[jira] [Reopened] (ISIS-1425) Fix support for publishing of wrapper calling programmatically instantiated mixin.
[
https://issues.apache.org/jira/browse/ISIS-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood reopened ISIS-1425:
---
communication channel and others failing, can't find the mixin. Need to
explore further. For now, revert to previous impl if unable to find (rather
than fail-fast).
> Fix support for publishing of wrapper calling programmatically instantiated
> mixin.
> --
>
> Key: ISIS-1425
> URL: https://issues.apache.org/jira/browse/ISIS-1425
> Project: Isis
> Issue Type: Improvement
> Components: Core
>Affects Versions: 1.12.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.13.0
>
>
> suppose we have a mixin:
> Touchable_touch
> whose action "$$" is published.
> What already works is that this will be published as an action "touch" on the
> mixed-in domain object.
> However, if we try to do this programmatically via the WrapperFactory, ie
> {code}
> wrapperFactory.wrap(factoryService.mixin(Touchable_touch.class,
> touchable)).$$();
> {code}
> then the target that is published is the (transient) mixin object itself,
> rather than the domain object.
> ~~~
> The fix is therefore to make the wrapper factory's wrapper proxy more
> intelligent, by invoking on the mixed-in action on the mixed-in domain
> object, rather than simply on the regular default action of the mixin
> (transient) object.
> If this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-1425) Fix support for publishing of wrapper calling programmatically instantiated mixin.
[
https://issues.apache.org/jira/browse/ISIS-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314553#comment-15314553
]
ASF subversion and git services commented on ISIS-1425:
---
Commit 964ab406680d62c24a8ae4153af96ab895ecffed in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=964ab40 ]
ISIS-1425: adding fallback to original behaviour if cannot locate the mixed-in
action
> Fix support for publishing of wrapper calling programmatically instantiated
> mixin.
> --
>
> Key: ISIS-1425
> URL: https://issues.apache.org/jira/browse/ISIS-1425
> Project: Isis
> Issue Type: Improvement
> Components: Core
>Affects Versions: 1.12.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.13.0
>
>
> suppose we have a mixin:
> Touchable_touch
> whose action "$$" is published.
> What already works is that this will be published as an action "touch" on the
> mixed-in domain object.
> However, if we try to do this programmatically via the WrapperFactory, ie
> {code}
> wrapperFactory.wrap(factoryService.mixin(Touchable_touch.class,
> touchable)).$$();
> {code}
> then the target that is published is the (transient) mixin object itself,
> rather than the domain object.
> ~~~
> The fix is therefore to make the wrapper factory's wrapper proxy more
> intelligent, by invoking on the mixed-in action on the mixed-in domain
> object, rather than simply on the regular default action of the mixin
> (transient) object.
> If this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (ISIS-1425) Fix support for publishing of wrapper calling programmatically instantiated mixin.
[
https://issues.apache.org/jira/browse/ISIS-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood resolved ISIS-1425.
---
Resolution: Fixed
> Fix support for publishing of wrapper calling programmatically instantiated
> mixin.
> --
>
> Key: ISIS-1425
> URL: https://issues.apache.org/jira/browse/ISIS-1425
> Project: Isis
> Issue Type: Improvement
> Components: Core
>Affects Versions: 1.12.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.13.0
>
>
> suppose we have a mixin:
> Touchable_touch
> whose action "$$" is published.
> What already works is that this will be published as an action "touch" on the
> mixed-in domain object.
> However, if we try to do this programmatically via the WrapperFactory, ie
> {code}
> wrapperFactory.wrap(factoryService.mixin(Touchable_touch.class,
> touchable)).$$();
> {code}
> then the target that is published is the (transient) mixin object itself,
> rather than the domain object.
> ~~~
> The fix is therefore to make the wrapper factory's wrapper proxy more
> intelligent, by invoking on the mixed-in action on the mixed-in domain
> object, rather than simply on the regular default action of the mixin
> (transient) object.
> If this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-1425) Fix support for publishing of wrapper calling programmatically instantiated mixin.
[
https://issues.apache.org/jira/browse/ISIS-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314476#comment-15314476
]
ASF subversion and git services commented on ISIS-1425:
---
Commit ffd9f08c9487d1c785d8ebd10fb99c0da3aa47fe in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ffd9f08 ]
ISIS-1425: making the wrapper factory intelligent enough to handle
(dereference) programmatically instantiated mixins
> Fix support for publishing of wrapper calling programmatically instantiated
> mixin.
> --
>
> Key: ISIS-1425
> URL: https://issues.apache.org/jira/browse/ISIS-1425
> Project: Isis
> Issue Type: Improvement
> Components: Core
>Affects Versions: 1.12.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.13.0
>
>
> suppose we have a mixin:
> Touchable_touch
> whose action "$$" is published.
> What already works is that this will be published as an action "touch" on the
> mixed-in domain object.
> However, if we try to do this programmatically via the WrapperFactory, ie
> {code}
> wrapperFactory.wrap(factoryService.mixin(Touchable_touch.class,
> touchable)).$$();
> {code}
> then the target that is published is the (transient) mixin object itself,
> rather than the domain object.
> ~~~
> The fix is therefore to make the wrapper factory's wrapper proxy more
> intelligent, by invoking on the mixed-in action on the mixed-in domain
> object, rather than simply on the regular default action of the mixin
> (transient) object.
> If this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (ISIS-1425) Fix support for publishing of wrapper calling programmatically instantiated mixin.
Dan Haywood created ISIS-1425:
-
Summary: Fix support for publishing of wrapper calling
programmatically instantiated mixin.
Key: ISIS-1425
URL: https://issues.apache.org/jira/browse/ISIS-1425
Project: Isis
Issue Type: Improvement
Components: Core
Affects Versions: 1.12.1
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: 1.13.0
suppose we have a mixin:
Touchable_touch
whose action "$$" is published.
What already works is that this will be published as an action "touch" on the
mixed-in domain object.
However, if we try to do this programmatically via the WrapperFactory, ie
{code}
wrapperFactory.wrap(factoryService.mixin(Touchable_touch.class,
touchable)).$$();
{code}
then the target that is published is the (transient) mixin object itself,
rather than the domain object.
~~~
The fix is therefore to make the wrapper factory's wrapper proxy more
intelligent, by invoking on the mixed-in action on the mixed-in domain object,
rather than simply on the regular default action of the mixin (transient)
object.
If this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (ISIS-1422) Autocomplete publishes events to the event bus.
[ https://issues.apache.org/jira/browse/ISIS-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-1422. --- Resolution: Fixed > Autocomplete publishes events to the event bus. > --- > > Key: ISIS-1422 > URL: https://issues.apache.org/jira/browse/ISIS-1422 > Project: Isis > Issue Type: Bug >Affects Versions: 1.12.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[VOTE] Apache Isis Core release 1.12.2 RC1
I've cut a release for Apache Isis Core and the simpleapp archetype: * Core 1.12.2 * SimpleApp Archetype 1.12.2 The source code artifacts have been uploaded to staging repositories on repository.apache.org: * http://repository.apache.org/content/repositories/orgapacheisis-1048/org/apache/isis/core/isis/1.12.2/isis-1.12.2-source-release.zip * http://repository.apache.org/content/repositories/orgapacheisis-1048/org/apache/isis/archetype/simpleapp-archetype/1.12.2/simpleapp-archetype-1.12.2-source-release.zip For each zip there is a corresponding signature file (append .asc to the zip's url). In the source code repo the code has been tagged as isis-1.12.2-RC1 and simpleapp-archetype-1.12.2-RC1; see https://git-wip-us.apache.org/repos/asf?p=isis.git For instructions on how to verify the release (build from binaries and/or use in Maven directly), see http://isis.apache.org/guides/cgcom.html#_cgcom_verifying-releases Please verify the release and cast your vote. The vote will be open for a minimum of 72 hours. [ ] +1 [ ] 0 [ ] -1
[jira] [Commented] (ISIS-1424) Release activities for v1.12.2
[ https://issues.apache.org/jira/browse/ISIS-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314317#comment-15314317 ] ASF subversion and git services commented on ISIS-1424: --- Commit 46d4527a1be3f74c00eba71acce9e24ab395d3ac in isis's branch refs/heads/release-1.12.2-RC1 from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=46d4527 ] ISIS-1424: update to example app pom.xml to reference 1.12.2 > Release activities for v1.12.2 > -- > > Key: ISIS-1424 > URL: https://issues.apache.org/jira/browse/ISIS-1424 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.12.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.12.2 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1424) Release activities for v1.12.2
[ https://issues.apache.org/jira/browse/ISIS-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314316#comment-15314316 ] ASF subversion and git services commented on ISIS-1424: --- Commit 008347450f0f608d3d5275311e4e1b5c93b7ade7 in isis's branch refs/heads/release-1.12.2-RC1 from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0083474 ] ISIS-1424: recreating simpleapp archetype > Release activities for v1.12.2 > -- > > Key: ISIS-1424 > URL: https://issues.apache.org/jira/browse/ISIS-1424 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.12.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.12.2 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1422) Autocomplete publishes events to the event bus.
[ https://issues.apache.org/jira/browse/ISIS-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314310#comment-15314310 ] ASF subversion and git services commented on ISIS-1422: --- Commit 28bd6dd52f37ace0bf10f97f0af7af8b9132f1f6 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=28bd6dd ] ISIS-1422: refactoring (no functional change) - completely eliminated ValueSemanticsProviderContext, just use ServicesInjector throughout, and don't pass IsisConfiguration to VSP either, since derivable from ServicesInjector. Also: - made ConfigurationServiceInternal extend from IsisConfiguration (IsisConfigurationDefault is the only impl anyway) - removed unnecessary casts to IsisConfiguration - removed components passed into AutoCompleteFacetAbstract, since all derivable from ServicesInjector. > Autocomplete publishes events to the event bus. > --- > > Key: ISIS-1422 > URL: https://issues.apache.org/jira/browse/ISIS-1422 > Project: Isis > Issue Type: Bug >Affects Versions: 1.12.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1335) Release activities for v1.13.0
[ https://issues.apache.org/jira/browse/ISIS-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314314#comment-15314314 ] ASF subversion and git services commented on ISIS-1335: --- Commit 5522f4bd512b2c7d6c98dd6f3c9948329e7f3660 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=5522f4b ] ISIS-1335: adding missing/updating existing layout.xml files for applib view models. > Release activities for v1.13.0 > -- > > Key: ISIS-1335 > URL: https://issues.apache.org/jira/browse/ISIS-1335 > Project: Isis > Issue Type: Task > Components: Core >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.0 > > > Miscellaneous release activities for 1.12.0 release. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1422) Autocomplete publishes events to the event bus.
[ https://issues.apache.org/jira/browse/ISIS-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314312#comment-15314312 ] ASF subversion and git services commented on ISIS-1422: --- Commit 0f5508038f7090bb3c1eed5a9e7fb09aa02e6311 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0f55080 ] ISIS-1422: fixing unit tests. > Autocomplete publishes events to the event bus. > --- > > Key: ISIS-1422 > URL: https://issues.apache.org/jira/browse/ISIS-1422 > Project: Isis > Issue Type: Bug >Affects Versions: 1.12.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1422) Autocomplete publishes events to the event bus.
[ https://issues.apache.org/jira/browse/ISIS-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314313#comment-15314313 ] ASF subversion and git services commented on ISIS-1422: --- Commit a322518276504ab788b46a7a777b30230727f909 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a322518 ] ISIS-1422: use PublishingServiceInternal's withPublishingSuppressed wormhole to stop publishing when invoke an action for autoComplete. > Autocomplete publishes events to the event bus. > --- > > Key: ISIS-1422 > URL: https://issues.apache.org/jira/browse/ISIS-1422 > Project: Isis > Issue Type: Bug >Affects Versions: 1.12.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1422) Autocomplete publishes events to the event bus.
[ https://issues.apache.org/jira/browse/ISIS-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314311#comment-15314311 ] ASF subversion and git services commented on ISIS-1422: --- Commit 935a5d947149544e3c15b44291676d0fa46eeed8 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=935a5d9 ] ISIS-1422: refactoring (no functional change) - looking up components from ServicesInjector rather than pass them in. for misc facets (ActionInvocationFacet, MaxLengthFacet, Encodable, RegEx, MultiLine) > Autocomplete publishes events to the event bus. > --- > > Key: ISIS-1422 > URL: https://issues.apache.org/jira/browse/ISIS-1422 > Project: Isis > Issue Type: Bug >Affects Versions: 1.12.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1396) Some elements on an entity page can be rendered against stale data.
[ https://issues.apache.org/jira/browse/ISIS-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314100#comment-15314100 ] ASF subversion and git services commented on ISIS-1396: --- Commit da3f1ecee896c88559019e98b863f0d062980798 in isis's branch refs/heads/maintenance-1.12.x from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=da3f1ec ] ISIS-1396: detaching an EntityModel should cascade the detach to all child property ScalarModels. > Some elements on an entity page can be rendered against stale data. > --- > > Key: ISIS-1396 > URL: https://issues.apache.org/jira/browse/ISIS-1396 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 1.12.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.12.2 > > > In the contactapp (github.com/incodehq/contactapp), if edit a ContactGroup, > then the Country title/icon are shown as null. This seems to be because they > are being rendered against a stale version of the ContactGroup, ie after the > JDO transaction has completed. > Two different fixes. > The first would seem to be to move the stuff that builds the EntityPage > component hierarchy out of the EntityPage constructor and into the > EntityPage's onBeforeRender() method. > This works, but does solve the underlying issue. Talking with martin-g, he > says this ought not to be necessary and pointed to a possible issue with the > EntityModel (impl of LoadableDetachableModel). > Further investigation shows that this is indeed where the issue is. > EntityModel holds a lazily-populated cache of ScalarModels, keyed by > property(Id). This is not cleared down on detach, meaning that a subsequent > rendering of the property containing the reference to the country is using a > stale ObjectAdapter (never detached) that refers to a pojo that was reset at > the end of the preceding transaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1132) possible timezone issues when refresh page in Wicket viewer.
[ https://issues.apache.org/jira/browse/ISIS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314105#comment-15314105 ] ASF subversion and git services commented on ISIS-1132: --- Commit adcbcf8140a4ccc52e9ab46e4a31be4f17ac4aaa in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=adcbcf8 ] ISIS-1132: finally, the fix... the (legacy) Isis encoder/decoder stuff is used to copy the value from the object into the action parameter; the impl for joda DateTime was missing the time portion, so was defaulting to +1:00 (presumably due to locale, GMT+1 hour). > possible timezone issues when refresh page in Wicket viewer. > > > Key: ISIS-1132 > URL: https://issues.apache.org/jira/browse/ISIS-1132 > Project: Isis > Issue Type: Bug > Components: Core: Viewer: Wicket >Affects Versions: core-1.8.0 >Reporter: Boris Toninski >Assignee: Dan Haywood > Fix For: 1.12.2 > > > The issue is reproducible in the latest kitchensink demo application which > uses Isis 1.8.0. > When a form page is opened and the URL in the browser is like - > ".../wicket/entity?15" and the page is refreshed, following happens: > - All "org.joda.time.DateTime" fields are changed, so they have "03:00" at > the end. (ex. It was ...00:00 and becomes ...03:00) > - The splitters in the menus disappear. > I suppose there can be some other issues too. > The URL becomes like ".../wicket/entity?15" after a form is edited or if you > click for example on the "First DateObject" menu item in kitchensink app. If > the URL is like ".../wicket/entity/DATE:L_0" it works normally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1132) possible timezone issues when refresh page in Wicket viewer.
[ https://issues.apache.org/jira/browse/ISIS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314103#comment-15314103 ] ASF subversion and git services commented on ISIS-1132: --- Commit eb90e2991de4355db481224d717a7c8de4ae688c in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=eb90e29 ] ISIS-1132: refactoring (no functional changes) ... rationalized and simplified the DataConverterForJoda hierarchy of classes. > possible timezone issues when refresh page in Wicket viewer. > > > Key: ISIS-1132 > URL: https://issues.apache.org/jira/browse/ISIS-1132 > Project: Isis > Issue Type: Bug > Components: Core: Viewer: Wicket >Affects Versions: core-1.8.0 >Reporter: Boris Toninski >Assignee: Dan Haywood > Fix For: 1.12.2 > > > The issue is reproducible in the latest kitchensink demo application which > uses Isis 1.8.0. > When a form page is opened and the URL in the browser is like - > ".../wicket/entity?15" and the page is refreshed, following happens: > - All "org.joda.time.DateTime" fields are changed, so they have "03:00" at > the end. (ex. It was ...00:00 and becomes ...03:00) > - The splitters in the menus disappear. > I suppose there can be some other issues too. > The URL becomes like ".../wicket/entity?15" after a form is edited or if you > click for example on the "First DateObject" menu item in kitchensink app. If > the URL is like ".../wicket/entity/DATE:L_0" it works normally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1132) possible timezone issues when refresh page in Wicket viewer.
[ https://issues.apache.org/jira/browse/ISIS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314102#comment-15314102 ] ASF subversion and git services commented on ISIS-1132: --- Commit a2197cd52e2feac31bb54dec95193181ec058a36 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=a2197cd ] ISIS-1132: refactoring (no functional changes) in order to understand current design better. It seems that the datepicker pattern is not actually used; instead we read either the datePattern or the dateTimePattern and - if there is the picker for the component - then convert the format to moment.js format (as used by the bootstrap3 cpt we are using) on-the-fly. > possible timezone issues when refresh page in Wicket viewer. > > > Key: ISIS-1132 > URL: https://issues.apache.org/jira/browse/ISIS-1132 > Project: Isis > Issue Type: Bug > Components: Core: Viewer: Wicket >Affects Versions: core-1.8.0 >Reporter: Boris Toninski >Assignee: Dan Haywood > Fix For: 1.12.2 > > > The issue is reproducible in the latest kitchensink demo application which > uses Isis 1.8.0. > When a form page is opened and the URL in the browser is like - > ".../wicket/entity?15" and the page is refreshed, following happens: > - All "org.joda.time.DateTime" fields are changed, so they have "03:00" at > the end. (ex. It was ...00:00 and becomes ...03:00) > - The splitters in the menus disappear. > I suppose there can be some other issues too. > The URL becomes like ".../wicket/entity?15" after a form is edited or if you > click for example on the "First DateObject" menu item in kitchensink app. If > the URL is like ".../wicket/entity/DATE:L_0" it works normally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1132) possible timezone issues when refresh page in Wicket viewer.
[ https://issues.apache.org/jira/browse/ISIS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314101#comment-15314101 ] ASF subversion and git services commented on ISIS-1132: --- Commit 1dd64e618aebb85669ac8ceeed8deefc89c25c34 in isis's branch refs/heads/maintenance-1.12.x from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1dd64e6 ] ISIS-1132: finally, the fix... the (legacy) Isis encoder/decoder stuff is used to copy the value from the object into the action parameter; the impl for joda DateTime was missing the time portion, so was defaulting to +1:00 (presumably due to locale, GMT+1 hour). > possible timezone issues when refresh page in Wicket viewer. > > > Key: ISIS-1132 > URL: https://issues.apache.org/jira/browse/ISIS-1132 > Project: Isis > Issue Type: Bug > Components: Core: Viewer: Wicket >Affects Versions: core-1.8.0 >Reporter: Boris Toninski >Assignee: Dan Haywood > Fix For: 1.12.2 > > > The issue is reproducible in the latest kitchensink demo application which > uses Isis 1.8.0. > When a form page is opened and the URL in the browser is like - > ".../wicket/entity?15" and the page is refreshed, following happens: > - All "org.joda.time.DateTime" fields are changed, so they have "03:00" at > the end. (ex. It was ...00:00 and becomes ...03:00) > - The splitters in the menus disappear. > I suppose there can be some other issues too. > The URL becomes like ".../wicket/entity?15" after a form is edited or if you > click for example on the "First DateObject" menu item in kitchensink app. If > the URL is like ".../wicket/entity/DATE:L_0" it works normally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1132) possible timezone issues when refresh page in Wicket viewer.
[ https://issues.apache.org/jira/browse/ISIS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314104#comment-15314104 ] ASF subversion and git services commented on ISIS-1132: --- Commit b332a8bd9e3c5a7ccd16ecccbb3e14342b6d04c2 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=b332a8b ] ISIS-1132: further refactoring (no functional change) - showing how the bootstrap datetime config is built from the converter's dateTime pattern. > possible timezone issues when refresh page in Wicket viewer. > > > Key: ISIS-1132 > URL: https://issues.apache.org/jira/browse/ISIS-1132 > Project: Isis > Issue Type: Bug > Components: Core: Viewer: Wicket >Affects Versions: core-1.8.0 >Reporter: Boris Toninski >Assignee: Dan Haywood > Fix For: 1.12.2 > > > The issue is reproducible in the latest kitchensink demo application which > uses Isis 1.8.0. > When a form page is opened and the URL in the browser is like - > ".../wicket/entity?15" and the page is refreshed, following happens: > - All "org.joda.time.DateTime" fields are changed, so they have "03:00" at > the end. (ex. It was ...00:00 and becomes ...03:00) > - The splitters in the menus disappear. > I suppose there can be some other issues too. > The URL becomes like ".../wicket/entity?15" after a form is edited or if you > click for example on the "First DateObject" menu item in kitchensink app. If > the URL is like ".../wicket/entity/DATE:L_0" it works normally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1132) possible timezone issues when refresh page in Wicket viewer.
[ https://issues.apache.org/jira/browse/ISIS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314107#comment-15314107 ] ASF subversion and git services commented on ISIS-1132: --- Commit 1dd64e618aebb85669ac8ceeed8deefc89c25c34 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1dd64e6 ] ISIS-1132: finally, the fix... the (legacy) Isis encoder/decoder stuff is used to copy the value from the object into the action parameter; the impl for joda DateTime was missing the time portion, so was defaulting to +1:00 (presumably due to locale, GMT+1 hour). > possible timezone issues when refresh page in Wicket viewer. > > > Key: ISIS-1132 > URL: https://issues.apache.org/jira/browse/ISIS-1132 > Project: Isis > Issue Type: Bug > Components: Core: Viewer: Wicket >Affects Versions: core-1.8.0 >Reporter: Boris Toninski >Assignee: Dan Haywood > Fix For: 1.12.2 > > > The issue is reproducible in the latest kitchensink demo application which > uses Isis 1.8.0. > When a form page is opened and the URL in the browser is like - > ".../wicket/entity?15" and the page is refreshed, following happens: > - All "org.joda.time.DateTime" fields are changed, so they have "03:00" at > the end. (ex. It was ...00:00 and becomes ...03:00) > - The splitters in the menus disappear. > I suppose there can be some other issues too. > The URL becomes like ".../wicket/entity?15" after a form is edited or if you > click for example on the "First DateObject" menu item in kitchensink app. If > the URL is like ".../wicket/entity/DATE:L_0" it works normally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1396) Some elements on an entity page can be rendered against stale data.
[ https://issues.apache.org/jira/browse/ISIS-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314106#comment-15314106 ] ASF subversion and git services commented on ISIS-1396: --- Commit da3f1ecee896c88559019e98b863f0d062980798 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=da3f1ec ] ISIS-1396: detaching an EntityModel should cascade the detach to all child property ScalarModels. > Some elements on an entity page can be rendered against stale data. > --- > > Key: ISIS-1396 > URL: https://issues.apache.org/jira/browse/ISIS-1396 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 1.12.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.12.2 > > > In the contactapp (github.com/incodehq/contactapp), if edit a ContactGroup, > then the Country title/icon are shown as null. This seems to be because they > are being rendered against a stale version of the ContactGroup, ie after the > JDO transaction has completed. > Two different fixes. > The first would seem to be to move the stuff that builds the EntityPage > component hierarchy out of the EntityPage constructor and into the > EntityPage's onBeforeRender() method. > This works, but does solve the underlying issue. Talking with martin-g, he > says this ought not to be necessary and pointed to a possible issue with the > EntityModel (impl of LoadableDetachableModel). > Further investigation shows that this is indeed where the issue is. > EntityModel holds a lazily-populated cache of ScalarModels, keyed by > property(Id). This is not cleared down on detach, meaning that a subsequent > rendering of the property containing the reference to the country is using a > stale ObjectAdapter (never detached) that refers to a pojo that was reset at > the end of the preceding transaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ISIS-1303) Rename the project to better describe its values and purpose
[ https://issues.apache.org/jira/browse/ISIS-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314047#comment-15314047 ] Dan Haywood edited comment on ISIS-1303 at 6/3/16 12:40 PM: Just to say, haven't forgotten about this ticket/initiative. If anyone wants to do the trademark searches for their favorite, and update the wiki page (https://cwiki.apache.org/confluence/display/ISIS/Name+ideas), that would be peachy. Meantime, I have one further suggestion, namely *"Apache Tailor"*. Why? because we're about building bespoke/custom systems that fit the business (compare to an off-the-peg system where the business has to bend/be constrained by that package software). This is directly tackling the "build vs buy" argument, which is one of the most fundamental questions that needs to be answered. And "tailoring" is a metaphor that non-technical people can readily understand. was (Author: danhaywood): Just to say, haven't forgotten about this ticket/initiative. If anyone wants to do the trademark searches for their favorite, and update the wiki page (https://cwiki.apache.org/confluence/display/ISIS/Name+ideas), that would be peachy. Meantime, I have one further suggestion, namely "Apache Tailor". Why? because we're about building bespoke/custom systems that fit the business (compare to an off-the-peg system where the business has to bend/be constrained by that package software). This is directly tackling the "build vs buy" argument, which is one of the most fundamental questions that needs to be answered. And "tailoring" is a metaphor that non-technical people can readily understand. > Rename the project to better describe its values and purpose > > > Key: ISIS-1303 > URL: https://issues.apache.org/jira/browse/ISIS-1303 > Project: Isis > Issue Type: Wish >Affects Versions: 1.11.1 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: 1.15.0 > > Attachments: ApacheFarthing.jpg, ApacheFarthing.jpg, > ApacheGestalt.jpg, Offset-curves-of-sinus-curve.svg > > > In the past there have been a couple of discussions regarding renaming the > project, the reason generally cited being the potential embarrassment of > sharing a name with the jihadist militant group [1] currently prominent in > the headlines. After due discussion on the mailing lists the prevailing view > has been to retain our name: "we were here first". > Until now I've concurred with that view also... after all, I originally came > up with the name "Isis", originally based on the name of the Thames as it > flows through Oxford [2] (many of the original authors of the framework live > within Oxfordshire, UK). > Separately to that discussion, we have the issue of marketing. Originally we > marketed ourselves as a framework implementing the "naked objects" pattern > [3]; the original name of the framework (prior to Apache) was of course the > Naked Objects Framework. However, this pattern is either not well-known or > is misunderstood (only a low proportion of developers that encounter the idea > immediately "get it"). The crudity of the original user interfaces didn't > help. And the name also, of course, can cause embarrassment in some cultures. > Then, when domain-driven design [4] came along as a movement, that seemed an > obvious platform upon which to position the framework: we obviously share the > core belief that the domain is the most important bit of the system. However > - and I still find this surprising - despite attempts otherwise we haven't > really made too much of an impression in that community. The fact that the > DDD community got massively sidetracked for a while by the CQRS pattern is > perhaps part of it. I also often detect the view that DDD should imply not > using a framework. The irony of course is that in rejecting framework such > developers actually have to write more infrastructure code vs business domain > code. > Also, the fit is perhaps not all that good after all. In the DDD community I > don't see anyone talking about modules... one of the named patterns, and a > major focus of our framework, but missing from DDD talks. Instead they get > side-tracked talking only about aggregate roots or bounded contexts; all well > and good, but over-emphasised). > [Aside: Indeed, I raised the topic of modules with Eric Evans himself (in > person), and he agreed there was little emphasis. When I described our > framework's use of domain events to hook modules together (along with vetoing > behaviour we support) he admitted it was a new approach/pattern to him...] > Anyway, so DDD - which looked so promising - hasn't delivered. They might > come around to us one day, but it's probably time to define our own >
[jira] [Commented] (ISIS-1303) Rename the project to better describe its values and purpose
[ https://issues.apache.org/jira/browse/ISIS-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314047#comment-15314047 ] Dan Haywood commented on ISIS-1303: --- Just to say, haven't forgotten about this ticket/initiative. If anyone wants to do the trademark searches for their favorite, and update the wiki page (https://cwiki.apache.org/confluence/display/ISIS/Name+ideas), that would be peachy. Meantime, I have one further suggestion, namely "Apache Tailor". Why? because we're about building bespoke/custom systems that fit the business (compare to an off-the-peg system where the business has to bend/be constrained by that package software). This is directly tackling the "build vs buy" argument, which is one of the most fundamental questions that needs to be answered. And "tailoring" is a metaphor that non-technical people can readily understand. > Rename the project to better describe its values and purpose > > > Key: ISIS-1303 > URL: https://issues.apache.org/jira/browse/ISIS-1303 > Project: Isis > Issue Type: Wish >Affects Versions: 1.11.1 >Reporter: Dan Haywood >Assignee: Dan Haywood > Fix For: 1.15.0 > > Attachments: ApacheFarthing.jpg, ApacheFarthing.jpg, > ApacheGestalt.jpg, Offset-curves-of-sinus-curve.svg > > > In the past there have been a couple of discussions regarding renaming the > project, the reason generally cited being the potential embarrassment of > sharing a name with the jihadist militant group [1] currently prominent in > the headlines. After due discussion on the mailing lists the prevailing view > has been to retain our name: "we were here first". > Until now I've concurred with that view also... after all, I originally came > up with the name "Isis", originally based on the name of the Thames as it > flows through Oxford [2] (many of the original authors of the framework live > within Oxfordshire, UK). > Separately to that discussion, we have the issue of marketing. Originally we > marketed ourselves as a framework implementing the "naked objects" pattern > [3]; the original name of the framework (prior to Apache) was of course the > Naked Objects Framework. However, this pattern is either not well-known or > is misunderstood (only a low proportion of developers that encounter the idea > immediately "get it"). The crudity of the original user interfaces didn't > help. And the name also, of course, can cause embarrassment in some cultures. > Then, when domain-driven design [4] came along as a movement, that seemed an > obvious platform upon which to position the framework: we obviously share the > core belief that the domain is the most important bit of the system. However > - and I still find this surprising - despite attempts otherwise we haven't > really made too much of an impression in that community. The fact that the > DDD community got massively sidetracked for a while by the CQRS pattern is > perhaps part of it. I also often detect the view that DDD should imply not > using a framework. The irony of course is that in rejecting framework such > developers actually have to write more infrastructure code vs business domain > code. > Also, the fit is perhaps not all that good after all. In the DDD community I > don't see anyone talking about modules... one of the named patterns, and a > major focus of our framework, but missing from DDD talks. Instead they get > side-tracked talking only about aggregate roots or bounded contexts; all well > and good, but over-emphasised). > [Aside: Indeed, I raised the topic of modules with Eric Evans himself (in > person), and he agreed there was little emphasis. When I described our > framework's use of domain events to hook modules together (along with vetoing > behaviour we support) he admitted it was a new approach/pattern to him...] > Anyway, so DDD - which looked so promising - hasn't delivered. They might > come around to us one day, but it's probably time to define our own > individual space. Also, in the same way that everyone takes agile > development for granted as the "de facto", we ought to simply take DDD for > granted too... "of course you will be doing DDD, but are you doing it well?" > What we need to better market the framework is some other pattern or concept > or hook, and become known as the framework that best supports that idea. > There are several candidates: > - hexagonal architecture (also called ports and adapters, or the onion > architecture, and related to the clean architecture) > - don't repeat yourself principle > - aspect oriented programming (naked objects pattern is really the > recognition that UI presentation is a cross-cutting concern) > - the general concept of modularity > - DCI (data/context/interactions). >
[jira] [Resolved] (ISIS-1132) possible timezone issues when refresh page in Wicket viewer.
[ https://issues.apache.org/jira/browse/ISIS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-1132. --- Resolution: Fixed > possible timezone issues when refresh page in Wicket viewer. > > > Key: ISIS-1132 > URL: https://issues.apache.org/jira/browse/ISIS-1132 > Project: Isis > Issue Type: Bug > Components: Core: Viewer: Wicket >Affects Versions: core-1.8.0 >Reporter: Boris Toninski >Assignee: Dan Haywood > Fix For: 1.12.2 > > > The issue is reproducible in the latest kitchensink demo application which > uses Isis 1.8.0. > When a form page is opened and the URL in the browser is like - > ".../wicket/entity?15" and the page is refreshed, following happens: > - All "org.joda.time.DateTime" fields are changed, so they have "03:00" at > the end. (ex. It was ...00:00 and becomes ...03:00) > - The splitters in the menus disappear. > I suppose there can be some other issues too. > The URL becomes like ".../wicket/entity?15" after a form is edited or if you > click for example on the "First DateObject" menu item in kitchensink app. If > the URL is like ".../wicket/entity/DATE:L_0" it works normally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-1132) possible timezone issues when refresh page in Wicket viewer.
[ https://issues.apache.org/jira/browse/ISIS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1132: -- Fix Version/s: (was: 1.13.0) 1.12.2 > possible timezone issues when refresh page in Wicket viewer. > > > Key: ISIS-1132 > URL: https://issues.apache.org/jira/browse/ISIS-1132 > Project: Isis > Issue Type: Bug > Components: Core: Viewer: Wicket >Affects Versions: core-1.8.0 >Reporter: Boris Toninski >Assignee: Dan Haywood > Fix For: 1.12.2 > > > The issue is reproducible in the latest kitchensink demo application which > uses Isis 1.8.0. > When a form page is opened and the URL in the browser is like - > ".../wicket/entity?15" and the page is refreshed, following happens: > - All "org.joda.time.DateTime" fields are changed, so they have "03:00" at > the end. (ex. It was ...00:00 and becomes ...03:00) > - The splitters in the menus disappear. > I suppose there can be some other issues too. > The URL becomes like ".../wicket/entity?15" after a form is edited or if you > click for example on the "First DateObject" menu item in kitchensink app. If > the URL is like ".../wicket/entity/DATE:L_0" it works normally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ISIS-1424) Release activities for v1.12.2
Dan Haywood created ISIS-1424: - Summary: Release activities for v1.12.2 Key: ISIS-1424 URL: https://issues.apache.org/jira/browse/ISIS-1424 Project: Isis Issue Type: Task Components: Core Affects Versions: 1.12.1 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: 1.12.2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-1396) Some elements on an entity page can be rendered against stale data.
[ https://issues.apache.org/jira/browse/ISIS-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1396: -- Fix Version/s: (was: 1.13.0) 1.12.2 > Some elements on an entity page can be rendered against stale data. > --- > > Key: ISIS-1396 > URL: https://issues.apache.org/jira/browse/ISIS-1396 > Project: Isis > Issue Type: Bug > Components: Core >Affects Versions: 1.12.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.12.2 > > > In the contactapp (github.com/incodehq/contactapp), if edit a ContactGroup, > then the Country title/icon are shown as null. This seems to be because they > are being rendered against a stale version of the ContactGroup, ie after the > JDO transaction has completed. > Two different fixes. > The first would seem to be to move the stuff that builds the EntityPage > component hierarchy out of the EntityPage constructor and into the > EntityPage's onBeforeRender() method. > This works, but does solve the underlying issue. Talking with martin-g, he > says this ought not to be necessary and pointed to a possible issue with the > EntityModel (impl of LoadableDetachableModel). > Further investigation shows that this is indeed where the issue is. > EntityModel holds a lazily-populated cache of ScalarModels, keyed by > property(Id). This is not cleared down on detach, meaning that a subsequent > rendering of the property containing the reference to the country is using a > stale ObjectAdapter (never detached) that refers to a pojo that was reset at > the end of the preceding transaction. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-1132) possible timezone issues when refresh page in Wicket viewer.
[ https://issues.apache.org/jira/browse/ISIS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1132: -- Assignee: Dan Haywood (was: Martin Grigorov) > possible timezone issues when refresh page in Wicket viewer. > > > Key: ISIS-1132 > URL: https://issues.apache.org/jira/browse/ISIS-1132 > Project: Isis > Issue Type: Bug > Components: Core: Viewer: Wicket >Affects Versions: core-1.8.0 >Reporter: Boris Toninski >Assignee: Dan Haywood > Fix For: 1.13.0 > > > The issue is reproducible in the latest kitchensink demo application which > uses Isis 1.8.0. > When a form page is opened and the URL in the browser is like - > ".../wicket/entity?15" and the page is refreshed, following happens: > - All "org.joda.time.DateTime" fields are changed, so they have "03:00" at > the end. (ex. It was ...00:00 and becomes ...03:00) > - The splitters in the menus disappear. > I suppose there can be some other issues too. > The URL becomes like ".../wicket/entity?15" after a form is edited or if you > click for example on the "First DateObject" menu item in kitchensink app. If > the URL is like ".../wicket/entity/DATE:L_0" it works normally. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ISIS-1417) For faster start-ups, allow any deprecated facets to simply be ignored.
[ https://issues.apache.org/jira/browse/ISIS-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-1417. --- Resolution: Fixed > For faster start-ups, allow any deprecated facets to simply be ignored. > --- > > Key: ISIS-1417 > URL: https://issues.apache.org/jira/browse/ISIS-1417 > Project: Isis > Issue Type: Improvement > Components: Core >Affects Versions: 1.12.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.0 > > > ... using a configuration setting, "isis.reflector.facets.ignoreDeprecated" > The default should be false, in other words that deprecated facets continue > to be honoured. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-1423) TranslationServicePo does not guard against null keys.
[ https://issues.apache.org/jira/browse/ISIS-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1423: -- Attachment: screenshot-1.png > TranslationServicePo does not guard against null keys. > -- > > Key: ISIS-1423 > URL: https://issues.apache.org/jira/browse/ISIS-1423 > Project: Isis > Issue Type: Bug >Affects Versions: 1.12.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.0 > > Attachments: screenshot-1.png > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ISIS-1423) TranslationServicePo does not guard against null keys.
Dan Haywood created ISIS-1423: - Summary: TranslationServicePo does not guard against null keys. Key: ISIS-1423 URL: https://issues.apache.org/jira/browse/ISIS-1423 Project: Isis Issue Type: Bug Affects Versions: 1.12.1 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: 1.13.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1422) Autocomplete publishes events to the event bus.
[ https://issues.apache.org/jira/browse/ISIS-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313786#comment-15313786 ] Dan Haywood commented on ISIS-1422: --- After annotating with @Action(semantics=Semantics.SAFE) it is fixed. Question is would we exclude autocomplete altogether or should we annotate with @Action(semantics=Semantics.SAFE) > Autocomplete publishes events to the event bus. > --- > > Key: ISIS-1422 > URL: https://issues.apache.org/jira/browse/ISIS-1422 > Project: Isis > Issue Type: Bug >Affects Versions: 1.12.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ISIS-1422) Autocomplete publishes events to the event bus.
Dan Haywood created ISIS-1422: - Summary: Autocomplete publishes events to the event bus. Key: ISIS-1422 URL: https://issues.apache.org/jira/browse/ISIS-1422 Project: Isis Issue Type: Bug Affects Versions: 1.12.1 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: 1.13.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
