[jira] [Commented] (ISIS-1538) Rework simpleapp archetype so that is more modular.
[ https://issues.apache.org/jira/browse/ISIS-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712092#comment-15712092 ] ASF subversion and git services commented on ISIS-1538: --- Commit fa36da4a486d24c72b78c5a3ee812d9c228156ac in isis's branch refs/heads/maint-1.13.2 from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fa36da4 ] ISIS-1538: recreating simpleapp archetype > Rework simpleapp archetype so that is more modular. > --- > > Key: ISIS-1538 > URL: https://issues.apache.org/jira/browse/ISIS-1538 > Project: Isis > Issue Type: Improvement > Components: Archetype: SimpleApp >Affects Versions: 1.13.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.2 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1548) Allow @Mixin annotation to specify the method name to use (instead of '$$') meaning to infer the mixin name from the mixin type. Also, allow '$' to be used as separator
[
https://issues.apache.org/jira/browse/ISIS-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712091#comment-15712091
]
ASF subversion and git services commented on ISIS-1548:
---
Commit 147f4c5d4a4eb7541b06a628b7d666bc5169c4f5 in isis's branch
refs/heads/maint-1.13.2 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=147f4c5 ]
ISIS-1548: extends @Mixin and @DomainObject to accept (mixin)method()
attribute; updates facets; updates algorithm for inferring mixin name/id based
on when the name of the method being processed matches this attribute (rather
than hard-coded "$$" as previously).
Also, supports using "$" (as well as "_") as the separator for
MixinType_mixinName (ie for nested static classes).
Most of the stuff in ObjectMemberAbstract, plus the three Mixin classes,
ObjectActionMixedIn, OneToOneAssociationMixedIn, OneToManyAssociationMixedIn.
> Allow @Mixin annotation to specify the method name to use (instead of '$$')
> meaning to infer the mixin name from the mixin type. Also, allow '$' to be
> used as separator of the mixin type.
>
>
> Key: ISIS-1548
> URL: https://issues.apache.org/jira/browse/ISIS-1548
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.13.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.13.2
>
>
> The current mixin conventions gives rise to code such as:
> {code}
> mixin(Invoice._approve.class, invoice).$$();
> {code}
> where:
> {code}
> public class Invoice {
> ...
> @Mixin
> public static class _approve {
> ...
> public Invoice $$() { ... }
> }
> }
> {code}
> We'd like it instead to read:
> {code}
> mixin(Invoice.Approve.class, invoice).exec();
> {code}
> ie:
> * change "$$" to "exec" (or any other verb)
> * not require the leading "_" in the mixin name
> * allow the class to be capitalized
> Suggestion is:
> {code}
> public class Invoice {
> ...
> @Mixin(method="exec")
> public static class Approve {
> public void exec() { ... }
> }
> }
> {code}
> or (if using `@DomainObject`)
> {code}
> public class Invoice {
> ...
> @DomainObject(nature=MIXIN, mixinMethod="exec")
> public static class Approve {
> public void exec() { ... }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-1503) Allow security checking be disabled when running via SudoService.
[ https://issues.apache.org/jira/browse/ISIS-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711669#comment-15711669 ] ASF subversion and git services commented on ISIS-1503: --- Commit f057d29d883ea6ca9dd49e9bb8070b8676d81b0f in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f057d29 ] ISIS-1503 and ISIS-1548: further documentation updates for these tickets (@Mixin, @DomainObject, UserService, AuthenticationSessionProvider, SudoService) > Allow security checking be disabled when running via SudoService. > - > > Key: ISIS-1503 > URL: https://issues.apache.org/jira/browse/ISIS-1503 > Project: Isis > Issue Type: Improvement > Components: Core >Affects Versions: 1.13.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.2 > > > ... to provide the ability to run fixture scripts that use the wrapper > factory from contexts where there is no current user, in particular during > UserRegistration. > The AuthenticationSessionProvider (internal) service should also report the > current user/roles (as well as UserService) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1548) Allow @Mixin annotation to specify the method name to use (instead of '$$') meaning to infer the mixin name from the mixin type. Also, allow '$' to be used as separator
[
https://issues.apache.org/jira/browse/ISIS-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711670#comment-15711670
]
ASF subversion and git services commented on ISIS-1548:
---
Commit f057d29d883ea6ca9dd49e9bb8070b8676d81b0f in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f057d29 ]
ISIS-1503 and ISIS-1548: further documentation updates for these tickets
(@Mixin, @DomainObject, UserService, AuthenticationSessionProvider, SudoService)
> Allow @Mixin annotation to specify the method name to use (instead of '$$')
> meaning to infer the mixin name from the mixin type. Also, allow '$' to be
> used as separator of the mixin type.
>
>
> Key: ISIS-1548
> URL: https://issues.apache.org/jira/browse/ISIS-1548
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.13.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.13.2
>
>
> The current mixin conventions gives rise to code such as:
> {code}
> mixin(Invoice._approve.class, invoice).$$();
> {code}
> where:
> {code}
> public class Invoice {
> ...
> @Mixin
> public static class _approve {
> ...
> public Invoice $$() { ... }
> }
> }
> {code}
> We'd like it instead to read:
> {code}
> mixin(Invoice.Approve.class, invoice).exec();
> {code}
> ie:
> * change "$$" to "exec" (or any other verb)
> * not require the leading "_" in the mixin name
> * allow the class to be capitalized
> Suggestion is:
> {code}
> public class Invoice {
> ...
> @Mixin(method="exec")
> public static class Approve {
> public void exec() { ... }
> }
> }
> {code}
> or (if using `@DomainObject`)
> {code}
> public class Invoice {
> ...
> @DomainObject(nature=MIXIN, mixinMethod="exec")
> public static class Approve {
> public void exec() { ... }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-1121) Integ Tests: allow them to simulate a new Authentication Session
[ https://issues.apache.org/jira/browse/ISIS-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711610#comment-15711610 ] Vladimir Nisevic commented on ISIS-1121: We are using security add on in combination with our enterprise active directory as authentication instance. I want to make integration test, e.g.: Given a new user (type delegated account) with username USERNAME When the user tries to login Then the authentication goes against out active directory I see that Integration Test bypasses security mechanism per default, and SudoService currently doesn't support authentication, since it has only the username as parameter. I guess this feature addresses exactly my requirement? > Integ Tests: allow them to simulate a new Authentication Session > > > Key: ISIS-1121 > URL: https://issues.apache.org/jira/browse/ISIS-1121 > Project: Isis > Issue Type: Improvement > Components: Core >Affects Versions: core-1.8.0 >Reporter: Oscar Bou > Fix For: 1.17.0 > > > There are some integration tests where the authentication context used can be > relevant (i.e., for testing Application Tenancy configured through the Isis > Security Add-on). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ISIS-1538) Rework simpleapp archetype so that is more modular.
[ https://issues.apache.org/jira/browse/ISIS-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-1538. --- Resolution: Fixed > Rework simpleapp archetype so that is more modular. > --- > > Key: ISIS-1538 > URL: https://issues.apache.org/jira/browse/ISIS-1538 > Project: Isis > Issue Type: Improvement > Components: Archetype: SimpleApp >Affects Versions: 1.13.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.2 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1550) Remove metamodel validation that insists on at least one @PersistenceCapable class.
[
https://issues.apache.org/jira/browse/ISIS-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711597#comment-15711597
]
ASF subversion and git services commented on ISIS-1550:
---
Commit 856d1117f3134e6d7767d746f60a5a556ad57faa in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=856d111 ]
ISIS-1550: removes validator that ensures there is >=1 @PersistenceCapable
entity in the classpath
> Remove metamodel validation that insists on at least one @PersistenceCapable
> class.
> ---
>
> Key: ISIS-1550
> URL: https://issues.apache.org/jira/browse/ISIS-1550
> Project: Isis
> Issue Type: Improvement
> Components: Core
>Affects Versions: 1.13.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.13.2
>
>
> As per JdoMetaModelValidator:
> {code}
> if(!found) {
> validationFailures.add("No @PersistenceCapable entities
> found. " +
> "(Are the entities referenced by the registered
> services? " +
> "are all services registered? " +
> "did the DataNucleus enhancer run?)");
> }
> {code}
> because it's perfectly valid to have an Isis app with no persisted entities,
> just view models.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-1538) Rework simpleapp archetype so that is more modular.
[ https://issues.apache.org/jira/browse/ISIS-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711600#comment-15711600 ] ASF subversion and git services commented on ISIS-1538: --- Commit fa36da4a486d24c72b78c5a3ee812d9c228156ac in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=fa36da4 ] ISIS-1538: recreating simpleapp archetype > Rework simpleapp archetype so that is more modular. > --- > > Key: ISIS-1538 > URL: https://issues.apache.org/jira/browse/ISIS-1538 > Project: Isis > Issue Type: Improvement > Components: Archetype: SimpleApp >Affects Versions: 1.13.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.2 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ISIS-1548) Allow @Mixin annotation to specify the method name to use (instead of '$$') meaning to infer the mixin name from the mixin type. Also, allow '$' to be used as separator
[
https://issues.apache.org/jira/browse/ISIS-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood resolved ISIS-1548.
---
Resolution: Fixed
> Allow @Mixin annotation to specify the method name to use (instead of '$$')
> meaning to infer the mixin name from the mixin type. Also, allow '$' to be
> used as separator of the mixin type.
>
>
> Key: ISIS-1548
> URL: https://issues.apache.org/jira/browse/ISIS-1548
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.13.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.13.2
>
>
> The current mixin conventions gives rise to code such as:
> {code}
> mixin(Invoice._approve.class, invoice).$$();
> {code}
> where:
> {code}
> public class Invoice {
> ...
> @Mixin
> public static class _approve {
> ...
> public Invoice $$() { ... }
> }
> }
> {code}
> We'd like it instead to read:
> {code}
> mixin(Invoice.Approve.class, invoice).exec();
> {code}
> ie:
> * change "$$" to "exec" (or any other verb)
> * not require the leading "_" in the mixin name
> * allow the class to be capitalized
> Suggestion is:
> {code}
> public class Invoice {
> ...
> @Mixin(method="exec")
> public static class Approve {
> public void exec() { ... }
> }
> }
> {code}
> or (if using `@DomainObject`)
> {code}
> public class Invoice {
> ...
> @DomainObject(nature=MIXIN, mixinMethod="exec")
> public static class Approve {
> public void exec() { ... }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-1538) Rework simpleapp archetype so that is more modular.
[ https://issues.apache.org/jira/browse/ISIS-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711601#comment-15711601 ] ASF subversion and git services commented on ISIS-1538: --- Commit 1f03e0dc13925c04be855916ad2e35f02f44e8da in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1f03e0d ] ISIS-1538: recreating simpleapp archetype > Rework simpleapp archetype so that is more modular. > --- > > Key: ISIS-1538 > URL: https://issues.apache.org/jira/browse/ISIS-1538 > Project: Isis > Issue Type: Improvement > Components: Archetype: SimpleApp >Affects Versions: 1.13.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.2 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1548) Allow @Mixin annotation to specify the method name to use (instead of '$$') meaning to infer the mixin name from the mixin type. Also, allow '$' to be used as separator
[
https://issues.apache.org/jira/browse/ISIS-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711599#comment-15711599
]
ASF subversion and git services commented on ISIS-1548:
---
Commit 147f4c5d4a4eb7541b06a628b7d666bc5169c4f5 in isis's branch
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=147f4c5 ]
ISIS-1548: extends @Mixin and @DomainObject to accept (mixin)method()
attribute; updates facets; updates algorithm for inferring mixin name/id based
on when the name of the method being processed matches this attribute (rather
than hard-coded "$$" as previously).
Also, supports using "$" (as well as "_") as the separator for
MixinType_mixinName (ie for nested static classes).
Most of the stuff in ObjectMemberAbstract, plus the three Mixin classes,
ObjectActionMixedIn, OneToOneAssociationMixedIn, OneToManyAssociationMixedIn.
> Allow @Mixin annotation to specify the method name to use (instead of '$$')
> meaning to infer the mixin name from the mixin type. Also, allow '$' to be
> used as separator of the mixin type.
>
>
> Key: ISIS-1548
> URL: https://issues.apache.org/jira/browse/ISIS-1548
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.13.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.13.2
>
>
> The current mixin conventions gives rise to code such as:
> {code}
> mixin(Invoice._approve.class, invoice).$$();
> {code}
> where:
> {code}
> public class Invoice {
> ...
> @Mixin
> public static class _approve {
> ...
> public Invoice $$() { ... }
> }
> }
> {code}
> We'd like it instead to read:
> {code}
> mixin(Invoice.Approve.class, invoice).exec();
> {code}
> ie:
> * change "$$" to "exec" (or any other verb)
> * not require the leading "_" in the mixin name
> * allow the class to be capitalized
> Suggestion is:
> {code}
> public class Invoice {
> ...
> @Mixin(method="exec")
> public static class Approve {
> public void exec() { ... }
> }
> }
> {code}
> or (if using `@DomainObject`)
> {code}
> public class Invoice {
> ...
> @DomainObject(nature=MIXIN, mixinMethod="exec")
> public static class Approve {
> public void exec() { ... }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-1538) Rework simpleapp archetype so that is more modular.
[ https://issues.apache.org/jira/browse/ISIS-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711596#comment-15711596 ] ASF subversion and git services commented on ISIS-1538: --- Commit 91f8c83b27a27471ec888985c58c15a00eb1493e in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=91f8c83 ] ISIS-1538: updates to latest version of the mavenmixins. Shorter property names, fixes the plugin versions. Also rename _UnitTest to _Test > Rework simpleapp archetype so that is more modular. > --- > > Key: ISIS-1538 > URL: https://issues.apache.org/jira/browse/ISIS-1538 > Project: Isis > Issue Type: Improvement > Components: Archetype: SimpleApp >Affects Versions: 1.13.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.13.2 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-1548) Allow @Mixin annotation to specify the method name to use (instead of '$$') meaning to infer the mixin name from the mixin type. Also, allow '$' to be used as separator o
[
https://issues.apache.org/jira/browse/ISIS-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1548:
--
Description:
The current mixin conventions gives rise to code such as:
{code}
mixin(Invoice._approve.class, invoice).$$();
{code}
where:
{code}
public class Invoice {
...
@Mixin
public static class _approve {
...
public Invoice $$() { ... }
}
}
{code}
We'd like it instead to read:
{code}
mixin(Invoice.Approve.class, invoice).exec();
{code}
ie:
* change "$$" to "exec" (or any other verb)
* not require the leading "_" in the mixin name
* allow the class to be capitalized
Suggestion is:
{code}
public class Invoice {
...
@Mixin(method="exec")
public static class Approve {
public void exec() { ... }
}
}
{code}
or (if using `@DomainObject`)
{code}
public class Invoice {
...
@DomainObject(nature=MIXIN, mixinMethod="exec")
public static class Approve {
public void exec() { ... }
}
}
{code}
was:
The current mixin conventions gives rise to code such as:
{code}
mixin(Invoice._approve.class, invoice).$$();
{code}
where:
{code}
public class Invoice {
...
@Mixin
public static class _approve {
...
public Invoice $$() { ... }
}
}
{code}
We'd like it instead to read:
{code}
mixin(Invoice.Approve.class, invoice).exec();
{code}
ie:
* change "$$" to "exec" (or any other verb)
* not require the leading "_" in the mixin name
* allow the class to be capitalized
Suggestion is:
{code}
public class Invoice {
...
@Mixin("exec")
public static class Approve {
public void exec() { ... }
}
}
{code}
Summary: Allow @Mixin annotation to specify the method name to use
(instead of '$$') meaning to infer the mixin name from the mixin type. Also,
allow '$' to be used as separator of the mixin type. (was: Allow @Mixin
annotation to specify the verb to use for the action (instead of '$$'); allow
'$' to be used as separator.)
> Allow @Mixin annotation to specify the method name to use (instead of '$$')
> meaning to infer the mixin name from the mixin type. Also, allow '$' to be
> used as separator of the mixin type.
>
>
> Key: ISIS-1548
> URL: https://issues.apache.org/jira/browse/ISIS-1548
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.13.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.13.2
>
>
> The current mixin conventions gives rise to code such as:
> {code}
> mixin(Invoice._approve.class, invoice).$$();
> {code}
> where:
> {code}
> public class Invoice {
> ...
> @Mixin
> public static class _approve {
> ...
> public Invoice $$() { ... }
> }
> }
> {code}
> We'd like it instead to read:
> {code}
> mixin(Invoice.Approve.class, invoice).exec();
> {code}
> ie:
> * change "$$" to "exec" (or any other verb)
> * not require the leading "_" in the mixin name
> * allow the class to be capitalized
> Suggestion is:
> {code}
> public class Invoice {
> ...
> @Mixin(method="exec")
> public static class Approve {
> public void exec() { ... }
> }
> }
> {code}
> or (if using `@DomainObject`)
> {code}
> public class Invoice {
> ...
> @DomainObject(nature=MIXIN, mixinMethod="exec")
> public static class Approve {
> public void exec() { ... }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ISIS-1547) Cannot select text in (latest version of) Chrome, due to 'disabled' rather than 'readonly'
[ https://issues.apache.org/jira/browse/ISIS-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1547: -- Assignee: (was: Dan Haywood) > Cannot select text in (latest version of) Chrome, due to 'disabled' rather > than 'readonly' > -- > > Key: ISIS-1547 > URL: https://issues.apache.org/jira/browse/ISIS-1547 > Project: Isis > Issue Type: Improvement > Components: Core: Viewer: Wicket >Affects Versions: 1.13.1 >Reporter: Erik de Hair >Priority: Minor > Fix For: 1.14.0 > > > suggestion from Martin to use CSS. > https://lists.apache.org/thread.html/34499ec5b20658b01329f7866e27f2601b4aba95630ef0f0dd577590@%3Cusers.isis.apache.org%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-1547) Cannot select text in (latest version of) Chrome, due to 'disabled' rather than 'readonly'
[ https://issues.apache.org/jira/browse/ISIS-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1547: -- Assignee: (was: Dan Haywood) Fix Version/s: (was: 1.13.2) 1.14.0 > Cannot select text in (latest version of) Chrome, due to 'disabled' rather > than 'readonly' > -- > > Key: ISIS-1547 > URL: https://issues.apache.org/jira/browse/ISIS-1547 > Project: Isis > Issue Type: Improvement > Components: Core: Viewer: Wicket >Affects Versions: 1.13.1 >Reporter: Erik de Hair >Priority: Minor > Fix For: 1.14.0 > > > suggestion from Martin to use CSS. > https://lists.apache.org/thread.html/34499ec5b20658b01329f7866e27f2601b4aba95630ef0f0dd577590@%3Cusers.isis.apache.org%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-1548) Allow @Mixin annotation to specify the verb to use for the action (instead of '$$'); allow '$' to be used as separator.
[
https://issues.apache.org/jira/browse/ISIS-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1548:
--
Assignee: Dan Haywood
> Allow @Mixin annotation to specify the verb to use for the action (instead of
> '$$'); allow '$' to be used as separator.
> ---
>
> Key: ISIS-1548
> URL: https://issues.apache.org/jira/browse/ISIS-1548
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.13.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.13.2
>
>
> The current mixin conventions gives rise to code such as:
> {code}
> mixin(Invoice._approve.class, invoice).$$();
> {code}
> where:
> {code}
> public class Invoice {
> ...
> @Mixin
> public static class _approve {
> ...
> public Invoice $$() { ... }
> }
> }
> {code}
> We'd like it instead to read:
> {code}
> mixin(Invoice.Approve.class, invoice).exec();
> {code}
> ie:
> * change "$$" to "exec" (or any other verb)
> * not require the leading "_" in the mixin name
> * allow the class to be capitalized
> Suggestion is:
> {code}
> public class Invoice {
> ...
> @Mixin("exec")
> public static class Approve {
> public void exec() { ... }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
