[VOTE] Apache Isis Core release 1.15.1 RC1

2017-09-21 Thread Dan Haywood
I've cut a release for Apache Isis Core and the two archetypes:

* Core 1.15.1
* HelloWorld Archetype 1.15.1
* SimpleApp Archetype 1.15.1

This is mostly a bugfix release, including updating to a Wicket 7.9.0
(Wicket 7.8.0 had some major issues); there are a couple of small new
features, notably ISIS-1697 and ISIS-1616

The source code artifacts have been uploaded to staging repositories on
repository.apache.org:

*
http://repository.apache.org/content/repositories/orgapacheisis-1060/org/apache/isis/core/isis/1.15.1/isis-1.15.1-source-release.zip
*
http://repository.apache.org/content/repositories/orgapacheisis-1060/org/apache/isis/archetype/helloworld-archetype/1.15.1/helloworld-archetype-1.15.1-source-release.zip
*
http://repository.apache.org/content/repositories/orgapacheisis-1060/org/apache/isis/archetype/simpleapp-archetype/1.15.1/simpleapp-archetype-1.15.1-source-release.zip

For each zip there is a corresponding signature file (append .asc to the
zip's url).

In the source code repo the code has been tagged as isis-1.15.1-RC1,
helloworld-archetype-1.15.1-RC1 and simpleapp-archetype-1.15.1-RC1; see
https://git-wip-us.apache.org/repos/asf?p=isis.git

For instructions on how to verify the release (build from binaries and/or
use in Maven directly), see
http://isis.apache.org/guides/cgcom.html#_cgcom_verifying-releases

Please verify the release and cast your vote.  The vote will be open for a
minimum of 72 hours.

[ ] +1
[ ]  0
[ ] -1


[jira] [Commented] (ISIS-1712) 1.15.1 release activities

2017-09-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175654#comment-16175654
 ] 

ASF subversion and git services commented on ISIS-1712:
---

Commit 498c9bb74402aa312771292c69be622bc32fd327 in isis's branch 
refs/heads/release-1.15.1-RC1 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=498c9bb ]

ISIS-1712: updates helloworld app to use 1.15.1.

Also updates lombok to 1.16.18


> 1.15.1 release activities
> -
>
> Key: ISIS-1712
> URL: https://issues.apache.org/jira/browse/ISIS-1712
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.15.1
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1712) 1.15.1 release activities

2017-09-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175652#comment-16175652
 ] 

ASF subversion and git services commented on ISIS-1712:
---

Commit 3ea3af6618440d1524329c29164e54048e30b702 in isis's branch 
refs/heads/release-1.15.1-RC1 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3ea3af6 ]

ISIS-1712: updates simpleapp example app to use isis 1.15.1

Also bumps lombok to 1.16.18


> 1.15.1 release activities
> -
>
> Key: ISIS-1712
> URL: https://issues.apache.org/jira/browse/ISIS-1712
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.15.1
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1712) 1.15.1 release activities

2017-09-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175655#comment-16175655
 ] 

ASF subversion and git services commented on ISIS-1712:
---

Commit 057b85c906fb108a64daab6f0f545e8993d525aa in isis's branch 
refs/heads/release-1.15.1-RC1 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=057b85c ]

ISIS-1712: recreating helloworld archetype


> 1.15.1 release activities
> -
>
> Key: ISIS-1712
> URL: https://issues.apache.org/jira/browse/ISIS-1712
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.15.1
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1712) 1.15.1 release activities

2017-09-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175653#comment-16175653
 ] 

ASF subversion and git services commented on ISIS-1712:
---

Commit 215969cbc905e397145c880a069ca3891ee0411f in isis's branch 
refs/heads/release-1.15.1-RC1 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=215969c ]

ISIS-1712: recreating simpleapp archetype


> 1.15.1 release activities
> -
>
> Key: ISIS-1712
> URL: https://issues.apache.org/jira/browse/ISIS-1712
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.15.1
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (ISIS-1297) Integrate with Keycloak

2017-09-21 Thread Dan Haywood (JIRA)

 [ 
https://issues.apache.org/jira/browse/ISIS-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1297:
--
Fix Version/s: (was: 3.0.0)
   2.0.0

> Integrate with Keycloak
> ---
>
> Key: ISIS-1297
> URL: https://issues.apache.org/jira/browse/ISIS-1297
> Project: Isis
>  Issue Type: New Feature
>Reporter: Dan Haywood
> Fix For: 2.0.0
>
>
> As suggested on the Apache Isis mailing list.
> http://markmail.org/message/6jwghlmyravuxfbx
> There are several approaches ...
> As described in our security guide [1] Apache Isis has a pluggable API for
> both authentication and authorization, so at the lowest level one could
> take implement either/both of these plugin points.
> Apache Isis has two integrations, one for Shiro and one called "bypass"
> (which basically disables security).  So one could ignore Apache Isis'
> Shiro integration and implement everything yourself.
> However, it would probably make more sense to build
> upon the Isis Add-ons security module [2], which builds upon the Shiro
> integration by providing an implementation of a Shiro Realm.  This is
> described in [3].  In fact, I would suggest that keycloak would be used as
> a delegate realm within the Isis addons' security module.
> In other words, the design that we could use is:
> Apache Isis -> Shiro -> Isis addons security realm -> Isis addons
> delegate realm
> This last realm would be implemented using Keycloak.
> The documentation in the security module [4] and [5] might also help to
> explain this.
> Note that this design would use Keycloak for authentication (validate
> credentials and lookup roles), with the security module taking
> responsibility for authorization. 
> [1] http://isis.apache.org/guides/ugsec.html
> [2] https://github.com/isisaddons/isis-module-security
> [3]
> http://isis.apache.org/guides/ugsec.html#_ugsec_shiro-isisaddons-security-module-realm
> [4] https://github.com/isisaddons/isis-module-security#application-users
> [5]
> https://github.com/isisaddons/isis-module-security#shiro-configuration-shiroini



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (ISIS-1734) Enhance TitleService, return an enhanced TitleBuffer that uses TitleService for new appendTitleOf(...)

2017-09-21 Thread Dan Haywood (JIRA)
Dan Haywood created ISIS-1734:
-

 Summary: Enhance TitleService, return an enhanced TitleBuffer that 
uses TitleService for new appendTitleOf(...)
 Key: ISIS-1734
 URL: https://issues.apache.org/jira/browse/ISIS-1734
 Project: Isis
  Issue Type: Improvement
  Components: Core
Affects Versions: 1.15.0
Reporter: Dan Haywood
 Fix For: 1.16.0


thus:

TitleBuffer buffer = titleService.newBuffer();



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (ISIS-1530) Introduce @CollectionLayout(title=SHOW|HIDE, ...) similarly for @ActionLayout and @DomainObjectLayout

2017-09-21 Thread Dan Haywood (JIRA)

 [ 
https://issues.apache.org/jira/browse/ISIS-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1530:
--
Fix Version/s: (was: 2.1.0)
   1.16.0

> Introduce @CollectionLayout(title=SHOW|HIDE, ...) similarly for @ActionLayout 
> and @DomainObjectLayout
> -
>
> Key: ISIS-1530
> URL: https://issues.apache.org/jira/browse/ISIS-1530
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.13.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.16.0
>
>
> Introduce @CollectionLayout(title=SHOW|HIDE, ...) for parented collections, 
> and @ActionLayout(titleInCollection=SHOW|HIDE, ...) for actions returning 
> collections (ignored otherwise).  Could also have 
> @DomainObjectLayout(titleInCollection=SHOW|HIDE, ...) as a fallback



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1712) 1.15.1 release activities

2017-09-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174551#comment-16174551
 ] 

ASF subversion and git services commented on ISIS-1712:
---

Commit ff85b71ee89954b16fde26ba4769396fbdefc08a in isis's branch 
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=ff85b71 ]

ISIS-1712: uses @RequiredArgsConstructor from lombok to remove some more 
boilerplate from helloworld and simpleapp

Also adds enhance-all.sh to each


> 1.15.1 release activities
> -
>
> Key: ISIS-1712
> URL: https://issues.apache.org/jira/browse/ISIS-1712
> Project: Isis
>  Issue Type: Task
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.15.1
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (ISIS-1466) Hidden(where=REFERENCES_PARENT) seems to be broken.

2017-09-21 Thread Dan Haywood (JIRA)

 [ 
https://issues.apache.org/jira/browse/ISIS-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1466.
---
Resolution: Fixed

> Hidden(where=REFERENCES_PARENT) seems to be broken.
> ---
>
> Key: ISIS-1466
> URL: https://issues.apache.org/jira/browse/ISIS-1466
> Project: Isis
>  Issue Type: Bug
>  Components: Core: Viewer: Wicket
>Affects Versions: 1.13.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.15.1
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (ISIS-1733) Improve API of RepositoryService#persist, so returns the object being persisted.

2017-09-21 Thread Dan Haywood (JIRA)

 [ 
https://issues.apache.org/jira/browse/ISIS-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1733.
---
Resolution: Fixed

> Improve API of RepositoryService#persist, so returns the object being 
> persisted.
> 
>
> Key: ISIS-1733
> URL: https://issues.apache.org/jira/browse/ISIS-1733
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.15.1
>
>
> Allows for more fluent coding.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (ISIS-1731) @Property(hidden=Where.PARENTED_TABLES) does not render correctly in standalone collection view

2017-09-21 Thread Dan Haywood (JIRA)

 [ 
https://issues.apache.org/jira/browse/ISIS-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1731.
---
Resolution: Fixed

> @Property(hidden=Where.PARENTED_TABLES) does not render correctly in 
> standalone collection view
> ---
>
> Key: ISIS-1731
> URL: https://issues.apache.org/jira/browse/ISIS-1731
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
>Assignee: Dan Haywood
> Fix For: 1.15.1
>
>
> Having a tree-structure of a domain class _A_ with persistent parent child 
> relationship, there seems to be an issue with rendering the parent property 
> column, when asking for a standalone collection view (of a list of these 
> objects). The +parent+ column is present, but the column's cells are empty. 
> {code:java}
> class A {
>   @Property(hidden=Where.PARENTED_TABLES) 
>   @Column(allowsNull="true")
>   @Getter @Setter
>   private A parent;
>   
>   @Property
>   @Persistent(mappedBy="parent")
>   @Getter @Setter 
>   private SortedSet children;
>   
> }
> {code}
> Strangely, if we switch to the excel view and download the collection, the 
> cells of the parent column are filled in as expected. And this is no CSS 
> issue (of hiding elements in the DOM), because there the corresponding HTML 
> tags are actually empty.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1731) @Property(hidden=Where.PARENTED_TABLES) does not render correctly in standalone collection view

2017-09-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174545#comment-16174545
 ] 

ASF subversion and git services commented on ISIS-1731:
---

Commit 0cae6aa3fbf2fcfd3410ea5cb72c32a91bfb52f7 in isis's branch 
refs/heads/master from [~hobrom]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=0cae6aa ]

FIX ISIS-1731 @Property(hidden=Where.PARENTED_TABLES) does not render
correctly in standalone collection view

> @Property(hidden=Where.PARENTED_TABLES) does not render correctly in 
> standalone collection view
> ---
>
> Key: ISIS-1731
> URL: https://issues.apache.org/jira/browse/ISIS-1731
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
>Assignee: Dan Haywood
> Fix For: 1.15.1
>
>
> Having a tree-structure of a domain class _A_ with persistent parent child 
> relationship, there seems to be an issue with rendering the parent property 
> column, when asking for a standalone collection view (of a list of these 
> objects). The +parent+ column is present, but the column's cells are empty. 
> {code:java}
> class A {
>   @Property(hidden=Where.PARENTED_TABLES) 
>   @Column(allowsNull="true")
>   @Getter @Setter
>   private A parent;
>   
>   @Property
>   @Persistent(mappedBy="parent")
>   @Getter @Setter 
>   private SortedSet children;
>   
> }
> {code}
> Strangely, if we switch to the excel view and download the collection, the 
> cells of the parent column are filled in as expected. And this is no CSS 
> issue (of hiding elements in the DOM), because there the corresponding HTML 
> tags are actually empty.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1731) @Property(hidden=Where.PARENTED_TABLES) does not render correctly in standalone collection view

2017-09-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174548#comment-16174548
 ] 

ASF subversion and git services commented on ISIS-1731:
---

Commit 2493cf84f6a9fc08e65cac96f40810e7ae6c56e6 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2493cf8 ]

Merge branch 'ISIS-1731_pr-94'


> @Property(hidden=Where.PARENTED_TABLES) does not render correctly in 
> standalone collection view
> ---
>
> Key: ISIS-1731
> URL: https://issues.apache.org/jira/browse/ISIS-1731
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
>Assignee: Dan Haywood
> Fix For: 1.15.1
>
>
> Having a tree-structure of a domain class _A_ with persistent parent child 
> relationship, there seems to be an issue with rendering the parent property 
> column, when asking for a standalone collection view (of a list of these 
> objects). The +parent+ column is present, but the column's cells are empty. 
> {code:java}
> class A {
>   @Property(hidden=Where.PARENTED_TABLES) 
>   @Column(allowsNull="true")
>   @Getter @Setter
>   private A parent;
>   
>   @Property
>   @Persistent(mappedBy="parent")
>   @Getter @Setter 
>   private SortedSet children;
>   
> }
> {code}
> Strangely, if we switch to the excel view and download the collection, the 
> cells of the parent column are filled in as expected. And this is no CSS 
> issue (of hiding elements in the DOM), because there the corresponding HTML 
> tags are actually empty.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1731) @Property(hidden=Where.PARENTED_TABLES) does not render correctly in standalone collection view

2017-09-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174547#comment-16174547
 ] 

ASF subversion and git services commented on ISIS-1731:
---

Commit 7f15b185379496ac30eb9bece3352cc62b3f in isis's branch 
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7f15b18 ]

Merge branch 'ISIS-1731' of https://github.com/hobrom/isis into ISIS-1731_pr-94


> @Property(hidden=Where.PARENTED_TABLES) does not render correctly in 
> standalone collection view
> ---
>
> Key: ISIS-1731
> URL: https://issues.apache.org/jira/browse/ISIS-1731
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
>Assignee: Dan Haywood
> Fix For: 1.15.1
>
>
> Having a tree-structure of a domain class _A_ with persistent parent child 
> relationship, there seems to be an issue with rendering the parent property 
> column, when asking for a standalone collection view (of a list of these 
> objects). The +parent+ column is present, but the column's cells are empty. 
> {code:java}
> class A {
>   @Property(hidden=Where.PARENTED_TABLES) 
>   @Column(allowsNull="true")
>   @Getter @Setter
>   private A parent;
>   
>   @Property
>   @Persistent(mappedBy="parent")
>   @Getter @Setter 
>   private SortedSet children;
>   
> }
> {code}
> Strangely, if we switch to the excel view and download the collection, the 
> cells of the parent column are filled in as expected. And this is no CSS 
> issue (of hiding elements in the DOM), because there the corresponding HTML 
> tags are actually empty.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1733) Improve API of RepositoryService#persist, so returns the object being persisted.

2017-09-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174550#comment-16174550
 ] 

ASF subversion and git services commented on ISIS-1733:
---

Commit 3076e5b796e30005f536eb8bcdd24b3f4ddca9b3 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=3076e5b ]

ISIS-1733: updates RepositoryService and its framework implementation so that 
persist and persistAndFlush are now generic and return the supplied object ... 
allow for more fluent coding style


> Improve API of RepositoryService#persist, so returns the object being 
> persisted.
> 
>
> Key: ISIS-1733
> URL: https://issues.apache.org/jira/browse/ISIS-1733
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.15.1
>
>
> Allows for more fluent coding.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1731) @Property(hidden=Where.PARENTED_TABLES) does not render correctly in standalone collection view

2017-09-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174546#comment-16174546
 ] 

ASF subversion and git services commented on ISIS-1731:
---

Commit 7f15b185379496ac30eb9bece3352cc62b3f in isis's branch 
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7f15b18 ]

Merge branch 'ISIS-1731' of https://github.com/hobrom/isis into ISIS-1731_pr-94


> @Property(hidden=Where.PARENTED_TABLES) does not render correctly in 
> standalone collection view
> ---
>
> Key: ISIS-1731
> URL: https://issues.apache.org/jira/browse/ISIS-1731
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
>Assignee: Dan Haywood
> Fix For: 1.15.1
>
>
> Having a tree-structure of a domain class _A_ with persistent parent child 
> relationship, there seems to be an issue with rendering the parent property 
> column, when asking for a standalone collection view (of a list of these 
> objects). The +parent+ column is present, but the column's cells are empty. 
> {code:java}
> class A {
>   @Property(hidden=Where.PARENTED_TABLES) 
>   @Column(allowsNull="true")
>   @Getter @Setter
>   private A parent;
>   
>   @Property
>   @Persistent(mappedBy="parent")
>   @Getter @Setter 
>   private SortedSet children;
>   
> }
> {code}
> Strangely, if we switch to the excel view and download the collection, the 
> cells of the parent column are filled in as expected. And this is no CSS 
> issue (of hiding elements in the DOM), because there the corresponding HTML 
> tags are actually empty.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ISIS-1466) Hidden(where=REFERENCES_PARENT) seems to be broken.

2017-09-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ISIS-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174549#comment-16174549
 ] 

ASF subversion and git services commented on ISIS-1466:
---

Commit f8ecbde40c8014ebd24d868c3fb058d84b7b9ab9 in isis's branch 
refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=f8ecbde ]

ISIS-1466: adds null guard which fixes Hidden(Where.PARENTED_TABLES), and 
testing Hidden(Where.REFERENCES_PARENT) this also seems to be ok.


> Hidden(where=REFERENCES_PARENT) seems to be broken.
> ---
>
> Key: ISIS-1466
> URL: https://issues.apache.org/jira/browse/ISIS-1466
> Project: Isis
>  Issue Type: Bug
>  Components: Core: Viewer: Wicket
>Affects Versions: 1.13.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.15.1
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (ISIS-1733) Improve API of RepositoryService#persist, so returns the object being persisted.

2017-09-21 Thread Dan Haywood (JIRA)

 [ 
https://issues.apache.org/jira/browse/ISIS-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood reassigned ISIS-1733:
-

Assignee: Dan Haywood

> Improve API of RepositoryService#persist, so returns the object being 
> persisted.
> 
>
> Key: ISIS-1733
> URL: https://issues.apache.org/jira/browse/ISIS-1733
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.15.1
>
>
> Allows for more fluent coding.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (ISIS-1733) Improve API of RepositoryService#persist, so returns the object being persisted.

2017-09-21 Thread Dan Haywood (JIRA)
Dan Haywood created ISIS-1733:
-

 Summary: Improve API of RepositoryService#persist, so returns the 
object being persisted.
 Key: ISIS-1733
 URL: https://issues.apache.org/jira/browse/ISIS-1733
 Project: Isis
  Issue Type: Improvement
  Components: Core
Affects Versions: 1.15.0
Reporter: Dan Haywood
Priority: Minor
 Fix For: 1.15.1


Allows for more fluent coding.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (ISIS-1466) Hidden(where=REFERENCES_PARENT) seems to be broken.

2017-09-21 Thread Dan Haywood (JIRA)

 [ 
https://issues.apache.org/jira/browse/ISIS-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1466:
--
Fix Version/s: (was: 2.1.0)
   1.15.1

> Hidden(where=REFERENCES_PARENT) seems to be broken.
> ---
>
> Key: ISIS-1466
> URL: https://issues.apache.org/jira/browse/ISIS-1466
> Project: Isis
>  Issue Type: Bug
>  Components: Core: Viewer: Wicket
>Affects Versions: 1.13.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.15.1
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (ISIS-1731) @Property(hidden=Where.PARENTED_TABLES) does not render correctly in standalone collection view

2017-09-21 Thread Dan Haywood (JIRA)

 [ 
https://issues.apache.org/jira/browse/ISIS-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood reassigned ISIS-1731:
-

 Assignee: Dan Haywood
Fix Version/s: (was: 1.16.0)
   1.15.1

> @Property(hidden=Where.PARENTED_TABLES) does not render correctly in 
> standalone collection view
> ---
>
> Key: ISIS-1731
> URL: https://issues.apache.org/jira/browse/ISIS-1731
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.15.0
>Reporter: Andi Huber
>Assignee: Dan Haywood
> Fix For: 1.15.1
>
>
> Having a tree-structure of a domain class _A_ with persistent parent child 
> relationship, there seems to be an issue with rendering the parent property 
> column, when asking for a standalone collection view (of a list of these 
> objects). The +parent+ column is present, but the column's cells are empty. 
> {code:java}
> class A {
>   @Property(hidden=Where.PARENTED_TABLES) 
>   @Column(allowsNull="true")
>   @Getter @Setter
>   private A parent;
>   
>   @Property
>   @Persistent(mappedBy="parent")
>   @Getter @Setter 
>   private SortedSet children;
>   
> }
> {code}
> Strangely, if we switch to the excel view and download the collection, the 
> cells of the parent column are filled in as expected. And this is no CSS 
> issue (of hiding elements in the DOM), because there the corresponding HTML 
> tags are actually empty.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (ISIS-1732) Document "hidden" as a supported method for services.

2017-09-21 Thread Dan Haywood (JIRA)
Dan Haywood created ISIS-1732:
-

 Summary: Document "hidden" as a supported method for services.
 Key: ISIS-1732
 URL: https://issues.apache.org/jira/browse/ISIS-1732
 Project: Isis
  Issue Type: Improvement
Affects Versions: 1.15.0
Reporter: Dan Haywood
Priority: Minor
 Fix For: 2.0.0


eg, in kitchensink, we have:

{code}
public abstract class RepositoryAbstract {

private final Class cls;

public RepositoryAbstract(Class cls, Visibility visibility) {
this.cls = cls;
this.visibility = visibility;
}

//region > visibility

private final Visibility visibility;

protected enum Visibility {
VISIBLE,
NOT_VISIBLE
}

public boolean hidden() {
return this.visibility == Visibility.NOT_VISIBLE;
}
//endregion
 
{code}

and then:

{code}
@DomainService(
repositoryFor = ChildObject.class
)
public class ChildObjects extends RepositoryAbstract {

public ChildObjects() {
super(ChildObject.class, Visibility.NOT_VISIBLE);
}

public ChildObject create(
final String name,
final ParentObject parentObject) {
return repositoryService.persist(ChildObject.create(name, 
parentObject));
}

public List listAll() {
return repositoryService.allInstances(ChildObject.class);
}

}
{code}

if use super(...VISIBLE) then this service appears in the menu.  so, "hidden()" 
is a way of globally hiding an object (or a domain service, at least).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (ISIS-1701) Document the polymorphic associations pattern, xref dom-alias and dom-classification.

2017-09-21 Thread Dan Haywood (JIRA)

 [ 
https://issues.apache.org/jira/browse/ISIS-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1701.
-
Resolution: Done

> Document the polymorphic associations pattern, xref dom-alias and 
> dom-classification.
> -
>
> Key: ISIS-1701
> URL: https://issues.apache.org/jira/browse/ISIS-1701
> Project: Isis
>  Issue Type: Improvement
>  Components: Website and Docs
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.15.0
>
>
> Part of platform.incode.org



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (ISIS-1722) Upgrade to Wicket 7.9.0 once available

2017-09-21 Thread Dan Haywood (JIRA)

 [ 
https://issues.apache.org/jira/browse/ISIS-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1722.
---
Resolution: Fixed

> Upgrade to Wicket 7.9.0 once available
> --
>
> Key: ISIS-1722
> URL: https://issues.apache.org/jira/browse/ISIS-1722
> Project: Isis
>  Issue Type: Dependency upgrade
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 1.15.1
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (ISIS-1699) Titles of (editable) references not shown in collections

2017-09-21 Thread Dan Haywood (JIRA)

 [ 
https://issues.apache.org/jira/browse/ISIS-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1699.
---
Resolution: Fixed

> Titles of (editable) references not shown in collections
> 
>
> Key: ISIS-1699
> URL: https://issues.apache.org/jira/browse/ISIS-1699
> Project: Isis
>  Issue Type: Bug
>  Components: Core: Viewer: Wicket
>Affects Versions: 1.15.0
>Reporter: Andi Huber
>Assignee: Dan Haywood
> Fix For: 1.15.1
>
> Attachments: ISIS-1699.png
>
>
> The css class 'inlinePrompt' appears in ReferencePanels within the collection 
> view.
> I suppose, this should never happen. It results in references' titles being 
> hidden.
> (see attached screenshot)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)