[jira] [Commented] (ISIS-1632) Support meta annotations for @Property/@Collection/@Action + @XxxLayout
[ https://issues.apache.org/jira/browse/ISIS-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312247#comment-16312247 ] ASF subversion and git services commented on ISIS-1632: --- Commit c62048b2f82c93aa4d5e05504c8e45ca396d7815 in isis's branch refs/heads/dev/2.0.0/ISIS-1632-meta-annotations from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=c62048b ] Merge branch 'master' into dev/2.0.0/ISIS-1632-meta-annotations # Conflicts: # adocs/documentation/src/main/asciidoc/guides/rgcfg/_rgcfg_configuring-core.adoc # adocs/documentation/src/main/asciidoc/guides/rgcms/_rgcms_schema-aim.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-api_ActionInvocationContext.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-api_BackgroundService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-api_CommandContext.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-api_InteractionContext.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-api_MessageService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-api_TitleService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-api_TransactionService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-api_WrapperFactory.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-spi_BackgroundCommandService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-spi_CommandService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_application-layer-spi_HomePageProviderService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_bootstrapping-spi_ClassDiscoveryService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_core-domain-api_ClockService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_core-domain-api_ConfigurationService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_core-domain-api_DomainObjectContainer.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_core-domain-api_EventBusService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_core-domain-api_FactoryService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_core-domain-api_Scratchpad.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_core-domain-api_UserService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_integration-api_BookmarkService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_integration-api_EmailService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_integration-api_JaxbService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_integration-api_MementoService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_integration-api_XmlSnapshotService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_metadata-api_ApplicationFeatureRepository.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_metadata-api_MetamodelService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_metadata-api_ServiceRegistry.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_persistence-layer-api_IsisJdoSupport.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_persistence-layer-api_MetricsService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_persistence-layer-api_QueryResultsCache.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_persistence-layer-api_RepositoryService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_persistence-layer-spi_AuditerService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_persistence-layer-spi_AuditingService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_persistence-layer-spi_EventSerializer.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_persistence-layer-spi_PublisherService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_persistence-layer-spi_PublishingService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_persistence-layer-spi_UserRegistrationService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_presentation-layer-api_AcceptHeaderService.adoc # adocs/documentation/src/main/asciidoc/guides/rgsvc/_rgsvc_presentation-layer-api_DeepLinkService.adoc #
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312242#comment-16312242 ] ASF subversion and git services commented on ISIS-1465: --- Commit c5e4a0d3cf937370c6164e0e6fd56dd9f0f50928 in isis's branch refs/heads/dev/2.0.0/ISIS-1632-meta-annotations from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=c5e4a0d ] ISIS-1465: updates to release docs > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1750) SQL Exception when invoke action (inline prompt) not handled correctly in UI
[
https://issues.apache.org/jira/browse/ISIS-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312244#comment-16312244
]
ASF subversion and git services commented on ISIS-1750:
---
Commit e2e422b3bb7785bd13e094a8418902e52aa90479 in isis's branch
refs/heads/dev/2.0.0/ISIS-1632-meta-annotations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e2e422b ]
ISIS-1750: adds fallback to previous behaviour if fail to handle exception
gracefully. This can occur if attempt to access non-existent object
This can occur if attempt to access non-existent object. An exception is
thrown which takes us to the OnException handler, and then the
respondGracefully for the recognised exception again attempts to take us back
to the entity page which promptly throws the same exception once more.
So, if this happens we just give up and revert to the original behaviour of
showing the error page.
> SQL Exception when invoke action (inline prompt) not handled correctly in UI
>
>
> Key: ISIS-1750
> URL: https://issues.apache.org/jira/browse/ISIS-1750
> Project: Isis
> Issue Type: Bug
> Components: Core: Viewer: Wicket
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 1.16.0
>
>
> Invoked an action that threw SQL exception due to DB constraint being hit.
> reproduce:
> * github shaId: ca2923908b4f2c3f07b088c79e698bdd849fb48d,
> * bitbucket shaId: 3df4e10b5d3f8f584ffb7bb468ebc2c337d659ea
> using org.estatio.app.EstatioEcpAppManifestWithDemoFixture
> http://localhost:8080/wicket/entity/orders.OrderItem:2
> editCharge : WORKS -> MARKETING
> What I see is that the prompt doesn't change when hit OK (this is a single
> autoComplete parameter), and in the browser we see a Javascript error, and
> the following stacktrace server-side:
> {code}
> 14:09:37,954 [TitleFacetViaTitleMethod ] title failure
> javax.jdo.JDODataStoreException: Update of object
> "org.estatio.capex.dom.order.OrderItem@a0ac5fc" using statement "UPDATE
> "dbo"."OrderItem" SET "chargeId"=?, "version"=? WHERE "id"=?" failed :
> java.sql.SQLIntegrityConstraintViolationException: integrity constraint
> violation: unique constraint or index violation; "OrderItem_order_charge_UNQ"
> table: "OrderItem"
> at org.hsqldb.jdbc.JDBCUtil.sqlException(Unknown Source)
> at org.hsqldb.jdbc.JDBCUtil.sqlException(Unknown Source)
> at org.hsqldb.jdbc.JDBCPreparedStatement.fetchResult(Unknown Source)
> at org.hsqldb.jdbc.JDBCPreparedStatement.executeUpdate(Unknown Source)
> at
> com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.executeUpdate(NewProxyPreparedStatement.java:105)
> at
> org.datanucleus.store.rdbms.ParamLoggingPreparedStatement.executeUpdate(ParamLoggingPreparedStatement.java:393)
> at
> org.datanucleus.store.rdbms.SQLController.executeStatementUpdate(SQLController.java:431)
> at
> org.datanucleus.store.rdbms.request.UpdateRequest.execute(UpdateRequest.java:395)
> at
> org.datanucleus.store.rdbms.RDBMSPersistenceHandler.updateObjectInTable(RDBMSPersistenceHandler.java:409)
> at
> org.datanucleus.store.rdbms.RDBMSPersistenceHandler.updateObject(RDBMSPersistenceHandler.java:383)
> at
> org.datanucleus.state.StateManagerImpl.flush(StateManagerImpl.java:4585)
> at org.datanucleus.flush.FlushOrdered.execute(FlushOrdered.java:106)
> at
> org.datanucleus.ExecutionContextImpl.flushInternal(ExecutionContextImpl.java:4054)
> at org.datanucleus.store.query.Query.prepareDatastore(Query.java:1647)
> at org.datanucleus.store.query.Query.executeQuery(Query.java:1832)
> at org.datanucleus.store.query.Query.executeWithMap(Query.java:1762)
> at org.datanucleus.api.jdo.JDOQuery.executeWithMap(JDOQuery.java:346)
> at
> org.apache.isis.objectstore.jdo.datanucleus.persistence.queries.PersistenceQueryFindUsingApplibQueryProcessor.getResults(PersistenceQueryFindUsingApplibQueryProcessor.java:117)
> at
> org.apache.isis.objectstore.jdo.datanucleus.persistence.queries.PersistenceQueryFindUsingApplibQueryProcessor.process(PersistenceQueryFindUsingApplibQueryProcessor.java:57)
> at
> org.apache.isis.objectstore.jdo.datanucleus.persistence.queries.PersistenceQueryFindUsingApplibQueryProcessor.process(PersistenceQueryFindUsingApplibQueryProcessor.java:41)
> at
> org.apache.isis.core.runtime.system.persistence.PersistenceSession.processPersistenceQuery(PersistenceSession.java:606)
> at
> org.apache.isis.core.runtime.system.persistence.PersistenceSession.access$000(PersistenceSession.java:147)
> at
> org.apache.isis.core.runtime.system.persistence.PersistenceSession$1.execute(PersistenceSession.java:567)
> at
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312245#comment-16312245 ] ASF subversion and git services commented on ISIS-1465: --- Commit fed2ce0413d7dcb1f912e8af7c258ae255783a01 in isis's branch refs/heads/dev/2.0.0/ISIS-1632-meta-annotations from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=fed2ce0 ] ISIS-1465: fixes typo in doc > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1729) Auditer Service probably shouldn't submit records for an object that is [new] -> [deleted]
[
https://issues.apache.org/jira/browse/ISIS-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312243#comment-16312243
]
ASF subversion and git services commented on ISIS-1729:
---
Commit 1a38713acbd8cce0092a6f1b51414589ad5d85ca in isis's branch
refs/heads/dev/2.0.0/ISIS-1632-meta-annotations from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1a38713 ]
ISIS-1729: removes test action accidentally committed for the simple app
> Auditer Service probably shouldn't submit records for an object that is [new]
> -> [deleted]
> ---
>
> Key: ISIS-1729
> URL: https://issues.apache.org/jira/browse/ISIS-1729
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.0
>
>
> ie is created but then deleted in the same xactn.
> eg
> {code}
> 16:07:18,365 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, transitionType:
> [NEW] -> [DELETED]
> 16:07:18,365 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, task: [NEW] ->
> [DELETED]
> 16:07:18,366 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, createdOn: [NEW]
> -> [DELETED]
> 16:07:18,367 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, paymentBatch:
> [NEW] -> [DELETED]
> 16:07:18,367 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, fromState: [NEW]
> -> [DELETED]
> 16:07:18,368 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, toState: [NEW]
> -> [DELETED]
> 16:07:18,370 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completed: [NEW]
> -> [DELETED]
> 16:07:18,370 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completedBy:
> [NEW] -> [DELETED]
> 16:07:18,371 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completedOn:
> [NEW] -> [DELETED]
> 16:07:18,372 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, comment: [NEW]
> -> [DELETED]
> 16:07:18,372 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, debtorBankAccount: [NEW] -> [DELETED]
> 16:07:18,373 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, createdOn: [NEW] -> [DELETED]
> 16:07:18,374 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, requestedExecutionDate: [NEW] -> [DELETED]
> 16:07:18,375 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, approvalState: [NEW] -> [DELETED]
> 16:07:18,375 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, transitionType:
> [NEW] -> [DELETED]
> 16:07:18,376 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, task: [NEW] ->
> [DELETED]
> 16:07:18,377 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, createdOn: [NEW]
> -> [DELETED]
> 16:07:18,377 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, paymentBatch:
> [NEW] -> [DELETED]
> 16:07:18,378 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, fromState: [NEW]
> -> [DELETED]
> 16:07:18,379 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, toState: [NEW]
> -> [DELETED]
> 16:07:18,379 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin,
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312246#comment-16312246 ] ASF subversion and git services commented on ISIS-1465: --- Commit 7728fd666a4cd59977d108b770be1a8cbce8a09c in isis's branch refs/heads/dev/2.0.0/ISIS-1632-meta-annotations from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=7728fd6 ] ISIS-1465: adds migration notes and release notes for 1.16.0 > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1754) JEE Support - Investigate Class Loading on Payara 4.1.2
[ https://issues.apache.org/jira/browse/ISIS-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312137#comment-16312137 ] ASF subversion and git services commented on ISIS-1754: --- Commit 662414bba2e34bd7ba2f4e8ab42f6a3ad20f30e4 in isis's branch refs/heads/dev/2.0.0/ISIS-1779-jax-rs-2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=662414b ] ISIS-1754 proper DN class-loading > JEE Support - Investigate Class Loading on Payara 4.1.2 > --- > > Key: ISIS-1754 > URL: https://issues.apache.org/jira/browse/ISIS-1754 > Project: Isis > Issue Type: Improvement >Reporter: Dan Haywood >Assignee: Andi Huber > Fix For: 2.0.0 > > > Investigating whether there are class-loading issues specifically on Payara > (full 4.1.2.173). > This requires a proper test case: > * skinny-war scenario with shared libraries > * test deployment > * also test a deploy/undeploy/deploy cycle > This issue will be closed, once this test-case is developed, automated and > tests are successful. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1779) Transition to JAX-RS 2.0 Client API
[ https://issues.apache.org/jira/browse/ISIS-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312141#comment-16312141 ] ASF subversion and git services commented on ISIS-1779: --- Commit 6bb2923582b6e0e5d6745ce8372152ea0088ab2a in isis's branch refs/heads/dev/2.0.0/ISIS-1779-jax-rs-2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=6bb2923 ] ISIS-1779 Transition to JAX-RS 2.0 Client API removed dependency on deprecated resteasy client api > Transition to JAX-RS 2.0 Client API > --- > > Key: ISIS-1779 > URL: https://issues.apache.org/jira/browse/ISIS-1779 > Project: Isis > Issue Type: Improvement > Components: Core: Viewer: RestfulObjects >Affects Versions: 1.15.1 >Reporter: Andi Huber >Assignee: Andi Huber > Fix For: 2.0.0 > > > Dedicated Branch > dev/2.0.0/ISIS-1779-jax-rs-2 > It seems JEE 8 servers (compliant with JAX-RS 2.1 API) conflict with > deployment of resteasy-jaxrs.version 3.x (which is JAX-RS 2.0 API) > and JEE 7 servers (compliant with JAX-RS 2.0 API) conflict with deployment of > resteasy-jaxrs.version 4.x (which is JAX-RS 2.1 API). > So by now there is no easy way to package a war file with resteasy included, > that will run on both JEE 7 and 8. > I've successfully tested > 4.0.0.Beta1 on glassfish 5, > 3.0.17.Final on glassfish 4, > 3.1.4.Final on glassfish 4. > Note: transitioning resteasy-jaxrs from 3.0.x to any higher version involves > removal of deprecated classes in > org.jboss.resteasy.client.*, which we are using it in > core/viewer-resfulobjects-applib. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1756) JEE Support - IsisContext requires proper lifecycling.
[ https://issues.apache.org/jira/browse/ISIS-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312140#comment-16312140 ] ASF subversion and git services commented on ISIS-1756: --- Commit 48053925364871ce30cf832360ee9b6855f1ee95 in isis's branch refs/heads/dev/2.0.0/ISIS-1779-jax-rs-2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=4805392 ] ISIS-1756 on shutdown purge any state associated with the current web-app classloader > JEE Support - IsisContext requires proper lifecycling. > -- > > Key: ISIS-1756 > URL: https://issues.apache.org/jira/browse/ISIS-1756 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Andi Huber > Fix For: 2.0.0 > > > as per > https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E > The isis-context needs a proper lifecycling, meaning a deploy/undeploy cycle > should properly invalidate any state. (e.g meta model validation is currently > not cleared after an undeploy, in my case after calling > IsisContext.testReset()) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1755) JEE Support - dummy bean as workaround for CDI
[ https://issues.apache.org/jira/browse/ISIS-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312138#comment-16312138 ] ASF subversion and git services commented on ISIS-1755: --- Commit f42ac8b9889ab72599ed8bfe81110d48e1f81c2b in isis's branch refs/heads/dev/2.0.0/ISIS-1779-jax-rs-2 from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=f42ac8b ] ISIS-1755 veto ExceptionRecognizer on CDI scan > JEE Support - dummy bean as workaround for CDI > -- > > Key: ISIS-1755 > URL: https://issues.apache.org/jira/browse/ISIS-1755 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Andi Huber > Fix For: 2.0.0 > > > as per > https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E > During JEE-Application bootstrapping the JEE container identifies a > list of Isis classes it feels responsible for, but does not know how to > instantiate; so errors are thrown. For me it was sufficient to provide a > single stateless JEE bean that states, that it produces all these > classes. As long as you deploy your Isis application including this > dummy-bean, CDI does not complain. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1756) JEE Support - IsisContext requires proper lifecycling.
[ https://issues.apache.org/jira/browse/ISIS-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312118#comment-16312118 ] ASF subversion and git services commented on ISIS-1756: --- Commit 16ac24d8e1ed0ce3882d6054cf54f2565e903bb0 in isis's branch refs/heads/dev/2.0.0/ISIS-1632-meta-annotations from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=16ac24d ] ISIS-1756: adds @Deprecated annotation to IsisContext.testReset() > JEE Support - IsisContext requires proper lifecycling. > -- > > Key: ISIS-1756 > URL: https://issues.apache.org/jira/browse/ISIS-1756 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Andi Huber > Fix For: 2.0.0 > > > as per > https://lists.apache.org/thread.html/a815c6d3e50c02111d0cd3df93b70b529c18193f321e613b116119b4@%3Cdev.isis.apache.org%3E > The isis-context needs a proper lifecycling, meaning a deploy/undeploy cycle > should properly invalidate any state. (e.g meta model validation is currently > not cleared after an undeploy, in my case after calling > IsisContext.testReset()) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1729) Auditer Service probably shouldn't submit records for an object that is [new] -> [deleted]
[
https://issues.apache.org/jira/browse/ISIS-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311939#comment-16311939
]
ASF subversion and git services commented on ISIS-1729:
---
Commit 1a38713acbd8cce0092a6f1b51414589ad5d85ca in isis's branch
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1a38713 ]
ISIS-1729: removes test action accidentally committed for the simple app
> Auditer Service probably shouldn't submit records for an object that is [new]
> -> [deleted]
> ---
>
> Key: ISIS-1729
> URL: https://issues.apache.org/jira/browse/ISIS-1729
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.0
>
>
> ie is created but then deleted in the same xactn.
> eg
> {code}
> 16:07:18,365 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, transitionType:
> [NEW] -> [DELETED]
> 16:07:18,365 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, task: [NEW] ->
> [DELETED]
> 16:07:18,366 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, createdOn: [NEW]
> -> [DELETED]
> 16:07:18,367 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, paymentBatch:
> [NEW] -> [DELETED]
> 16:07:18,367 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, fromState: [NEW]
> -> [DELETED]
> 16:07:18,368 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, toState: [NEW]
> -> [DELETED]
> 16:07:18,370 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completed: [NEW]
> -> [DELETED]
> 16:07:18,370 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completedBy:
> [NEW] -> [DELETED]
> 16:07:18,371 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completedOn:
> [NEW] -> [DELETED]
> 16:07:18,372 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, comment: [NEW]
> -> [DELETED]
> 16:07:18,372 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, debtorBankAccount: [NEW] -> [DELETED]
> 16:07:18,373 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, createdOn: [NEW] -> [DELETED]
> 16:07:18,374 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, requestedExecutionDate: [NEW] -> [DELETED]
> 16:07:18,375 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, approvalState: [NEW] -> [DELETED]
> 16:07:18,375 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, transitionType:
> [NEW] -> [DELETED]
> 16:07:18,376 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, task: [NEW] ->
> [DELETED]
> 16:07:18,377 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, createdOn: [NEW]
> -> [DELETED]
> 16:07:18,377 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, paymentBatch:
> [NEW] -> [DELETED]
> 16:07:18,378 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, fromState: [NEW]
> -> [DELETED]
> 16:07:18,379 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, toState: [NEW]
> -> [DELETED]
> 16:07:18,379 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, completed: [NEW]
> -> [DELETED]
>
[jira] [Commented] (ISIS-1750) SQL Exception when invoke action (inline prompt) not handled correctly in UI
[
https://issues.apache.org/jira/browse/ISIS-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311940#comment-16311940
]
ASF subversion and git services commented on ISIS-1750:
---
Commit e2e422b3bb7785bd13e094a8418902e52aa90479 in isis's branch
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e2e422b ]
ISIS-1750: adds fallback to previous behaviour if fail to handle exception
gracefully. This can occur if attempt to access non-existent object
This can occur if attempt to access non-existent object. An exception is
thrown which takes us to the OnException handler, and then the
respondGracefully for the recognised exception again attempts to take us back
to the entity page which promptly throws the same exception once more.
So, if this happens we just give up and revert to the original behaviour of
showing the error page.
> SQL Exception when invoke action (inline prompt) not handled correctly in UI
>
>
> Key: ISIS-1750
> URL: https://issues.apache.org/jira/browse/ISIS-1750
> Project: Isis
> Issue Type: Bug
> Components: Core: Viewer: Wicket
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 1.16.0
>
>
> Invoked an action that threw SQL exception due to DB constraint being hit.
> reproduce:
> * github shaId: ca2923908b4f2c3f07b088c79e698bdd849fb48d,
> * bitbucket shaId: 3df4e10b5d3f8f584ffb7bb468ebc2c337d659ea
> using org.estatio.app.EstatioEcpAppManifestWithDemoFixture
> http://localhost:8080/wicket/entity/orders.OrderItem:2
> editCharge : WORKS -> MARKETING
> What I see is that the prompt doesn't change when hit OK (this is a single
> autoComplete parameter), and in the browser we see a Javascript error, and
> the following stacktrace server-side:
> {code}
> 14:09:37,954 [TitleFacetViaTitleMethod ] title failure
> javax.jdo.JDODataStoreException: Update of object
> "org.estatio.capex.dom.order.OrderItem@a0ac5fc" using statement "UPDATE
> "dbo"."OrderItem" SET "chargeId"=?, "version"=? WHERE "id"=?" failed :
> java.sql.SQLIntegrityConstraintViolationException: integrity constraint
> violation: unique constraint or index violation; "OrderItem_order_charge_UNQ"
> table: "OrderItem"
> at org.hsqldb.jdbc.JDBCUtil.sqlException(Unknown Source)
> at org.hsqldb.jdbc.JDBCUtil.sqlException(Unknown Source)
> at org.hsqldb.jdbc.JDBCPreparedStatement.fetchResult(Unknown Source)
> at org.hsqldb.jdbc.JDBCPreparedStatement.executeUpdate(Unknown Source)
> at
> com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.executeUpdate(NewProxyPreparedStatement.java:105)
> at
> org.datanucleus.store.rdbms.ParamLoggingPreparedStatement.executeUpdate(ParamLoggingPreparedStatement.java:393)
> at
> org.datanucleus.store.rdbms.SQLController.executeStatementUpdate(SQLController.java:431)
> at
> org.datanucleus.store.rdbms.request.UpdateRequest.execute(UpdateRequest.java:395)
> at
> org.datanucleus.store.rdbms.RDBMSPersistenceHandler.updateObjectInTable(RDBMSPersistenceHandler.java:409)
> at
> org.datanucleus.store.rdbms.RDBMSPersistenceHandler.updateObject(RDBMSPersistenceHandler.java:383)
> at
> org.datanucleus.state.StateManagerImpl.flush(StateManagerImpl.java:4585)
> at org.datanucleus.flush.FlushOrdered.execute(FlushOrdered.java:106)
> at
> org.datanucleus.ExecutionContextImpl.flushInternal(ExecutionContextImpl.java:4054)
> at org.datanucleus.store.query.Query.prepareDatastore(Query.java:1647)
> at org.datanucleus.store.query.Query.executeQuery(Query.java:1832)
> at org.datanucleus.store.query.Query.executeWithMap(Query.java:1762)
> at org.datanucleus.api.jdo.JDOQuery.executeWithMap(JDOQuery.java:346)
> at
> org.apache.isis.objectstore.jdo.datanucleus.persistence.queries.PersistenceQueryFindUsingApplibQueryProcessor.getResults(PersistenceQueryFindUsingApplibQueryProcessor.java:117)
> at
> org.apache.isis.objectstore.jdo.datanucleus.persistence.queries.PersistenceQueryFindUsingApplibQueryProcessor.process(PersistenceQueryFindUsingApplibQueryProcessor.java:57)
> at
> org.apache.isis.objectstore.jdo.datanucleus.persistence.queries.PersistenceQueryFindUsingApplibQueryProcessor.process(PersistenceQueryFindUsingApplibQueryProcessor.java:41)
> at
> org.apache.isis.core.runtime.system.persistence.PersistenceSession.processPersistenceQuery(PersistenceSession.java:606)
> at
> org.apache.isis.core.runtime.system.persistence.PersistenceSession.access$000(PersistenceSession.java:147)
> at
> org.apache.isis.core.runtime.system.persistence.PersistenceSession$1.execute(PersistenceSession.java:567)
> at
>
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311917#comment-16311917 ] ASF subversion and git services commented on ISIS-1465: --- Commit f0a3d6a65d743075b0cbbca80648ced6d629c845 in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=f0a3d6a ] ISIS-1465: updates to docs, remove reference to the old git repo, since we now only have a github repo > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[VOTE] Apache Isis Core release 1.16.0 RC1
Hi folks and a happy new year! I've cut a release for Apache Isis Core and the two archetypes: * Core 1.16.0 * HelloWorld Archetype 1.16.0 * SimpleApp Archetype 1.16.0 The source code artifacts have been uploaded to staging repositories on repository.apache.org: * http://repository.apache.org/content/repositories/orgapacheisis-1062/org/apache/isis/core/isis/1.16.0/isis-1.16.0-source-release.zip * http://repository.apache.org/content/repositories/orgapacheisis-1063/org/apache/isis/archetype/helloworld-archetype/1.16.0/helloworld-archetype-1.16.0-source-release.zip * http://repository.apache.org/content/repositories/orgapacheisis-1063/org/apache/isis/archetype/simpleapp-archetype/1.16.0/simpleapp-archetype-1.16.0-source-release.zip For each zip there is a corresponding signature file (append .asc to the zip's url). In the source code repo the code has been tagged as isis-1.16.0-RC1, helloworld-archetype-1.16.0-RC1 and simpleapp-archetype-1.16.0-RC1; see https://github.com/apache/isis/tags For instructions on how to verify the release (build from binaries and/or use in Maven directly), see https://isis.apache.org/guides/cgcom/cgcom.html#_cgcom_verifying-releases Please verify the release and cast your vote. The vote will be open for a minimum of 72 hours. [ ] +1 [ ] 0 [ ] -1
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311898#comment-16311898 ] ASF subversion and git services commented on ISIS-1465: --- Commit 2e2ac1f62d2096a03f1cd4d29c84362f9bcdc4ad in isis's branch refs/heads/release-1.16.0-RC1 from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=2e2ac1f ] ISIS-1465: fixes property in hellworld app. This change is already copied into the helloworld arch; forgot to commit earlier > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311895#comment-16311895 ] ASF subversion and git services commented on ISIS-1465: --- Commit 0cca70dc7e6064d833dc5f874717680e26ea8ca0 in isis's branch refs/heads/release-1.16.0-RC1 from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=0cca70d ] ISIS-1465: updates helloworld app to use 1.16.0 > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311894#comment-16311894 ] ASF subversion and git services commented on ISIS-1465: --- Commit 63c3152e1f77a72f6d2c28e6674a1ad2ecf4c81a in isis's branch refs/heads/release-1.16.0-RC1 from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=63c3152 ] ISIS-1465: recreating simpleapp archetype > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311896#comment-16311896 ] ASF subversion and git services commented on ISIS-1465: --- Commit 2a0b21fe5f1981c938b90879d2008b402d7b13c6 in isis's branch refs/heads/release-1.16.0-RC1 from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=2a0b21f ] ISIS-1465: recreating helloworld archetype > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311893#comment-16311893 ] ASF subversion and git services commented on ISIS-1465: --- Commit 806c110c06383865f27cd2f771dc074c562de4a1 in isis's branch refs/heads/release-1.16.0-RC1 from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=806c110 ] ISIS-1465: updates simpleapp to use 1.16.0 > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311817#comment-16311817 ] ASF subversion and git services commented on ISIS-1465: --- Commit fed2ce0413d7dcb1f912e8af7c258ae255783a01 in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=fed2ce0 ] ISIS-1465: fixes typo in doc > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311818#comment-16311818 ] ASF subversion and git services commented on ISIS-1465: --- Commit 7728fd666a4cd59977d108b770be1a8cbce8a09c in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=7728fd6 ] ISIS-1465: adds migration notes and release notes for 1.16.0 > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1750) SQL Exception when invoke action (inline prompt) not handled correctly in UI
[
https://issues.apache.org/jira/browse/ISIS-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311680#comment-16311680
]
ASF subversion and git services commented on ISIS-1750:
---
Commit e2e422b3bb7785bd13e094a8418902e52aa90479 in isis's branch
refs/heads/release-1.16.0-RC1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e2e422b ]
ISIS-1750: adds fallback to previous behaviour if fail to handle exception
gracefully. This can occur if attempt to access non-existent object
This can occur if attempt to access non-existent object. An exception is
thrown which takes us to the OnException handler, and then the
respondGracefully for the recognised exception again attempts to take us back
to the entity page which promptly throws the same exception once more.
So, if this happens we just give up and revert to the original behaviour of
showing the error page.
> SQL Exception when invoke action (inline prompt) not handled correctly in UI
>
>
> Key: ISIS-1750
> URL: https://issues.apache.org/jira/browse/ISIS-1750
> Project: Isis
> Issue Type: Bug
> Components: Core: Viewer: Wicket
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
> Fix For: 1.16.0
>
>
> Invoked an action that threw SQL exception due to DB constraint being hit.
> reproduce:
> * github shaId: ca2923908b4f2c3f07b088c79e698bdd849fb48d,
> * bitbucket shaId: 3df4e10b5d3f8f584ffb7bb468ebc2c337d659ea
> using org.estatio.app.EstatioEcpAppManifestWithDemoFixture
> http://localhost:8080/wicket/entity/orders.OrderItem:2
> editCharge : WORKS -> MARKETING
> What I see is that the prompt doesn't change when hit OK (this is a single
> autoComplete parameter), and in the browser we see a Javascript error, and
> the following stacktrace server-side:
> {code}
> 14:09:37,954 [TitleFacetViaTitleMethod ] title failure
> javax.jdo.JDODataStoreException: Update of object
> "org.estatio.capex.dom.order.OrderItem@a0ac5fc" using statement "UPDATE
> "dbo"."OrderItem" SET "chargeId"=?, "version"=? WHERE "id"=?" failed :
> java.sql.SQLIntegrityConstraintViolationException: integrity constraint
> violation: unique constraint or index violation; "OrderItem_order_charge_UNQ"
> table: "OrderItem"
> at org.hsqldb.jdbc.JDBCUtil.sqlException(Unknown Source)
> at org.hsqldb.jdbc.JDBCUtil.sqlException(Unknown Source)
> at org.hsqldb.jdbc.JDBCPreparedStatement.fetchResult(Unknown Source)
> at org.hsqldb.jdbc.JDBCPreparedStatement.executeUpdate(Unknown Source)
> at
> com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.executeUpdate(NewProxyPreparedStatement.java:105)
> at
> org.datanucleus.store.rdbms.ParamLoggingPreparedStatement.executeUpdate(ParamLoggingPreparedStatement.java:393)
> at
> org.datanucleus.store.rdbms.SQLController.executeStatementUpdate(SQLController.java:431)
> at
> org.datanucleus.store.rdbms.request.UpdateRequest.execute(UpdateRequest.java:395)
> at
> org.datanucleus.store.rdbms.RDBMSPersistenceHandler.updateObjectInTable(RDBMSPersistenceHandler.java:409)
> at
> org.datanucleus.store.rdbms.RDBMSPersistenceHandler.updateObject(RDBMSPersistenceHandler.java:383)
> at
> org.datanucleus.state.StateManagerImpl.flush(StateManagerImpl.java:4585)
> at org.datanucleus.flush.FlushOrdered.execute(FlushOrdered.java:106)
> at
> org.datanucleus.ExecutionContextImpl.flushInternal(ExecutionContextImpl.java:4054)
> at org.datanucleus.store.query.Query.prepareDatastore(Query.java:1647)
> at org.datanucleus.store.query.Query.executeQuery(Query.java:1832)
> at org.datanucleus.store.query.Query.executeWithMap(Query.java:1762)
> at org.datanucleus.api.jdo.JDOQuery.executeWithMap(JDOQuery.java:346)
> at
> org.apache.isis.objectstore.jdo.datanucleus.persistence.queries.PersistenceQueryFindUsingApplibQueryProcessor.getResults(PersistenceQueryFindUsingApplibQueryProcessor.java:117)
> at
> org.apache.isis.objectstore.jdo.datanucleus.persistence.queries.PersistenceQueryFindUsingApplibQueryProcessor.process(PersistenceQueryFindUsingApplibQueryProcessor.java:57)
> at
> org.apache.isis.objectstore.jdo.datanucleus.persistence.queries.PersistenceQueryFindUsingApplibQueryProcessor.process(PersistenceQueryFindUsingApplibQueryProcessor.java:41)
> at
> org.apache.isis.core.runtime.system.persistence.PersistenceSession.processPersistenceQuery(PersistenceSession.java:606)
> at
> org.apache.isis.core.runtime.system.persistence.PersistenceSession.access$000(PersistenceSession.java:147)
> at
> org.apache.isis.core.runtime.system.persistence.PersistenceSession$1.execute(PersistenceSession.java:567)
> at
>
[jira] [Updated] (ISIS-1806) Reinstate ability to bookmark action invocations
[ https://issues.apache.org/jira/browse/ISIS-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1806: -- Description: broken in 1.15.0, and commented out in 1.16.0 to avoid user failures. The issue is that the BookmarkTreeNode infers a pageType of ACTION_PROMPT, which causes the ActionPromptPage to be rendered. This in turn has a ComponentType of ACTION_PARAMETERS. However, the ActionParametersPromptPanelFactory explicitly does not match for actions that take no arguments, and so the only component found is UnknownPanel which - of course - fails to add the correct ActionParametersPanel component. This whole area needs reworking ... the ActionParametersPanel now no-longer supports being invoked with no-args or with populated n-args and automatically resolving to the result of the action invocation. Instead, will need to move the action execution stuff into the implementation of the AbstractLink that is created within the BookmarkedPagesPanel. ~~ or: maybe we just keep this functionality commented out; is it used anyway ? was:broken in 1.15.0, and commented out in 1.16.0 to avoid user failures > Reinstate ability to bookmark action invocations > - > > Key: ISIS-1806 > URL: https://issues.apache.org/jira/browse/ISIS-1806 > Project: Isis > Issue Type: Bug >Affects Versions: 1.15.0 >Reporter: Dan Haywood > Fix For: 2.1.0 > > > broken in 1.15.0, and commented out in 1.16.0 to avoid user failures. > The issue is that the BookmarkTreeNode infers a pageType of ACTION_PROMPT, > which causes the ActionPromptPage to be rendered. This in turn has a > ComponentType of ACTION_PARAMETERS. > However, the ActionParametersPromptPanelFactory explicitly does not match for > actions that take no arguments, and so the only component found is > UnknownPanel which - of course - fails to add the correct > ActionParametersPanel component. > This whole area needs reworking ... the ActionParametersPanel now no-longer > supports being invoked with no-args or with populated n-args and > automatically resolving to the result of the action invocation. > Instead, will need to move the action execution stuff into the implementation > of the AbstractLink that is created within the BookmarkedPagesPanel. > ~~ > or: maybe we just keep this functionality commented out; is it used anyway ? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1729) Auditer Service probably shouldn't submit records for an object that is [new] -> [deleted]
[
https://issues.apache.org/jira/browse/ISIS-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311679#comment-16311679
]
ASF subversion and git services commented on ISIS-1729:
---
Commit 1a38713acbd8cce0092a6f1b51414589ad5d85ca in isis's branch
refs/heads/release-1.16.0-RC1 from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1a38713 ]
ISIS-1729: removes test action accidentally committed for the simple app
> Auditer Service probably shouldn't submit records for an object that is [new]
> -> [deleted]
> ---
>
> Key: ISIS-1729
> URL: https://issues.apache.org/jira/browse/ISIS-1729
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.0
>
>
> ie is created but then deleted in the same xactn.
> eg
> {code}
> 16:07:18,365 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, transitionType:
> [NEW] -> [DELETED]
> 16:07:18,365 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, task: [NEW] ->
> [DELETED]
> 16:07:18,366 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, createdOn: [NEW]
> -> [DELETED]
> 16:07:18,367 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, paymentBatch:
> [NEW] -> [DELETED]
> 16:07:18,367 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, fromState: [NEW]
> -> [DELETED]
> 16:07:18,368 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, toState: [NEW]
> -> [DELETED]
> 16:07:18,370 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completed: [NEW]
> -> [DELETED]
> 16:07:18,370 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completedBy:
> [NEW] -> [DELETED]
> 16:07:18,371 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completedOn:
> [NEW] -> [DELETED]
> 16:07:18,372 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, comment: [NEW]
> -> [DELETED]
> 16:07:18,372 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, debtorBankAccount: [NEW] -> [DELETED]
> 16:07:18,373 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, createdOn: [NEW] -> [DELETED]
> 16:07:18,374 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, requestedExecutionDate: [NEW] -> [DELETED]
> 16:07:18,375 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, approvalState: [NEW] -> [DELETED]
> 16:07:18,375 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, transitionType:
> [NEW] -> [DELETED]
> 16:07:18,376 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, task: [NEW] ->
> [DELETED]
> 16:07:18,377 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, createdOn: [NEW]
> -> [DELETED]
> 16:07:18,377 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, paymentBatch:
> [NEW] -> [DELETED]
> 16:07:18,378 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, fromState: [NEW]
> -> [DELETED]
> 16:07:18,379 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, toState: [NEW]
> -> [DELETED]
> 16:07:18,379 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, completed: [NEW]
> ->
[jira] [Created] (ISIS-1806) Reinstate ability to bookmark action invocations
Dan Haywood created ISIS-1806: - Summary: Reinstate ability to bookmark action invocations Key: ISIS-1806 URL: https://issues.apache.org/jira/browse/ISIS-1806 Project: Isis Issue Type: Bug Affects Versions: 1.15.0 Reporter: Dan Haywood Fix For: 2.1.0 broken in 1.15.0, and commented out in 1.16.0 to avoid user failures -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311392#comment-16311392 ] ASF subversion and git services commented on ISIS-1465: --- Commit c2a94fb0aa04dbf053682619d11189c2674a0ad9 in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=c2a94fb ] ISIS-1465: adds missing headers > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311389#comment-16311389 ] ASF subversion and git services commented on ISIS-1465: --- Commit c2a94fb0aa04dbf053682619d11189c2674a0ad9 in isis's branch refs/heads/release-1.16.0-RC1 from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=c2a94fb ] ISIS-1465: adds missing headers > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311346#comment-16311346 ] ASF subversion and git services commented on ISIS-1465: --- Commit 689231ba7994320d4af9844f7698000b6a876df9 in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=689231b ] ISIS-1465: tidies up configuration properties across .adoc's > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (ISIS-1747) Update docs, hints-n-tips for view models
[
https://issues.apache.org/jira/browse/ISIS-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood resolved ISIS-1747.
---
Resolution: Fixed
> Update docs, hints-n-tips for view models
> -
>
> Key: ISIS-1747
> URL: https://issues.apache.org/jira/browse/ISIS-1747
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.0
>
>
> see https://github.com/incodehq/incode-platform/issues/10
> ~
> here's the text that has been removed
> ## Demo App: Highlighting Current
> As a by-the-by, the demo app has one further "trick up its sleeve".
> If you run the app you'll notice that the currently selected `DemoObject` is
> highlighted in the left-hand table of the `HomePageViewModel`.
> This is accomplished by having the view model collaborate with a subscribing
> domain service that configures a CSS class.
> We start by ensuring that the `DemoObject` emits an event for its CSS class:
> .DemoObject.java
> java
> @DomainObjectLayout(
> ...
> cssClassUiEvent = DemoObject.CssClassUiEvent.class
> )
> public class DemoObject ... {
> public static class CssClassUiEvent
> extends
> org.apache.isis.applib.services.eventbus.CssClassUiEvent {}
> ...
> }
>
> Next, we define the domain service to act as the subscriber.
> Since it will be interact
> .HomePageViewModel.java
> java
> public class HomePageViewModel ... {
> @DomainService(nature = NatureOfService.DOMAIN)
> public static class CssHighlighter extends AbstractSubscriber {
> @EventHandler
> @Subscribe
> public void on(DemoObject.CssClassUiEvent ev) {
> if(getContext() == null) {
> return;
> }
> if(ev.getSource() == getContext().getSelected()) { // <1>
> ev.setCssClass("selected");
> }
> }
> private HomePageViewModel getContext() {// <2>
> return (HomePageViewModel) scratchpad.get("context");
> }
> void setContext(final HomePageViewModel homePageViewModel) {
> scratchpad.put("context", homePageViewModel);
> }
> @Inject
> Scratchpad scratchpad; // <3>
> }
> }
>
> <1> If the domain object is the currently selected then set the CSS class
> <2> Provide methods to set and get the current `HomePageViewModel` (acting as
> the context)
> <3> Store the context using the `Scratchpad` domain service (request-scoped
> so thread-safe).
> The `HomePageViewModel` is responsible for setting itself as the context for
> the domain service:
> .HomePageViewModel.java
> java
> public class HomePageViewModel ... {
> ...
> public TranslatableString title() {
> cssHighlighter.setContext(this);// <1>
> ...
> }
> ...
> @javax.inject.Inject
> CssHighlighter cssHighlighter;
> }
>
> <1> set the context on the domain service
> Finally we just need some CSS, in the `application.css` file:
> .application.css
> css
> .selected {
> font-style: italic;
> font-weight: bolder;
> }
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ISIS-1747) Update docs, hints-n-tips for view models
[
https://issues.apache.org/jira/browse/ISIS-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311282#comment-16311282
]
ASF subversion and git services commented on ISIS-1747:
---
Commit 5c183f0db3d0aee5aff9775bcc5ecc26e27cefff in isis's branch
refs/heads/master from [~danhaywood]
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=5c183f0 ]
ISIS-1747: adds hint-n-tip for wicket viewer
> Update docs, hints-n-tips for view models
> -
>
> Key: ISIS-1747
> URL: https://issues.apache.org/jira/browse/ISIS-1747
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.0
>
>
> see https://github.com/incodehq/incode-platform/issues/10
> ~
> here's the text that has been removed
> ## Demo App: Highlighting Current
> As a by-the-by, the demo app has one further "trick up its sleeve".
> If you run the app you'll notice that the currently selected `DemoObject` is
> highlighted in the left-hand table of the `HomePageViewModel`.
> This is accomplished by having the view model collaborate with a subscribing
> domain service that configures a CSS class.
> We start by ensuring that the `DemoObject` emits an event for its CSS class:
> .DemoObject.java
> java
> @DomainObjectLayout(
> ...
> cssClassUiEvent = DemoObject.CssClassUiEvent.class
> )
> public class DemoObject ... {
> public static class CssClassUiEvent
> extends
> org.apache.isis.applib.services.eventbus.CssClassUiEvent {}
> ...
> }
>
> Next, we define the domain service to act as the subscriber.
> Since it will be interact
> .HomePageViewModel.java
> java
> public class HomePageViewModel ... {
> @DomainService(nature = NatureOfService.DOMAIN)
> public static class CssHighlighter extends AbstractSubscriber {
> @EventHandler
> @Subscribe
> public void on(DemoObject.CssClassUiEvent ev) {
> if(getContext() == null) {
> return;
> }
> if(ev.getSource() == getContext().getSelected()) { // <1>
> ev.setCssClass("selected");
> }
> }
> private HomePageViewModel getContext() {// <2>
> return (HomePageViewModel) scratchpad.get("context");
> }
> void setContext(final HomePageViewModel homePageViewModel) {
> scratchpad.put("context", homePageViewModel);
> }
> @Inject
> Scratchpad scratchpad; // <3>
> }
> }
>
> <1> If the domain object is the currently selected then set the CSS class
> <2> Provide methods to set and get the current `HomePageViewModel` (acting as
> the context)
> <3> Store the context using the `Scratchpad` domain service (request-scoped
> so thread-safe).
> The `HomePageViewModel` is responsible for setting itself as the context for
> the domain service:
> .HomePageViewModel.java
> java
> public class HomePageViewModel ... {
> ...
> public TranslatableString title() {
> cssHighlighter.setContext(this);// <1>
> ...
> }
> ...
> @javax.inject.Inject
> CssHighlighter cssHighlighter;
> }
>
> <1> set the context on the domain service
> Finally we just need some CSS, in the `application.css` file:
> .application.css
> css
> .selected {
> font-style: italic;
> font-weight: bolder;
> }
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ISIS-1465) Release activities for 1.16.0
[ https://issues.apache.org/jira/browse/ISIS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311281#comment-16311281 ] ASF subversion and git services commented on ISIS-1465: --- Commit 2504f3dab08eb0f58013348c0017a32f9905cc11 in isis's branch refs/heads/master from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=2504f3d ] ISIS-1465: removes '1.16.0-SNAPSHOT' qualifiers from docs (since these now are published to versions/SNAPSHOT) so safe to already be the "next version". > Release activities for 1.16.0 > - > > Key: ISIS-1465 > URL: https://issues.apache.org/jira/browse/ISIS-1465 > Project: Isis > Issue Type: Task > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (ISIS-1729) Auditer Service probably shouldn't submit records for an object that is [new] -> [deleted]
[
https://issues.apache.org/jira/browse/ISIS-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood resolved ISIS-1729.
---
Resolution: Fixed
> Auditer Service probably shouldn't submit records for an object that is [new]
> -> [deleted]
> ---
>
> Key: ISIS-1729
> URL: https://issues.apache.org/jira/browse/ISIS-1729
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.0
>
>
> ie is created but then deleted in the same xactn.
> eg
> {code}
> 16:07:18,365 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, transitionType:
> [NEW] -> [DELETED]
> 16:07:18,365 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, task: [NEW] ->
> [DELETED]
> 16:07:18,366 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, createdOn: [NEW]
> -> [DELETED]
> 16:07:18,367 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, paymentBatch:
> [NEW] -> [DELETED]
> 16:07:18,367 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, fromState: [NEW]
> -> [DELETED]
> 16:07:18,368 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, toState: [NEW]
> -> [DELETED]
> 16:07:18,370 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completed: [NEW]
> -> [DELETED]
> 16:07:18,370 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completedBy:
> [NEW] -> [DELETED]
> 16:07:18,371 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completedOn:
> [NEW] -> [DELETED]
> 16:07:18,372 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, comment: [NEW]
> -> [DELETED]
> 16:07:18,372 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, debtorBankAccount: [NEW] -> [DELETED]
> 16:07:18,373 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, createdOn: [NEW] -> [DELETED]
> 16:07:18,374 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, requestedExecutionDate: [NEW] -> [DELETED]
> 16:07:18,375 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, approvalState: [NEW] -> [DELETED]
> 16:07:18,375 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, transitionType:
> [NEW] -> [DELETED]
> 16:07:18,376 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, task: [NEW] ->
> [DELETED]
> 16:07:18,377 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, createdOn: [NEW]
> -> [DELETED]
> 16:07:18,377 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, paymentBatch:
> [NEW] -> [DELETED]
> 16:07:18,378 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, fromState: [NEW]
> -> [DELETED]
> 16:07:18,379 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, toState: [NEW]
> -> [DELETED]
> 16:07:18,379 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, completed: [NEW]
> -> [DELETED]
> 16:07:18,380 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, completedBy:
> [NEW] -> [DELETED]
> 16:07:18,381 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
>
[jira] [Assigned] (ISIS-1747) Update docs, hints-n-tips for view models
[
https://issues.apache.org/jira/browse/ISIS-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood reassigned ISIS-1747:
-
Assignee: Dan Haywood
> Update docs, hints-n-tips for view models
> -
>
> Key: ISIS-1747
> URL: https://issues.apache.org/jira/browse/ISIS-1747
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.15.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.0
>
>
> see https://github.com/incodehq/incode-platform/issues/10
> ~
> here's the text that has been removed
> ## Demo App: Highlighting Current
> As a by-the-by, the demo app has one further "trick up its sleeve".
> If you run the app you'll notice that the currently selected `DemoObject` is
> highlighted in the left-hand table of the `HomePageViewModel`.
> This is accomplished by having the view model collaborate with a subscribing
> domain service that configures a CSS class.
> We start by ensuring that the `DemoObject` emits an event for its CSS class:
> .DemoObject.java
> java
> @DomainObjectLayout(
> ...
> cssClassUiEvent = DemoObject.CssClassUiEvent.class
> )
> public class DemoObject ... {
> public static class CssClassUiEvent
> extends
> org.apache.isis.applib.services.eventbus.CssClassUiEvent {}
> ...
> }
>
> Next, we define the domain service to act as the subscriber.
> Since it will be interact
> .HomePageViewModel.java
> java
> public class HomePageViewModel ... {
> @DomainService(nature = NatureOfService.DOMAIN)
> public static class CssHighlighter extends AbstractSubscriber {
> @EventHandler
> @Subscribe
> public void on(DemoObject.CssClassUiEvent ev) {
> if(getContext() == null) {
> return;
> }
> if(ev.getSource() == getContext().getSelected()) { // <1>
> ev.setCssClass("selected");
> }
> }
> private HomePageViewModel getContext() {// <2>
> return (HomePageViewModel) scratchpad.get("context");
> }
> void setContext(final HomePageViewModel homePageViewModel) {
> scratchpad.put("context", homePageViewModel);
> }
> @Inject
> Scratchpad scratchpad; // <3>
> }
> }
>
> <1> If the domain object is the currently selected then set the CSS class
> <2> Provide methods to set and get the current `HomePageViewModel` (acting as
> the context)
> <3> Store the context using the `Scratchpad` domain service (request-scoped
> so thread-safe).
> The `HomePageViewModel` is responsible for setting itself as the context for
> the domain service:
> .HomePageViewModel.java
> java
> public class HomePageViewModel ... {
> ...
> public TranslatableString title() {
> cssHighlighter.setContext(this);// <1>
> ...
> }
> ...
> @javax.inject.Inject
> CssHighlighter cssHighlighter;
> }
>
> <1> set the context on the domain service
> Finally we just need some CSS, in the `application.css` file:
> .application.css
> css
> .selected {
> font-style: italic;
> font-weight: bolder;
> }
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (ISIS-1729) Auditer Service probably shouldn't submit records for an object that is [new] -> [deleted]
[
https://issues.apache.org/jira/browse/ISIS-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood reassigned ISIS-1729:
-
Assignee: Dan Haywood
> Auditer Service probably shouldn't submit records for an object that is [new]
> -> [deleted]
> ---
>
> Key: ISIS-1729
> URL: https://issues.apache.org/jira/browse/ISIS-1729
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.0
>
>
> ie is created but then deleted in the same xactn.
> eg
> {code}
> 16:07:18,365 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, transitionType:
> [NEW] -> [DELETED]
> 16:07:18,365 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, task: [NEW] ->
> [DELETED]
> 16:07:18,366 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, createdOn: [NEW]
> -> [DELETED]
> 16:07:18,367 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, paymentBatch:
> [NEW] -> [DELETED]
> 16:07:18,367 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, fromState: [NEW]
> -> [DELETED]
> 16:07:18,368 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, toState: [NEW]
> -> [DELETED]
> 16:07:18,370 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completed: [NEW]
> -> [DELETED]
> 16:07:18,370 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completedBy:
> [NEW] -> [DELETED]
> 16:07:18,371 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, completedOn:
> [NEW] -> [DELETED]
> 16:07:18,372 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:294 by estatio-admin, comment: [NEW]
> -> [DELETED]
> 16:07:18,372 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, debtorBankAccount: [NEW] -> [DELETED]
> 16:07:18,373 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, createdOn: [NEW] -> [DELETED]
> 16:07:18,374 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, requestedExecutionDate: [NEW] -> [DELETED]
> 16:07:18,375 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0: payment.PaymentBatch:128 by
> estatio-admin, approvalState: [NEW] -> [DELETED]
> 16:07:18,375 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, transitionType:
> [NEW] -> [DELETED]
> 16:07:18,376 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, task: [NEW] ->
> [DELETED]
> 16:07:18,377 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, createdOn: [NEW]
> -> [DELETED]
> 16:07:18,377 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, paymentBatch:
> [NEW] -> [DELETED]
> 16:07:18,378 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, fromState: [NEW]
> -> [DELETED]
> 16:07:18,379 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, toState: [NEW]
> -> [DELETED]
> 16:07:18,379 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, completed: [NEW]
> -> [DELETED]
> 16:07:18,380 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
> payment.PaymentApprovalStateTransition:295 by estatio-admin, completedBy:
> [NEW] -> [DELETED]
> 16:07:18,381 [AuditerServiceLogging ]
> 376bb280-73e6-490e-a6a3-b4ff95063229,0:
>
