[jira] [Resolved] (ISIS-1848) References of type java.lang.Object (sometimes) not rendered correctly in Wicket viewer
[ https://issues.apache.org/jira/browse/ISIS-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-1848. --- Resolution: Fixed > References of type java.lang.Object (sometimes) not rendered correctly in > Wicket viewer > --- > > Key: ISIS-1848 > URL: https://issues.apache.org/jira/browse/ISIS-1848 > Project: Isis > Issue Type: Bug >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > This is down to a race condition, I think. > At any rate, the ObjectSpecificationOnStandaloneList for FreeStandingList > (the internal pojo that holds the result of an action invocation) is asked > for its ObjectSpecId. It tries to do this by asking for the value of the > corresponding ObjectSpecIfFacet. > However, no such facet (in some circumstances, presumably) is installed for > this ObjectSpec, and so it searches up the hierarchy. The superclass is > java.lang.Object, and so we return the ObjectSpecId for java.lang.Object. > This in turn causes the cache of ObjectSpecId -> ObjectSpecification's to be > corrupted, with java.lang.Object mapping to the list. > In the Wicket viewer, when attempting to render a reference property of type > java.lang.Object (such as the Task_object mixin for Estatio), the > SpecificationLoader reports that a reference of this type is not isObject() > (because it's using ObjectSpecificationOnStandaloneList), resulting in an > UnknownPanel being selected to render the Wicket model for the reference > property. This simply shows a toString(). > The fix, I think, is to not search up the hierarchy in the case of > ObjectSpecIdFacet... an ObjectSpecification must be able to answer this > question itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ISIS-1831) If Accept header bad, then our exception handler throws an NPE and so issue of bad header is not reported.
[ https://issues.apache.org/jira/browse/ISIS-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-1831. --- Resolution: Fixed > If Accept header bad, then our exception handler throws an NPE and so issue > of bad header is not reported. > -- > > Key: ISIS-1831 > URL: https://issues.apache.org/jira/browse/ISIS-1831 > Project: Isis > Issue Type: Bug >Affects Versions: 1.16.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > If RestEasy throws exception due to bad Accept header, this happens before > Isis has set up a session. We therefore need to guard against this in the > exception handler to avoid the NPE. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ISIS-1837) Metamodel validator should check for cyclic dependencies (reference to entities that live outside of the module set)
[ https://issues.apache.org/jira/browse/ISIS-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-1837. --- Resolution: Fixed > Metamodel validator should check for cyclic dependencies (reference to > entities that live outside of the module set) > > > Key: ISIS-1837 > URL: https://issues.apache.org/jira/browse/ISIS-1837 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.16.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.1 > > > at the moment this shows up as an error of an entity referencing a > non-existent repository. This is where the entity is found by walking the > graph outside the set of defined modules, and yet the domain services are > only ever strictly loaded. > The metamodel validator should basically check that every entity and view > model type in the metamodel resides within one of the packages of the set of > modules that make up the application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1849) 1.16.0 - Broken Links according to W3C checker
[ https://issues.apache.org/jira/browse/ISIS-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jörg Rade updated ISIS-1849: Attachment: W3C Link Checker https _isis.apache.org_.htm > 1.16.0 - Broken Links according to W3C checker > -- > > Key: ISIS-1849 > URL: https://issues.apache.org/jira/browse/ISIS-1849 > Project: Isis > Issue Type: Documentation >Reporter: Jörg Rade >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.1 > > Attachments: W3C Link Checker https _isis.apache.org_.htm > > > According to > [https://validator.w3.org/checklink?uri=https%3A%2F%2Fisis.apache.org%2F=on_type=all=on=3=nochanges=Check] > > there are some 404 errors: > [https://isis.apache.org/guides/cgcom/cgcom.html] (probably on purpose) > Line: 2321 > https://git-wip-us.apache.org/repos/asf/isis/repo?p=isis.git;a=blob_plain;f=STATUS;hb=HEAD > Line: 3512 http://people.apache.org/~/.asc > https://isis.apache.org/guides/rgcms/rgcms.html > Line: 5198 https://isis.apache.org/guides/rgcms/images/value-types/markup/.png > Line: 6378 http://isis.apache.org/applib/layout/menus/menubars.xsd > https://isis.apache.org/guides/ugtst/ugtst.html > Line: 2276 https://isis.apache.org/guides/ugtst/rgsvc.html > https://isis.apache.org/migration-notes/migration-notes.html > Line: 619 https://isis.apache.org/rgcms/rgcms.html > Lines: 464, 564, 565 https://isis.apache.org/ugfun/ugfun.html > Line: 1072 https://isis.apache.org/migration-notes/rgsvc.html > Line: 572 https://isis.apache.org/rgcfg.html > Line: 552 https://isis.apache.org/ugfun.html > Line: 619 https://isis.apache.org/ugtst/ugtst.html > https://isis.apache.org/guides/dg/dg.html > Line: 4441 https://isis.apache.org/setting-up/concepts/concepts.html > Lines: 4412, 4426 https://isis.apache.org/guides/dg/_images/vscode.png > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1849) 1.16.0 - Broken Links according to W3C checker
[ https://issues.apache.org/jira/browse/ISIS-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jörg Rade updated ISIS-1849: Description: According to [https://validator.w3.org/checklink?uri=https%3A%2F%2Fisis.apache.org%2F=on_type=all=on=3=nochanges=Check] there are some 404 errors: [https://isis.apache.org/guides/cgcom/cgcom.html] (probably on purpose) Line: 2321 https://git-wip-us.apache.org/repos/asf/isis/repo?p=isis.git;a=blob_plain;f=STATUS;hb=HEAD Line: 3512 http://people.apache.org/~/.asc https://isis.apache.org/guides/rgcms/rgcms.html Line: 5198 https://isis.apache.org/guides/rgcms/images/value-types/markup/.png Line: 6378 http://isis.apache.org/applib/layout/menus/menubars.xsd https://isis.apache.org/guides/ugtst/ugtst.html Line: 2276 https://isis.apache.org/guides/ugtst/rgsvc.html https://isis.apache.org/migration-notes/migration-notes.html Line: 619 https://isis.apache.org/rgcms/rgcms.html Lines: 464, 564, 565 https://isis.apache.org/ugfun/ugfun.html Line: 1072 https://isis.apache.org/migration-notes/rgsvc.html Line: 572 https://isis.apache.org/rgcfg.html Line: 552 https://isis.apache.org/ugfun.html Line: 619 https://isis.apache.org/ugtst/ugtst.html https://isis.apache.org/guides/dg/dg.html Line: 4441 https://isis.apache.org/setting-up/concepts/concepts.html Lines: 4412, 4426 https://isis.apache.org/guides/dg/_images/vscode.png was: According to https://validator.w3.org/checklink?uri=https%3A%2F%2Fisis.apache.org%2F=on_type=all=on=3=nochanges=Check there are some 404 errors, see attachment. grtnx -j > 1.16.0 - Broken Links according to W3C checker > -- > > Key: ISIS-1849 > URL: https://issues.apache.org/jira/browse/ISIS-1849 > Project: Isis > Issue Type: Documentation >Reporter: Jörg Rade >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.1 > > > According to > [https://validator.w3.org/checklink?uri=https%3A%2F%2Fisis.apache.org%2F=on_type=all=on=3=nochanges=Check] > > there are some 404 errors: > [https://isis.apache.org/guides/cgcom/cgcom.html] (probably on purpose) > Line: 2321 > https://git-wip-us.apache.org/repos/asf/isis/repo?p=isis.git;a=blob_plain;f=STATUS;hb=HEAD > Line: 3512 http://people.apache.org/~/.asc > https://isis.apache.org/guides/rgcms/rgcms.html > Line: 5198 https://isis.apache.org/guides/rgcms/images/value-types/markup/.png > Line: 6378 http://isis.apache.org/applib/layout/menus/menubars.xsd > https://isis.apache.org/guides/ugtst/ugtst.html > Line: 2276 https://isis.apache.org/guides/ugtst/rgsvc.html > https://isis.apache.org/migration-notes/migration-notes.html > Line: 619 https://isis.apache.org/rgcms/rgcms.html > Lines: 464, 564, 565 https://isis.apache.org/ugfun/ugfun.html > Line: 1072 https://isis.apache.org/migration-notes/rgsvc.html > Line: 572 https://isis.apache.org/rgcfg.html > Line: 552 https://isis.apache.org/ugfun.html > Line: 619 https://isis.apache.org/ugtst/ugtst.html > https://isis.apache.org/guides/dg/dg.html > Line: 4441 https://isis.apache.org/setting-up/concepts/concepts.html > Lines: 4412, 4426 https://isis.apache.org/guides/dg/_images/vscode.png > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1849) 1.16.0 - Broken Links according to W3C checker
[ https://issues.apache.org/jira/browse/ISIS-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jörg Rade updated ISIS-1849: Fix Version/s: (was: 1.15.1) 1.16.1 > 1.16.0 - Broken Links according to W3C checker > -- > > Key: ISIS-1849 > URL: https://issues.apache.org/jira/browse/ISIS-1849 > Project: Isis > Issue Type: Documentation >Reporter: Jörg Rade >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.1 > > > According to > [https://validator.w3.org/checklink?uri=https%3A%2F%2Fisis.apache.org%2F=on_type=all=on=3=nochanges=Check] > > there are some 404 errors: > [https://isis.apache.org/guides/cgcom/cgcom.html] (probably on purpose) > Line: 2321 > https://git-wip-us.apache.org/repos/asf/isis/repo?p=isis.git;a=blob_plain;f=STATUS;hb=HEAD > Line: 3512 http://people.apache.org/~/.asc > https://isis.apache.org/guides/rgcms/rgcms.html > Line: 5198 https://isis.apache.org/guides/rgcms/images/value-types/markup/.png > Line: 6378 http://isis.apache.org/applib/layout/menus/menubars.xsd > https://isis.apache.org/guides/ugtst/ugtst.html > Line: 2276 https://isis.apache.org/guides/ugtst/rgsvc.html > https://isis.apache.org/migration-notes/migration-notes.html > Line: 619 https://isis.apache.org/rgcms/rgcms.html > Lines: 464, 564, 565 https://isis.apache.org/ugfun/ugfun.html > Line: 1072 https://isis.apache.org/migration-notes/rgsvc.html > Line: 572 https://isis.apache.org/rgcfg.html > Line: 552 https://isis.apache.org/ugfun.html > Line: 619 https://isis.apache.org/ugtst/ugtst.html > https://isis.apache.org/guides/dg/dg.html > Line: 4441 https://isis.apache.org/setting-up/concepts/concepts.html > Lines: 4412, 4426 https://isis.apache.org/guides/dg/_images/vscode.png > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ISIS-1849) 1.16.0 - Broken Links according to W3C checker
Jörg Rade created ISIS-1849: --- Summary: 1.16.0 - Broken Links according to W3C checker Key: ISIS-1849 URL: https://issues.apache.org/jira/browse/ISIS-1849 Project: Isis Issue Type: Documentation Reporter: Jörg Rade Assignee: Dan Haywood Fix For: 1.15.1 According to https://validator.w3.org/checklink?uri=https%3A%2F%2Fisis.apache.org%2F=on_type=all=on=3=nochanges=Check there are some 404 errors, see attachment. grtnx -j -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1569) Automated testing tool to replay commands against a copy of prod
[ https://issues.apache.org/jira/browse/ISIS-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337736#comment-16337736 ] ASF subversion and git services commented on ISIS-1569: --- Commit 329d75b624f8486114f96a0c9c2a0b0ba8d55f7b in isis's branch refs/heads/ISIS-1569-replay-commands from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=329d75b ] ISIS-1569: updates to XSDs, make sure the version defaultsb are correct. > Automated testing tool to replay commands against a copy of prod > > > Key: ISIS-1569 > URL: https://issues.apache.org/jira/browse/ISIS-1569 > Project: Isis > Issue Type: New Feature > Components: Core >Affects Versions: 1.13.2.1 >Reporter: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > eg obtain copy of prod from a month ago > then for all commands since then, replay (simulating the current user and > time for each) > finally, compare resultant database with current prod, and list out > differences in data. > could also use for performance testing, perhaps. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1569) Automated testing tool to replay commands against a copy of prod
[ https://issues.apache.org/jira/browse/ISIS-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337737#comment-16337737 ] ASF subversion and git services commented on ISIS-1569: --- Commit a37ba576eaf36ee8552e67533b1b46e627a30773 in isis's branch refs/heads/ISIS-1569-replay-commands from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=a37ba57 ] ISIS-1569: removes unused and accidentally committed element in cmd-1.4.xsd > Automated testing tool to replay commands against a copy of prod > > > Key: ISIS-1569 > URL: https://issues.apache.org/jira/browse/ISIS-1569 > Project: Isis > Issue Type: New Feature > Components: Core >Affects Versions: 1.13.2.1 >Reporter: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > eg obtain copy of prod from a month ago > then for all commands since then, replay (simulating the current user and > time for each) > finally, compare resultant database with current prod, and list out > differences in data. > could also use for performance testing, perhaps. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1835) Better diagnostic reporting if fail to read a configuration flie.
[ https://issues.apache.org/jira/browse/ISIS-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337733#comment-16337733 ] ASF subversion and git services commented on ISIS-1835: --- Commit 4a5e7603ee0d01e26a464ea16a144a19356a02e0 in isis's branch refs/heads/ISIS-1569-replay-commands from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=4a5e760 ] ISIS-1835: catches any type of exception in order to report a problem (an NPE was being thrown if the file wasn't present, rather than an IOException) > Better diagnostic reporting if fail to read a configuration flie. > - > > Key: ISIS-1835 > URL: https://issues.apache.org/jira/browse/ISIS-1835 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.16.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Trivial > Fix For: 1.16.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1569) Automated testing tool to replay commands against a copy of prod
[ https://issues.apache.org/jira/browse/ISIS-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337738#comment-16337738 ] ASF subversion and git services commented on ISIS-1569: --- Commit fad907f97a2e1ae9925feef2bb959deebafb0473 in isis's branch refs/heads/ISIS-1569-replay-commands from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=fad907f ] ISIS-1569: updates XSDs for docs, and adds in the historical previous versions also. > Automated testing tool to replay commands against a copy of prod > > > Key: ISIS-1569 > URL: https://issues.apache.org/jira/browse/ISIS-1569 > Project: Isis > Issue Type: New Feature > Components: Core >Affects Versions: 1.13.2.1 >Reporter: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > eg obtain copy of prod from a month ago > then for all commands since then, replay (simulating the current user and > time for each) > finally, compare resultant database with current prod, and list out > differences in data. > could also use for performance testing, perhaps. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1569) Automated testing tool to replay commands against a copy of prod
[ https://issues.apache.org/jira/browse/ISIS-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337740#comment-16337740 ] ASF subversion and git services commented on ISIS-1569: --- Commit 1e364418932800fb331942ab06a5d5633d6c1403 in isis's branch refs/heads/ISIS-1569-replay-commands from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=1e36441 ] ISIS-1569: updates docs for ContentMappingService, default implementations for Command(s)Dto also removes unused import. > Automated testing tool to replay commands against a copy of prod > > > Key: ISIS-1569 > URL: https://issues.apache.org/jira/browse/ISIS-1569 > Project: Isis > Issue Type: New Feature > Components: Core >Affects Versions: 1.13.2.1 >Reporter: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > eg obtain copy of prod from a month ago > then for all commands since then, replay (simulating the current user and > time for each) > finally, compare resultant database with current prod, and list out > differences in data. > could also use for performance testing, perhaps. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1836) Better diagnostic reporting in RO viewer if passed in a non-parseable value
[ https://issues.apache.org/jira/browse/ISIS-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337734#comment-16337734 ] ASF subversion and git services commented on ISIS-1836: --- Commit 8463f4b55c64f847bfd9a1da5a8b5eeb3dc3def1 in isis's branch refs/heads/ISIS-1569-replay-commands from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=8463f4b ] ISIS-1836: removes chance of an NPE in the RO mapper for an exception (which was in turn resulting in a 500 rather than 422 when invoked an action with an incorrect parameter argument). > Better diagnostic reporting in RO viewer if passed in a non-parseable value > --- > > Key: ISIS-1836 > URL: https://issues.apache.org/jira/browse/ISIS-1836 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.16.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Trivial > Fix For: 1.16.1 > > > was passing transactionId=null for a parameter of type UUID... underlying > issue swallowed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1848) References of type java.lang.Object (sometimes) not rendered correctly in Wicket viewer
[ https://issues.apache.org/jira/browse/ISIS-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337731#comment-16337731 ] ASF subversion and git services commented on ISIS-1848: --- Commit a56f19dad5a628d059fd561c076aa3f5b6edca41 in isis's branch refs/heads/maint-1.16.1 from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=a56f19d ] ISIS-1848: ensures that FreeStandingList does not incorrectly return java.lang.Object's specId, and adds new metamodel validator to detect this situation in future. > References of type java.lang.Object (sometimes) not rendered correctly in > Wicket viewer > --- > > Key: ISIS-1848 > URL: https://issues.apache.org/jira/browse/ISIS-1848 > Project: Isis > Issue Type: Bug >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > This is down to a race condition, I think. > At any rate, the ObjectSpecificationOnStandaloneList for FreeStandingList > (the internal pojo that holds the result of an action invocation) is asked > for its ObjectSpecId. It tries to do this by asking for the value of the > corresponding ObjectSpecIfFacet. > However, no such facet (in some circumstances, presumably) is installed for > this ObjectSpec, and so it searches up the hierarchy. The superclass is > java.lang.Object, and so we return the ObjectSpecId for java.lang.Object. > This in turn causes the cache of ObjectSpecId -> ObjectSpecification's to be > corrupted, with java.lang.Object mapping to the list. > In the Wicket viewer, when attempting to render a reference property of type > java.lang.Object (such as the Task_object mixin for Estatio), the > SpecificationLoader reports that a reference of this type is not isObject() > (because it's using ObjectSpecificationOnStandaloneList), resulting in an > UnknownPanel being selected to render the Wicket model for the reference > property. This simply shows a toString(). > The fix, I think, is to not search up the hierarchy in the case of > ObjectSpecIdFacet... an ObjectSpecification must be able to answer this > question itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1848) References of type java.lang.Object (sometimes) not rendered correctly in Wicket viewer
[ https://issues.apache.org/jira/browse/ISIS-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337732#comment-16337732 ] ASF subversion and git services commented on ISIS-1848: --- Commit b6bb1c77d4240840ee2db354767ba61ed3d0b916 in isis's branch refs/heads/maint-1.16.1 from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=b6bb1c7 ] Merge branch 'ISIS-1848' into maint-1.16.1 > References of type java.lang.Object (sometimes) not rendered correctly in > Wicket viewer > --- > > Key: ISIS-1848 > URL: https://issues.apache.org/jira/browse/ISIS-1848 > Project: Isis > Issue Type: Bug >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > This is down to a race condition, I think. > At any rate, the ObjectSpecificationOnStandaloneList for FreeStandingList > (the internal pojo that holds the result of an action invocation) is asked > for its ObjectSpecId. It tries to do this by asking for the value of the > corresponding ObjectSpecIfFacet. > However, no such facet (in some circumstances, presumably) is installed for > this ObjectSpec, and so it searches up the hierarchy. The superclass is > java.lang.Object, and so we return the ObjectSpecId for java.lang.Object. > This in turn causes the cache of ObjectSpecId -> ObjectSpecification's to be > corrupted, with java.lang.Object mapping to the list. > In the Wicket viewer, when attempting to render a reference property of type > java.lang.Object (such as the Task_object mixin for Estatio), the > SpecificationLoader reports that a reference of this type is not isObject() > (because it's using ObjectSpecificationOnStandaloneList), resulting in an > UnknownPanel being selected to render the Wicket model for the reference > property. This simply shows a toString(). > The fix, I think, is to not search up the hierarchy in the case of > ObjectSpecIdFacet... an ObjectSpecification must be able to answer this > question itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ISIS-1837) Metamodel validator should check for cyclic dependencies (reference to entities that live outside of the module set)
[ https://issues.apache.org/jira/browse/ISIS-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood reassigned ISIS-1837: - Assignee: Dan Haywood > Metamodel validator should check for cyclic dependencies (reference to > entities that live outside of the module set) > > > Key: ISIS-1837 > URL: https://issues.apache.org/jira/browse/ISIS-1837 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.16.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.16.1 > > > at the moment this shows up as an error of an entity referencing a > non-existent repository. This is where the entity is found by walking the > graph outside the set of defined modules, and yet the domain services are > only ever strictly loaded. > The metamodel validator should basically check that every entity and view > model type in the metamodel resides within one of the packages of the set of > modules that make up the application. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337574#comment-16337574 ] ASF subversion and git services commented on ISIS-1846: --- Commit 8ebd31355b1ec18800819f915a41acf166c79d85 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=8ebd313 ] ISIS-1846 thread-safe (atomic) writes to _Context (singleton-store) > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ISIS-1848) References of type java.lang.Object (sometimes) not rendered correctly in Wicket viewer
[ https://issues.apache.org/jira/browse/ISIS-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood reassigned ISIS-1848: - Assignee: Dan Haywood > References of type java.lang.Object (sometimes) not rendered correctly in > Wicket viewer > --- > > Key: ISIS-1848 > URL: https://issues.apache.org/jira/browse/ISIS-1848 > Project: Isis > Issue Type: Bug >Affects Versions: 1.15.1 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > This is down to a race condition, I think. > At any rate, the ObjectSpecificationOnStandaloneList for FreeStandingList > (the internal pojo that holds the result of an action invocation) is asked > for its ObjectSpecId. It tries to do this by asking for the value of the > corresponding ObjectSpecIfFacet. > However, no such facet (in some circumstances, presumably) is installed for > this ObjectSpec, and so it searches up the hierarchy. The superclass is > java.lang.Object, and so we return the ObjectSpecId for java.lang.Object. > This in turn causes the cache of ObjectSpecId -> ObjectSpecification's to be > corrupted, with java.lang.Object mapping to the list. > In the Wicket viewer, when attempting to render a reference property of type > java.lang.Object (such as the Task_object mixin for Estatio), the > SpecificationLoader reports that a reference of this type is not isObject() > (because it's using ObjectSpecificationOnStandaloneList), resulting in an > UnknownPanel being selected to render the Wicket model for the reference > property. This simply shows a toString(). > The fix, I think, is to not search up the hierarchy in the case of > ObjectSpecIdFacet... an ObjectSpecification must be able to answer this > question itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1569) Automated testing tool to replay commands against a copy of prod
[ https://issues.apache.org/jira/browse/ISIS-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337399#comment-16337399 ] ASF subversion and git services commented on ISIS-1569: --- Commit ea6d19a0859df2f4ebf9e673192cda0c083b8dee in isis's branch refs/heads/ISIS-1569-replay-commands from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=ea6d19a ] ISIS-1569: updates docs for ContentMappingService, default implementations for Command(s)Dto also removes unused import. > Automated testing tool to replay commands against a copy of prod > > > Key: ISIS-1569 > URL: https://issues.apache.org/jira/browse/ISIS-1569 > Project: Isis > Issue Type: New Feature > Components: Core >Affects Versions: 1.13.2.1 >Reporter: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > eg obtain copy of prod from a month ago > then for all commands since then, replay (simulating the current user and > time for each) > finally, compare resultant database with current prod, and list out > differences in data. > could also use for performance testing, perhaps. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1569) Automated testing tool to replay commands against a copy of prod
[ https://issues.apache.org/jira/browse/ISIS-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337364#comment-16337364 ] ASF subversion and git services commented on ISIS-1569: --- Commit 4b2d3aedf2bf09b263cf156dc56bd8966d22a0ab in isis's branch refs/heads/ISIS-1569-replay-commands from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=4b2d3ae ] ISIS-1569: removes unused import is all > Automated testing tool to replay commands against a copy of prod > > > Key: ISIS-1569 > URL: https://issues.apache.org/jira/browse/ISIS-1569 > Project: Isis > Issue Type: New Feature > Components: Core >Affects Versions: 1.13.2.1 >Reporter: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > eg obtain copy of prod from a month ago > then for all commands since then, replay (simulating the current user and > time for each) > finally, compare resultant database with current prod, and list out > differences in data. > could also use for performance testing, perhaps. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1569) Automated testing tool to replay commands against a copy of prod
[ https://issues.apache.org/jira/browse/ISIS-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337349#comment-16337349 ] ASF subversion and git services commented on ISIS-1569: --- Commit 3ea05a10b57df56725b6b6d10be5124e2e9dd7c1 in isis's branch refs/heads/ISIS-1569-replay-commands from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=3ea05a1 ] ISIS-1569: removes unused and accidentally committed element in cmd-1.4.xsd > Automated testing tool to replay commands against a copy of prod > > > Key: ISIS-1569 > URL: https://issues.apache.org/jira/browse/ISIS-1569 > Project: Isis > Issue Type: New Feature > Components: Core >Affects Versions: 1.13.2.1 >Reporter: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > eg obtain copy of prod from a month ago > then for all commands since then, replay (simulating the current user and > time for each) > finally, compare resultant database with current prod, and list out > differences in data. > could also use for performance testing, perhaps. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1569) Automated testing tool to replay commands against a copy of prod
[ https://issues.apache.org/jira/browse/ISIS-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337348#comment-16337348 ] ASF subversion and git services commented on ISIS-1569: --- Commit b12a01dbe8b1eabe556ceba32632bf269042236a in isis's branch refs/heads/ISIS-1569-replay-commands from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=b12a01d ] ISIS-1569: updates to XSDs, make sure the version defaultsb are correct. > Automated testing tool to replay commands against a copy of prod > > > Key: ISIS-1569 > URL: https://issues.apache.org/jira/browse/ISIS-1569 > Project: Isis > Issue Type: New Feature > Components: Core >Affects Versions: 1.13.2.1 >Reporter: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > eg obtain copy of prod from a month ago > then for all commands since then, replay (simulating the current user and > time for each) > finally, compare resultant database with current prod, and list out > differences in data. > could also use for performance testing, perhaps. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1569) Automated testing tool to replay commands against a copy of prod
[ https://issues.apache.org/jira/browse/ISIS-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337350#comment-16337350 ] ASF subversion and git services commented on ISIS-1569: --- Commit 49dd518bbe06dd17d417a1c0d42bd9ef6879f423 in isis's branch refs/heads/ISIS-1569-replay-commands from [~danhaywood] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=49dd518 ] ISIS-1569: updates XSDs for docs, and adds in the historical previous versions also. > Automated testing tool to replay commands against a copy of prod > > > Key: ISIS-1569 > URL: https://issues.apache.org/jira/browse/ISIS-1569 > Project: Isis > Issue Type: New Feature > Components: Core >Affects Versions: 1.13.2.1 >Reporter: Dan Haywood >Priority: Major > Fix For: 1.16.1 > > > eg obtain copy of prod from a month ago > then for all commands since then, replay (simulating the current user and > time for each) > finally, compare resultant database with current prod, and list out > differences in data. > could also use for performance testing, perhaps. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ISIS-1843) remove occurences of Thread.currentThread().getContextClassLoader()
[ https://issues.apache.org/jira/browse/ISIS-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber reassigned ISIS-1843: Assignee: Andi Huber > remove occurences of Thread.currentThread().getContextClassLoader() > --- > > Key: ISIS-1843 > URL: https://issues.apache.org/jira/browse/ISIS-1843 > Project: Isis > Issue Type: Sub-task >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > ... replace by calling a singleton (of application-scope) that is responsible > for providing Isis' default class-loader. > We have such a mechanism in 2.0.0-M2 with IsisContext, but this is in > isis-core-runtime, while e.g. the ClassDiscoveryService is in > isis-core-applib and makes calls to > Thread.currentThread().getContextClassLoader() > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1846) API Cleanup: code deduplication
[ https://issues.apache.org/jira/browse/ISIS-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337122#comment-16337122 ] ASF subversion and git services commented on ISIS-1846: --- Commit 62725eb3dfd7cf5c995eb5d943781437bd37e274 in isis's branch refs/heads/ISIS-1846_internal_utils from [~hobrom] [ https://gitbox.apache.org/repos/asf?p=isis.git;h=62725eb ] ISIS-1846 added reviewer notes and questions > API Cleanup: code deduplication > --- > > Key: ISIS-1846 > URL: https://issues.apache.org/jira/browse/ISIS-1846 > Project: Isis > Issue Type: Sub-task > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-M1 > > > isis-core-applib would be the perfect place to consolidate any internal > utility classes such as > NullSafe (common null check idioms), StringExtensions, ordering algorithms, > etc ... > but we would want to keep these classes contained, meaning they should not be > available for public use, just for internal use within Isis' code-base. > Java 9 has the perfect solution for this. But what can we do in the meantime > (with Java 8)? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
