[jira] [Resolved] (ISIS-1916) enhance archetype so runs out-of-the-box in gitlab CI

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1916.
---
Resolution: Fixed

> enhance archetype so runs out-of-the-box in gitlab CI
> -
>
> Key: ISIS-1916
> URL: https://issues.apache.org/jira/browse/ISIS-1916
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-2057) JaxbServiceDefault should handle entity if isn't annotated with XmlJavaTypeAdapter

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-2057.
-

> JaxbServiceDefault should handle entity if isn't annotated with 
> XmlJavaTypeAdapter
> --
>
> Key: ISIS-2057
> URL: https://issues.apache.org/jira/browse/ISIS-2057
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-2024) Centre image or text on sign-in page.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-2024.
-

> Centre image or text on sign-in page.
> -
>
> Key: ISIS-2024
> URL: https://issues.apache.org/jira/browse/ISIS-2024
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>
> backported from 2.0.0-M2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-2053) Improve tabbing behaviour

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-2053.
-

> Improve tabbing behaviour
> -
>
> Key: ISIS-2053
> URL: https://issues.apache.org/jira/browse/ISIS-2053
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-2046) RO viewer should honour x-ro-validate-only

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-2046.
-

> RO viewer should honour x-ro-validate-only
> --
>
> Key: ISIS-2046
> URL: https://issues.apache.org/jira/browse/ISIS-2046
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>
> It claims it does (on the version resource), and yet not.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-2051) Amend ugrov

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-2051.
-

> Amend ugrov 
> 
>
> Key: ISIS-2051
> URL: https://issues.apache.org/jira/browse/ISIS-2051
> Project: Isis
>  Issue Type: Documentation
>Affects Versions: 1.16.2
>Reporter: Jörg Rade
>Assignee: Dan Haywood
>Priority: Trivial
> Fix For: 1.17.0
>
> Attachments: _ugvro_hints-and-tips_troubleshooting.adoc
>
>
> Attachment contains adoc formatted example, in short:
> Exception:
> 'com.sun.xml.bind.v2.runtime.IllegalAnnotationsException: 1 counts of 
> IllegalAnnotationExceptions'
> Solution: 
> Add @XmlAccessorType(XmlAccessType.FIELD) to your domain entity



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-2045) RO viewer does not render body correctly when action validation fails.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-2045.
-

> RO viewer does not render body correctly when action validation fails.
> --
>
> Key: ISIS-2045
> URL: https://issues.apache.org/jira/browse/ISIS-2045
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-2050) Install ObjectSpecIdFacet immediately on creation of ObjectSpecification so can be cached.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-2050.
-

> Install ObjectSpecIdFacet immediately on creation of ObjectSpecification so 
> can be cached.
> --
>
> Key: ISIS-2050
> URL: https://issues.apache.org/jira/browse/ISIS-2050
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-2008) Add null guards in Blob and Clob, to detect errors in application code early

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-2008.
-

> Add null guards in Blob and Clob, to detect errors in application code early
> 
>
> Key: ISIS-2008
> URL: https://issues.apache.org/jira/browse/ISIS-2008
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Trivial
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1965) Enable CI/CD for maint-1.16.3

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1965.
-

> Enable CI/CD for maint-1.16.3
> -
>
> Key: ISIS-1965
> URL: https://issues.apache.org/jira/browse/ISIS-1965
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ISIS-2058) Pre-render home page to avoid wait when first hit webapp after bootstrapping

2018-12-28 Thread Dan Haywood (JIRA)
Dan Haywood created ISIS-2058:
-

 Summary: Pre-render home page to avoid wait when first hit webapp 
after bootstrapping
 Key: ISIS-2058
 URL: https://issues.apache.org/jira/browse/ISIS-2058
 Project: Isis
  Issue Type: Improvement
  Components: Core: Viewer: Wicket
Affects Versions: 1.16.2
Reporter: Dan Haywood
 Fix For: 1.18.0


You can try by rendering the home page in a separate thread during the 
bootstraping

You need to use ComponentRenderer#renderPage(app.getHomePage())

you can do this for any of Isis' pages. You just need to provide their input if 
they require such

 

It is a static method and it creates an artificial RequestCycle for its needs 
(so it doesn't need an HTTP thread)


[this is an cool idea for a small WicketStuff project that uses Wicket 
IInitializer to render the home page in the background as soon as the app is 
started]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1977) Improve flattening for -Drevision=...

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1977.
-

> Improve flattening for -Drevision=...
> -
>
> Key: ISIS-1977
> URL: https://issues.apache.org/jira/browse/ISIS-1977
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>
> Currently flatten-maven-plugin is inherited from the parent pom to all 
> children, and this results in , being 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1974) Reduce time to bootstrap

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1974.
-

> Reduce time to bootstrap
> 
>
> Key: ISIS-1974
> URL: https://issues.apache.org/jira/browse/ISIS-1974
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (ISIS-1916) enhance archetype so runs out-of-the-box in gitlab CI

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood reopened ISIS-1916:
---

as a reminder to document the .gitlab-ci.yml file.

> enhance archetype so runs out-of-the-box in gitlab CI
> -
>
> Key: ISIS-1916
> URL: https://issues.apache.org/jira/browse/ISIS-1916
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1964) ConcurrentModificationException when stating application

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1964.
-

> ConcurrentModificationException when stating application
> 
>
> Key: ISIS-1964
> URL: https://issues.apache.org/jira/browse/ISIS-1964
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.16.2
>Reporter: Vladimir Nisevic
>Priority: Major
> Fix For: 1.17.0
>
>
> Hi Dan, meanwhile we are using 1.16.2 and observe still (more rarely) this 
> exception during startup.
>  
> {code:java}
> 018-06-20 15:10:47.546 [localhost-startStop-1] init ERROR 
> org.apache.isis.viewer.wicket.viewer.IsisWicketApplication - Failed to 
> initialize
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, java.lang.RuntimeException: An error occurred 
> while executing code in a temporary session
> at 
> org.apache.isis.core.runtime.runner.IsisInjectModule.provideIsisSessionFactory(IsisInjectModule.java:109)
> at 
> org.apache.isis.core.runtime.runner.IsisInjectModule.provideIsisSessionFactory(IsisInjectModule.java:109)
> while locating org.apache.isis.core.runtime.system.session.IsisSessionFactory
> for field at 
> org.apache.isis.viewer.wicket.viewer.IsisWicketApplication.isisSessionFactory(IsisWicketApplication.java:155)
> while locating at.a1ta.cll.webapp.CllWebApplication
> 1 error
> at 
> com.google.inject.internal.Errors.throwProvisionExceptionIfErrorsExist(Errors.java:486)
> at 
> com.google.inject.internal.MembersInjectorImpl.injectMembers(MembersInjectorImpl.java:67)
> at 
> com.google.inject.internal.InjectorImpl.injectMembers(InjectorImpl.java:987)
> at 
> org.apache.isis.viewer.wicket.viewer.IsisWicketApplication.init(IsisWicketApplication.java:368)
> at at.a1ta.cll.webapp.CllWebApplication.init(CllWebApplication.java:32)
> at org.apache.wicket.Application.initApplication(Application.java:953)
> at org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:429)
> at org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:353)
> at 
> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:285)
> at 
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:266)
> at 
> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:108)
> at 
> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4590)
> at 
> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5233)
> at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
> at 
> org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:752)
> at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:728)
> at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:734)
> at 
> org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:629)
> at 
> org.apache.catalina.startup.HostConfig$DeployDescriptor.run(HostConfig.java:1839)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.RuntimeException: An error occurred while executing code 
> in a temporary session
> at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactory.doInSession(IsisSessionFactory.java:366)
> at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactory.doInSession(IsisSessionFactory.java:330)
> at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactory.doInSession(IsisSessionFactory.java:317)
> at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactoryBuilder.buildSessionFactory(IsisSessionFactoryBuilder.java:211)
> at 
> org.apache.isis.core.runtime.runner.IsisInjectModule.provideIsisSessionFactory(IsisInjectModule.java:118)
> at 
> org.apache.isis.core.runtime.runner.IsisInjectModule$$FastClassByGuice$$a813f90e.invoke()
> at 
> com.google.inject.internal.ProviderMethod$FastClassProviderMethod.doProvision(ProviderMethod.java:264)
> at 
> com.google.inject.internal.ProviderMethod$Factory.provision(ProviderMethod.java:401)
> at 
> com.google.inject.internal.ProviderMethod$Factory.get(ProviderMethod.java:376)
> at 
> com.google.inject.internal.ProviderToInternalFactoryAdapter$1.call(ProviderToInternalFactoryAdapter.java:46)
> at 
> com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1092)
> at 
> 

[jira] [Closed] (ISIS-1485) MessageService#informUser(...) doesn't seem to be raising an alert for an action returning a Blob

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1485.
-

> MessageService#informUser(...) doesn't seem to be raising an alert for an 
> action returning a Blob
> -
>
> Key: ISIS-1485
> URL: https://issues.apache.org/jira/browse/ISIS-1485
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.13.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>
> {code}
> @Action(semantcs = SAFE)
> public Blob $$() {
> messageService.informUser("Not yet implemented");
> return null;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1916) enhance archetype so runs out-of-the-box in gitlab CI

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1916.
-

> enhance archetype so runs out-of-the-box in gitlab CI
> -
>
> Key: ISIS-1916
> URL: https://issues.apache.org/jira/browse/ISIS-1916
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ISIS-1966) Introduce extension of HasTransactionId that includes sequence number

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1966.
---
Resolution: Fixed

> Introduce extension of HasTransactionId that includes sequence number
> -
>
> Key: ISIS-1966
> URL: https://issues.apache.org/jira/browse/ISIS-1966
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>
> So can SPIs contribute onto it.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1925) Invoking an action on an entity with contributed blobs (or clobs) returning null will result in an NPE.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1925.
-

> Invoking an action on an entity with contributed blobs (or clobs) returning 
> null will result in an NPE.
> ---
>
> Key: ISIS-1925
> URL: https://issues.apache.org/jira/browse/ISIS-1925
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Critical
> Fix For: 1.17.0
>
> Attachments: stack-trace-1.png, stack-trace-2.png
>
>
> Also as per Erik on users ml
> [https://lists.apache.org/thread.html/2055cf053e713d768c36d2cf25632c8bed74bf757a4be4d3ab540b05@%3Cusers.isis.apache.org%3E]
> the first issue he reports suggests that hitting an action returning a Blob 
> via RO also results in this issue.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1912) simpleapp 1.16.2 archetype is missing webapp/resources/Dockerfile

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1912.
-

> simpleapp 1.16.2 archetype is missing webapp/resources/Dockerfile
> -
>
> Key: ISIS-1912
> URL: https://issues.apache.org/jira/browse/ISIS-1912
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1902) Datanucles: plugging in of Isis provided JDO value types is broken

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1902.
-

> Datanucles: plugging in of Isis provided JDO value types is broken
> --
>
> Key: ISIS-1902
> URL: https://issues.apache.org/jira/browse/ISIS-1902
> Project: Isis
>  Issue Type: Bug
>  Components: Core Plugins
>Affects Versions: 1.16.0
>Reporter: Andi Huber
>Assignee: Dan Haywood
>Priority: Blocker
> Fix For: 1.17.0
>
>
> After moving the 'org.apache.isis.objectstore.jdo.datanucleus.valuetypes' 
> from 'runtime' into both new 'core-plugin-jdo-datanucleus', datanulces does 
> no longer register these! 
> This breaks Blob/Clob fetching from persistence layer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ISIS-2025) Extend WrapperFactory with new execution mode to "try" to execute.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-2025.
---
Resolution: Fixed

> Extend WrapperFactory with new execution mode to "try" to execute.
> --
>
> Key: ISIS-2025
> URL: https://issues.apache.org/jira/browse/ISIS-2025
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>
> same as execute, but swallow any validation errors.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ISIS-2043) Allow domain events to be specified at @DomainObject, and make mixins aware of this.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-2043.
---
Resolution: Fixed

> Allow domain events to be specified at @DomainObject, and make mixins aware 
> of this.
> 
>
> Key: ISIS-2043
> URL: https://issues.apache.org/jira/browse/ISIS-2043
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>
> Thus:
> {code:java}
> @DomainObject(
> ...,
> actionDomainEvent=IncomingInvoice.ActionDomainEvent.class, 
> propertyDomainEvent=IncomingInvoice.PropertyDomainEvent.class,
> collectionDomainEVent=IncomingInvoice.CollectionDomainEvent.class
> )
> public class IncomingInvoice {
>   public static class ActionDomainEvent 
>   extends o.a.i.applib.services.eventbus.ActionDomainEvent {}
>   // etc
> }{code}
> then, for this domain event would be used as the default for any actions etc.
> Two refinements to this:
> a) for mixins, the event type emitted by a mixin action should be that of its 
> mixee if possible.  This does mean that the domain event must use  as 
> its generic type, because the source could either be the regular domain 
> object or a mixin.  This seems reasonable, the subscriber can just call 
> ev.getMixee() to determine the original source.
> b) as a metamodel validation, if there are members that already define their 
> own event types, then these event types should inherit from the types defined 
> in @DomainObject.  However, not sure exactly how well this plays with 
> requirement from (a) that the generic type is .
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ISIS-1997) For an alternative for non-obtrusive bulk entry of info, use a sidebar as action prompt (for top-level actions only).

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1997.
---
Resolution: Fixed

> For an alternative for non-obtrusive bulk entry of info, use a sidebar as 
> action prompt (for top-level actions only).
> -
>
> Key: ISIS-1997
> URL: https://issues.apache.org/jira/browse/ISIS-1997
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
> Attachments: sketch.pptx
>
>
> add new @ActionLayout(prompt=SIDEBAR), only for "top-level" actions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1888) Tweak/add CSS class names to better support E2E tests (page object selectors)

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1888.
-
Resolution: Fixed

no doc changes required

> Tweak/add CSS class names to better support E2E tests (page object selectors)
> -
>
> Key: ISIS-1888
> URL: https://issues.apache.org/jira/browse/ISIS-1888
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2051) Amend ugrov

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730245#comment-16730245
 ] 

ASF subversion and git services commented on ISIS-2051:
---

Commit b5bb2240293d82619ea37bac09ba78d327eb2568 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b5bb224 ]

ISIS-2051: adds troubleshooting hint for ugvro


> Amend ugrov 
> 
>
> Key: ISIS-2051
> URL: https://issues.apache.org/jira/browse/ISIS-2051
> Project: Isis
>  Issue Type: Documentation
>Affects Versions: 1.16.2
>Reporter: Jörg Rade
>Assignee: Dan Haywood
>Priority: Trivial
> Fix For: 1.17.0
>
> Attachments: _ugvro_hints-and-tips_troubleshooting.adoc
>
>
> Attachment contains adoc formatted example, in short:
> Exception:
> 'com.sun.xml.bind.v2.runtime.IllegalAnnotationsException: 1 counts of 
> IllegalAnnotationExceptions'
> Solution: 
> Add @XmlAccessorType(XmlAccessType.FIELD) to your domain entity



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ISIS-2051) Amend ugrov

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-2051.
---
Resolution: Fixed

> Amend ugrov 
> 
>
> Key: ISIS-2051
> URL: https://issues.apache.org/jira/browse/ISIS-2051
> Project: Isis
>  Issue Type: Documentation
>Affects Versions: 1.16.2
>Reporter: Jörg Rade
>Assignee: Dan Haywood
>Priority: Trivial
> Fix For: 1.17.0
>
> Attachments: _ugvro_hints-and-tips_troubleshooting.adoc
>
>
> Attachment contains adoc formatted example, in short:
> Exception:
> 'com.sun.xml.bind.v2.runtime.IllegalAnnotationsException: 1 counts of 
> IllegalAnnotationExceptions'
> Solution: 
> Add @XmlAccessorType(XmlAccessType.FIELD) to your domain entity



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2057) JaxbServiceDefault should handle entity if isn't annotated with XmlJavaTypeAdapter

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730243#comment-16730243
 ] 

ASF subversion and git services commented on ISIS-2057:
---

Commit 9cfacbde319d519c73a466bdab100a6c9d176ba9 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9cfacbd ]

ISIS-2057: checks if annotated


> JaxbServiceDefault should handle entity if isn't annotated with 
> XmlJavaTypeAdapter
> --
>
> Key: ISIS-2057
> URL: https://issues.apache.org/jira/browse/ISIS-2057
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2050) Install ObjectSpecIdFacet immediately on creation of ObjectSpecification so can be cached.

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730244#comment-16730244
 ] 

ASF subversion and git services commented on ISIS-2050:
---

Commit 45ded3b101b28cf452ccbf19dcb4e6fcbd6fb704 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=45ded3b ]

ISIS-2050: ignoring broken tests.


> Install ObjectSpecIdFacet immediately on creation of ObjectSpecification so 
> can be cached.
> --
>
> Key: ISIS-2050
> URL: https://issues.apache.org/jira/browse/ISIS-2050
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1899) Release tasks for 1.17.0

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1899:
--
Summary: Release tasks for 1.17.0  (was: Release tasks for 1.16.3)

> Release tasks for 1.17.0
> 
>
> Key: ISIS-1899
> URL: https://issues.apache.org/jira/browse/ISIS-1899
> Project: Isis
>  Issue Type: Task
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1993) allow factory actions to be associated with both properties and parameters.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1993:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> allow factory actions to be associated with both properties and parameters.
> ---
>
> Key: ISIS-1993
> URL: https://issues.apache.org/jira/browse/ISIS-1993
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> {code:java}
> @Property(createRepository=Supplier.Repository.class, createAction="create")
> @Getter @Setter Party supplier;{code}
> and
> {code:java}
> public IncomingInvoice edit(
> @Parameter(createRepository=Supplier.Repository.class, 
> createAction="create")
> Party supplier,
> ...
> ) {
>...
> }{code}
>  
> to invoke a nominated action "in-situ".
> This could be bound to a keystroke, eg "F3"
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1992) [WON'T FIX] Actions associated with the panel should optionally be rendered "in-place" (rather than modal).

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1992.
-

> [WON'T FIX] Actions associated with the panel should optionally be rendered 
> "in-place" (rather than modal).
> ---
>
> Key: ISIS-1992
> URL: https://issues.apache.org/jira/browse/ISIS-1992
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2050) Install ObjectSpecIdFacet immediately on creation of ObjectSpecification so can be cached.

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730237#comment-16730237
 ] 

ASF subversion and git services commented on ISIS-2050:
---

Commit 45ded3b101b28cf452ccbf19dcb4e6fcbd6fb704 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=45ded3b ]

ISIS-2050: ignoring broken tests.


> Install ObjectSpecIdFacet immediately on creation of ObjectSpecification so 
> can be cached.
> --
>
> Key: ISIS-2050
> URL: https://issues.apache.org/jira/browse/ISIS-2050
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1999) For action mixins, allow read-only properties and collections to be defined, to show useful/relevant context data.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1999:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> For action mixins, allow read-only properties and collections to be defined, 
> to show useful/relevant context data.
> --
>
> Key: ISIS-1999
> URL: https://issues.apache.org/jira/browse/ISIS-1999
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
> Attachments: sketch.pptx
>
>
> These would simply be rendered underneath the OK/Cancel button.
> One property might also show help markup, or hyperlink to reference guides 
> etc.
> As a refinement (perhaps split out to separate story), allow a layout file 
> (with same name( as mixin to be specified.   Perhaps this might even (through 
> some extension to the existing syntax) allow the parameters to be laid out 
> differently, eg over multiple columns).
> ~~~
> * https://bootstrapious.com/p/bootstrap-sidebar
> * https://bootsnipp.com/tags/sidebar
> * 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2051) Amend ugrov

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730238#comment-16730238
 ] 

ASF subversion and git services commented on ISIS-2051:
---

Commit b5bb2240293d82619ea37bac09ba78d327eb2568 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b5bb224 ]

ISIS-2051: adds troubleshooting hint for ugvro


> Amend ugrov 
> 
>
> Key: ISIS-2051
> URL: https://issues.apache.org/jira/browse/ISIS-2051
> Project: Isis
>  Issue Type: Documentation
>Affects Versions: 1.16.2
>Reporter: Jörg Rade
>Priority: Trivial
> Fix For: 1.17.0
>
> Attachments: _ugvro_hints-and-tips_troubleshooting.adoc
>
>
> Attachment contains adoc formatted example, in short:
> Exception:
> 'com.sun.xml.bind.v2.runtime.IllegalAnnotationsException: 1 counts of 
> IllegalAnnotationExceptions'
> Solution: 
> Add @XmlAccessorType(XmlAccessType.FIELD) to your domain entity



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-2004) Concurrent Modification Exception in grid service

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-2004:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> Concurrent Modification Exception in grid service
> -
>
> Key: ISIS-2004
> URL: https://issues.apache.org/jira/browse/ISIS-2004
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> This occurred when invoking "latestFastnetImportLog" within Estatio (having 
> just restarted, in estatio-test - prototype mode)
> {code}
> 11:20:44,677 [RequestCycleExtra ] Handling the following exception
> org.apache.wicket.WicketRuntimeException: Error attaching this container for 
> rendering: [RepeatingViewWithDynamicallyVisibleContent [Component id = 
> tabGroups]]
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1837)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at 
> org.apache.wicket.markup.repeater.AbstractRepeater.onBeforeRender(AbstractRepeater.java:143)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at 
> org.apache.wicket.markup.repeater.AbstractRepeater.onBeforeRender(AbstractRepeater.java:143)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at 
> org.apache.wicket.markup.repeater.AbstractRepeater.onBeforeRender(AbstractRepeater.java:143)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
>   at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
>   at org.apache.wicket.Page.onBeforeRender(Page.java:801)
>   at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
>   at org.apache.wicket.Component.beforeRender(Component.java:1018)
>   at 
> org.apache.wicket.Component.internalPrepareForRender(Component.java:2236)
>   at org.apache.wicket.Page.internalPrepareForRender(Page.java:242)
>   at org.apache.wicket.Component.render(Component.java:2325)
>   at 

[jira] [Updated] (ISIS-2002) Allow RO viewer to define actions accepting an (JAXB) DTO as a value, to be invoked with appropriate Content-Type so that can be deserialized.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-2002:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> Allow RO viewer to define actions accepting an (JAXB) DTO as a value, to be 
> invoked with appropriate Content-Type so that can be deserialized.
> --
>
> Key: ISIS-2002
> URL: https://issues.apache.org/jira/browse/ISIS-2002
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-2054) Reduce memory pressure when reducing calls on getMethod(byName) when looking up annotations.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-2054:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> Reduce memory pressure when reducing calls on getMethod(byName) when looking 
> up annotations.
> 
>
> Key: ISIS-2054
> URL: https://issues.apache.org/jira/browse/ISIS-2054
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> Comment by Andi ...
> think this relates to just noticed we can improve performance of specloader 
> initialization by tweaking ... 
> org.apache.isis.core.metamodel.facets.Annotations such that annotation lookup 
> does no longer call getMethod(byName, ...) 
> this produces a huge amount of stack-trace objects that pollute the heap
> This has already been parallelized, but I think the bottleneck could be 
> memory related :)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-2000) Display an optional help page in a sidebar, eg on the right.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-2000:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> Display an optional help page in a sidebar, eg on the right.
> 
>
> Key: ISIS-2000
> URL: https://issues.apache.org/jira/browse/ISIS-2000
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1994) Render collection of objects as tabs

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1994:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> Render collection of objects as tabs
> 
>
> Key: ISIS-1994
> URL: https://issues.apache.org/jira/browse/ISIS-1994
> Project: Isis
>  Issue Type: New Feature
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1998) Simplify syntax way for mixins, to better express intent using @Action, @Collection and @Property

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1998:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> Simplify syntax way for mixins, to better express intent using @Action, 
> @Collection and @Property
> -
>
> Key: ISIS-1998
> URL: https://issues.apache.org/jira/browse/ISIS-1998
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> that is:
>  * for actions with @Action annotation at class level (replacing @Mixin), new 
> mixinMethod="act". Also allow @ActionLayout at top-level
>  * for collections, ditto @Collection, new mixinMethod="coll"; 
> @CollectionLayout
>  * for properties, ditto @Property, mixinMethod="prop" and @PropertyLayout



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1995) Render collection of objects as panels

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1995:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> Render collection of objects as panels
> --
>
> Key: ISIS-1995
> URL: https://issues.apache.org/jira/browse/ISIS-1995
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-2001) Dynamically hide/disable/default action parameters (based on other parameter arguments)

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-2001:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> Dynamically hide/disable/default action parameters (based on other parameter 
> arguments)
> ---
>
> Key: ISIS-2001
> URL: https://issues.apache.org/jira/browse/ISIS-2001
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (ISIS-1996) [DUPLICATE, WON'T FIX] For non-obtrusive bulk entry of info, use panel/fieldset as action prompt (for actions associated with panel).

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood closed ISIS-1996.
-

> [DUPLICATE, WON'T FIX] For non-obtrusive bulk entry of info, use 
> panel/fieldset as action prompt (for actions associated with panel).
> -
>
> Key: ISIS-1996
> URL: https://issues.apache.org/jira/browse/ISIS-1996
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>
> intepret @ActionLayout(prompt=INLINE|INLINE,position=PANEL|PANEL_DROPDOWN) to 
> temporarily replace the panel with the dialog



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1996) [DUPLICATE, WON'T FIX] For non-obtrusive bulk entry of info, use panel/fieldset as action prompt (for actions associated with panel).

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1996:
--
Summary: [DUPLICATE, WON'T FIX] For non-obtrusive bulk entry of info, use 
panel/fieldset as action prompt (for actions associated with panel).  (was: For 
non-obtrusive bulk entry of info, use panel/fieldset as action prompt (for 
actions associated with panel).)

> [DUPLICATE, WON'T FIX] For non-obtrusive bulk entry of info, use 
> panel/fieldset as action prompt (for actions associated with panel).
> -
>
> Key: ISIS-1996
> URL: https://issues.apache.org/jira/browse/ISIS-1996
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>
> intepret @ActionLayout(prompt=INLINE|INLINE,position=PANEL|PANEL_DROPDOWN) to 
> temporarily replace the panel with the dialog



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ISIS-1996) [DUPLICATE, WON'T FIX] For non-obtrusive bulk entry of info, use panel/fieldset as action prompt (for actions associated with panel).

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1996.
---
Resolution: Duplicate

seems to be a duplicate of ISIS-1992 (which, incidentally, is a WON'T FIX)

> [DUPLICATE, WON'T FIX] For non-obtrusive bulk entry of info, use 
> panel/fieldset as action prompt (for actions associated with panel).
> -
>
> Key: ISIS-1996
> URL: https://issues.apache.org/jira/browse/ISIS-1996
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>
> intepret @ActionLayout(prompt=INLINE|INLINE,position=PANEL|PANEL_DROPDOWN) to 
> temporarily replace the panel with the dialog



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ISIS-1992) [WON'T FIX] Actions associated with the panel should optionally be rendered "in-place" (rather than modal).

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1992.
---
Resolution: Won't Fix

ISIS-1997 (sidebar dialog) may suffice.

> [WON'T FIX] Actions associated with the panel should optionally be rendered 
> "in-place" (rather than modal).
> ---
>
> Key: ISIS-1992
> URL: https://issues.apache.org/jira/browse/ISIS-1992
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1992) [WON'T FIX] Actions associated with the panel should optionally be rendered "in-place" (rather than modal).

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1992:
--
Summary: [WON'T FIX] Actions associated with the panel should optionally be 
rendered "in-place" (rather than modal).  (was: Actions associated with the 
panel should optionally be rendered "in-place" (rather than modal).)

> [WON'T FIX] Actions associated with the panel should optionally be rendered 
> "in-place" (rather than modal).
> ---
>
> Key: ISIS-1992
> URL: https://issues.apache.org/jira/browse/ISIS-1992
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1984) Extend RO representation to show property format or type in object members

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1984:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> Extend RO representation to show property format or type in object members
> --
>
> Key: ISIS-1984
> URL: https://issues.apache.org/jira/browse/ISIS-1984
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
> Attachments: contactnumber21.json
>
>
> See attached json representation of a contact number
> "x-isis-format": "string"
> is present in string properties
> however, this attribute is not on object properties.
> It would be very benefitial to have all I need to render that property in 
> this page only. Ideally, something like
> "x-isis-returntype" with the url to the domain-type (e.g. 
> [http://localhost:8080/restful/domain-types/org.incode.eurocommercial.contactapp.dom.number.ContactNumber/properties/owner])
> for now, I will render any non-string as a generic catch all object viewer
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1973) "republish" mixin - action button is rendered but attempting to invoke throws an exception

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1973:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> "republish" mixin - action button is rendered but attempting to invoke throws 
> an exception
> --
>
> Key: ISIS-1973
> URL: https://issues.apache.org/jira/browse/ISIS-1973
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> h2. To reproduce:
>  * login with estatio-user-it, ensure has "estatio-user" role but doesn't 
> have "estatio-superuser" role. 
> - navigate to 
> http://estatiotest.int.prd.ecpnv.com/wicket/entity/org.estatio.dom.invoice.Invoice:106874
> - the "republish" action (contributed from 
> - when invoke, get an exception in the UI, with stack trace below:
>  
> message shown to user:
> Reason: Not authorized to view. Identifier: 
> org.isisaddons.module.publishmq.dom.jdo.events.PublishedEvent_republish#$$()
> stack trace:
> {code}
> Caused by: org.apache.isis.core.commons.exceptions.IsisApplicationException: 
> org.apache.isis.applib.services.wrapper.HiddenException: Reason: Not 
> authorized to view. Identifier: 
> org.isisaddons.module.publishmq.dom.jdo.events.PublishedEvent_republish#$$()
>  at 
> org.apache.isis.core.commons.lang.ThrowableExtensions.throwWithinIsisException(ThrowableExtensions.java:55)
>  at 
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract$2.execute(ActionInvocationFacetForDomainEventAbstract.java:303)
>  at 
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract$2.execute(ActionInvocationFacetForDomainEventAbstract.java:222)
>  at 
> org.apache.isis.applib.services.iactn.Interaction.executeInternal(Interaction.java:173)
>  at 
> org.apache.isis.applib.services.iactn.Interaction.execute(Interaction.java:143)
>  at 
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract.doInvoke(ActionInvocationFacetForDomainEventAbstract.java:310)
>  at 
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract$1.execute(ActionInvocationFacetForDomainEventAbstract.java:164)
>  at 
> org.apache.isis.core.runtime.system.transaction.IsisTransactionManager.executeWithinTransaction(IsisTransactionManager.java:142)
>  at 
> org.apache.isis.core.runtime.system.transaction.IsisTransactionManager.executeWithinTransaction(IsisTransactionManager.java:132)
>  at 
> org.apache.isis.core.runtime.services.persistsession.PersistenceSessionServiceInternalDefault.executeWithinTransaction(PersistenceSessionServiceInternalDefault.java:192)
>  at 
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract.invoke(ActionInvocationFacetForDomainEventAbstract.java:160)
>  at 
> org.apache.isis.core.metamodel.specloader.specimpl.ObjectActionDefault.executeInternal(ObjectActionDefault.java:400)
>  at 
> org.apache.isis.core.metamodel.specloader.specimpl.ObjectActionMixedIn.execute(ObjectActionMixedIn.java:230)
>  at 
> org.apache.isis.core.metamodel.specloader.specimpl.ObjectActionDefault.executeWithRuleChecking(ObjectActionDefault.java:370)
>  at 
> org.apache.isis.viewer.wicket.model.models.ActionModel.executeAction(ActionModel.java:460)
>  at 
> org.apache.isis.viewer.wicket.model.models.ActionModel.load(ActionModel.java:439)
>  at 
> org.apache.isis.viewer.wicket.model.models.ActionModel.load(ActionModel.java:76)
>  at 
> org.apache.wicket.model.LoadableDetachableModel.getObject(LoadableDetachableModel.java:135)
>  at 
> org.apache.isis.viewer.wicket.model.models.ActionModel.execute(ActionModel.java:569)
>  at 
> org.apache.isis.viewer.wicket.ui.components.actions.ActionFormExecutorStrategy.obtainResultAdapter(ActionFormExecutorStrategy.java:71)
>  at 
> org.apache.isis.viewer.wicket.ui.panels.FormExecutorDefault.obtainResultAdapter(FormExecutorDefault.java:514)
>  at 
> org.apache.isis.viewer.wicket.ui.panels.FormExecutorDefault.executeAndProcessResults(FormExecutorDefault.java:147)
>  at 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLinkFactoryAbstract.onClick(ActionLinkFactoryAbstract.java:214)
>  at 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLinkFactoryAbstract.access$100(ActionLinkFactoryAbstract.java:71)
>  at 
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLinkFactoryAbstract$1.performOnClick(ActionLinkFactoryAbstract.java:147)
>  at 
> 

[jira] [Updated] (ISIS-1980) Unexpected error when accessing collection through wrapper.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1980:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> Unexpected error when accessing collection through wrapper.
> ---
>
> Key: ISIS-1980
> URL: https://issues.apache.org/jira/browse/ISIS-1980
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.16.2
>Reporter: Andi Huber
>Priority: Major
> Fix For: 1.18.0
>
>
> As reported by Gabriel Terwesten  [1]
> Inside of integration tests i can’t seem to access collections through the 
> getter if the object is wrapped. From the documentation I got the impression 
> that that should be possible. 
> This is the offending line:
> assertThat(wrap(food).getCustomUnits()).hasSize(1);
> {noformat}
> IllegalArgumentException: d.m.c.d.i.Food#customUnits: more than one 
> ImperativeFacet for method getCustomUnits , with inconsistent intents: ...
> at o.a.i.c.m.facets.ImperativeFacet$Util.getIntent(ImperativeFacet.java:167)
> {noformat}
> [1] 
> https://lists.apache.org/thread.html/cd92d8cd28ae877104fc965f83ca90b98e2e8188f464b65181e79a27@%3Cusers.isis.apache.org%3E



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ISIS-1964) ConcurrentModificationException when stating application

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1964.
---
Resolution: Fixed

assuming this is fixed via ISIS-2050 and other similar tickets.

> ConcurrentModificationException when stating application
> 
>
> Key: ISIS-1964
> URL: https://issues.apache.org/jira/browse/ISIS-1964
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.16.2
>Reporter: Vladimir Nisevic
>Priority: Major
> Fix For: 1.17.0
>
>
> Hi Dan, meanwhile we are using 1.16.2 and observe still (more rarely) this 
> exception during startup.
>  
> {code:java}
> 018-06-20 15:10:47.546 [localhost-startStop-1] init ERROR 
> org.apache.isis.viewer.wicket.viewer.IsisWicketApplication - Failed to 
> initialize
> com.google.inject.ProvisionException: Unable to provision, see the following 
> errors:
> 1) Error in custom provider, java.lang.RuntimeException: An error occurred 
> while executing code in a temporary session
> at 
> org.apache.isis.core.runtime.runner.IsisInjectModule.provideIsisSessionFactory(IsisInjectModule.java:109)
> at 
> org.apache.isis.core.runtime.runner.IsisInjectModule.provideIsisSessionFactory(IsisInjectModule.java:109)
> while locating org.apache.isis.core.runtime.system.session.IsisSessionFactory
> for field at 
> org.apache.isis.viewer.wicket.viewer.IsisWicketApplication.isisSessionFactory(IsisWicketApplication.java:155)
> while locating at.a1ta.cll.webapp.CllWebApplication
> 1 error
> at 
> com.google.inject.internal.Errors.throwProvisionExceptionIfErrorsExist(Errors.java:486)
> at 
> com.google.inject.internal.MembersInjectorImpl.injectMembers(MembersInjectorImpl.java:67)
> at 
> com.google.inject.internal.InjectorImpl.injectMembers(InjectorImpl.java:987)
> at 
> org.apache.isis.viewer.wicket.viewer.IsisWicketApplication.init(IsisWicketApplication.java:368)
> at at.a1ta.cll.webapp.CllWebApplication.init(CllWebApplication.java:32)
> at org.apache.wicket.Application.initApplication(Application.java:953)
> at org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:429)
> at org.apache.wicket.protocol.http.WicketFilter.init(WicketFilter.java:353)
> at 
> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:285)
> at 
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:266)
> at 
> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:108)
> at 
> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4590)
> at 
> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5233)
> at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
> at 
> org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:752)
> at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:728)
> at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:734)
> at 
> org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:629)
> at 
> org.apache.catalina.startup.HostConfig$DeployDescriptor.run(HostConfig.java:1839)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.RuntimeException: An error occurred while executing code 
> in a temporary session
> at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactory.doInSession(IsisSessionFactory.java:366)
> at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactory.doInSession(IsisSessionFactory.java:330)
> at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactory.doInSession(IsisSessionFactory.java:317)
> at 
> org.apache.isis.core.runtime.system.session.IsisSessionFactoryBuilder.buildSessionFactory(IsisSessionFactoryBuilder.java:211)
> at 
> org.apache.isis.core.runtime.runner.IsisInjectModule.provideIsisSessionFactory(IsisInjectModule.java:118)
> at 
> org.apache.isis.core.runtime.runner.IsisInjectModule$$FastClassByGuice$$a813f90e.invoke()
> at 
> com.google.inject.internal.ProviderMethod$FastClassProviderMethod.doProvision(ProviderMethod.java:264)
> at 
> com.google.inject.internal.ProviderMethod$Factory.provision(ProviderMethod.java:401)
> at 
> com.google.inject.internal.ProviderMethod$Factory.get(ProviderMethod.java:376)
> at 
> com.google.inject.internal.ProviderToInternalFactoryAdapter$1.call(ProviderToInternalFactoryAdapter.java:46)
> at 
> com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1092)
> at 

[jira] [Commented] (ISIS-2057) JaxbServiceDefault should handle entity if isn't annotated with XmlJavaTypeAdapter

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730216#comment-16730216
 ] 

ASF subversion and git services commented on ISIS-2057:
---

Commit 9cfacbde319d519c73a466bdab100a6c9d176ba9 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9cfacbd ]

ISIS-2057: checks if annotated


> JaxbServiceDefault should handle entity if isn't annotated with 
> XmlJavaTypeAdapter
> --
>
> Key: ISIS-2057
> URL: https://issues.apache.org/jira/browse/ISIS-2057
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ISIS-2057) JaxbServiceDefault should handle entity if isn't annotated with XmlJavaTypeAdapter

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-2057.
---
Resolution: Fixed

> JaxbServiceDefault should handle entity if isn't annotated with 
> XmlJavaTypeAdapter
> --
>
> Key: ISIS-2057
> URL: https://issues.apache.org/jira/browse/ISIS-2057
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.17.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ISIS-2057) JaxbServiceDefault should handle entity if isn't annotated with XmlJavaTypeAdapter

2018-12-28 Thread Dan Haywood (JIRA)
Dan Haywood created ISIS-2057:
-

 Summary: JaxbServiceDefault should handle entity if isn't 
annotated with XmlJavaTypeAdapter
 Key: ISIS-2057
 URL: https://issues.apache.org/jira/browse/ISIS-2057
 Project: Isis
  Issue Type: Improvement
Affects Versions: 1.16.2
Reporter: Dan Haywood
Assignee: Dan Haywood
 Fix For: 1.17.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1936) FK exception on delete action not rendered to user correctly.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1936:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> FK exception on delete action not rendered to user correctly.
> -
>
> Key: ISIS-1936
> URL: https://issues.apache.org/jira/browse/ISIS-1936
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> To reproduce:
>  * for simpleapp, introduce a child entity (not cascade)
>  * delete parent entity to force an FK exception (due to child entities still 
> present)
> this results in a 500 html exception (RestartResponseException).  the FK 
> exception messages are queued and only rendered subsequently.
> (Also, see two exceptions queued, one warning - orange - and one error - red).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1937) NPE when render domain entity for first time that has contributed action on contributed collection.

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1937:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> NPE when render domain entity for first time that has contributed action on 
> contributed collection.
> ---
>
> Key: ISIS-1937
> URL: https://issues.apache.org/jira/browse/ISIS-1937
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> for example
> [https://github.com/danhaywood/busydevtutorial]
> in Pets.layout.xml, remove the "visits" collection to reproduce.  The 
> contributed Pet_bookVisit action causes the issue because its "owner" is not 
> declared and so returns null.
>  
> {code:java}
> Caused by: java.lang.NullPointerException
> at 
> org.apache.isis.core.metamodel.services.grid.bootstrap3.GridSystemServiceBS3.addActionTo(GridSystemServiceBS3.java:661)
> at 
> org.apache.isis.core.metamodel.services.grid.bootstrap3.GridSystemServiceBS3.validateAndNormalize(GridSystemServiceBS3.java:529)
> at 
> org.apache.isis.core.metamodel.services.grid.GridSystemServiceAbstract.normalize(GridSystemServiceAbstract.java:165)
> at 
> org.apache.isis.core.metamodel.services.grid.GridServiceDefault.normalize(GridServiceDefault.java:102)
> at 
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.load(GridFacetDefault.java:75)
> at 
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.getGrid(GridFacetDefault.java:65)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.addPropertyColumnsIfRequired(CollectionContentsAsAjaxTablePanel.java:170)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.buildGui(CollectionContentsAsAjaxTablePanel.java:102)
> at 
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.onInitialize(CollectionContentsAsAjaxTablePanel.java:80)
> at org.apache.wicket.Component.fireInitialize(Component.java:878)
> at 
> org.apache.wicket.MarkupContainer.internalInitialize(MarkupContainer.java:1070)
> at org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:1047)
> at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:241)
> at org.apache.wicket.MarkupContainer.addOrReplace(MarkupContainer.java:265)
> at{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1938) Unable to specify FakeDataModule as a dependency using ModuleAbstract#withAdditionalDependencies

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1938:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> Unable to specify FakeDataModule as a dependency using 
> ModuleAbstract#withAdditionalDependencies
> 
>
> Key: ISIS-1938
> URL: https://issues.apache.org/jira/browse/ISIS-1938
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> as a workaround, had to override getDependencies()
> {code:java}
> java.lang.IllegalArgumentException: Module domainapp.modules.PetClinicModule 
> has returned class org.isisaddons.module.fakedata.FakeDataModule from 
> getAdditionalModules(). This class implements 'Module' interface so should 
> instead be returned from getDependencies()
> at 
> org.apache.isis.applib.Module$Util.transitiveAdditionalModulesOf(Module.java:150)
> at 
> org.apache.isis.applib.ModuleOrBuilderAbstract.withTransitiveFrom(ModuleOrBuilderAbstract.java:66)
> at 
> org.apache.isis.applib.AppManifestAbstract2$Builder.(AppManifestAbstract2.java:99)
> at 
> org.apache.isis.applib.AppManifestAbstract2$Builder.forModule(AppManifestAbstract2.java:92)
> at 
> org.apache.isis.core.runtime.headless.IsisSystemBootstrapper.(IsisSystemBootstrapper.java:60)
> at 
> org.apache.isis.core.runtime.headless.HeadlessWithBootstrappingAbstract.(HeadlessWithBootstrappingAbstract.java:94)
> at 
> org.apache.isis.core.integtestsupport.IntegrationTestAbstract3.(IntegrationTestAbstract3.java:160)
> at 
> org.apache.isis.core.integtestsupport.IntegrationTestAbstract3.(IntegrationTestAbstract3.java:154)
> at 
> domainapp.modules.impl.PetClinicModuleIntegTestAbstract.(PetClinicModuleIntegTestAbstract.java:34)
> at 
> domainapp.modules.impl.visits.integtests.Visit_enterOutcome_IntegTest.(Visit_enterOutcome_IntegTest.java:37)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at 
> org.junit.runners.BlockJUnit4ClassRunner.createTest(BlockJUnit4ClassRunner.java:217)
> at 
> org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:266)
> at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at 
> org.junit.runners.BlockJUnit4ClassRunner.methodBlock(BlockJUnit4ClassRunner.java:263)
> at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ISIS-1485) MessageService#informUser(...) doesn't seem to be raising an alert for an action returning a Blob

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1485.
---
Resolution: Fixed

> MessageService#informUser(...) doesn't seem to be raising an alert for an 
> action returning a Blob
> -
>
> Key: ISIS-1485
> URL: https://issues.apache.org/jira/browse/ISIS-1485
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.13.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.17.0
>
>
> {code}
> @Action(semantcs = SAFE)
> public Blob $$() {
> messageService.informUser("Not yet implemented");
> return null;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1927) Invoking an action returning a non-null Blob via RO results in exception

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1927:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> Invoking an action returning a non-null Blob via RO results in exception
> 
>
> Key: ISIS-1927
> URL: https://issues.apache.org/jira/browse/ISIS-1927
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> Also as per Erik on users ml
> [https://lists.apache.org/thread.html/2055cf053e713d768c36d2cf25632c8bed74bf757a4be4d3ab540b05@%3Cusers.isis.apache.org%3E]
> the second issue he reports suggests that hitting an action returning a  
> non-null Blob via RO results in an exception in OidUtils. 
>  
> {code:java}
> public static String getOidStr(final ObjectAdapter objectAdapter) {
>   final Oid oid = objectAdapter.getOid();
>   if (!(oid instanceof RootOid)) {
> throw new IllegalArgumentException("objectAdapter must be a root 
> adapter");
>   }
>   return oid.enStringNoVersion();
> }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ISIS-1926) Why do we create an ActionInvocationDto for a mixin property anyway ?

2018-12-28 Thread Dan Haywood (JIRA)


 [ 
https://issues.apache.org/jira/browse/ISIS-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1926:
--
Fix Version/s: (was: 1.17.0)
   1.18.0

> Why do we create an ActionInvocationDto for a mixin property anyway ?
> -
>
> Key: ISIS-1926
> URL: https://issues.apache.org/jira/browse/ISIS-1926
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> see ISIS-1925



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


v2 - explicit vs implicit annotations

2018-12-28 Thread Dan Haywood
Hi folks,

... and happy holidays!

We currently have the configuration property
"isis.reflector.explicitAnnotations.action" which if specified
requires @Action to be added as an annotation for all public methods that
don't represent properties/collections or supporting methods.  If this is
enabled then there's generally no need to annotate public methods that
aren't meant to be in the metamodel with the @Programmatic annotation.

Andi and I have just been discussing this (off-list) and wondering if we
should extend this in v2.  Our idea is maybe to allow this to be specified
at the class level, and to also have three levels rather than two:

- explicit : all properties, collections and actions must be annotated
- actions : actions must be annotated, but properties and collections need
not.  This is the behavior if the above configuration property is specified.
- implicit : no annotations are required.  This is the current default

So, we were thinking to add a value to @DomainObject, eg

@DomainObject(metamodelDiscoveryStrategy = EXPLICIT | ACTIONS | IMPLICIT |
AS_CONFIGURED)

where "AS_CONFIGURED" would read a new configuration property that would
take these three values (replacing the existing
"isis.reflector.explicitAnnotations.action".

Two questions:

1. is the idea of a new level to explicitly annotate everything (properties
and collections as well as actions) useful ?
2. is there a need to configure this on a class-by-class basis, or is a
global configuration property sufficient?

Thx
Dan


[jira] [Commented] (ISIS-1997) For an alternative for non-obtrusive bulk entry of info, use a sidebar as action prompt (for top-level actions only).

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730098#comment-16730098
 ] 

ASF subversion and git services commented on ISIS-1997:
---

Commit 6fa6b5aa4e0bf72f5ecb6bc55a8d923297f1aec6 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6fa6b5a ]

ISIS-1997: first cut of sidebar


> For an alternative for non-obtrusive bulk entry of info, use a sidebar as 
> action prompt (for top-level actions only).
> -
>
> Key: ISIS-1997
> URL: https://issues.apache.org/jira/browse/ISIS-1997
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.3
>
> Attachments: sketch.pptx
>
>
> add new @ActionLayout(prompt=SIDEBAR), only for "top-level" actions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2053) Improve tabbing behaviour

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730100#comment-16730100
 ] 

ASF subversion and git services commented on ISIS-2053:
---

Commit f0896aa5950afec2f1f5cb90cd9832b9fc1354a0 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=f0896aa ]

ISIS-2053: removes tabindex=-1 for a href's, specify focus styling for all 
themes.

Also:
- disallow tabbing into the underlying widget (textarea etc) contained within 
the "inline" editing hyperlink 


> Improve tabbing behaviour
> -
>
> Key: ISIS-2053
> URL: https://issues.apache.org/jira/browse/ISIS-2053
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.3
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1997) For an alternative for non-obtrusive bulk entry of info, use a sidebar as action prompt (for top-level actions only).

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730101#comment-16730101
 ] 

ASF subversion and git services commented on ISIS-1997:
---

Commit 63597f7a0c409c080b4a682a14ed2ebaf147e3e5 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=63597f7 ]

ISIS-1997: introduces 'dialogMode' configuration property, updates documentation


> For an alternative for non-obtrusive bulk entry of info, use a sidebar as 
> action prompt (for top-level actions only).
> -
>
> Key: ISIS-1997
> URL: https://issues.apache.org/jira/browse/ISIS-1997
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.3
>
> Attachments: sketch.pptx
>
>
> add new @ActionLayout(prompt=SIDEBAR), only for "top-level" actions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2050) Install ObjectSpecIdFacet immediately on creation of ObjectSpecification so can be cached.

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730105#comment-16730105
 ] 

ASF subversion and git services commented on ISIS-2050:
---

Commit fef99b8e64943810a499231b543ee68835d03c1e in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fef99b8 ]

ISIS-2050: fixes unit tests


> Install ObjectSpecIdFacet immediately on creation of ObjectSpecification so 
> can be cached.
> --
>
> Key: ISIS-2050
> URL: https://issues.apache.org/jira/browse/ISIS-2050
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.3
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1997) For an alternative for non-obtrusive bulk entry of info, use a sidebar as action prompt (for top-level actions only).

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730099#comment-16730099
 ] 

ASF subversion and git services commented on ISIS-1997:
---

Commit effc68817649d73d0728431ecfc64686cfa9ca6a in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=effc688 ]

ISIS-1997: fine-tuning sidebar prompt

- don't add the icon to the action name at the top of the panel (also for modal 
dialog, too)
- escape key should cancel
- removes toggle button from every page
- specify width of panel as 20% rather than hardcoded number of pixels


> For an alternative for non-obtrusive bulk entry of info, use a sidebar as 
> action prompt (for top-level actions only).
> -
>
> Key: ISIS-1997
> URL: https://issues.apache.org/jira/browse/ISIS-1997
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.3
>
> Attachments: sketch.pptx
>
>
> add new @ActionLayout(prompt=SIDEBAR), only for "top-level" actions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-1997) For an alternative for non-obtrusive bulk entry of info, use a sidebar as action prompt (for top-level actions only).

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730102#comment-16730102
 ] 

ASF subversion and git services commented on ISIS-1997:
---

Commit 46b6e7074b37ab812efef85d2161840876746b4c in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=46b6e70 ]

Merge branch 'ISIS-1997'


> For an alternative for non-obtrusive bulk entry of info, use a sidebar as 
> action prompt (for top-level actions only).
> -
>
> Key: ISIS-1997
> URL: https://issues.apache.org/jira/browse/ISIS-1997
> Project: Isis
>  Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.3
>
> Attachments: sketch.pptx
>
>
> add new @ActionLayout(prompt=SIDEBAR), only for "top-level" actions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2053) Improve tabbing behaviour

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730103#comment-16730103
 ] 

ASF subversion and git services commented on ISIS-2053:
---

Commit 3e208897ca044eaf81d6999759858b783995eba7 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=3e20889 ]

ISIS-2053: fixes spacing of hidden buttons


> Improve tabbing behaviour
> -
>
> Key: ISIS-2053
> URL: https://issues.apache.org/jira/browse/ISIS-2053
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Major
> Fix For: 1.16.3
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2050) Install ObjectSpecIdFacet immediately on creation of ObjectSpecification so can be cached.

2018-12-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730104#comment-16730104
 ] 

ASF subversion and git services commented on ISIS-2050:
---

Commit 56e909407695ca0f20a97f920f963b5cce69cd64 in isis's branch refs/heads/v2 
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=56e9094 ]

ISIS-2050: ignoring broken tests


> Install ObjectSpecIdFacet immediately on creation of ObjectSpecification so 
> can be cached.
> --
>
> Key: ISIS-2050
> URL: https://issues.apache.org/jira/browse/ISIS-2050
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.3
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)