[jira] [Comment Edited] (ISIS-2104) AuditerService not being called

2019-04-15 Thread Andi Huber (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818374#comment-16818374
 ] 

Andi Huber edited comment on ISIS-2104 at 4/15/19 8:47 PM:
---

Yes, we will drop our current persistence/transaction code based on JDO. Spring 
Data seems to provide sufficient replacements. Its too early to say what our so 
called 'Application Layer API' [1] will look like, but we do want to have these 
concepts also in v2.

[1] 
https://isis.apache.org/guides/rgsvc/rgsvc.html#__rgsvc_intro_commands-and-events


was (Author: hobrom):
Yes, we will drop our current persistence/transaction code based on JDO. Spring 
Data seems to provide sufficient replacements. Its too early to say what our so 
called 'Application API' [1] will look like, but we do want to have these 
concepts also in v2.

[1] 
https://isis.apache.org/guides/rgsvc/rgsvc.html#__rgsvc_intro_commands-and-events

> AuditerService not being called
> ---
>
> Key: ISIS-2104
> URL: https://issues.apache.org/jira/browse/ISIS-2104
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.0.0-M2
> Environment: C:\Users\bkalbfus\workspace>mvn -v
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 
> 2018-10-24T10:41:47-08:00)
> Maven home: C:\ProgramData\chocolatey\lib\maven\apache-maven-3.6.0\bin\..
> Java version: 1.8.0_152, vendor: Oracle Corporation, runtime: C:\Program 
> Files\Java\jdk1.8.0_152\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>Reporter: Brian Kalbfus
>Priority: Major
> Attachments: AuditDatabaseLogger.java
>
>
> A simple implementation of AuditerService (see attached) works in v1.17 
> helloworld archetype but not in v2.0.0-M2 helloworld archetype.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2104) AuditerService not being called

2019-04-15 Thread Andi Huber (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818374#comment-16818374
 ] 

Andi Huber commented on ISIS-2104:
--

Yes, we will drop our current persistence/transaction code based on JDO. Spring 
Data seems to provide sufficient replacements. Its too early to say what our so 
called 'Application API' [1] will look like, but we do want to have these 
concepts also in v2.

[1] 
https://isis.apache.org/guides/rgsvc/rgsvc.html#__rgsvc_intro_commands-and-events

> AuditerService not being called
> ---
>
> Key: ISIS-2104
> URL: https://issues.apache.org/jira/browse/ISIS-2104
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.0.0-M2
> Environment: C:\Users\bkalbfus\workspace>mvn -v
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 
> 2018-10-24T10:41:47-08:00)
> Maven home: C:\ProgramData\chocolatey\lib\maven\apache-maven-3.6.0\bin\..
> Java version: 1.8.0_152, vendor: Oracle Corporation, runtime: C:\Program 
> Files\Java\jdk1.8.0_152\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>Reporter: Brian Kalbfus
>Priority: Major
> Attachments: AuditDatabaseLogger.java
>
>
> A simple implementation of AuditerService (see attached) works in v1.17 
> helloworld archetype but not in v2.0.0-M2 helloworld archetype.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ISIS-2104) AuditerService not being called

2019-04-15 Thread Brian Kalbfus (JIRA)


[ 
https://issues.apache.org/jira/browse/ISIS-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818316#comment-16818316
 ] 

Brian Kalbfus commented on ISIS-2104:
-

[https://github.com/apache/isis/blob/a494f564103769976083e2a5c0ed5142d475b230/core/plugins/jdo-datanucleus-5/src/main/java/org/apache/isis/core/runtime/system/persistence/PersistenceSession5.java#L841]
 is missing the code that existed in v1 to enlist updating to 
changedObjectsServiceInternal at

[https://github.com/apache/isis/blob/af58faef7dbf2e9f635ec46c72affd3a830a6946/core/runtime/src/main/java/org/apache/isis/core/runtime/system/persistence/PersistenceSession.java#L2381]

 

When I added it (I skipped the EventBus code for this test), auditing seemed to 
work. Is this module going away in favor of Spring Persistence?

> AuditerService not being called
> ---
>
> Key: ISIS-2104
> URL: https://issues.apache.org/jira/browse/ISIS-2104
> Project: Isis
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.0.0-M2
> Environment: C:\Users\bkalbfus\workspace>mvn -v
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 
> 2018-10-24T10:41:47-08:00)
> Maven home: C:\ProgramData\chocolatey\lib\maven\apache-maven-3.6.0\bin\..
> Java version: 1.8.0_152, vendor: Oracle Corporation, runtime: C:\Program 
> Files\Java\jdk1.8.0_152\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>Reporter: Brian Kalbfus
>Priority: Major
> Attachments: AuditDatabaseLogger.java
>
>
> A simple implementation of AuditerService (see attached) works in v1.17 
> helloworld archetype but not in v2.0.0-M2 helloworld archetype.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)