[jira] [Commented] (ISIS-2020) Experimental Support for DataNucleus Federated Datastore
[ https://issues.apache.org/jira/browse/ISIS-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829651#comment-16829651 ] Brian Kalbfus commented on ISIS-2020: - Yes, this was my concern. Will the 'v2' release have all the features in 'v1' like auditing, event bus (I identified earlier) and quickstart archetype? I think it is a good idea to put spring overhaul in 'v3' . > Experimental Support for DataNucleus Federated Datastore > > > Key: ISIS-2020 > URL: https://issues.apache.org/jira/browse/ISIS-2020 > Project: Isis > Issue Type: New Feature > Components: Core: Objectstore: JDO >Affects Versions: 1.16.2, 2.0.0-M1 >Reporter: Brian Kalbfus >Assignee: Andi Huber >Priority: Minor > Fix For: 2.0.0 > > Attachments: datanucleus-api-jdo.patch > > > Insert and Update operations work as expected, but query operations operate > on the primary datastore. I see from stepping through the M1 code that > Insert and Update operations use a transaction that accesses a > FederatedDataStore. I guess that is where the difference occurs in that the > query operations get a data store another way, failing to get the > FederatedDataStore that is configured. > example code created from helloworld-archetype is at > [https://github.com/bkalbfus/isis-federatedDS-2_0_0-M1] > Mailing list: > [https://lists.apache.org/thread.html/2edea2f8d802532c3672eddc83b484bbc2e31d1cac16f2759feeb95f@%3Cusers.isis.apache.org%3E] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2020) Experimental Support for DataNucleus Federated Datastore
[ https://issues.apache.org/jira/browse/ISIS-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829604#comment-16829604 ] Andi Huber commented on ISIS-2020: -- If you do worry about our announcement of dropping JDO support with v2, well we are also discussing the possibility to postpone this step to version 3. Things are not cut in stone yet. The 'v2' Milestone 2 release, apart from some minor known issues, appears to be solid enough for production use. So we are thinking about making v2 final, which also requires to cleanup the ascii docs. Then do the JDO drop (replaced by Spring Data) with version 3. > Experimental Support for DataNucleus Federated Datastore > > > Key: ISIS-2020 > URL: https://issues.apache.org/jira/browse/ISIS-2020 > Project: Isis > Issue Type: New Feature > Components: Core: Objectstore: JDO >Affects Versions: 1.16.2, 2.0.0-M1 >Reporter: Brian Kalbfus >Assignee: Andi Huber >Priority: Minor > Fix For: 2.0.0 > > Attachments: datanucleus-api-jdo.patch > > > Insert and Update operations work as expected, but query operations operate > on the primary datastore. I see from stepping through the M1 code that > Insert and Update operations use a transaction that accesses a > FederatedDataStore. I guess that is where the difference occurs in that the > query operations get a data store another way, failing to get the > FederatedDataStore that is configured. > example code created from helloworld-archetype is at > [https://github.com/bkalbfus/isis-federatedDS-2_0_0-M1] > Mailing list: > [https://lists.apache.org/thread.html/2edea2f8d802532c3672eddc83b484bbc2e31d1cac16f2759feeb95f@%3Cusers.isis.apache.org%3E] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2020) Experimental Support for DataNucleus Federated Datastore
[ https://issues.apache.org/jira/browse/ISIS-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829589#comment-16829589 ] Brian Kalbfus commented on ISIS-2020: - Hi Andi, This answers my question! I guess this is one of the reasons for the 'v2' branch, then. Thanks! > Experimental Support for DataNucleus Federated Datastore > > > Key: ISIS-2020 > URL: https://issues.apache.org/jira/browse/ISIS-2020 > Project: Isis > Issue Type: New Feature > Components: Core: Objectstore: JDO >Affects Versions: 1.16.2, 2.0.0-M1 >Reporter: Brian Kalbfus >Assignee: Andi Huber >Priority: Minor > Fix For: 2.0.0 > > Attachments: datanucleus-api-jdo.patch > > > Insert and Update operations work as expected, but query operations operate > on the primary datastore. I see from stepping through the M1 code that > Insert and Update operations use a transaction that accesses a > FederatedDataStore. I guess that is where the difference occurs in that the > query operations get a data store another way, failing to get the > FederatedDataStore that is configured. > example code created from helloworld-archetype is at > [https://github.com/bkalbfus/isis-federatedDS-2_0_0-M1] > Mailing list: > [https://lists.apache.org/thread.html/2edea2f8d802532c3672eddc83b484bbc2e31d1cac16f2759feeb95f@%3Cusers.isis.apache.org%3E] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2020) Experimental Support for DataNucleus Federated Datastore
[ https://issues.apache.org/jira/browse/ISIS-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829564#comment-16829564 ] Andi Huber commented on ISIS-2020: -- Unfortunately 'v1' is stuck with DN 4.x and cannot be upgraded to DN 5.x. Not sure, does this answer your question? > Experimental Support for DataNucleus Federated Datastore > > > Key: ISIS-2020 > URL: https://issues.apache.org/jira/browse/ISIS-2020 > Project: Isis > Issue Type: New Feature > Components: Core: Objectstore: JDO >Affects Versions: 1.16.2, 2.0.0-M1 >Reporter: Brian Kalbfus >Assignee: Andi Huber >Priority: Minor > Fix For: 2.0.0 > > Attachments: datanucleus-api-jdo.patch > > > Insert and Update operations work as expected, but query operations operate > on the primary datastore. I see from stepping through the M1 code that > Insert and Update operations use a transaction that accesses a > FederatedDataStore. I guess that is where the difference occurs in that the > query operations get a data store another way, failing to get the > FederatedDataStore that is configured. > example code created from helloworld-archetype is at > [https://github.com/bkalbfus/isis-federatedDS-2_0_0-M1] > Mailing list: > [https://lists.apache.org/thread.html/2edea2f8d802532c3672eddc83b484bbc2e31d1cac16f2759feeb95f@%3Cusers.isis.apache.org%3E] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2020) Experimental Support for DataNucleus Federated Datastore
[ https://issues.apache.org/jira/browse/ISIS-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829553#comment-16829553 ] Brian Kalbfus commented on ISIS-2020: - Can we apply these fixes to the 'v1' branch? Thanks! > Experimental Support for DataNucleus Federated Datastore > > > Key: ISIS-2020 > URL: https://issues.apache.org/jira/browse/ISIS-2020 > Project: Isis > Issue Type: New Feature > Components: Core: Objectstore: JDO >Affects Versions: 1.16.2, 2.0.0-M1 >Reporter: Brian Kalbfus >Assignee: Andi Huber >Priority: Minor > Fix For: 2.0.0 > > Attachments: datanucleus-api-jdo.patch > > > Insert and Update operations work as expected, but query operations operate > on the primary datastore. I see from stepping through the M1 code that > Insert and Update operations use a transaction that accesses a > FederatedDataStore. I guess that is where the difference occurs in that the > query operations get a data store another way, failing to get the > FederatedDataStore that is configured. > example code created from helloworld-archetype is at > [https://github.com/bkalbfus/isis-federatedDS-2_0_0-M1] > Mailing list: > [https://lists.apache.org/thread.html/2edea2f8d802532c3672eddc83b484bbc2e31d1cac16f2759feeb95f@%3Cusers.isis.apache.org%3E] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2107) Allow enums to implement interfaces for choices.
[
https://issues.apache.org/jira/browse/ISIS-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829450#comment-16829450
]
ASF subversion and git services commented on ISIS-2107:
---
Commit bb51403aeb0091364bc86835ced05db611aecbd7 in isis's branch refs/heads/v2
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=bb51403 ]
ISIS-2107: reformat is all
> Allow enums to implement interfaces for choices.
>
>
> Key: ISIS-2107
> URL: https://issues.apache.org/jira/browse/ISIS-2107
> Project: Isis
> Issue Type: Bug
> Components: Core, Core: Viewer: Wicket
>Affects Versions: 1.17.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> The code we wanted to write was equivalent to:
> {code:java}
> public Object act(
> final INflLeague nflLeague,
> final NflRegion nflRegion,
> final NflTeamEntity nflTeam) {
> nflPlayer.updateUsingEntity((NflLeague)nflLeague, nflRegion, nflTeam);
> return this.nflPlayer;
> }
> public List choices0Act() {
> return Arrays.asList(NflLeague.values());
> }
> ...
> {code}
> where NflLeague is an enum that implements INflLeague :
> {code:java}
> public interface INflLeague {
> String getName();
> }
> {code}
> and
> {code:java}
> public enum NflLeague implements INflLeague {
> AFC,
> NFC;
> @Override
> public String getName() {
> return name();
> }
> }
> {code}
> There are two issues:
> * first, in the metamodel we don't introspect enums to recognise that a list
> of NflLeague enum instances can be returned in the choices method returning
> List
> * second, in the Wicket viewer the selection of the choicesPanel is based on
> the type, and if an interface is used then it guesses a referencePanel rather
> than ValueSelect2Panel that is normally used for enums. The marshalling
> logic for ReferencePanel assumes entities, and fails when handed a bunch of
> scalar enums.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ISIS-2072) Release tasks for 1.18.0
[ https://issues.apache.org/jira/browse/ISIS-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829454#comment-16829454 ] ASF subversion and git services commented on ISIS-2072: --- Commit 057a06112c62dceb3b88b0084f926b8382d37789 in isis's branch refs/heads/v2 from danhaywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=057a061 ] ISIS-2072: removes reference to maven2-repository.dev.java.net Certificate error. Failed to resolve dependencies for one or more projects in the reactor. Reason: Could not transfer artifact org.apache.isis.core:isis-core-schema:jar:1.17.0.20190429-1255-f3a54c7c from/to maven2-repository.dev.java.net (http://download.java.net/maven/2/): Certificate for doesn't match any of the subject alternative names: [download.oracle.com, epd-akam-us.oracle.com, epd-akam-ca.oracle.com, epd-akam-intl.oracle.com, aru-akam.oracle.com] I'm hoping that we don't actually need this cert. > Release tasks for 1.18.0 > > > Key: ISIS-2072 > URL: https://issues.apache.org/jira/browse/ISIS-2072 > Project: Isis > Issue Type: Task >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2107) Allow enums to implement interfaces for choices.
[
https://issues.apache.org/jira/browse/ISIS-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829452#comment-16829452
]
ASF subversion and git services commented on ISIS-2107:
---
Commit cb1105da75f1ed097e775348f670f4a6bd0c9bd3 in isis's branch refs/heads/v2
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=cb1105d ]
ISIS-2107: fixes unit test
> Allow enums to implement interfaces for choices.
>
>
> Key: ISIS-2107
> URL: https://issues.apache.org/jira/browse/ISIS-2107
> Project: Isis
> Issue Type: Bug
> Components: Core, Core: Viewer: Wicket
>Affects Versions: 1.17.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> The code we wanted to write was equivalent to:
> {code:java}
> public Object act(
> final INflLeague nflLeague,
> final NflRegion nflRegion,
> final NflTeamEntity nflTeam) {
> nflPlayer.updateUsingEntity((NflLeague)nflLeague, nflRegion, nflTeam);
> return this.nflPlayer;
> }
> public List choices0Act() {
> return Arrays.asList(NflLeague.values());
> }
> ...
> {code}
> where NflLeague is an enum that implements INflLeague :
> {code:java}
> public interface INflLeague {
> String getName();
> }
> {code}
> and
> {code:java}
> public enum NflLeague implements INflLeague {
> AFC,
> NFC;
> @Override
> public String getName() {
> return name();
> }
> }
> {code}
> There are two issues:
> * first, in the metamodel we don't introspect enums to recognise that a list
> of NflLeague enum instances can be returned in the choices method returning
> List
> * second, in the Wicket viewer the selection of the choicesPanel is based on
> the type, and if an interface is used then it guesses a referencePanel rather
> than ValueSelect2Panel that is normally used for enums. The marshalling
> logic for ReferencePanel assumes entities, and fails when handed a bunch of
> scalar enums.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ISIS-2107) Allow enums to implement interfaces for choices.
[
https://issues.apache.org/jira/browse/ISIS-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829449#comment-16829449
]
ASF subversion and git services commented on ISIS-2107:
---
Commit b1b64e5e336ec067f5d9ef3bf7bc3d4d70d1a9f4 in isis's branch refs/heads/v2
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b1b64e5 ]
ISIS-2107: allows ObjectAdapterMementos that represent enum instances to be
instantiated.
> Allow enums to implement interfaces for choices.
>
>
> Key: ISIS-2107
> URL: https://issues.apache.org/jira/browse/ISIS-2107
> Project: Isis
> Issue Type: Bug
> Components: Core, Core: Viewer: Wicket
>Affects Versions: 1.17.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> The code we wanted to write was equivalent to:
> {code:java}
> public Object act(
> final INflLeague nflLeague,
> final NflRegion nflRegion,
> final NflTeamEntity nflTeam) {
> nflPlayer.updateUsingEntity((NflLeague)nflLeague, nflRegion, nflTeam);
> return this.nflPlayer;
> }
> public List choices0Act() {
> return Arrays.asList(NflLeague.values());
> }
> ...
> {code}
> where NflLeague is an enum that implements INflLeague :
> {code:java}
> public interface INflLeague {
> String getName();
> }
> {code}
> and
> {code:java}
> public enum NflLeague implements INflLeague {
> AFC,
> NFC;
> @Override
> public String getName() {
> return name();
> }
> }
> {code}
> There are two issues:
> * first, in the metamodel we don't introspect enums to recognise that a list
> of NflLeague enum instances can be returned in the choices method returning
> List
> * second, in the Wicket viewer the selection of the choicesPanel is based on
> the type, and if an interface is used then it guesses a referencePanel rather
> than ValueSelect2Panel that is normally used for enums. The marshalling
> logic for ReferencePanel assumes entities, and fails when handed a bunch of
> scalar enums.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ISIS-2107) Allow enums to implement interfaces for choices.
[
https://issues.apache.org/jira/browse/ISIS-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829451#comment-16829451
]
ASF subversion and git services commented on ISIS-2107:
---
Commit ab79a031447f37532b93e1b4d6098e5618789ea6 in isis's branch refs/heads/v2
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ab79a03 ]
ISIS-2107: makes reference choices more flexible by allowing it to handle enums
that are implementing an interface
> Allow enums to implement interfaces for choices.
>
>
> Key: ISIS-2107
> URL: https://issues.apache.org/jira/browse/ISIS-2107
> Project: Isis
> Issue Type: Bug
> Components: Core, Core: Viewer: Wicket
>Affects Versions: 1.17.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> The code we wanted to write was equivalent to:
> {code:java}
> public Object act(
> final INflLeague nflLeague,
> final NflRegion nflRegion,
> final NflTeamEntity nflTeam) {
> nflPlayer.updateUsingEntity((NflLeague)nflLeague, nflRegion, nflTeam);
> return this.nflPlayer;
> }
> public List choices0Act() {
> return Arrays.asList(NflLeague.values());
> }
> ...
> {code}
> where NflLeague is an enum that implements INflLeague :
> {code:java}
> public interface INflLeague {
> String getName();
> }
> {code}
> and
> {code:java}
> public enum NflLeague implements INflLeague {
> AFC,
> NFC;
> @Override
> public String getName() {
> return name();
> }
> }
> {code}
> There are two issues:
> * first, in the metamodel we don't introspect enums to recognise that a list
> of NflLeague enum instances can be returned in the choices method returning
> List
> * second, in the Wicket viewer the selection of the choicesPanel is based on
> the type, and if an interface is used then it guesses a referencePanel rather
> than ValueSelect2Panel that is normally used for enums. The marshalling
> logic for ReferencePanel assumes entities, and fails when handed a bunch of
> scalar enums.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ISIS-2107) Allow enums to implement interfaces for choices.
[
https://issues.apache.org/jira/browse/ISIS-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829448#comment-16829448
]
ASF subversion and git services commented on ISIS-2107:
---
Commit c2c3a3a46326b7b9e0424766c4f9efed67d6c07a in isis's branch refs/heads/v2
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c2c3a3a ]
ISIS-2107: improves isOfType so that enums that implement an interface are
allowed for.
> Allow enums to implement interfaces for choices.
>
>
> Key: ISIS-2107
> URL: https://issues.apache.org/jira/browse/ISIS-2107
> Project: Isis
> Issue Type: Bug
> Components: Core, Core: Viewer: Wicket
>Affects Versions: 1.17.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> The code we wanted to write was equivalent to:
> {code:java}
> public Object act(
> final INflLeague nflLeague,
> final NflRegion nflRegion,
> final NflTeamEntity nflTeam) {
> nflPlayer.updateUsingEntity((NflLeague)nflLeague, nflRegion, nflTeam);
> return this.nflPlayer;
> }
> public List choices0Act() {
> return Arrays.asList(NflLeague.values());
> }
> ...
> {code}
> where NflLeague is an enum that implements INflLeague :
> {code:java}
> public interface INflLeague {
> String getName();
> }
> {code}
> and
> {code:java}
> public enum NflLeague implements INflLeague {
> AFC,
> NFC;
> @Override
> public String getName() {
> return name();
> }
> }
> {code}
> There are two issues:
> * first, in the metamodel we don't introspect enums to recognise that a list
> of NflLeague enum instances can be returned in the choices method returning
> List
> * second, in the Wicket viewer the selection of the choicesPanel is based on
> the type, and if an interface is used then it guesses a referencePanel rather
> than ValueSelect2Panel that is normally used for enums. The marshalling
> logic for ReferencePanel assumes entities, and fails when handed a bunch of
> scalar enums.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ISIS-2107) Allow enums to implement interfaces for choices.
[
https://issues.apache.org/jira/browse/ISIS-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829453#comment-16829453
]
ASF subversion and git services commented on ISIS-2107:
---
Commit f3a54c7cdfabe232311918e43a616dbde66e5242 in isis's branch refs/heads/v2
from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=f3a54c7 ]
Merge branch 'ISIS-2107'
> Allow enums to implement interfaces for choices.
>
>
> Key: ISIS-2107
> URL: https://issues.apache.org/jira/browse/ISIS-2107
> Project: Isis
> Issue Type: Bug
> Components: Core, Core: Viewer: Wicket
>Affects Versions: 1.17.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> The code we wanted to write was equivalent to:
> {code:java}
> public Object act(
> final INflLeague nflLeague,
> final NflRegion nflRegion,
> final NflTeamEntity nflTeam) {
> nflPlayer.updateUsingEntity((NflLeague)nflLeague, nflRegion, nflTeam);
> return this.nflPlayer;
> }
> public List choices0Act() {
> return Arrays.asList(NflLeague.values());
> }
> ...
> {code}
> where NflLeague is an enum that implements INflLeague :
> {code:java}
> public interface INflLeague {
> String getName();
> }
> {code}
> and
> {code:java}
> public enum NflLeague implements INflLeague {
> AFC,
> NFC;
> @Override
> public String getName() {
> return name();
> }
> }
> {code}
> There are two issues:
> * first, in the metamodel we don't introspect enums to recognise that a list
> of NflLeague enum instances can be returned in the choices method returning
> List
> * second, in the Wicket viewer the selection of the choicesPanel is based on
> the type, and if an interface is used then it guesses a referencePanel rather
> than ValueSelect2Panel that is normally used for enums. The marshalling
> logic for ReferencePanel assumes entities, and fails when handed a bunch of
> scalar enums.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ISIS-2072) Release tasks for 1.18.0
[ https://issues.apache.org/jira/browse/ISIS-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829259#comment-16829259 ] ASF subversion and git services commented on ISIS-2072: --- Commit 057a06112c62dceb3b88b0084f926b8382d37789 in isis's branch refs/heads/master from danhaywood [ https://gitbox.apache.org/repos/asf?p=isis.git;h=057a061 ] ISIS-2072: removes reference to maven2-repository.dev.java.net Certificate error. Failed to resolve dependencies for one or more projects in the reactor. Reason: Could not transfer artifact org.apache.isis.core:isis-core-schema:jar:1.17.0.20190429-1255-f3a54c7c from/to maven2-repository.dev.java.net (http://download.java.net/maven/2/): Certificate for doesn't match any of the subject alternative names: [download.oracle.com, epd-akam-us.oracle.com, epd-akam-ca.oracle.com, epd-akam-intl.oracle.com, aru-akam.oracle.com] I'm hoping that we don't actually need this cert. > Release tasks for 1.18.0 > > > Key: ISIS-2072 > URL: https://issues.apache.org/jira/browse/ISIS-2072 > Project: Isis > Issue Type: Task >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2107) Allow enums to implement interfaces for choices.
[
https://issues.apache.org/jira/browse/ISIS-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829220#comment-16829220
]
ASF subversion and git services commented on ISIS-2107:
---
Commit cb1105da75f1ed097e775348f670f4a6bd0c9bd3 in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=cb1105d ]
ISIS-2107: fixes unit test
> Allow enums to implement interfaces for choices.
>
>
> Key: ISIS-2107
> URL: https://issues.apache.org/jira/browse/ISIS-2107
> Project: Isis
> Issue Type: Bug
> Components: Core, Core: Viewer: Wicket
>Affects Versions: 1.17.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> The code we wanted to write was equivalent to:
> {code:java}
> public Object act(
> final INflLeague nflLeague,
> final NflRegion nflRegion,
> final NflTeamEntity nflTeam) {
> nflPlayer.updateUsingEntity((NflLeague)nflLeague, nflRegion, nflTeam);
> return this.nflPlayer;
> }
> public List choices0Act() {
> return Arrays.asList(NflLeague.values());
> }
> ...
> {code}
> where NflLeague is an enum that implements INflLeague :
> {code:java}
> public interface INflLeague {
> String getName();
> }
> {code}
> and
> {code:java}
> public enum NflLeague implements INflLeague {
> AFC,
> NFC;
> @Override
> public String getName() {
> return name();
> }
> }
> {code}
> There are two issues:
> * first, in the metamodel we don't introspect enums to recognise that a list
> of NflLeague enum instances can be returned in the choices method returning
> List
> * second, in the Wicket viewer the selection of the choicesPanel is based on
> the type, and if an interface is used then it guesses a referencePanel rather
> than ValueSelect2Panel that is normally used for enums. The marshalling
> logic for ReferencePanel assumes entities, and fails when handed a bunch of
> scalar enums.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ISIS-2107) Allow enums to implement interfaces for choices.
[
https://issues.apache.org/jira/browse/ISIS-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829216#comment-16829216
]
ASF subversion and git services commented on ISIS-2107:
---
Commit c2c3a3a46326b7b9e0424766c4f9efed67d6c07a in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c2c3a3a ]
ISIS-2107: improves isOfType so that enums that implement an interface are
allowed for.
> Allow enums to implement interfaces for choices.
>
>
> Key: ISIS-2107
> URL: https://issues.apache.org/jira/browse/ISIS-2107
> Project: Isis
> Issue Type: Bug
> Components: Core, Core: Viewer: Wicket
>Affects Versions: 1.17.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> The code we wanted to write was equivalent to:
> {code:java}
> public Object act(
> final INflLeague nflLeague,
> final NflRegion nflRegion,
> final NflTeamEntity nflTeam) {
> nflPlayer.updateUsingEntity((NflLeague)nflLeague, nflRegion, nflTeam);
> return this.nflPlayer;
> }
> public List choices0Act() {
> return Arrays.asList(NflLeague.values());
> }
> ...
> {code}
> where NflLeague is an enum that implements INflLeague :
> {code:java}
> public interface INflLeague {
> String getName();
> }
> {code}
> and
> {code:java}
> public enum NflLeague implements INflLeague {
> AFC,
> NFC;
> @Override
> public String getName() {
> return name();
> }
> }
> {code}
> There are two issues:
> * first, in the metamodel we don't introspect enums to recognise that a list
> of NflLeague enum instances can be returned in the choices method returning
> List
> * second, in the Wicket viewer the selection of the choicesPanel is based on
> the type, and if an interface is used then it guesses a referencePanel rather
> than ValueSelect2Panel that is normally used for enums. The marshalling
> logic for ReferencePanel assumes entities, and fails when handed a bunch of
> scalar enums.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ISIS-2107) Allow enums to implement interfaces for choices.
[
https://issues.apache.org/jira/browse/ISIS-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829221#comment-16829221
]
ASF subversion and git services commented on ISIS-2107:
---
Commit f3a54c7cdfabe232311918e43a616dbde66e5242 in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=f3a54c7 ]
Merge branch 'ISIS-2107'
> Allow enums to implement interfaces for choices.
>
>
> Key: ISIS-2107
> URL: https://issues.apache.org/jira/browse/ISIS-2107
> Project: Isis
> Issue Type: Bug
> Components: Core, Core: Viewer: Wicket
>Affects Versions: 1.17.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> The code we wanted to write was equivalent to:
> {code:java}
> public Object act(
> final INflLeague nflLeague,
> final NflRegion nflRegion,
> final NflTeamEntity nflTeam) {
> nflPlayer.updateUsingEntity((NflLeague)nflLeague, nflRegion, nflTeam);
> return this.nflPlayer;
> }
> public List choices0Act() {
> return Arrays.asList(NflLeague.values());
> }
> ...
> {code}
> where NflLeague is an enum that implements INflLeague :
> {code:java}
> public interface INflLeague {
> String getName();
> }
> {code}
> and
> {code:java}
> public enum NflLeague implements INflLeague {
> AFC,
> NFC;
> @Override
> public String getName() {
> return name();
> }
> }
> {code}
> There are two issues:
> * first, in the metamodel we don't introspect enums to recognise that a list
> of NflLeague enum instances can be returned in the choices method returning
> List
> * second, in the Wicket viewer the selection of the choicesPanel is based on
> the type, and if an interface is used then it guesses a referencePanel rather
> than ValueSelect2Panel that is normally used for enums. The marshalling
> logic for ReferencePanel assumes entities, and fails when handed a bunch of
> scalar enums.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ISIS-2107) Allow enums to implement interfaces for choices.
[
https://issues.apache.org/jira/browse/ISIS-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829217#comment-16829217
]
ASF subversion and git services commented on ISIS-2107:
---
Commit b1b64e5e336ec067f5d9ef3bf7bc3d4d70d1a9f4 in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b1b64e5 ]
ISIS-2107: allows ObjectAdapterMementos that represent enum instances to be
instantiated.
> Allow enums to implement interfaces for choices.
>
>
> Key: ISIS-2107
> URL: https://issues.apache.org/jira/browse/ISIS-2107
> Project: Isis
> Issue Type: Bug
> Components: Core, Core: Viewer: Wicket
>Affects Versions: 1.17.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> The code we wanted to write was equivalent to:
> {code:java}
> public Object act(
> final INflLeague nflLeague,
> final NflRegion nflRegion,
> final NflTeamEntity nflTeam) {
> nflPlayer.updateUsingEntity((NflLeague)nflLeague, nflRegion, nflTeam);
> return this.nflPlayer;
> }
> public List choices0Act() {
> return Arrays.asList(NflLeague.values());
> }
> ...
> {code}
> where NflLeague is an enum that implements INflLeague :
> {code:java}
> public interface INflLeague {
> String getName();
> }
> {code}
> and
> {code:java}
> public enum NflLeague implements INflLeague {
> AFC,
> NFC;
> @Override
> public String getName() {
> return name();
> }
> }
> {code}
> There are two issues:
> * first, in the metamodel we don't introspect enums to recognise that a list
> of NflLeague enum instances can be returned in the choices method returning
> List
> * second, in the Wicket viewer the selection of the choicesPanel is based on
> the type, and if an interface is used then it guesses a referencePanel rather
> than ValueSelect2Panel that is normally used for enums. The marshalling
> logic for ReferencePanel assumes entities, and fails when handed a bunch of
> scalar enums.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ISIS-2107) Allow enums to implement interfaces for choices.
[
https://issues.apache.org/jira/browse/ISIS-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829219#comment-16829219
]
ASF subversion and git services commented on ISIS-2107:
---
Commit ab79a031447f37532b93e1b4d6098e5618789ea6 in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ab79a03 ]
ISIS-2107: makes reference choices more flexible by allowing it to handle enums
that are implementing an interface
> Allow enums to implement interfaces for choices.
>
>
> Key: ISIS-2107
> URL: https://issues.apache.org/jira/browse/ISIS-2107
> Project: Isis
> Issue Type: Bug
> Components: Core, Core: Viewer: Wicket
>Affects Versions: 1.17.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> The code we wanted to write was equivalent to:
> {code:java}
> public Object act(
> final INflLeague nflLeague,
> final NflRegion nflRegion,
> final NflTeamEntity nflTeam) {
> nflPlayer.updateUsingEntity((NflLeague)nflLeague, nflRegion, nflTeam);
> return this.nflPlayer;
> }
> public List choices0Act() {
> return Arrays.asList(NflLeague.values());
> }
> ...
> {code}
> where NflLeague is an enum that implements INflLeague :
> {code:java}
> public interface INflLeague {
> String getName();
> }
> {code}
> and
> {code:java}
> public enum NflLeague implements INflLeague {
> AFC,
> NFC;
> @Override
> public String getName() {
> return name();
> }
> }
> {code}
> There are two issues:
> * first, in the metamodel we don't introspect enums to recognise that a list
> of NflLeague enum instances can be returned in the choices method returning
> List
> * second, in the Wicket viewer the selection of the choicesPanel is based on
> the type, and if an interface is used then it guesses a referencePanel rather
> than ValueSelect2Panel that is normally used for enums. The marshalling
> logic for ReferencePanel assumes entities, and fails when handed a bunch of
> scalar enums.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ISIS-2107) Allow enums to implement interfaces for choices.
[
https://issues.apache.org/jira/browse/ISIS-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829218#comment-16829218
]
ASF subversion and git services commented on ISIS-2107:
---
Commit bb51403aeb0091364bc86835ced05db611aecbd7 in isis's branch
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=bb51403 ]
ISIS-2107: reformat is all
> Allow enums to implement interfaces for choices.
>
>
> Key: ISIS-2107
> URL: https://issues.apache.org/jira/browse/ISIS-2107
> Project: Isis
> Issue Type: Bug
> Components: Core, Core: Viewer: Wicket
>Affects Versions: 1.17.0
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> The code we wanted to write was equivalent to:
> {code:java}
> public Object act(
> final INflLeague nflLeague,
> final NflRegion nflRegion,
> final NflTeamEntity nflTeam) {
> nflPlayer.updateUsingEntity((NflLeague)nflLeague, nflRegion, nflTeam);
> return this.nflPlayer;
> }
> public List choices0Act() {
> return Arrays.asList(NflLeague.values());
> }
> ...
> {code}
> where NflLeague is an enum that implements INflLeague :
> {code:java}
> public interface INflLeague {
> String getName();
> }
> {code}
> and
> {code:java}
> public enum NflLeague implements INflLeague {
> AFC,
> NFC;
> @Override
> public String getName() {
> return name();
> }
> }
> {code}
> There are two issues:
> * first, in the metamodel we don't introspect enums to recognise that a list
> of NflLeague enum instances can be returned in the choices method returning
> List
> * second, in the Wicket viewer the selection of the choicesPanel is based on
> the type, and if an interface is used then it guesses a referencePanel rather
> than ValueSelect2Panel that is normally used for enums. The marshalling
> logic for ReferencePanel assumes entities, and fails when handed a bunch of
> scalar enums.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (ISIS-2107) Allow enums to implement interfaces for choices.
Dan Haywood created ISIS-2107:
-
Summary: Allow enums to implement interfaces for choices.
Key: ISIS-2107
URL: https://issues.apache.org/jira/browse/ISIS-2107
Project: Isis
Issue Type: Bug
Components: Core, Core: Viewer: Wicket
Affects Versions: 1.17.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Fix For: 1.18.0
The code we wanted to write was equivalent to:
{code:java}
public Object act(
final INflLeague nflLeague,
final NflRegion nflRegion,
final NflTeamEntity nflTeam) {
nflPlayer.updateUsingEntity((NflLeague)nflLeague, nflRegion, nflTeam);
return this.nflPlayer;
}
public List choices0Act() {
return Arrays.asList(NflLeague.values());
}
...
{code}
where NflLeague is an enum that implements INflLeague :
{code:java}
public interface INflLeague {
String getName();
}
{code}
and
{code:java}
public enum NflLeague implements INflLeague {
AFC,
NFC;
@Override
public String getName() {
return name();
}
}
{code}
There are two issues:
* first, in the metamodel we don't introspect enums to recognise that a list of
NflLeague enum instances can be returned in the choices method returning
List
* second, in the Wicket viewer the selection of the choicesPanel is based on
the type, and if an interface is used then it guesses a referencePanel rather
than ValueSelect2Panel that is normally used for enums. The marshalling logic
for ReferencePanel assumes entities, and fails when handed a bunch of scalar
enums.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (ISIS-2106) Fix CSS for sidebar, buttons not visible if lots of params
[ https://issues.apache.org/jira/browse/ISIS-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-2106. --- Resolution: Fixed > Fix CSS for sidebar, buttons not visible if lots of params > -- > > Key: ISIS-2106 > URL: https://issues.apache.org/jira/browse/ISIS-2106 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.17.0 >Reporter: Dan Haywood >Assignee: Dan Haywood >Priority: Minor > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
