[jira] [Closed] (ISIS-1806) [WON'T FIX] Reinstate ability to bookmark action invocations
[ https://issues.apache.org/jira/browse/ISIS-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood closed ISIS-1806. - Resolution: Fixed > [WON'T FIX] Reinstate ability to bookmark action invocations > - > > Key: ISIS-1806 > URL: https://issues.apache.org/jira/browse/ISIS-1806 > Project: Isis > Issue Type: Bug >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Priority: Major > Fix For: 1.18.0 > > > broken in 1.15.0, and commented out in 1.16.0 to avoid user failures. > The issue is that the BookmarkTreeNode infers a pageType of ACTION_PROMPT, > which causes the ActionPromptPage to be rendered. This in turn has a > ComponentType of ACTION_PARAMETERS. > However, the ActionParametersPromptPanelFactory explicitly does not match for > actions that take no arguments, and so the only component found is > UnknownPanel which - of course - fails to add the correct > ActionParametersPanel component. > This whole area needs reworking ... the ActionParametersPanel now no-longer > supports being invoked with no-args or with populated n-args and > automatically resolving to the result of the action invocation. > Instead, will need to move the action execution stuff into the implementation > of the AbstractLink that is created within the BookmarkedPagesPanel. > ~~ > or: maybe we just keep this functionality commented out; is it used anyway ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-1806) [WON'T FIX] Reinstate ability to bookmark action invocations
[ https://issues.apache.org/jira/browse/ISIS-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843957#comment-16843957 ] Dan Haywood commented on ISIS-1806: --- have decided I'm not even gonna delete the commented out code. > [WON'T FIX] Reinstate ability to bookmark action invocations > - > > Key: ISIS-1806 > URL: https://issues.apache.org/jira/browse/ISIS-1806 > Project: Isis > Issue Type: Bug >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Priority: Major > Fix For: 1.18.0 > > > broken in 1.15.0, and commented out in 1.16.0 to avoid user failures. > The issue is that the BookmarkTreeNode infers a pageType of ACTION_PROMPT, > which causes the ActionPromptPage to be rendered. This in turn has a > ComponentType of ACTION_PARAMETERS. > However, the ActionParametersPromptPanelFactory explicitly does not match for > actions that take no arguments, and so the only component found is > UnknownPanel which - of course - fails to add the correct > ActionParametersPanel component. > This whole area needs reworking ... the ActionParametersPanel now no-longer > supports being invoked with no-args or with populated n-args and > automatically resolving to the result of the action invocation. > Instead, will need to move the action execution stuff into the implementation > of the AbstractLink that is created within the BookmarkedPagesPanel. > ~~ > or: maybe we just keep this functionality commented out; is it used anyway ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ISIS-2084) Allow upload of snapshot builds to repo.incode.work
[ https://issues.apache.org/jira/browse/ISIS-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-2084. --- Resolution: Fixed > Allow upload of snapshot builds to repo.incode.work > --- > > Key: ISIS-2084 > URL: https://issues.apache.org/jira/browse/ISIS-2084 > Project: Isis > Issue Type: New Feature >Affects Versions: 1.17.0 >Reporter: Dan Haywood >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ISIS-2120) Extend DomainServiceLayout to specify menuName, and use to "slot into" appropriate part of menubars.layout.xml
Dan Haywood created ISIS-2120: - Summary: Extend DomainServiceLayout to specify menuName, and use to "slot into" appropriate part of menubars.layout.xml Key: ISIS-2120 URL: https://issues.apache.org/jira/browse/ISIS-2120 Project: Isis Issue Type: New Feature Affects Versions: 1.17.0 Reporter: Dan Haywood Fix For: 1.18.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-2084) Allow upload of snapshot builds to repo.incode.work
[ https://issues.apache.org/jira/browse/ISIS-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-2084: -- Summary: Allow upload of snapshot builds to repo.incode.work (was: Extend DomainServiceLayout to specify menuName, and use to "slot into" appropriate part of menubars.layout.xml) > Allow upload of snapshot builds to repo.incode.work > --- > > Key: ISIS-2084 > URL: https://issues.apache.org/jira/browse/ISIS-2084 > Project: Isis > Issue Type: New Feature >Affects Versions: 1.17.0 >Reporter: Dan Haywood >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
