[jira] [Commented] (ISIS-2151) Pull in Incode's security modul as an extension
[ https://issues.apache.org/jira/browse/ISIS-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882866#comment-16882866 ] ASF subversion and git services commented on ISIS-2151: --- Commit f0885d593ca52dddacbefb634c222f5e32e058be in isis's branch refs/heads/v2 from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=f0885d5 ] ISIS-2151 removes intermediate helper class 'TransitionHelper' > Pull in Incode's security modul as an extension > --- > > Key: ISIS-2151 > URL: https://issues.apache.org/jira/browse/ISIS-2151 > Project: Isis > Issue Type: Improvement >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ISIS-2152) FactoryService (API): remove 'm' shortcut, add 'viewModel'
[
https://issues.apache.org/jira/browse/ISIS-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber resolved ISIS-2152.
--
Resolution: Fixed
API Note added: EXPERIMENTAL
> FactoryService (API): remove 'm' shortcut, add 'viewModel'
> --
>
> Key: ISIS-2152
> URL: https://issues.apache.org/jira/browse/ISIS-2152
> Project: Isis
> Issue Type: Improvement
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>
> Opinionated: remove this shortcut for 'mixin', don't encourage bad code
> readablity, especially when the verbose variant 'mixin' is already short
> enough:
>
> {code:java}
> T m(Class mixinClass, Object mixedIn);
> {code}
> Add
>
>
> {code:java}
> /**
> * Creates a new ViewModel instance, and initializes according to the given
> {@code mementoStr}
> * @param viewModelClass
> * @param mementoStr
> * @since 2.0
> */
> T viewModel(Class viewModelClass, @Nullable String mementoStr);
> {code}
> However, I'm not entirely sure whether its a good idea to expose the
> mementoStr with the API that way.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (ISIS-2152) FactoryService (API): remove 'm' shortcut, add 'viewModel'
[
https://issues.apache.org/jira/browse/ISIS-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882844#comment-16882844
]
ASF subversion and git services commented on ISIS-2152:
---
Commit 9ad77a45a24ea4b886d79fc62e029a1d8dd5ceb2 in isis's branch refs/heads/v2
from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9ad77a4 ]
ISIS-2152 adds ViewModel creation to the FactoryService (API)
- also removes 'm' (=mixin) shortcut from FactoryService interface
> FactoryService (API): remove 'm' shortcut, add 'viewModel'
> --
>
> Key: ISIS-2152
> URL: https://issues.apache.org/jira/browse/ISIS-2152
> Project: Isis
> Issue Type: Improvement
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>
> Opinionated: remove this shortcut for 'mixin', don't encourage bad code
> readablity, especially when the verbose variant 'mixin' is already short
> enough:
>
> {code:java}
> T m(Class mixinClass, Object mixedIn);
> {code}
> Add
>
>
> {code:java}
> /**
> * Creates a new ViewModel instance, and initializes according to the given
> {@code mementoStr}
> * @param viewModelClass
> * @param mementoStr
> * @since 2.0
> */
> T viewModel(Class viewModelClass, @Nullable String mementoStr);
> {code}
> However, I'm not entirely sure whether its a good idea to expose the
> mementoStr with the API that way.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (ISIS-2152) FactoryService (API): remove 'm' shortcut, add 'viewModel'
[
https://issues.apache.org/jira/browse/ISIS-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber updated ISIS-2152:
-
Fix Version/s: 2.0.0
> FactoryService (API): remove 'm' shortcut, add 'viewModel'
> --
>
> Key: ISIS-2152
> URL: https://issues.apache.org/jira/browse/ISIS-2152
> Project: Isis
> Issue Type: Improvement
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>
> Opinionated: remove this shortcut for 'mixin', don't encourage bad code
> readablity, especially when the verbose variant 'mixin' is already short
> enough:
>
> {code:java}
> T m(Class mixinClass, Object mixedIn);
> {code}
> Add
>
>
> {code:java}
> /**
> * Creates a new ViewModel instance, and initializes according to the given
> {@code mementoStr}
> * @param viewModelClass
> * @param mementoStr
> * @since 2.0
> */
> T viewModel(Class viewModelClass, @Nullable String mementoStr);
> {code}
> However, I'm not entirely sure whether its a good idea to expose the
> mementoStr with the API that way.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Assigned] (ISIS-2152) FactoryService (API): remove 'm' shortcut, add 'viewModel'
[
https://issues.apache.org/jira/browse/ISIS-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andi Huber reassigned ISIS-2152:
Assignee: Andi Huber
> FactoryService (API): remove 'm' shortcut, add 'viewModel'
> --
>
> Key: ISIS-2152
> URL: https://issues.apache.org/jira/browse/ISIS-2152
> Project: Isis
> Issue Type: Improvement
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>
> Opinionated: remove this shortcut for 'mixin', don't encourage bad code
> readablity, especially when the verbose variant 'mixin' is already short
> enough:
>
> {code:java}
> T m(Class mixinClass, Object mixedIn);
> {code}
> Add
>
>
> {code:java}
> /**
> * Creates a new ViewModel instance, and initializes according to the given
> {@code mementoStr}
> * @param viewModelClass
> * @param mementoStr
> * @since 2.0
> */
> T viewModel(Class viewModelClass, @Nullable String mementoStr);
> {code}
> However, I'm not entirely sure whether its a good idea to expose the
> mementoStr with the API that way.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (ISIS-2152) FactoryService (API): remove 'm' shortcut, add 'viewModel'
Andi Huber created ISIS-2152:
Summary: FactoryService (API): remove 'm' shortcut, add 'viewModel'
Key: ISIS-2152
URL: https://issues.apache.org/jira/browse/ISIS-2152
Project: Isis
Issue Type: Improvement
Reporter: Andi Huber
Opinionated: remove this shortcut for 'mixin', don't encourage bad code
readablity, especially when the verbose variant 'mixin' is already short enough:
{code:java}
T m(Class mixinClass, Object mixedIn);
{code}
Add
{code:java}
/**
* Creates a new ViewModel instance, and initializes according to the given
{@code mementoStr}
* @param viewModelClass
* @param mementoStr
* @since 2.0
*/
T viewModel(Class viewModelClass, @Nullable String mementoStr);
{code}
However, I'm not entirely sure whether its a good idea to expose the mementoStr
with the API that way.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (ISIS-2151) Pull in Incode's security modul as an extension
[ https://issues.apache.org/jira/browse/ISIS-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16882690#comment-16882690 ] ASF subversion and git services commented on ISIS-2151: --- Commit b147834d11a71f1ffcea3997342b500aa92932db in isis's branch refs/heads/v2 from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=b147834 ] ISIS-2151 remove dependency on guava > Pull in Incode's security modul as an extension > --- > > Key: ISIS-2151 > URL: https://issues.apache.org/jira/browse/ISIS-2151 > Project: Isis > Issue Type: Improvement >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
