[jira] [Commented] (ISIS-2223) Mitigate Reliability and Security Issues as detected by Code Quality Analysis

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027259#comment-17027259
 ] 

ASF subversion and git services commented on ISIS-2223:
---

Commit 13a14c0bc3e5d5f8638d08c3d1aca02aa0d46218 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=13a14c0 ]

ISIS-2223: disable analysis for 'isis-subdomains-excel-integtests'

> Mitigate Reliability and Security Issues as detected by Code Quality Analysis
> -
>
> Key: ISIS-2223
> URL: https://issues.apache.org/jira/browse/ISIS-2223
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M2
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>
> See [1] for nightly updated status.
> [1] https://sonarcloud.io/dashboard?id=apache_isis



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2158) Miscellaneous tasks in preparation of Version 2

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027247#comment-17027247
 ] 

ASF subversion and git services commented on ISIS-2158:
---

Commit a06784d6beed8204f22a2d10b6ae71e44e1d2106 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=a06784d ]

ISIS-2158: rest-client: polishing the API + java-doc

> Miscellaneous tasks in preparation of Version 2
> ---
>
> Key: ISIS-2158
> URL: https://issues.apache.org/jira/browse/ISIS-2158
> Project: Isis
>  Issue Type: Task
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2192) Improve the mavendeps-testing, to avoid accidental junit 4 dependency

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026827#comment-17026827
 ] 

ASF subversion and git services commented on ISIS-2192:
---

Commit 011f207266fe3f17cdc08e3dec67ae890c8848ec in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=011f207 ]

ISIS-2192: porsts ExceptionRecognizerTranslate

from junit 4 MethodRule to junit 5 extension


> Improve the mavendeps-testing, to avoid accidental junit 4 dependency
> -
>
> Key: ISIS-2192
> URL: https://issues.apache.org/jira/browse/ISIS-2192
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> At the moment the isis-mavendeps-testing defines transitive dependencies on 
> both unittestsupport and integtestsupport.
>  
> unittestsupport defines the JMock rule stuff, which depends on junit 4: don't 
> want to change this for now.
>  
> for integtestsupport, though, want to force upgrade to junit 5, which also 
> means removing any accidental dependencies on junit:junit:4.x
>  
> The following dependency for integ tests works, but think it might be better 
> to define two different mavendeps, one for unit testing and one for integ 
> testing.
>  
> 
>  org.apache.isis.mavendeps
>  isis-mavendeps-testing
>  pom
>  test
>  
>  
>  org.apache.isis.core
>  isis-unittestsupport
>  
>  
>  org.junit.vintage
>  junit-vintage-engine
>  
>  
> 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2062) Convert website to use Antora

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026823#comment-17026823
 ] 

ASF subversion and git services commented on ISIS-2062:
---

Commit 04cc491fd7d99bc04a11b67bcdc42938243a5b3d in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=04cc491 ]

ISIS-2062: docs


> Convert website to use Antora
> -
>
> Key: ISIS-2062
> URL: https://issues.apache.org/jira/browse/ISIS-2062
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2192) Improve the mavendeps-testing, to avoid accidental junit 4 dependency

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026828#comment-17026828
 ] 

ASF subversion and git services commented on ISIS-2192:
---

Commit 525ea0c605c8568248714249ea24363265e6 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=525ea0c ]

ISIS-2192: ports some unit test from 4 to 5


> Improve the mavendeps-testing, to avoid accidental junit 4 dependency
> -
>
> Key: ISIS-2192
> URL: https://issues.apache.org/jira/browse/ISIS-2192
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> At the moment the isis-mavendeps-testing defines transitive dependencies on 
> both unittestsupport and integtestsupport.
>  
> unittestsupport defines the JMock rule stuff, which depends on junit 4: don't 
> want to change this for now.
>  
> for integtestsupport, though, want to force upgrade to junit 5, which also 
> means removing any accidental dependencies on junit:junit:4.x
>  
> The following dependency for integ tests works, but think it might be better 
> to define two different mavendeps, one for unit testing and one for integ 
> testing.
>  
> 
>  org.apache.isis.mavendeps
>  isis-mavendeps-testing
>  pom
>  test
>  
>  
>  org.apache.isis.core
>  isis-unittestsupport
>  
>  
>  org.junit.vintage
>  junit-vintage-engine
>  
>  
> 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2192) Improve the mavendeps-testing, to avoid accidental junit 4 dependency

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026826#comment-17026826
 ] 

ASF subversion and git services commented on ISIS-2192:
---

Commit ef123c3187538904c50c4a7d41d9d8421660d6b8 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ef123c3 ]

ISIS-2192: sorting out dependencies

go the other way.  Also add in fakedata for all 3


> Improve the mavendeps-testing, to avoid accidental junit 4 dependency
> -
>
> Key: ISIS-2192
> URL: https://issues.apache.org/jira/browse/ISIS-2192
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> At the moment the isis-mavendeps-testing defines transitive dependencies on 
> both unittestsupport and integtestsupport.
>  
> unittestsupport defines the JMock rule stuff, which depends on junit 4: don't 
> want to change this for now.
>  
> for integtestsupport, though, want to force upgrade to junit 5, which also 
> means removing any accidental dependencies on junit:junit:4.x
>  
> The following dependency for integ tests works, but think it might be better 
> to define two different mavendeps, one for unit testing and one for integ 
> testing.
>  
> 
>  org.apache.isis.mavendeps
>  isis-mavendeps-testing
>  pom
>  test
>  
>  
>  org.apache.isis.core
>  isis-unittestsupport
>  
>  
>  org.junit.vintage
>  junit-vintage-engine
>  
>  
> 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2274) Properties should be disabled by default.

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026830#comment-17026830
 ] 

ASF subversion and git services commented on ISIS-2274:
---

Commit dd4855221913fbdc750bb43fe2272557988595cd in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=dd48552 ]

ISIS-2274: fixes for smoke test, I hope (fix typo)


> Properties should be disabled by default.
> -
>
> Key: ISIS-2274
> URL: https://issues.apache.org/jira/browse/ISIS-2274
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> This is a change in policy from v1 ...
> isis.applib.annotation.domain-object.editing = false



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2274) Properties should be disabled by default.

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026829#comment-17026829
 ] 

ASF subversion and git services commented on ISIS-2274:
---

Commit db36047ec8b415bb6c88756842e48c13dfb30147 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=db36047 ]

ISIS-2274: fixes for smoke test, I hope


> Properties should be disabled by default.
> -
>
> Key: ISIS-2274
> URL: https://issues.apache.org/jira/browse/ISIS-2274
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> This is a change in policy from v1 ...
> isis.applib.annotation.domain-object.editing = false



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2192) Improve the mavendeps-testing, to avoid accidental junit 4 dependency

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026825#comment-17026825
 ] 

ASF subversion and git services commented on ISIS-2192:
---

Commit e7eaf0a5c763891dba33b4816a68835501ae8c9f in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=e7eaf0a ]

ISIS-2192: sorting out dependencies

have a cycle fixtures <-> integtestsupport-applib


> Improve the mavendeps-testing, to avoid accidental junit 4 dependency
> -
>
> Key: ISIS-2192
> URL: https://issues.apache.org/jira/browse/ISIS-2192
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> At the moment the isis-mavendeps-testing defines transitive dependencies on 
> both unittestsupport and integtestsupport.
>  
> unittestsupport defines the JMock rule stuff, which depends on junit 4: don't 
> want to change this for now.
>  
> for integtestsupport, though, want to force upgrade to junit 5, which also 
> means removing any accidental dependencies on junit:junit:4.x
>  
> The following dependency for integ tests works, but think it might be better 
> to define two different mavendeps, one for unit testing and one for integ 
> testing.
>  
> 
>  org.apache.isis.mavendeps
>  isis-mavendeps-testing
>  pom
>  test
>  
>  
>  org.apache.isis.core
>  isis-unittestsupport
>  
>  
>  org.junit.vintage
>  junit-vintage-engine
>  
>  
> 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2192) Improve the mavendeps-testing, to avoid accidental junit 4 dependency

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026824#comment-17026824
 ] 

ASF subversion and git services commented on ISIS-2192:
---

Commit 348ce73e7ad849f4239b1d84192b1c22c7ae7a5f in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=348ce73 ]

ISIS-2192: splits mavendeps-testing into 3

* mavendeps-unittests
* mavendeps-integtests
* mavendeps-integspecs


> Improve the mavendeps-testing, to avoid accidental junit 4 dependency
> -
>
> Key: ISIS-2192
> URL: https://issues.apache.org/jira/browse/ISIS-2192
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> At the moment the isis-mavendeps-testing defines transitive dependencies on 
> both unittestsupport and integtestsupport.
>  
> unittestsupport defines the JMock rule stuff, which depends on junit 4: don't 
> want to change this for now.
>  
> for integtestsupport, though, want to force upgrade to junit 5, which also 
> means removing any accidental dependencies on junit:junit:4.x
>  
> The following dependency for integ tests works, but think it might be better 
> to define two different mavendeps, one for unit testing and one for integ 
> testing.
>  
> 
>  org.apache.isis.mavendeps
>  isis-mavendeps-testing
>  pom
>  test
>  
>  
>  org.apache.isis.core
>  isis-unittestsupport
>  
>  
>  org.junit.vintage
>  junit-vintage-engine
>  
>  
> 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ISIS-2192) Improve the mavendeps-testing, to avoid accidental junit 4 dependency

2020-01-30 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood reassigned ISIS-2192:
-

Assignee: Daniel Keir Haywood

> Improve the mavendeps-testing, to avoid accidental junit 4 dependency
> -
>
> Key: ISIS-2192
> URL: https://issues.apache.org/jira/browse/ISIS-2192
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> At the moment the isis-mavendeps-testing defines transitive dependencies on 
> both unittestsupport and integtestsupport.
>  
> unittestsupport defines the JMock rule stuff, which depends on junit 4: don't 
> want to change this for now.
>  
> for integtestsupport, though, want to force upgrade to junit 5, which also 
> means removing any accidental dependencies on junit:junit:4.x
>  
> The following dependency for integ tests works, but think it might be better 
> to define two different mavendeps, one for unit testing and one for integ 
> testing.
>  
> 
>  org.apache.isis.mavendeps
>  isis-mavendeps-testing
>  pom
>  test
>  
>  
>  org.apache.isis.core
>  isis-unittestsupport
>  
>  
>  org.junit.vintage
>  junit-vintage-engine
>  
>  
> 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2223) Mitigate Reliability and Security Issues as detected by Code Quality Analysis

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026720#comment-17026720
 ] 

ASF subversion and git services commented on ISIS-2223:
---

Commit 5caed7435e077d24f48725b9a08f565a36cd6208 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=5caed74 ]

ISIS-2223: integrate jacoco with surefire

- that is allow jacoco to modify the argLine as passed over to surefire

https://stackoverflow.com/questions/46489455/append-the-value-of-argline-param-in-maven-surefire-plugin/46490011

> Mitigate Reliability and Security Issues as detected by Code Quality Analysis
> -
>
> Key: ISIS-2223
> URL: https://issues.apache.org/jira/browse/ISIS-2223
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M2
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>
> See [1] for nightly updated status.
> [1] https://sonarcloud.io/dashboard?id=apache_isis



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2223) Mitigate Reliability and Security Issues as detected by Code Quality Analysis

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026691#comment-17026691
 ] 

ASF subversion and git services commented on ISIS-2223:
---

Commit 67edd07161e221b497f4199074f6d2f1521d7f24 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=67edd07 ]

ISIS-2223: add jacoco maven plugin (should enable code coverage reports)

> Mitigate Reliability and Security Issues as detected by Code Quality Analysis
> -
>
> Key: ISIS-2223
> URL: https://issues.apache.org/jira/browse/ISIS-2223
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M2
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>
> See [1] for nightly updated status.
> [1] https://sonarcloud.io/dashboard?id=apache_isis



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2223) Mitigate Reliability and Security Issues as detected by Code Quality Analysis

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026654#comment-17026654
 ] 

ASF subversion and git services commented on ISIS-2223:
---

Commit 291913b3f80d8216b7e937d1509efa5939a6a087 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=291913b ]

ISIS-2223: marks 2 thread-local's deprecated (no mitigation yet)

> Mitigate Reliability and Security Issues as detected by Code Quality Analysis
> -
>
> Key: ISIS-2223
> URL: https://issues.apache.org/jira/browse/ISIS-2223
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M2
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>
> See [1] for nightly updated status.
> [1] https://sonarcloud.io/dashboard?id=apache_isis



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2223) Mitigate Reliability and Security Issues as detected by Code Quality Analysis

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026645#comment-17026645
 ] 

ASF subversion and git services commented on ISIS-2223:
---

Commit 6d08555a472c91af5dd880f2b3522e0b232d2bb2 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6d08555 ]

ISIS-2223: propagate previous mitigations also to 'internaltestsupport'

> Mitigate Reliability and Security Issues as detected by Code Quality Analysis
> -
>
> Key: ISIS-2223
> URL: https://issues.apache.org/jira/browse/ISIS-2223
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M2
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>
> See [1] for nightly updated status.
> [1] https://sonarcloud.io/dashboard?id=apache_isis



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2223) Mitigate Reliability and Security Issues as detected by Code Quality Analysis

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026628#comment-17026628
 ] 

ASF subversion and git services commented on ISIS-2223:
---

Commit 5393e042b3620cc7b863a30d0c12b235e1dae6c9 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=5393e04 ]

ISIS-2223: fixes regression from previous commit

> Mitigate Reliability and Security Issues as detected by Code Quality Analysis
> -
>
> Key: ISIS-2223
> URL: https://issues.apache.org/jira/browse/ISIS-2223
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M2
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>
> See [1] for nightly updated status.
> [1] https://sonarcloud.io/dashboard?id=apache_isis



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2223) Mitigate Reliability and Security Issues as detected by Code Quality Analysis

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026623#comment-17026623
 ] 

ASF subversion and git services commented on ISIS-2223:
---

Commit ca8760fea7ddce7dc101c6948086d98c0f1ee2cf in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=ca8760f ]

ISIS-2223: fixes null check bug in shared test class

> Mitigate Reliability and Security Issues as detected by Code Quality Analysis
> -
>
> Key: ISIS-2223
> URL: https://issues.apache.org/jira/browse/ISIS-2223
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M2
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>
> See [1] for nightly updated status.
> [1] https://sonarcloud.io/dashboard?id=apache_isis



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2223) Mitigate Reliability and Security Issues as detected by Code Quality Analysis

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026624#comment-17026624
 ] 

ASF subversion and git services commented on ISIS-2223:
---

Commit 58ab592c93f1e34382d1b56949d27f73324a2d3c in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=58ab592 ]

ISIS-2223: remove deprecated mocking 'one(...)'

- also remove generic type parameter in ExpectationsOn (no way the
compiler can make use of this anyway)
- also remove Double Brace Initialization (DBI)

> Mitigate Reliability and Security Issues as detected by Code Quality Analysis
> -
>
> Key: ISIS-2223
> URL: https://issues.apache.org/jira/browse/ISIS-2223
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M2
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>
> See [1] for nightly updated status.
> [1] https://sonarcloud.io/dashboard?id=apache_isis



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2158) Miscellaneous tasks in preparation of Version 2

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026621#comment-17026621
 ] 

ASF subversion and git services commented on ISIS-2158:
---

Commit 5a2f0b13724048d84ad19ceca1e727f7695daae5 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=5a2f0b1 ]

ISIS-2158: move sorting logic to ManagedObject (for possible reuse)

> Miscellaneous tasks in preparation of Version 2
> ---
>
> Key: ISIS-2158
> URL: https://issues.apache.org/jira/browse/ISIS-2158
> Project: Isis
>  Issue Type: Task
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2158) Miscellaneous tasks in preparation of Version 2

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026620#comment-17026620
 ] 

ASF subversion and git services commented on ISIS-2158:
---

Commit fbd4d7d251ed40387eeb9c1591b8a88ca372610d in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fbd4d7d ]

ISIS-2158: correcting RO pom name

> Miscellaneous tasks in preparation of Version 2
> ---
>
> Key: ISIS-2158
> URL: https://issues.apache.org/jira/browse/ISIS-2158
> Project: Isis
>  Issue Type: Task
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ISIS-2274) Properties should be disabled by default.

2020-01-30 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood resolved ISIS-2274.
---
Resolution: Fixed

> Properties should be disabled by default.
> -
>
> Key: ISIS-2274
> URL: https://issues.apache.org/jira/browse/ISIS-2274
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> This is a change in policy from v1 ...
> isis.applib.annotation.domain-object.editing = false



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ISIS-2272) Simplify @HomePage support - just use as annotation on type, not for an action.

2020-01-30 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood resolved ISIS-2272.
---
Resolution: Fixed

> Simplify @HomePage support - just use as annotation on type, not for an 
> action.
> ---
>
> Key: ISIS-2272
> URL: https://issues.apache.org/jira/browse/ISIS-2272
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>
> For two reasons:
>  * first, because almost always a home page will be a view model, so the only 
> thing that this change does not support - which is to display the results of 
> an action being arbitrary standalone collections - can be easily simulated as 
> the parented collection of a view model
>  * second, because the current implementation to support @HomePage on actions 
> requires a dummy helper class that exposes this action into the metamodel, 
> but it is also exposed in the REST API, which is not ideal.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ISIS-2273) Move most of core-unittestsupport into testing. Perhaps all of it.

2020-01-30 Thread Daniel Keir Haywood (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Keir Haywood resolved ISIS-2273.
---
Resolution: Fixed

> Move most of core-unittestsupport into testing.  Perhaps all of it.
> ---
>
> Key: ISIS-2273
> URL: https://issues.apache.org/jira/browse/ISIS-2273
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2274) Properties should be disabled by default.

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026517#comment-17026517
 ] 

ASF subversion and git services commented on ISIS-2274:
---

Commit dcefb438bbe509f7f6dddbd5503bf19ce80b820e in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=dcefb43 ]

ISIS-2274: fixes unit tests


> Properties should be disabled by default.
> -
>
> Key: ISIS-2274
> URL: https://issues.apache.org/jira/browse/ISIS-2274
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> This is a change in policy from v1 ...
> isis.applib.annotation.domain-object.editing = false



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2094) Release tasks for 2.0.0

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026516#comment-17026516
 ] 

ASF subversion and git services commented on ISIS-2094:
---

Commit aad0c98807d00a2bff64334333a7679d0450adde in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=aad0c98 ]

ISIS-2094: reducing noise of build, ctd


> Release tasks for 2.0.0
> ---
>
> Key: ISIS-2094
> URL: https://issues.apache.org/jira/browse/ISIS-2094
> Project: Isis
>  Issue Type: Task
>Affects Versions: 2.0.0-M2
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> Consider adding credits to the web-site including ...
> - Icons made by [Freepik|http://www.freepik.com/] and 
> [Smashicons|https://www.flaticon.com/authors/smashicons] from 
> [www.flaticon.com|https://www.flaticon.com/] which are licensed by [CC 3.0 
> BY|http://creativecommons.org/licenses/by/3.0/].
> - We use [flexmark|https://github.com/vsch/flexmark-java] for markdown 
> rendering.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2274) Properties should be disabled by default.

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026519#comment-17026519
 ] 

ASF subversion and git services commented on ISIS-2274:
---

Commit 72118c8200f682b9ed85503dade7c9c3109c1724 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=72118c8 ]

ISIS-2274: fixes unit tests


> Properties should be disabled by default.
> -
>
> Key: ISIS-2274
> URL: https://issues.apache.org/jira/browse/ISIS-2274
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> This is a change in policy from v1 ...
> isis.applib.annotation.domain-object.editing = false



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2094) Release tasks for 2.0.0

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026518#comment-17026518
 ] 

ASF subversion and git services commented on ISIS-2094:
---

Commit 8e9b9055ccbd5a281bd83a10a28a9cebd3468097 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=8e9b905 ]

ISIS-2094: reducing noise of build, ctd


> Release tasks for 2.0.0
> ---
>
> Key: ISIS-2094
> URL: https://issues.apache.org/jira/browse/ISIS-2094
> Project: Isis
>  Issue Type: Task
>Affects Versions: 2.0.0-M2
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> Consider adding credits to the web-site including ...
> - Icons made by [Freepik|http://www.freepik.com/] and 
> [Smashicons|https://www.flaticon.com/authors/smashicons] from 
> [www.flaticon.com|https://www.flaticon.com/] which are licensed by [CC 3.0 
> BY|http://creativecommons.org/licenses/by/3.0/].
> - We use [flexmark|https://github.com/vsch/flexmark-java] for markdown 
> rendering.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2094) Release tasks for 2.0.0

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026513#comment-17026513
 ] 

ASF subversion and git services commented on ISIS-2094:
---

Commit 90c381d9f4785184763a7b3e44ccf3aa155fa1ac in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=90c381d ]

ISIS-2094: reducing noise of build, ctd


> Release tasks for 2.0.0
> ---
>
> Key: ISIS-2094
> URL: https://issues.apache.org/jira/browse/ISIS-2094
> Project: Isis
>  Issue Type: Task
>Affects Versions: 2.0.0-M2
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> Consider adding credits to the web-site including ...
> - Icons made by [Freepik|http://www.freepik.com/] and 
> [Smashicons|https://www.flaticon.com/authors/smashicons] from 
> [www.flaticon.com|https://www.flaticon.com/] which are licensed by [CC 3.0 
> BY|http://creativecommons.org/licenses/by/3.0/].
> - We use [flexmark|https://github.com/vsch/flexmark-java] for markdown 
> rendering.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2094) Release tasks for 2.0.0

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026511#comment-17026511
 ] 

ASF subversion and git services commented on ISIS-2094:
---

Commit b082b55a75ab7ac829c1445a68e2328c71dd7039 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b082b55 ]

ISIS-2094: reducing noise of build, ctd


> Release tasks for 2.0.0
> ---
>
> Key: ISIS-2094
> URL: https://issues.apache.org/jira/browse/ISIS-2094
> Project: Isis
>  Issue Type: Task
>Affects Versions: 2.0.0-M2
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> Consider adding credits to the web-site including ...
> - Icons made by [Freepik|http://www.freepik.com/] and 
> [Smashicons|https://www.flaticon.com/authors/smashicons] from 
> [www.flaticon.com|https://www.flaticon.com/] which are licensed by [CC 3.0 
> BY|http://creativecommons.org/licenses/by/3.0/].
> - We use [flexmark|https://github.com/vsch/flexmark-java] for markdown 
> rendering.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2094) Release tasks for 2.0.0

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026510#comment-17026510
 ] 

ASF subversion and git services commented on ISIS-2094:
---

Commit a35bb9495eae551bb34af79b5cfb987b2548bdc1 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=a35bb94 ]

ISIS-2094: reducing noise of build


> Release tasks for 2.0.0
> ---
>
> Key: ISIS-2094
> URL: https://issues.apache.org/jira/browse/ISIS-2094
> Project: Isis
>  Issue Type: Task
>Affects Versions: 2.0.0-M2
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> Consider adding credits to the web-site including ...
> - Icons made by [Freepik|http://www.freepik.com/] and 
> [Smashicons|https://www.flaticon.com/authors/smashicons] from 
> [www.flaticon.com|https://www.flaticon.com/] which are licensed by [CC 3.0 
> BY|http://creativecommons.org/licenses/by/3.0/].
> - We use [flexmark|https://github.com/vsch/flexmark-java] for markdown 
> rendering.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2094) Release tasks for 2.0.0

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026515#comment-17026515
 ] 

ASF subversion and git services commented on ISIS-2094:
---

Commit 6b86e98826233a37168b72adf4b8b4f46a07 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6b86e93 ]

ISIS-2094: reducing noise of build, ctd


> Release tasks for 2.0.0
> ---
>
> Key: ISIS-2094
> URL: https://issues.apache.org/jira/browse/ISIS-2094
> Project: Isis
>  Issue Type: Task
>Affects Versions: 2.0.0-M2
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> Consider adding credits to the web-site including ...
> - Icons made by [Freepik|http://www.freepik.com/] and 
> [Smashicons|https://www.flaticon.com/authors/smashicons] from 
> [www.flaticon.com|https://www.flaticon.com/] which are licensed by [CC 3.0 
> BY|http://creativecommons.org/licenses/by/3.0/].
> - We use [flexmark|https://github.com/vsch/flexmark-java] for markdown 
> rendering.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2094) Release tasks for 2.0.0

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026512#comment-17026512
 ] 

ASF subversion and git services commented on ISIS-2094:
---

Commit 44e25144578e776f1a4c37afa0a321d760e482c5 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=44e2514 ]

ISIS-2094: reducing noise of build, ctd


> Release tasks for 2.0.0
> ---
>
> Key: ISIS-2094
> URL: https://issues.apache.org/jira/browse/ISIS-2094
> Project: Isis
>  Issue Type: Task
>Affects Versions: 2.0.0-M2
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> Consider adding credits to the web-site including ...
> - Icons made by [Freepik|http://www.freepik.com/] and 
> [Smashicons|https://www.flaticon.com/authors/smashicons] from 
> [www.flaticon.com|https://www.flaticon.com/] which are licensed by [CC 3.0 
> BY|http://creativecommons.org/licenses/by/3.0/].
> - We use [flexmark|https://github.com/vsch/flexmark-java] for markdown 
> rendering.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2094) Release tasks for 2.0.0

2020-01-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026514#comment-17026514
 ] 

ASF subversion and git services commented on ISIS-2094:
---

Commit aaac152bdecc5922c9ca31f41c24c99dd28d4716 in isis's branch 
refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=aaac152 ]

ISIS-2094: reducing noise of build, ctd


> Release tasks for 2.0.0
> ---
>
> Key: ISIS-2094
> URL: https://issues.apache.org/jira/browse/ISIS-2094
> Project: Isis
>  Issue Type: Task
>Affects Versions: 2.0.0-M2
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> Consider adding credits to the web-site including ...
> - Icons made by [Freepik|http://www.freepik.com/] and 
> [Smashicons|https://www.flaticon.com/authors/smashicons] from 
> [www.flaticon.com|https://www.flaticon.com/] which are licensed by [CC 3.0 
> BY|http://creativecommons.org/licenses/by/3.0/].
> - We use [flexmark|https://github.com/vsch/flexmark-java] for markdown 
> rendering.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)