[jira] [Updated] (ISIS-2235) Mixins declared using @Property, @Collection or @Action should propagate facets correctly

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber updated ISIS-2235:
-
Summary: Mixins declared using @Property, @Collection or @Action should 
propagate facets correctly  (was: Mixins declared using @Property, @Collection 
or @Action shouldn't need to indicate contribution style.)

> Mixins declared using @Property, @Collection or @Action should propagate 
> facets correctly
> -
>
> Key: ISIS-2235
> URL: https://issues.apache.org/jira/browse/ISIS-2235
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> for example, with this mixin:
> {code:java}
> @Property
> public class SimpleObject_self {
> private final SimpleObject simpleObject;
> public SimpleObject_self(SimpleObject simpleObject) {
> this.simpleObject = simpleObject;
> }
> @ActionLayout(contributed = Contributed.AS_ASSOCIATION)
> public SimpleObject prop() {
> return simpleObject;
> }
> }
>  {code}
> it's necessary to specify @ActionLayout, otherwise the behaviour is 
> contributed as both an association and an action.
> The @ActionLayout should be inferred.
> ~~~
> See the same for @Collection and @Action also ... should imply AS_ASSOCIATION 
> and AS_ACTION respectively.
> ~~~
> Also, (and this might be a slightly different issue), the facets defined by 
> @Property(...) should be copied down correctly to the corresponding facets on 
> the action, eg domain event (this might need specifying more precisely...)
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ISIS-2329) Support nested non-static mixins, with domain event class declared within.

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber reassigned ISIS-2329:


Assignee: Andi Huber

> Support nested non-static mixins, with domain event class declared within.
> --
>
> Key: ISIS-2329
> URL: https://issues.apache.org/jira/browse/ISIS-2329
> Project: Isis
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M3
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> To support this, need to allow action domain events to have 1-arg 
> constructor, being the mixee. 
> eg, at the moment, in simpleapp, I can refactor updateName into a mixin:
> {code:java}
> public static class UpdateNameActionDomainEvent 
>   extends SimpleModule.ActionDomainEvent { }
> @Action(semantics = IDEMPOTENT,
> command = CommandReification.ENABLED, publishing = 
> Publishing.DISABLED,
> associateWith = "name", domainEvent = 
> UpdateNotesActionDomainEvent.class)
> public class updateName {
> public SimpleObject act(@Name final String name) {
> setName(name);
> return SimpleObject.this;
> }
> public String default0Act() {
> return getName();
> }
> }
>  {code}
> but the  UpdateNameActionDomainEvent has to remain outside for now.  Instead, 
> I'd like to write:
> {code:java}
> @Action(semantics = IDEMPOTENT,
> command = CommandReification.ENABLED, publishing = 
> Publishing.DISABLED,
> associateWith = "name", domainEvent = 
> UpdateNotesActionDomainEvent.class)
> public class updateName {
>public class UpdateNameActionDomainEvent 
>  extends SimpleModule.ActionDomainEvent { } 
> public SimpleObject act(@Name final String name) {
> setName(name);
> return SimpleObject.this;
> }
> public String default0Act() {
> return getName();
> }
> }
>  {code}
> The fix should be quite simple: improve the instantiation logic in 
> DomainEventHelper to handle events with 1 arg as well as 0 args and 3 args.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ISIS-2328) Missing publisher facet for @Action declared on mixin.

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber reassigned ISIS-2328:


Assignee: Andi Huber

> Missing publisher facet for @Action declared on mixin.
> --
>
> Key: ISIS-2328
> URL: https://issues.apache.org/jira/browse/ISIS-2328
> Project: Isis
>  Issue Type: Bug
>Affects Versions: 2.0.0-M3
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> At least this facet is not picked up, as in @Action(publishing=ENABLED); 
> perhaps others too?
> Seems to be an issue irrespective of whether we use
> * @Action(publishing=ENABLED) on the mixin type, or
> * the older style of @Mixin(method="act") on the mixin type and then 
> @Action(published=ENABLED)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-2098) Buttons (action-links) with confirmation don't show their associated tooltip

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-2098.

  Assignee: Andi Huber
Resolution: Fixed

> Buttons (action-links) with confirmation don't show their associated tooltip
> 
>
> Key: ISIS-2098
> URL: https://issues.apache.org/jira/browse/ISIS-2098
> Project: Isis
>  Issue Type: Sub-task
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M4
>
> Attachments: no-tooltip-2.png
>
>
> Buttons (action-links) with confirmation don't show their associated tooltip 
> when mouse-over.
> Tooltip text is however rendered after clicking on the button (on top of the 
> opened confirmation-dialog). 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2324) Merge kroviz

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber updated ISIS-2324:
-
Affects Version/s: (was: 2.0.0-M4)

> Merge kroviz
> 
>
> Key: ISIS-2324
> URL: https://issues.apache.org/jira/browse/ISIS-2324
> Project: Isis
>  Issue Type: Task
>  Components: Isis Incubator
>Reporter: Jörg Rade
>Assignee: Jörg Rade
>Priority: Minor
> Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2324) Merge kroviz

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber updated ISIS-2324:
-
Fix Version/s: 2.0.0-M4

> Merge kroviz
> 
>
> Key: ISIS-2324
> URL: https://issues.apache.org/jira/browse/ISIS-2324
> Project: Isis
>  Issue Type: Task
>  Components: Isis Incubator
>Affects Versions: 2.0.0-M4
>Reporter: Jörg Rade
>Assignee: Jörg Rade
>Priority: Minor
> Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2235) Mixins declared using @Property, @Collection or @Action shouldn't need to indicate contribution style.

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber updated ISIS-2235:
-
Component/s: (was: Isis Applib (programming model))
 Isis Core

> Mixins declared using @Property, @Collection or @Action shouldn't need to 
> indicate contribution style.
> --
>
> Key: ISIS-2235
> URL: https://issues.apache.org/jira/browse/ISIS-2235
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> for example, with this mixin:
> {code:java}
> @Property
> public class SimpleObject_self {
> private final SimpleObject simpleObject;
> public SimpleObject_self(SimpleObject simpleObject) {
> this.simpleObject = simpleObject;
> }
> @ActionLayout(contributed = Contributed.AS_ASSOCIATION)
> public SimpleObject prop() {
> return simpleObject;
> }
> }
>  {code}
> it's necessary to specify @ActionLayout, otherwise the behaviour is 
> contributed as both an association and an action.
> The @ActionLayout should be inferred.
> ~~~
> See the same for @Collection and @Action also ... should imply AS_ASSOCIATION 
> and AS_ACTION respectively.
> ~~~
> Also, (and this might be a slightly different issue), the facets defined by 
> @Property(...) should be copied down correctly to the corresponding facets on 
> the action, eg domain event (this might need specifying more precisely...)
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2235) Mixins declared using @Property, @Collection or @Action shouldn't need to indicate contribution style.

2020-03-24 Thread Andi Huber (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066398#comment-17066398
 ] 

Andi Huber commented on ISIS-2235:
--

first part already fixed, second suggests showcasing with the Mixin Demo

> Mixins declared using @Property, @Collection or @Action shouldn't need to 
> indicate contribution style.
> --
>
> Key: ISIS-2235
> URL: https://issues.apache.org/jira/browse/ISIS-2235
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Applib (programming model)
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> for example, with this mixin:
> {code:java}
> @Property
> public class SimpleObject_self {
> private final SimpleObject simpleObject;
> public SimpleObject_self(SimpleObject simpleObject) {
> this.simpleObject = simpleObject;
> }
> @ActionLayout(contributed = Contributed.AS_ASSOCIATION)
> public SimpleObject prop() {
> return simpleObject;
> }
> }
>  {code}
> it's necessary to specify @ActionLayout, otherwise the behaviour is 
> contributed as both an association and an action.
> The @ActionLayout should be inferred.
> ~~~
> See the same for @Collection and @Action also ... should imply AS_ASSOCIATION 
> and AS_ACTION respectively.
> ~~~
> Also, (and this might be a slightly different issue), the facets defined by 
> @Property(...) should be copied down correctly to the corresponding facets on 
> the action, eg domain event (this might need specifying more precisely...)
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ISIS-2235) Mixins declared using @Property, @Collection or @Action shouldn't need to indicate contribution style.

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber reassigned ISIS-2235:


Assignee: Andi Huber

> Mixins declared using @Property, @Collection or @Action shouldn't need to 
> indicate contribution style.
> --
>
> Key: ISIS-2235
> URL: https://issues.apache.org/jira/browse/ISIS-2235
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Applib (programming model)
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> for example, with this mixin:
> {code:java}
> @Property
> public class SimpleObject_self {
> private final SimpleObject simpleObject;
> public SimpleObject_self(SimpleObject simpleObject) {
> this.simpleObject = simpleObject;
> }
> @ActionLayout(contributed = Contributed.AS_ASSOCIATION)
> public SimpleObject prop() {
> return simpleObject;
> }
> }
>  {code}
> it's necessary to specify @ActionLayout, otherwise the behaviour is 
> contributed as both an association and an action.
> The @ActionLayout should be inferred.
> ~~~
> See the same for @Collection and @Action also ... should imply AS_ASSOCIATION 
> and AS_ACTION respectively.
> ~~~
> Also, (and this might be a slightly different issue), the facets defined by 
> @Property(...) should be copied down correctly to the corresponding facets on 
> the action, eg domain event (this might need specifying more precisely...)
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [ANNOUNCE] - New committer - Jörg Rade

2020-03-24 Thread Kevin Meyer
Welcome Jörg!

You've been a silent partner for too long.

On 23 March 2020 10:05:23 CET, Dan Haywood  
wrote:
>Hi folks,
>
>I'm delighted to announce that Jörg Rade has been voted in as a
>committer
>for Apache Isis, and also as a member of the Apache Isis PMC.  The
>first
>gives Jörg the right to commit changes directly to Isis' codebase, the
>second gives him the right to be involved in future votes.
>
>Jörg has been active in the community for more than five years, and has
>been actively been developing a new viewer for the framework, called
>"Kroviz" .  This runs against the REST API provided by the Restful
>Objects
>viewer, and is implemented in Kotlin (running in the browser as
>KotlinJS).
>I'm delighted to say that Jörg will be donating this codebase to the
>framework and will continue to develop it within our new "incubator".
>
>Jörg is also very visible on our new Slack channel (he's been sharing
>the
>status on Kroviz there for quite a while) so if you want to ping him
>and
>ask him questions about this new viewer, I'm sure he'd be very willing
>
>I'm looking forward to continue working with Jörg in the future;
>another
>great addition to Isis' committers.
>
>Dan

-- 
Sent from my phone with K-9 Mail.
Please excuse my brevity.


[jira] [Closed] (ISIS-2327) Use new Popover Label for Object Reference Tooltips

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-2327.

Resolution: Fixed

implemented

> Use new Popover Label for Object Reference Tooltips
> ---
>
> Key: ISIS-2327
> URL: https://issues.apache.org/jira/browse/ISIS-2327
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2327) Use new Popover Label for Object Reference Tooltips

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066389#comment-17066389
 ] 

ASF subversion and git services commented on ISIS-2327:
---

Commit d935c4a35b648f89e23759f4b5b6b2e77bee5481 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=d935c4a ]

ISIS-2327: use popover label for object reference tooltips

> Use new Popover Label for Object Reference Tooltips
> ---
>
> Key: ISIS-2327
> URL: https://issues.apache.org/jira/browse/ISIS-2327
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2062) Convert website to use Antora

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066279#comment-17066279
 ] 

ASF subversion and git services commented on ISIS-2062:
---

Commit 0bf957a9c7fd2a3e363f14303cffe8613ff8415f in isis's branch 
refs/heads/ISIS-2062 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0bf957a ]

ISIS-2062: remove unused stuff from userguide


> Convert website to use Antora
> -
>
> Key: ISIS-2062
> URL: https://issues.apache.org/jira/browse/ISIS-2062
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2062) Convert website to use Antora

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066278#comment-17066278
 ] 

ASF subversion and git services commented on ISIS-2062:
---

Commit 37ae51f16923ffef2a0d82fd6faa5d8aa38a3b27 in isis's branch 
refs/heads/ISIS-2062 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=37ae51f ]

ISIS-2062: menu and object layouts

in the user guide


> Convert website to use Antora
> -
>
> Key: ISIS-2062
> URL: https://issues.apache.org/jira/browse/ISIS-2062
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2062) Convert website to use Antora

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066118#comment-17066118
 ] 

ASF subversion and git services commented on ISIS-2062:
---

Commit 434e4b0164e4082f6d805ab46c36415ea0dd6495 in isis's branch 
refs/heads/ISIS-2062 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=434e4b0 ]

ISIS-2062: removes some duplication

re object types docs, programming model


> Convert website to use Antora
> -
>
> Key: ISIS-2062
> URL: https://issues.apache.org/jira/browse/ISIS-2062
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2062) Convert website to use Antora

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066120#comment-17066120
 ] 

ASF subversion and git services commented on ISIS-2062:
---

Commit fa492074634db9e46c4b1718e0e59c9dcf8b9c91 in isis's branch 
refs/heads/ISIS-2062 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fa49207 ]

ISIS-2062: some inlining of user guide stuff


> Convert website to use Antora
> -
>
> Key: ISIS-2062
> URL: https://issues.apache.org/jira/browse/ISIS-2062
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2062) Convert website to use Antora

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066119#comment-17066119
 ] 

ASF subversion and git services commented on ISIS-2062:
---

Commit 08d427abf236e824d88b67935162bf747707017d in isis's branch 
refs/heads/ISIS-2062 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=08d427a ]

ISIS-2062: flattens user guide


> Convert website to use Antora
> -
>
> Key: ISIS-2062
> URL: https://issues.apache.org/jira/browse/ISIS-2062
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2062) Convert website to use Antora

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066121#comment-17066121
 ] 

ASF subversion and git services commented on ISIS-2062:
---

Commit 6cfddcd2de59b234cffd363ca8046854987c588d in isis's branch 
refs/heads/ISIS-2062 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=6cfddcd ]

ISIS-2062: more on the user guide


> Convert website to use Antora
> -
>
> Key: ISIS-2062
> URL: https://issues.apache.org/jira/browse/ISIS-2062
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2062) Convert website to use Antora

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065924#comment-17065924
 ] 

ASF subversion and git services commented on ISIS-2062:
---

Commit 3a862b23112ce1a9ff111b47d49bef336f06328f in isis's branch 
refs/heads/ISIS-2062 from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=3a862b2 ]

ISIS-2062: user guide docs


> Convert website to use Antora
> -
>
> Key: ISIS-2062
> URL: https://issues.apache.org/jira/browse/ISIS-2062
> Project: Isis
>  Issue Type: Improvement
>Reporter: Daniel Keir Haywood
>Assignee: Daniel Keir Haywood
>Priority: Major
> Fix For: 2.0.0-M3
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ISIS-2329) Support nested non-static mixins, with domain event class declared within.

2020-03-24 Thread Daniel Keir Haywood (Jira)
Daniel Keir Haywood created ISIS-2329:
-

 Summary: Support nested non-static mixins, with domain event class 
declared within.
 Key: ISIS-2329
 URL: https://issues.apache.org/jira/browse/ISIS-2329
 Project: Isis
  Issue Type: Improvement
Affects Versions: 2.0.0-M3
Reporter: Daniel Keir Haywood
 Fix For: 2.0.0-M4


To support this, need to allow action domain events to have 1-arg constructor, 
being the mixee. 

eg, at the moment, in simpleapp, I can refactor updateName into a mixin:
{code:java}
public static class UpdateNameActionDomainEvent 
  extends SimpleModule.ActionDomainEvent { }

@Action(semantics = IDEMPOTENT,
command = CommandReification.ENABLED, publishing = Publishing.DISABLED,
associateWith = "name", domainEvent = 
UpdateNotesActionDomainEvent.class)
public class updateName {

public SimpleObject act(@Name final String name) {
setName(name);
return SimpleObject.this;
}

public String default0Act() {
return getName();
}
}
 {code}
but the  UpdateNameActionDomainEvent has to remain outside for now.  Instead, 
I'd like to write:
{code:java}
@Action(semantics = IDEMPOTENT,
command = CommandReification.ENABLED, publishing = Publishing.DISABLED,
associateWith = "name", domainEvent = 
UpdateNotesActionDomainEvent.class)
public class updateName {

   public class UpdateNameActionDomainEvent 
 extends SimpleModule.ActionDomainEvent { } 

public SimpleObject act(@Name final String name) {
setName(name);
return SimpleObject.this;
}

public String default0Act() {
return getName();
}
}
 {code}
The fix should be quite simple: improve the instantiation logic in 
DomainEventHelper to handle events with 1 arg as well as 0 args and 3 args.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ISIS-2328) Missing publisher facet for @Action declared on mixin.

2020-03-24 Thread Daniel Keir Haywood (Jira)
Daniel Keir Haywood created ISIS-2328:
-

 Summary: Missing publisher facet for @Action declared on mixin.
 Key: ISIS-2328
 URL: https://issues.apache.org/jira/browse/ISIS-2328
 Project: Isis
  Issue Type: Bug
Affects Versions: 2.0.0-M3
Reporter: Daniel Keir Haywood
 Fix For: 2.0.0-M4


At least this facet is not picked up, as in @Action(publishing=ENABLED); 
perhaps others too?

Seems to be an issue irrespective of whether we use

* @Action(publishing=ENABLED) on the mixin type, or

* the older style of @Mixin(method="act") on the mixin type and then 
@Action(published=ENABLED)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ISIS-2327) Use new Popover Label for Object Reference Tooltips

2020-03-24 Thread Andi Huber (Jira)
Andi Huber created ISIS-2327:


 Summary: Use new Popover Label for Object Reference Tooltips
 Key: ISIS-2327
 URL: https://issues.apache.org/jira/browse/ISIS-2327
 Project: Isis
  Issue Type: Improvement
  Components: Isis Viewer Wicket
Reporter: Andi Huber
Assignee: Andi Huber
 Fix For: 2.0.0-M4






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-2326) No-arg Action w/ Confirmation suppresses Tooltips.

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-2326.

Resolution: Fixed

fixed by switching Wicket Extensions Tooltip -> Popover

> No-arg Action w/ Confirmation suppresses Tooltips.
> --
>
> Key: ISIS-2326
> URL: https://issues.apache.org/jira/browse/ISIS-2326
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> No-arg Action button don't show their tooltips, when a confirmation dialog is 
> associated.
> Also Wicket's ConfirmationConfig allows for tooltips to be configured. These 
> don't show up neither.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2326) No-arg Action w/ Confirmation suppresses Tooltips.

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065861#comment-17065861
 ] 

ASF subversion and git services commented on ISIS-2326:
---

Commit 2cbf51afa49db3f4b155c332d49be77b959418d1 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2cbf51a ]

ISIS-2326: missing source selector in TupleDemo.adoc

> No-arg Action w/ Confirmation suppresses Tooltips.
> --
>
> Key: ISIS-2326
> URL: https://issues.apache.org/jira/browse/ISIS-2326
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> No-arg Action button don't show their tooltips, when a confirmation dialog is 
> associated.
> Also Wicket's ConfirmationConfig allows for tooltips to be configured. These 
> don't show up neither.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2326) No-arg Action w/ Confirmation suppresses Tooltips.

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065862#comment-17065862
 ] 

ASF subversion and git services commented on ISIS-2326:
---

Commit 1658bfd9ada31d7e1f3e3bc0df5aedb96b103c89 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1658bfd ]

ISIS-2326: typo in DemoHomePage.adoc

> No-arg Action w/ Confirmation suppresses Tooltips.
> --
>
> Key: ISIS-2326
> URL: https://issues.apache.org/jira/browse/ISIS-2326
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> No-arg Action button don't show their tooltips, when a confirmation dialog is 
> associated.
> Also Wicket's ConfirmationConfig allows for tooltips to be configured. These 
> don't show up neither.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2326) No-arg Action w/ Confirmation suppresses Tooltips.

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065863#comment-17065863
 ] 

ASF subversion and git services commented on ISIS-2326:
---

Commit f6ee594c66d0a864be22b70da2aa79053362ae37 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=f6ee594 ]

ISIS-2326: suppress tooltip behavior creation, when body is blank

> No-arg Action w/ Confirmation suppresses Tooltips.
> --
>
> Key: ISIS-2326
> URL: https://issues.apache.org/jira/browse/ISIS-2326
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> No-arg Action button don't show their tooltips, when a confirmation dialog is 
> associated.
> Also Wicket's ConfirmationConfig allows for tooltips to be configured. These 
> don't show up neither.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2326) No-arg Action w/ Confirmation suppresses Tooltips.

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065846#comment-17065846
 ] 

ASF subversion and git services commented on ISIS-2326:
---

Commit d340e740763b22a51df81413d52cda168160f73d in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=d340e74 ]

ISIS-2326: switch from Wicket Extensions Tooltip -> Popover

however, I guess we still have some workarounds in place regarding
tooltips, need to remove these

> No-arg Action w/ Confirmation suppresses Tooltips.
> --
>
> Key: ISIS-2326
> URL: https://issues.apache.org/jira/browse/ISIS-2326
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> No-arg Action button don't show their tooltips, when a confirmation dialog is 
> associated.
> Also Wicket's ConfirmationConfig allows for tooltips to be configured. These 
> don't show up neither.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2326) No-arg Action w/ Confirmation suppresses Tooltips.

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065845#comment-17065845
 ] 

ASF subversion and git services commented on ISIS-2326:
---

Commit 9cb02779d711e82ae64e0c29f1adb4ef522ed5cc in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=9cb0277 ]

ISIS-2326: fixes text dotted underline rendering for Chromium/Edge

> No-arg Action w/ Confirmation suppresses Tooltips.
> --
>
> Key: ISIS-2326
> URL: https://issues.apache.org/jira/browse/ISIS-2326
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> No-arg Action button don't show their tooltips, when a confirmation dialog is 
> associated.
> Also Wicket's ConfirmationConfig allows for tooltips to be configured. These 
> don't show up neither.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2326) No-arg Action w/ Confirmation suppresses Tooltips.

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber updated ISIS-2326:
-
Summary: No-arg Action w/ Confirmation suppresses Tooltips.  (was: No-arg 
Action w/ Confirmation supresses Tooltips.)

> No-arg Action w/ Confirmation suppresses Tooltips.
> --
>
> Key: ISIS-2326
> URL: https://issues.apache.org/jira/browse/ISIS-2326
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> No-arg Action button don't show their tooltips, when a confirmation dialog is 
> associated.
> Also Wicket's ConfirmationConfig allows for tooltips to be configured. These 
> don't show up neither.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ISIS-2326) No-arg Action w/ Confirmation supresses Tooltips.

2020-03-24 Thread Andi Huber (Jira)
Andi Huber created ISIS-2326:


 Summary: No-arg Action w/ Confirmation supresses Tooltips.
 Key: ISIS-2326
 URL: https://issues.apache.org/jira/browse/ISIS-2326
 Project: Isis
  Issue Type: Bug
  Components: Isis Viewer Wicket
Reporter: Andi Huber
Assignee: Andi Huber
 Fix For: 2.0.0-M4


No-arg Action button don't show their tooltips, when a confirmation dialog is 
associated.

Also Wicket's ConfirmationConfig allows for tooltips to be configured. These 
don't show up neither.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-1919) Collective UI Improvements

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-1919.

Resolution: Fixed

all subtasks fixed

> Collective UI Improvements
> --
>
> Key: ISIS-1919
> URL: https://issues.apache.org/jira/browse/ISIS-1919
> Project: Isis
>  Issue Type: Task
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> Main task to track various sub-tasks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-2093) Dialog OK Button: when ARE_YOU_SURE semantics then render style 'DANGER'

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-2093.

Resolution: Fixed

fixed

> Dialog OK Button: when ARE_YOU_SURE semantics then render style 'DANGER'
> 
>
> Key: ISIS-2093
> URL: https://issues.apache.org/jira/browse/ISIS-2093
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
> Attachments: confirm_no_danger.png
>
>
> To be consistent with other action buttons, that have an associated 
> are-you-sure confirmation dialog.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2093) Dialog OK Button: when ARE_YOU_SURE semantics then render style 'DANGER'

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065495#comment-17065495
 ] 

ASF subversion and git services commented on ISIS-2093:
---

Commit 026d1174d9e8166a830c72da90aa53027cb9e52e in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=026d117 ]

ISIS-2093: minor improvements to Tooltip Demo (button naming and text)

> Dialog OK Button: when ARE_YOU_SURE semantics then render style 'DANGER'
> 
>
> Key: ISIS-2093
> URL: https://issues.apache.org/jira/browse/ISIS-2093
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
> Attachments: confirm_no_danger.png
>
>
> To be consistent with other action buttons, that have an associated 
> are-you-sure confirmation dialog.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2093) Dialog OK Button: when ARE_YOU_SURE semantics then render style 'DANGER'

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065487#comment-17065487
 ] 

ASF subversion and git services commented on ISIS-2093:
---

Commit fc5b5c1d9286b4aaafb617f4585485e65cc1bb72 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=fc5b5c1 ]

ISIS-2093: fixes dialog ok button not receiving 'btn-danger' style

> Dialog OK Button: when ARE_YOU_SURE semantics then render style 'DANGER'
> 
>
> Key: ISIS-2093
> URL: https://issues.apache.org/jira/browse/ISIS-2093
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
> Attachments: confirm_no_danger.png
>
>
> To be consistent with other action buttons, that have an associated 
> are-you-sure confirmation dialog.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2093) Dialog OK Button: when ARE_YOU_SURE semantics then render style 'DANGER'

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065450#comment-17065450
 ] 

ASF subversion and git services commented on ISIS-2093:
---

Commit b1f2185c767ec936c39ab90cf6950a4b3d5e758a in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=b1f2185 ]

ISIS-2093: extends Tooltip Demo to show the issue

> Dialog OK Button: when ARE_YOU_SURE semantics then render style 'DANGER'
> 
>
> Key: ISIS-2093
> URL: https://issues.apache.org/jira/browse/ISIS-2093
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
> Attachments: confirm_no_danger.png
>
>
> To be consistent with other action buttons, that have an associated 
> are-you-sure confirmation dialog.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ISIS-2093) Dialog OK Button: when ARE_YOU_SURE semantics then render style 'DANGER'

2020-03-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ISIS-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065436#comment-17065436
 ] 

ASF subversion and git services commented on ISIS-2093:
---

Commit 05c610a8e3115ed73f29f5721a399b3b477fbd98 in isis's branch 
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=05c610a ]

ISIS-2093: bumping some Wicket extensions

wicket-bootstrap 2.0.11->2.0.12
wicket-bootstrap-core 2.0.11->2.0.12
wicket-bootstrap-datetimepicker 4.17.37-1->4.17.47
wicket-webjars 2.0.15->2.0.17

> Dialog OK Button: when ARE_YOU_SURE semantics then render style 'DANGER'
> 
>
> Key: ISIS-2093
> URL: https://issues.apache.org/jira/browse/ISIS-2093
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
> Attachments: confirm_no_danger.png
>
>
> To be consistent with other action buttons, that have an associated 
> are-you-sure confirmation dialog.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ISIS-2325) Allow Mixins to render additional Properties/Collections (but not Actions)

2020-03-24 Thread Andi Huber (Jira)
Andi Huber created ISIS-2325:


 Summary: Allow Mixins to render additional Properties/Collections 
(but not Actions)
 Key: ISIS-2325
 URL: https://issues.apache.org/jira/browse/ISIS-2325
 Project: Isis
  Issue Type: Improvement
  Components: Isis Viewer Wicket
Affects Versions: 2.0.0-M3
Reporter: Andi Huber
 Fix For: 2.0.0-M4


In support of providing additional context to the user when filling out an 
action's parameter(s) within a modal or sidebar dialog.

There are possibly other solutions to explore here. Eg. Is there a more general 
purpose way of rendering this kind of context specific support information?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-2323) Allow for IsisInteractions to store User Data (InteractionScoped)

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-2323.


> Allow for IsisInteractions to store User Data (InteractionScoped)
> -
>
> Key: ISIS-2323
> URL: https://issues.apache.org/jira/browse/ISIS-2323
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (ISIS-2320) Rename IsisSessionScope -> IsisInteractionScope

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber closed ISIS-2320.


> Rename IsisSessionScope -> IsisInteractionScope
> ---
>
> Key: ISIS-2320
> URL: https://issues.apache.org/jira/browse/ISIS-2320
> Project: Isis
>  Issue Type: Improvement
>  Components: Isis Core
>Affects Versions: 2.0.0-M3
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Minor
> Fix For: 2.0.0-M4
>
>
> and also rename IsisSessionFactory -> IsisInteractionFactory 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ISIS-2319) defaults/disable/hide not honored when pending args are preset with defaults

2020-03-24 Thread Andi Huber (Jira)


 [ 
https://issues.apache.org/jira/browse/ISIS-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andi Huber updated ISIS-2319:
-
Labels: on-hold  (was: )

> defaults/disable/hide not honored when pending args are preset with defaults
> 
>
> Key: ISIS-2319
> URL: https://issues.apache.org/jira/browse/ISIS-2319
> Project: Isis
>  Issue Type: Bug
>  Components: Isis Viewer Wicket
>Affects Versions: 2.0.0-M3
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
>  Labels: on-hold
> Fix For: 2.0.0-M4
>
>
> Action parameter 
> + visibility (hide) 
> + usability (disable) 
> + priming (defaults) 
> do not work when pending arguments are preset with a defaultNXxx() supporting 
> method. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)