[GitHub] [isis] andi-huber commented on pull request #1371: ISIS-3328: HTML Documentation Service based on the domain model
andi-huber commented on PR #1371: URL: https://github.com/apache/isis/pull/1371#issuecomment-1386461365 For now, let's keep this PR open for further discussion and ideas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@isis.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [isis] andi-huber merged pull request #1372: Bump vaadin.version from 23.3.3 to 23.3.4
andi-huber merged PR #1372: URL: https://github.com/apache/isis/pull/1372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@isis.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [isis] andi-huber commented on pull request #1371: ISIS-3328: HTML Documentation Service based on the domain model
andi-huber commented on PR #1371: URL: https://github.com/apache/isis/pull/1371#issuecomment-1386429923 While there is nothing wrong with the code, I don't think we'll merge it into the framework. Mainly because I think the docs created are suitable to provide a documentation blueprint, but in the general case, not enough to be presented to the end-user. This opinionated of course. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@isis.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [isis] dependabot[bot] opened a new pull request, #1372: Bump vaadin.version from 23.3.3 to 23.3.4
dependabot[bot] opened a new pull request, #1372: URL: https://github.com/apache/isis/pull/1372 Bumps `vaadin.version` from 23.3.3 to 23.3.4. Updates `vaadin-bom` from 23.3.3 to 23.3.4 Updates `vaadin-maven-plugin` from 23.3.3 to 23.3.4 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@isis.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (ISIS-3328) HTML Documentation Service based on the domain model
[ https://issues.apache.org/jira/browse/ISIS-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miroslav Holubec updated ISIS-3328: --- Description: We have created new documentation service which creates the HTML documentation based on the menu and the domain model. Very similar to the sitemap, but in HTML, so the end user can directly show it together with autogenerated description. I've migrated it into the latest version, I've just hasn't been able to test it. At least it worked fine in ISIS M7. Pull Request: https://github.com/apache/isis/pull/1371 was: We have created new documentation service which creates the HTML documentation based on the menu and the domain model. Very similar to the sitemap, but in HTML, so the end user can directly show it together with autogenerated description. I've migrated it into the latest version, I've just hasn't been able to test it. At least it worked fine in ISIS M7. I will post pull request asap. > HTML Documentation Service based on the domain model > > > Key: ISIS-3328 > URL: https://issues.apache.org/jira/browse/ISIS-3328 > Project: Isis > Issue Type: Improvement >Reporter: Miroslav Holubec >Priority: Major > > We have created new documentation service which creates the HTML > documentation based on the menu and the domain model. Very similar to the > sitemap, but in HTML, so the end user can directly show it together with > autogenerated description. > I've migrated it into the latest version, I've just hasn't been able to test > it. At least it worked fine in ISIS M7. > Pull Request: https://github.com/apache/isis/pull/1371 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [isis] myroch opened a new pull request, #1371: ISIS-3328: HTML Documentation Service based on the domain model
myroch opened a new pull request, #1371: URL: https://github.com/apache/isis/pull/1371 We have created new documentation service which creates the HTML documentation based on the menu and the domain model. Very similar to the sitemap, but in HTML, so the end user can directly show it together with autogenerated description. I've migrated it into the latest version, I've just hasn't been able to test it. At least it worked fine in ISIS M7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@isis.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (ISIS-3328) HTML Documentation Service based on the domain model
[ https://issues.apache.org/jira/browse/ISIS-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miroslav Holubec updated ISIS-3328: --- Summary: HTML Documentation Service based on the domain model (was: HTML Documentation based on the domain model) > HTML Documentation Service based on the domain model > > > Key: ISIS-3328 > URL: https://issues.apache.org/jira/browse/ISIS-3328 > Project: Isis > Issue Type: Improvement >Reporter: Miroslav Holubec >Priority: Major > > We have created new documentation service which creates the HTML > documentation based on the menu and the domain model. Very similar to the > sitemap, but in HTML, so the end user can directly show it together with > autogenerated description. > I've migrated it into the latest version, I've just hasn't been able to test > it. At least it worked fine in ISIS M7. > I will post pull request asap. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ISIS-3328) HTML Documentation based on the domain model
Miroslav Holubec created ISIS-3328: -- Summary: HTML Documentation based on the domain model Key: ISIS-3328 URL: https://issues.apache.org/jira/browse/ISIS-3328 Project: Isis Issue Type: Improvement Reporter: Miroslav Holubec We have created new documentation service which creates the HTML documentation based on the menu and the domain model. Very similar to the sitemap, but in HTML, so the end user can directly show it together with autogenerated description. I've migrated it into the latest version, I've just hasn't been able to test it. At least it worked fine in ISIS M7. I will post pull request asap. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3327) [Metamodel] Introspection Glitch when overriding Property Getters from Interfaces
[ https://issues.apache.org/jira/browse/ISIS-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677767#comment-17677767 ] ASF subversion and git services commented on ISIS-3327: --- Commit 181b2e4258474a4f200bd303b8bd4910e6462554 in isis's branch refs/heads/3327-mm-getter-glitch from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=181b2e4258 ] ISIS-3327: adds test case, but cannot reproduce issue > [Metamodel] Introspection Glitch when overriding Property Getters from > Interfaces > - > > Key: ISIS-3327 > URL: https://issues.apache.org/jira/browse/ISIS-3327 > Project: Isis > Issue Type: Bug > Components: Isis Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-RC1 > > > example is in the comments ... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3325) IsisToWicketTreeAdapter nodes result in "failed title" when collapsed/re-expanded.
[ https://issues.apache.org/jira/browse/ISIS-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677732#comment-17677732 ] Andi Huber commented on ISIS-3325: -- Attachment: If I modify our demo app's tree showcase, that is, have the FileNodeVm reference some arbitrary entity node (held by the property favoriteChild) and we then let the FileNodeVm's title be dependent on presence of its favoriteChild, we then do see issues with creating the correct title. > IsisToWicketTreeAdapter nodes result in "failed title" when > collapsed/re-expanded. > -- > > Key: ISIS-3325 > URL: https://issues.apache.org/jira/browse/ISIS-3325 > Project: Isis > Issue Type: Bug >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-RC1 > > Attachments: FileNodeVm.java > > > as per [https://the-asf.slack.com/archives/CFC42LWBV/p1673873138874239] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ISIS-3325) IsisToWicketTreeAdapter nodes result in "failed title" when collapsed/re-expanded.
[ https://issues.apache.org/jira/browse/ISIS-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andi Huber updated ISIS-3325: - Attachment: FileNodeVm.java > IsisToWicketTreeAdapter nodes result in "failed title" when > collapsed/re-expanded. > -- > > Key: ISIS-3325 > URL: https://issues.apache.org/jira/browse/ISIS-3325 > Project: Isis > Issue Type: Bug >Affects Versions: 2.0.0-M9 >Reporter: Daniel Keir Haywood >Assignee: Andi Huber >Priority: Major > Fix For: 2.0.0-RC1 > > Attachments: FileNodeVm.java > > > as per [https://the-asf.slack.com/archives/CFC42LWBV/p1673873138874239] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ISIS-3327) [Metamodel] Introspection Glitch when overriding Property Getters from Interfaces
[
https://issues.apache.org/jira/browse/ISIS-3327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677730#comment-17677730
]
Andi Huber commented on ISIS-3327:
--
{code:java}
@DomainObject(logicalTypeName = "xxx.TypeA", nature = Nature.VIEW_MODEL)
@DomainObjectLayout( cssClassFa="play" )
public class TypeA implements ITypeA {
@Property
@PropertyLayout(navigable = Navigable.PARENT, hidden =
Where.EVERYWHERE)
@Getter @Setter
private TypeB parent;
}
@DomainObject(logicalTypeName = "xxx.TypeB", nature = Nature.VIEW_MODEL)
@DomainObjectLayout( cssClassFa="play" )
public class TypeB implements ITypeB {
}
public interface ITypeA {
ITypeB getParent();
}
{code}
> [Metamodel] Introspection Glitch when overriding Property Getters from
> Interfaces
> -
>
> Key: ISIS-3327
> URL: https://issues.apache.org/jira/browse/ISIS-3327
> Project: Isis
> Issue Type: Bug
> Components: Isis Core
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-RC1
>
>
> example is in the comments ...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ISIS-3325) IsisToWicketTreeAdapter nodes result in "failed title" when collapsed/re-expanded.
[
https://issues.apache.org/jira/browse/ISIS-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677729#comment-17677729
]
Andi Huber commented on ISIS-3325:
--
{code:java}
@DomainObject(logicalTypeName = "xxx.TypeA", nature = Nature.VIEW_MODEL)
@DomainObjectLayout( cssClassFa="play" )
public class TypeA implements ITypeA {
@Property
@PropertyLayout(navigable = Navigable.PARENT, hidden =
Where.EVERYWHERE)
@Getter @Setter
private TypeB parent;
}
@DomainObject(logicalTypeName = "xxx.TypeB", nature = Nature.VIEW_MODEL)
@DomainObjectLayout( cssClassFa="play" )
public class TypeB implements ITypeB {
}
public interface ITypeA {
ITypeB getParent();
}
{code}
> IsisToWicketTreeAdapter nodes result in "failed title" when
> collapsed/re-expanded.
> --
>
> Key: ISIS-3325
> URL: https://issues.apache.org/jira/browse/ISIS-3325
> Project: Isis
> Issue Type: Bug
>Affects Versions: 2.0.0-M9
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-RC1
>
>
> as per [https://the-asf.slack.com/archives/CFC42LWBV/p1673873138874239]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (ISIS-3327) [Metamodel] Introspection Glitch when overriding Property Getters from Interfaces
Andi Huber created ISIS-3327: Summary: [Metamodel] Introspection Glitch when overriding Property Getters from Interfaces Key: ISIS-3327 URL: https://issues.apache.org/jira/browse/ISIS-3327 Project: Isis Issue Type: Bug Components: Isis Core Reporter: Andi Huber Assignee: Andi Huber Fix For: 2.0.0-RC1 example is in the comments ... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (ISIS-3325) IsisToWicketTreeAdapter nodes result in "failed title" when collapsed/re-expanded.
[ https://issues.apache.org/jira/browse/ISIS-3325 ]
Andi Huber deleted comment on ISIS-3325:
--
was (Author: hobrom):
{code:java}
@DomainObject(logicalTypeName = "xxx.TypeA", nature = Nature.VIEW_MODEL)
@DomainObjectLayout( cssClassFa="play" )
public class TypeA implements ITypeA {
@Property
@PropertyLayout(navigable = Navigable.PARENT, hidden =
Where.EVERYWHERE)
@Getter @Setter
private TypeB parent;
}
@DomainObject(logicalTypeName = "xxx.TypeB", nature = Nature.VIEW_MODEL)
@DomainObjectLayout( cssClassFa="play" )
public class TypeB implements ITypeB {
}
public interface ITypeA {
ITypeB getParent();
}
{code}
> IsisToWicketTreeAdapter nodes result in "failed title" when
> collapsed/re-expanded.
> --
>
> Key: ISIS-3325
> URL: https://issues.apache.org/jira/browse/ISIS-3325
> Project: Isis
> Issue Type: Bug
>Affects Versions: 2.0.0-M9
>Reporter: Daniel Keir Haywood
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-RC1
>
>
> as per [https://the-asf.slack.com/archives/CFC42LWBV/p1673873138874239]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
