[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types
[
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157215#comment-17157215
]
ASF subversion and git services commented on ISIS-2401:
---
Commit 3c960bd2e1f18195d39bd5f1b4159dddf8256a16 in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=3c960bd ]
ISIS-2401: ObjectSerializer: mitigate potential resource leaks (sonar)
> Memento creation/recreation roundtrip might get confused when processing
> Value Types
>
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
> at
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
> ~[classes/:?]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types
[
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157183#comment-17157183
]
ASF subversion and git services commented on ISIS-2401:
---
Commit 1b11734cb6c0437cf97a7e541cfb9015c81538e4 in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=1b11734 ]
ISIS-2401: revert previous commit
> Memento creation/recreation roundtrip might get confused when processing
> Value Types
>
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
> at
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
> ~[classes/:?]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types
[
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157182#comment-17157182
]
ASF subversion and git services commented on ISIS-2401:
---
Commit c67392ee724e5eed24256471033c218a69268700 in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=c67392e ]
ISIS-2401: wkt: also create mementos for 'free' collections
> Memento creation/recreation roundtrip might get confused when processing
> Value Types
>
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
> at
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
> ~[classes/:?]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types
[
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157010#comment-17157010
]
ASF subversion and git services commented on ISIS-2401:
---
Commit 2101531507b8f744875ba3091b17854470f624da in isis's branch
refs/heads/ISIS- from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2101531 ]
ISIS-2401: fix regression: create mementos for paranted coll. as well
> Memento creation/recreation roundtrip might get confused when processing
> Value Types
>
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
> at
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
> ~[classes/:?]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types
[
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156724#comment-17156724
]
ASF subversion and git services commented on ISIS-2401:
---
Commit 2101531507b8f744875ba3091b17854470f624da in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2101531 ]
ISIS-2401: fix regression: create mementos for paranted coll. as well
> Memento creation/recreation roundtrip might get confused when processing
> Value Types
>
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
> at
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
> ~[classes/:?]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types
[
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156702#comment-17156702
]
ASF subversion and git services commented on ISIS-2401:
---
Commit 564ba58a57675c35cee2da52e4b43646b15e3e45 in isis's branch
refs/heads/ISIS- from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=564ba58 ]
ISIS-2401: wkt: properly select type marshalling strategy based on
object's spec
adds a plain old java serialization fallback strategy,
to be used if all the others fail
also fail early with some usable info, if strategy selection goes wrong
> Memento creation/recreation roundtrip might get confused when processing
> Value Types
>
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
> at
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
> ~[classes/:?]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types
[
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156704#comment-17156704
]
ASF subversion and git services commented on ISIS-2401:
---
Commit 2528994e9466fa68897c5df262198f0d9eeea4e9 in isis's branch
refs/heads/ISIS- from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2528994 ]
ISIS-2401: polishing new ObjectSerializer
> Memento creation/recreation roundtrip might get confused when processing
> Value Types
>
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
> at
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
> ~[classes/:?]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types
[
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156703#comment-17156703
]
ASF subversion and git services commented on ISIS-2401:
---
Commit 0ef5caae0fcc836b0ba855dcbe574586f6bf52d8 in isis's branch
refs/heads/ISIS- from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0ef5caa ]
ISIS-2401: lombok build issue: don't use val in enum bodys
> Memento creation/recreation roundtrip might get confused when processing
> Value Types
>
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
> at
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
> ~[classes/:?]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types
[
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156203#comment-17156203
]
ASF subversion and git services commented on ISIS-2401:
---
Commit 2528994e9466fa68897c5df262198f0d9eeea4e9 in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=2528994 ]
ISIS-2401: polishing new ObjectSerializer
> Memento creation/recreation roundtrip might get confused when processing
> Value Types
>
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
> at
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
> ~[classes/:?]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types
[
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156123#comment-17156123
]
ASF subversion and git services commented on ISIS-2401:
---
Commit 0ef5caae0fcc836b0ba855dcbe574586f6bf52d8 in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=0ef5caa ]
ISIS-2401: lombok build issue: don't use val in enum bodys
> Memento creation/recreation roundtrip might get confused when processing
> Value Types
>
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
> at
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
> ~[classes/:?]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ISIS-2401) Memento creation/recreation roundtrip might get confused when processing Value Types
[
https://issues.apache.org/jira/browse/ISIS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156119#comment-17156119
]
ASF subversion and git services commented on ISIS-2401:
---
Commit 564ba58a57675c35cee2da52e4b43646b15e3e45 in isis's branch
refs/heads/master from Andi Huber
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=564ba58 ]
ISIS-2401: wkt: properly select type marshalling strategy based on
object's spec
adds a plain old java serialization fallback strategy,
to be used if all the others fail
also fail early with some usable info, if strategy selection goes wrong
> Memento creation/recreation roundtrip might get confused when processing
> Value Types
>
>
> Key: ISIS-2401
> URL: https://issues.apache.org/jira/browse/ISIS-2401
> Project: Isis
> Issue Type: Bug
> Components: Isis Viewer Wicket
>Reporter: Andi Huber
>Assignee: Andi Huber
>Priority: Major
> Fix For: 2.0.0-M4
>
>
> Seeing this when running vaadin and wkt viewer simultaneous. Wkt throws ...
> {noformat}
> Caused by: java.lang.IllegalArgumentException: need an id to lookup an object
> specId=org.apache.isis.valuetypes.asciidoc.applib.value.AsciiDoc
> at
> org.apache.isis.core.commons.internal.exceptions._Exceptions.illegalArgument(_Exceptions.java:80)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$RecreateStrategy$2.recreateObject(ObjectMementoLegacy.java:221)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy$Cardinality$1.asAdapter(ObjectMementoLegacy.java:85)
> ~[classes/:?]
> at
> org.apache.isis.viewer.wicket.viewer.services.mementos.ObjectMementoLegacy.reconstructObject(ObjectMementoLegacy.java:449)
> ~[classes/:?]{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
