[jira] [Commented] (ISIS-959) Update Jackson dependency from 1.9.11 to 2.4.3
[ https://issues.apache.org/jira/browse/ISIS-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385811#comment-14385811 ] ASF subversion and git services commented on ISIS-959: -- Commit c01e3db0f33a6290333bea5f923e8dbc80920e0f in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=c01e3db ] ISIS-1126: merging commit '03d5e0a07a13629b4ed6a57441099257c72d1d58' from https://github.com/niv0/isis, as per ... ... as per https://github.com/apache/isis/pull/17 and the earlier comments in ISIS-959. Update Jackson dependency from 1.9.11 to 2.4.3 -- Key: ISIS-959 URL: https://issues.apache.org/jira/browse/ISIS-959 Project: Isis Issue Type: Task Components: Core: Viewer: RestfulObjects Affects Versions: core-1.7.0 Reporter: Martin Grigorov Priority: Minor Fix For: core-1.8.0 Attachments: ISIS-959.patch See http://markmail.org/message/lc37rxwrowzqtzdh and https://github.com/apache/isis/pull/8 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-959) Update Jackson dependency from 1.9.11 to 2.4.3
[ https://issues.apache.org/jira/browse/ISIS-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259481#comment-14259481 ] Vladimir Nisevic commented on ISIS-959: --- Hi Dan, this is my pull request https://github.com/apache/isis/pull/17 Update Jackson dependency from 1.9.11 to 2.4.3 -- Key: ISIS-959 URL: https://issues.apache.org/jira/browse/ISIS-959 Project: Isis Issue Type: Task Components: Core: Viewer: RestfulObjects Affects Versions: core-1.7.0 Reporter: Martin Grigorov Assignee: Dan Haywood Priority: Minor Fix For: core-1.8.0 Attachments: ISIS-959.patch See http://markmail.org/message/lc37rxwrowzqtzdh and https://github.com/apache/isis/pull/8 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-959) Update Jackson dependency from 1.9.11 to 2.4.3
[ https://issues.apache.org/jira/browse/ISIS-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235762#comment-14235762 ] ASF subversion and git services commented on ISIS-959: -- Commit 7af85652c023a3e30cd50ba7dd1b6b25d6df9e3b in isis's branch refs/heads/master from [~mgrigorov] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=7af8565 ] ISIS-959 Define explicit dependency on jackson-annotations because otherwise an old version of it may be picked Kitchensink app used jackson-annotations:2.0.5 due to transitive dependency via wickedcharts. Additionally update Jackson to 2.4.4 Update Jackson dependency from 1.9.11 to 2.4.3 -- Key: ISIS-959 URL: https://issues.apache.org/jira/browse/ISIS-959 Project: Isis Issue Type: Task Components: Core: Viewer: RestfulObjects Affects Versions: core-1.7.0 Reporter: Martin Grigorov Assignee: Dan Haywood Priority: Minor Fix For: core-1.8.0 Attachments: ISIS-959.patch See http://markmail.org/message/lc37rxwrowzqtzdh and https://github.com/apache/isis/pull/8 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-959) Update Jackson dependency from 1.9.11 to 2.4.3
[ https://issues.apache.org/jira/browse/ISIS-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234214#comment-14234214 ] Vladimir Nisevic commented on ISIS-959: --- Hi Dan, in my contribution I tried to use (kind of symmetric) custom serializer/deserializer and registered them both when constructing object mapper. So I could remove some of your code, just check my contribution in the class JsonMapper.. Regs,Vladimir Update Jackson dependency from 1.9.11 to 2.4.3 -- Key: ISIS-959 URL: https://issues.apache.org/jira/browse/ISIS-959 Project: Isis Issue Type: Task Components: Core: Viewer: RestfulObjects Affects Versions: core-1.7.0 Reporter: Martin Grigorov Assignee: Dan Haywood Priority: Minor Fix For: core-1.8.0 Attachments: ISIS-959.patch See http://markmail.org/message/lc37rxwrowzqtzdh and https://github.com/apache/isis/pull/8 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-959) Update Jackson dependency from 1.9.11 to 2.4.3
[ https://issues.apache.org/jira/browse/ISIS-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230729#comment-14230729 ] Dan Haywood commented on ISIS-959: -- I've applied Martin's PR. Vladimir, thanks for doing the patch, but as Martin says, it's easier for us to apply if you create a pull request from a fork on github. If you don't want to do that, then take care with the whitespace so that the differences can be easier reviewed. With respect t the change you've made in JsonMapper, what's the rationale behind your changes are they taking advantage of new API in 2.4.3, or some other reason? Thx Dan Update Jackson dependency from 1.9.11 to 2.4.3 -- Key: ISIS-959 URL: https://issues.apache.org/jira/browse/ISIS-959 Project: Isis Issue Type: Task Components: Core: Viewer: RestfulObjects Affects Versions: core-1.7.0 Reporter: Martin Grigorov Assignee: Dan Haywood Priority: Minor Fix For: core-1.8.0 Attachments: ISIS-959.patch See http://markmail.org/message/lc37rxwrowzqtzdh and https://github.com/apache/isis/pull/8 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-959) Update Jackson dependency from 1.9.11 to 2.4.3
[ https://issues.apache.org/jira/browse/ISIS-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226172#comment-14226172 ] Martin Grigorov commented on ISIS-959: -- The patch is not really usable in its current state. Because of the whitespace differences it looks like you re-wrote the complete source of the affected files. https://github.com/apache/isis/pull/8/files looks better, no ? ;-) Update Jackson dependency from 1.9.11 to 2.4.3 -- Key: ISIS-959 URL: https://issues.apache.org/jira/browse/ISIS-959 Project: Isis Issue Type: Task Components: Core: Viewer: RestfulObjects Affects Versions: core-1.7.0 Reporter: Martin Grigorov Assignee: Dan Haywood Priority: Minor Attachments: ISIS-959.patch See http://markmail.org/message/lc37rxwrowzqtzdh and https://github.com/apache/isis/pull/8 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-959) Update Jackson dependency from 1.9.11 to 2.4.3
[ https://issues.apache.org/jira/browse/ISIS-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226199#comment-14226199 ] Vladimir Nisevic commented on ISIS-959: --- Hi Martin, if I correct understand, you did the work also? Would be great if I would know it in advance. Regards,Vladimir Update Jackson dependency from 1.9.11 to 2.4.3 -- Key: ISIS-959 URL: https://issues.apache.org/jira/browse/ISIS-959 Project: Isis Issue Type: Task Components: Core: Viewer: RestfulObjects Affects Versions: core-1.7.0 Reporter: Martin Grigorov Assignee: Dan Haywood Priority: Minor Attachments: ISIS-959.patch See http://markmail.org/message/lc37rxwrowzqtzdh and https://github.com/apache/isis/pull/8 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-959) Update Jackson dependency from 1.9.11 to 2.4.3
[ https://issues.apache.org/jira/browse/ISIS-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226202#comment-14226202 ] Martin Grigorov commented on ISIS-959: -- Sorry! I've missed somehow the notification for your first comment. The link to my pull request was in the description since the creation of this ticket. Update Jackson dependency from 1.9.11 to 2.4.3 -- Key: ISIS-959 URL: https://issues.apache.org/jira/browse/ISIS-959 Project: Isis Issue Type: Task Components: Core: Viewer: RestfulObjects Affects Versions: core-1.7.0 Reporter: Martin Grigorov Assignee: Dan Haywood Priority: Minor Attachments: ISIS-959.patch See http://markmail.org/message/lc37rxwrowzqtzdh and https://github.com/apache/isis/pull/8 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-959) Update Jackson dependency from 1.9.11 to 2.4.3
[ https://issues.apache.org/jira/browse/ISIS-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226203#comment-14226203 ] Vladimir Nisevic commented on ISIS-959: --- Hi again, I've also made a bit larger adaptations in JsonMapper than you. https://github.com/martin-g/isis/blob/24320d86f4362df552b237d6ba33947e5c734db4/core/viewer-restfulobjects-applib/src/main/java/org/apache/isis/viewer/restfulobjects/applib/util/JsonMapper.java maybe you look to that part in my contribution if makes sense... Regs,Vladimir Update Jackson dependency from 1.9.11 to 2.4.3 -- Key: ISIS-959 URL: https://issues.apache.org/jira/browse/ISIS-959 Project: Isis Issue Type: Task Components: Core: Viewer: RestfulObjects Affects Versions: core-1.7.0 Reporter: Martin Grigorov Assignee: Dan Haywood Priority: Minor Attachments: ISIS-959.patch See http://markmail.org/message/lc37rxwrowzqtzdh and https://github.com/apache/isis/pull/8 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-959) Update Jackson dependency from 1.9.11 to 2.4.3
[ https://issues.apache.org/jira/browse/ISIS-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222387#comment-14222387 ] Vladimir Nisevic commented on ISIS-959: --- Hi, I planned to give it a try and to do this task and provide you eclipse worskpace patch? Ok to do so? Regs,Vladimir Update Jackson dependency from 1.9.11 to 2.4.3 -- Key: ISIS-959 URL: https://issues.apache.org/jira/browse/ISIS-959 Project: Isis Issue Type: Task Components: Core: Viewer: RestfulObjects Affects Versions: core-1.7.0 Reporter: Martin Grigorov Assignee: Dan Haywood Priority: Minor See http://markmail.org/message/lc37rxwrowzqtzdh and https://github.com/apache/isis/pull/8 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
