Re: CI environment

2019-08-20 Thread Konrad Windszus
Hi,
Instead of configuring it manually I would prefer using Jenkinsfiles for it. Do 
you have any good example at hand or are all other Jackrabbit Jenkins Jobs 
manually configured?
Usually one uses a Shared Library for setting the jobs up (e.g. compare with 
https://github.com/apache/sling-tooling-jenkins 
)
Also who is currently Jenkins admin 
(https://cwiki.apache.org/confluence/display/INFRA/Jenkins#Jenkins-HowdoIgetanaccount
 
)?

Can you grant me the according rights or set up Jobs for 
http://svn.apache.org/repos/asf/jackrabbit/commons/filevault/ 
 and 
http://svn.apache.org/repos/asf/jackrabbit/commons/filevault-package-maven-plugin/?
 

Both should be built with Java 7, 8, and 11 both on Windows and Linux.
Thanks in advance,
Konrad

> On 20. Aug 2019, at 15:58, Marcel Reutegger  wrote:
> 
> Hi,
> 
> Travis is nice because it integrates well with GitHub, but there were issues
> in the past with notification emails sent to the list by travis. It required
> constant moderation. It looks like this has just very recently been fixed.
> What a coincidence :)
> 
> https://issues.apache.org/jira/browse/INFRA-18843
> 
> I'd say use the Apache infrastructure if possible, but if travis better fits
> your requirements, then it's fine as well.
> 
> Regards
> Marcel
> 
> On 20.08.19, 13:48, "Konrad Windszus"  wrote:
>According to 
> https://lists.apache.org/thread.html/523a8dbfbf6fa4cef6d98c5e25770a9f8e8525de3781516d031c068a@%3Cprivate.infra.apache.org%3E
>  
> 
>  it
> seems wise nowadays to primarily rely on Travis to also enable builds on 
> PRs.
>WDYT?
> 
> 
>On 20. Aug 2019, at 13:42, Konrad Windszus  wrote:
> 
>Hi,
>the information at 
>https://jackrabbit.apache.org/jcr/continuous-integration.html 
>  seems pretty 
> outdated.
>On the ASF Jenkins I could not find too many CI jobs either (some related 
> to Oak,
>https://builds.apache.org/view/AllJobs/).
> 
>I would like to set up Jobs for Jackrabbit Filevault and Jackrabbit 
> Filevault Maven Plugin. The latter requires also a Windows build job (we 
> faced several Windows only issues in the past).
>Also it would be nice to have a dedicated view in Jenkins for Apache 
> Jackrabbit which contains all Jobs for Oak, Jackrabbit and Filevault.
>Is there any reference documentation around the set up of CI jobs at 
> Jackrabbit?
>Also I could not find any Jenkinsfile anywhere so I guess the Jenkins Jobs 
> are currently maintained manually?
>Or should I instead rather use Travis?
> 
>Thanks for your input.
>Konrad
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 



[jira] [Commented] (JCR-4468) Update CI page

2019-08-20 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/JCR-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911403#comment-16911403
 ] 

Julian Reschke commented on JCR-4468:
-

See also https://issues.apache.org/jira/browse/OAK-8325

> Update CI page
> --
>
> Key: JCR-4468
> URL: https://issues.apache.org/jira/browse/JCR-4468
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: docs
>Reporter: Konrad Windszus
>Priority: Major
>
> The page at https://jackrabbit.apache.org/jcr/continuous-integration.html is 
> pretty outdated. It should be updated and link to all CI jobs of Jackrabbit 
> (including Oak), potentially towards the ASF Jenkins and also to Travis CI 
> where applicable.
> Compare with this discussion: 
> https://lists.apache.org/thread.html/89de8be21f993c013c4be6914e28fc21473e9dbe1056ccf90c692bab@%3Cdev.jackrabbit.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


Re: CI environment

2019-08-20 Thread Konrad Windszus
Thanks for the answer. I opened issue 
https://issues.apache.org/jira/browse/JCR-4468 
 to track that.
Konrad

> On 20. Aug 2019, at 15:42, Marcel Reutegger  wrote:
> 
> Hi,
> 
> That page is indeed outdated. Do you mind creating an issue for this?
> I think this should be fixed.
> 
> I'm aware of:
> - https://builds.apache.org/job/Jackrabbit-trunk/
> - https://builds.apache.org/job/Apache%20Jackrabbit%20matrix/ (disabled ~2 
> years ago)
> 
> Regards
> Marcel
> 
> On 20.08.19, 13:43, "Konrad Windszus"  wrote:
> 
>Hi,
>the information at 
> https://jackrabbit.apache.org/jcr/continuous-integration.html seems pretty 
> outdated.
>On the ASF Jenkins I could not find too many CI jobs either (some related 
> to Oak, https://builds.apache.org/view/AllJobs/).
> 
>I would like to set up Jobs for Jackrabbit Filevault and Jackrabbit 
> Filevault Maven Plugin. The latter requires also a Windows build job (we 
> faced several Windows only issues in the past).
>Also it would be nice to have a dedicated view in Jenkins for Apache 
> Jackrabbit which contains all Jobs for Oak, Jackrabbit and Filevault.
>Is there any reference documentation around the set up of CI jobs at 
> Jackrabbit?
>Also I could not find any Jenkinsfile anywhere so I guess the Jenkins Jobs 
> are currently maintained manually?
>Or should I instead rather use Travis?
> 
>Thanks for your input.
>Konrad
> 
> 
> 
> 



[jira] [Created] (JCR-4468) Update CI page

2019-08-20 Thread Konrad Windszus (Jira)
Konrad Windszus created JCR-4468:


 Summary: Update CI page
 Key: JCR-4468
 URL: https://issues.apache.org/jira/browse/JCR-4468
 Project: Jackrabbit Content Repository
  Issue Type: Improvement
  Components: docs
Reporter: Konrad Windszus


The page at https://jackrabbit.apache.org/jcr/continuous-integration.html is 
pretty outdated. It should be updated and link to all CI jobs of Jackrabbit 
(including Oak), potentially towards the ASF Jenkins and also to Travis CI 
where applicable.

Compare with this discussion: 
https://lists.apache.org/thread.html/89de8be21f993c013c4be6914e28fc21473e9dbe1056ccf90c692bab@%3Cdev.jackrabbit.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


Re: CI environment

2019-08-20 Thread Marcel Reutegger
Hi,

Travis is nice because it integrates well with GitHub, but there were issues
in the past with notification emails sent to the list by travis. It required
constant moderation. It looks like this has just very recently been fixed.
What a coincidence :)

https://issues.apache.org/jira/browse/INFRA-18843

I'd say use the Apache infrastructure if possible, but if travis better fits
your requirements, then it's fine as well.

Regards
 Marcel

On 20.08.19, 13:48, "Konrad Windszus"  wrote:
According to 
https://lists.apache.org/thread.html/523a8dbfbf6fa4cef6d98c5e25770a9f8e8525de3781516d031c068a@%3Cprivate.infra.apache.org%3E
 

 it
 seems wise nowadays to primarily rely on Travis to also enable builds on 
PRs.
WDYT?


On 20. Aug 2019, at 13:42, Konrad Windszus  wrote:

Hi,
the information at 
https://jackrabbit.apache.org/jcr/continuous-integration.html 
 seems pretty 
outdated.
On the ASF Jenkins I could not find too many CI jobs either (some related 
to Oak,
https://builds.apache.org/view/AllJobs/).

I would like to set up Jobs for Jackrabbit Filevault and Jackrabbit 
Filevault Maven Plugin. The latter requires also a Windows build job (we faced 
several Windows only issues in the past).
Also it would be nice to have a dedicated view in Jenkins for Apache 
Jackrabbit which contains all Jobs for Oak, Jackrabbit and Filevault.
Is there any reference documentation around the set up of CI jobs at 
Jackrabbit?
Also I could not find any Jenkinsfile anywhere so I guess the Jenkins Jobs 
are currently maintained manually?
Or should I instead rather use Travis?

Thanks for your input.
Konrad













[jira] [Updated] (JCR-4467) Remove all usage of java.security.acl.Group for Java 14

2019-08-20 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/JCR-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated JCR-4467:

Attachment: JCR-4467.diff
  Assignee: Julian Reschke
Status: Patch Available  (was: Open)

> Remove all usage of java.security.acl.Group for Java 14
> ---
>
> Key: JCR-4467
> URL: https://issues.apache.org/jira/browse/JCR-4467
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Attachments: JCR-4467.diff
>
>
> Followup of OAK-7024 for the actual removal of the Group class from the 
> codebase to be java 14 compliant.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (JCR-4467) Remove all usage of java.security.acl.Group for Java 14

2019-08-20 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/JCR-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated JCR-4467:

Fix Version/s: 2.20

> Remove all usage of java.security.acl.Group for Java 14
> ---
>
> Key: JCR-4467
> URL: https://issues.apache.org/jira/browse/JCR-4467
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 2.20
>
> Attachments: JCR-4467.diff
>
>
> Followup of OAK-7024 for the actual removal of the Group class from the 
> codebase to be java 14 compliant.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


Re: CI environment

2019-08-20 Thread Marcel Reutegger
Hi,

That page is indeed outdated. Do you mind creating an issue for this?
I think this should be fixed.

I'm aware of:
- https://builds.apache.org/job/Jackrabbit-trunk/
- https://builds.apache.org/job/Apache%20Jackrabbit%20matrix/ (disabled ~2 
years ago)

Regards
 Marcel

On 20.08.19, 13:43, "Konrad Windszus"  wrote:

Hi,
the information at 
https://jackrabbit.apache.org/jcr/continuous-integration.html seems pretty 
outdated.
On the ASF Jenkins I could not find too many CI jobs either (some related 
to Oak, https://builds.apache.org/view/AllJobs/).

I would like to set up Jobs for Jackrabbit Filevault and Jackrabbit 
Filevault Maven Plugin. The latter requires also a Windows build job (we faced 
several Windows only issues in the past).
Also it would be nice to have a dedicated view in Jenkins for Apache 
Jackrabbit which contains all Jobs for Oak, Jackrabbit and Filevault.
Is there any reference documentation around the set up of CI jobs at 
Jackrabbit?
Also I could not find any Jenkinsfile anywhere so I guess the Jenkins Jobs 
are currently maintained manually?
Or should I instead rather use Travis?

Thanks for your input.
Konrad






[jira] [Created] (JCR-4467) Remove all usage of java.security.acl.Group for Java 14

2019-08-20 Thread Julian Reschke (Jira)
Julian Reschke created JCR-4467:
---

 Summary: Remove all usage of java.security.acl.Group for Java 14
 Key: JCR-4467
 URL: https://issues.apache.org/jira/browse/JCR-4467
 Project: Jackrabbit Content Repository
  Issue Type: Improvement
Reporter: Julian Reschke


Followup of OAK-7024 for the actual removal of the Group class from the 
codebase to be java 14 compliant.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (JCR-4466) Jackrabbit should compile & test with JDK 14

2019-08-20 Thread Julian Reschke (Jira)
Julian Reschke created JCR-4466:
---

 Summary: Jackrabbit should compile & test with JDK 14
 Key: JCR-4466
 URL: https://issues.apache.org/jira/browse/JCR-4466
 Project: Jackrabbit Content Repository
  Issue Type: Bug
Reporter: Julian Reschke
Assignee: Julian Reschke






--
This message was sent by Atlassian Jira
(v8.3.2#803003)


Re: CI environment

2019-08-20 Thread Konrad Windszus
According to 
https://lists.apache.org/thread.html/523a8dbfbf6fa4cef6d98c5e25770a9f8e8525de3781516d031c068a@%3Cprivate.infra.apache.org%3E
 

 it seems wise nowadays to primarily rely on Travis to also enable builds on 
PRs.
WDYT?

> On 20. Aug 2019, at 13:42, Konrad Windszus  wrote:
> 
> Hi,
> the information at 
> https://jackrabbit.apache.org/jcr/continuous-integration.html seems pretty 
> outdated.
> On the ASF Jenkins I could not find too many CI jobs either (some related to 
> Oak, https://builds.apache.org/view/AllJobs/).
> 
> I would like to set up Jobs for Jackrabbit Filevault and Jackrabbit Filevault 
> Maven Plugin. The latter requires also a Windows build job (we faced several 
> Windows only issues in the past).
> Also it would be nice to have a dedicated view in Jenkins for Apache 
> Jackrabbit which contains all Jobs for Oak, Jackrabbit and Filevault.
> Is there any reference documentation around the set up of CI jobs at 
> Jackrabbit?
> Also I could not find any Jenkinsfile anywhere so I guess the Jenkins Jobs 
> are currently maintained manually?
> Or should I instead rather use Travis?
> 
> Thanks for your input.
> Konrad
> 
> 



CI environment

2019-08-20 Thread Konrad Windszus
Hi,
the information at 
https://jackrabbit.apache.org/jcr/continuous-integration.html seems pretty 
outdated.
On the ASF Jenkins I could not find too many CI jobs either (some related to 
Oak, https://builds.apache.org/view/AllJobs/).

I would like to set up Jobs for Jackrabbit Filevault and Jackrabbit Filevault 
Maven Plugin. The latter requires also a Windows build job (we faced several 
Windows only issues in the past).
Also it would be nice to have a dedicated view in Jenkins for Apache Jackrabbit 
which contains all Jobs for Oak, Jackrabbit and Filevault.
Is there any reference documentation around the set up of CI jobs at Jackrabbit?
Also I could not find any Jenkinsfile anywhere so I guess the Jenkins Jobs are 
currently maintained manually?
Or should I instead rather use Travis?

Thanks for your input.
Konrad




Jackrabbit 2.19.4 Release Plan

2019-08-20 Thread Julian Reschke

Hi,

I'd like to cut Jackrabbit 2.19.4 tomorrow.

The list of open issues scheduled for 2.19.4 is empty:

https://issues.apache.org/jira/issues/?jql=fixVersion%20%3D%202.19.4%20AND%20project%20%3D%20JCR%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC

The candidate release notes are here:

https://svn.apache.org/repos/asf/jackrabbit/trunk/RELEASE-NOTES.txt

If there are any objections please let me know.

Best regards, Julian


[jira] [Created] (JCR-4465) Release Jackrabbit 2.19.4

2019-08-20 Thread Julian Reschke (Jira)
Julian Reschke created JCR-4465:
---

 Summary: Release Jackrabbit 2.19.4
 Key: JCR-4465
 URL: https://issues.apache.org/jira/browse/JCR-4465
 Project: Jackrabbit Content Repository
  Issue Type: Task
Reporter: Julian Reschke
Assignee: Julian Reschke






--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Resolved] (JCR-4464) Update Tika dependency to 1.22

2019-08-20 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/JCR-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved JCR-4464.
-
Fix Version/s: 2.19.4
   2.20
   Resolution: Fixed

> Update Tika dependency to 1.22
> --
>
> Key: JCR-4464
> URL: https://issues.apache.org/jira/browse/JCR-4464
> Project: Jackrabbit Content Repository
>  Issue Type: Task
>  Components: parent
>Affects Versions: 2.20
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 2.20, 2.19.4
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (JCR-4464) Update Tika dependency to 1.22

2019-08-20 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/JCR-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911213#comment-16911213
 ] 

Julian Reschke commented on JCR-4464:
-

trunk: [r1865525|http://svn.apache.org/r1865525]

> Update Tika dependency to 1.22
> --
>
> Key: JCR-4464
> URL: https://issues.apache.org/jira/browse/JCR-4464
> Project: Jackrabbit Content Repository
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_jcr_2_18
> Fix For: 2.20, 2.19.4
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (JCR-4464) Update Tika dependency to 1.22

2019-08-20 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/JCR-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated JCR-4464:

Affects Version/s: (was: 2.20)

> Update Tika dependency to 1.22
> --
>
> Key: JCR-4464
> URL: https://issues.apache.org/jira/browse/JCR-4464
> Project: Jackrabbit Content Repository
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 2.20, 2.19.4
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (JCR-4464) Update Tika dependency to 1.22

2019-08-20 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/JCR-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated JCR-4464:

Labels: candidate_jcr_2_18  (was: )

> Update Tika dependency to 1.22
> --
>
> Key: JCR-4464
> URL: https://issues.apache.org/jira/browse/JCR-4464
> Project: Jackrabbit Content Repository
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_jcr_2_18
> Fix For: 2.20, 2.19.4
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (JCR-4464) Update Tika dependency to 1.22

2019-08-20 Thread Julian Reschke (Jira)
Julian Reschke created JCR-4464:
---

 Summary: Update Tika dependency to 1.22
 Key: JCR-4464
 URL: https://issues.apache.org/jira/browse/JCR-4464
 Project: Jackrabbit Content Repository
  Issue Type: Task
  Components: parent
Affects Versions: 2.20
Reporter: Julian Reschke
Assignee: Julian Reschke






--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (JCR-4458) When JcrRemotingServlet deployed on non-root context, AclResource Webdav request fails

2019-08-20 Thread Woonsan Ko (Jira)


[ 
https://issues.apache.org/jira/browse/JCR-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911192#comment-16911192
 ] 

Woonsan Ko commented on JCR-4458:
-

Hi [~julian.resc...@gmx.de] ,
No objection. :-) Please go ahead.
Best, Woonsan

> When JcrRemotingServlet deployed on non-root context, AclResource Webdav 
> request fails
> --
>
> Key: JCR-4458
> URL: https://issues.apache.org/jira/browse/JCR-4458
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>Affects Versions: 2.18.2
>Reporter: Woonsan Ko
>Assignee: Julian Reschke
>Priority: Major
>
> If {{org.apache.jackrabbit.server.remoting.davex.JcrRemotingServlet}} is 
> configured in a non-root web application, the contextPath of which is "/cms" 
> for example with the servletPath, "/server", then 
> {{javax.jcr.Session#importXML(...)}} fails from a JCR client based on 
> JCR/WebDAV. In other words, {{#importXML(...)}} fails from a JCR {{Session}} 
> using a repository which can be created like the following for JCR over 
> WebDAV:
> {code}
> String repositoryAddress = "http://localhost:8080/cms/server;;
> Jcr2davRepositoryFactory factory = new Jcr2davRepositoryFactory();
> Map params = new HashMap();
> params.put(JcrUtils.REPOSITORY_URI, repositoryAddress);
> Repository repository = factory.getRepository(params);
> // ...
> {code}
> It seems like that {{Session#importXML(...)}} call invokes an AclResource 
> Webdav request first on the specific resource path, but 
> {{org.apache.jackrabbit.webdav.jcr.version.report.JcrPrivilegeReport#init(DavResource,
>  ReportInfo)}} does not remove the contextPath, "/cms" for example, when 
> determining the resoucrePath.
> Unlike the {{JcrPrivilegeReport}}, 
> {{org.apache.jackrabbit.webdav.WebdavRequestImpl#getHrefLocator(String, 
> boolean)}} seems to remove the contextPath properly.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


Intent to backport OAK-8066 to 1.8 and 1.10

2019-08-20 Thread Francesco Mari
I intend to backport OAK-8066 to 1.8 and 1.10. The change prevents
excessive memory consumption, which can lead to OOME, when rebasing a node
with many children.

The backport is tracked by OAK-8559. I couldn't reopen the original issue,
so I created a new one to clearly signal that I want this change to be part
of the next releases on the 1.8 and 1.10 branches.


[jira] [Commented] (JCR-4458) When JcrRemotingServlet deployed on non-root context, AclResource Webdav request fails

2019-08-20 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/JCR-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911082#comment-16911082
 ] 

Julian Reschke commented on JCR-4458:
-

[~woon_san] - I'll have a look, but it might take a few days. Any objections to 
do a release of Jackrabbit trunk first?

> When JcrRemotingServlet deployed on non-root context, AclResource Webdav 
> request fails
> --
>
> Key: JCR-4458
> URL: https://issues.apache.org/jira/browse/JCR-4458
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>Affects Versions: 2.18.2
>Reporter: Woonsan Ko
>Assignee: Julian Reschke
>Priority: Major
>
> If {{org.apache.jackrabbit.server.remoting.davex.JcrRemotingServlet}} is 
> configured in a non-root web application, the contextPath of which is "/cms" 
> for example with the servletPath, "/server", then 
> {{javax.jcr.Session#importXML(...)}} fails from a JCR client based on 
> JCR/WebDAV. In other words, {{#importXML(...)}} fails from a JCR {{Session}} 
> using a repository which can be created like the following for JCR over 
> WebDAV:
> {code}
> String repositoryAddress = "http://localhost:8080/cms/server;;
> Jcr2davRepositoryFactory factory = new Jcr2davRepositoryFactory();
> Map params = new HashMap();
> params.put(JcrUtils.REPOSITORY_URI, repositoryAddress);
> Repository repository = factory.getRepository(params);
> // ...
> {code}
> It seems like that {{Session#importXML(...)}} call invokes an AclResource 
> Webdav request first on the specific resource path, but 
> {{org.apache.jackrabbit.webdav.jcr.version.report.JcrPrivilegeReport#init(DavResource,
>  ReportInfo)}} does not remove the contextPath, "/cms" for example, when 
> determining the resoucrePath.
> Unlike the {{JcrPrivilegeReport}}, 
> {{org.apache.jackrabbit.webdav.WebdavRequestImpl#getHrefLocator(String, 
> boolean)}} seems to remove the contextPath properly.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (JCRVLT-355) False error in case embedded file/subpackage is overwritten by jcrRootSourceDirectory

2019-08-20 Thread Stefan Seifert (Jira)


[ 
https://issues.apache.org/jira/browse/JCRVLT-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911050#comment-16911050
 ] 

Stefan Seifert commented on JCRVLT-355:
---

concerning the 2nd test project:

 {quote}
if you set the root directoy to vault-work, it works:
{code:xml}
${project.build.directory}/vault-work
{code}
{quote}

this does not work (neither with package plugin 1.0.3 or 1.0.4), as the package 
then only contains the output produced by the {{build-helper-maven-plugin}}, 
and not the other content.

but let's first focus on the simpler 1st test project before trying to solve 
the interaction of those two plugins.

> False error in case embedded file/subpackage is overwritten by 
> jcrRootSourceDirectory
> -
>
> Key: JCRVLT-355
> URL: https://issues.apache.org/jira/browse/JCRVLT-355
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.0.4
>Reporter: Stefan Seifert
>Assignee: Konrad Windszus
>Priority: Major
>
> i've found problem with the check introduced with JCRVLT-279 - or i do not 
> understand why the check leads to a failure in my case.
> i've two projects where this happens:
> 1. conf-content:
> https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/master/content-packages/conf-content
> fails with:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.jackrabbit:filevault-package-maven-plugin:1.0.4:package 
> (default-package) on project 
> mycompany.myprojectgroup.myproject1.conf-content: 
> org.apache.maven.plugin.MojoFailureException: Found duplicate files in 
> content package, most probably you have overlapping filter roots or you embed 
> a file which is already there in 'jcrRootSourceDirectory'. For details check 
> the nested exception!: Duplicate file 
> jcr_root\conf\myproject1\settings\wcm\policies was found and the duplicate 
> attribute is 'fail'. {noformat}
> 2. ui.apps
> https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/master/content-packages/ui.apps
> fails with:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.jackrabbit:filevault-package-maven-plugin:1.0.4:package 
> (default-package) on project mycompany.myprojectgroup.myproject1.ui.apps: 
> org.apache.maven.plugin.MojoFailureException: Found duplicate files in 
> content package, most probably you have overlapping filter roots or you embed 
> a file which is already there in 'jcrRootSourceDirectory'. For details check 
> the nested exception!: Duplicate file 
> jcr_root\apps\epsilon65Project\clientlibs\.content.xml was found and the 
> duplicate attribute is 'fail'.
> {noformat}
> the second project is a special case because in some files in the 
> "clientlibs" folder placeholders are replaced using maven resource filtering, 
> if the corresponding build-helper-maven-plugin definition is removed the 
> build works.
> but the first project is really simple project.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (JCRVLT-355) False error in case embedded file/subpackage is overwritten by jcrRootSourceDirectory

2019-08-20 Thread Stefan Seifert (Jira)


[ 
https://issues.apache.org/jira/browse/JCRVLT-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911037#comment-16911037
 ] 

Stefan Seifert commented on JCRVLT-355:
---

concerning the 1st test project:

this does not work when installing the package:
{code:xml}






{code}

it does not create {{/conf/myproject1/settings/wcm}} or anything below it.
it is only creates the path when i add a third include pattern like
{code:xml}

{code}
but this is than not the same filter as the initial one as it also 
includes/overwrite the node {{/conf/myproject1/settings}}.

and technically - even if the filter expression can be made more elegant 
somehow - it should not lead to an error when building the package?

> False error in case embedded file/subpackage is overwritten by 
> jcrRootSourceDirectory
> -
>
> Key: JCRVLT-355
> URL: https://issues.apache.org/jira/browse/JCRVLT-355
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.0.4
>Reporter: Stefan Seifert
>Assignee: Konrad Windszus
>Priority: Major
>
> i've found problem with the check introduced with JCRVLT-279 - or i do not 
> understand why the check leads to a failure in my case.
> i've two projects where this happens:
> 1. conf-content:
> https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/master/content-packages/conf-content
> fails with:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.jackrabbit:filevault-package-maven-plugin:1.0.4:package 
> (default-package) on project 
> mycompany.myprojectgroup.myproject1.conf-content: 
> org.apache.maven.plugin.MojoFailureException: Found duplicate files in 
> content package, most probably you have overlapping filter roots or you embed 
> a file which is already there in 'jcrRootSourceDirectory'. For details check 
> the nested exception!: Duplicate file 
> jcr_root\conf\myproject1\settings\wcm\policies was found and the duplicate 
> attribute is 'fail'. {noformat}
> 2. ui.apps
> https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/master/content-packages/ui.apps
> fails with:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.jackrabbit:filevault-package-maven-plugin:1.0.4:package 
> (default-package) on project mycompany.myprojectgroup.myproject1.ui.apps: 
> org.apache.maven.plugin.MojoFailureException: Found duplicate files in 
> content package, most probably you have overlapping filter roots or you embed 
> a file which is already there in 'jcrRootSourceDirectory'. For details check 
> the nested exception!: Duplicate file 
> jcr_root\apps\epsilon65Project\clientlibs\.content.xml was found and the 
> duplicate attribute is 'fail'.
> {noformat}
> the second project is a special case because in some files in the 
> "clientlibs" folder placeholders are replaced using maven resource filtering, 
> if the corresponding build-helper-maven-plugin definition is removed the 
> build works.
> but the first project is really simple project.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)