[jira] [Comment Edited] (JCRVLT-443) Allow dependencies in "container" package type
[
https://issues.apache.org/jira/browse/JCRVLT-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138914#comment-17138914
]
Tobias Bocanegra edited comment on JCRVLT-443 at 6/18/20, 12:18 AM:
I think we added the import package requirements for bundles to the package,
but never implemented a validation check. since jackrabbit doesn't really know
about OSGi.
But I agree with [~dsuess] that we should not allow dependencies in container
packages.
We use to do this for a long time, and it got us in deep troubles when trying
to resolve the installation order of larger package sets.
was (Author: tripod):
I think we added the import package requirements for bundles to the package,
but never implemented a validation check. since jackrabbit doesn't really know
about OSGi.
> Allow dependencies in "container" package type
> --
>
> Key: JCRVLT-443
> URL: https://issues.apache.org/jira/browse/JCRVLT-443
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: Packaging
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> According to JCRVLT-170 {{container}} packages must not have package
> dependencies.
> Sometimes there are multiple container packages though and with the nesting
> of container packages added in JCRVLT-401 it makes sense now to add package
> dependencies also to containers (to enforce a certain order in case they are
> nested or just because at build time the dependency cannot be resolved, i.e.
> included in the container package)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-443) Allow dependencies in "container" package type
[
https://issues.apache.org/jira/browse/JCRVLT-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138914#comment-17138914
]
Tobias Bocanegra commented on JCRVLT-443:
-
I think we added the import package requirements for bundles to the package,
but never implemented a validation check. since jackrabbit doesn't really know
about OSGi.
> Allow dependencies in "container" package type
> --
>
> Key: JCRVLT-443
> URL: https://issues.apache.org/jira/browse/JCRVLT-443
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: Packaging
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> According to JCRVLT-170 {{container}} packages must not have package
> dependencies.
> Sometimes there are multiple container packages though and with the nesting
> of container packages added in JCRVLT-401 it makes sense now to add package
> dependencies also to containers (to enforce a certain order in case they are
> nested or just because at build time the dependency cannot be resolved, i.e.
> included in the container package)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [jackrabbit-oak] johobot closed pull request #234: OAK-9113 - Make the migrateGraph and migrateBinaryRef more resilient to timeouts
johobot closed pull request #234: URL: https://github.com/apache/jackrabbit-oak/pull/234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (JCRVLT-443) Allow dependencies in "container" package type
[
https://issues.apache.org/jira/browse/JCRVLT-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138663#comment-17138663
]
Konrad Windszus edited comment on JCRVLT-443 at 6/17/20, 5:22 PM:
--
bq. the analysers are supposed to check the dependencies of the actual
contained artifacts and not dependencies between containers
I am not aware of any such analysers. Where are they? I need to prevent
installation of the package in the case the dependency cannot be resolved, and
the only means I know is currently effectively working for that is package
dependencies. But maybe I missed something
was (Author: kwin):
> the analysers are supposed to check the dependencies of the actual contained
> artifacts and not dependencies between containers
I am not aware of any such analysers. Where are they? I need to prevent
installation of the package in the case the dependency cannot be resolved, and
the only means I know is currently effectively working for that is package
dependencies. But maybe I missed something
> Allow dependencies in "container" package type
> --
>
> Key: JCRVLT-443
> URL: https://issues.apache.org/jira/browse/JCRVLT-443
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: Packaging
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> According to JCRVLT-170 {{container}} packages must not have package
> dependencies.
> Sometimes there are multiple container packages though and with the nesting
> of container packages added in JCRVLT-401 it makes sense now to add package
> dependencies also to containers (to enforce a certain order in case they are
> nested or just because at build time the dependency cannot be resolved, i.e.
> included in the container package)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-443) Allow dependencies in "container" package type
[
https://issues.apache.org/jira/browse/JCRVLT-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138663#comment-17138663
]
Konrad Windszus commented on JCRVLT-443:
> the analysers are supposed to check the dependencies of the actual contained
> artifacts and not dependencies between containers
I am not aware of any such analysers. Where are they? I need to prevent
installation of the package in the case the dependency cannot be resolved, and
the only means I know is currently effectively working for that is package
dependencies. But maybe I missed something
> Allow dependencies in "container" package type
> --
>
> Key: JCRVLT-443
> URL: https://issues.apache.org/jira/browse/JCRVLT-443
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: Packaging
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> According to JCRVLT-170 {{container}} packages must not have package
> dependencies.
> Sometimes there are multiple container packages though and with the nesting
> of container packages added in JCRVLT-401 it makes sense now to add package
> dependencies also to containers (to enforce a certain order in case they are
> nested or just because at build time the dependency cannot be resolved, i.e.
> included in the container package)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-443) Allow dependencies in "container" package type
[
https://issues.apache.org/jira/browse/JCRVLT-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138600#comment-17138600
]
Dominik Süß commented on JCRVLT-443:
[~kwin] no that is exactly what we want to prevent - the analysers are supposed
to check the dependencies of the actual contained artifacts and not
dependencies between containers. The effective dependency that you are
describing is an import-package (java) dependency that should be formulated as
such, any additional dependency is a wrong constraint - it doesn't matter if
the java package is provided by container a or container b, it just matters
that the import-package requirement is being satisfied.
> Allow dependencies in "container" package type
> --
>
> Key: JCRVLT-443
> URL: https://issues.apache.org/jira/browse/JCRVLT-443
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: Packaging
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> According to JCRVLT-170 {{container}} packages must not have package
> dependencies.
> Sometimes there are multiple container packages though and with the nesting
> of container packages added in JCRVLT-401 it makes sense now to add package
> dependencies also to containers (to enforce a certain order in case they are
> nested or just because at build time the dependency cannot be resolved, i.e.
> included in the container package)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (JCRVLT-443) Allow dependencies in "container" package type
[
https://issues.apache.org/jira/browse/JCRVLT-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138596#comment-17138596
]
Konrad Windszus edited comment on JCRVLT-443 at 6/17/20, 3:52 PM:
--
Consider container package {{a}} containing bundle {{b}}. {{b}} has a
dependency on another bundle {{c}}. This is correctly reflected in the
{{Import-Packages}} header of the bundle {{b}}. Bundle {{c}} is only provided
by container {{d}}. Therefore it is reasonable to in addition add a package
dependency from {{a}} to {{d}}.
was (Author: kwin):
Consider container package `a` containing bundle `b`. `b` has a dependency on
another bundle `c`. This is correctly reflected in the `Import-Packages` header
of the bundle. Bundle `c` is only provided by container `d`. Therefore it is
reasonable to in addition add a package dependency from `a` to `d`.
> Allow dependencies in "container" package type
> --
>
> Key: JCRVLT-443
> URL: https://issues.apache.org/jira/browse/JCRVLT-443
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: Packaging
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> According to JCRVLT-170 {{container}} packages must not have package
> dependencies.
> Sometimes there are multiple container packages though and with the nesting
> of container packages added in JCRVLT-401 it makes sense now to add package
> dependencies also to containers (to enforce a certain order in case they are
> nested or just because at build time the dependency cannot be resolved, i.e.
> included in the container package)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-443) Allow dependencies in "container" package type
[
https://issues.apache.org/jira/browse/JCRVLT-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138596#comment-17138596
]
Konrad Windszus commented on JCRVLT-443:
Consider container package `a` containing bundle `b`. `b` has a dependency on
another bundle `c`. This is correctly reflected in the `Import-Packages` header
of the bundle. Bundle `c` is only provided by container `d`. Therefore it is
reasonable to in addition add a package dependency from `a` to `d`.
> Allow dependencies in "container" package type
> --
>
> Key: JCRVLT-443
> URL: https://issues.apache.org/jira/browse/JCRVLT-443
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: Packaging
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> According to JCRVLT-170 {{container}} packages must not have package
> dependencies.
> Sometimes there are multiple container packages though and with the nesting
> of container packages added in JCRVLT-401 it makes sense now to add package
> dependencies also to containers (to enforce a certain order in case they are
> nested or just because at build time the dependency cannot be resolved, i.e.
> included in the container package)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-443) Allow dependencies in "container" package type
[
https://issues.apache.org/jira/browse/JCRVLT-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138534#comment-17138534
]
Dominik Süß commented on JCRVLT-443:
[~kwin] I don't know if I really can follow the scenario. The reasoning behind
containers not having dependencies is that the dependencies always relate to
content - so the dependency should be defined on the package within the
container holding the content it depends on. This is similar to not depending
on bundles but on java packages in osgi. We did even check if we could have
dependency vectors related to the actual content but that turned out to make
the dependency syntax far too complex - dependencies on the actual holding
content-package seems the most accurate way and avoids transient dependencies.
> Allow dependencies in "container" package type
> --
>
> Key: JCRVLT-443
> URL: https://issues.apache.org/jira/browse/JCRVLT-443
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: Packaging
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> According to JCRVLT-170 {{container}} packages must not have package
> dependencies.
> Sometimes there are multiple container packages though and with the nesting
> of container packages added in JCRVLT-401 it makes sense now to add package
> dependencies also to containers (to enforce a certain order in case they are
> nested or just because at build time the dependency cannot be resolved, i.e.
> included in the container package)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
