AW: [VOTE] Release Apache Jackrabbit 2.21.5

2021-01-11 Thread KÖLL Claus
+1

greets
claus


Re: [VOTE] Release Apache Jackrabbit 2.21.5

2021-01-11 Thread Woonsan Ko
[X] +1 Release this package as Apache Jackrabbit 2.21.5

all checks okay on:

[INFO] Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T15:39:06-04:00)
[INFO] OS name: "mac os x", version: "10.15.7", arch: "x86_64", family: "mac"
[INFO] Java version: 1.8.0_144, vendor: Oracle Corporation
[INFO] MAVEN_OPTS:

Regards,

Woonsan

On Mon, Jan 11, 2021 at 6:14 AM Julian Reschke  wrote:
>
> A candidate for the Jackrabbit 2.21.5 release is available at:
>
>  https://dist.apache.org/repos/dist/dev/jackrabbit/2.21.5/
>
> The release candidate is a zip archive of the sources in:
>
>  https://svn.apache.org/repos/asf/jackrabbit/tags/jackrabbit-2.21.5/
>
> The SHA1 checksum of the archive is
> fbb7663a02559236c3d71bf45f6c4f78aa233758.
>
> A staged Maven repository is available for review at:
>
>  https://repository.apache.org/
>
> The command for running automated checks against this release candidate is:
>
>  # run in SVN checkout of
> https://dist.apache.org/repos/dist/dev/jackrabbit/
>  $ sh check-release.sh 2.21.5 fbb7663a02559236c3d71bf45f6c4f78aa233758
>
> Please vote on releasing this package as Apache Jackrabbit 2.21.5.
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 Jackrabbit PMC votes are cast.
>
>  [ ] +1 Release this package as Apache Jackrabbit 2.21.5
>  [ ] -1 Do not release this package because...
>
> Best regards, Julian


RE: [VOTE] Release Jackrabbit FileVault 3.4.8 and FileVault Package Maven Plugin 1.1.6

2021-01-11 Thread Stefan Seifert
+1 (non-binding)

stefan


Release Jackrabbit FileVault 3.4.8 and FileVault Package Maven Plugin 1.1.6

2021-01-11 Thread Konrad Windszus
Hi,

A candidate for the Jackrabbit Filevault 3.4.8 release is available at:

https://dist.apache.org/repos/dist/dev/jackrabbit/filevault/3.4.8/

The release candidate is a zip archive of the sources in:
https://github.com/apache/jackrabbit-filevault/tree/jackrabbit-filevault-3.4.8/

The release notes in JIRA are at 
https://issues.apache.org/jira/projects/JCRVLT/versions/12348445

The SHA1 checksum of the archive is 669663e26d9fe7364a2735bcf237b4719ba1879d.
The SHA512 checksum of the archive is 
c2e0024af08ec640ba6a725944392dca4ab36b6106b4418f98a67c4d0c8ba2b601c49627d83d8541b3d5c04824d5fce1479b727510d22d9a4b14c11af6621f90

The command for running automated checks against this release candidate is:
$ sh check-release.sh filevault 3.4.8 669663e26d9fe7364a2735bcf237b4719ba1879d

A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachejackrabbit-1534

=

Also a candidate for  the Jackrabbit FileVault Package Maven Plugin 1.1.6 
release is available at:
https://dist.apache.org/repos/dist/dev/jackrabbit/filevault-package-maven-plugin/1.1.6/

The release candidate is a zip archive of the sources in:
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/tree/filevault-package-maven-plugin-1.1.6/

The release notes in JIRA are at 
https://issues.apache.org/jira/projects/JCRVLT/versions/12348444

The SHA1 checksum of the archive is d5c8785cdf5a9d6e069e8af1cc3542b6acee5677
The SHA512 checksum of the archive is 
bb11177aaa59b9d69ad06d7b63e965c4bba70e6433577292c4a32d7431198840b9f6e83c6b374c0cf9b5409224a03b413d9e0e68057346a51c01d915b301e3a5

The command for running automated checks against this release candidate is:
$ sh check-release.sh filevault-plugin 1.1.6 
d5c8785cdf5a9d6e069e8af1cc3542b6acee5677


*** As FileVault Package Maven Plugin 1.1.6 depends on the FileVault 3.4.8 you 
need to install FileVault 3.4.8 to your local Maven repository (e.g. via mvn 
install) before being able to run the checks ***

A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachejackrabbit-1535

=

Please vote on releasing both packages as Apache Jackrabbit Filevault 3.4.8 and 
FileVault Package Maven Plugin 1.1.6.
The vote is open for a minimum of 72 hours during business days and passes
if a majority of at least three +1 Jackrabbit PMC votes are cast.
The vote fails if not enough votes are cast after 1 week (5 business days).

[ ] +1 Release these packages as Apache Jackrabbit Filevault 3.4.8 and 
FileVault Package Maven Plugin 1.1.6
[ ] -1 Do not release these packages because...

Thanks in advance for voting,
Konrad

[jira] [Resolved] (JCRVLT-490) jackrabbit-filevault-package-maven-plugin fails embedding files located on different drives on Windows

2021-01-11 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/JCRVLT-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved JCRVLT-490.

Resolution: Fixed

Fixed in 
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/commit/4e96a3b13cea390f862d5777b8ca0df5665deb05.

> jackrabbit-filevault-package-maven-plugin fails embedding files located on 
> different drives on Windows
> --
>
> Key: JCRVLT-490
> URL: https://issues.apache.org/jira/browse/JCRVLT-490
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.1.6
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: package-maven-plugin-1.1.6
>
>
> e.g. the project is on drive {{D:}} and the maven repository on drive {{C:}} 
> - the package step then fails with:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.jackrabbit:filevault-package-maven-plugin:1.1.5-SNAPSHOT:package 
> (default-package) on project io.wcm.samples.complete: Execution 
> default-package of goal 
> org.apache.jackrabbit:filevault-package-maven-plugin:1.1.5-SNAPSHOT:package 
> failed: 'other' has different root -> [Help 1]
> {noformat}
> root cause is a method to beautify the filenames for log output introduced in 
> JCRVLT-471 - i will prepare a PR.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [jackrabbit-filevault-package-maven-plugin] kwin commented on pull request #49: JCRVLT-490 fix issue with file name relativization when file resides on different drive than project (on window

2021-01-11 Thread GitBox


kwin commented on pull request #49:
URL: 
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/49#issuecomment-758146031


   Superseded by #50 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [jackrabbit-filevault-package-maven-plugin] kwin closed pull request #49: JCRVLT-490 fix issue with file name relativization when file resides on different drive than project (on windows file

2021-01-11 Thread GitBox


kwin closed pull request #49:
URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/49


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [jackrabbit-filevault-package-maven-plugin] kwin merged pull request #50: JCRVLT-490 only relativize path if it starts with the given base

2021-01-11 Thread GitBox


kwin merged pull request #50:
URL: https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/50


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (JCRVLT-490) jackrabbit-filevault-package-maven-plugin fails embedding files located on different drives on Windows

2021-01-11 Thread Stefan Seifert (Jira)


[ 
https://issues.apache.org/jira/browse/JCRVLT-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262833#comment-17262833
 ] 

Stefan Seifert commented on JCRVLT-490:
---

[~kwin] that's definitely the better approach, i validated it locally on 
windows, it works.

> jackrabbit-filevault-package-maven-plugin fails embedding files located on 
> different drives on Windows
> --
>
> Key: JCRVLT-490
> URL: https://issues.apache.org/jira/browse/JCRVLT-490
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.1.6
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: package-maven-plugin-1.1.6
>
>
> e.g. the project is on drive {{D:}} and the maven repository on drive {{C:}} 
> - the package step then fails with:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.jackrabbit:filevault-package-maven-plugin:1.1.5-SNAPSHOT:package 
> (default-package) on project io.wcm.samples.complete: Execution 
> default-package of goal 
> org.apache.jackrabbit:filevault-package-maven-plugin:1.1.5-SNAPSHOT:package 
> failed: 'other' has different root -> [Help 1]
> {noformat}
> root cause is a method to beautify the filenames for log output introduced in 
> JCRVLT-471 - i will prepare a PR.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [VOTE] Release Apache Jackrabbit 2.21.5

2021-01-11 Thread Julian Reschke

Am 11.01.2021 um 12:14 schrieb Julian Reschke:

...


[X] +1 Release this package as Apache Jackrabbit 2.21.5

...where...


[INFO] Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 
2018-06-17T20:33:14+02:00)
[INFO] OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
[INFO] Java version: 1.8.0_231, vendor: Oracle Corporation, runtime: 
C:\usr\local\jdk18\jre
[INFO] MAVEN_OPTS: -Xmx2g


Best regards, Julian


[VOTE] Release Apache Jackrabbit 2.21.5

2021-01-11 Thread Julian Reschke

A candidate for the Jackrabbit 2.21.5 release is available at:

https://dist.apache.org/repos/dist/dev/jackrabbit/2.21.5/

The release candidate is a zip archive of the sources in:

https://svn.apache.org/repos/asf/jackrabbit/tags/jackrabbit-2.21.5/

The SHA1 checksum of the archive is 
fbb7663a02559236c3d71bf45f6c4f78aa233758.


A staged Maven repository is available for review at:

https://repository.apache.org/

The command for running automated checks against this release candidate is:

# run in SVN checkout of 
https://dist.apache.org/repos/dist/dev/jackrabbit/

$ sh check-release.sh 2.21.5 fbb7663a02559236c3d71bf45f6c4f78aa233758

Please vote on releasing this package as Apache Jackrabbit 2.21.5.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 Jackrabbit PMC votes are cast.

[ ] +1 Release this package as Apache Jackrabbit 2.21.5
[ ] -1 Do not release this package because...

Best regards, Julian


[GitHub] [jackrabbit-filevault-package-maven-plugin] sonarcloud[bot] commented on pull request #50: JCRVLT-490 only relativize path if it starts with the given base

2021-01-11 Thread GitBox


sonarcloud[bot] commented on pull request #50:
URL: 
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/50#issuecomment-75153


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin=50=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin=50=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin=50=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin=50=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin=50=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin=50=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_jackrabbit-filevault-package-maven-plugin=50=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_jackrabbit-filevault-package-maven-plugin=50=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_jackrabbit-filevault-package-maven-plugin=50=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin=50=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin=50=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_jackrabbit-filevault-package-maven-plugin=50=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_jackrabbit-filevault-package-maven-plugin=50=new_coverage=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_jackrabbit-filevault-package-maven-plugin=50=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_jackrabbit-filevault-package-maven-plugin=50=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_jackrabbit-filevault-package-maven-plugin=50=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (JCRVLT-490) jackrabbit-filevault-package-maven-plugin fails embedding files located on different drives on Windows

2021-01-11 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/JCRVLT-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262462#comment-17262462
 ] 

Konrad Windszus commented on JCRVLT-490:


[~sseifert] Thanks for the report. I came up with a slightly different fix in 
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/50/files,
 because we should only use relative paths in case the given path is below the 
basedir. WDYT?

> jackrabbit-filevault-package-maven-plugin fails embedding files located on 
> different drives on Windows
> --
>
> Key: JCRVLT-490
> URL: https://issues.apache.org/jira/browse/JCRVLT-490
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.1.6
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: package-maven-plugin-1.1.6
>
>
> e.g. the project is on drive {{D:}} and the maven repository on drive {{C:}} 
> - the package step then fails with:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.jackrabbit:filevault-package-maven-plugin:1.1.5-SNAPSHOT:package 
> (default-package) on project io.wcm.samples.complete: Execution 
> default-package of goal 
> org.apache.jackrabbit:filevault-package-maven-plugin:1.1.5-SNAPSHOT:package 
> failed: 'other' has different root -> [Help 1]
> {noformat}
> root cause is a method to beautify the filenames for log output introduced in 
> JCRVLT-471 - i will prepare a PR.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)