[GitHub] [jackrabbit-filevault] kwin merged pull request #212: releng: use newest ASF parent 25

[GitBox]

kwin merged pull request #212:
URL: https://github.com/apache/jackrabbit-filevault/pull/212


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Jackrabbit Oak 1.22.11

[Nitin Gupta]

  [X] +1 Release this package as Apache Jackrabbit Oak 1.22.11


[INFO] 

[INFO] Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)

[INFO] OS name: "mac os x", version: "10.15.7", arch: "x86_64", family: "mac"

[INFO] Java version: 11.0.2, vendor: Oracle Corporation, runtime: 
/Library/Java/JavaVirtualMachines/openjdk-11.0.2.jdk/Contents/Home

[INFO] MAVEN_OPTS:

[INFO] 

[INFO] ALL CHECKS OK

[INFO] 


From: Nitin Gupta 
Date: Tuesday, 22 February 2022 at 12:11 PM
To: oak-dev@jackrabbit.apache.org 
Subject: [VOTE] Release Apache Jackrabbit Oak 1.22.11
A candidate for the Jackrabbit Oak 1.22.11 release is available at:



https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fjackrabbit%2Foak%2F1.22.11%2Fdata=04%7C01%7Cnitigup%40adobe.com%7C4a09c755b18b41b7e57408d9f5ce2385%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637811088701527788%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000sdata=1HPcRCtBTAge%2BZDzaDgHcErwyeuCGZ1Kh0EgJgM42pk%3Dreserved=0


The release candidate is a zip archive of the sources in:


 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fjackrabbit-oak%2Ftree%2Fjackrabbit-oak-1.22.11%2Fdata=04%7C01%7Cnitigup%40adobe.com%7C4a09c755b18b41b7e57408d9f5ce2385%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637811088701527788%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000sdata=XPyEG1BpttqH6DSNlTXeD7SaRDGpWYlq3fZSECj8pWE%3Dreserved=0


The SHA1 checksum of the archive is a30de1acef87debdcc73773d434529c4ab287283.


A staged Maven repository is available for review at:



https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fdata=04%7C01%7Cnitigup%40adobe.com%7C4a09c755b18b41b7e57408d9f5ce2385%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637811088701527788%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000sdata=YypRH%2Fb1D%2BySN1dv%2FRNOcjXQgDm%2BxyGUtgHYnBom1Gg%3Dreserved=0


The command for running automated checks against this release candidate is:


# run in SVN checkout of 
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fjackrabbitdata=04%7C01%7Cnitigup%40adobe.com%7C4a09c755b18b41b7e57408d9f5ce2385%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637811088701527788%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000sdata=%2FxKUXZ4MwJZyHDu5%2FPy%2FC5nBbXZmxQQHG0xlqtHjuAo%3Dreserved=0

$ sh check-release.sh oak 1.22.11 a30de1acef87debdcc73773d434529c4ab287283


Please vote on releasing this package as Apache Jackrabbit Oak 1.22.11.

The vote is open for the next 72 hours and passes if a majority of at

least three +1 Jackrabbit PMC votes are cast.


[ ] +1 Release this package as Apache Jackrabbit Oak 1.22.11

[ ] -1 Do not release this package because...

[jira] [Commented] (JCR-4767) Jackrabbit 2.18.0, fails to get Respository Session on Tomcat9, where as everything works fine on Tomcat7

[Hari (Jira)]

[ 
https://issues.apache.org/jira/browse/JCR-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495905#comment-17495905
 ] 

Hari commented on JCR-4767:
---

[~Adhip] Could you please help with this issue

> Jackrabbit 2.18.0, fails to get Respository Session on Tomcat9, where as 
> everything works fine on Tomcat7
> -
>
> Key: JCR-4767
> URL: https://issues.apache.org/jira/browse/JCR-4767
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: config
>Reporter: Hari
>Priority: Major
>
> Need help to suggest, how to resolve the below issue, after migrating the 
> application to Tomcat9.
> Please help suggest, if any additional configurations required when we 
> migrate from TOmcat7 to Tomcat9
> JackRabbit Version Being used: 2.18.0
>  
> Error: 
> Caused by: javax.servlet.ServletException: Repository access configuration is 
> not valid.
>                 at 
> org.apache.jackrabbit.j2ee.RepositoryAccessServlet.getConfig(RepositoryAccessServlet.java:171)
>                 at 
> org.apache.jackrabbit.j2ee.RepositoryAccessServlet.getRepositoryByJNDI(RepositoryAccessServlet.java:203)
>                 at 
> org.apache.jackrabbit.j2ee.RepositoryAccessServlet.getRepository(RepositoryAccessServlet.java:303)
>                 ... 50 more
> 22-Feb-2022 06:51:24.483 SEVERE [http-nio-127.0.0.1-27100-exec-7] 
> org.apache.catalina.core.StandardWrapperValve.invoke Servlet.service() for 
> servlet [JCRWebdavServer] in context with path [/jackrabbit] threw exc
> eption
>         java.lang.IllegalStateException: The repository is not available. 
> Please check RepositoryAccessServlet configuration in web.xml.
>                 at 
> org.apache.jackrabbit.j2ee.RepositoryAccessServlet.getRepository(RepositoryAccessServlet.java:314)
>                 at 
> org.apache.jackrabbit.j2ee.RepositoryAccessServlet.getRepository(RepositoryAccessServlet.java:328)
>                 at 
> org.apache.jackrabbit.j2ee.JcrRemotingServlet.getRepository(JcrRemotingServlet.java:31)
>                 at 
> org.apache.jackrabbit.webdav.jcr.JCRWebdavServerServlet.getDavSessionProvider(JCRWebdavServerServlet.java:161)
>                 at 
> org.apache.jackrabbit.webdav.server.AbstractWebdavServlet.service(AbstractWebdavServlet.java:316)
>                 at 
> javax.servlet.http.HttpServlet.service(HttpServlet.java:733)
>                 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>                 at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (JCRVLT-608) CI/CD: Snapshot deployment does not update metadata correctly

[Konrad Windszus (Jira)]

Konrad Windszus created JCRVLT-608:
--

 Summary: CI/CD: Snapshot deployment does not update metadata 
correctly
 Key: JCRVLT-608
 URL: https://issues.apache.org/jira/browse/JCRVLT-608
 Project: Jackrabbit FileVault
  Issue Type: Bug
Reporter: Konrad Windszus
Assignee: Konrad Windszus


With JCRVLT-579 the snapshot deployment uses the {{wagon-maven-plugin}} for 
uploading to Nexus. This does not properly update the metadata of SNAPSHOT 
versions (https://github.com/mojohaus/wagon-maven-plugin/issues/7) therefore 
downstream builds might pick up outdated SNAPSHOT versions.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (JCR-4767) Jackrabbit 2.18.0, fails to get Respository Session on Tomcat9, where as everything works fine on Tomcat7

[Hari (Jira)]

Hari created JCR-4767:
-

 Summary: Jackrabbit 2.18.0, fails to get Respository Session on 
Tomcat9, where as everything works fine on Tomcat7
 Key: JCR-4767
 URL: https://issues.apache.org/jira/browse/JCR-4767
 Project: Jackrabbit Content Repository
  Issue Type: Bug
  Components: config
Reporter: Hari


Need help to suggest, how to resolve the below issue, after migrating the 
application to Tomcat9.

Please help suggest, if any additional configurations required when we migrate 
from TOmcat7 to Tomcat9

JackRabbit Version Being used: 2.18.0

 

Error: 

Caused by: javax.servlet.ServletException: Repository access configuration is 
not valid.
                at 
org.apache.jackrabbit.j2ee.RepositoryAccessServlet.getConfig(RepositoryAccessServlet.java:171)
                at 
org.apache.jackrabbit.j2ee.RepositoryAccessServlet.getRepositoryByJNDI(RepositoryAccessServlet.java:203)
                at 
org.apache.jackrabbit.j2ee.RepositoryAccessServlet.getRepository(RepositoryAccessServlet.java:303)
                ... 50 more
22-Feb-2022 06:51:24.483 SEVERE [http-nio-127.0.0.1-27100-exec-7] 
org.apache.catalina.core.StandardWrapperValve.invoke Servlet.service() for 
servlet [JCRWebdavServer] in context with path [/jackrabbit] threw exc
eption
        java.lang.IllegalStateException: The repository is not available. 
Please check RepositoryAccessServlet configuration in web.xml.
                at 
org.apache.jackrabbit.j2ee.RepositoryAccessServlet.getRepository(RepositoryAccessServlet.java:314)
                at 
org.apache.jackrabbit.j2ee.RepositoryAccessServlet.getRepository(RepositoryAccessServlet.java:328)
                at 
org.apache.jackrabbit.j2ee.JcrRemotingServlet.getRepository(JcrRemotingServlet.java:31)
                at 
org.apache.jackrabbit.webdav.jcr.JCRWebdavServerServlet.getDavSessionProvider(JCRWebdavServerServlet.java:161)
                at 
org.apache.jackrabbit.webdav.server.AbstractWebdavServlet.service(AbstractWebdavServlet.java:316)
                at javax.servlet.http.HttpServlet.service(HttpServlet.java:733)
                at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[VOTE] Release Apache Jackrabbit Oak 1.22.11

[Nitin Gupta]

A candidate for the Jackrabbit Oak 1.22.11 release is available at:


https://dist.apache.org/repos/dist/dev/jackrabbit/oak/1.22.11/


The release candidate is a zip archive of the sources in:


 https://github.com/apache/jackrabbit-oak/tree/jackrabbit-oak-1.22.11/


The SHA1 checksum of the archive is a30de1acef87debdcc73773d434529c4ab287283.


A staged Maven repository is available for review at:


https://repository.apache.org/


The command for running automated checks against this release candidate is:


# run in SVN checkout of https://dist.apache.org/repos/dist/dev/jackrabbit

$ sh check-release.sh oak 1.22.11 a30de1acef87debdcc73773d434529c4ab287283


Please vote on releasing this package as Apache Jackrabbit Oak 1.22.11.

The vote is open for the next 72 hours and passes if a majority of at

least three +1 Jackrabbit PMC votes are cast.


[ ] +1 Release this package as Apache Jackrabbit Oak 1.22.11

[ ] -1 Do not release this package because...

[GitHub] [jackrabbit-oak] thomasmueller commented on a change in pull request #498: OAK-9694: expose elastic stats in oak-index-stats and mbean

[GitBox]

thomasmueller commented on a change in pull request #498:
URL: https://github.com/apache/jackrabbit-oak/pull/498#discussion_r811307939



##
File path: 
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/inventory/IndexPrinter.java
##
@@ -71,147 +70,107 @@ public IndexPrinter(IndexInfoService indexInfoService, 
AsyncIndexInfoService asy
 
 @Override
 public void print(PrintWriter pw, Format format, boolean isZip) {
-
-if (format == Format.JSON) {
-JsopBuilder json = new JsopBuilder();
-startJsonObject(json);
-printAsyncIndexInfo(pw, json, format);
-printIndexInfo(pw, json, format);
-endJsonObject(json);
-pw.print(JsopBuilder.prettyPrint(json.toString()));
-} else {
-//TODO Highlight if failing
-printAsyncIndexInfo(pw, null, format);
-printIndexInfo(pw, null, format);
-}
+PrinterOutput po = format == Format.JSON ? new JsonPrinterOutput() : 
new TextPrinterOutput();
+asyncLanesInfo(po);
+indexInfo(po);
+pw.print(po.output());
 }
 
-private void printAsyncIndexInfo(PrintWriter pw, JsopBuilder json, Format 
format) {
+private void asyncLanesInfo(PrinterOutput po) {
 List asyncLanes = 
ImmutableList.copyOf(asyncIndexInfoService.getAsyncLanes());
-String title = "Async Indexers State";
-printTitle(pw, title, format);
-addJsonKey(json, title);
-startJsonObject(json);
-keyValue("Number of async indexer lanes ", asyncLanes.size(), pw, 
json, format);
-printWithNewLine(pw, "", format);
+po.startSection("Async Indexers State", true);
+po.text("Number of async indexer lanes", asyncLanes.size());
 
 for (String lane : asyncLanes) {
-printWithNewLine(pw, lane, format);
-addJsonKey(json, lane);
+po.startSection(lane, false);
 AsyncIndexInfo info = asyncIndexInfoService.getInfo(lane);
-startJsonObject(json);
 if (info != null) {
-keyValue("Last indexed to  ", 
formatTime(info.getLastIndexedTo()), pw, json, format);
+po.text("Last indexed to", 
formatTime(info.getLastIndexedTo()));
 IndexStatsMBean stats = info.getStatsMBean();
 if (stats != null) {
-keyValue("Status  ", stats.getStatus(), 
pw, json, format);
-keyValue("Failing ", stats.isFailing(), 
pw, json, format);
-keyValue("Paused  ", stats.isPaused(), pw, 
json, format);
+po.text("Status", stats.getStatus());
+po.text("Failing", stats.isFailing());
+po.text("Paused", stats.isPaused());
 if (stats.isFailing()) {
-keyValue("Failing since   ", 
stats.getFailingSince(), pw, json, format);
-keyValue("Latest error", 
stats.getLatestError(), pw, json, format);
+po.text("Failing since", stats.getFailingSince());
+po.text("Latest error", stats.getLatestError());
 }
 }
-printWithNewLine(pw, "", format);
 }
-endJsonObject(json);
+po.endSection();
 }
-endJsonObject(json);
+po.endSection();
 }
 
-private static void printTitle(PrintWriter pw, String title, Format 
format) {
-if (format == Format.TEXT) {
-pw.println(title);
-pw.println(Strings.repeat("=", title.length()));
-pw.println();
-}
-}
+private void indexInfo(PrinterOutput po) {
+Map> indexesByType = 
StreamSupport.stream(indexInfoService.getAllIndexInfo().spliterator(), false)
+.collect(Collectors.groupingBy(IndexInfo::getType));
 
-private static void printWithNewLine(PrintWriter pw, String printLine, 
Format format) {
-if (format == Format.TEXT) {
-pw.println(printLine);
-}
-}
+po.text("Total number of indexes", 
indexesByType.values().stream().mapToInt(List::size).sum());
 
-private void printIndexInfo(PrintWriter pw, JsopBuilder json, Format 
format) {
-ListMultimap infos = ArrayListMultimap.create();
-for (IndexInfo info : indexInfoService.getAllIndexInfo()) {
-infos.put(info.getType(), info);
-}
-
-keyValue("Total number of indexes ", infos.size(), pw, json, format);
-
-for (String type : infos.keySet()){
-List typedInfo = infos.get(type);
-String title = String.format("%s(%d)", type, typedInfo.size());
-printTitle(pw, title, format);
-addJsonKey(json, type);
-startJsonObject(json);
+for (String type : 

[GitHub] [jackrabbit-oak] fabriziofortino commented on a change in pull request #498: OAK-9694: expose elastic stats in oak-index-stats and mbean

[GitBox]

fabriziofortino commented on a change in pull request #498:
URL: https://github.com/apache/jackrabbit-oak/pull/498#discussion_r811292239



##
File path: 
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/editor/FulltextIndexEditorContext.java
##
@@ -165,9 +164,8 @@ public void closeWriter() throws IOException {
   NodeBuilder status = 
definitionBuilder.child(IndexDefinition.STATUS_NODE);
   status.setProperty(IndexDefinition.STATUS_LAST_UPDATED, 
getUpdatedTime(currentTime), Type.DATE);
   status.setProperty("indexedNodes", indexedNodes);
-  if (storedIndexDefinitionEnabled() && reindex) {
-NodeBuilder indexDefinition = definitionBuilder.child(STATUS_NODE);
-
indexDefinition.setProperty(IndexDefinition.REINDEX_COMPLETION_TIMESTAMP, 
ISO8601.format(currentTime), Type.DATE);
+  if (reindex) {

Review comment:
   the reindex completion timestamp is exposed in the index stats. I could 
not find a reason why this was not set for NON stored index defs. I don't see 
issues in setting it in any case. Feedback is welcome @thomasmueller @nit0906 
@averma21 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] fabriziofortino commented on pull request #498: OAK-9694: expose elastic stats in oak-index-stats and mbean

[GitBox]

fabriziofortino commented on pull request #498:
URL: https://github.com/apache/jackrabbit-oak/pull/498#issuecomment-1047055377


   cc @AngelaFabregues 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Planned release date for FileVault 3.6.0

[Robert Munteanu]

Hi Konrad,

On Mon, 2022-02-21 at 14:50 +0100, Konrad Windszus wrote:
> Hi,
> I could start the release end of this week. 
> I am not sure if Julian is still working on
> https://issues.apache.org/jira/browse/JCRVLT-598 <
> https://issues.apache.org/jira/browse/JCRVLT-598>…
> 
> Apart from that I would just like to include
> https://issues.apache.org/jira/browse/JCRVLT-559 <
> https://issues.apache.org/jira/browse/JCRVLT-559> which I am
> currently working on.

Thanks for the info, end of this week would work fine for me.

Robert

[jira] [Assigned] (JCRVLT-559) jackrabbit-nodetypes validator: Support CNDs contained in package

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/JCRVLT-559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned JCRVLT-559:
--

Assignee: Konrad Windszus

> jackrabbit-nodetypes validator: Support CNDs contained in package
> -
>
> Key: JCRVLT-559
> URL: https://issues.apache.org/jira/browse/JCRVLT-559
> Project: Jackrabbit FileVault
>  Issue Type: Improvement
>  Components: validation
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.6.0
>
>
> The validator should automatically pick up the CND files shipping with the 
> package and also correctly treat remapped namespaces (having a different 
> prefix in the docview XML than in the predefined CND)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [jackrabbit-filevault] kwin merged pull request #211: JCRVLT-357 add method to DocViewParser for converting file name to root

[GitBox]

kwin merged pull request #211:
URL: https://github.com/apache/jackrabbit-filevault/pull/211


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit] reschke commented on pull request #96: JCR-4766: correct json response content type

[GitBox]

reschke commented on pull request #96:
URL: https://github.com/apache/jackrabbit/pull/96#issuecomment-1046911160


   The change in itself looks right to me. My only concern would be that there 
is client code which might rely on the incorrect type. But that should be 
covered by integration tests, right. @anchela ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (JCRVLT-559) jackrabbit-nodetypes validator: Support CNDs contained in package

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/JCRVLT-559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated JCRVLT-559:
---
Fix Version/s: 3.6.0

> jackrabbit-nodetypes validator: Support CNDs contained in package
> -
>
> Key: JCRVLT-559
> URL: https://issues.apache.org/jira/browse/JCRVLT-559
> Project: Jackrabbit FileVault
>  Issue Type: Improvement
>  Components: validation
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.6.0
>
>
> The validator should automatically pick up the CND files shipping with the 
> package and also correctly treat remapped namespaces (having a different 
> prefix in the docview XML than in the predefined CND)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (JCRVLT-559) jackrabbit-nodetypes validator: Support CNDs contained in package

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/JCRVLT-559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated JCRVLT-559:
---
Summary: jackrabbit-nodetypes validator: Support CNDs contained in package  
(was: jackrabbit-nodetypes validator: Support CNDs from package and namespaces 
from Docview XML)

> jackrabbit-nodetypes validator: Support CNDs contained in package
> -
>
> Key: JCRVLT-559
> URL: https://issues.apache.org/jira/browse/JCRVLT-559
> Project: Jackrabbit FileVault
>  Issue Type: Improvement
>  Components: validation
>Reporter: Konrad Windszus
>Priority: Major
>
> The validator should automatically pick up the CND files shipping with the 
> package and also correctly treat remapped namespaces (having a different 
> prefix in the docview XML than in the predefined CND)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Re: Planned release date for FileVault 3.6.0

[Konrad Windszus]

Hi,
I could start the release end of this week. 
I am not sure if Julian is still working on 
https://issues.apache.org/jira/browse/JCRVLT-598 
…

Apart from that I would just like to include 
https://issues.apache.org/jira/browse/JCRVLT-559 
 which I am currently working 
on.

Konrad

> On 21. Feb 2022, at 13:48, Robert Munteanu  wrote:
> 
> Hi,
> 
> Is there an ETA for FileVault 3.6.0? I would like to consume JCRVLT-357
> [1] for an upcoming Sling task [2].
> 
> Thanks,
> Robert
> 
> [1]: https://issues.apache.org/jira/browse/JCRVLT-357
> [2]: https://issues.apache.org/jira/browse/SLING-11134

[GitHub] [jackrabbit-oak] chibulcuteanu commented on a change in pull request #497: OAK-9699 Document Elastic Indexes

[GitBox]

chibulcuteanu commented on a change in pull request #497:
URL: https://github.com/apache/jackrabbit-oak/pull/497#discussion_r811133325



##
File path: oak-doc/src/site/markdown/query/elastic.md
##
@@ -0,0 +1,47 @@
+
+
+## Elastic Index
+
+Oak supports Elasticsearch (Elastic for short) based indexes to support 
+both property constraint and full text constraints. 
+Elastic indexes support similar features than [Lucene][lucene] indexes, 
+however there are differences:
+
+* The `type` is `elastic`.
+* The index definition needs to be under `/oak:index`.
+  Other locations are not supported.
+* The `async` property needs to be set to `async`. 
+  Synchronous, `nrt` or other lanes are not supported.
+  Indexes are updated asynchronously.
+* `refresh` is ignored.
+  Changes take effect immediately after changing them.
+  Existing documents in Elasticsearch are not changed.
+* `reindex` is ignored.

Review comment:
   what do you mean this is ignored? It's the only way to build an ES index 
after deploying the index definition directly on the repository (no oak-run).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] chibulcuteanu commented on a change in pull request #497: OAK-9699 Document Elastic Indexes

[GitBox]

chibulcuteanu commented on a change in pull request #497:
URL: https://github.com/apache/jackrabbit-oak/pull/497#discussion_r811133325



##
File path: oak-doc/src/site/markdown/query/elastic.md
##
@@ -0,0 +1,47 @@
+
+
+## Elastic Index
+
+Oak supports Elasticsearch (Elastic for short) based indexes to support 
+both property constraint and full text constraints. 
+Elastic indexes support similar features than [Lucene][lucene] indexes, 
+however there are differences:
+
+* The `type` is `elastic`.
+* The index definition needs to be under `/oak:index`.
+  Other locations are not supported.
+* The `async` property needs to be set to `async`. 
+  Synchronous, `nrt` or other lanes are not supported.
+  Indexes are updated asynchronously.
+* `refresh` is ignored.
+  Changes take effect immediately after changing them.
+  Existing documents in Elasticsearch are not changed.
+* `reindex` is ignored.

Review comment:
   what do you mean this is ignored? It's the only way to build an ES index 
after deploying the index definition.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] chibulcuteanu commented on a change in pull request #497: OAK-9699 Document Elastic Indexes

[GitBox]

chibulcuteanu commented on a change in pull request #497:
URL: https://github.com/apache/jackrabbit-oak/pull/497#discussion_r811132779



##
File path: oak-doc/src/site/markdown/query/elastic.md
##
@@ -0,0 +1,47 @@
+
+
+## Elastic Index
+
+Oak supports Elasticsearch (Elastic for short) based indexes to support 
+both property constraint and full text constraints. 
+Elastic indexes support similar features than [Lucene][lucene] indexes, 
+however there are differences:
+
+* The `type` is `elastic`.
+* The index definition needs to be under `/oak:index`.
+  Other locations are not supported.
+* The `async` property needs to be set to `async`. 
+  Synchronous, `nrt` or other lanes are not supported.
+  Indexes are updated asynchronously.
+* `refresh` is ignored.
+  Changes take effect immediately after changing them.
+  Existing documents in Elasticsearch are not changed.
+* `reindex` is ignored.
+  Indexes are automatically built when needed.
+  We recommend to build then using the `oak-run` tool.

Review comment:
   ```suggestion
 Indexes are NOT automatically built when needed. They can be build by 
setting the `reindex` property to `true` or by using the `oak-run` tool.
 We recommend to build them using the `oak-run` tool.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] chibulcuteanu commented on a change in pull request #497: OAK-9699 Document Elastic Indexes

[GitBox]

chibulcuteanu commented on a change in pull request #497:
URL: https://github.com/apache/jackrabbit-oak/pull/497#discussion_r811129073



##
File path: oak-doc/src/site/markdown/query/elastic.md
##
@@ -0,0 +1,47 @@
+
+
+## Elastic Index
+
+Oak supports Elasticsearch (Elastic for short) based indexes to support 
+both property constraint and full text constraints. 

Review comment:
   ```suggestion
   Oak supports Elasticsearch (Elastic for short) based indexes for both 
property constraint and full text constraints. 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #497: OAK-9699 Document Elastic Indexes

[GitBox]

nit0906 commented on a change in pull request #497:
URL: https://github.com/apache/jackrabbit-oak/pull/497#discussion_r86291



##
File path: oak-doc/src/site/markdown/query/elastic.md
##
@@ -0,0 +1,47 @@
+
+
+## Elastic Index
+
+Oak supports Elasticsearch (Elastic for short) based indexes to support 
+both property constraint and full text constraints. 
+Elastic indexes support similar features than [Lucene][lucene] indexes, 
+however there are differences:
+
+* The `type` is `elastic`.
+* The index definition needs to be under `/oak:index`.
+  Other locations are not supported.
+* The `async` property needs to be set to `async`. 
+  Synchronous, `nrt` or other lanes are not supported.
+  Indexes are updated asynchronously.
+* `refresh` is ignored.
+  Changes take effect immediately after changing them.
+  Existing documents in Elasticsearch are not changed.
+* `reindex` is ignored.
+  Indexes are automatically built when needed.
+  We recommend to build then using the `oak-run` tool.

Review comment:
   build them*




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #497: OAK-9699 Document Elastic Indexes

[GitBox]

nit0906 commented on a change in pull request #497:
URL: https://github.com/apache/jackrabbit-oak/pull/497#discussion_r85531



##
File path: oak-doc/src/site/markdown/query/elastic.md
##
@@ -0,0 +1,47 @@
+
+
+## Elastic Index
+
+Oak supports Elasticsearch (Elastic for short) based indexes to support 
+both property constraint and full text constraints. 
+Elastic indexes support similar features than [Lucene][lucene] indexes, 
+however there are differences:
+
+* The `type` is `elastic`.
+* The index definition needs to be under `/oak:index`.
+  Other locations are not supported.
+* The `async` property needs to be set to `async`. 

Review comment:
   The `async` property needs to be set to `async`.  --> The `async` 
property needs to be set to `elastic-async`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #497: OAK-9699 Document Elastic Indexes

[GitBox]

nit0906 commented on a change in pull request #497:
URL: https://github.com/apache/jackrabbit-oak/pull/497#discussion_r84790



##
File path: oak-doc/src/site/markdown/query/elastic.md
##
@@ -0,0 +1,47 @@
+
+
+## Elastic Index
+
+Oak supports Elasticsearch (Elastic for short) based indexes to support 
+both property constraint and full text constraints. 
+Elastic indexes support similar features than [Lucene][lucene] indexes, 
+however there are differences:
+
+* The `type` is `elastic`.

Review comment:
   elasticsearch instead of elastic.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #497: OAK-9699 Document Elastic Indexes

[GitBox]

nit0906 commented on a change in pull request #497:
URL: https://github.com/apache/jackrabbit-oak/pull/497#discussion_r84334



##
File path: oak-doc/src/site/markdown/query/elastic.md
##
@@ -0,0 +1,47 @@
+
+
+## Elastic Index
+
+Oak supports Elasticsearch (Elastic for short) based indexes to support 
+both property constraint and full text constraints. 
+Elastic indexes support similar features than [Lucene][lucene] indexes, 

Review comment:
   similar features **than** [Lucene][lucene] --> similar features **as** 
[Lucene][lucene]




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Planned release date for FileVault 3.6.0

[Robert Munteanu]

Hi,

Is there an ETA for FileVault 3.6.0? I would like to consume JCRVLT-357
[1] for an upcoming Sling task [2].

Thanks,
Robert

[1]: https://issues.apache.org/jira/browse/JCRVLT-357
[2]: https://issues.apache.org/jira/browse/SLING-11134

[GitHub] [jackrabbit] woonsan commented on pull request #96: JCR-4766: correct json response content type

[GitBox]

woonsan commented on pull request #96:
URL: https://github.com/apache/jackrabbit/pull/96#issuecomment-1046815863


   Hello @reschke ,
   Would you mind reviewing this bug fix?
   Thanks in advance,
   Woonsan


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (JCR-4766) JcrRemotingServlet should write application/json content for JSON response

[Woonsan Ko (Jira)]

[ 
https://issues.apache.org/jira/browse/JCR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495495#comment-17495495
 ] 

Woonsan Ko commented on JCR-4766:
-

PR ready for review: https://github.com/apache/jackrabbit/pull/96

> JcrRemotingServlet should write application/json content for JSON response
> --
>
> Key: JCR-4766
> URL: https://issues.apache.org/jira/browse/JCR-4766
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: jackrabbit-jcr-server
>Affects Versions: 2.21.10
>Reporter: Woonsan Ko
>Priority: Minor
>
> When retrieving a JCR node using JSON binding like the following by appending 
> '.json' to the path, the content-type of the response should have been 
> {{application/json}}, instead of the current {{text/plain;charset=utf-8}}.
> {{GET http://localhost:8080/server/default/jcr:root/hello.json}}
> Reproduction:
> - Create a node (e.g, hello) like the following (excerpt from [1]):
> {code}
> $ curl --request MKCOL --data @- --user name:pass \
>http://localhost:8080/server/default/jcr:root/hello/ < http://www.jcp.org/jcr/sv/1.0;>
>   
> Hello, World!
>   
>   
> 2022-01-15T12:00:00.000Z
>   
> 
> END
> {code}
> - Retrieve the node by JSON binding:
> {code}
> $ curl -i --user admin:admin 
> http://localhost:8080/server/default/jcr:root/hello.json
> {code}
> - The {{Content-Type}} response header should be "application/json" or one of 
> its compatibles.
>   But the actual value is "text/plain;charset=utf-8".
> [1] https://jukkaz.wordpress.com/2009/11/24/jackrabbit-over-http/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [jackrabbit-filevault] kwin opened a new pull request #211: JCRVLT-357 add method to DocViewParser for converting file name to root

[GitBox]

kwin opened a new pull request #211:
URL: https://github.com/apache/jackrabbit-filevault/pull/211


   node path


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #492: OAK-9690 | Adding bringIndexUptoDate support for elastic index post offline reindexing

[GitBox]

nit0906 commented on a change in pull request #492:
URL: https://github.com/apache/jackrabbit-oak/pull/492#discussion_r810975450



##
File path: 
oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticIndexCommand.java
##
@@ -137,9 +136,10 @@ private void execute(NodeStoreFixture fixture, 
ElasticIndexOptions indexOpts, Cl
 //dumpIndexStats(indexOpts, indexHelper);
 //dumpIndexDefinitions(indexOpts, indexHelper);
 reindexOperation(indexOpts, indexHelper);
-// This will not work with --doc-traversal mode, since that only works 
with read only mode and apply index def needs read write mode
-// read write requirement - logic handled in applyIndexDefOperation
-applyIndexDefOperation(indexOpts, indexHelper);
+
+// For elastic implementation - this applies the newly created elastic 
defintion to the repo and brings the index up to date with the

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] nit0906 commented on a change in pull request #492: OAK-9690 | Adding bringIndexUptoDate support for elastic index post offline reindexing

[GitBox]

nit0906 commented on a change in pull request #492:
URL: https://github.com/apache/jackrabbit-oak/pull/492#discussion_r810975104



##
File path: 
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexerSupport.java
##
@@ -119,7 +119,7 @@ private void updateIndexDefinitions(NodeBuilder 
rootBuilder) throws IOException,
 }
 }
 
-private void dumpIndexDefinitions(NodeStore nodeStore) throws IOException, 
CommitFailedException {
+protected void dumpIndexDefinitions(NodeStore nodeStore) throws 
IOException, CommitFailedException {

Review comment:
   done

##
File path: 
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexerSupport.java
##
@@ -150,7 +150,7 @@ public void postIndexWork(NodeStore copyOnWriteStore) 
throws CommitFailedExcepti
 dumpIndexDefinitions(copyOnWriteStore);
 }
 
-private void switchIndexLanesBack(NodeStore copyOnWriteStore) throws 
CommitFailedException, IOException {
+protected void switchIndexLanesBack(NodeStore copyOnWriteStore) throws 
CommitFailedException, IOException {

Review comment:
   done

##
File path: 
oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticIndexCommand.java
##
@@ -31,7 +31,6 @@
 import org.apache.jackrabbit.oak.plugins.commit.AnnotatingConflictHandler;
 import org.apache.jackrabbit.oak.plugins.commit.ConflictHook;
 import org.apache.jackrabbit.oak.plugins.commit.ConflictValidatorProvider;
-import org.apache.jackrabbit.oak.plugins.index.elastic.ElasticIndexDefinition;
 import org.apache.jackrabbit.oak.plugins.index.importer.IndexDefinitionUpdater;
 import org.apache.jackrabbit.oak.run.cli.CommonOptions;
 import org.apache.jackrabbit.oak.run.cli.NodeStoreFixture;

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jackrabbit-oak] fabriziofortino commented on a change in pull request #492: OAK-9690 | Adding bringIndexUptoDate support for elastic index post offline reindexing

[GitBox]

fabriziofortino commented on a change in pull request #492:
URL: https://github.com/apache/jackrabbit-oak/pull/492#discussion_r810119882



##
File path: 
oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticIndexCommand.java
##
@@ -137,9 +136,10 @@ private void execute(NodeStoreFixture fixture, 
ElasticIndexOptions indexOpts, Cl
 //dumpIndexStats(indexOpts, indexHelper);
 //dumpIndexDefinitions(indexOpts, indexHelper);
 reindexOperation(indexOpts, indexHelper);
-// This will not work with --doc-traversal mode, since that only works 
with read only mode and apply index def needs read write mode
-// read write requirement - logic handled in applyIndexDefOperation
-applyIndexDefOperation(indexOpts, indexHelper);
+
+// For elastic implementation - this applies the newly created elastic 
defintion to the repo and brings the index up to date with the

Review comment:
   typo
   ```suggestion
   // For elastic implementation - this applies the newly created 
elastic definition to the repo and brings the index up to date with the
   ```

##
File path: 
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexerSupport.java
##
@@ -119,7 +119,7 @@ private void updateIndexDefinitions(NodeBuilder 
rootBuilder) throws IOException,
 }
 }
 
-private void dumpIndexDefinitions(NodeStore nodeStore) throws IOException, 
CommitFailedException {
+protected void dumpIndexDefinitions(NodeStore nodeStore) throws 
IOException, CommitFailedException {

Review comment:
   `CommitFailedException` is never thrown here. I would remove it.

##
File path: 
oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticIndexCommand.java
##
@@ -31,7 +31,6 @@
 import org.apache.jackrabbit.oak.plugins.commit.AnnotatingConflictHandler;
 import org.apache.jackrabbit.oak.plugins.commit.ConflictHook;
 import org.apache.jackrabbit.oak.plugins.commit.ConflictValidatorProvider;
-import org.apache.jackrabbit.oak.plugins.index.elastic.ElasticIndexDefinition;
 import org.apache.jackrabbit.oak.plugins.index.importer.IndexDefinitionUpdater;
 import org.apache.jackrabbit.oak.run.cli.CommonOptions;
 import org.apache.jackrabbit.oak.run.cli.NodeStoreFixture;

Review comment:
   `import org.apache.jackrabbit.oak.spi.state.NodeState;` (line 49) can be 
removed

##
File path: 
oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/ElasticIndexCommand.java
##
@@ -216,33 +207,25 @@ private void reindex(ElasticIndexOptions indexOpts, 
IndexHelper indexHelper, Str
 indexOpts.getElasticScheme(), indexOpts.getElasticHost(),
 indexOpts.getElasticPort(), indexOpts.getApiKeyId(), 
indexOpts.getApiKeySecret())) {
 indexer.reindex();
-// Wait for default flush interval before exiting the try block
-// to make sure the client is not closed before the last flush
-// TODO : See if this can be handled in a better manner
-
Thread.sleep(ElasticIndexDefinition.BULK_FLUSH_INTERVAL_MS_DEFAULT * 2);

Review comment:
   +1  

##
File path: 
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexerSupport.java
##
@@ -150,7 +150,7 @@ public void postIndexWork(NodeStore copyOnWriteStore) 
throws CommitFailedExcepti
 dumpIndexDefinitions(copyOnWriteStore);
 }
 
-private void switchIndexLanesBack(NodeStore copyOnWriteStore) throws 
CommitFailedException, IOException {
+protected void switchIndexLanesBack(NodeStore copyOnWriteStore) throws 
CommitFailedException, IOException {

Review comment:
   `IOException` never thrown here. I would remove it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (JCR-4766) JcrRemotingServlet should write application/json content for JSON response

[Woonsan Ko (Jira)]

 [ 
https://issues.apache.org/jira/browse/JCR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Woonsan Ko updated JCR-4766:

Description: 
When retrieving a JCR node using JSON binding like the following by appending 
'.json' to the path, the content-type of the response should have been 
{{application/json}}, instead of the current {{text/plain;charset=utf-8}}.

{{GET http://localhost:8080/server/default/jcr:root/hello.json}}

Reproduction:
- Create a node (e.g, hello) like the following (excerpt from [1]):
{code}
$ curl --request MKCOL --data @- --user name:pass \
   http://localhost:8080/server/default/jcr:root/hello/ 
  
Hello, World!
  
  
2022-01-15T12:00:00.000Z
  

END
{code}
- Retrieve the node by JSON binding:
{code}
$ curl -i --user admin:admin 
http://localhost:8080/server/default/jcr:root/hello.json
{code}
- The {{Content-Type}} response header should be "application/json" or one of 
its compatibles.
  But the actual value is "text/plain;charset=utf-8".

[1] https://jukkaz.wordpress.com/2009/11/24/jackrabbit-over-http/

  was:
When retrieving a JCR node using JSON binding like the following by appending 
'.json' to the path, the content-type of the response should have been 
{{application/json}}, instead of the current {{text/plain;charset=utf-8}}.

{{GET http://localhost:8080/server/default/jcr:root/hello.json}}

Reproduction:
- Create a node (e.g, hello) like the following (excerpt from [1]):
{code}
$ curl --request MKCOL --data @- --user name:pass \
   http://localhost:8080/server/default/jcr:root/hello/ 
  
Hello, World!
  
  
2022-01-15T12:00:00.000Z
  

END
{code}
- Retrieve the node by JSON binding:
{code}
$ curl -i --user admin:admin 
http://localhost:8080/server/default/jcr:root/hello.json
{code}
- The {{Content-Type}} response header should be "application/json" or one of 
its compatibles.

[1] https://jukkaz.wordpress.com/2009/11/24/jackrabbit-over-http/


> JcrRemotingServlet should write application/json content for JSON response
> --
>
> Key: JCR-4766
> URL: https://issues.apache.org/jira/browse/JCR-4766
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: jackrabbit-jcr-server
>Affects Versions: 2.21.10
>Reporter: Woonsan Ko
>Priority: Minor
>
> When retrieving a JCR node using JSON binding like the following by appending 
> '.json' to the path, the content-type of the response should have been 
> {{application/json}}, instead of the current {{text/plain;charset=utf-8}}.
> {{GET http://localhost:8080/server/default/jcr:root/hello.json}}
> Reproduction:
> - Create a node (e.g, hello) like the following (excerpt from [1]):
> {code}
> $ curl --request MKCOL --data @- --user name:pass \
>http://localhost:8080/server/default/jcr:root/hello/ < http://www.jcp.org/jcr/sv/1.0;>
>   
> Hello, World!
>   
>   
> 2022-01-15T12:00:00.000Z
>   
> 
> END
> {code}
> - Retrieve the node by JSON binding:
> {code}
> $ curl -i --user admin:admin 
> http://localhost:8080/server/default/jcr:root/hello.json
> {code}
> - The {{Content-Type}} response header should be "application/json" or one of 
> its compatibles.
>   But the actual value is "text/plain;charset=utf-8".
> [1] https://jukkaz.wordpress.com/2009/11/24/jackrabbit-over-http/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (JCR-4766) JcrRemotingServlet should write application/json content for JSON response

[Woonsan Ko (Jira)]

 [ 
https://issues.apache.org/jira/browse/JCR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Woonsan Ko updated JCR-4766:

Description: 
When retrieving a JCR node using JSON binding like the following by appending 
'.json' to the path, the content-type of the response should have been 
{{application/json}}, instead of the current {{text/plain;charset=utf-8}}.

{{GET http://localhost:8080/server/default/jcr:root/hello.json}}

Reproduction:
- Create a node (e.g, hello) like the following (excerpt from [1]):
{code}
$ curl --request MKCOL --data @- --user name:pass \
   http://localhost:8080/server/default/jcr:root/hello/ 
  
Hello, World!
  
  
2022-01-15T12:00:00.000Z
  

END
{code}
- Retrieve the node by JSON binding:
{code}
$ curl --user name:pass http://localhost:8080/server/default/jcr:root/hello.json
{code}
- The {{Content-Type}} response header should be "application/json" or one of 
its compatibles.

[1] https://jukkaz.wordpress.com/2009/11/24/jackrabbit-over-http/

  was:
When retrieving a JCR node using JSON binding like the following by appending 
'.json' to the path, the content-type of the response should have been 
{{application/json}}, instead of the current {{text/plain;charset=utf-8}}.

{{GET http://localhost:8080/server/default/jcr:root/hello.json}}



> JcrRemotingServlet should write application/json content for JSON response
> --
>
> Key: JCR-4766
> URL: https://issues.apache.org/jira/browse/JCR-4766
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: jackrabbit-jcr-server
>Affects Versions: 2.21.10
>Reporter: Woonsan Ko
>Priority: Minor
>
> When retrieving a JCR node using JSON binding like the following by appending 
> '.json' to the path, the content-type of the response should have been 
> {{application/json}}, instead of the current {{text/plain;charset=utf-8}}.
> {{GET http://localhost:8080/server/default/jcr:root/hello.json}}
> Reproduction:
> - Create a node (e.g, hello) like the following (excerpt from [1]):
> {code}
> $ curl --request MKCOL --data @- --user name:pass \
>http://localhost:8080/server/default/jcr:root/hello/ < http://www.jcp.org/jcr/sv/1.0;>
>   
> Hello, World!
>   
>   
> 2022-01-15T12:00:00.000Z
>   
> 
> END
> {code}
> - Retrieve the node by JSON binding:
> {code}
> $ curl --user name:pass 
> http://localhost:8080/server/default/jcr:root/hello.json
> {code}
> - The {{Content-Type}} response header should be "application/json" or one of 
> its compatibles.
> [1] https://jukkaz.wordpress.com/2009/11/24/jackrabbit-over-http/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (JCR-4766) JcrRemotingServlet should write application/json content for JSON response

[Woonsan Ko (Jira)]

 [ 
https://issues.apache.org/jira/browse/JCR-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Woonsan Ko updated JCR-4766:

Description: 
When retrieving a JCR node using JSON binding like the following by appending 
'.json' to the path, the content-type of the response should have been 
{{application/json}}, instead of the current {{text/plain;charset=utf-8}}.

{{GET http://localhost:8080/server/default/jcr:root/hello.json}}

Reproduction:
- Create a node (e.g, hello) like the following (excerpt from [1]):
{code}
$ curl --request MKCOL --data @- --user name:pass \
   http://localhost:8080/server/default/jcr:root/hello/ 
  
Hello, World!
  
  
2022-01-15T12:00:00.000Z
  

END
{code}
- Retrieve the node by JSON binding:
{code}
$ curl -i --user admin:admin 
http://localhost:8080/server/default/jcr:root/hello.json
{code}
- The {{Content-Type}} response header should be "application/json" or one of 
its compatibles.

[1] https://jukkaz.wordpress.com/2009/11/24/jackrabbit-over-http/

  was:
When retrieving a JCR node using JSON binding like the following by appending 
'.json' to the path, the content-type of the response should have been 
{{application/json}}, instead of the current {{text/plain;charset=utf-8}}.

{{GET http://localhost:8080/server/default/jcr:root/hello.json}}

Reproduction:
- Create a node (e.g, hello) like the following (excerpt from [1]):
{code}
$ curl --request MKCOL --data @- --user name:pass \
   http://localhost:8080/server/default/jcr:root/hello/ 
  
Hello, World!
  
  
2022-01-15T12:00:00.000Z
  

END
{code}
- Retrieve the node by JSON binding:
{code}
$ curl --user name:pass http://localhost:8080/server/default/jcr:root/hello.json
{code}
- The {{Content-Type}} response header should be "application/json" or one of 
its compatibles.

[1] https://jukkaz.wordpress.com/2009/11/24/jackrabbit-over-http/


> JcrRemotingServlet should write application/json content for JSON response
> --
>
> Key: JCR-4766
> URL: https://issues.apache.org/jira/browse/JCR-4766
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>  Components: jackrabbit-jcr-server
>Affects Versions: 2.21.10
>Reporter: Woonsan Ko
>Priority: Minor
>
> When retrieving a JCR node using JSON binding like the following by appending 
> '.json' to the path, the content-type of the response should have been 
> {{application/json}}, instead of the current {{text/plain;charset=utf-8}}.
> {{GET http://localhost:8080/server/default/jcr:root/hello.json}}
> Reproduction:
> - Create a node (e.g, hello) like the following (excerpt from [1]):
> {code}
> $ curl --request MKCOL --data @- --user name:pass \
>http://localhost:8080/server/default/jcr:root/hello/ < http://www.jcp.org/jcr/sv/1.0;>
>   
> Hello, World!
>   
>   
> 2022-01-15T12:00:00.000Z
>   
> 
> END
> {code}
> - Retrieve the node by JSON binding:
> {code}
> $ curl -i --user admin:admin 
> http://localhost:8080/server/default/jcr:root/hello.json
> {code}
> - The {{Content-Type}} response header should be "application/json" or one of 
> its compatibles.
> [1] https://jukkaz.wordpress.com/2009/11/24/jackrabbit-over-http/



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (JCR-4766) JcrRemotingServlet should write application/json content for JSON response

[Woonsan Ko (Jira)]

Woonsan Ko created JCR-4766:
---

 Summary: JcrRemotingServlet should write application/json content 
for JSON response
 Key: JCR-4766
 URL: https://issues.apache.org/jira/browse/JCR-4766
 Project: Jackrabbit Content Repository
  Issue Type: Bug
  Components: jackrabbit-jcr-server
Affects Versions: 2.21.10
Reporter: Woonsan Ko


When retrieving a JCR node using JSON binding like the following by appending 
'.json' to the path, the content-type of the response should have been 
{{application/json}}, instead of the current {{text/plain;charset=utf-8}}.

{{GET http://localhost:8080/server/default/jcr:root/hello.json}}




--
This message was sent by Atlassian Jira
(v8.20.1#820001)