[jira] [Comment Edited] (JCRVLT-359) Provide separate option to control handling of rep:cugPolicy nodes.
[ https://issues.apache.org/jira/browse/JCRVLT-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921777#comment-16921777 ] Alexei Krainiouk edited comment on JCRVLT-359 at 9/4/19 12:20 AM: -- [~tripod] Added [unit tests|https://github.com/apache/jackrabbit-filevault/pull/56/commits/6fafa8afbfc4fb4d6de7262bedc7cf15f5bc30a0] for cugHandling. As far as I understand for CUG case [MERGE|https://github.com/apache/jackrabbit-filevault/blob/c6a8b816a31f3347113b8a8d4eac281faf0a6d5b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.java#L65] and [MERGE_PRESERVE|https://github.com/apache/jackrabbit-filevault/blob/c6a8b816a31f3347113b8a8d4eac281faf0a6d5b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.java#L97] are essentially the same. I.E. in both cases the resulting principal list is a union of pre-existing principals and those that come in the package. Please correct me if I am wrong. was (Author: akrainiouk): [~tripod] Added [unit tests|https://github.com/apache/jackrabbit-filevault/pull/56/commits/6fafa8afbfc4fb4d6de7262bedc7cf15f5bc30a0] for cugHandling. As far as I understand for CUG case [AccessControlHandling.MERGE|https://github.com/apache/jackrabbit-filevault/blob/c6a8b816a31f3347113b8a8d4eac281faf0a6d5b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.java#L65] and [AccessControlHandling.MERGE_PRESERVE|https://github.com/apache/jackrabbit-filevault/blob/c6a8b816a31f3347113b8a8d4eac281faf0a6d5b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.java#L97] are essentially the same. I.E. in both cases the resulting principal list is a union of pre-existing principals and those that come in the package. Please correct me if I am wrong. > Provide separate option to control handling of rep:cugPolicy nodes. > --- > > Key: JCRVLT-359 > URL: https://issues.apache.org/jira/browse/JCRVLT-359 > Project: Jackrabbit FileVault > Issue Type: Bug > Components: vlt >Affects Versions: 3.2.8 >Reporter: Alexei Krainiouk >Priority: Major > > Currently handling of rep:cugPolicy nodes is controlled by aclHandling > configuration option that equally affects ACLs and CUGs. We need to control > them separately as for replication that is based on sling-distribution we > need to ignore ACLs while overwriting CUGs -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Comment Edited] (JCRVLT-359) Provide separate option to control handling of rep:cugPolicy nodes.
[ https://issues.apache.org/jira/browse/JCRVLT-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921777#comment-16921777 ] Alexei Krainiouk edited comment on JCRVLT-359 at 9/4/19 12:19 AM: -- [~tripod] Added [unit tests|https://github.com/apache/jackrabbit-filevault/pull/56/commits/6fafa8afbfc4fb4d6de7262bedc7cf15f5bc30a0] for cugHandling. As far as I understand for CUG case [AccessControlHandling.MERGE|https://github.com/apache/jackrabbit-filevault/blob/c6a8b816a31f3347113b8a8d4eac281faf0a6d5b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.java#L65] and [AccessControlHandling.MERGE_PRESERVE|https://github.com/apache/jackrabbit-filevault/blob/c6a8b816a31f3347113b8a8d4eac281faf0a6d5b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.java#L97] are essentially the same. Please correct me if I am wrong. I.E. in both cases the resulting principal list is a union of pre-existing principals and those that come in the package. was (Author: akrainiouk): Added [unit tests|https://github.com/apache/jackrabbit-filevault/pull/56/commits/6fafa8afbfc4fb4d6de7262bedc7cf15f5bc30a0] for cugHandling. > Provide separate option to control handling of rep:cugPolicy nodes. > --- > > Key: JCRVLT-359 > URL: https://issues.apache.org/jira/browse/JCRVLT-359 > Project: Jackrabbit FileVault > Issue Type: Bug > Components: vlt >Affects Versions: 3.2.8 >Reporter: Alexei Krainiouk >Priority: Major > > Currently handling of rep:cugPolicy nodes is controlled by aclHandling > configuration option that equally affects ACLs and CUGs. We need to control > them separately as for replication that is based on sling-distribution we > need to ignore ACLs while overwriting CUGs -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Comment Edited] (JCRVLT-359) Provide separate option to control handling of rep:cugPolicy nodes.
[ https://issues.apache.org/jira/browse/JCRVLT-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921777#comment-16921777 ] Alexei Krainiouk edited comment on JCRVLT-359 at 9/4/19 12:19 AM: -- [~tripod] Added [unit tests|https://github.com/apache/jackrabbit-filevault/pull/56/commits/6fafa8afbfc4fb4d6de7262bedc7cf15f5bc30a0] for cugHandling. As far as I understand for CUG case [AccessControlHandling.MERGE|https://github.com/apache/jackrabbit-filevault/blob/c6a8b816a31f3347113b8a8d4eac281faf0a6d5b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.java#L65] and [AccessControlHandling.MERGE_PRESERVE|https://github.com/apache/jackrabbit-filevault/blob/c6a8b816a31f3347113b8a8d4eac281faf0a6d5b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.java#L97] are essentially the same. I.E. in both cases the resulting principal list is a union of pre-existing principals and those that come in the package. Please correct me if I am wrong. was (Author: akrainiouk): [~tripod] Added [unit tests|https://github.com/apache/jackrabbit-filevault/pull/56/commits/6fafa8afbfc4fb4d6de7262bedc7cf15f5bc30a0] for cugHandling. As far as I understand for CUG case [AccessControlHandling.MERGE|https://github.com/apache/jackrabbit-filevault/blob/c6a8b816a31f3347113b8a8d4eac281faf0a6d5b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.java#L65] and [AccessControlHandling.MERGE_PRESERVE|https://github.com/apache/jackrabbit-filevault/blob/c6a8b816a31f3347113b8a8d4eac281faf0a6d5b/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.java#L97] are essentially the same. Please correct me if I am wrong. I.E. in both cases the resulting principal list is a union of pre-existing principals and those that come in the package. > Provide separate option to control handling of rep:cugPolicy nodes. > --- > > Key: JCRVLT-359 > URL: https://issues.apache.org/jira/browse/JCRVLT-359 > Project: Jackrabbit FileVault > Issue Type: Bug > Components: vlt >Affects Versions: 3.2.8 >Reporter: Alexei Krainiouk >Priority: Major > > Currently handling of rep:cugPolicy nodes is controlled by aclHandling > configuration option that equally affects ACLs and CUGs. We need to control > them separately as for replication that is based on sling-distribution we > need to ignore ACLs while overwriting CUGs -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (JCRVLT-359) Provide separate option to control handling of rep:cugPolicy nodes.
[ https://issues.apache.org/jira/browse/JCRVLT-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921777#comment-16921777 ] Alexei Krainiouk commented on JCRVLT-359: - Added [unit tests|https://github.com/apache/jackrabbit-filevault/pull/56/commits/6fafa8afbfc4fb4d6de7262bedc7cf15f5bc30a0] for cugHandling. > Provide separate option to control handling of rep:cugPolicy nodes. > --- > > Key: JCRVLT-359 > URL: https://issues.apache.org/jira/browse/JCRVLT-359 > Project: Jackrabbit FileVault > Issue Type: Bug > Components: vlt >Affects Versions: 3.2.8 >Reporter: Alexei Krainiouk >Priority: Major > > Currently handling of rep:cugPolicy nodes is controlled by aclHandling > configuration option that equally affects ACLs and CUGs. We need to control > them separately as for replication that is based on sling-distribution we > need to ignore ACLs while overwriting CUGs -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Comment Edited] (JCRVLT-359) Provide separate option to control handling of rep:cugPolicy nodes.
[ https://issues.apache.org/jira/browse/JCRVLT-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920522#comment-16920522 ] Alexei Krainiouk edited comment on JCRVLT-359 at 9/1/19 10:39 PM: -- [~tripod] rep:cugPolicy nodes are serialized into a package just fine. This is not a problem. The problem is in de-serialization (installation) of ACL nodes, which is entirely controlled by aclHandling. And we need more fine grained control. For replication we need rep:cugPolicy nodes handled differently from other ACL nodes and this is why separate configuration (cugHandling) option is proposed. For backwards compatibility when cugHandling policy is set to null (the default) deserialization of all ACL nodes is controlled by aclHandling as before. I have created a [pull request|https://github.com/apache/jackrabbit-filevault/pull/56] that implements this idea. was (Author: akrainiouk): [~tripod] rep:cugPolicy nodes are serialized into a package just fine. This is not a problem. The problem in de-serialization (installation), which is controlled by aclHandling which applies equally to all policy nodes. For replication we need rep:cugPolicy nodes handled differently from other ACL nodes and this is why separate configuration (cugHandling) option is proposed. For backwards compatibility when cugHandling policy is set to null (the default) deserialization of all ACL nodes is controlled by aclHandling as before. I have created a [pull request|https://github.com/apache/jackrabbit-filevault/pull/56] that implements this idea. > Provide separate option to control handling of rep:cugPolicy nodes. > --- > > Key: JCRVLT-359 > URL: https://issues.apache.org/jira/browse/JCRVLT-359 > Project: Jackrabbit FileVault > Issue Type: Bug > Components: vlt >Affects Versions: 3.2.8 >Reporter: Alexei Krainiouk >Priority: Major > > Currently handling of rep:cugPolicy nodes is controlled by aclHandling > configuration option that equally affects ACLs and CUGs. We need to control > them separately as for replication that is based on sling-distribution we > need to ignore ACLs while overwriting CUGs -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (JCRVLT-359) Provide separate option to control handling of rep:cugPolicy nodes.
[ https://issues.apache.org/jira/browse/JCRVLT-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920522#comment-16920522 ] Alexei Krainiouk commented on JCRVLT-359: - [~tripod] rep:cugPolicy nodes are serialized into a package just fine. This is not a problem. The problem in de-serialization (installation), which is controlled by aclHandling which applies equally to all policy nodes. For replication we need rep:cugPolicy nodes handled differently from other ACL nodes and this is why separate configuration (cugHandling) option is proposed. For backwards compatibility when cugHandling policy is set to null (the default) deserialization of all ACL nodes is controlled by aclHandling as before. I have created a [pull request|https://github.com/apache/jackrabbit-filevault/pull/56] that implements this idea. > Provide separate option to control handling of rep:cugPolicy nodes. > --- > > Key: JCRVLT-359 > URL: https://issues.apache.org/jira/browse/JCRVLT-359 > Project: Jackrabbit FileVault > Issue Type: Bug > Components: vlt >Affects Versions: 3.2.8 >Reporter: Alexei Krainiouk >Priority: Major > > Currently handling of rep:cugPolicy nodes is controlled by aclHandling > configuration option that equally affects ACLs and CUGs. We need to control > them separately as for replication that is based on sling-distribution we > need to ignore ACLs while overwriting CUGs -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (JCRVLT-359) Provide separate option to control handling of rep:cugPolicy nodes.
[ https://issues.apache.org/jira/browse/JCRVLT-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexei Krainiouk updated JCRVLT-359: Description: Currently handling of rep:cugPolicy nodes is controlled by aclHandling configuration option that equally affects ACLs and CUGs. We need to control them separately as for replication that is based on sling-distribution we need to ignore ACLs while overwriting CUGs > Provide separate option to control handling of rep:cugPolicy nodes. > --- > > Key: JCRVLT-359 > URL: https://issues.apache.org/jira/browse/JCRVLT-359 > Project: Jackrabbit FileVault > Issue Type: Bug > Components: vlt >Affects Versions: 3.2.8 >Reporter: Alexei Krainiouk >Priority: Major > > Currently handling of rep:cugPolicy nodes is controlled by aclHandling > configuration option that equally affects ACLs and CUGs. We need to control > them separately as for replication that is based on sling-distribution we > need to ignore ACLs while overwriting CUGs -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (JCRVLT-359) Provide separate option to control handling of rep:cugPolicy nodes.
[ https://issues.apache.org/jira/browse/JCRVLT-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexei Krainiouk updated JCRVLT-359: Summary: Provide separate option to control handling of rep:cugPolicy nodes. (was: rep:cugPolicy node is ignored when aclHandling is set to "IGNORE") > Provide separate option to control handling of rep:cugPolicy nodes. > --- > > Key: JCRVLT-359 > URL: https://issues.apache.org/jira/browse/JCRVLT-359 > Project: Jackrabbit FileVault > Issue Type: Bug > Components: vlt >Affects Versions: 3.2.8 >Reporter: Alexei Krainiouk >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (JCRVLT-359) rep:cugPolicy node is ignored when aclHandling is set to "IGNORE"
Alexei Krainiouk created JCRVLT-359: --- Summary: rep:cugPolicy node is ignored when aclHandling is set to "IGNORE" Key: JCRVLT-359 URL: https://issues.apache.org/jira/browse/JCRVLT-359 Project: Jackrabbit FileVault Issue Type: Bug Components: vlt Affects Versions: 3.2.8 Reporter: Alexei Krainiouk -- This message was sent by Atlassian Jira (v8.3.2#803003)
