[jira] Created: (JCR-1308) Unnecessary null check in EffectiveNodeType.getApplicableChildNodeDef()
Unnecessary null check in EffectiveNodeType.getApplicableChildNodeDef()
---
Key: JCR-1308
URL: https://issues.apache.org/jira/browse/JCR-1308
Project: Jackrabbit
Issue Type: Improvement
Components: jackrabbit-core
Affects Versions: 1.4
Reporter: Ed Burnette
Priority: Trivial
This is just a trivial thing I noticed this while inspecting the code.
getApplicableChildNodeDef() says:
// try named node definitions first
ItemDef[] defs = getNamedItemDefs(name);
if (defs != null) {
but getNamedItemDefs() is currently defined to not return null:
public ItemDef[] getNamedItemDefs(Name name) {
List defs = (List) namedItemDefs.get(name);
if (defs == null || defs.size() == 0) {
return ItemDef.EMPTY_ARRAY;
}
return (ItemDef[]) defs.toArray(new ItemDef[defs.size()]);
}
I didn't check to see if there were any other unnecessary null checks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (JCR-1267) Unreachable catch block for NameException in ValueConstraint.java
Unreachable catch block for NameException in ValueConstraint.java - Key: JCR-1267 URL: https://issues.apache.org/jira/browse/JCR-1267 Project: Jackrabbit Issue Type: Improvement Components: jackrabbit-jcr2spi Affects Versions: 1.4 Reporter: Ed Burnette Priority: Trivial Fix For: 1.4 Unreachable catch block for NameException. Only more specific exceptions are thrown and handled by previous catch block(s). ValueConstraint.javaline 855 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1267) Unreachable catch block for NameException in ValueConstraint.java
[ https://issues.apache.org/jira/browse/JCR-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ed Burnette updated JCR-1267: - Attachment: patch.txt Patch to fix this compiler warning. Unreachable catch block for NameException in ValueConstraint.java - Key: JCR-1267 URL: https://issues.apache.org/jira/browse/JCR-1267 Project: Jackrabbit Issue Type: Improvement Components: jackrabbit-jcr2spi Affects Versions: 1.4 Reporter: Ed Burnette Priority: Trivial Fix For: 1.4 Attachments: patch.txt Unreachable catch block for NameException. Only more specific exceptions are thrown and handled by previous catch block(s). ValueConstraint.java line 855 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-388) add support for RFC 3253 to the simple server
[ https://issues.apache.org/jira/browse/JCR-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515276 ] Ed Burnette commented on JCR-388: - Thanks! add support for RFC 3253 to the simple server - Key: JCR-388 URL: https://issues.apache.org/jira/browse/JCR-388 Project: Jackrabbit Issue Type: New Feature Components: webdav Affects Versions: 0.9 Reporter: jeremi Joslin Assignee: angela Priority: Minor Attachments: JCR-388_2007_07_19.patch, patch_16JUL07.txt, patch_16JUL07.zip, patch_rfc3253.zip, Review.txt, rfc.zip http://www.ietf.org/rfc/rfc3253.txt -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-388) add support for RFC 3253 to the simple server
[ https://issues.apache.org/jira/browse/JCR-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513950 ] Ed Burnette commented on JCR-388: - I did a smoke test on it and it seems to work for me. add support for RFC 3253 to the simple server - Key: JCR-388 URL: https://issues.apache.org/jira/browse/JCR-388 Project: Jackrabbit Issue Type: New Feature Components: webdav Affects Versions: 0.9 Reporter: jeremi Joslin Assignee: angela Priority: Minor Attachments: JCR-388_2007_07_19.patch, patch_16JUL07.txt, patch_16JUL07.zip, patch_rfc3253.zip, Review.txt, rfc.zip http://www.ietf.org/rfc/rfc3253.txt -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-388) add support for RFC 3253 to the simple server
[ https://issues.apache.org/jira/browse/JCR-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513222 ] Ed Burnette commented on JCR-388: - (Rob and I work together) I believe he created it with Eclipse Team Create Patch, in unified diff format. I was able to apply it with Eclipse by telling it to ignore one or two of the initial path components. If you need it in some other format let us know. add support for RFC 3253 to the simple server - Key: JCR-388 URL: https://issues.apache.org/jira/browse/JCR-388 Project: Jackrabbit Issue Type: New Feature Components: webdav Affects Versions: 0.9 Reporter: jeremi Joslin Assignee: angela Priority: Minor Attachments: patch_16JUL07.txt, patch_rfc3253.zip, Review.txt, rfc.zip http://www.ietf.org/rfc/rfc3253.txt -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (JCR-1033) webapp doesn't compile (use of enum keyword)
webapp doesn't compile (use of enum keyword) Key: JCR-1033 URL: https://issues.apache.org/jira/browse/JCR-1033 Project: Jackrabbit Issue Type: Bug Components: webapp Affects Versions: 1.4 Reporter: Ed Burnette AbstractConfig.java and JNDIConfig.java have local variables named 'enum' that aren't allowed when using JDK5 or later compilers. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1033) webapp doesn't compile (use of enum keyword)
[ https://issues.apache.org/jira/browse/JCR-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ed Burnette updated JCR-1033: - Attachment: j2ee.patch Trivial changes to use different variable names to make the compiler happy. webapp doesn't compile (use of enum keyword) Key: JCR-1033 URL: https://issues.apache.org/jira/browse/JCR-1033 Project: Jackrabbit Issue Type: Bug Components: webapp Affects Versions: 1.4 Reporter: Ed Burnette Attachments: j2ee.patch AbstractConfig.java and JNDIConfig.java have local variables named 'enum' that aren't allowed when using JDK5 or later compilers. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-350) WebDAV: add support for RFC 3744
[ https://issues.apache.org/jira/browse/JCR-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512968 ] Ed Burnette commented on JCR-350: - What's the status on this one? Is anybody working on an implementation? WebDAV: add support for RFC 3744 Key: JCR-350 URL: https://issues.apache.org/jira/browse/JCR-350 Project: Jackrabbit Issue Type: New Feature Components: webdav Reporter: angela Assignee: angela Priority: Minor -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-848) javacc-maven-plugin version in jackrabbit-core pom file
[ https://issues.apache.org/jira/browse/JCR-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ed Burnette updated JCR-848: Attachment: jackrabbit-core.patch Lucene had the same problem (see http://issues.apache.org/jira/browse/LUCENE-490). JavaCC 4.0 broke two of the grammar files, QueryParser.jjt, and XPath.jjt. The attached patch fixes it. javacc-maven-plugin version in jackrabbit-core pom file --- Key: JCR-848 URL: https://issues.apache.org/jira/browse/JCR-848 Project: Jackrabbit Issue Type: Bug Components: core Environment: linux desktop, normal pc, java 1.5 Reporter: Eduardo Burgos Assignee: Jukka Zitting Priority: Minor Attachments: jackrabbit-core.patch Hi, I noticed that the pom.xml file of the jackrabbit-core project needs to specify version 2.1 for the javacc-maven-plugin because if it takes the 2.2-SNAPSHOT it won't compile. I put the 2.1 version and it worked fine. plugin groupIdorg.codehaus.mojo/groupId artifactIdjavacc-maven-plugin/artifactId version2.1/version executions Im working with revision 529712 [April 17, 2007, 15:05 EST] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-388) add support for RFC 3253 to the simple server
[ https://issues.apache.org/jira/browse/JCR-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499948 ] Ed Burnette commented on JCR-388: - What's the status of this patch? add support for RFC 3253 to the simple server - Key: JCR-388 URL: https://issues.apache.org/jira/browse/JCR-388 Project: Jackrabbit Issue Type: New Feature Components: webdav Affects Versions: 0.9 Reporter: jeremi Joslin Assignee: angela Priority: Minor Attachments: patch_rfc3253.zip, Review.txt, rfc.zip http://www.ietf.org/rfc/rfc3253.txt -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
