[jira] [Comment Edited] (JCRVLT-355) False error in case embedded file/subpackage is overwritten by jcrRootSourceDirectory
[
https://issues.apache.org/jira/browse/JCRVLT-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964427#comment-16964427
]
Konrad Windszus edited comment on JCRVLT-355 at 11/3/19 3:41 PM:
-
I created JCRVLT-389 to better support that use case. As alternative you could
first copy from src to target/something with filtering and then set parameter
http://jackrabbit.apache.org/filevault-package-maven-plugin/package-mojo.html#jcrRootSourceDirectory
to that target filter.
was (Author: kwin):
I created JCRVLT-389 to better support that use case
> False error in case embedded file/subpackage is overwritten by
> jcrRootSourceDirectory
> -
>
> Key: JCRVLT-355
> URL: https://issues.apache.org/jira/browse/JCRVLT-355
> Project: Jackrabbit FileVault
> Issue Type: Bug
> Components: package maven plugin
>Affects Versions: package-maven-plugin-1.0.4
>Reporter: Stefan Seifert
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: package-maven-plugin-1.1.0
>
>
> i've found problem with the check introduced with JCRVLT-279 - or i do not
> understand why the check leads to a failure in my case.
> i've two projects where this happens:
> 1. conf-content:
> https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/master/content-packages/conf-content
> fails with:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.jackrabbit:filevault-package-maven-plugin:1.0.4:package
> (default-package) on project
> mycompany.myprojectgroup.myproject1.conf-content:
> org.apache.maven.plugin.MojoFailureException: Found duplicate files in
> content package, most probably you have overlapping filter roots or you embed
> a file which is already there in 'jcrRootSourceDirectory'. For details check
> the nested exception!: Duplicate file
> jcr_root\conf\myproject1\settings\wcm\policies was found and the duplicate
> attribute is 'fail'. {noformat}
> 2. ui.apps
> https://github.com/stefanseifert/filevault-package-maven-plugin-1.0.4-validation-issues/tree/master/content-packages/ui.apps
> fails with:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.jackrabbit:filevault-package-maven-plugin:1.0.4:package
> (default-package) on project mycompany.myprojectgroup.myproject1.ui.apps:
> org.apache.maven.plugin.MojoFailureException: Found duplicate files in
> content package, most probably you have overlapping filter roots or you embed
> a file which is already there in 'jcrRootSourceDirectory'. For details check
> the nested exception!: Duplicate file
> jcr_root\apps\epsilon65Project\clientlibs\.content.xml was found and the
> duplicate attribute is 'fail'.
> {noformat}
> the second project is a special case because in some files in the
> "clientlibs" folder placeholders are replaced using maven resource filtering,
> if the corresponding build-helper-maven-plugin definition is removed the
> build works.
> but the first project is really simple project.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (JCRVLT-355) False error in case embedded file/subpackage is overwritten by jcrRootSourceDirectory
[
https://issues.apache.org/jira/browse/JCRVLT-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948415#comment-16948415
]
Konrad Windszus edited comment on JCRVLT-355 at 10/10/19 11:59 AM:
---
This should be solved with the PR attached to JCRVLT-363.
For {{conf-content}} I now get the following (IMHO correct) output:
{code}
[INFO] --- filevault-package-maven-plugin:1.0.5-SNAPSHOT:package
(default-package) @ mycompany.myprojectgroup.myproject1.conf-content ---
[INFO] Using META-INF/vault from
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/conf-content/META-INF/vault
[INFO] Packaging content from
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/conf-content/jcr_root
[WARNING] File
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/conf-content/jcr_root/.content.xml
not covered by a filter rule and therefore not contained in the resulting
package
[INFO] Building content-package:
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/conf-content/target/myproject1-conf-content-1.0.0-SNAPSHOT.zip
[INFO]
[INFO] --- filevault-package-maven-plugin:1.0.5-SNAPSHOT:validate-package
(default-validate-package) @ mycompany.myprojectgroup.myproject1.conf-content
---
[INFO] Start validating package
'/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/conf-content/target/myproject1-conf-content-1.0.0-SNAPSHOT.zip'...
[INFO] Using 9 validators for package of type CONTENT: jackrabbit-filter
(org.apache.jackrabbit.vault.validation.spi.impl.AdvancedFilterValidator),
jackrabbit-properties
(org.apache.jackrabbit.vault.validation.spi.impl.AdvancedPropertiesValidator),
jackrabbit-docviewparser
(org.apache.jackrabbit.vault.validation.spi.impl.DocumentViewParserValidator),
jackrabbit-dependencies
(org.apache.jackrabbit.vault.validation.spi.impl.DependencyValidator),
jackrabbit-emptyelements
(org.apache.jackrabbit.vault.validation.spi.impl.EmptyElementsValidator),
jackrabbit-mergelimitations
(org.apache.jackrabbit.vault.validation.spi.impl.MergeLimitationsValidator),
jackrabbit-oakindex
(org.apache.jackrabbit.vault.validation.spi.impl.OakIndexDefinitionValidator),
jackrabbit-packagetype
(org.apache.jackrabbit.vault.validation.spi.impl.PackageTypeValidator),
jackrabbit-primarynodetype
(org.apache.jackrabbit.vault.validation.spi.impl.PrimaryNodeTypeValidator)
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor
'/conf' is not covered by any of the specified dependencies nor a valid root.",
filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor
'/conf/myproject1/settings' is not covered by any of the specified dependencies
nor a valid root.", filePath=META-INF/vault/filter.xml
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node
'/conf/myproject1/settings' is not covered by any of the filter rules.
Preferably depend on a package that provides this node or include it in the
filter rules!", filePath=jcr_root/conf/myproject1/settings/.content.xml,
nodePath=/conf/myproject1/settings, line=4
[ERROR] ValidationViolation: "jackrabbit-filter: Node
'/conf/myproject1/rep:policy/allow' is not contained in any of the filter
rules", filePath=jcr_root/conf/myproject1/_rep_policy.xml,
nodePath=/conf/myproject1/rep:policy/allow, line=7
[ERROR] ValidationViolation: "jackrabbit-filter: Node
'/conf/myproject1/rep:policy/allow2' is not contained in any of the filter
rules", filePath=jcr_root/conf/myproject1/_rep_policy.xml,
nodePath=/conf/myproject1/rep:policy/allow2, line=19
[ERROR] ValidationViolation: "jackrabbit-filter: Node
'/conf/myproject1/rep:policy/allow/rep:restrictions' is not contained in any of
the filter rules", filePath=jcr_root/conf/myproject1/_rep_policy.xml,
nodePath=/conf/myproject1/rep:policy/allow/rep:restrictions, line=10
[ERROR] ValidationViolation: "jackrabbit-filter: Node
'/conf/myproject1/rep:policy/allow1' is not contained in any of the filter
rules", filePath=jcr_root/conf/myproject1/_rep_policy.xml,
nodePath=/conf/myproject1/rep:policy/allow1, line=15
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node
'/conf/myproject1' is not covered by any of the filter rules. Preferably depend
on a package that provides this node or include it in the filter rules!",
filePath=jcr_root/conf/myproject1/.content.xml, nodePath=/conf/myproject1,
line=5
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/conf' is not
covered by any of the filter rules. Preferably depend on a package that
provides this node or include it in the filter rules!",
filePath=jcr_root/conf/.content.xml, nodePath=/conf, line=4
[INFO]
[jira] [Comment Edited] (JCRVLT-355) False error in case embedded file/subpackage is overwritten by jcrRootSourceDirectory
[
https://issues.apache.org/jira/browse/JCRVLT-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948415#comment-16948415
]
Konrad Windszus edited comment on JCRVLT-355 at 10/10/19 11:57 AM:
---
This should be solved with the PR attached to JCRVLT-363.
For {{conf-content}} I now get the following (IMHO correct) output:
{code}
[INFO] --- filevault-package-maven-plugin:1.0.5-SNAPSHOT:package
(default-package) @ mycompany.myprojectgroup.myproject1.conf-content ---
[INFO] Using META-INF/vault from
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/conf-content/META-INF/vault
[INFO] Packaging content from
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/conf-content/jcr_root
[WARNING] File
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/conf-content/jcr_root/.content.xml
not covered by a filter rule and therefore not contained in the resulting
package
[INFO] Building content-package:
/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/conf-content/target/myproject1-conf-content-1.0.0-SNAPSHOT.zip
[INFO]
[INFO] --- filevault-package-maven-plugin:1.0.5-SNAPSHOT:validate-package
(default-validate-package) @ mycompany.myprojectgroup.myproject1.conf-content
---
[INFO] Start validating package
'/Users/konradwindszus/git/filevault-package-maven-plugin-1.0.4-validation-issues/content-packages/conf-content/target/myproject1-conf-content-1.0.0-SNAPSHOT.zip'...
[INFO] Using 9 validators for package of type CONTENT: jackrabbit-filter
(org.apache.jackrabbit.vault.validation.spi.impl.AdvancedFilterValidator),
jackrabbit-properties
(org.apache.jackrabbit.vault.validation.spi.impl.AdvancedPropertiesValidator),
jackrabbit-docviewparser
(org.apache.jackrabbit.vault.validation.spi.impl.DocumentViewParserValidator),
jackrabbit-dependencies
(org.apache.jackrabbit.vault.validation.spi.impl.DependencyValidator),
jackrabbit-emptyelements
(org.apache.jackrabbit.vault.validation.spi.impl.EmptyElementsValidator),
jackrabbit-mergelimitations
(org.apache.jackrabbit.vault.validation.spi.impl.MergeLimitationsValidator),
jackrabbit-oakindex
(org.apache.jackrabbit.vault.validation.spi.impl.OakIndexDefinitionValidator),
jackrabbit-packagetype
(org.apache.jackrabbit.vault.validation.spi.impl.PackageTypeValidator),
jackrabbit-primarynodetype
(org.apache.jackrabbit.vault.validation.spi.impl.PrimaryNodeTypeValidator)
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor
'/conf' is not covered by any of the specified dependencies nor a valid root.",
filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor
'/conf/myproject1/settings' is not covered by any of the specified dependencies
nor a valid root.", filePath=META-INF/vault/filter.xml
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node
'/conf/myproject1/settings' is not covered by any of the filter rules.
Preferably depend on a package that provides this node or include it in the
filter rules!", filePath=jcr_root/conf/myproject1/settings/.content.xml,
nodePath=/conf/myproject1/settings, line=4
[ERROR] ValidationViolation: "jackrabbit-filter: Node
'/conf/myproject1/rep:policy/allow' is not contained in any of the filter
rules", filePath=jcr_root/conf/myproject1/_rep_policy.xml,
nodePath=/conf/myproject1/rep:policy/allow, line=7
[ERROR] ValidationViolation: "jackrabbit-filter: Node
'/conf/myproject1/rep:policy/allow2' is not contained in any of the filter
rules", filePath=jcr_root/conf/myproject1/_rep_policy.xml,
nodePath=/conf/myproject1/rep:policy/allow2, line=19
[ERROR] ValidationViolation: "jackrabbit-filter: Node
'/conf/myproject1/rep:policy/allow/rep:restrictions' is not contained in any of
the filter rules", filePath=jcr_root/conf/myproject1/_rep_policy.xml,
nodePath=/conf/myproject1/rep:policy/allow/rep:restrictions, line=10
[ERROR] ValidationViolation: "jackrabbit-filter: Node
'/conf/myproject1/rep:policy/allow1' is not contained in any of the filter
rules", filePath=jcr_root/conf/myproject1/_rep_policy.xml,
nodePath=/conf/myproject1/rep:policy/allow1, line=15
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node
'/conf/myproject1' is not covered by any of the filter rules. Preferably depend
on a package that provides this node or include it in the filter rules!",
filePath=jcr_root/conf/myproject1/.content.xml, nodePath=/conf/myproject1,
line=5
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/conf' is not
covered by any of the filter rules. Preferably depend on a package that
provides this node or include it in the filter rules!",
filePath=jcr_root/conf/.content.xml, nodePath=/conf, line=4
[INFO]
