[jira] [Comment Edited] (JCRVLT-443) Allow dependencies in "container" package type
[
https://issues.apache.org/jira/browse/JCRVLT-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138914#comment-17138914
]
Tobias Bocanegra edited comment on JCRVLT-443 at 6/18/20, 12:18 AM:
I think we added the import package requirements for bundles to the package,
but never implemented a validation check. since jackrabbit doesn't really know
about OSGi.
But I agree with [~dsuess] that we should not allow dependencies in container
packages.
We use to do this for a long time, and it got us in deep troubles when trying
to resolve the installation order of larger package sets.
was (Author: tripod):
I think we added the import package requirements for bundles to the package,
but never implemented a validation check. since jackrabbit doesn't really know
about OSGi.
> Allow dependencies in "container" package type
> --
>
> Key: JCRVLT-443
> URL: https://issues.apache.org/jira/browse/JCRVLT-443
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: Packaging
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> According to JCRVLT-170 {{container}} packages must not have package
> dependencies.
> Sometimes there are multiple container packages though and with the nesting
> of container packages added in JCRVLT-401 it makes sense now to add package
> dependencies also to containers (to enforce a certain order in case they are
> nested or just because at build time the dependency cannot be resolved, i.e.
> included in the container package)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (JCRVLT-443) Allow dependencies in "container" package type
[
https://issues.apache.org/jira/browse/JCRVLT-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138663#comment-17138663
]
Konrad Windszus edited comment on JCRVLT-443 at 6/17/20, 5:22 PM:
--
bq. the analysers are supposed to check the dependencies of the actual
contained artifacts and not dependencies between containers
I am not aware of any such analysers. Where are they? I need to prevent
installation of the package in the case the dependency cannot be resolved, and
the only means I know is currently effectively working for that is package
dependencies. But maybe I missed something
was (Author: kwin):
> the analysers are supposed to check the dependencies of the actual contained
> artifacts and not dependencies between containers
I am not aware of any such analysers. Where are they? I need to prevent
installation of the package in the case the dependency cannot be resolved, and
the only means I know is currently effectively working for that is package
dependencies. But maybe I missed something
> Allow dependencies in "container" package type
> --
>
> Key: JCRVLT-443
> URL: https://issues.apache.org/jira/browse/JCRVLT-443
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: Packaging
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> According to JCRVLT-170 {{container}} packages must not have package
> dependencies.
> Sometimes there are multiple container packages though and with the nesting
> of container packages added in JCRVLT-401 it makes sense now to add package
> dependencies also to containers (to enforce a certain order in case they are
> nested or just because at build time the dependency cannot be resolved, i.e.
> included in the container package)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (JCRVLT-443) Allow dependencies in "container" package type
[
https://issues.apache.org/jira/browse/JCRVLT-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138596#comment-17138596
]
Konrad Windszus edited comment on JCRVLT-443 at 6/17/20, 3:52 PM:
--
Consider container package {{a}} containing bundle {{b}}. {{b}} has a
dependency on another bundle {{c}}. This is correctly reflected in the
{{Import-Packages}} header of the bundle {{b}}. Bundle {{c}} is only provided
by container {{d}}. Therefore it is reasonable to in addition add a package
dependency from {{a}} to {{d}}.
was (Author: kwin):
Consider container package `a` containing bundle `b`. `b` has a dependency on
another bundle `c`. This is correctly reflected in the `Import-Packages` header
of the bundle. Bundle `c` is only provided by container `d`. Therefore it is
reasonable to in addition add a package dependency from `a` to `d`.
> Allow dependencies in "container" package type
> --
>
> Key: JCRVLT-443
> URL: https://issues.apache.org/jira/browse/JCRVLT-443
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: Packaging
>Affects Versions: 3.4.4
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.6
>
>
> According to JCRVLT-170 {{container}} packages must not have package
> dependencies.
> Sometimes there are multiple container packages though and with the nesting
> of container packages added in JCRVLT-401 it makes sense now to add package
> dependencies also to containers (to enforce a certain order in case they are
> nested or just because at build time the dependency cannot be resolved, i.e.
> included in the container package)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
