[jira] [Commented] (JCR-4475) Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path mapping

2019-09-01 Thread Julian Reschke (Jira) 


[ 
https://issues.apache.org/jira/browse/JCR-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920365#comment-16920365
 ] 

Julian Reschke commented on JCR-4475:
-

trunk: [r1866234|http://svn.apache.org/r1866234]

> Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path 
> mapping
> -
>
> Key: JCR-4475
> URL: https://issues.apache.org/jira/browse/JCR-4475
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>Affects Versions: 2.18.3
>Reporter: Woonsan Ko
>Assignee: Julian Reschke
>Priority: Major
>  Labels: candidate_jcr_2_18
> Fix For: 2.20, 2.19.5
>
> Attachments: servlet_path_prefix.patch, servlet_path_prefix2.patch
>
>
> {{org.apache.jackrabbit.jcr2dav.RepositoryStubImpl}} supports testing with 
> custom context path like the following, but not with custom servlet path 
> mapping.
> {noformat}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> It would be nice if we can test with custom servlet path mapping as well, 
> instead of the hard-coded "/server" path only, like the following examples:
> {noformat:title=1. Default with /server prefix}
> $ mvn clean install -PintegrationTesting
> {noformat}
> {noformat:title=2. With empty servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix=""
> {noformat}
> {noformat:title=3. With custom servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix="/jcrserver"
> {noformat}
> {noformat:title=4. With custom context path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> {noformat:title=5. With custom context path and custom servlet path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo" 
> -DWebDAVServletPrefix="/jcrserver"
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (JCR-4475) Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path mapping

2019-08-31 Thread Woonsan Ko (Jira) 


[ 
https://issues.apache.org/jira/browse/JCR-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920143#comment-16920143
 ] 

Woonsan Ko commented on JCR-4475:
-

Hi [~reschke],

I see your point. It makes sense to keep the empty path as is. I've uploaded a 
new patch with the empty servlet path by default to keep the same behavior:  
[^servlet_path_prefix2.patch] 

Thanks,

Woonsan

> Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path 
> mapping
> -
>
> Key: JCR-4475
> URL: https://issues.apache.org/jira/browse/JCR-4475
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>Affects Versions: 2.18.3
>Reporter: Woonsan Ko
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 2.20
>
> Attachments: servlet_path_prefix.patch, servlet_path_prefix2.patch
>
>
> {{org.apache.jackrabbit.jcr2dav.RepositoryStubImpl}} supports testing with 
> custom context path like the following, but not with custom servlet path 
> mapping.
> {noformat}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> It would be nice if we can test with custom servlet path mapping as well, 
> instead of the hard-coded "/server" path only, like the following examples:
> {noformat:title=1. Default with /server prefix}
> $ mvn clean install -PintegrationTesting
> {noformat}
> {noformat:title=2. With empty servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix=""
> {noformat}
> {noformat:title=3. With custom servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix="/jcrserver"
> {noformat}
> {noformat:title=4. With custom context path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> {noformat:title=5. With custom context path and custom servlet path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo" 
> -DWebDAVServletPrefix="/jcrserver"
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (JCR-4475) Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path mapping

2019-08-30 Thread Julian Reschke (Jira) 


[ 
https://issues.apache.org/jira/browse/JCR-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919725#comment-16919725
 ] 

Julian Reschke commented on JCR-4475:
-

What bugs me is that apparently the integration tests pass either way (with or 
without "server"). If we tested by default without, we should continue to do 
so...

> Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path 
> mapping
> -
>
> Key: JCR-4475
> URL: https://issues.apache.org/jira/browse/JCR-4475
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>Affects Versions: 2.18.3
>Reporter: Woonsan Ko
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 2.20
>
> Attachments: servlet_path_prefix.patch
>
>
> {{org.apache.jackrabbit.jcr2dav.RepositoryStubImpl}} supports testing with 
> custom context path like the following, but not with custom servlet path 
> mapping.
> {noformat}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> It would be nice if we can test with custom servlet path mapping as well, 
> instead of the hard-coded "/server" path only, like the following examples:
> {noformat:title=1. Default with /server prefix}
> $ mvn clean install -PintegrationTesting
> {noformat}
> {noformat:title=2. With empty servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix=""
> {noformat}
> {noformat:title=3. With custom servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix="/jcrserver"
> {noformat}
> {noformat:title=4. With custom context path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> {noformat:title=5. With custom context path and custom servlet path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo" 
> -DWebDAVServletPrefix="/jcrserver"
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (JCR-4475) Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path mapping

2019-08-30 Thread Woonsan Ko (Jira) 


[ 
https://issues.apache.org/jira/browse/JCR-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919718#comment-16919718
 ] 

Woonsan Ko commented on JCR-4475:
-

Hi [~reschke],

I've just tested the test case #1 to #5 again, after apply the  
[^servlet_path_prefix.patch]  on top of the bug fix branch for JCR-4458. 
Everything seems working fine.

Regards,

Woonsan

> Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path 
> mapping
> -
>
> Key: JCR-4475
> URL: https://issues.apache.org/jira/browse/JCR-4475
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>Affects Versions: 2.18.3
>Reporter: Woonsan Ko
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 2.20
>
> Attachments: servlet_path_prefix.patch
>
>
> {{org.apache.jackrabbit.jcr2dav.RepositoryStubImpl}} supports testing with 
> custom context path like the following, but not with custom servlet path 
> mapping.
> {noformat}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> It would be nice if we can test with custom servlet path mapping as well, 
> instead of the hard-coded "/server" path only, like the following examples:
> {noformat:title=1. Default with /server prefix}
> $ mvn clean install -PintegrationTesting
> {noformat}
> {noformat:title=2. With empty servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix=""
> {noformat}
> {noformat:title=3. With custom servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix="/jcrserver"
> {noformat}
> {noformat:title=4. With custom context path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> {noformat:title=5. With custom context path and custom servlet path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo" 
> -DWebDAVServletPrefix="/jcrserver"
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (JCR-4475) Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path mapping

2019-08-30 Thread Woonsan Ko (Jira) 


[ 
https://issues.apache.org/jira/browse/JCR-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919715#comment-16919715
 ] 

Woonsan Ko commented on JCR-4475:
-

Yes, it changes the default servlet path mapping from "/*" to "/server/*", 
while giving an option to set it to empty one (the test case #2 above).
I thought the change would be better because that's how it is packaged and 
configured by default even in Jackrabbit-standalone. ;-)

> Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path 
> mapping
> -
>
> Key: JCR-4475
> URL: https://issues.apache.org/jira/browse/JCR-4475
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>Affects Versions: 2.18.3
>Reporter: Woonsan Ko
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 2.20
>
> Attachments: servlet_path_prefix.patch
>
>
> {{org.apache.jackrabbit.jcr2dav.RepositoryStubImpl}} supports testing with 
> custom context path like the following, but not with custom servlet path 
> mapping.
> {noformat}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> It would be nice if we can test with custom servlet path mapping as well, 
> instead of the hard-coded "/server" path only, like the following examples:
> {noformat:title=1. Default with /server prefix}
> $ mvn clean install -PintegrationTesting
> {noformat}
> {noformat:title=2. With empty servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix=""
> {noformat}
> {noformat:title=3. With custom servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix="/jcrserver"
> {noformat}
> {noformat:title=4. With custom context path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> {noformat:title=5. With custom context path and custom servlet path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo" 
> -DWebDAVServletPrefix="/jcrserver"
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Commented] (JCR-4475) Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path mapping

2019-08-30 Thread Julian Reschke (Jira) 


[ 
https://issues.apache.org/jira/browse/JCR-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919710#comment-16919710
 ] 

Julian Reschke commented on JCR-4475:
-

Hm, but that's changes the default no?

Now {{uri}} will end in {{/server}}, while before it did not. Am I missing 
something?

> Improve o.a.j.jcr2dav.RepositoryStubImpl to test with custom servlet path 
> mapping
> -
>
> Key: JCR-4475
> URL: https://issues.apache.org/jira/browse/JCR-4475
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>Affects Versions: 2.18.3
>Reporter: Woonsan Ko
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 2.20
>
> Attachments: servlet_path_prefix.patch
>
>
> {{org.apache.jackrabbit.jcr2dav.RepositoryStubImpl}} supports testing with 
> custom context path like the following, but not with custom servlet path 
> mapping.
> {noformat}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> It would be nice if we can test with custom servlet path mapping as well, 
> instead of the hard-coded "/server" path only, like the following examples:
> {noformat:title=1. Default with /server prefix}
> $ mvn clean install -PintegrationTesting
> {noformat}
> {noformat:title=2. With empty servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix=""
> {noformat}
> {noformat:title=3. With custom servlet path prefix}
> mvn clean install -PintegrationTesting -DWebDAVServletPrefix="/jcrserver"
> {noformat}
> {noformat:title=4. With custom context path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo"
> {noformat}
> {noformat:title=5. With custom context path and custom servlet path}
> mvn clean install -PintegrationTesting -DWebDAVServletContext="/foo" 
> -DWebDAVServletPrefix="/jcrserver"
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)