[jira] [Commented] (JCRVLT-210) Allow to define excludes for the ContentPackageArchiver to prevent copying of script files from src to target
[
https://issues.apache.org/jira/browse/JCRVLT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210713#comment-16210713
]
Tobias Bocanegra commented on JCRVLT-210:
-
[~kwin] see
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/4
I added the new {{jcrRootSourceDirectory}} property. it works quite well and is
almost backward compatible, except where the project manipulated the sources
via resource plugin (e.g. filtering) before building. see altered empty
directories tests:
-
https://github.com/tripodsan/jackrabbit-filevault-package-maven-plugin/blob/eb9df4c18be424e7184ebb462dd5b44352bedf27/it/src/test/resources/test-projects/default-test-projects/resource-empty-directories/pom.xml#L56
> Allow to define excludes for the ContentPackageArchiver to prevent copying of
> script files from src to target
> -
>
> Key: JCRVLT-210
> URL: https://issues.apache.org/jira/browse/JCRVLT-210
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
>Reporter: Konrad Windszus
>Assignee: Tobias Bocanegra
>
> Similar to the {{maven-war-plugin}} it should be possible to define exclusion
> filename patterns of files which should never end up in the filevault package
> (compare with
> https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html, parameter
> {{warSourceExcludes}}).
> The following filenames come to my mind, which would be useful to exclude by
> default:
> # .DS_Store
> # SVN files
> # Git fles
> # FileVault conflict files
> That way it would be possible to create the package based on the source
> directory without being forced to first use the {{maven-resource-plugin}} to
> copy them somewhere to {{/target}} and do the filtering there.
> That would speed up the generation of large packages a lot.
> At the same time the default value of parameter {{builtContentDirectory}}
> could be modified to point to the source directory e.g.
> {{${basedir}/src/main/jcr_root}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JCRVLT-210) Allow to define excludes for the ContentPackageArchiver to prevent copying of script files from src to target
[
https://issues.apache.org/jira/browse/JCRVLT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209287#comment-16209287
]
Tobias Bocanegra commented on JCRVLT-210:
-
I must have overlooked the .DS_Store in the defaults; I remove it again.
well, the META-INF/vault suffers from the same problem as the normal content.
if a project wants to provide its own meta files, it needs to specify is via
the resource plugin (see the confusion with the vault-work and filter.xml).
having cleanly defined directories for the jcr root and vault meta-dir,
probably helps. when specifying a {{vaultMetaDirectory}} it would copy it to
the vault-work.
for both cases, I would not auto default, if {{target/classes/jcr_root}} exists
or {{target/vault-work}} already exists
> Allow to define excludes for the ContentPackageArchiver to prevent copying of
> script files from src to target
> -
>
> Key: JCRVLT-210
> URL: https://issues.apache.org/jira/browse/JCRVLT-210
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
>Reporter: Konrad Windszus
>Assignee: Tobias Bocanegra
>
> Similar to the {{maven-war-plugin}} it should be possible to define exclusion
> filename patterns of files which should never end up in the filevault package
> (compare with
> https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html, parameter
> {{warSourceExcludes}}).
> The following filenames come to my mind, which would be useful to exclude by
> default:
> # .DS_Store
> # SVN files
> # Git fles
> # FileVault conflict files
> That way it would be possible to create the package based on the source
> directory without being forced to first use the {{maven-resource-plugin}} to
> copy them somewhere to {{/target}} and do the filtering there.
> That would speed up the generation of large packages a lot.
> At the same time the default value of parameter {{builtContentDirectory}}
> could be modified to point to the source directory e.g.
> {{${basedir}/src/main/jcr_root}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JCRVLT-210) Allow to define excludes for the ContentPackageArchiver to prevent copying of script files from src to target
[
https://issues.apache.org/jira/browse/JCRVLT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209118#comment-16209118
]
Konrad Windszus commented on JCRVLT-210:
.DS_Store is part of the default excludes already
(https://github.com/sonatype/plexus-utils/blob/master/src/main/java/org/codehaus/plexus/util/AbstractScanner.java#L83).
I was more thinking about excluding the conflict markers from Vlt.
Regarding your proposal of deprecating {{builtContentDirectory}}. This sounds
good in general.
I am just not sure about {{vaultMetaDirectory}} as we already have
{{workDirectory}} which ends up in the package as well.
I would propose introducing a new parameter {{jcrRootSourceDirectory}} which
may have the defaults you proposed (with several fallbacks).
> Allow to define excludes for the ContentPackageArchiver to prevent copying of
> script files from src to target
> -
>
> Key: JCRVLT-210
> URL: https://issues.apache.org/jira/browse/JCRVLT-210
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
>Reporter: Konrad Windszus
>Assignee: Tobias Bocanegra
>
> Similar to the {{maven-war-plugin}} it should be possible to define exclusion
> filename patterns of files which should never end up in the filevault package
> (compare with
> https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html, parameter
> {{warSourceExcludes}}).
> The following filenames come to my mind, which would be useful to exclude by
> default:
> # .DS_Store
> # SVN files
> # Git fles
> # FileVault conflict files
> That way it would be possible to create the package based on the source
> directory without being forced to first use the {{maven-resource-plugin}} to
> copy them somewhere to {{/target}} and do the filtering there.
> That would speed up the generation of large packages a lot.
> At the same time the default value of parameter {{builtContentDirectory}}
> could be modified to point to the source directory e.g.
> {{${basedir}/src/main/jcr_root}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JCRVLT-210) Allow to define excludes for the ContentPackageArchiver to prevent copying of script files from src to target
[
https://issues.apache.org/jira/browse/JCRVLT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209081#comment-16209081
]
Tobias Bocanegra commented on JCRVLT-210:
-
the mirror hasn't synced yet, I changed it:
https://svn.apache.org/viewvc?view=revision=1812478
> Allow to define excludes for the ContentPackageArchiver to prevent copying of
> script files from src to target
> -
>
> Key: JCRVLT-210
> URL: https://issues.apache.org/jira/browse/JCRVLT-210
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
>Reporter: Konrad Windszus
>Assignee: Tobias Bocanegra
>
> Similar to the {{maven-war-plugin}} it should be possible to define exclusion
> filename patterns of files which should never end up in the filevault package
> (compare with
> https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html, parameter
> {{warSourceExcludes}}).
> The following filenames come to my mind, which would be useful to exclude by
> default:
> # .DS_Store
> # SVN files
> # Git fles
> # FileVault conflict files
> That way it would be possible to create the package based on the source
> directory without being forced to first use the {{maven-resource-plugin}} to
> copy them somewhere to {{/target}} and do the filtering there.
> That would speed up the generation of large packages a lot.
> At the same time the default value of parameter {{builtContentDirectory}}
> could be modified to point to the source directory e.g.
> {{${basedir}/src/main/jcr_root}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JCRVLT-210) Allow to define excludes for the ContentPackageArchiver to prevent copying of script files from src to target
[
https://issues.apache.org/jira/browse/JCRVLT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209029#comment-16209029
]
Tobias Bocanegra commented on JCRVLT-210:
-
argh. committed in r1812478 but messed up the commit line. I'm not going to
change it, otherwise we might have problems with the github mirror.
> Allow to define excludes for the ContentPackageArchiver to prevent copying of
> script files from src to target
> -
>
> Key: JCRVLT-210
> URL: https://issues.apache.org/jira/browse/JCRVLT-210
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
>Reporter: Konrad Windszus
>Assignee: Tobias Bocanegra
>
> Similar to the {{maven-war-plugin}} it should be possible to define exclusion
> filename patterns of files which should never end up in the filevault package
> (compare with
> https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html, parameter
> {{warSourceExcludes}}).
> The following filenames come to my mind, which would be useful to exclude by
> default:
> # .DS_Store
> # SVN files
> # Git fles
> # FileVault conflict files
> That way it would be possible to create the package based on the source
> directory without being forced to first use the {{maven-resource-plugin}} to
> copy them somewhere to {{/target}} and do the filtering there.
> That would speed up the generation of large packages a lot.
> At the same time the default value of parameter {{builtContentDirectory}}
> could be modified to point to the source directory e.g.
> {{${basedir}/src/main/jcr_root}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JCRVLT-210) Allow to define excludes for the ContentPackageArchiver to prevent copying of script files from src to target
[
https://issues.apache.org/jira/browse/JCRVLT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209019#comment-16209019
]
Tobias Bocanegra commented on JCRVLT-210:
-
merged in in r1812478
> Allow to define excludes for the ContentPackageArchiver to prevent copying of
> script files from src to target
> -
>
> Key: JCRVLT-210
> URL: https://issues.apache.org/jira/browse/JCRVLT-210
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
>Reporter: Konrad Windszus
>Assignee: Tobias Bocanegra
>
> Similar to the {{maven-war-plugin}} it should be possible to define exclusion
> filename patterns of files which should never end up in the filevault package
> (compare with
> https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html, parameter
> {{warSourceExcludes}}).
> The following filenames come to my mind, which would be useful to exclude by
> default:
> # .DS_Store
> # SVN files
> # Git fles
> # FileVault conflict files
> That way it would be possible to create the package based on the source
> directory without being forced to first use the {{maven-resource-plugin}} to
> copy them somewhere to {{/target}} and do the filtering there.
> That would speed up the generation of large packages a lot.
> At the same time the default value of parameter {{builtContentDirectory}}
> could be modified to point to the source directory e.g.
> {{${basedir}/src/main/jcr_root}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JCRVLT-210) Allow to define excludes for the ContentPackageArchiver to prevent copying of script files from src to target
[
https://issues.apache.org/jira/browse/JCRVLT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208988#comment-16208988
]
Tobias Bocanegra commented on JCRVLT-210:
-
thanks for the patch. I will merge it in shortly. I think the .DS_Store,
.gitignore, .svn should also go in the default excludes
also, I think the {{builtContentDirectory}} is a legacy name that stipulates
that the content directory is 'built'. how about adding:
- *{{jcrRootDirectory}}* defaults to builtContentDirectory/jcr_root
- *{{vaultMetaDirectoy}}* defaults to builtContentDirectory/META-INF/vault
or just:
- *{{packageSource}}* defaults to builtContentDirectory
and deprecate the {{builtContentDirectory}} ?
> Allow to define excludes for the ContentPackageArchiver to prevent copying of
> script files from src to target
> -
>
> Key: JCRVLT-210
> URL: https://issues.apache.org/jira/browse/JCRVLT-210
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
>Reporter: Konrad Windszus
>Assignee: Tobias Bocanegra
>
> Similar to the {{maven-war-plugin}} it should be possible to define exclusion
> filename patterns of files which should never end up in the filevault package
> (compare with
> https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html, parameter
> {{warSourceExcludes}}).
> The following filenames come to my mind, which would be useful to exclude by
> default:
> # .DS_Store
> # SVN files
> # Git fles
> # FileVault conflict files
> That way it would be possible to create the package based on the source
> directory without being forced to first use the {{maven-resource-plugin}} to
> copy them somewhere to {{/target}} and do the filtering there.
> That would speed up the generation of large packages a lot.
> At the same time the default value of parameter {{builtContentDirectory}}
> could be modified to point to the source directory e.g.
> {{${basedir}/src/main/jcr_root}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JCRVLT-210) Allow to define excludes for the ContentPackageArchiver to prevent copying of script files from src to target
[
https://issues.apache.org/jira/browse/JCRVLT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207838#comment-16207838
]
Konrad Windszus commented on JCRVLT-210:
There is a PR for this in
https://github.com/apache/jackrabbit-filevault-package-maven-plugin/pull/2.
[~tri...@apache.org] I am not too sure about what is reasonable to put there as
a default though.
> Allow to define excludes for the ContentPackageArchiver to prevent copying of
> script files from src to target
> -
>
> Key: JCRVLT-210
> URL: https://issues.apache.org/jira/browse/JCRVLT-210
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
>Reporter: Konrad Windszus
>
> Similar to the {{maven-war-plugin}} it should be possible to define exclusion
> filename patterns of files which should never end up in the filevault package
> (compare with
> https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html, parameter
> {{warSourceExcludes}}).
> The following filenames come to my mind, which would be useful to exclude by
> default:
> # .DS_Store
> # SVN files
> # Git fles
> # FileVault conflict files
> That way it would be possible to create the package based on the source
> directory without being forced to first use the {{maven-resource-plugin}} to
> copy them somewhere to {{/target}} and do the filtering there.
> That would speed up the generation of large packages a lot.
> At the same time the default value of parameter {{builtContentDirectory}}
> could be modified to point to the source directory e.g.
> {{${basedir}/src/main/jcr_root}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JCRVLT-210) Allow to define excludes for the ContentPackageArchiver to prevent copying of script files from src to target
[
https://issues.apache.org/jira/browse/JCRVLT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196065#comment-16196065
]
Konrad Windszus commented on JCRVLT-210:
The following would probably be good to add as default exclusions as well,
because it is pretty common to also import/sync into the buildDirectory from
some JCR via Vlt.
# Vlt conflict marker files:
https://github.com/apache/jackrabbit-filevault/blob/0dcf09d58fa40cbe3bc24dcb6a00281123bd5a1c/vault-vlt/src/main/java/org/apache/jackrabbit/vault/vlt/meta/xml/XmlEntry.java#L217
# Vlt Meta Directory:
https://github.com/apache/jackrabbit-filevault/blob/trunk/vault-vlt/src/main/java/org/apache/jackrabbit/vault/vlt/VltDirectory.java#L47.
> Allow to define excludes for the ContentPackageArchiver to prevent copying of
> script files from src to target
> -
>
> Key: JCRVLT-210
> URL: https://issues.apache.org/jira/browse/JCRVLT-210
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
>Reporter: Konrad Windszus
>
> Similar to the {{maven-war-plugin}} it should be possible to define exclusion
> filename patterns of files which should never end up in the filevault package
> (compare with
> https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html, parameter
> {{warSourceExcludes}}).
> The following filenames come to my mind, which would be useful to exclude by
> default:
> # .DS_Store
> # SVN files
> # Git fles
> # FileVault conflict files
> That way it would be possible to create the package based on the source
> directory without being forced to first use the {{maven-resource-plugin}} to
> copy them somewhere to {{/target}} and do the filtering there.
> That would speed up the generation of large packages a lot.
> At the same time the default value of parameter {{builtContentDirectory}}
> could be modified to point to the source directory e.g.
> {{${basedir}/src/main/jcr_root}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JCRVLT-210) Allow to define excludes for the ContentPackageArchiver to prevent copying of script files from src to target
[
https://issues.apache.org/jira/browse/JCRVLT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196048#comment-16196048
]
Konrad Windszus commented on JCRVLT-210:
Most probably the source from
https://github.com/apache/maven-plugins/blob/a9566e14f980ff52f3ee3c89d64d6b98b03c0305/maven-war-plugin/src/main/java/org/apache/maven/plugins/war/packaging/WarProjectPackagingTask.java#L162
could be taken more or less as is.
> Allow to define excludes for the ContentPackageArchiver to prevent copying of
> script files from src to target
> -
>
> Key: JCRVLT-210
> URL: https://issues.apache.org/jira/browse/JCRVLT-210
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Components: package maven plugin
>Reporter: Konrad Windszus
>
> Similar to the {{maven-war-plugin}} it should be possible to define exclusion
> filename patterns of files which should never end up in the filevault package
> (compare with
> https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html, parameter
> {{warSourceExcludes}}).
> The following filenames come to my mind, which would be useful to exclude by
> default:
> # .DS_Store
> # SVN files
> # Git fles
> # FileVault conflict files
> That way it would be possible to create the package based on the source
> directory without being forced to first use the {{maven-resource-plugin}} to
> copy them somewhere to {{/target}} and do the filtering there.
> That would speed up the generation of large packages a lot.
> At the same time the default value of parameter {{builtContentDirectory}}
> could be modified to point to the source directory e.g.
> {{${basedir}/src/main/jcr_root}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
