[jira] [Commented] (JCRVLT-357) Split up DocViewSaxImporter: Separate parsing from importing
[ https://issues.apache.org/jira/browse/JCRVLT-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415015#comment-17415015 ] Konrad Windszus commented on JCRVLT-357: What I consider is rather a callback with a docview node object for each traversed element. That would allow to separate out importing without too much risk and would still allow to use the parser for other use cases. > Split up DocViewSaxImporter: Separate parsing from importing > > > Key: JCRVLT-357 > URL: https://issues.apache.org/jira/browse/JCRVLT-357 > Project: Jackrabbit FileVault > Issue Type: Improvement > Components: vlt >Reporter: Konrad Windszus >Priority: Major > > To be able to reuse the logic from DocViewSaxImporter (e.g. in the context of > JCRVLT-345) the parsing part (i.e. deserializing into DocViewNodes) should be > separated from the actual import. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (JCRVLT-357) Split up DocViewSaxImporter: Separate parsing from importing
[ https://issues.apache.org/jira/browse/JCRVLT-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916856#comment-16916856 ] Tobias Bocanegra commented on JCRVLT-357: - I agree that the importer can be optimized ;-) but it has grown over the last years to accommodate all special cases that came up, and is IMO a bit fragile to changes. I would be very scared to change much in that code. also, it must still support importing of very large trees, which do not fit into memory... > Split up DocViewSaxImporter: Separate parsing from importing > > > Key: JCRVLT-357 > URL: https://issues.apache.org/jira/browse/JCRVLT-357 > Project: Jackrabbit FileVault > Issue Type: Improvement > Components: vlt >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.2.10 > > > To be able to reuse the logic from DocViewSaxImporter (e.g. in the context of > JCRVLT-345) the parsing part (i.e. deserializing into DocViewNodes) should be > separated from the actual import. -- This message was sent by Atlassian Jira (v8.3.2#803003)
