[jira] [Commented] (JCRVLT-358) XmlAnalyser.analyze does not correctly detect regular (non FileVault) DocView xml

2019-08-29 Thread Tobias Bocanegra (Jira)


[ 
https://issues.apache.org/jira/browse/JCRVLT-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919041#comment-16919041
 ] 

Tobias Bocanegra commented on JCRVLT-358:
-

I think that we can explicitly not support regular docview (and sysview). I 
don't think there is any benefit.

> XmlAnalyser.analyze does not correctly detect regular (non FileVault) DocView 
> xml
> -
>
> Key: JCRVLT-358
> URL: https://issues.apache.org/jira/browse/JCRVLT-358
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: vlt
>Reporter: Konrad Windszus
>Priority: Major
>
> Only doc view files starting with element {{jcr:root}} are detected due to 
> https://github.com/apache/jackrabbit-filevault/blob/2cf781d74fa18d86d061f9962c51f7470cac4096/vault-sync/src/main/java/org/apache/jackrabbit/vault/sync/impl/XmlAnalyzer.java#L83.
>  But regular docview allows arbitrary elements according to 
> https://docs.adobe.com/docs/en/spec/jcr/2.0/7_Export.html#7.3%20Document%20View
>  (in contrast to the extended doc view from FileVault: 
> https://jackrabbit.apache.org/filevault/docview.html). For regular docview 
> files always {{SerializationType.XML_GENERIC}} is being returned.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (JCRVLT-358) XmlAnalyser.analyze does not correctly detect regular (non FileVault) DocView xml

2019-08-28 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/JCRVLT-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917658#comment-16917658
 ] 

Konrad Windszus commented on JCRVLT-358:


The javadoc is still stating:
{quote}Please note, that the docview serialization is recognized if the first
 * element contains a jcr:primaryType attribute.{quote}
(https://github.com/apache/jackrabbit-filevault/blob/2cf781d74fa18d86d061f9962c51f7470cac4096/vault-sync/src/main/java/org/apache/jackrabbit/vault/sync/impl/XmlAnalyzer.java#L38)

This seems reasonable but is currently not true.
Any idea [~tripod]?

> XmlAnalyser.analyze does not correctly detect regular (non FileVault) DocView 
> xml
> -
>
> Key: JCRVLT-358
> URL: https://issues.apache.org/jira/browse/JCRVLT-358
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: vlt
>Reporter: Konrad Windszus
>Priority: Major
>
> Only doc view files starting with element {{jcr:root}} are detected due to 
> https://github.com/apache/jackrabbit-filevault/blob/2cf781d74fa18d86d061f9962c51f7470cac4096/vault-sync/src/main/java/org/apache/jackrabbit/vault/sync/impl/XmlAnalyzer.java#L83.
>  But regular docview allows arbitrary elements according to 
> https://docs.adobe.com/docs/en/spec/jcr/2.0/7_Export.html#7.3%20Document%20View
>  (in contrast to the extended doc view from FileVault: 
> https://jackrabbit.apache.org/filevault/docview.html). For regular docview 
> files always {{SerializationType.XML_GENERIC}} is being returned.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)