[jira] [Commented] (JCRVLT-416) Adding a package dependency to a package containing it as subpackage leads to a dependency cycle

2020-03-02 Thread Tobias Bocanegra (Jira)


[ 
https://issues.apache.org/jira/browse/JCRVLT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049801#comment-17049801
 ] 

Tobias Bocanegra commented on JCRVLT-416:
-

i see... yes :-)

> Adding a package dependency to a package containing it as subpackage leads to 
> a dependency cycle
> 
>
> Key: JCRVLT-416
> URL: https://issues.apache.org/jira/browse/JCRVLT-416
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: package-maven-plugin-1.1.2
>
>
> Consider the case where {{a}} is a subpackage of {{b}}. This requires {{a}} 
> being a Maven dependency of Maven Module {{b}}. Since every package 
> installation of {{b}} adds {{b}} as package dependency to {{a}} implicitly 
> (compare with https://issues.apache.org/jira/browse/JCRVLT-140) it should 
> also be possible to make this implicit dependency and explicit one (to make 
> the validator be able to detect e.g. filter roots being provided by {{b}}). 
> But once you also add {{a}} as dependency to {{b}} you get a dependency cycle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (JCRVLT-416) Adding a package dependency to a package containing it as subpackage leads to a dependency cycle

2020-03-02 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/JCRVLT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049000#comment-17049000
 ] 

Konrad Windszus commented on JCRVLT-416:


The only workaround for now is to introduce a new application package {{c}} 
which contains {{/apps/myroot}} and make both {{a}} and {{b}} depend on it. 
Also {{b}} must depend on {{c}} in addition as it is supposed to contain both 
{{a}} and {{c}} as sub packages.

> Adding a package dependency to a package containing it as subpackage leads to 
> a dependency cycle
> 
>
> Key: JCRVLT-416
> URL: https://issues.apache.org/jira/browse/JCRVLT-416
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: package-maven-plugin-1.1.2
>
>
> Consider the case where {{a}} is a subpackage of {{b}}. This requires {{a}} 
> being a Maven dependency of Maven Module {{b}}. Since every package 
> installation of {{b}} adds {{b}} as package dependency to {{a}} implicitly 
> (compare with https://issues.apache.org/jira/browse/JCRVLT-140) it should 
> also be possible to make this implicit dependency and explicit one (to make 
> the validator be able to detect e.g. filter roots being provided by {{b}}). 
> But once you also add {{a}} as dependency to {{b}} you get a dependency cycle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (JCRVLT-416) Adding a package dependency to a package containing it as subpackage leads to a dependency cycle

2020-02-28 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/JCRVLT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047341#comment-17047341
 ] 

Konrad Windszus commented on JCRVLT-416:


As b contains a as a subpackage, it needs to define a as a dependency 
(http://jackrabbit.apache.org/filevault-package-maven-plugin/generate-metadata-mojo.html#subPackages)

> Adding a package dependency to a package containing it as subpackage leads to 
> a dependency cycle
> 
>
> Key: JCRVLT-416
> URL: https://issues.apache.org/jira/browse/JCRVLT-416
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: package-maven-plugin-1.1.2
>
>
> Consider the case where {{a}} is a subpackage of {{b}}. This requires {{a}} 
> being a Maven dependency of Maven Module {{b}}. Since every package 
> installation of {{b}} adds {{b}} as package dependency to {{a}} implicitly 
> (compare with https://issues.apache.org/jira/browse/JCRVLT-140) it should 
> also be possible to make this implicit dependency and explicit one (to make 
> the validator be able to detect e.g. filter roots being provided by {{b}}). 
> But once you also add {{a}} as dependency to {{b}} you get a dependency cycle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (JCRVLT-416) Adding a package dependency to a package containing it as subpackage leads to a dependency cycle

2020-02-28 Thread Tobias Bocanegra (Jira)


[ 
https://issues.apache.org/jira/browse/JCRVLT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047336#comment-17047336
 ] 

Tobias Bocanegra commented on JCRVLT-416:
-

but still, you can install b w/o a. so a is not a dependency of b.

> Adding a package dependency to a package containing it as subpackage leads to 
> a dependency cycle
> 
>
> Key: JCRVLT-416
> URL: https://issues.apache.org/jira/browse/JCRVLT-416
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: package-maven-plugin-1.1.2
>
>
> Consider the case where {{a}} is a subpackage of {{b}}. This requires {{a}} 
> being a Maven dependency of Maven Module {{b}}. Since every package 
> installation of {{b}} adds {{b}} as package dependency to {{a}} implicitly 
> (compare with https://issues.apache.org/jira/browse/JCRVLT-140) it should 
> also be possible to make this implicit dependency and explicit one (to make 
> the validator be able to detect e.g. filter roots being provided by {{b}}). 
> But once you also add {{a}} as dependency to {{b}} you get a dependency cycle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (JCRVLT-416) Adding a package dependency to a package containing it as subpackage leads to a dependency cycle

2020-02-28 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/JCRVLT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047321#comment-17047321
 ] 

Konrad Windszus commented on JCRVLT-416:


This is not true in case {{b}} provides the root node for {{a}}, e.g. {{b}} 
defines {{/apps/myroot}} with some excludes and {{a}} has a filter root like 
{{/apps/myroot/special}}.

> Adding a package dependency to a package containing it as subpackage leads to 
> a dependency cycle
> 
>
> Key: JCRVLT-416
> URL: https://issues.apache.org/jira/browse/JCRVLT-416
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: package-maven-plugin-1.1.2
>
>
> Consider the case where {{a}} is a subpackage of {{b}}. This requires {{a}} 
> being a Maven dependency of Maven Module {{b}}. Since every package 
> installation of {{b}} adds {{b}} as package dependency to {{a}} implicitly 
> (compare with https://issues.apache.org/jira/browse/JCRVLT-140) it should 
> also be possible to make this implicit dependency and explicit one (to make 
> the validator be able to detect e.g. filter roots being provided by {{b}}). 
> But once you also add {{a}} as dependency to {{b}} you get a dependency cycle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (JCRVLT-416) Adding a package dependency to a package containing it as subpackage leads to a dependency cycle

2020-02-28 Thread Tobias Bocanegra (Jira)


[ 
https://issues.apache.org/jira/browse/JCRVLT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047314#comment-17047314
 ] 

Tobias Bocanegra commented on JCRVLT-416:
-

bq. But once you also add a as dependency to b you get a dependency cycle.

why should a be a dependency of b ? it's the other way around.
you can install 'b' without 'a', but not vice versa.

> Adding a package dependency to a package containing it as subpackage leads to 
> a dependency cycle
> 
>
> Key: JCRVLT-416
> URL: https://issues.apache.org/jira/browse/JCRVLT-416
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: package-maven-plugin-1.1.2
>
>
> Consider the case where {{a}} is a subpackage of {{b}}. This requires {{a}} 
> being a Maven dependency of Maven Module {{b}}. Since every package 
> installation of {{b}} adds {{b}} as package dependency to {{a}} implicitly 
> (compare with https://issues.apache.org/jira/browse/JCRVLT-140) it should 
> also be possible to make this implicit dependency and explicit one (to make 
> the validator be able to detect e.g. filter roots being provided by {{b}}). 
> But once you also add {{a}} as dependency to {{b}} you get a dependency cycle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (JCRVLT-416) Adding a package dependency to a package containing it as subpackage leads to a dependency cycle

2020-02-27 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/JCRVLT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046588#comment-17046588
 ] 

Konrad Windszus commented on JCRVLT-416:


[~tripod] How can we make the dependency to the container package explicit 
without causing dependency cycles?

> Adding a package dependency to a package containing it as subpackage leads to 
> a dependency cycle
> 
>
> Key: JCRVLT-416
> URL: https://issues.apache.org/jira/browse/JCRVLT-416
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: package-maven-plugin-1.1.2
>
>
> Consider the case where {{a}} is a subpackage of {{b}}. This requires {{a}} 
> being a Maven dependency of Maven Module {{b}}. Since every package 
> installation of {{b}} adds {{b}} as package dependency to {{a}} implicitly 
> (compare with https://issues.apache.org/jira/browse/JCRVLT-140) it should 
> also be possible to make this implicit dependency and explicit one (to make 
> the validator be able to detect e.g. filter roots being provided by {{b}}). 
> But once you also add {{a}} as dependency to {{b}} you get a dependency cycle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)