[jira] Commented: (JCR-1762) Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class
[
https://issues.apache.org/jira/browse/JCR-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12635225#action_12635225
]
Christophe Lombart commented on JCR-1762:
-
Now it works on my machine with the updated patch - thanks
I have reviewed your patch and I'm wondering why you have modified the class
AbstractMapperImpl with that change :
@@ -198,7 +200,7 @@
public ClassDescriptor getClassDescriptorByClass(Class clazz) {
ClassDescriptor descriptor =
mappingDescriptor.getClassDescriptorByName(clazz.getName());
if (descriptor==null) {
- throw new IncorrectPersistentClassException(Class of
type: + clazz.getName() + has no descriptor.);
+ //throw new IncorrectPersistentClassException(Class of
type: + clazz.getName() + has no descriptor.);
}
return descriptor ;
}
If we keep the old code, your patch is still working.
Improvement to MultiValueCollectionConverterImpl to Map collections with
element class Object.class
---
Key: JCR-1762
URL: https://issues.apache.org/jira/browse/JCR-1762
Project: Jackrabbit
Issue Type: Improvement
Components: jackrabbit-ocm
Affects Versions: 1.5
Environment: Java 5 and Up
Reporter: Boni Gopalan
Assignee: Christophe Lombart
Priority: Minor
Attachments: JCR-1762-updated.patch, JCR-1762.patch, testresults.txt
Original Estimate: 3h
Remaining Estimate: 3h
Currently MultiValueCollectionConverterImpl does not support elements of
type Object.class. The type of the contained class has to be specified
either through the mapping file or through the Bean annotation. Even with
that flexibility Object.class is specifically excluded (For good reasons.).
My view is that by definition MultiValueCollectionConverterImpl should make
a best effort to convert and that best effort should include using Undefined
UndefinedTypeConverterImpl to convert an object when all the other conversion
strategies run out. To this resolve I have patched the OCM source. I have
test cases also. I will upload the patch files right after.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1762) Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class
[ https://issues.apache.org/jira/browse/JCR-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12635148#action_12635148 ] Christophe Lombart commented on JCR-1762: - trying to apply the patch but I got a NullPointerException : java.lang.NullPointerException at org.apache.jackrabbit.ocm.manager.objectconverter.impl.ObjectConverterImpl.getPath(ObjectConverterImpl.java:612) at org.apache.jackrabbit.ocm.manager.impl.ObjectContentManagerImpl.insert(ObjectContentManagerImpl.java:388) at org.apache.jackrabbit.ocm.manager.collectionconverter.AnnotationMultiValueWithObjectCollectionConverterImplTest.checkMultiValue(AnnotationMultiValueWithObjectCollectionConverterImplTest.java:81) at org.apache.jackrabbit.ocm.manager.collectionconverter.AnnotationMultiValueWithObjectCollectionConverterImplTest.testMultiValue(AnnotationMultiValueWithObjectCollectionConverterImplTest.java:59) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at junit.framework.TestCase.runTest(TestCase.java:154) at junit.framework.TestCase.runBare(TestCase.java:127) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at junit.framework.TestSuite.runTest(TestSuite.java:208) at junit.framework.TestSuite.run(TestSuite.java:203) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22) at junit.extensions.TestSetup$1.protect(TestSetup.java:19) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.extensions.TestSetup.run(TestSetup.java:23) at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196) Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class --- Key: JCR-1762 URL: https://issues.apache.org/jira/browse/JCR-1762 Project: Jackrabbit Issue Type: Improvement Components: jackrabbit-ocm Affects Versions: 1.5 Environment: Java 5 and Up Reporter: Boni Gopalan Assignee: Christophe Lombart Priority: Minor Attachments: JCR-1762.patch Original Estimate: 3h Remaining Estimate: 3h Currently MultiValueCollectionConverterImpl does not support elements of type Object.class. The type of the contained class has to be specified either through the mapping file or through the Bean annotation. Even with that flexibility Object.class is specifically excluded (For good reasons.). My view is that by definition MultiValueCollectionConverterImpl should make a best effort to convert and that best effort should include using Undefined UndefinedTypeConverterImpl to convert an object when all the other conversion strategies run out. To this resolve I have patched the OCM source. I have test cases also. I will upload the patch files right after. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1762) Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class
[ https://issues.apache.org/jira/browse/JCR-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12635149#action_12635149 ] Christophe Lombart commented on JCR-1762: - Maybe it is due to my latest changes. I will investigate later. Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class --- Key: JCR-1762 URL: https://issues.apache.org/jira/browse/JCR-1762 Project: Jackrabbit Issue Type: Improvement Components: jackrabbit-ocm Affects Versions: 1.5 Environment: Java 5 and Up Reporter: Boni Gopalan Assignee: Christophe Lombart Priority: Minor Attachments: JCR-1762.patch Original Estimate: 3h Remaining Estimate: 3h Currently MultiValueCollectionConverterImpl does not support elements of type Object.class. The type of the contained class has to be specified either through the mapping file or through the Bean annotation. Even with that flexibility Object.class is specifically excluded (For good reasons.). My view is that by definition MultiValueCollectionConverterImpl should make a best effort to convert and that best effort should include using Undefined UndefinedTypeConverterImpl to convert an object when all the other conversion strategies run out. To this resolve I have patched the OCM source. I have test cases also. I will upload the patch files right after. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1762) Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class
[ https://issues.apache.org/jira/browse/JCR-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12635151#action_12635151 ] Boni Gopalan commented on JCR-1762: --- I think so too. 'Cause I just ran the test cases once again got ocm and all passed. If you have something important to commit please go ahead, I will rework on the patch and submit. E:\boni\jackrabbit-src\trunk\jackrabbit-ocmmvn clean test [INFO] Scanning for projects... [INFO] [INFO] Building Jackrabbit Object Content Mapping [INFO]task-segment: [clean, test] [INFO] [INFO] [clean:clean] [INFO] Deleting directory E:\boni\jackrabbit-src\trunk\jackrabbit-ocm\target [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] snapshot org.apache.jackrabbit:jackrabbit-core:1.5-SNAPSHOT: checking for updates from apache.snapshots 7K downloaded [INFO] snapshot org.apache.jackrabbit:jackrabbit-api:1.5-SNAPSHOT: checking for updates from apache.snapshots 2K downloaded [INFO] snapshot org.apache.jackrabbit:jackrabbit-jcr-commons:1.5-SNAPSHOT: checking for updates from apache.snapshots 2K downloaded [INFO] snapshot org.apache.jackrabbit:jackrabbit-spi-commons:1.5-SNAPSHOT: checking for updates from apache.snapshots 7K downloaded [INFO] snapshot org.apache.jackrabbit:jackrabbit-spi:1.5-SNAPSHOT: checking for updates from apache.snapshots 2K downloaded [INFO] snapshot org.apache.jackrabbit:jackrabbit-text-extractors:1.5-SNAPSHOT: checking for updates from apache.snapshots 2K downloaded [INFO] [compiler:compile] [INFO] Compiling 106 source files to E:\boni\jackrabbit-src\trunk\jackrabbit-ocm\target\classes [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. 1645K downloaded 26K downloaded 197K downloaded 509K downloaded 21K downloaded 32K downloaded [INFO] [compiler:testCompile] [INFO] Compiling 169 source files to E:\boni\jackrabbit-src\trunk\jackrabbit-ocm\target\test-classes [INFO] [surefire:test] [INFO] Surefire report directory: E:\boni\jackrabbit-src\trunk\jackrabbit-ocm\target\surefire-reports --- T E S T S --- Running org.apache.jackrabbit.ocm.manager.collectionconverter.AnnotationMultiValueWithObjectCollectionConverterImplTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.434 sec Running org.apache.jackrabbit.ocm.querymanager.DigesterQueryManagerTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.61 sec Running org.apache.jackrabbit.ocm.manager.query.DigesterMultiValueQueryTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.35 sec Running org.apache.jackrabbit.ocm.manager.atomic.DigesterAtomicTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.125 sec Running org.apache.jackrabbit.ocm.manager.collectionconverter.DigesterResidualPropertiesCollectionConverterImplTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.08 sec Running org.apache.jackrabbit.ocm.manager.proxy.DigesterProxyTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.143 sec Running org.apache.jackrabbit.ocm.manager.collectionconverter.AnnotationResidualNodesCollectionConverterImplTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.395 sec Running org.apache.jackrabbit.ocm.manager.query.AnnotationScopeQueryTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.982 sec Running org.apache.jackrabbit.ocm.manager.auto.DigesterAutoTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.125 sec Running org.apache.jackrabbit.ocm.manager.collectionconverter.AnnotationDefaultCollectionConverterImplTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.69 sec Running org.apache.jackrabbit.ocm.manager.collectionconverter.DigesterMultiValueWithObjectCollectionConverterImplTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.09 sec Running org.apache.jackrabbit.ocm.manager.beanconverter.AnnotationBeanDescriptorTest Paragraph path : /test/paragraph[2] Paragraph path : /test/paragraph[3] Paragraph path : /test/paragraph Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.332 sec Running org.apache.jackrabbit.ocm.mapper.AnnotationMapperImplTest Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.103 sec Running org.apache.jackrabbit.ocm.manager.inheritance.DigesterInheritanceConcreteClassTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.938 sec Running org.apache.jackrabbit.ocm.manager.query.DigesterIteratorQueryTest getObject takes : 3 getObject takes : 18 getObject takes : 1 Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time
[jira] Commented: (JCR-1762) Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class
[ https://issues.apache.org/jira/browse/JCR-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12635157#action_12635157 ] Christophe Lombart commented on JCR-1762: - I have committed. You can update the project to get my changes. If you have no sufficient time I will review this problem tomorrow. thanks Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class --- Key: JCR-1762 URL: https://issues.apache.org/jira/browse/JCR-1762 Project: Jackrabbit Issue Type: Improvement Components: jackrabbit-ocm Affects Versions: 1.5 Environment: Java 5 and Up Reporter: Boni Gopalan Assignee: Christophe Lombart Priority: Minor Attachments: JCR-1762.patch Original Estimate: 3h Remaining Estimate: 3h Currently MultiValueCollectionConverterImpl does not support elements of type Object.class. The type of the contained class has to be specified either through the mapping file or through the Bean annotation. Even with that flexibility Object.class is specifically excluded (For good reasons.). My view is that by definition MultiValueCollectionConverterImpl should make a best effort to convert and that best effort should include using Undefined UndefinedTypeConverterImpl to convert an object when all the other conversion strategies run out. To this resolve I have patched the OCM source. I have test cases also. I will upload the patch files right after. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1762) Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class
[ https://issues.apache.org/jira/browse/JCR-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12635203#action_12635203 ] Boni Gopalan commented on JCR-1762: --- I am At revision 699765 of the whole trunk. All tests are passing. I am attaching my test execution and an updated patch. Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class --- Key: JCR-1762 URL: https://issues.apache.org/jira/browse/JCR-1762 Project: Jackrabbit Issue Type: Improvement Components: jackrabbit-ocm Affects Versions: 1.5 Environment: Java 5 and Up Reporter: Boni Gopalan Assignee: Christophe Lombart Priority: Minor Attachments: JCR-1762.patch Original Estimate: 3h Remaining Estimate: 3h Currently MultiValueCollectionConverterImpl does not support elements of type Object.class. The type of the contained class has to be specified either through the mapping file or through the Bean annotation. Even with that flexibility Object.class is specifically excluded (For good reasons.). My view is that by definition MultiValueCollectionConverterImpl should make a best effort to convert and that best effort should include using Undefined UndefinedTypeConverterImpl to convert an object when all the other conversion strategies run out. To this resolve I have patched the OCM source. I have test cases also. I will upload the patch files right after. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1762) Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class
[ https://issues.apache.org/jira/browse/JCR-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12635207#action_12635207 ] Boni Gopalan commented on JCR-1762: --- and wrt to OCM : E:\boni\jackrabbit-src\trunk\jackrabbit-ocmsvn info Path: . URL: http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-ocm Repository Root: http://svn.apache.org/repos/asf Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68 Revision: 699767 Node Kind: directory Schedule: normal Last Changed Author: clombart Last Changed Rev: 699628 Last Changed Date: 2008-09-27 18:07:02 +0530 (Sat, 27 Sep 2008) Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class --- Key: JCR-1762 URL: https://issues.apache.org/jira/browse/JCR-1762 Project: Jackrabbit Issue Type: Improvement Components: jackrabbit-ocm Affects Versions: 1.5 Environment: Java 5 and Up Reporter: Boni Gopalan Assignee: Christophe Lombart Priority: Minor Attachments: JCR-1762-updated.patch, JCR-1762.patch, testresults.txt Original Estimate: 3h Remaining Estimate: 3h Currently MultiValueCollectionConverterImpl does not support elements of type Object.class. The type of the contained class has to be specified either through the mapping file or through the Bean annotation. Even with that flexibility Object.class is specifically excluded (For good reasons.). My view is that by definition MultiValueCollectionConverterImpl should make a best effort to convert and that best effort should include using Undefined UndefinedTypeConverterImpl to convert an object when all the other conversion strategies run out. To this resolve I have patched the OCM source. I have test cases also. I will upload the patch files right after. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1762) Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class
[ https://issues.apache.org/jira/browse/JCR-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12634406#action_12634406 ] Christophe Lombart commented on JCR-1762: - Hi Boni, Can you provide a patch instead of a full java classes. It will be easier to apply changes because I'm also working AnnotationDescriptorReader AbstractMapperImpl Thanks. Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class --- Key: JCR-1762 URL: https://issues.apache.org/jira/browse/JCR-1762 Project: Jackrabbit Issue Type: Improvement Components: jackrabbit-ocm Affects Versions: 1.5 Environment: Java 5 and Up Reporter: Boni Gopalan Priority: Minor Attachments: JCR-1762-patch.zip Original Estimate: 3h Remaining Estimate: 3h Currently MultiValueCollectionConverterImpl does not support elements of type Object.class. The type of the contained class has to be specified either through the mapping file or through the Bean annotation. Even with that flexibility Object.class is specifically excluded (For good reasons.). My view is that by definition MultiValueCollectionConverterImpl should make a best effort to convert and that best effort should include using Undefined UndefinedTypeConverterImpl to convert an object when all the other conversion strategies run out. To this resolve I have patched the OCM source. I have test cases also. I will upload the patch files right after. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1762) Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class
[ https://issues.apache.org/jira/browse/JCR-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12634412#action_12634412 ] Boni Gopalan commented on JCR-1762: --- Can you briefly tell me how I provide a patch? Improvement to MultiValueCollectionConverterImpl to Map collections with element class Object.class --- Key: JCR-1762 URL: https://issues.apache.org/jira/browse/JCR-1762 Project: Jackrabbit Issue Type: Improvement Components: jackrabbit-ocm Affects Versions: 1.5 Environment: Java 5 and Up Reporter: Boni Gopalan Priority: Minor Attachments: JCR-1762-patch.zip Original Estimate: 3h Remaining Estimate: 3h Currently MultiValueCollectionConverterImpl does not support elements of type Object.class. The type of the contained class has to be specified either through the mapping file or through the Bean annotation. Even with that flexibility Object.class is specifically excluded (For good reasons.). My view is that by definition MultiValueCollectionConverterImpl should make a best effort to convert and that best effort should include using Undefined UndefinedTypeConverterImpl to convert an object when all the other conversion strategies run out. To this resolve I have patched the OCM source. I have test cases also. I will upload the patch files right after. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
