Re: [VOTE] Release JMeter 2.5.1 RC1

2011-09-24 Thread sebb
On 25 September 2011 01:03, Milamber  wrote:
>
>
> Le 23/09/2011 23:38, sebb a ecrit :
>> On 23 September 2011 23:17, sebb  wrote:
>>
>>> On 23 September 2011 18:14, sebb  wrote:
>>>
 On 23 September 2011 17:15, Milamber  wrote:

> Hello,
>
> It's seems all open bugs with 2.5.1RC1 are closed.
> I will start the RC2 process tomorrow.
>
 OK.

>>> Just found a problem with the HC4 retries - they prevent StopTest from 
>>> working.
>>>
>>> There's a deadlock in the code that prevents the interrupt from
>>> working when there is a retry.
>>> [At the back of my mind, I thought there was another reason why I set
>>> the retry count to 0!]
>>>
>>> Shutdown works fine, because it does not try to interrupt the sample.
>>>
>>> I think there's a work-round I can use in the JMeter code, but I don't
>>> think we should release the code as is.
>>>
>>> Sorry.
>>>
>>> The Java and HC3.1 samplers work fine; it's only HC4 that has the problem.
>>>
>>> I'll let you know if there's a solution ASAP.
>>>
>> URL: http://svn.apache.org/viewvc?rev=1175069&view=rev
>> Log:
>> Temporary hack to work round
>>
>
> This temporary hack don't always work for me. When I call Stop command
> at the beginning of a test (before end of ramp up), I have the same
> deadlock.
> (but sometimes the stop works fine.)

Can you do a thread dump when this happens?


> I thinks we must release the version 2.5.1 to correct the others bugs
> already fixed, and add a known problem in documentation for this deadlook?

Yes, that sounds reasonable. It's not clear yet whether this is a
JMeter or HC4 problem; nor is it clear what to do to fix it.
Anyway, it only occurs sometimes, and it only occurs when trying to
stop the test - so the GUI can just be exitted.

> Milamber
>
>
>
>> https://issues.apache.org/jira/browse/HTTPCLIENT-1120
>> Note: copying the code from the patch did not seem to work; it looks
>> like isAborted() was not set.
>> Hopefully that is fixed in 4.1.3
>>
>> That seems to have fixed it for me, or at least improved matters.
>>
>> Still needs more testing to see if the deadlock I found - reported in
>> https://issues.apache.org/jira/browse/HTTPCLIENT-1127 - can still
>> occur.
>>
>> BTW, I found the deadlock testing against the mirror server.
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
>> For additional commands, e-mail: dev-h...@jakarta.apache.org
>>
>>
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
> For additional commands, e-mail: dev-h...@jakarta.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org



Re: [VOTE] Release JMeter 2.5.1 RC1

2011-09-24 Thread Milamber


Le 23/09/2011 23:38, sebb a ecrit :
> On 23 September 2011 23:17, sebb  wrote:
>   
>> On 23 September 2011 18:14, sebb  wrote:
>> 
>>> On 23 September 2011 17:15, Milamber  wrote:
>>>   
 Hello,

 It's seems all open bugs with 2.5.1RC1 are closed.
 I will start the RC2 process tomorrow.
 
>>> OK.
>>>   
>> Just found a problem with the HC4 retries - they prevent StopTest from 
>> working.
>>
>> There's a deadlock in the code that prevents the interrupt from
>> working when there is a retry.
>> [At the back of my mind, I thought there was another reason why I set
>> the retry count to 0!]
>>
>> Shutdown works fine, because it does not try to interrupt the sample.
>>
>> I think there's a work-round I can use in the JMeter code, but I don't
>> think we should release the code as is.
>>
>> Sorry.
>>
>> The Java and HC3.1 samplers work fine; it's only HC4 that has the problem.
>>
>> I'll let you know if there's a solution ASAP.
>> 
> URL: http://svn.apache.org/viewvc?rev=1175069&view=rev
> Log:
> Temporary hack to work round
>   

This temporary hack don't always work for me. When I call Stop command
at the beginning of a test (before end of ramp up), I have the same
deadlock.
(but sometimes the stop works fine.)

I thinks we must release the version 2.5.1 to correct the others bugs
already fixed, and add a known problem in documentation for this deadlook?

Milamber



> https://issues.apache.org/jira/browse/HTTPCLIENT-1120
> Note: copying the code from the patch did not seem to work; it looks
> like isAborted() was not set.
> Hopefully that is fixed in 4.1.3
>
> That seems to have fixed it for me, or at least improved matters.
>
> Still needs more testing to see if the deadlock I found - reported in
> https://issues.apache.org/jira/browse/HTTPCLIENT-1127 - can still
> occur.
>
> BTW, I found the deadlock testing against the mirror server.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
> For additional commands, e-mail: dev-h...@jakarta.apache.org
>
>
>   


-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org