Re: svn commit: r1065011 - /jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties

2011-01-30 Thread Milamber
Hello

The documentation (component_reference) needs to be update too.
In my opinion, the lower case workaround for order isn't the best choice
for have Thread Group first. Doesn't better to change the menu factory
to manage an optional order?

Milamber


 [java] There were 3 failures:
 [java] 1)
runGUITitle(org.apache.jmeter.junit.JMeterTest)junit.framework.AssertionFailedError:
component_reference.xml needs 'tearDown_Thread_Group' anchor for
org.apache.jmeter.threads.gui.PostThreadGroupGui
 [java] at
org.apache.jmeter.junit.JMeterTest.runGUITitle(JMeterTest.java:364)
 [java] at sun.reflect.GeneratedMethodAccessor27.invoke(Unknown
Source)
 [java] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [java] at org.apache.jorphan.test.AllTests.main(AllTests.java:225)
 [java] 2)
runGUITitle(org.apache.jmeter.junit.JMeterTest)junit.framework.AssertionFailedError:
component_reference.xml needs 'setUp_Thread_Group' anchor for
org.apache.jmeter.threads.gui.SetupThreadGroupGui
 [java] at
org.apache.jmeter.junit.JMeterTest.runGUITitle(JMeterTest.java:364)
 [java] at sun.reflect.GeneratedMethodAccessor27.invoke(Unknown
Source)
 [java] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [java] at org.apache.jorphan.test.AllTests.main(AllTests.java:225)
 [java] 3)
checkGuiSet(org.apache.jmeter.junit.JMeterTest)junit.framework.AssertionFailedError:
Should not have any names left over expected:0 but was:2
 [java] at
org.apache.jmeter.junit.JMeterTest.checkGuiSet(JMeterTest.java:263)
 [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
 [java] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [java] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [java] at org.apache.jorphan.test.AllTests.main(AllTests.java:225)

Le 29/01/2011 12:39, s...@apache.org a ecrit :
 Author: sebb
 Date: Sat Jan 29 12:39:12 2011
 New Revision: 1065011

 URL: http://svn.apache.org/viewvc?rev=1065011view=rev
 Log:
 Rename Pre and Post Thread Group labels:
 - more like JUnit, so should be more familiar
 - lower-case initial letter to sort after the main one

 Modified:
 
 jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties

 Modified: 
 jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
 URL: 
 http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties?rev=1065011r1=1065010r2=1065011view=diff
 ==
 --- 
 jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties 
 (original)
 +++ 
 jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties 
 Sat Jan 29 12:39:12 2011
 @@ -562,7 +562,7 @@ patterns_to_include=URL Patterns to Incl
  pkcs12_desc=PKCS 12 Key (*.p12)
  pl=Polish
  port=Port\:
 -post_thread_group_title=Post Thread Group
 +post_thread_group_title=tearDown Thread Group
  property_as_field_label={0}\:
  property_default_param=Default value
  property_edit=Edit
 @@ -761,7 +761,7 @@ send_file_param_name_label=Parameter Nam
  server=Server Name or IP\:
  servername=Servername \:
  session_argument_name=Session Argument Name
 -setup_thread_group_title=Setup Thread Group
 +setup_thread_group_title=setUp Thread Group
  should_save=You should save your test plan before running it.  \nIf you are 
 using supporting data files (ie, for CSV Data Set or _StringFromFile), \nthen 
 it is particularly important to first save your test script. \nDo you want to 
 save your test plan first?
  shutdown=Shutdown
  simple_config_element=Simple Config Element



 -
 To unsubscribe, e-mail: notifications-unsubscr...@jakarta.apache.org
 For additional commands, e-mail: notifications-h...@jakarta.apache.org


   


-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org



Re: svn commit: r1065011 - /jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties

2011-01-30 Thread sebb
On 30 January 2011 10:40, Milamber milam...@apache.org wrote:
 Hello

 The documentation (component_reference) needs to be update too.

Yes, I was intending to do that later.

 In my opinion, the lower case workaround for order isn't the best choice
 for have Thread Group first. Doesn't better to change the menu factory
 to manage an optional order?

Yes, that would be better, but this works for now.
I won't object if anyone else wants to fix it - I'm not sure when I will do so.

 Milamber



 Le 29/01/2011 12:39, s...@apache.org a ecrit :
 Author: sebb
 Date: Sat Jan 29 12:39:12 2011
 New Revision: 1065011

 URL: http://svn.apache.org/viewvc?rev=1065011view=rev
 Log:
 Rename Pre and Post Thread Group labels:
 - more like JUnit, so should be more familiar
 - lower-case initial letter to sort after the main one


-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org