Re: svn commit: r1182664 - /jakarta/jmeter/trunk/eclipse.classpath

[sebb]

Good catch!

On 13 October 2011 06:39,   wrote:
> Author: pmouawad
> Date: Thu Oct 13 05:39:35 2011
> New Revision: 1182664
>
> URL: http://svn.apache.org/viewvc?rev=1182664&view=rev
> Log:
> Bug 52016 - It would be useful to support Jexl2
>
> Add jar to eclipse.classpath
>
> Modified:
>    jakarta/jmeter/trunk/eclipse.classpath
>
> Modified: jakarta/jmeter/trunk/eclipse.classpath
> URL: 
> http://svn.apache.org/viewvc/jakarta/jmeter/trunk/eclipse.classpath?rev=1182664&r1=1182663&r2=1182664&view=diff
> ==
> --- jakarta/jmeter/trunk/eclipse.classpath (original)
> +++ jakarta/jmeter/trunk/eclipse.classpath Thu Oct 13 05:39:35 2011
> @@ -50,6 +50,7 @@
>        
>        
>        
> +       
>        
>        
>        
>
>
>
> -
> To unsubscribe, e-mail: notifications-unsubscr...@jakarta.apache.org
> For additional commands, e-mail: notifications-h...@jakarta.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org

Patch 52001

[Philippe Mouawad]

Hello Sebb,
Do you think we should  implement issue
52001
:

   - Add scroll automatically to Summary Report

The only use case I see is when you label sampler with a variable name,
otherwise you may scroll but it won't last after some time number of lines
will stay the same.

If you give me the go, I will patch it.

Regards
Philippe

Re: DO NOT REPLY [Bug 52019] Add menu option to enable/disable timers when running Plan

[Philippe Mouawad]

Hello Sebb,
Do you agree with this proposition :

   - Add an Menu Option called "Run with timers disabled"
   - This option will set a boolean on GuiPackage#getinstance() called
   noTimersPause
   - Timers will consult this option to decide whether to run or not pause
   - At end of run option will be reset (what would be the best way to
   detect end, StandardJMeterEngine#run after waitThreadsStopped ?)


If you are Ok, I can implement it.

Regards
Philippe

On Thu, Oct 13, 2011 at 1:09 PM, Philippe Mouawad <
p.moua...@ubik-ingenierie.com> wrote:

> Hello Sebb,
> In my opinion this option would be useful only in Scripting Phase so
> through GUI.
> That's why I wanted it as a Menu Option or maybe "Run with timers disabled"
> .
>
> My implementation idea was to test in parent delay() method a check for
> this option and return immediately if it is on.
>
> This would make it simple to implement and would not be persisted in Test
> Plan nor disabling of Timers would occur.
> What do you think ?
>
> Regards
> Philippe
>
>
> On Thu, Oct 13, 2011 at 12:59 PM,  wrote:
>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=52019
>>
>> --- Comment #1 from Sebb  2011-10-13 10:59:33 UTC ---
>> Rather than a Menu item, perhaps it should be a Test Plan option, which
>> would
>> mean checking for it in the engine code. But I think it would be simpler
>> overall.
>>
>> If done via a Menu option, disabling is easy.
>>
>> However, I assume there would be a re-enable option - what about timers
>> that
>> were originally disabled? Seems wrong to enable those, so the code would
>> have
>> to keep track of which Timers did not need re-enabling.
>>
>> What if the Test Plan were updated in the mean-time? How could one keep
>> track
>> of which Timers to re-enable?
>>
>> Using a Test Plan option would mean it would also work in non-GUI and
>> client-server mode.
>>
>> --
>> Configure bugmail:
>> https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
>> --- You are receiving this mail because: ---
>> You reported the bug.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
> Ubik-Ingénierie
>
>
>
>


-- 
Cordialement.
Philippe Mouawad.
Ubik-Ingénierie

Re: Patch 52001

[sebb]

On 13 October 2011 18:28, Philippe Mouawad  wrote:
> Hello Sebb,
> Do you think we should  implement issue
> 52001
> :
>
>   - Add scroll automatically to Summary Report
>
> The only use case I see is when you label sampler with a variable name,
> otherwise you may scroll but it won't last after some time number of lines
> will stay the same.

Yes, it's only needed in limited circumstances, which is why I don't
really see the need for it.

> If you give me the go, I will patch it.

It's not my personal decision; we make decisions by consensus.
Any committer can veto a change on a technical basis (e.g. it would
break something else) but that is probably not the case here.

If it were me, I would not apply the patch as I cannot see the point;
more code to test and maintain with little benefit.

So I don't support the patch, but if you feel it would be useful I
won't veto it.

-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org

Re: Patch 52001

[Philippe Mouawad]

I agree with you.
Do we close the issue or we wait for other opinions ?

Thanks
Regards
Philippe

On Thu, Oct 13, 2011 at 7:45 PM, sebb  wrote:

> On 13 October 2011 18:28, Philippe Mouawad  wrote:
> > Hello Sebb,
> > Do you think we should  implement issue
> > 52001
> > :
> >
> >   - Add scroll automatically to Summary Report
> >
> > The only use case I see is when you label sampler with a variable name,
> > otherwise you may scroll but it won't last after some time number of
> lines
> > will stay the same.
>
> Yes, it's only needed in limited circumstances, which is why I don't
> really see the need for it.
>
> > If you give me the go, I will patch it.
>
> It's not my personal decision; we make decisions by consensus.
> Any committer can veto a change on a technical basis (e.g. it would
> break something else) but that is probably not the case here.
>
> If it were me, I would not apply the patch as I cannot see the point;
> more code to test and maintain with little benefit.
>
> So I don't support the patch, but if you feel it would be useful I
> won't veto it.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
> For additional commands, e-mail: dev-h...@jakarta.apache.org
>
>


-- 
Cordialement.
Philippe Mouawad.

[VOTE] Apache JMeter TLP

[Rahul Akolkar]

[This vote is being held on dev@jakarta, please reply there. This
message is being sent to multiple lists to make sure most at Jakarta
are informed.]

This is a vote for proposing an Apache JMeter TLP resolution to the
board, with sebb nominated as the first Chair. The full text appears
below [1] and is also on the wiki [2]. Vote will remain open for
atleast 72 hours.

8<
[  ] +1, its time for an Apache JMeter TLP
[  ] +/- 0
[  ] -1, because ...
8<

Cheers,
-Rahul

[1] Establish the Apache JMeter Project

WHEREAS, the Board of Directors deems it to be in the best
interests of the Foundation and consistent with the
Foundation's purpose to establish a Project Management
Committee charged with the creation and maintenance of
open-source software related to a Java desktop
application designed to load test functional behavior and
measure performance, for distribution at no charge to the
public.

NOW, THEREFORE, BE IT RESOLVED, that a Project Management
Committee (PMC), to be known as the "Apache JMeter Project",
be and hereby is established pursuant to Bylaws of the
Foundation; and be it further

RESOLVED, that the Apache JMeter Project be and hereby is
responsible for the creation and maintenance of software
that provides a Java desktop application designed to load
test functional behavior and measure performance; and be it
further

RESOLVED, that the office of "Vice President, Apache JMeter" be
and hereby is created, the person holding such office to
serve at the direction of the Board of Directors as the chair
of the Apache JMeter Project, and to have primary responsibility
for management of the projects within the scope of
responsibility of the Apache JMeter Project; and be it further

RESOLVED, that the persons listed immediately below be and
hereby are appointed to serve as the initial members of the
Apache JMeter Project:

 * Sebastian Bazley (sebb AT a.o)
 * Milamber (milamber AT a.o)
 * Peter Lin (woolfel AT a.o)
 * Henri Yandell (bayard AT a.o)
 * Rahul Akolkar (rahul AT a.o)
 * Oleg Kalnichevski (olegk AT a.o)
 * Rainer Jung (rjung AT a.o)
 * Philippe Mouawad (pmouawad AT a.o)

NOW, THEREFORE, BE IT FURTHER RESOLVED, that Sebastian Bazley
be appointed to the office of Vice President, Apache JMeter, to
serve in accordance with and subject to the direction of the
Board of Directors and the Bylaws of the Foundation until
death, resignation, retirement, removal or disqualification,
or until a successor is appointed; and be it further

RESOLVED, that the initial Apache JMeter PMC be and hereby is
tasked with the creation of a set of bylaws intended to
encourage open development and increased participation in the
Apache JMeter Project; and be it further

RESOLVED, that the Apache JMeter Project be and hereby
is tasked with the migration and rationalization of the Apache
Jakarta JMeter sub-project; and be it further

RESOLVED, that all responsibilities pertaining to the Apache
Jakarta JMeter sub-project encumbered upon the Apache Jakarta
Project are hereafter discharged.


[2] http://wiki.apache.org/jakarta/TLPJMeter (version 7 of wiki page)

-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org

Re: [VOTE] Apache JMeter TLP

[Peter Lin]

0

On Thu, Oct 13, 2011 at 2:04 PM, Rahul Akolkar  wrote:
> [This vote is being held on dev@jakarta, please reply there. This
> message is being sent to multiple lists to make sure most at Jakarta
> are informed.]
>
> This is a vote for proposing an Apache JMeter TLP resolution to the
> board, with sebb nominated as the first Chair. The full text appears
> below [1] and is also on the wiki [2]. Vote will remain open for
> atleast 72 hours.
>
> 8<
> [  ] +1, its time for an Apache JMeter TLP
> [  ] +/- 0
> [  ] -1, because ...
> 8<
>
> Cheers,
> -Rahul
>
> [1] Establish the Apache JMeter Project
>
> WHEREAS, the Board of Directors deems it to be in the best
> interests of the Foundation and consistent with the
> Foundation's purpose to establish a Project Management
> Committee charged with the creation and maintenance of
> open-source software related to a Java desktop
> application designed to load test functional behavior and
> measure performance, for distribution at no charge to the
> public.
>
> NOW, THEREFORE, BE IT RESOLVED, that a Project Management
> Committee (PMC), to be known as the "Apache JMeter Project",
> be and hereby is established pursuant to Bylaws of the
> Foundation; and be it further
>
> RESOLVED, that the Apache JMeter Project be and hereby is
> responsible for the creation and maintenance of software
> that provides a Java desktop application designed to load
> test functional behavior and measure performance; and be it
> further
>
> RESOLVED, that the office of "Vice President, Apache JMeter" be
> and hereby is created, the person holding such office to
> serve at the direction of the Board of Directors as the chair
> of the Apache JMeter Project, and to have primary responsibility
> for management of the projects within the scope of
> responsibility of the Apache JMeter Project; and be it further
>
> RESOLVED, that the persons listed immediately below be and
> hereby are appointed to serve as the initial members of the
> Apache JMeter Project:
>
>  * Sebastian Bazley (sebb AT a.o)
>  * Milamber (milamber AT a.o)
>  * Peter Lin (woolfel AT a.o)
>  * Henri Yandell (bayard AT a.o)
>  * Rahul Akolkar (rahul AT a.o)
>  * Oleg Kalnichevski (olegk AT a.o)
>  * Rainer Jung (rjung AT a.o)
>  * Philippe Mouawad (pmouawad AT a.o)
>
> NOW, THEREFORE, BE IT FURTHER RESOLVED, that Sebastian Bazley
> be appointed to the office of Vice President, Apache JMeter, to
> serve in accordance with and subject to the direction of the
> Board of Directors and the Bylaws of the Foundation until
> death, resignation, retirement, removal or disqualification,
> or until a successor is appointed; and be it further
>
> RESOLVED, that the initial Apache JMeter PMC be and hereby is
> tasked with the creation of a set of bylaws intended to
> encourage open development and increased participation in the
> Apache JMeter Project; and be it further
>
> RESOLVED, that the Apache JMeter Project be and hereby
> is tasked with the migration and rationalization of the Apache
> Jakarta JMeter sub-project; and be it further
>
> RESOLVED, that all responsibilities pertaining to the Apache
> Jakarta JMeter sub-project encumbered upon the Apache Jakarta
> Project are hereafter discharged.
>
>
> [2] http://wiki.apache.org/jakarta/TLPJMeter (version 7 of wiki page)
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
> For additional commands, e-mail: dev-h...@jakarta.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org

Re: Patch 52001

[sebb]

On 13 October 2011 18:47, Philippe Mouawad  wrote:
> I agree with you.

By the way, please don't top-post; it's harder to follow the thread
when it appears in reverse order.

> Do we close the issue or we wait for other opinions ?

We can wait a while, and then close it.

> Thanks
> Regards
> Philippe
>
> On Thu, Oct 13, 2011 at 7:45 PM, sebb  wrote:
>
>> On 13 October 2011 18:28, Philippe Mouawad  wrote:
>> > Hello Sebb,
>> > Do you think we should  implement issue
>> > 52001
>> > :
>> >
>> >   - Add scroll automatically to Summary Report
>> >
>> > The only use case I see is when you label sampler with a variable name,
>> > otherwise you may scroll but it won't last after some time number of
>> lines
>> > will stay the same.
>>
>> Yes, it's only needed in limited circumstances, which is why I don't
>> really see the need for it.
>>
>> > If you give me the go, I will patch it.
>>
>> It's not my personal decision; we make decisions by consensus.
>> Any committer can veto a change on a technical basis (e.g. it would
>> break something else) but that is probably not the case here.
>>
>> If it were me, I would not apply the patch as I cannot see the point;
>> more code to test and maintain with little benefit.
>>
>> So I don't support the patch, but if you feel it would be useful I
>> won't veto it.
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
>> For additional commands, e-mail: dev-h...@jakarta.apache.org
>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>

-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org

Re: [VOTE] Apache JMeter TLP

[Milamber]

+1, its time for an Apache JMeter TLP

Milamber



Le 13/10/2011 18:04, Rahul Akolkar a ecrit :
> [This vote is being held on dev@jakarta, please reply there. This
> message is being sent to multiple lists to make sure most at Jakarta
> are informed.]
>
> This is a vote for proposing an Apache JMeter TLP resolution to the
> board, with sebb nominated as the first Chair. The full text appears
> below [1] and is also on the wiki [2]. Vote will remain open for
> atleast 72 hours.
>
> 8<
> [  ] +1, its time for an Apache JMeter TLP
> [  ] +/- 0
> [  ] -1, because ...
> 8<
>
> Cheers,
> -Rahul
>
> [1] Establish the Apache JMeter Project
>
> WHEREAS, the Board of Directors deems it to be in the best
> interests of the Foundation and consistent with the
> Foundation's purpose to establish a Project Management
> Committee charged with the creation and maintenance of
> open-source software related to a Java desktop
> application designed to load test functional behavior and
> measure performance, for distribution at no charge to the
> public.
>
> NOW, THEREFORE, BE IT RESOLVED, that a Project Management
> Committee (PMC), to be known as the "Apache JMeter Project",
> be and hereby is established pursuant to Bylaws of the
> Foundation; and be it further
>
> RESOLVED, that the Apache JMeter Project be and hereby is
> responsible for the creation and maintenance of software
> that provides a Java desktop application designed to load
> test functional behavior and measure performance; and be it
> further
>
> RESOLVED, that the office of "Vice President, Apache JMeter" be
> and hereby is created, the person holding such office to
> serve at the direction of the Board of Directors as the chair
> of the Apache JMeter Project, and to have primary responsibility
> for management of the projects within the scope of
> responsibility of the Apache JMeter Project; and be it further
>
> RESOLVED, that the persons listed immediately below be and
> hereby are appointed to serve as the initial members of the
> Apache JMeter Project:
>
>  * Sebastian Bazley (sebb AT a.o)
>  * Milamber (milamber AT a.o)
>  * Peter Lin (woolfel AT a.o)
>  * Henri Yandell (bayard AT a.o)
>  * Rahul Akolkar (rahul AT a.o)
>  * Oleg Kalnichevski (olegk AT a.o)
>  * Rainer Jung (rjung AT a.o)
>  * Philippe Mouawad (pmouawad AT a.o)
>
> NOW, THEREFORE, BE IT FURTHER RESOLVED, that Sebastian Bazley
> be appointed to the office of Vice President, Apache JMeter, to
> serve in accordance with and subject to the direction of the
> Board of Directors and the Bylaws of the Foundation until
> death, resignation, retirement, removal or disqualification,
> or until a successor is appointed; and be it further
>
> RESOLVED, that the initial Apache JMeter PMC be and hereby is
> tasked with the creation of a set of bylaws intended to
> encourage open development and increased participation in the
> Apache JMeter Project; and be it further
>
> RESOLVED, that the Apache JMeter Project be and hereby
> is tasked with the migration and rationalization of the Apache
> Jakarta JMeter sub-project; and be it further
>
> RESOLVED, that all responsibilities pertaining to the Apache
> Jakarta JMeter sub-project encumbered upon the Apache Jakarta
> Project are hereafter discharged.
>
>
> [2] http://wiki.apache.org/jakarta/TLPJMeter (version 7 of wiki page)
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
> For additional commands, e-mail: dev-h...@jakarta.apache.org
>
>
>   


-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org

Re: [VOTE] Apache JMeter TLP

[Philippe Mouawad]

+1, its time for an Apache JMeter TLP
Philippe

On Thursday, October 13, 2011, Milamber  wrote:
> +1, its time for an Apache JMeter TLP
>
> Milamber
>
>
>
> Le 13/10/2011 18:04, Rahul Akolkar a ecrit :
>> [This vote is being held on dev@jakarta, please reply there. This
>> message is being sent to multiple lists to make sure most at Jakarta
>> are informed.]
>>
>> This is a vote for proposing an Apache JMeter TLP resolution to the
>> board, with sebb nominated as the first Chair. The full text appears
>> below [1] and is also on the wiki [2]. Vote will remain open for
>> atleast 72 hours.
>>
>> 8<
>> [  ] +1, its time for an Apache JMeter TLP
>> [  ] +/- 0
>> [  ] -1, because ...
>> 8<
>>
>> Cheers,
>> -Rahul
>>
>> [1] Establish the Apache JMeter Project
>>
>> WHEREAS, the Board of Directors deems it to be in the best
>> interests of the Foundation and consistent with the
>> Foundation's purpose to establish a Project Management
>> Committee charged with the creation and maintenance of
>> open-source software related to a Java desktop
>> application designed to load test functional behavior and
>> measure performance, for distribution at no charge to the
>> public.
>>
>> NOW, THEREFORE, BE IT RESOLVED, that a Project Management
>> Committee (PMC), to be known as the "Apache JMeter Project",
>> be and hereby is established pursuant to Bylaws of the
>> Foundation; and be it further
>>
>> RESOLVED, that the Apache JMeter Project be and hereby is
>> responsible for the creation and maintenance of software
>> that provides a Java desktop application designed to load
>> test functional behavior and measure performance; and be it
>> further
>>
>> RESOLVED, that the office of "Vice President, Apache JMeter" be
>> and hereby is created, the person holding such office to
>> serve at the direction of the Board of Directors as the chair
>> of the Apache JMeter Project, and to have primary responsibility
>> for management of the projects within the scope of
>> responsibility of the Apache JMeter Project; and be it further
>>
>> RESOLVED, that the persons listed immediately below be and
>> hereby are appointed to serve as the initial members of the
>> Apache JMeter Project:
>>
>>  * Sebastian Bazley (sebb AT a.o)
>>  * Milamber (milamber AT a.o)
>>  * Peter Lin (woolfel AT a.o)
>>  * Henri Yandell (bayard AT a.o)
>>  * Rahul Akolkar (rahul AT a.o)
>>  * Oleg Kalnichevski (olegk AT a.o)
>>  * Rainer Jung (rjung AT a.o)
>>  * Philippe Mouawad (pmouawad AT a.o)
>>
>> NOW, THEREFORE, BE IT FURTHER RESOLVED, that Sebastian Bazley
>> be appointed to the office of Vice President, Apache JMeter, to
>> serve in accordance with and subject to the direction of the
>> Board of Directors and the Bylaws of the Foundation until
>> death, resignation, retirement, removal or disqualification,
>> or until a successor is appointed; and be it further
>>
>> RESOLVED, that the initial Apache JMeter PMC be and hereby is
>> tasked with the creation of a set of bylaws intended to
>> encourage open development and increased participation in the
>> Apache JMeter Project; and be it further
>>
>> RESOLVED, that the Apache JMeter Project be and hereby
>> is tasked with the migration and rationalization of the Apache
>> Jakarta JMeter sub-project; and be it further
>>
>> RESOLVED, that all responsibilities pertaining to the Apache
>> Jakarta JMeter sub-project encumbered upon the Apache Jakarta
>> Project are hereafter discharged.
>>
>>
>> [2] http://wiki.apache.org/jakarta/TLPJMeter (version 7 of wiki page)
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
>> For additional commands, e-mail: dev-h...@jakarta.apache.org
>>
>>
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
> For additional commands, e-mail: dev-h...@jakarta.apache.org
>
>

-- 
Cordialement.
Philippe Mouawad.

Re: DO NOT REPLY [Bug 52019] Add menu option to enable/disable timers when running Plan

[sebb]

On 13 October 2011 18:34, Philippe Mouawad
 wrote:
> Hello Sebb,
> Do you agree with this proposition :
>
>   - Add an Menu Option called "Run with timers disabled"

I see - so it would only apply to GUI runs - that's reasonable.

>   - This option will set a boolean on GuiPackage#getinstance() called
>   noTimersPause
>   - Timers will consult this option to decide whether to run or not pause

That would require changing all timers; what happens about 3rd party timers?
See below for simpler option.

>   - At end of run option will be reset (what would be the best way to
>   detect end, StandardJMeterEngine#run after waitThreadsStopped ?)
>

The GUI Start code has to clone and traverse the tree before passing
it to the engine, so it could remove the Timers there.
Disabled elements are removed anyway, so it could alternatively
disable them if that was easier.

Perhaps create a subclass of TreeCloner that skips Timers.

No need to reset the option afterwards.

> If you are Ok, I can implement it.
>
> Regards
> Philippe
>
> On Thu, Oct 13, 2011 at 1:09 PM, Philippe Mouawad <
> p.moua...@ubik-ingenierie.com> wrote:
>
>> Hello Sebb,
>> In my opinion this option would be useful only in Scripting Phase so
>> through GUI.
>> That's why I wanted it as a Menu Option or maybe "Run with timers disabled"
>> .
>>
>> My implementation idea was to test in parent delay() method a check for
>> this option and return immediately if it is on.
>>
>> This would make it simple to implement and would not be persisted in Test
>> Plan nor disabling of Timers would occur.
>> What do you think ?
>>
>> Regards
>> Philippe
>>
>>
>> On Thu, Oct 13, 2011 at 12:59 PM,  wrote:
>>
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=52019
>>>
>>> --- Comment #1 from Sebb  2011-10-13 10:59:33 UTC ---
>>> Rather than a Menu item, perhaps it should be a Test Plan option, which
>>> would
>>> mean checking for it in the engine code. But I think it would be simpler
>>> overall.
>>>
>>> If done via a Menu option, disabling is easy.
>>>
>>> However, I assume there would be a re-enable option - what about timers
>>> that
>>> were originally disabled? Seems wrong to enable those, so the code would
>>> have
>>> to keep track of which Timers did not need re-enabling.
>>>
>>> What if the Test Plan were updated in the mean-time? How could one keep
>>> track
>>> of which Timers to re-enable?
>>>
>>> Using a Test Plan option would mean it would also work in non-GUI and
>>> client-server mode.
>>>
>>> --
>>> Configure bugmail:
>>> https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
>>> --- You are receiving this mail because: ---
>>> You reported the bug.
>>>
>>
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>> Ubik-Ingénierie
>>
>>
>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
> Ubik-Ingénierie
>

-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org

Re: [VOTE] Apache JMeter TLP

[Siegfried Goeschl]

+1

Cheers,

Siegfried Goeschl

On 13.10.11 20:04, Rahul Akolkar wrote:

[This vote is being held on dev@jakarta, please reply there. This
message is being sent to multiple lists to make sure most at Jakarta
are informed.]

This is a vote for proposing an Apache JMeter TLP resolution to the
board, with sebb nominated as the first Chair. The full text appears
below [1] and is also on the wiki [2]. Vote will remain open for
atleast 72 hours.

8<
[  ] +1, its time for an Apache JMeter TLP
[  ] +/- 0
[  ] -1, because ...
8<

Cheers,
-Rahul

[1] Establish the Apache JMeter Project

WHEREAS, the Board of Directors deems it to be in the best
interests of the Foundation and consistent with the
Foundation's purpose to establish a Project Management
Committee charged with the creation and maintenance of
open-source software related to a Java desktop
application designed to load test functional behavior and
measure performance, for distribution at no charge to the
public.

NOW, THEREFORE, BE IT RESOLVED, that a Project Management
Committee (PMC), to be known as the "Apache JMeter Project",
be and hereby is established pursuant to Bylaws of the
Foundation; and be it further

RESOLVED, that the Apache JMeter Project be and hereby is
responsible for the creation and maintenance of software
that provides a Java desktop application designed to load
test functional behavior and measure performance; and be it
further

RESOLVED, that the office of "Vice President, Apache JMeter" be
and hereby is created, the person holding such office to
serve at the direction of the Board of Directors as the chair
of the Apache JMeter Project, and to have primary responsibility
for management of the projects within the scope of
responsibility of the Apache JMeter Project; and be it further

RESOLVED, that the persons listed immediately below be and
hereby are appointed to serve as the initial members of the
Apache JMeter Project:

  * Sebastian Bazley (sebb AT a.o)
  * Milamber (milamber AT a.o)
  * Peter Lin (woolfel AT a.o)
  * Henri Yandell (bayard AT a.o)
  * Rahul Akolkar (rahul AT a.o)
  * Oleg Kalnichevski (olegk AT a.o)
  * Rainer Jung (rjung AT a.o)
  * Philippe Mouawad (pmouawad AT a.o)

NOW, THEREFORE, BE IT FURTHER RESOLVED, that Sebastian Bazley
be appointed to the office of Vice President, Apache JMeter, to
serve in accordance with and subject to the direction of the
Board of Directors and the Bylaws of the Foundation until
death, resignation, retirement, removal or disqualification,
or until a successor is appointed; and be it further

RESOLVED, that the initial Apache JMeter PMC be and hereby is
tasked with the creation of a set of bylaws intended to
encourage open development and increased participation in the
Apache JMeter Project; and be it further

RESOLVED, that the Apache JMeter Project be and hereby
is tasked with the migration and rationalization of the Apache
Jakarta JMeter sub-project; and be it further

RESOLVED, that all responsibilities pertaining to the Apache
Jakarta JMeter sub-project encumbered upon the Apache Jakarta
Project are hereafter discharged.


[2] http://wiki.apache.org/jakarta/TLPJMeter (version 7 of wiki page)

-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org

Re: [VOTE] Apache JMeter TLP

[Oleg Kalnichevski]

[x] +1, its time for an Apache JMeter TLP

On Thu, 2011-10-13 at 14:04 -0400, Rahul Akolkar wrote:
> [This vote is being held on dev@jakarta, please reply there. This
> message is being sent to multiple lists to make sure most at Jakarta
> are informed.]
> 
> This is a vote for proposing an Apache JMeter TLP resolution to the
> board, with sebb nominated as the first Chair. The full text appears
> below [1] and is also on the wiki [2]. Vote will remain open for
> atleast 72 hours.
> 
> 8<
> [  ] +1, its time for an Apache JMeter TLP
> [  ] +/- 0
> [  ] -1, because ...
> 8<
> 
> Cheers,
> -Rahul
> 
> [1] Establish the Apache JMeter Project
> 
> WHEREAS, the Board of Directors deems it to be in the best
> interests of the Foundation and consistent with the
> Foundation's purpose to establish a Project Management
> Committee charged with the creation and maintenance of
> open-source software related to a Java desktop
> application designed to load test functional behavior and
> measure performance, for distribution at no charge to the
> public.
> 
> NOW, THEREFORE, BE IT RESOLVED, that a Project Management
> Committee (PMC), to be known as the "Apache JMeter Project",
> be and hereby is established pursuant to Bylaws of the
> Foundation; and be it further
> 
> RESOLVED, that the Apache JMeter Project be and hereby is
> responsible for the creation and maintenance of software
> that provides a Java desktop application designed to load
> test functional behavior and measure performance; and be it
> further
> 
> RESOLVED, that the office of "Vice President, Apache JMeter" be
> and hereby is created, the person holding such office to
> serve at the direction of the Board of Directors as the chair
> of the Apache JMeter Project, and to have primary responsibility
> for management of the projects within the scope of
> responsibility of the Apache JMeter Project; and be it further
> 
> RESOLVED, that the persons listed immediately below be and
> hereby are appointed to serve as the initial members of the
> Apache JMeter Project:
> 
>  * Sebastian Bazley (sebb AT a.o)
>  * Milamber (milamber AT a.o)
>  * Peter Lin (woolfel AT a.o)
>  * Henri Yandell (bayard AT a.o)
>  * Rahul Akolkar (rahul AT a.o)
>  * Oleg Kalnichevski (olegk AT a.o)
>  * Rainer Jung (rjung AT a.o)
>  * Philippe Mouawad (pmouawad AT a.o)
> 
> NOW, THEREFORE, BE IT FURTHER RESOLVED, that Sebastian Bazley
> be appointed to the office of Vice President, Apache JMeter, to
> serve in accordance with and subject to the direction of the
> Board of Directors and the Bylaws of the Foundation until
> death, resignation, retirement, removal or disqualification,
> or until a successor is appointed; and be it further
> 
> RESOLVED, that the initial Apache JMeter PMC be and hereby is
> tasked with the creation of a set of bylaws intended to
> encourage open development and increased participation in the
> Apache JMeter Project; and be it further
> 
> RESOLVED, that the Apache JMeter Project be and hereby
> is tasked with the migration and rationalization of the Apache
> Jakarta JMeter sub-project; and be it further
> 
> RESOLVED, that all responsibilities pertaining to the Apache
> Jakarta JMeter sub-project encumbered upon the Apache Jakarta
> Project are hereafter discharged.
> 
> 
> [2] http://wiki.apache.org/jakarta/TLPJMeter (version 7 of wiki page)
> 



-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org

Re: DO NOT REPLY [Bug 52019] Add menu option to enable/disable timers when running Plan

[Philippe Mouawad]

Thanks for your advice, it is much better implementation
I implemented it this way.

On Thu, Oct 13, 2011 at 8:23 PM, sebb  wrote:

> On 13 October 2011 18:34, Philippe Mouawad
>  wrote:
> > Hello Sebb,
> > Do you agree with this proposition :
> >
> >   - Add an Menu Option called "Run with timers disabled"
>
> I see - so it would only apply to GUI runs - that's reasonable.
>
> >   - This option will set a boolean on GuiPackage#getinstance() called
> >   noTimersPause
> >   - Timers will consult this option to decide whether to run or not pause
>
> That would require changing all timers; what happens about 3rd party
> timers?
> See below for simpler option.
>
> >   - At end of run option will be reset (what would be the best way to
> >   detect end, StandardJMeterEngine#run after waitThreadsStopped ?)
> >
>
> The GUI Start code has to clone and traverse the tree before passing
> it to the engine, so it could remove the Timers there.
> Disabled elements are removed anyway, so it could alternatively
> disable them if that was easier.
>
> Perhaps create a subclass of TreeCloner that skips Timers.
>
> No need to reset the option afterwards.
>
> > If you are Ok, I can implement it.
> >
> > Regards
> > Philippe
> >
> > On Thu, Oct 13, 2011 at 1:09 PM, Philippe Mouawad <
> > p.moua...@ubik-ingenierie.com> wrote:
> >
> >> Hello Sebb,
> >> In my opinion this option would be useful only in Scripting Phase so
> >> through GUI.
> >> That's why I wanted it as a Menu Option or maybe "Run with timers
> disabled"
> >> .
> >>
> >> My implementation idea was to test in parent delay() method a check for
> >> this option and return immediately if it is on.
> >>
> >> This would make it simple to implement and would not be persisted in
> Test
> >> Plan nor disabling of Timers would occur.
> >> What do you think ?
> >>
> >> Regards
> >> Philippe
> >>
> >>
> >> On Thu, Oct 13, 2011 at 12:59 PM,  wrote:
> >>
> >>> https://issues.apache.org/bugzilla/show_bug.cgi?id=52019
> >>>
> >>> --- Comment #1 from Sebb  2011-10-13 10:59:33 UTC ---
> >>> Rather than a Menu item, perhaps it should be a Test Plan option, which
> >>> would
> >>> mean checking for it in the engine code. But I think it would be
> simpler
> >>> overall.
> >>>
> >>> If done via a Menu option, disabling is easy.
> >>>
> >>> However, I assume there would be a re-enable option - what about timers
> >>> that
> >>> were originally disabled? Seems wrong to enable those, so the code
> would
> >>> have
> >>> to keep track of which Timers did not need re-enabling.
> >>>
> >>> What if the Test Plan were updated in the mean-time? How could one keep
> >>> track
> >>> of which Timers to re-enable?
> >>>
> >>> Using a Test Plan option would mean it would also work in non-GUI and
> >>> client-server mode.
> >>>
> >>> --
> >>> Configure bugmail:
> >>> https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> >>> --- You are receiving this mail because: ---
> >>> You reported the bug.
> >>>
> >>
> >>
> >>
> >> --
> >> Cordialement.
> >> Philippe Mouawad.
> >> Ubik-Ingénierie
> >>
> >>
> >>
> >>
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> > Ubik-Ingénierie
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
> For additional commands, e-mail: dev-h...@jakarta.apache.org
>
>


-- 
Cordialement.
Philippe Mouawad.

Re: svn commit: r1183065 - in /jakarta/jmeter/trunk: src/core/org/apache/jmeter/engine/ src/core/org/apache/jmeter/gui/action/ src/core/org/apache/jmeter/gui/util/ src/core/org/apache/jmeter/resources

[sebb]

On 13 October 2011 21:12,   wrote:
> Author: pmouawad
> Date: Thu Oct 13 20:12:23 2011
> New Revision: 1183065
>
> URL: http://svn.apache.org/viewvc?rev=1183065&view=rev
> Log:
> Bug 52019 - Add menu option to Start a test ignoring Pause Timers
>
> Added:
>    
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java 
>   (with props)
> Modified:
>    jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java
>    jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/ActionNames.java
>    jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/Start.java
>    jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java
>    
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
>    
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_es.properties
>    
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
>    
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_pt_BR.properties
>    jakarta/jmeter/trunk/xdocs/changes.xml
>
> Modified: 
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java
> URL: 
> http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java?rev=1183065&r1=1183064&r2=1183065&view=diff
> ==
> --- jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java 
> (original)
> +++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java 
> Thu Oct 13 20:12:23 2011
> @@ -56,7 +56,6 @@ public class TreeCloner implements HashT
>     }
>
>     public void addNode(Object node, HashTree subTree) {
> -
>         if ( (node instanceof TestElement) // Check can cast for clone
>            // Don't clone NoThreadClone unless honourNoThreadClone == false
>           && (!honourNoThreadClone || !(node instanceof NoThreadClone))
> @@ -66,6 +65,14 @@ public class TreeCloner implements HashT
>         } else {
>             newTree.add(objects, node);
>         }
> +        addLast(node);
> +    }
> +
> +    /**
> +     * add node to objects LinkedList
> +     * @param node Object
> +     */
> +    protected final void addLast(Object node) {
>         objects.addLast(node);
>     }

OK, so subclasses can override this to skip adding a node.

>
> Added: 
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java
> URL: 
> http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java?rev=1183065&view=auto
> ==
> --- 
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java 
> (added)
> +++ 
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java 
> Thu Oct 13 20:12:23 2011
> @@ -0,0 +1,59 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements.  See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License.  You may obtain a copy of the License at
> + *
> + *   http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + *
> + */
> +
> +package org.apache.jmeter.engine;
> +
> +import org.apache.jmeter.timers.Timer;
> +import org.apache.jorphan.collections.HashTree;
> +import org.apache.jorphan.logging.LoggingManager;
> +import org.apache.log.Logger;
> +
> +/**
> + * Clones the test tree,  skipping test elements that implement {@link 
> Timer} by default.
> + */
> +public class TreeClonerNoTimer extends TreeCloner{
> +    private Logger logger = LoggingManager.getLoggerForClass();
> +
> +    /**
> +     * {@inheritDoc}
> +     */
> +    public TreeClonerNoTimer() {
> +        super();
> +    }
> +
> +    /**
> +     * {@inheritDoc}
> +     */
> +    public TreeClonerNoTimer(boolean honourNoThreadClone) {
> +        super(honourNoThreadClone);
> +    }
> +
> +    /**
> +     * {@inheritDoc}
> +     */

@Override?

> +    public void addNode(Object node, HashTree subTree) {
> +        if(!(node instanceof Timer)) {

It's confusing to use negative conditions

> +            super.addNode(node, subTree);
> +        } else {
> +            if(logger.isDebugEnabled()) {
> +                logger.debug("Ignoring timer node:"+ node);
> +            }
> +            addLast(node);

This looks wrong, surely you don't want to add the nod

Re: svn commit: r1183065 - in /jakarta/jmeter/trunk: src/core/org/apache/jmeter/engine/ src/core/org/apache/jmeter/gui/action/ src/core/org/apache/jmeter/gui/util/ src/core/org/apache/jmeter/resources

[Philippe Mouawad]

On Thu, Oct 13, 2011 at 10:26 PM, sebb  wrote:

> On 13 October 2011 21:12,   wrote:
> > Author: pmouawad
> > Date: Thu Oct 13 20:12:23 2011
> > New Revision: 1183065
> >
> > URL: http://svn.apache.org/viewvc?rev=1183065&view=rev
> > Log:
> > Bug 52019 - Add menu option to Start a test ignoring Pause Timers
> >
> > Added:
> >
>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java
>   (with props)
> > Modified:
> >jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java
> >
>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/ActionNames.java
> >jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/Start.java
> >
>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java
> >
>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
> >
>  
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_es.properties
> >
>  
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
> >
>  
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_pt_BR.properties
> >jakarta/jmeter/trunk/xdocs/changes.xml
> >
> > Modified:
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java
> > URL:
> http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java?rev=1183065&r1=1183064&r2=1183065&view=diff
> >
> ==
> > ---
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java
> (original)
> > +++
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java Thu
> Oct 13 20:12:23 2011
> > @@ -56,7 +56,6 @@ public class TreeCloner implements HashT
> > }
> >
> > public void addNode(Object node, HashTree subTree) {
> > -
> > if ( (node instanceof TestElement) // Check can cast for clone
> >// Don't clone NoThreadClone unless honourNoThreadClone ==
> false
> >   && (!honourNoThreadClone || !(node instanceof NoThreadClone))
> > @@ -66,6 +65,14 @@ public class TreeCloner implements HashT
> > } else {
> > newTree.add(objects, node);
> > }
> > +addLast(node);
> > +}
> > +
> > +/**
> > + * add node to objects LinkedList
> > + * @param node Object
> > + */
> > +protected final void addLast(Object node) {
> > objects.addLast(node);
> > }
>
> OK, so subclasses can override this to skip adding a node.
>
> >
> > Added:
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java
> > URL:
> http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java?rev=1183065&view=auto
> >
> ==
> > ---
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java
> (added)
> > +++
> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java
> Thu Oct 13 20:12:23 2011
> > @@ -0,0 +1,59 @@
> > +/*
> > + * Licensed to the Apache Software Foundation (ASF) under one or more
> > + * contributor license agreements.  See the NOTICE file distributed with
> > + * this work for additional information regarding copyright ownership.
> > + * The ASF licenses this file to You under the Apache License, Version
> 2.0
> > + * (the "License"); you may not use this file except in compliance with
> > + * the License.  You may obtain a copy of the License at
> > + *
> > + *   http://www.apache.org/licenses/LICENSE-2.0
> > + *
> > + * Unless required by applicable law or agreed to in writing, software
> > + * distributed under the License is distributed on an "AS IS" BASIS,
> > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> > + * See the License for the specific language governing permissions and
> > + * limitations under the License.
> > + *
> > + */
> > +
> > +package org.apache.jmeter.engine;
> > +
> > +import org.apache.jmeter.timers.Timer;
> > +import org.apache.jorphan.collections.HashTree;
> > +import org.apache.jorphan.logging.LoggingManager;
> > +import org.apache.log.Logger;
> > +
> > +/**
> > + * Clones the test tree,  skipping test elements that implement {@link
> Timer} by default.
> > + */
> > +public class TreeClonerNoTimer extends TreeCloner{
> > +private Logger logger = LoggingManager.getLoggerForClass();
> > +
> > +/**
> > + * {@inheritDoc}
> > + */
> > +public TreeClonerNoTimer() {
> > +super();
> > +}
> > +
> > +/**
> > + * {@inheritDoc}
> > + */
> > +public TreeClonerNoTimer(boolean honourNoThreadClone) {
> > +super(honourNoThreadClone);
> > +}
> > +
> > +/**
> > + * {@inheritDoc}
> > + */
>
> @Override?
>
> > +public void addNode(Object node, HashTree subTree) {
> > +if(!(node instanceof Timer)) {
>
> It's confusing to use negative conditions
>

It's f

Re: svn commit: r1183065 - in /jakarta/jmeter/trunk: src/core/org/apache/jmeter/engine/ src/core/org/apache/jmeter/gui/action/ src/core/org/apache/jmeter/gui/util/ src/core/org/apache/jmeter/resources

[Philippe Mouawad]

I changed implementation a little.
Added @Override (as I didn't see it in other classes, didn't add it)

About negative condition, Start should generally be called more frequently
that the new option so put it first.

Regards
Philippe

On Thu, Oct 13, 2011 at 10:29 PM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

>
>
> On Thu, Oct 13, 2011 at 10:26 PM, sebb  wrote:
>
>> On 13 October 2011 21:12,   wrote:
>> > Author: pmouawad
>> > Date: Thu Oct 13 20:12:23 2011
>> > New Revision: 1183065
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1183065&view=rev
>> > Log:
>> > Bug 52019 - Add menu option to Start a test ignoring Pause Timers
>> >
>> > Added:
>> >
>>  
>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java
>>   (with props)
>> > Modified:
>> >
>>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java
>> >
>>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/ActionNames.java
>> >jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/Start.java
>> >
>>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java
>> >
>>  
>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
>> >
>>  
>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_es.properties
>> >
>>  
>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
>> >
>>  
>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_pt_BR.properties
>> >jakarta/jmeter/trunk/xdocs/changes.xml
>> >
>> > Modified:
>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java
>> > URL:
>> http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java?rev=1183065&r1=1183064&r2=1183065&view=diff
>> >
>> ==
>> > ---
>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java
>> (original)
>> > +++
>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java Thu
>> Oct 13 20:12:23 2011
>> > @@ -56,7 +56,6 @@ public class TreeCloner implements HashT
>> > }
>> >
>> > public void addNode(Object node, HashTree subTree) {
>> > -
>> > if ( (node instanceof TestElement) // Check can cast for clone
>> >// Don't clone NoThreadClone unless honourNoThreadClone ==
>> false
>> >   && (!honourNoThreadClone || !(node instanceof NoThreadClone))
>> > @@ -66,6 +65,14 @@ public class TreeCloner implements HashT
>> > } else {
>> > newTree.add(objects, node);
>> > }
>> > +addLast(node);
>> > +}
>> > +
>> > +/**
>> > + * add node to objects LinkedList
>> > + * @param node Object
>> > + */
>> > +protected final void addLast(Object node) {
>> > objects.addLast(node);
>> > }
>>
>> OK, so subclasses can override this to skip adding a node.
>>
>> >
>> > Added:
>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java
>> > URL:
>> http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java?rev=1183065&view=auto
>> >
>> ==
>> > ---
>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java
>> (added)
>> > +++
>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java
>> Thu Oct 13 20:12:23 2011
>> > @@ -0,0 +1,59 @@
>> > +/*
>> > + * Licensed to the Apache Software Foundation (ASF) under one or more
>> > + * contributor license agreements.  See the NOTICE file distributed
>> with
>> > + * this work for additional information regarding copyright ownership.
>> > + * The ASF licenses this file to You under the Apache License, Version
>> 2.0
>> > + * (the "License"); you may not use this file except in compliance with
>> > + * the License.  You may obtain a copy of the License at
>> > + *
>> > + *   http://www.apache.org/licenses/LICENSE-2.0
>> > + *
>> > + * Unless required by applicable law or agreed to in writing, software
>> > + * distributed under the License is distributed on an "AS IS" BASIS,
>> > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> implied.
>> > + * See the License for the specific language governing permissions and
>> > + * limitations under the License.
>> > + *
>> > + */
>> > +
>> > +package org.apache.jmeter.engine;
>> > +
>> > +import org.apache.jmeter.timers.Timer;
>> > +import org.apache.jorphan.collections.HashTree;
>> > +import org.apache.jorphan.logging.LoggingManager;
>> > +import org.apache.log.Logger;
>> > +
>> > +/**
>> > + * Clones the test tree,  skipping test elements that implement {@link
>> Timer} by default.
>> > + */
>> > +public class TreeClonerNoTimer extends TreeCloner{
>> > +private Logger logger = LoggingManager.getLoggerForClass();
>> > +
>> > +/**
>> > + * {@inheritDoc}
>> > + */
>> > +public

Re: svn commit: r1183065 - in /jakarta/jmeter/trunk: src/core/org/apache/jmeter/engine/ src/core/org/apache/jmeter/gui/action/ src/core/org/apache/jmeter/gui/util/ src/core/org/apache/jmeter/resources

[sebb]

On 13 October 2011 21:44, Philippe Mouawad  wrote:
> I changed implementation a little.

That's much clearer.
However the method private final void addLast(Object node) is no
longer needed and could be inlined.

Sorry, I was confused by the addLast(); thought it was adding to the
new tree, rather than keeping track of the current one.

> Added @Override (as I didn't see it in other classes, didn't add it)

OK

> About negative condition, Start should generally be called more frequently
> that the new option so put it first.

There is only one condition check.

Surely the following have the same performance.

Positive:

if (node instanceof Timer) {
   return node;
} else {
  return super.addNodeToTree(node);
}

Negative:

if (!(node instanceof Timer)) {
  return super.addNodeToTree(node);
} else {
  return node;
}

I agree where there are multiple conditions, best to check the
cheapest first, but here there is only one check.

It's important for code to be readable.

> Regards
> Philippe
>
> On Thu, Oct 13, 2011 at 10:29 PM, Philippe Mouawad <
> philippe.moua...@gmail.com> wrote:
>
>>
>>
>> On Thu, Oct 13, 2011 at 10:26 PM, sebb  wrote:
>>
>>> On 13 October 2011 21:12,   wrote:
>>> > Author: pmouawad
>>> > Date: Thu Oct 13 20:12:23 2011
>>> > New Revision: 1183065
>>> >
>>> > URL: http://svn.apache.org/viewvc?rev=1183065&view=rev
>>> > Log:
>>> > Bug 52019 - Add menu option to Start a test ignoring Pause Timers
>>> >
>>> > Added:
>>> >
>>>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java
>>>   (with props)
>>> > Modified:
>>> >
>>>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java
>>> >
>>>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/ActionNames.java
>>> >    jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/Start.java
>>> >
>>>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java
>>> >
>>>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
>>> >
>>>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_es.properties
>>> >
>>>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
>>> >
>>>  jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_pt_BR.properties
>>> >    jakarta/jmeter/trunk/xdocs/changes.xml
>>> >
>>> > Modified:
>>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java
>>> > URL:
>>> http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java?rev=1183065&r1=1183064&r2=1183065&view=diff
>>> >
>>> ==
>>> > ---
>>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java
>>> (original)
>>> > +++
>>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeCloner.java Thu
>>> Oct 13 20:12:23 2011
>>> > @@ -56,7 +56,6 @@ public class TreeCloner implements HashT
>>> >     }
>>> >
>>> >     public void addNode(Object node, HashTree subTree) {
>>> > -
>>> >         if ( (node instanceof TestElement) // Check can cast for clone
>>> >            // Don't clone NoThreadClone unless honourNoThreadClone ==
>>> false
>>> >           && (!honourNoThreadClone || !(node instanceof NoThreadClone))
>>> > @@ -66,6 +65,14 @@ public class TreeCloner implements HashT
>>> >         } else {
>>> >             newTree.add(objects, node);
>>> >         }
>>> > +        addLast(node);
>>> > +    }
>>> > +
>>> > +    /**
>>> > +     * add node to objects LinkedList
>>> > +     * @param node Object
>>> > +     */
>>> > +    protected final void addLast(Object node) {
>>> >         objects.addLast(node);
>>> >     }
>>>
>>> OK, so subclasses can override this to skip adding a node.
>>>
>>> >
>>> > Added:
>>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java
>>> > URL:
>>> http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java?rev=1183065&view=auto
>>> >
>>> ==
>>> > ---
>>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java
>>> (added)
>>> > +++
>>> jakarta/jmeter/trunk/src/core/org/apache/jmeter/engine/TreeClonerNoTimer.java
>>> Thu Oct 13 20:12:23 2011
>>> > @@ -0,0 +1,59 @@
>>> > +/*
>>> > + * Licensed to the Apache Software Foundation (ASF) under one or more
>>> > + * contributor license agreements.  See the NOTICE file distributed
>>> with
>>> > + * this work for additional information regarding copyright ownership.
>>> > + * The ASF licenses this file to You under the Apache License, Version
>>> 2.0
>>> > + * (the "License"); you may not use this file except in compliance with
>>> > + * the License.  You may obtain a copy of the License at
>>> > + *
>>> > + *   http://www.apache.org/licenses/LICENSE-2.0
>>> > + *
>>> > + * Unless required by applicable law or agreed to in writing, software
>>> > + * distribut

Re: [VOTE] Apache JMeter TLP

[sebb]

On 13 October 2011 19:04, Rahul Akolkar  wrote:
> [This vote is being held on dev@jakarta, please reply there. This
> message is being sent to multiple lists to make sure most at Jakarta
> are informed.]
>
> This is a vote for proposing an Apache JMeter TLP resolution to the
> board, with sebb nominated as the first Chair. The full text appears
> below [1] and is also on the wiki [2]. Vote will remain open for
> atleast 72 hours.
>
> 8<
> [ X ] +1, its time for an Apache JMeter TLP
> [  ] +/- 0
> [  ] -1, because ...
> 8<
>
> Cheers,
> -Rahul
>
> [1] Establish the Apache JMeter Project
>
> WHEREAS, the Board of Directors deems it to be in the best
> interests of the Foundation and consistent with the
> Foundation's purpose to establish a Project Management
> Committee charged with the creation and maintenance of
> open-source software related to a Java desktop
> application designed to load test functional behavior and
> measure performance, for distribution at no charge to the
> public.
>
> NOW, THEREFORE, BE IT RESOLVED, that a Project Management
> Committee (PMC), to be known as the "Apache JMeter Project",
> be and hereby is established pursuant to Bylaws of the
> Foundation; and be it further
>
> RESOLVED, that the Apache JMeter Project be and hereby is
> responsible for the creation and maintenance of software
> that provides a Java desktop application designed to load
> test functional behavior and measure performance; and be it
> further
>
> RESOLVED, that the office of "Vice President, Apache JMeter" be
> and hereby is created, the person holding such office to
> serve at the direction of the Board of Directors as the chair
> of the Apache JMeter Project, and to have primary responsibility
> for management of the projects within the scope of
> responsibility of the Apache JMeter Project; and be it further
>
> RESOLVED, that the persons listed immediately below be and
> hereby are appointed to serve as the initial members of the
> Apache JMeter Project:
>
>  * Sebastian Bazley (sebb AT a.o)
>  * Milamber (milamber AT a.o)
>  * Peter Lin (woolfel AT a.o)
>  * Henri Yandell (bayard AT a.o)
>  * Rahul Akolkar (rahul AT a.o)
>  * Oleg Kalnichevski (olegk AT a.o)
>  * Rainer Jung (rjung AT a.o)
>  * Philippe Mouawad (pmouawad AT a.o)
>
> NOW, THEREFORE, BE IT FURTHER RESOLVED, that Sebastian Bazley
> be appointed to the office of Vice President, Apache JMeter, to
> serve in accordance with and subject to the direction of the
> Board of Directors and the Bylaws of the Foundation until
> death, resignation, retirement, removal or disqualification,
> or until a successor is appointed; and be it further
>
> RESOLVED, that the initial Apache JMeter PMC be and hereby is
> tasked with the creation of a set of bylaws intended to
> encourage open development and increased participation in the
> Apache JMeter Project; and be it further
>
> RESOLVED, that the Apache JMeter Project be and hereby
> is tasked with the migration and rationalization of the Apache
> Jakarta JMeter sub-project; and be it further
>
> RESOLVED, that all responsibilities pertaining to the Apache
> Jakarta JMeter sub-project encumbered upon the Apache Jakarta
> Project are hereafter discharged.
>
>
> [2] http://wiki.apache.org/jakarta/TLPJMeter (version 7 of wiki page)
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
> For additional commands, e-mail: dev-h...@jakarta.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org

Re: [VOTE] Apache JMeter TLP

[Dave Brosius]

+1


On 13.10.2011 20:04, Rahul Akolkar wrote:

[This vote is being held on dev@jakarta, please reply there. This
message is being sent to multiple lists to make sure most at Jakarta
are informed.]

This is a vote for proposing an Apache JMeter TLP resolution to the
board, with sebb nominated as the first Chair. The full text appears
below [1] and is also on the wiki [2]. Vote will remain open for
atleast 72 hours.

8<
[  ] +1, its time for an Apache JMeter TLP
[  ] +/- 0
[  ] -1, because ...
8<

Cheers,
-Rahul



-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org

Re: [VOTE] Apache JMeter TLP

[Stefan Bodewig]

On 2011-10-13, Rahul Akolkar wrote:

> This is a vote for proposing an Apache JMeter TLP resolution to the
> board, with sebb nominated as the first Chair. The full text appears
> below [1] and is also on the wiki [2]. Vote will remain open for
> atleast 72 hours.

> 8<
> [X] +1, its time for an Apache JMeter TLP
> [  ] +/- 0
> [  ] -1, because ...
> 8<

+1

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org
For additional commands, e-mail: dev-h...@jakarta.apache.org