[jbehave-scm] [739] trunk/plugins/eclipse: Added build.properties to enable easy configurability of lauch properties - which have changed from Eclipse 3.2 to 3.3.

2007-07-10 Thread mauro
Title:  [739] trunk/plugins/eclipse: Added build.properties to enable easy configurability of lauch properties - which have changed from Eclipse 3.2 to 3.3.







Revision 739
Author mauro
Date 2007-07-10 03:28:15 -0500 (Tue, 10 Jul 2007)


Log Message
Added build.properties to enable easy configurability of lauch properties - which have changed from Eclipse 3.2 to 3.3. 

Modified Paths

trunk/plugins/eclipse/build-eclipse.xml
trunk/plugins/eclipse/build.xml


Added Paths

trunk/plugins/eclipse/build.properties




Diff

Modified: trunk/plugins/eclipse/build-eclipse.xml (738 => 739)

--- trunk/plugins/eclipse/build-eclipse.xml	2007-06-16 08:48:51 UTC (rev 738)
+++ trunk/plugins/eclipse/build-eclipse.xml	2007-07-10 08:28:15 UTC (rev 739)
@@ -1,49 +1,39 @@
 project name=jbehave-eclipse default=generate-scripts
 	target name=generate-scripts
-	
-	
-	property name=feature value=org.jbehave.plugin.eclipse.feature/
-	property name=elements value=[EMAIL PROTECTED]/
-	
-	
-	 mkdir dir=build/
-	eclipse.fetch elements=${elements}		
-			buildDirectory=.	
-			
-			directory=directory.txt
-			fetchTag=COPY/
-			
-	
-	ant  antfile=fetch_${feature}.xml	
-		property name=featureAndPlugins value=X/
-		property name=featureOnly value=X/
-		property name=buildDirectory value=build/
-	/ant
+
+		echoFeature - ${feature}/echo
+		property name=feature value=org.jbehave.plugin.eclipse.feature /
+		property name=elements value=[EMAIL PROTECTED] /
 
+		mkdir dir=build /
+		eclipse.fetch elements=${elements} buildDirectory=. directory=directory.txt fetchTag=COPY /
 
-	xslt extension=properties style=extract-feature-version.xslt in=build/features/${feature}/feature.xml out=version.xml/
-	xmlproperty file=version.xml/
-	
+		ant antfile=fetch_${feature}.xml
+			property name=featureAndPlugins value=X /
+			property name=featureOnly value=X /
+			property name=buildDirectory value=build /
+		/ant
 
-	eclipse.buildScript  elements=${elements} children=true buildDirectory=build baseLocation=${eclipse.home} / 
-	mkdir dir=build/site/features / 
-	mkdir dir=build/site/plugins / 
-	
-	
-	ant dir=build/features/${feature} antfile=build.xml target=build.update.jar 
-		property name=feature.destination value=../../site/features/
-		property name=plugin.destination   value=../../site/plugins/
-	/ant	
+		xslt extension=properties style=extract-feature-version.xslt in=build/features/${feature}/feature.xml out=version.xml /
+		xmlproperty file=version.xml /
 
-	ant dir=build/features/${feature} antfile=build.xml target=zip.distribution / 
-  	!--ant antfile=build/assemble.${feature}.all.xml/ --
+		echoUsing Eclipse Home: ${eclipse.home}/echo
+		eclipse.buildScript elements=${elements} children=true buildDirectory=build baseLocation=${eclipse.home} /
+		mkdir dir=build/site/features /
+		mkdir dir=build/site/plugins /
 
-		
- 			
-		
-		xslt  style=site.xslt in=version.xml out=build/site/site.xml/
-		
+
+		ant dir=build/features/${feature} antfile=build.xml target=build.update.jar
+			property name=feature.destination value=../../site/features /
+			property name=plugin.destination value=../../site/plugins /
+		/ant
+
+		ant dir=build/features/${feature} antfile=build.xml target=zip.distribution /
+		!--ant antfile=build/assemble.${feature}.all.xml/ --
+
+		xslt style=site.xslt in=version.xml out=build/site/site.xml /
+
 	/target
-  /project
+/project
 
 


Added: trunk/plugins/eclipse/build.properties (0 => 739)

--- trunk/plugins/eclipse/build.properties	(rev 0)
+++ trunk/plugins/eclipse/build.properties	2007-07-10 08:28:15 UTC (rev 739)
@@ -0,0 +1,5 @@
+# Eclipse plugin build properties
+eclipseDir=C:/Program Files/eclipse
+eclipseLauncherCP=${eclipseDir}/plugins/org.eclipse.equinox.launcher_1.0.0.v20070606.jar
+eclipseLauncherMain=org.eclipse.core.launcher.Main
+label=20070710
\ No newline at end of file


Modified: trunk/plugins/eclipse/build.xml (738 => 739)

--- trunk/plugins/eclipse/build.xml	2007-06-16 08:48:51 UTC (rev 738)
+++ trunk/plugins/eclipse/build.xml	2007-07-10 08:28:15 UTC (rev 739)
@@ -1,15 +1,13 @@
 project name=cc-build-jbehave-eclipse default=build basedir=
 	!-- 
 	Usage:
-		ant -DeclipseDir=yourEclipseFolder
-	--
- 	target name=build 
-		condition property=eclipseDir value=C:/Program Files/eclipse
-			not
-isset property=eclipseDir/isset
-			/not
-		/condition
- 		java fork=true classname=org.eclipse.core.launcher.Main classpath=${eclipseDir}/startup.jar failonerror=true
+		ant -DeclipseDir=eclipseInstallDir
+	--
+!-- Load build.properties --
+property file=build.properties/
+	
+ 	target name=build 
+ 		java fork=true classname=${eclipseLauncherMain} classpath=${eclipseLauncherCP} failonerror=true
 			arg line=-application org.eclipse.ant.core.antRunner -buildfile build-eclipse.xml  -DjavacFailOnError=true -DbuildLabel=${label} / 
 		/java
 	/target










To unsubscribe from this list please visit:


http://xircles.codehaus.org/manage_email



[jbehave-dev] [jira] Updated: (JBEHAVE-19) Broken links in website

2007-07-10 Thread Mauro Talevi (JIRA)

 [ 
http://jira.codehaus.org/browse/JBEHAVE-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mauro Talevi updated JBEHAVE-19:


Affects Version/s: (was: 1.0)
   1.0.1
Fix Version/s: (was: 1.0.1)
   1.1
  Summary: Broken links in website  (was: broken links)

Moving to 1.1 to fix remaining links.

 Broken links in website
 ---

 Key: JBEHAVE-19
 URL: http://jira.codehaus.org/browse/JBEHAVE-19
 Project: JBehave
  Issue Type: Bug
  Components: Website
Affects Versions: 1.0.1
Reporter: Robert Dawson
 Fix For: 1.1


 http://jbehave.codehaus.org/development.html has a couple of broken links.  
 These are to:
 http://jbehave.codehaus.org/architecture.html, and
 http://builds.codehaus.org/log/jbehave/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email



[jbehave-dev] [jira] Updated: (JBEHAVE-89) Plugin not available on Eclipse 3.3/Europa

2007-07-10 Thread Mauro Talevi (JIRA)

 [ 
http://jira.codehaus.org/browse/JBEHAVE-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mauro Talevi updated JBEHAVE-89:


 Priority: Critical  (was: Major)
Fix Version/s: 1.1

 Plugin not available on Eclipse 3.3/Europa
 --

 Key: JBEHAVE-89
 URL: http://jira.codehaus.org/browse/JBEHAVE-89
 Project: JBehave
  Issue Type: Bug
  Components: Eclipse plugin
Affects Versions: 1.0.1
Reporter: Mauro Talevi
Assignee: Shane Duan
Priority: Critical
 Fix For: 1.1


 After installation of plugin in Eclipse 3.3/Europa without errors, the plugin 
 functionality does not seem to be available. 
 Right-clicking on a behaviour class does not offer the Verify Behaviour 
 option in Run As

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email



[jbehave-dev] [jira] Updated: (JBEHAVE-89) Plugin not available on Eclipse 3.3/Europa

2007-07-10 Thread Mauro Talevi (JIRA)

 [ 
http://jira.codehaus.org/browse/JBEHAVE-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mauro Talevi updated JBEHAVE-89:


Assignee: FelixTFelix  (was: Shane Duan)

 Plugin not available on Eclipse 3.3/Europa
 --

 Key: JBEHAVE-89
 URL: http://jira.codehaus.org/browse/JBEHAVE-89
 Project: JBehave
  Issue Type: Bug
  Components: Eclipse plugin
Affects Versions: 1.0.1
Reporter: Mauro Talevi
Assignee: FelixTFelix
Priority: Critical
 Fix For: 1.1


 After installation of plugin in Eclipse 3.3/Europa without errors, the plugin 
 functionality does not seem to be available. 
 Right-clicking on a behaviour class does not offer the Verify Behaviour 
 option in Run As

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email



[jbehave-scm] [741] trunk/core/src/behaviour/org/jbehave/core/matchers/UsingCollectionMatchersBehaviour.java: Fixed behaviour following JDK1.4 compatibility.

2007-07-10 Thread mauro
Title:  [741] trunk/core/src/behaviour/org/jbehave/core/matchers/UsingCollectionMatchersBehaviour.java: Fixed behaviour following JDK1.4 compatibility.







Revision 741
Author mauro
Date 2007-07-10 04:23:42 -0500 (Tue, 10 Jul 2007)


Log Message
Fixed behaviour following JDK1.4 compatibility.

Modified Paths

trunk/core/src/behaviour/org/jbehave/core/matchers/UsingCollectionMatchersBehaviour.java




Diff

Modified: trunk/core/src/behaviour/org/jbehave/core/matchers/UsingCollectionMatchersBehaviour.java (740 => 741)

--- trunk/core/src/behaviour/org/jbehave/core/matchers/UsingCollectionMatchersBehaviour.java	2007-07-10 09:06:08 UTC (rev 740)
+++ trunk/core/src/behaviour/org/jbehave/core/matchers/UsingCollectionMatchersBehaviour.java	2007-07-10 09:23:42 UTC (rev 741)
@@ -80,8 +80,8 @@
 Ensure.that(containsInOrder.toString(), eq(a collection containing [equal to 4, equal to 5] and in order));
 
 // Describe what we got
-		Ensure.that(contains.describe(list), eq(a ArrayList containing [5, 6]));
-		Ensure.that(containsOnly.describe(list), eq(a ArrayList containing [5, 6]));
-		Ensure.that(containsInOrder.describe(list), eq(a ArrayList containing [5, 6]));
+		Ensure.that(contains.describe(list), eq(a java.util.ArrayList containing [5, 6]));
+		Ensure.that(containsOnly.describe(list), eq(a java.util.ArrayList containing [5, 6]));
+		Ensure.that(containsInOrder.describe(list), eq(a java.util.ArrayList containing [5, 6]));
 }
 }










To unsubscribe from this list please visit:


http://xircles.codehaus.org/manage_email



[jbehave-dev] [jira] Commented: (JBEHAVE-88) Allow for comments and newlines in story text files

2007-07-10 Thread Mauro Talevi (JIRA)

[ 
http://jira.codehaus.org/browse/JBEHAVE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101785
 ] 

Mauro Talevi commented on JBEHAVE-88:
-

Eric - applied patch and rebuilt sablecc generator code.

Added a behaviour to verify the use of comments.

What do you mean by Please make a more robust grammar if you implement this 
improvement.  Can you elaborate? 

Thanks

 Allow for comments and newlines in story text files
 ---

 Key: JBEHAVE-88
 URL: http://jira.codehaus.org/browse/JBEHAVE-88
 Project: JBehave
  Issue Type: Improvement
  Components: Story runner
Affects Versions: 1.0, 1.0.1
Reporter: Eric Lewin
Assignee: Mauro Talevi
 Fix For: 1.1


 Se below for a working example of sablecc grammar that allows comments 
 starting with '#'.  Please make a more robust grammar if you implement this 
 improvement.
 ...
 Helpers
   letter = [['a'..'z'] + ['A'..'Z']];
   digit = ['0'..'9'];
   space = ' ';
   tab = 9;
   cr = 13;
   lf = 10;
   endl = cr | lf | cr lf;
   commentchar = '#';
   specialchar = '/' | '?' | '-' | '.' | '*' | '(' | ')';
   norwegianchar = 'æ'|'ø'|'å'|'Æ'|'Ø'|'Å';
   commentchars = space | tab | letter | digit | specialchar | 
 norwegianchar;
 Tokens
   title_keyword = 'Title:';
   scenario_keyword = 'Scenario:';
   as_a = 'As a';
   i_want = 'I want';
   so_that = 'So that';
   given = 'Given';
   when = 'When';
   then = 'Then';
   space = space;
   word = letter+;
   endl = endl;
   commentline = commentchar commentchars* endl;
 Ignored Tokens
 commentline;
 Productions
   story =
   title
   role?
   feature?
   benefit?
   scenario*;
 ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email



[jbehave-dev] [jira] Updated: (JBEHAVE-86) Maven JBehave plugin does not run text story files

2007-07-10 Thread Mauro Talevi (JIRA)

 [ 
http://jira.codehaus.org/browse/JBEHAVE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mauro Talevi updated JBEHAVE-86:


Summary: Maven JBehave plugin does not run text story files  (was: Patch 
fixing following bug: Maven JBehave plugin does not run text story files)

 Maven JBehave plugin does not run text story files
 --

 Key: JBEHAVE-86
 URL: http://jira.codehaus.org/browse/JBEHAVE-86
 Project: JBehave
  Issue Type: Bug
  Components: Core, Maven Plugin, Story runner
Affects Versions: 1.0.1
 Environment: Patch applied to SVN version 736
Reporter: Eric Lewin
Assignee: Mauro Talevi
Priority: Critical
 Fix For: 1.1

 Attachments: 
 fix_maven_plugin_and_introduce_named_interface_2007.05.31.736.patch


 The patch fixes maven plugin and story runner bugs described in 
 http://archive.jbehave.codehaus.org/dev/465151AA.6020700%40xait.no.
 The patch also fix a bug when printing stories: when the story and scenario 
 classes are anonymous, numbers are printed. With this patch the name of the 
 story and the scenario(s) are printed.
 1. Apply the patch at jbehave/trunk/ 
 2. run ant build
 3. run mvn install
 4. run mvn integration-test at plugins/maven/src/it
 5. verify that the maven build gives the same as the result further below.
 6. remember to add the interface Named to Subversion. Feel free to place it 
 somewhere else than org/jbehave/core/story/domain
 ***Maven results:
 [INFO] Scanning for projects...
 [INFO] Reactor build order:
 [INFO]   jBehave Maven Plugin Integration Test 1
 [INFO]   jBehave Maven Plugin Integration Test 2
 [INFO]   jBehave Maven Plugin Integration Test 3
 [INFO]   jBehave Maven Plugin Integration Test Reactor
 [INFO] 
 
 [INFO] Building jBehave Maven Plugin Integration Test 1
 [INFO]task-segment: [integration-test]
 [INFO] 
 
 [INFO] [resources:resources]
 [INFO] Using default encoding to copy filtered resources.
 [INFO] [compiler:compile]
 [INFO] Compiling 5 source files to 
 C:\work\svn_workspace\jbehaveTrunkClean\plugins\maven\src\it\test1\target\classes
 [INFO] [resources:testResources]
 [INFO] Using default encoding to copy filtered resources.
 [INFO] [compiler:testCompile]
 [INFO] No sources to compile
 [INFO] [surefire:test]
 [INFO] No tests to run.
 [INFO] [jar:jar]
 [INFO] Building jar: 
 C:\work\svn_workspace\jbehaveTrunkClean\plugins\maven\src\it\test1\target\jbehave-maven-plugin-it-test1-1.1-SNAPSHOT.jar
 [INFO] [jbehave:run-behaviours {execution: run-behaviours}]
 Done something
 .
 Time: 0.015s
 Total: 1. Success!
 [INFO] 
 
 [INFO] Building jBehave Maven Plugin Integration Test 2
 [INFO]task-segment: [integration-test]
 [INFO] 
 
 [INFO] [resources:resources]
 [INFO] Using default encoding to copy filtered resources.
 [INFO] [compiler:compile]
 [INFO] Compiling 5 source files to 
 C:\work\svn_workspace\jbehaveTrunkClean\plugins\maven\src\it\test2\target\classes
 [INFO] [resources:testResources]
 [INFO] Using default encoding to copy filtered resources.
 [INFO] [compiler:testCompile]
 [INFO] No sources to compile
 [INFO] [surefire:test]
 [INFO] No tests to run.
 [INFO] [jar:jar]
 [INFO] Building jar: 
 C:\work\svn_workspace\jbehaveTrunkClean\plugins\maven\src\it\test2\target\jbehave-maven-plugin-it-test2-1.1-SNAPSHOT.jar
 [INFO] [jbehave:run-story {execution: run-story}]
 Given org.jbehave.it.stories.givens.ATestToBeRun
 When org.jbehave.it.stories.events.UserRunsTest
 Then org.jbehave.it.stories.outcomes.ATestIsRunSuccessfully
 .
 Time: 0.0s
 Total: 1. Success!
 [INFO] 
 
 [INFO] Building jBehave Maven Plugin Integration Test 3
 [INFO]task-segment: [integration-test]
 [INFO] 
 
 [INFO] [resources:resources]
 [INFO] Using default encoding to copy filtered resources.
 [INFO] [compiler:compile]
 [INFO] Compiling 5 source files to 
 C:\work\svn_workspace\jbehaveTrunkClean\plugins\maven\src\it\test3\target\classes
 [INFO] [resources:testResources]
 [INFO] Using default encoding to copy filtered resources.
 [INFO] [compiler:testCompile]
 [INFO] No sources to compile
 [INFO] [surefire:test]
 [INFO] No tests to run.
 [INFO] [jar:jar]
 [INFO] Building jar: 
 C:\work\svn_workspace\jbehaveTrunkClean\plugins\maven\src\it\test3\target\jbehave-maven-plugin-it-test3-1.1-SNAPSHOT.jar
 [INFO] [jbehave:print-story {execution: run-story}]
 Story: user runs integration test
 As a
 

[jbehave-scm] [743] trunk/core/src/analysis: JBEHAVE-86: Applied patch from Eric Lewin.

2007-07-10 Thread mauro
Title:  [743] trunk/core/src/analysis: JBEHAVE-86: Applied patch from Eric Lewin.







Revision 743
Author mauro
Date 2007-07-10 08:18:50 -0500 (Tue, 10 Jul 2007)


Log Message
JBEHAVE-86: Applied patch from Eric Lewin.

Modified Paths

trunk/core/src/analysis/user withdraws cash.txt
trunk/core/src/java/org/jbehave/core/story/StoryBuilder.java
trunk/core/src/java/org/jbehave/core/story/StoryLoader.java
trunk/core/src/java/org/jbehave/core/story/StoryPrinter.java
trunk/core/src/java/org/jbehave/core/story/domain/MultiStepScenario.java
trunk/core/src/java/org/jbehave/core/story/domain/ScenarioDrivenStory.java
trunk/core/src/java/org/jbehave/core/util/CamelCaseConverter.java
trunk/plugins/maven/src/main/java/org/jbehave/mojo/StoryRunnerMojo.java


Added Paths

trunk/core/src/java/org/jbehave/core/story/domain/Named.java




Diff

Modified: trunk/core/src/analysis/user withdraws cash.txt (742 => 743)

--- trunk/core/src/analysis/user withdraws cash.txt	2007-07-10 12:54:50 UTC (rev 742)
+++ trunk/core/src/analysis/user withdraws cash.txt	2007-07-10 13:18:50 UTC (rev 743)
@@ -1,29 +1,16 @@
-Story: User withdraws cash
-
-As a Bank card holder
-I want to be able to withdraw cash from an ATM
-So that I dont have to visit the bank
-
-Scenario: Happy scenario
-
-Given Account is in credit
-When User requests cash
-Then ATM should dispense cash
-and ATM should return bank card
-and account balance should be reduced
-
-Scenario: Happy story with overdraft
-
-Given Account has overdraft facility
-and Account is easily within overdraft limit
-When User requests cash
-Then ATM should dispense cash
-and ATM should return bank card
-and account balance should be reduced
-
-Scenario: In lots of trouble
-
-Given Account is over overdraft limit
-When User requests cash
-Then Refuse cash
-and Keep bank card
+Title: User withdraws cash
+As a Bank card holder
+I want to be able to withdraw cash from an ATM
+So that I dont have to visit the bank
+Scenario: Happy scenario
+Given Account is in credit
+When User requests cash
+Then ATM should dispense cash and ATM should return bank card and account balance should be reduced
+Scenario: Happy story with overdraft
+Given Account has overdraft facility and Account is easily within overdraft limit
+When User requests cash
+Then ATM should dispense cash and ATM should return bank card and account balance should be reduced
+Scenario: In lots of trouble
+Given Account is over overdraft limit
+When User requests cash
+Then Refuse cash and Keep bank card


Modified: trunk/core/src/java/org/jbehave/core/story/StoryBuilder.java (742 => 743)

--- trunk/core/src/java/org/jbehave/core/story/StoryBuilder.java	2007-07-10 12:54:50 UTC (rev 742)
+++ trunk/core/src/java/org/jbehave/core/story/StoryBuilder.java	2007-07-10 13:18:50 UTC (rev 743)
@@ -3,7 +3,6 @@
 import java.text.MessageFormat;
 import java.util.Iterator;
 
-import org.jbehave.core.story.codegen.domain.BasicDetails;
 import org.jbehave.core.story.codegen.domain.ScenarioDetails;
 import org.jbehave.core.story.codegen.domain.StoryDetails;
 import org.jbehave.core.story.domain.Event;
@@ -27,7 +26,7 @@
 
 private StoryDetails details;
 private final String rootPackageName;
-private ClassLoader classLoader;
+private final ClassLoader classLoader;
 private final ClassBuilder builder = new ClassBuilder();
 
 public StoryBuilder(StoryDetails details, String rootPackageName) {
@@ -41,23 +40,25 @@
 }
 
 public Story story(){
-ScenarioDrivenStory story = new ScenarioDrivenStory(new Narrative(details.role, details.feature, details.benefit)) {
+return new ScenarioDrivenStory(new Narrative(details.role, details.feature, details.benefit)) {
 public void specify() {
 for ( Iterator i = details.scenarios.iterator(); i.hasNext(); ){
-addScenario(scenario((ScenarioDetails)i.next(), details.name));
+addScenario(scenario((ScenarioDetails)i.next()));
 }
 }
+
+public String getName() {
+return details.name;
+}
 };
-return story;
 }
 
-private Scenario scenario(final ScenarioDetails details, String storyName) {
+private Scenario scenario(final ScenarioDetails details) {
 return new MultiStepScenario() {
 public void specifySteps() {
 // given
 for (Iterator i = details.context.givens.iterator(); i.hasNext();) {
-BasicDetails given = (BasicDetails)i.next();
-given((Given)builder.newGiven(given.name));
+given((Given)builder.newGiven((String) i.next()));
 }
 
 // when
@@ -65,10 +66,13 @@
 
 // then
 for (Iterator i = details.outcome.outcomes.iterator(); i.hasNext();) {
-BasicDetails outcome = 

[jbehave-dev] [jira] Closed: (JBEHAVE-86) Maven JBehave plugin does not run text story files

2007-07-10 Thread Mauro Talevi (JIRA)

 [ 
http://jira.codehaus.org/browse/JBEHAVE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mauro Talevi closed JBEHAVE-86.
---

Resolution: Fixed

Applied with thanks!

 Maven JBehave plugin does not run text story files
 --

 Key: JBEHAVE-86
 URL: http://jira.codehaus.org/browse/JBEHAVE-86
 Project: JBehave
  Issue Type: Bug
  Components: Core, Maven Plugin, Story runner
Affects Versions: 1.0.1
 Environment: Patch applied to SVN version 736
Reporter: Eric Lewin
Assignee: Mauro Talevi
Priority: Critical
 Fix For: 1.1

 Attachments: 
 fix_maven_plugin_and_introduce_named_interface_2007.05.31.736.patch


 The patch fixes maven plugin and story runner bugs described in 
 http://archive.jbehave.codehaus.org/dev/465151AA.6020700%40xait.no.
 The patch also fix a bug when printing stories: when the story and scenario 
 classes are anonymous, numbers are printed. With this patch the name of the 
 story and the scenario(s) are printed.
 1. Apply the patch at jbehave/trunk/ 
 2. run ant build
 3. run mvn install
 4. run mvn integration-test at plugins/maven/src/it
 5. verify that the maven build gives the same as the result further below.
 6. remember to add the interface Named to Subversion. Feel free to place it 
 somewhere else than org/jbehave/core/story/domain
 ***Maven results:
 [INFO] Scanning for projects...
 [INFO] Reactor build order:
 [INFO]   jBehave Maven Plugin Integration Test 1
 [INFO]   jBehave Maven Plugin Integration Test 2
 [INFO]   jBehave Maven Plugin Integration Test 3
 [INFO]   jBehave Maven Plugin Integration Test Reactor
 [INFO] 
 
 [INFO] Building jBehave Maven Plugin Integration Test 1
 [INFO]task-segment: [integration-test]
 [INFO] 
 
 [INFO] [resources:resources]
 [INFO] Using default encoding to copy filtered resources.
 [INFO] [compiler:compile]
 [INFO] Compiling 5 source files to 
 C:\work\svn_workspace\jbehaveTrunkClean\plugins\maven\src\it\test1\target\classes
 [INFO] [resources:testResources]
 [INFO] Using default encoding to copy filtered resources.
 [INFO] [compiler:testCompile]
 [INFO] No sources to compile
 [INFO] [surefire:test]
 [INFO] No tests to run.
 [INFO] [jar:jar]
 [INFO] Building jar: 
 C:\work\svn_workspace\jbehaveTrunkClean\plugins\maven\src\it\test1\target\jbehave-maven-plugin-it-test1-1.1-SNAPSHOT.jar
 [INFO] [jbehave:run-behaviours {execution: run-behaviours}]
 Done something
 .
 Time: 0.015s
 Total: 1. Success!
 [INFO] 
 
 [INFO] Building jBehave Maven Plugin Integration Test 2
 [INFO]task-segment: [integration-test]
 [INFO] 
 
 [INFO] [resources:resources]
 [INFO] Using default encoding to copy filtered resources.
 [INFO] [compiler:compile]
 [INFO] Compiling 5 source files to 
 C:\work\svn_workspace\jbehaveTrunkClean\plugins\maven\src\it\test2\target\classes
 [INFO] [resources:testResources]
 [INFO] Using default encoding to copy filtered resources.
 [INFO] [compiler:testCompile]
 [INFO] No sources to compile
 [INFO] [surefire:test]
 [INFO] No tests to run.
 [INFO] [jar:jar]
 [INFO] Building jar: 
 C:\work\svn_workspace\jbehaveTrunkClean\plugins\maven\src\it\test2\target\jbehave-maven-plugin-it-test2-1.1-SNAPSHOT.jar
 [INFO] [jbehave:run-story {execution: run-story}]
 Given org.jbehave.it.stories.givens.ATestToBeRun
 When org.jbehave.it.stories.events.UserRunsTest
 Then org.jbehave.it.stories.outcomes.ATestIsRunSuccessfully
 .
 Time: 0.0s
 Total: 1. Success!
 [INFO] 
 
 [INFO] Building jBehave Maven Plugin Integration Test 3
 [INFO]task-segment: [integration-test]
 [INFO] 
 
 [INFO] [resources:resources]
 [INFO] Using default encoding to copy filtered resources.
 [INFO] [compiler:compile]
 [INFO] Compiling 5 source files to 
 C:\work\svn_workspace\jbehaveTrunkClean\plugins\maven\src\it\test3\target\classes
 [INFO] [resources:testResources]
 [INFO] Using default encoding to copy filtered resources.
 [INFO] [compiler:testCompile]
 [INFO] No sources to compile
 [INFO] [surefire:test]
 [INFO] No tests to run.
 [INFO] [jar:jar]
 [INFO] Building jar: 
 C:\work\svn_workspace\jbehaveTrunkClean\plugins\maven\src\it\test3\target\jbehave-maven-plugin-it-test3-1.1-SNAPSHOT.jar
 [INFO] [jbehave:print-story {execution: run-story}]
 Story: user runs integration test
 As a
 I want
 So that
 Scenario: user runs test successfully
 Given a test to be run
 When user runs test
 Then a 

[jbehave-dev] [jira] Closed: (JBEHAVE-41) Eclipse plugin needs an update site

2007-07-10 Thread Mauro Talevi (JIRA)

 [ 
http://jira.codehaus.org/browse/JBEHAVE-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mauro Talevi closed JBEHAVE-41.
---

   Resolution: Fixed
Fix Version/s: 1.0.1

Done

 Eclipse plugin needs an update site
 ---

 Key: JBEHAVE-41
 URL: http://jira.codehaus.org/browse/JBEHAVE-41
 Project: JBehave
  Issue Type: Sub-task
  Components: Eclipse plugin, Website
Reporter: Shane Duan
 Fix For: 1.0.1


 Eclipse plugin needs to have an update site.  It is pretty much done and 
 checked into the source repository.  However, we need to establish a plugin 
 release plan.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email



[jbehave-dev] [jira] Closed: (JBEHAVE-49) Maven 2 support

2007-07-10 Thread Mauro Talevi (JIRA)

 [ 
http://jira.codehaus.org/browse/JBEHAVE-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mauro Talevi closed JBEHAVE-49.
---

   Resolution: Fixed
Fix Version/s: 1.0.1

Closing this issue as Maven 2 support has been implemented.

Any further improvements should be dealt with by separate specific issues.

 Maven 2 support
 ---

 Key: JBEHAVE-49
 URL: http://jira.codehaus.org/browse/JBEHAVE-49
 Project: JBehave
  Issue Type: New Feature
  Components: Build system
Reporter: Mauro Talevi
 Fix For: 1.0.1

 Attachments: jbehave-49-classloader.patch, maven-patch.txt


 Regardless of feelings about maven vs ant, there is a case for supporting 
 both.
 IMO maven 2 provides a declarative approach that simplifies readability of 
 build system, 
 especially for multicomponent systems.
 Discussions on merits should be on the list.   
 Here I'm attaching an initial spike patch that mavenises build for people to 
 have a look at and get a feel.
 Read README.txt to start off with - need to install cotta jar in the local 
 repo (this is just a temporary step to get build
 working - it can also be configured to be installed automatically or deployed 
 to ibiblio).
 The behaviours still fail to run because of the 
 jbehave.core.util.BehavioursLoader does not provide injection of classloader. 
  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email



[jbehave-dev] Re: Maven 2 support

2007-07-10 Thread Mauro Talevi

Stefan,

sorry for the long wait - getting back to jBehaving ...

Stefan Hübner wrote:

So this would boil down to placing behaviours/stories either in
src/main/java or src/test/java and scoping jbehave either in
compile or test scope.

The switch could be easily supported by a simple boolean configuration
option, I guess. The plugin then would create a classloader upon
either compile scope or test scope classpath elements.


http://jira.codehaus.org/browse/JBEHAVE-90 - will be implemented shortly.

 I took the approach the surefire-plugin is based on. It doesn't 
import *any* JUnit-specific classes, but instead loads them into a 
completely isolated classloader. Of course this brings some nasty 
reflection mechanics as a side effect, though.


 The difference to your implementation is, that the patched plugin 
doesn't leave the classloading hassles to the jbehave-library. Rather 
it puts the jbehave-classes into the same classloader, that serves as 
the classloader for the behaviours to be verified. So jbehave is on 
the same classpath as the behaviours and nowhere else.


IMO the scenarios are a slightly different - in that surefire is an integrator 
of
completely different projects, while the jbehave plugin is an extension module 
of the
core.  In this sense I'm not sure that the added complication is justified.

Let's see if there is a usecase arises that justified the change - eg a bug or 
a problem of sorts.

 But either way, I'd just like to see a maven plugin that works, 
since I appreciate your effort very much. I do hope seeing the project 
gaining momentum in the near future. To me, a maven plugin is a must 
though, before I can spread the word.


That's my aim too :-)  I've just applied the patches from Eric Lewin and I've deploy a snapshot 
release.  I'd like to get out a 1.1 quite soon.



Since we're talking about Maven2 support, may I also suggest to update
jbehave's parent- and core-poms? The dependencies should be mentioned
properly. This would help developers great deals.


Can you please raise a jira issue?

Thanks


-
To unsubscribe from this list please visit:

   http://xircles.codehaus.org/manage_email