Re: jena git commit: Added chdir $FUSEKI_HOME when running in an environment without start-stop-daemon. Added a chdir to original directory after starting fuseki. Fixes bug JENA-984

2015-07-05 Thread Andy Seaborne

Comments:

1/
Needs to cope spaces in directory names as well.
cd $FUSEKI_HOME

2/
A safer shell idiom is to use a subshell envirionment:

( cd $FUSEKI_HOME
  .. do stuff ..
)

the change of working directory is limited to the subshell.

No need to have OLD_DIR.

Andy

On 04/07/15 17:27, cla...@apache.org wrote:

Repository: jena
Updated Branches:
   refs/heads/master 255416a86 - d58c1a1ab


Added chdir $FUSEKI_HOME when running in an environment without 
start-stop-daemon.
Added a chdir to original directory after starting fuseki.
Fixes bug JENA-984


Project: http://git-wip-us.apache.org/repos/asf/jena/repo
Commit: http://git-wip-us.apache.org/repos/asf/jena/commit/d58c1a1a
Tree: http://git-wip-us.apache.org/repos/asf/jena/tree/d58c1a1a
Diff: http://git-wip-us.apache.org/repos/asf/jena/diff/d58c1a1a

Branch: refs/heads/master
Commit: d58c1a1abc7dfb2a58ce5b8c04e176940fecbb9a
Parents: 255416a
Author: Claude Warren cla...@apache.org
Authored: Sat Jul 4 17:25:47 2015 +0100
Committer: Claude Warren cla...@apache.org
Committed: Sat Jul 4 17:25:47 2015 +0100

--
  jena-fuseki2/apache-jena-fuseki/fuseki | 5 -
  1 file changed, 4 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/jena/blob/d58c1a1a/jena-fuseki2/apache-jena-fuseki/fuseki
--
diff --git a/jena-fuseki2/apache-jena-fuseki/fuseki 
b/jena-fuseki2/apache-jena-fuseki/fuseki
index 62c2f16..814433a 100755
--- a/jena-fuseki2/apache-jena-fuseki/fuseki
+++ b/jena-fuseki2/apache-jena-fuseki/fuseki
@@ -371,6 +371,8 @@ start() {
rm -f $FUSEKI_PID
  fi

+OLD_DIR=`pwd`
+cd $FUSEKI_HOME
  if [ $FUSEKI_USER ]
  then
touch $FUSEKI_PID
@@ -386,7 +388,8 @@ start() {
disown $!
echo $!  $FUSEKI_PID
  fi
-
+cd $OLD_DIR
+
  log_end_msg 0
  print_started
fi





jena-core dependencies : contract testing

2015-07-05 Thread Andy Seaborne

On 29/06/15 17:05, Claude Warren wrote:

I'll have to mess with the build when I get home.




On Mon, Jun 29, 2015 at 4:42 PM, Andy Seaborne a...@apache.org wrote:


On 29/06/15 09:57, Claude Warren wrote:


The contract-test-maven-plugin should be version 0.1.4


There is a dependency on this (not the plugin) in jena-core:pom.xml


dependency
 groupIdorg.xenei/groupId
 artifactIdcontract-test-maven-plugin/artifactId
 scopetest/scope
   /dependency


Claude - the plugin is, well, just a plugin isn't it?  I removed the 
dependency and the tests seem to pass.


Can the dependency simply be removed, leaving it only in plugin?

---

Also, would it be possible to remove the logging at [INFO] for the next 
version of the contract framework?


ContractSuite.java:343
ContractTestMap.java:268

Messages like:
 INFO [main] (ContractSuite.java:343) - Running: 
org.xenei.junit.contract.ContractSuite$BaseClassRunner@248e319b
 INFO [main] (ContractSuite.java:343) - Running: 
org.xenei.junit.contract.ContractTestRunner@5d0bf09b
 INFO [main] (ContractSuite.java:343) - Running: 
org.xenei.junit.contract.ContractTestRunner@793f29ff


aren't about the jena-core test suite.

Andy



and then in jena-core I see:

 plugin
 groupIdorg.xenei/groupId
 artifactIdcontract-test-maven-plugin/artifactId
 version0.1.2/version

so 0.1.2 for contract-test-maven-plugin.







[jira] [Commented] (JENA-984) Fuseki script does not correctly run when start-stop-daemon is not available

2015-07-05 Thread Andy Seaborne (JIRA)

[ 
https://issues.apache.org/jira/browse/JENA-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614268#comment-14614268
 ] 

Andy Seaborne commented on JENA-984:


What actually goes wrong, what error messages occur, on AWS Linux?


 Fuseki script does not correctly run when start-stop-daemon is not available
 

 Key: JENA-984
 URL: https://issues.apache.org/jira/browse/JENA-984
 Project: Apache Jena
  Issue Type: Improvement
  Components: Fuseki
Affects Versions: Fuseki 2.3.0
 Environment: EC2 - Amazon Linux
Reporter: Claude Warren
Assignee: Claude Warren
Priority: Minor

 When running on an Amazon Linux EC2 instance the  start-stop-daemon is not 
 available. 
 When the fuseki script is run from /etc/init.d it does not find the 
 FUSEKI_HOME directory and so fails to start.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [ANN] GSoC 2015 Project Mid-term Evaluation (PASS)

2015-07-05 Thread Qihong Lin
Hi,

Please check my latest commits [1]. I just completed the function of
QueryEngineHTTP.execConstructQuads(). You can try out the example of
query_construct_quad_01() in TestQuery [2].

I'll improve the tests later on, with more questions in the other
thread. Thanks!

Regards,
Qihong


[1] 
https://github.com/confidencesun/jena/commit/07afdbf0fe635d41c302b25a9c51f43802ea903a
[2] 
https://github.com/confidencesun/jena/blob/JENA-491/jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/TestQuery.java

On Sat, Jul 4, 2015 at 10:08 PM, Ying Jiang jpz6311...@gmail.com wrote:
 Hi all,

 FYI, Google announced the mid-term evaluation result of GSoC 2015
 project yesterday. The Jena project of Extend CONSTRUCT to build
 quads (JENA-491) passed the evaluation.

 Hi Qihong,
 Thanks a lot for your contribution last month! We expect your
 excellent work in the coming weeks.
 The status of the project is a little ahead of the schedule. But the
 rest work is also challenging. You're supposed to integrate JENA-491
 into Fuseki. In addition, the tests should be improved in accordance
 with the original test framework of jena-arq.
 Have fun!

 Cheers,
 Ying Jiang


Re: [ANN] GSoC 2015 Project Mid-term Evaluation (PASS)

2015-07-05 Thread Andy Seaborne

On 04/07/15 15:08, Ying Jiang wrote:

Hi all,

FYI, Google announced the mid-term evaluation result of GSoC 2015
project yesterday. The Jena project of Extend CONSTRUCT to build
quads (JENA-491) passed the evaluation.

Hi Qihong,
Thanks a lot for your contribution last month! We expect your
excellent work in the coming weeks.
The status of the project is a little ahead of the schedule. But the
rest work is also challenging. You're supposed to integrate JENA-491
into Fuseki. In addition, the tests should be improved in accordance
with the original test framework of jena-arq.
Have fun!

Cheers,
Ying Jiang



Good news.

Ying - What's the plan for the deliver element of the tasks?  That's 
going to need mentor time and also to review a specific, focused set of 
changes.


Andy