date:20181001

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634772#comment-16634772
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/474
  
Thanks @afs I looked at the build and built locally using the following 
parameters
```
mvn clean verify -Pdev
```
... it results in SUCCESSFUL build.


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc

Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/474
  
Thanks @afs I looked at the build and built locally using the following 
parameters
```
mvn clean verify -Pdev
```
... it results in SUCCESSFUL build.


---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634754#comment-16634754
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221785452
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
--- End diff --

This being said, what would you rather see? This issue is titled _Jena 
master does not build under JDK10_ so I wonder if getting Jena to build under 
JDK 10 is the immediate response. Someone can then go and work on the 
underlying logging issue. Right now I have not investigated it enough or else I 
would have provided the fix. 


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221785452
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
--- End diff --

This being said, what would you rather see? This issue is titled _Jena 
master does not build under JDK10_ so I wonder if getting Jena to build under 
JDK 10 is the immediate response. Someone can then go and work on the 
underlying logging issue. Right now I have not investigated it enough or else I 
would have provided the fix. 


---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634579#comment-16634579
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user ajs6f commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221745287
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
--- End diff --

Yup. We may have to do something like this, but it's definitely 
"papering-over" the underlying fault.



> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread ajs6f

Github user ajs6f commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221745287
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
--- End diff --

Yup. We may have to do something like this, but it's definitely 
"papering-over" the underlying fault.



---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634578#comment-16634578
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221744935
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
--- End diff --

IMO The fix is not to use log4 directly but to use SLF4J and LogCtl because 
then logger can be swapped.  But, for history reasons, this may not be 
practical.  cc @rvesse 


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread afs

Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221744935
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
--- End diff --

IMO The fix is not to use log4 directly but to use SLF4J and LogCtl because 
then logger can be swapped.  But, for history reasons, this may not be 
practical.  cc @rvesse 


---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634561#comment-16634561
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user afs commented on the issue:

https://github.com/apache/jena/pull/474
  
See https://builds.apache.org/view/H-L/view/Jena/job/Jena_JDK11/ which 
builds with -Pdev and has been running for a while. It does not build jena-jdbc 
or jena-elephas both of which are need looking at.


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread afs

Github user afs commented on the issue:

https://github.com/apache/jena/pull/474
  
See https://builds.apache.org/view/H-L/view/Jena/job/Jena_JDK11/ which 
builds with -Pdev and has been running for a while. It does not build jena-jdbc 
or jena-elephas both of which are need looking at.


---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634554#comment-16634554
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221738972
  
--- Diff: jena-arq/pom.xml ---
@@ -216,6 +216,7 @@
 
   
   Licenced under the Apache License, Version 2.0
+  -html5
--- End diff --

This setting in the parent POM. It is commented out because the build fails 
with Java8.

1. Is setting in the parent enough? If it does, it is better to have in one 
place because ...
2. Has this PR been run with Java8? The build exits with an error in 
jena-iri:javadoc for me.



> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread afs

Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221738972
  
--- Diff: jena-arq/pom.xml ---
@@ -216,6 +216,7 @@
 
   
   Licenced under the Apache License, Version 2.0
+  -html5
--- End diff --

This setting in the parent POM. It is commented out because the build fails 
with Java8.

1. Is setting in the parent enough? If it does, it is better to have in one 
place because ...
2. Has this PR been run with Java8? The build exits with an error in 
jena-iri:javadoc for me.



---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634542#comment-16634542
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/474
  
Thats good to know @acoburn thanks for chiming in. 


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc

Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/474
  
Thats good to know @acoburn thanks for chiming in. 


---

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread acoburn

Github user acoburn commented on the issue:

https://github.com/apache/jena/pull/474
  
It is possibly worth noting here that these changes also make it possible 
to build Jena on JDK 11.


---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634518#comment-16634518
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user acoburn commented on the issue:

https://github.com/apache/jena/pull/474
  
It is possibly worth noting here that these changes also make it possible 
to build Jena on JDK 11.


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221726413
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
--- End diff --

Because the 
[org.apache.log4j.PropertyConfigurator](https://github.com/apache/jena/blob/master/jena-jdbc/jena-jdbc-core/src/main/java/org/apache/jena/jdbc/JenaDriver.java#L42)
 class is required in 
jena/jena-jdbc/jena-jdbc-core/src/main/java/org/apache/jena/jdbc/JenaDriver.java


---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634511#comment-16634511
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221726413
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
--- End diff --

Because the 
[org.apache.log4j.PropertyConfigurator](https://github.com/apache/jena/blob/master/jena-jdbc/jena-jdbc-core/src/main/java/org/apache/jena/jdbc/JenaDriver.java#L42)
 class is required in 
jena/jena-jdbc/jena-jdbc-core/src/main/java/org/apache/jena/jdbc/JenaDriver.java


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634512#comment-16634512
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/474
  
Thanks for comments @ajs6f 


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc

Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/474
  
Thanks for comments @ajs6f 


---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634508#comment-16634508
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221725604
  
--- Diff: 
jena-elephas/jena-elephas-mapreduce/src/main/java/org/apache/jena/hadoop/rdf/mapreduce/filter/AbstractNodeTupleFilterMapper.java
 ---
@@ -28,9 +28,7 @@
 /**
  * Abstract mapper implementation which helps in filtering tuples from the
  * input, derived implementations provide an implementation of the
- * {@link #accepts(TKey, T)}
- * 
- * 
+ * {@link #accepts(Object, AbstractNodeTupleWritable)}
--- End diff --

I agree... it was strange when it turned out that this seemed to be the 
fix. Without the code augmentation, I was unable to generate the Javadocs for 
the project. It should be noted that Javadoc generation is activated by default 
during an ```install``` target.


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221725604
  
--- Diff: 
jena-elephas/jena-elephas-mapreduce/src/main/java/org/apache/jena/hadoop/rdf/mapreduce/filter/AbstractNodeTupleFilterMapper.java
 ---
@@ -28,9 +28,7 @@
 /**
  * Abstract mapper implementation which helps in filtering tuples from the
  * input, derived implementations provide an implementation of the
- * {@link #accepts(TKey, T)}
- * 
- * 
+ * {@link #accepts(Object, AbstractNodeTupleWritable)}
--- End diff --

I agree... it was strange when it turned out that this seemed to be the 
fix. Without the code augmentation, I was unable to generate the Javadocs for 
the project. It should be noted that Javadoc generation is activated by default 
during an ```install``` target.


---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634503#comment-16634503
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221725050
  
--- Diff: jena-arq/pom.xml ---
@@ -216,6 +216,7 @@
 
   
   Licenced under the Apache License, Version 2.0
+  -html5
--- End diff --

If it is not included there is a ```WARNING``` message as follows 
```
javadoc: warning - You have not specified the version of HTML to use. The 
default is currently HTML 4.01, but this will change to HTML5 in a future 
release. To suppress this warning, please specify the version of HTML used in 
your documentation comments and to be generated by this doclet, using the 
-html4 or -html5 options.
```
The -html5 additional option cleans up presence of ```WARNING```'s during 
Maven build.


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221725050
  
--- Diff: jena-arq/pom.xml ---
@@ -216,6 +216,7 @@
 
   
   Licenced under the Apache License, Version 2.0
+  -html5
--- End diff --

If it is not included there is a ```WARNING``` message as follows 
```
javadoc: warning - You have not specified the version of HTML to use. The 
default is currently HTML 4.01, but this will change to HTML5 in a future 
release. To suppress this warning, please specify the version of HTML used in 
your documentation comments and to be generated by this doclet, using the 
-html4 or -html5 options.
```
The -html5 additional option cleans up presence of ```WARNING```'s during 
Maven build.


---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634468#comment-16634468
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user ajs6f commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221715600
  
--- Diff: jena-arq/pom.xml ---
@@ -216,6 +216,7 @@
 
   
   Licenced under the Apache License, Version 2.0
+  -html5
--- End diff --

Is this in some way needed for Java 10 builds?


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634469#comment-16634469
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user ajs6f commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221716224
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
--- End diff --

Why are you pulling in the `log4j` API?


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634467#comment-16634467
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user ajs6f commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221716057
  
--- Diff: 
jena-elephas/jena-elephas-mapreduce/src/main/java/org/apache/jena/hadoop/rdf/mapreduce/filter/AbstractNodeTupleFilterMapper.java
 ---
@@ -28,9 +28,7 @@
 /**
  * Abstract mapper implementation which helps in filtering tuples from the
  * input, derived implementations provide an implementation of the
- * {@link #accepts(TKey, T)}
- * 
- * 
+ * {@link #accepts(Object, AbstractNodeTupleWritable)}
--- End diff --

This just looks wrong-- the method below clearly is `accepts(TKey key, T 
tuple)`, and the concrete class isn't there at all.


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634466#comment-16634466
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user ajs6f commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221715434
  
--- Diff: .gitignore ---
@@ -14,7 +14,10 @@ buildNumber.properties
 .project
 .settings
 .recommenders
-.metadata
+.metadat
--- End diff --

Is this correct? `.metadata` => `.metadat`?


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread ajs6f

Github user ajs6f commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221716224
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
--- End diff --

Why are you pulling in the `log4j` API?


---

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread ajs6f

Github user ajs6f commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221715600
  
--- Diff: jena-arq/pom.xml ---
@@ -216,6 +216,7 @@
 
   
   Licenced under the Apache License, Version 2.0
+  -html5
--- End diff --

Is this in some way needed for Java 10 builds?


---

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread ajs6f

Github user ajs6f commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221716057
  
--- Diff: 
jena-elephas/jena-elephas-mapreduce/src/main/java/org/apache/jena/hadoop/rdf/mapreduce/filter/AbstractNodeTupleFilterMapper.java
 ---
@@ -28,9 +28,7 @@
 /**
  * Abstract mapper implementation which helps in filtering tuples from the
  * input, derived implementations provide an implementation of the
- * {@link #accepts(TKey, T)}
- * 
- * 
+ * {@link #accepts(Object, AbstractNodeTupleWritable)}
--- End diff --

This just looks wrong-- the method below clearly is `accepts(TKey key, T 
tuple)`, and the concrete class isn't there at all.


---

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread ajs6f

Github user ajs6f commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r221715434
  
--- Diff: .gitignore ---
@@ -14,7 +14,10 @@ buildNumber.properties
 .project
 .settings
 .recommenders
-.metadata
+.metadat
--- End diff --

Is this correct? `.metadata` => `.metadat`?


---

[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread ASF GitHub Bot (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634457#comment-16634457
 ] 

ASF GitHub Bot commented on JENA-1609:
--

GitHub user lewismc opened a pull request:

https://github.com/apache/jena/pull/474

JENA-1609 Jena master does not build under JDK10

This PR addresses https://issues.apache.org/jira/browse/JENA-1609

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/jena JENA-1609

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/474.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #474


commit 18497eaf21f2135b4cfc07c4decc18ef7f8dc1af
Author: Lewis John McGibbney 
Date:   2018-10-01T18:43:46Z

JENA-1609 Jena master does not build under JDK10




> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-01 Thread lewismc

GitHub user lewismc opened a pull request:

https://github.com/apache/jena/pull/474

JENA-1609 Jena master does not build under JDK10

This PR addresses https://issues.apache.org/jira/browse/JENA-1609

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/jena JENA-1609

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/474.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #474


commit 18497eaf21f2135b4cfc07c4decc18ef7f8dc1af
Author: Lewis John McGibbney 
Date:   2018-10-01T18:43:46Z

JENA-1609 Jena master does not build under JDK10




---

[jira] [Created] (JENA-1609) Jena master does not build under JDK10

2018-10-01 Thread Lewis John McGibbney (JIRA)

Lewis John McGibbney created JENA-1609:
--

 Summary: Jena master does not build under JDK10
 Key: JENA-1609
 URL: https://issues.apache.org/jira/browse/JENA-1609
 Project: Apache Jena
  Issue Type: Improvement
  Components: Build, Documentation
 Environment: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
Maven home: /usr/local/Cellar/maven/3.5.4/libexec
Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
/Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
Reporter: Lewis John McGibbney
 Fix For: Jena 3.9.0


When I attempt build under Oracle JDK 10 there are several issues which cause 
the build to fail. The following PR addresses these issues and enables me to 
build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (JENA-1601) Make ClosableIterator extend AutoCloseable

2018-10-01 Thread Andy Seaborne (JIRA)



[ 
https://issues.apache.org/jira/browse/JENA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634346#comment-16634346
 ] 

Andy Seaborne commented on JENA-1601:
-

SDB is (I believe) little used these days. If anyone wants to provide a PR For 
any fixed in SDB, I'll certainly process it.

Jena should use iterators consistently - which includes 
internal-close-on-completion - but it is not checked automatically. In ARQ, its 
use of QueryIterator is checked and it does complain if open iterators are 
found. This is both internal and because QueryExecution is AutoCloseable.

However, it is application code, that is the issue. If we turn warnings on, a 
possible outcome if there are lots of warnings, is that users will turn the 
warning off in their IDE. That's just life. 

There is a natural idiom now with transactions and it applies for TDB. When the 
transaction ends, further use of an iterator will cause an error.

Due to he lack of interest in SDB, deep Jena transaction API integration hasn't 
been retrofitted.

So Jena's transactions, especially used with {{Txn}}, provide a way for a 
system to catch and log misuse of iterators.

Any new API can be conversent of history - if resource manage could matter, 
then design for it so at scale, mistakes do not accumulate. But the core Jena 
API predates try-with-resource.

We can leave this open for a while - its a useful discussion.

> Make ClosableIterator extend AutoCloseable
> -
>
> Key: JENA-1601
> URL: https://issues.apache.org/jira/browse/JENA-1601
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Jena
>Affects Versions: Jena 3.8.0
>Reporter: David Schwingenschlögl
>Priority: Minor
>
> The interface org.apache.jena.util.iterator.ClosableIterator defines a 
> method public void close(), so the concept of closing is already baked into 
> it. The only barrier to using a ClosableIterator (and thus, ExtendedIterator) 
> in a try-with-resource block is the missing extension of 
> java.lang.AutoCloseable.
> According to API documentation of ClosableIterator, an iterator should be 
> closed when not completely exhausted, which may be the case when the block 
> consuming the iterator throws an exception, effectively making constructs 
> such as this necessary:
> {code:java}
> final ExtendedIterator iterator = someGraph.find();
> try {
>   while (iterator.hasNext()) {
> // consume iterator, might throw in here
>   }
> } finally {
>   // Prevent resource leaks
>   iterator.close();
> }
> {code}
> This would be better expressed in a try-with-resource-construct:
> {code:java}
> try (final ExtendedIterator itrator = someGraph.find()) {
>   // consume iterator, might throw in here
> }
> {code}
> From what I can tell, making a ClosableIterator also extend AutoCloseable 
> only adds to the usability of Jena's API while keeping source backwards 
> compatibility intact.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Apache Jena 3.9.0 RC1

2018-10-01 Thread ajs6f

> On 29/09/18 10:22, Andy Seaborne wrote:
> 
>> Please vote to approve this release:

+1 Approve the release

Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 
2018-02-24T14:49:05-05:00)
Java version: 1.8.0_65, vendor: Oracle Corporation
OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"

> + does everything work on OS X?
> + are the GPG signatures fine?
> + are the checksums correct?
> + is there a source archive?
> + can the source archive really be built?
>  (NB This requires a "mvn install" first time)

Yup. I haven't checked the binary distributions.

ajs6f

> On Sep 29, 2018, at 6:20 AM, Andy Seaborne  wrote:
> 
> +1
> 
> including using the staging maven repo in RDF Delta.
> 
> On 29/09/18 10:22, Andy Seaborne wrote:
> 
>> Please vote to approve this release:
>>[ ] +1 Approve the release
>>[ ]  0 Don't care
>>[ ] -1 Don't release, because ...
>> This vote will be open to at least
>>Wednesday, 2018-10-03, 08:00 UTC.

Re: of isomorphism and AdhocDatatypes

2018-10-01 Thread Andy Seaborne





On 01/10/18 07:52, Claude Warren wrote:

I resolved it by following the Don't Do That pattern and not loading the
datatype twice.

Event with hashCode and equals on the datatype it does not match as the
datatype equality is checked with ==.  I will find and document the issue
here.


Good - my cursory look at the code showed only use of Objects.equals.


But I am leaning toward the type registry issuing a warning when a
datatype is registered a second time.


As long as parsing unknown datatypes isn't impacted.

Andy



Claude

On Fri, Sep 28, 2018 at 9:45 AM Andy Seaborne  wrote:


Claude -

Did you resolve this?

In experimentation, I found a subtype of AdhocDatatype had to implement
.hashCode and .equals.

  Andy

[GitHub] jena pull request #473: Extendable versions of classes for printing result s...

2018-10-01 Thread hartig

GitHub user hartig opened a pull request:

https://github.com/apache/jena/pull/473

Extendable versions of classes for printing result sets

This PR modifies the classes `CSVOutput` and `TSVOutput` to make it 
possible to extend them and override their behavior in subclasses. I want to 
implement such subclasses for my SPARQL* extension of Jena.

A related question: Is there a reason why the mapping from `ResultsFormat` 
objects to `ResultSetLang`object (i.e., the [`mapResultsFormatToLang` in 
`ResultsFormat.java`](https://github.com/apache/jena/blob/aef35ee50eef9e0820d23d5ba184906b177a5c15/jena-arq/src/main/java/org/apache/jena/sparql/resultset/ResultsFormat.java#L190))
 does not map `ResultsFormat.FMT_TEXT` to `ResultSetLang.SPARQLResultSetText`?
Without this, the command line program `arq.query` falls back to the old 
`ResultSetWriter` and there is no elegant way for my SPARQL* extension of this 
program to use my SPARQL*-aware version of `ResultSetWriter` for text output. 
Hence, it would be great to add the following line into code that sets up 
`mapResultsFormatToLang`.

```
mapResultsFormatToLang.put(ResultsFormat.FMT_TEXT, 
ResultSetLang.SPARQLResultSetText) ;
```

Alternatively, the could be a method that can be used for adding something 
to `mapResultsFormatToLang`.

If you are fine with any of these two options, I would like to add it to 
this PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hartig/jena master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/473.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #473


commit ce453fe9a930ce060c662360dfb4e17a8c6e03fc
Author: Olaf Hartig 
Date:   2018-09-30T09:32:35Z

Merge pull request #1 from apache/master

update this fork to reflect the latest version of the original

commit 3ea4a230610fea61ff288dc15e5ce8f4ae36924e
Author: Olaf Hartig 
Date:   2018-09-30T18:53:08Z

changed the access modifier of both 'output' and 'csvSafe' to be protected

commit a8550192ed39c899687764fd9beda410a2560542
Author: Olaf Hartig 
Date:   2018-09-30T18:59:09Z

added method createNodeFormatter() which can be overridden in subclasses

commit ea7b430b825636595e92aebe7366d27b8ddcf47c
Author: Olaf Hartig 
Date:   2018-09-30T19:00:09Z

removed irrelevant comment




---

Re: of isomorphism and AdhocDatatypes

2018-10-01 Thread Claude Warren

I resolved it by following the Don't Do That pattern and not loading the
datatype twice.

Event with hashCode and equals on the datatype it does not match as the
datatype equality is checked with ==.  I will find and document the issue
here.  But I am leaning toward the type registry issuing a warning when a
datatype is registered a second time.

Claude

On Fri, Sep 28, 2018 at 9:45 AM Andy Seaborne  wrote:

> Claude -
>
> Did you resolve this?
>
> In experimentation, I found a subtype of AdhocDatatype had to implement
> .hashCode and .equals.
>
>  Andy
>

-- 
I like: Like Like - The likeliest place on the web

LinkedIn: http://www.linkedin.com/in/claudewarren

[jira] [Commented] (JENA-1601) Make ClosableIterator extend AutoCloseable

2018-10-01 Thread JIRA



[ 
https://issues.apache.org/jira/browse/JENA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633643#comment-16633643
 ] 

David Schwingenschlögl commented on JENA-1601:
--

After consulting my collegue, the issues we had were in fact related to using 
RDB (and later, SDB) with leaking database cursors. It's from this time that I 
distinctly remember to always close all iterators, or very bad things would 
happen.

Since we too do not plan on supporting SDB in the future, this issue is not so 
important to me anymore. However, I think for SDB this constellation is 
problematic; if Jena does not consistently close its iterators (which I read 
between the lines), and the users of the APIs are not forced to, database 
connections are bound to leak.

How should I proceed? From my perspective, this issue can be 
invalidated/closed, but I think it's still present for all users of SDB.

> Make ClosableIterator extend AutoCloseable
> -
>
> Key: JENA-1601
> URL: https://issues.apache.org/jira/browse/JENA-1601
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Jena
>Affects Versions: Jena 3.8.0
>Reporter: David Schwingenschlögl
>Priority: Minor
>
> The interface org.apache.jena.util.iterator.ClosableIterator defines a 
> method public void close(), so the concept of closing is already baked into 
> it. The only barrier to using a ClosableIterator (and thus, ExtendedIterator) 
> in a try-with-resource block is the missing extension of 
> java.lang.AutoCloseable.
> According to API documentation of ClosableIterator, an iterator should be 
> closed when not completely exhausted, which may be the case when the block 
> consuming the iterator throws an exception, effectively making constructs 
> such as this necessary:
> {code:java}
> final ExtendedIterator iterator = someGraph.find();
> try {
>   while (iterator.hasNext()) {
> // consume iterator, might throw in here
>   }
> } finally {
>   // Prevent resource leaks
>   iterator.close();
> }
> {code}
> This would be better expressed in a try-with-resource-construct:
> {code:java}
> try (final ExtendedIterator itrator = someGraph.find()) {
>   // consume iterator, might throw in here
> }
> {code}
> From what I can tell, making a ClosableIterator also extend AutoCloseable 
> only adds to the usability of Jena's API while keeping source backwards 
> compatibility intact.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

41 matches

Mail list logo