[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637414#comment-16637414
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user afs commented on the issue:

https://github.com/apache/jena/pull/474
  
I've picked out the .gitignore changes (not for `META-INF` - that's needed) 
and added them.


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread afs
Github user afs commented on the issue:

https://github.com/apache/jena/pull/474
  
I've picked out the .gitignore changes (not for `META-INF` - that's needed) 
and added them.


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637407#comment-16637407
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user afs commented on the issue:

https://github.com/apache/jena/pull/476
  
Looks good. A Java 10.0.2 build `mvn clean install` gets passed `jena-jdbc`:

```
[ERROR] Failed to execute goal on project jena-elephas-common: Could not 
resolve dependencies for project 
org.apache.jena:jena-elephas-common:jar:3.10.0-SNAPSHOT: Could not find 
artifact jdk.tools:jdk.tools:jar:1.6 at specified path 
/usr/lib/jvm/java-11-openjdk-amd64/../lib/tools.jar -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, 
please read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the 
command
[ERROR]   mvn  -rf :jena-elephas-common
```


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #476: Fix JDK10 Build (JENA-1609)

2018-10-03 Thread afs
Github user afs commented on the issue:

https://github.com/apache/jena/pull/476
  
Looks good. A Java 10.0.2 build `mvn clean install` gets passed `jena-jdbc`:

```
[ERROR] Failed to execute goal on project jena-elephas-common: Could not 
resolve dependencies for project 
org.apache.jena:jena-elephas-common:jar:3.10.0-SNAPSHOT: Could not find 
artifact jdk.tools:jdk.tools:jar:1.6 at specified path 
/usr/lib/jvm/java-11-openjdk-amd64/../lib/tools.jar -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, 
please read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the 
command
[ERROR]   mvn  -rf :jena-elephas-common
```


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637369#comment-16637369
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc closed the pull request at:

https://github.com/apache/jena/pull/474


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread lewismc
Github user lewismc closed the pull request at:

https://github.com/apache/jena/pull/474


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637368#comment-16637368
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/474
  
Closing in favor of #476 


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637367#comment-16637367
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/476
  
Tried it locally and apart from the -html Javadoc WARNING's this LGTM. 
@rvesse 


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #476: Fix JDK10 Build (JENA-1609)

2018-10-03 Thread lewismc
Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/476
  
Tried it locally and apart from the -html Javadoc WARNING's this LGTM. 
@rvesse 


---


[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread lewismc
Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/474
  
Closing in favor of #476 


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637353#comment-16637353
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user afs commented on the issue:

https://github.com/apache/jena/pull/474
  
`10 < 11`.  All these issues are in Java11 because Java 9 & 10 were the big 
changes and Java 11 the consolidation.


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread afs
Github user afs commented on the issue:

https://github.com/apache/jena/pull/474
  
`10 < 11`.  All these issues are in Java11 because Java 9 & 10 were the big 
changes and Java 11 the consolidation.


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637341#comment-16637341
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user ajs6f commented on the issue:

https://github.com/apache/jena/pull/474
  
@rvesse Yup, that's my site and every other one I know. That's not to say 
that this PR isn't worthwhile, just that I would certainly like to spend as 
much time as possible on 11, not 10.


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread ajs6f
Github user ajs6f commented on the issue:

https://github.com/apache/jena/pull/474
  
@rvesse Yup, that's my site and every other one I know. That's not to say 
that this PR isn't worthwhile, just that I would certainly like to spend as 
much time as possible on 11, not 10.


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637318#comment-16637318
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user rvesse commented on the issue:

https://github.com/apache/jena/pull/474
  
@afs Agreed, many folks are going to migrate Java 8 -> Java 11 because of 
the LTS release status are are skipping interim versions


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread rvesse
Github user rvesse commented on the issue:

https://github.com/apache/jena/pull/474
  
@afs Agreed, many folks are going to migrate Java 8 -> Java 11 because of 
the LTS release status are are skipping interim versions


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637314#comment-16637314
 ] 

ASF GitHub Bot commented on JENA-1609:
--

GitHub user rvesse opened a pull request:

https://github.com/apache/jena/pull/476

Fix JDK10 Build (JENA-1609)

Simplified version of PR #474 avoiding the dependency weirdness by adding 
the missing dependency only for the execution of the Javadoc plugin on the 
offending module

cc @lewismc

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rvesse/jena jdk10-build

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #476


commit ae06ecf498c3cd7e909b76d81ae72a05709c6941
Author: Rob Vesse 
Date:   2018-10-03T17:33:25Z

Get Jena JDBC building on JDK 10 (JENA-1609)

Pass needed log4j dependency directly to Javadoc plugin when bundling
the Jena JDBC javadocs.

Also upgrade Javadoc plugin to 3.0.1 to avoid bugs

commit 4ee971b42a018dc8887db274283a1606b2f2b32a
Author: Rob Vesse 
Date:   2018-10-03T18:02:30Z

Remove Javadoc link that JDK 10 dislikes (JENA-1609)




> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena pull request #476: Fix JDK10 Build (JENA-1609)

2018-10-03 Thread rvesse
GitHub user rvesse opened a pull request:

https://github.com/apache/jena/pull/476

Fix JDK10 Build (JENA-1609)

Simplified version of PR #474 avoiding the dependency weirdness by adding 
the missing dependency only for the execution of the Javadoc plugin on the 
offending module

cc @lewismc

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rvesse/jena jdk10-build

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jena/pull/476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #476


commit ae06ecf498c3cd7e909b76d81ae72a05709c6941
Author: Rob Vesse 
Date:   2018-10-03T17:33:25Z

Get Jena JDBC building on JDK 10 (JENA-1609)

Pass needed log4j dependency directly to Javadoc plugin when bundling
the Jena JDBC javadocs.

Also upgrade Javadoc plugin to 3.0.1 to avoid bugs

commit 4ee971b42a018dc8887db274283a1606b2f2b32a
Author: Rob Vesse 
Date:   2018-10-03T18:02:30Z

Remove Javadoc link that JDK 10 dislikes (JENA-1609)




---


[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread afs
Github user afs commented on the issue:

https://github.com/apache/jena/pull/474
  
"should be used with JDK 1.8" has several facets.
There are different levels of Java11 usage: the project discussions back 
when it was Java9:

[dev@ 
message](https://lists.apache.org/thread.html/880632ba6b6df6f2b26e4357462d94426ea4b14d83f08e9edac0b684@%3Cdev.jena.apache.org%3E)
 and sent as part of [users@ 
message](https://lists.apache.org/thread.html/5b31a3b6794781f6a02658608444043b5535957a6c94f3728efd8304@%3Cusers.jena.apache.org%3E).

Ultimately, it is a community decision. 

My personal opinion is that Jena should be able to run on Java8 runtime. 
Research projects may upgrade quickly but enterprise deployments are another 
matter.

To ensure no accidents, I prefer the release build used Java8 because it 
protects against runtime library changes (we have one currently about 
tools.jar).

I'd like the build to work with Java11 - hence the commented line in the 
parent `pom.xml` and the Jenkins job, both of which came out of the project 
discussions from Feb. Currently, "-Pdev" works, the full release build does not.

I have `~/.mavenrc` setup to make sure I gets builds right. I use JDK10 as 
the default java on my system (I am resisting installing Java11 manually and 
waiting for Ubuntu ... at least for now!), I make sure maven runs with Java8.

 # ~/.mavenrc
JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64

Java11 will change the ecosystem and we don't know how that plays out or 
what may come out of [adoptjava](https://adoptopenjdk.net/) and the Jan2019 
deadline from Oracle. I think it will rapidly become clear.



---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637303#comment-16637303
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user afs commented on the issue:

https://github.com/apache/jena/pull/474
  
"should be used with JDK 1.8" has several facets.
There are different levels of Java11 usage: the project discussions back 
when it was Java9:

[dev@ 
message](https://lists.apache.org/thread.html/880632ba6b6df6f2b26e4357462d94426ea4b14d83f08e9edac0b684@%3Cdev.jena.apache.org%3E)
 and sent as part of [users@ 
message](https://lists.apache.org/thread.html/5b31a3b6794781f6a02658608444043b5535957a6c94f3728efd8304@%3Cusers.jena.apache.org%3E).

Ultimately, it is a community decision. 

My personal opinion is that Jena should be able to run on Java8 runtime. 
Research projects may upgrade quickly but enterprise deployments are another 
matter.

To ensure no accidents, I prefer the release build used Java8 because it 
protects against runtime library changes (we have one currently about 
tools.jar).

I'd like the build to work with Java11 - hence the commented line in the 
parent `pom.xml` and the Jenkins job, both of which came out of the project 
discussions from Feb. Currently, "-Pdev" works, the full release build does not.

I have `~/.mavenrc` setup to make sure I gets builds right. I use JDK10 as 
the default java on my system (I am resisting installing Java11 manually and 
waiting for Ubuntu ... at least for now!), I make sure maven runs with Java8.

 # ~/.mavenrc
JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64

Java11 will change the ecosystem and we don't know how that plays out or 
what may come out of [adoptjava](https://adoptopenjdk.net/) and the Jan2019 
deadline from Oracle. I think it will rapidly become clear.



> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637286#comment-16637286
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/474
  
@rvesse grand


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread lewismc
Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/474
  
@rvesse grand


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637266#comment-16637266
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user rvesse commented on the issue:

https://github.com/apache/jena/pull/474
  
I think there is a simpler solution to this, I have Jena JDBC building 
locally under JDK10 and will push a new PR shortly


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread rvesse
Github user rvesse commented on the issue:

https://github.com/apache/jena/pull/474
  
I think there is a simpler solution to this, I have Jena JDBC building 
locally under JDK10 and will push a new PR shortly


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637264#comment-16637264
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r222399187
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
+   org.apache.logging.log4j
+   log4j-api
+   
+
+   
+   
+   org.apache.logging.log4j
--- End diff --

Wrong PropertyConfigurator.java  - there are two, one in log4j1 and one in 
log4j2 for compatibility code 
`log4j-1.2-api/src/main/java/org/apache/log4j/PropertyConfigurator.java`.

Jena is picking up the one from log4j1. So the log4j2 dependencies aren't 
need but the log4j1 is. Either will do to compile but log4j1 is intended.



> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread afs
Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r222399187
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
+   org.apache.logging.log4j
+   log4j-api
+   
+
+   
+   
+   org.apache.logging.log4j
--- End diff --

Wrong PropertyConfigurator.java  - there are two, one in log4j1 and one in 
log4j2 for compatibility code 
`log4j-1.2-api/src/main/java/org/apache/log4j/PropertyConfigurator.java`.

Jena is picking up the one from log4j1. So the log4j2 dependencies aren't 
need but the log4j1 is. Either will do to compile but log4j1 is intended.



---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637201#comment-16637201
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user rvesse commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r222388084
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
+   org.apache.logging.log4j
+   log4j-api
+   
+
+   
+   
+   org.apache.logging.log4j
--- End diff --

This code predates Log4j 2.x so shouldn't have any dependency upon it


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread rvesse
Github user rvesse commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r222388084
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
+   org.apache.logging.log4j
+   log4j-api
+   
+
+   
+   
+   org.apache.logging.log4j
--- End diff --

This code predates Log4j 2.x so shouldn't have any dependency upon it


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637176#comment-16637176
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r222383653
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
+   org.apache.logging.log4j
+   log4j-api
+   
+
+   
+   
+   org.apache.logging.log4j
--- End diff --

From what I understand, the offending class 
[org.apache.log4j.PropertyConfigurator](https://logging.apache.org/log4j/2.0/log4j-1.2-api/apidocs/index.html?org/apache/log4j/PropertyConfigurator.html)
 resides in log4j 2.0... the runtime dependencies are detailed [as 
follows](https://logging.apache.org/log4j/2.0/runtime-dependencies.html) with 
the [Maven Artifacts detailed 
here](https://logging.apache.org/log4j/2.0/maven-artifacts.html).


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r222383653
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
+   org.apache.logging.log4j
+   log4j-api
+   
+
+   
+   
+   org.apache.logging.log4j
--- End diff --

From what I understand, the offending class 
[org.apache.log4j.PropertyConfigurator](https://logging.apache.org/log4j/2.0/log4j-1.2-api/apidocs/index.html?org/apache/log4j/PropertyConfigurator.html)
 resides in log4j 2.0... the runtime dependencies are detailed [as 
follows](https://logging.apache.org/log4j/2.0/runtime-dependencies.html) with 
the [Maven Artifacts detailed 
here](https://logging.apache.org/log4j/2.0/maven-artifacts.html).


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637172#comment-16637172
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r222382699
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
+   org.apache.logging.log4j
+   log4j-api
+   
+
+   
+   
+   org.apache.logging.log4j
--- End diff --

Agreed. This is the behavior I get as well. 
My thinking was that the dependency needed to be available at compile time 
as oppose to only runtime... but maybe this thinking is wrong. 
The generated Javadoc look fine but the error prevents a stable build.


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r222382699
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
+   org.apache.logging.log4j
+   log4j-api
+   
+
+   
+   
+   org.apache.logging.log4j
--- End diff --

Agreed. This is the behavior I get as well. 
My thinking was that the dependency needed to be available at compile time 
as oppose to only runtime... but maybe this thinking is wrong. 
The generated Javadoc look fine but the error prevents a stable build.


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637170#comment-16637170
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/474
  
@afs 
> The problem is not html4/html5 (we can clean up the javadoc) but 
compatible with java8 javadoc tool. Java8 build causes:

Got it.

> I'd prefer that the build uses java8 for java8 libraries because 
cross-compiling does not catch changes in the runtime libraries.

So do you want to abandon this PR and state that Jena should be used with 
JDK 1.8? If so I can close out this issue. Unless of course if you can propose 
an alternative.


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread lewismc
Github user lewismc commented on the issue:

https://github.com/apache/jena/pull/474
  
@afs 
> The problem is not html4/html5 (we can clean up the javadoc) but 
compatible with java8 javadoc tool. Java8 build causes:

Got it.

> I'd prefer that the build uses java8 for java8 libraries because 
cross-compiling does not catch changes in the runtime libraries.

So do you want to abandon this PR and state that Jena should be used with 
JDK 1.8? If so I can close out this issue. Unless of course if you can propose 
an alternative.


---


[GitHub] jena issue #473: Extendable versions of classes for printing result sets

2018-10-03 Thread hartig
Github user hartig commented on the issue:

https://github.com/apache/jena/pull/473
  
> When Jena 3.9.0 is completed, I can come back and look at this PR. In 
principle, there is no reason not have have them extensible.

Sounds good. Thanks!

> What syntax are you using for TSV extensions?

My idea was to simply extend the TSV format that you have in Jena with a 
possibility to also represent `Node_Triple` objects (as solution mappings in 
SPARQL* may map variables not only to URIs, literals, and bnodes, but also to 
triples).

> On the question of mapping `ResultsFormat.FMT_TEXT`: IIRC it is because 
text is only an output format and not an input format (but then CSV is also 
only an output format).

I see. If you are hesitant to add `ResultsFormat.FMT_TEXT` to 
`mapResultsFormatToLang` directly in the Jena code base, my alternative 
proposal of introducing a method for adding something to 
`mapResultsFormatToLang` from external code (like mine) would work for me too.


---


[jira] [Commented] (JENA-1606) add OpenAnnotation and ActivityStream vocabulary

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636707#comment-16636707
 ] 

ASF GitHub Bot commented on JENA-1606:
--

Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/475


> add OpenAnnotation and ActivityStream vocabulary
> 
>
> Key: JENA-1606
> URL: https://issues.apache.org/jira/browse/JENA-1606
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Core
>Reporter: Elie Roux
>Priority: Minor
> Fix For: Jena 3.10.0
>
>
> I've created vocabulary classes for OA (Open Annotation) and AS (Activity 
> Stream) vocabulary, both are used in Web annotations. They're in 
> [https://github.com/BuddhistDigitalResourceCenter/lds-pdi/tree/master/src/main/java/io/bdrc/ldspdi/annotations]
>  I can open a pull request if desired.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (JENA-1606) add OpenAnnotation and ActivityStream vocabulary

2018-10-03 Thread Andy Seaborne (JIRA)


 [ 
https://issues.apache.org/jira/browse/JENA-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Seaborne resolved JENA-1606.
-
   Resolution: Done
Fix Version/s: Jena 3.10.0

> add OpenAnnotation and ActivityStream vocabulary
> 
>
> Key: JENA-1606
> URL: https://issues.apache.org/jira/browse/JENA-1606
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Core
>Reporter: Elie Roux
>Priority: Minor
> Fix For: Jena 3.10.0
>
>
> I've created vocabulary classes for OA (Open Annotation) and AS (Activity 
> Stream) vocabulary, both are used in Web annotations. They're in 
> [https://github.com/BuddhistDigitalResourceCenter/lds-pdi/tree/master/src/main/java/io/bdrc/ldspdi/annotations]
>  I can open a pull request if desired.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1606) add OpenAnnotation and ActivityStream vocabulary

2018-10-03 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636706#comment-16636706
 ] 

ASF subversion and git services commented on JENA-1606:
---

Commit df760c544cf0244f06545f962b4ee0f6befeadf0 in jena's branch 
refs/heads/master from [~an...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=df760c5 ]

JENA-1606: Merge commit 'refs/pull/475/head' of https://github.com/apache/jena

This closes #475.


> add OpenAnnotation and ActivityStream vocabulary
> 
>
> Key: JENA-1606
> URL: https://issues.apache.org/jira/browse/JENA-1606
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Core
>Reporter: Elie Roux
>Priority: Minor
>
> I've created vocabulary classes for OA (Open Annotation) and AS (Activity 
> Stream) vocabulary, both are used in Web annotations. They're in 
> [https://github.com/BuddhistDigitalResourceCenter/lds-pdi/tree/master/src/main/java/io/bdrc/ldspdi/annotations]
>  I can open a pull request if desired.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena pull request #475: add AS and OA vocabularies

2018-10-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/jena/pull/475


---


[jira] [Created] (JENA-1610) Clear up version recording and reporting

2018-10-03 Thread Andy Seaborne (JIRA)
Andy Seaborne created JENA-1610:
---

 Summary: Clear up version recording and reporting
 Key: JENA-1610
 URL: https://issues.apache.org/jira/browse/JENA-1610
 Project: Apache Jena
  Issue Type: Bug
Affects Versions: Jena 3.9.0
Reporter: Andy Seaborne
Assignee: Andy Seaborne


1/ There are two versions of the Metadata class.

2/ No need to report subsystem versions for"–version" because they are all the 
same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread afs
Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r43798
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
+   org.apache.logging.log4j
+   log4j-api
+   
+
+   
+   
+   org.apache.logging.log4j
--- End diff --

More:

Confirmed I have only have to add a single log4j1 dependency.
The error is otherwise from the maven-javadoc-plugin, not the compiler:

```
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar (attach-javadocs) on 
project jena-jdbc-driver-bundle: MavenReportException: Error while generating 
Javadoc: 
[ERROR] Exit code: 1 - 
/home/afs/Jena/jena-jdbc/jena-jdbc-core/src/main/java/org/apache/jena/jdbc/JenaDriver.java:42:
 error: package org.apache.log4j does not exist
[ERROR] import org.apache.log4j.PropertyConfigurator;
[ERROR]^
[ERROR] 
[ERROR] Command line was: /usr/lib/jvm/default-java/bin/javadoc @options 
@packages
[ERROR] 
[ERROR] Refer to the generated Javadoc files in 
'/home/afs/Jena/jena-jdbc/jena-jdbc-driver-bundle/target/apidocs' dir.
[ERROR] 
```


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636681#comment-16636681
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r43798
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
+   org.apache.logging.log4j
+   log4j-api
+   
+
+   
+   
+   org.apache.logging.log4j
--- End diff --

More:

Confirmed I have only have to add a single log4j1 dependency.
The error is otherwise from the maven-javadoc-plugin, not the compiler:

```
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar (attach-javadocs) on 
project jena-jdbc-driver-bundle: MavenReportException: Error while generating 
Javadoc: 
[ERROR] Exit code: 1 - 
/home/afs/Jena/jena-jdbc/jena-jdbc-core/src/main/java/org/apache/jena/jdbc/JenaDriver.java:42:
 error: package org.apache.log4j does not exist
[ERROR] import org.apache.log4j.PropertyConfigurator;
[ERROR]^
[ERROR] 
[ERROR] Command line was: /usr/lib/jvm/default-java/bin/javadoc @options 
@packages
[ERROR] 
[ERROR] Refer to the generated Javadoc files in 
'/home/afs/Jena/jena-jdbc/jena-jdbc-driver-bundle/target/apidocs' dir.
[ERROR] 
```


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636655#comment-16636655
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user rvesse commented on the issue:

https://github.com/apache/jena/pull/474
  
@afs https://github.com/rvesse/airline/blob/master/pom.xml#L495-L497 which 
I discovered via JIRA https://issues.apache.org/jira/browse/MJAVADOC-475


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread rvesse
Github user rvesse commented on the issue:

https://github.com/apache/jena/pull/474
  
@afs https://github.com/rvesse/airline/blob/master/pom.xml#L495-L497 which 
I discovered via JIRA https://issues.apache.org/jira/browse/MJAVADOC-475


---


[GitHub] jena issue #473: Extendable versions of classes for printing result sets

2018-10-03 Thread afs
Github user afs commented on the issue:

https://github.com/apache/jena/pull/473
  
On the question of mapping `ResultsFormat.FMT_TEXT`: IIRC it is because 
text is only an output format and not an input format (but then CSV is also 
only an output format).

When Jena 3.9.0 is completed, I can come back and look at this PR. In 
principle, there is no reason not have have them extensible.

What syntax are you using for TSV extensions?



---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636631#comment-16636631
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r33579
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
+   org.apache.logging.log4j
+   log4j-api
+   
+
+   
+   
+   org.apache.logging.log4j
--- End diff --

I'm unclear here. I tried with JDK10 and had to add the log4j1 dependency 
but not the log4j2 dependencies.

In the code I can only find imports of `org.apache.log4j`, which is log4j1, 
not `org.apache.logging.log4j` which is log4j2.

Elasticsearch does use log4j2 and Jena adds adapters theer for that.


> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena pull request #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread afs
Github user afs commented on a diff in the pull request:

https://github.com/apache/jena/pull/474#discussion_r33579
  
--- Diff: jena-jdbc/jena-jdbc-core/pom.xml ---
@@ -39,17 +39,28 @@
3.10.0-SNAPSHOT

 
-
-
-  org.slf4j
-  slf4j-log4j12
-
+   
+   
+   org.slf4j
+   slf4j-log4j12
+   
+
+   
+   log4j
+   log4j
+   
+
+   
+   org.apache.logging.log4j
+   log4j-api
+   
+
+   
+   
+   org.apache.logging.log4j
--- End diff --

I'm unclear here. I tried with JDK10 and had to add the log4j1 dependency 
but not the log4j2 dependencies.

In the code I can only find imports of `org.apache.log4j`, which is log4j1, 
not `org.apache.logging.log4j` which is log4j2.

Elasticsearch does use log4j2 and Jena adds adapters theer for that.


---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636628#comment-16636628
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user afs commented on the issue:

https://github.com/apache/jena/pull/474
  
@rvesse  - The current plugin in the build is 3.0.0. `` didn't 
change the situation. Can you given an example or point to one? (the online 
plugin doc does not talk about ``

Profiles: that would be great. Again, a sample to start from would help. 
While all the suggestions here are great, it's going to be slower if I have to 
carry out each one from scratch.



> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread afs
Github user afs commented on the issue:

https://github.com/apache/jena/pull/474
  
@rvesse  - The current plugin in the build is 3.0.0. `` didn't 
change the situation. Can you given an example or point to one? (the online 
plugin doc does not talk about ``

Profiles: that would be great. Again, a sample to start from would help. 
While all the suggestions here are great, it's going to be slower if I have to 
carry out each one from scratch.



---


[jira] [Commented] (JENA-1609) Jena master does not build under JDK10

2018-10-03 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636620#comment-16636620
 ] 

ASF GitHub Bot commented on JENA-1609:
--

Github user afs commented on the issue:

https://github.com/apache/jena/pull/474
  
@lewismc 
> @afs how about we propose the change to
> 
> ```
> -html4
> ```
> This would produce JDK WARNING's under several environment's however 
would at least enable successful build under this environments.

The problem is not html4/html5 (we can clean up the javadoc) but compatible 
with java8 javadoc tool. Java8 build causes:

Exit code: 1 - javadoc: error - invalid flag: -html4

I'd prefer that the build uses java8 for java8 libraries because 
cross-compiling does not catch changes in the runtime libraries.



> Jena master does not build under JDK10
> --
>
> Key: JENA-1609
> URL: https://issues.apache.org/jira/browse/JENA-1609
> Project: Apache Jena
>  Issue Type: Improvement
>  Components: Build, Documentation
> Environment: Apache Maven 3.5.4 
> (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 10.0.2, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
>Reporter: Lewis John McGibbney
>Priority: Major
> Fix For: Jena 3.9.0
>
>
> When I attempt build under Oracle JDK 10 there are several issues which cause 
> the build to fail. The following PR addresses these issues and enables me to 
> build and run Jena master under JDK 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10

2018-10-03 Thread afs
Github user afs commented on the issue:

https://github.com/apache/jena/pull/474
  
@lewismc 
> @afs how about we propose the change to
> 
> ```
> -html4
> ```
> This would produce JDK WARNING's under several environment's however 
would at least enable successful build under this environments.

The problem is not html4/html5 (we can clean up the javadoc) but compatible 
with java8 javadoc tool. Java8 build causes:

Exit code: 1 - javadoc: error - invalid flag: -html4

I'd prefer that the build uses java8 for java8 libraries because 
cross-compiling does not catch changes in the runtime libraries.



---