[jira] [Commented] (JENA-1671) SPARQL_QueryGeneral does not work.
[
https://issues.apache.org/jira/browse/JENA-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769603#comment-16769603
]
ASF subversion and git services commented on JENA-1671:
---
Commit 33bfa90de9758d22ec49620f4c9db590ac7d0d45 in jena's branch
refs/heads/master from Andy Seaborne
[ https://gitbox.apache.org/repos/asf?p=jena.git;h=33bfa90 ]
JENA-1671: Fix general query servlet.
* direct servlet as ActionService
* remove dataset description from query if processed
> SPARQL_QueryGeneral does not work.
> --
>
> Key: JENA-1671
> URL: https://issues.apache.org/jira/browse/JENA-1671
> Project: Apache Jena
> Issue Type: Bug
> Components: Fuseki
>Affects Versions: Jena 3.10.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Adding a general purpose SPARQL processor (no dataset, reads data using
> protocol or FROM/FROM NAMED) does work work any more because:
> * The dispatch in {{ActionService}} remaps it to the registered SPARQL
> dataset processor.
> * When the dataset is built by {{SPARQL_QueryGeneral}}, it does not clear
> the query FROM so that get interpreted again during query processing as
> picking from the dataset.
> The general purpose SPARQL processor is {{--general}} in Fuseki Main.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] grahamtriggs commented on issue #533: Feature/sdborder
grahamtriggs commented on issue #533: Feature/sdborder URL: https://github.com/apache/jena/pull/533#issuecomment-464205740 Functionally, the LinkedHastSet (order of Scope), and DISTINCT / GROUP BY translation are tested multiple times during the existing tests - the code is exercised and affects the SQL generated without breaking any of the tests. The ORDER BY translation currently isn't because it's disabled by default, but it could be turned on for the tests (and again it doesn't break any existing tests). I'll have a think about what tests could be included to ensure that the SQL translations occur as expected, beyond just testing the execution of the query. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (JENA-1671) SPARQL_QueryGeneral does not work.
[
https://issues.apache.org/jira/browse/JENA-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Seaborne resolved JENA-1671.
-
Resolution: Fixed
Fix Version/s: Jena 3.11.0
> SPARQL_QueryGeneral does not work.
> --
>
> Key: JENA-1671
> URL: https://issues.apache.org/jira/browse/JENA-1671
> Project: Apache Jena
> Issue Type: Bug
> Components: Fuseki
>Affects Versions: Jena 3.10.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.11.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Adding a general purpose SPARQL processor (no dataset, reads data using
> protocol or FROM/FROM NAMED) does work work any more because:
> * The dispatch in {{ActionService}} remaps it to the registered SPARQL
> dataset processor.
> * When the dataset is built by {{SPARQL_QueryGeneral}}, it does not clear
> the query FROM so that get interpreted again during query processing as
> picking from the dataset.
> The general purpose SPARQL processor is {{--general}} in Fuseki Main.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (JENA-1670) The Xerces-based XML datatype support uses string classnames to create factories
[ https://issues.apache.org/jira/browse/JENA-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne resolved JENA-1670. - Resolution: Fixed Fix Version/s: Jena 3.11.0 > The Xerces-based XML datatype support uses string classnames to create > factories > > > Key: JENA-1670 > URL: https://issues.apache.org/jira/browse/JENA-1670 > Project: Apache Jena > Issue Type: Improvement > Components: Datatypes >Affects Versions: Jena 3.10.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.11.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Package: org.apache.jena.ext.xerces.impl.dv; > Classes affected: SchemaDVFactory, DTDDVFactory. > For this self-contained use of Xerces code, we can just create the right > class without class name, and newInstance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1670) The Xerces-based XML datatype support uses string classnames to create factories
[ https://issues.apache.org/jira/browse/JENA-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769601#comment-16769601 ] ASF subversion and git services commented on JENA-1670: --- Commit 1954b3cbff86104436e34ccee5323cc77ad2da26 in jena's branch refs/heads/master from Andy Seaborne [ https://gitbox.apache.org/repos/asf?p=jena.git;h=1954b3c ] JENA-1670: Hardwire and isolate ext.Xerces setup > The Xerces-based XML datatype support uses string classnames to create > factories > > > Key: JENA-1670 > URL: https://issues.apache.org/jira/browse/JENA-1670 > Project: Apache Jena > Issue Type: Improvement > Components: Datatypes >Affects Versions: Jena 3.10.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Package: org.apache.jena.ext.xerces.impl.dv; > Classes affected: SchemaDVFactory, DTDDVFactory. > For this self-contained use of Xerces code, we can just create the right > class without class name, and newInstance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] afs removed a comment on issue #528: Allow direct loading of tuples without temporary tables
afs removed a comment on issue #528: Allow direct loading of tuples without temporary tables URL: https://github.com/apache/jena/pull/528#issuecomment-464165138 Some tests maybe? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] afs edited a comment on issue #533: Feature/sdborder
afs edited a comment on issue #533: Feature/sdborder URL: https://github.com/apache/jena/pull/533#issuecomment-464165809 Some tests maybe? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] afs commented on issue #533: Feature/sdborder
afs commented on issue #533: Feature/sdborder URL: https://github.com/apache/jena/pull/533#issuecomment-464165809 Some test maybe? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] afs commented on issue #528: Allow direct loading of tuples without temporary tables
afs commented on issue #528: Allow direct loading of tuples without temporary tables URL: https://github.com/apache/jena/pull/528#issuecomment-464165138 Some tests maybe? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (JENA-1671) SPARQL_QueryGeneral does not work.
[
https://issues.apache.org/jira/browse/JENA-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769604#comment-16769604
]
ASF subversion and git services commented on JENA-1671:
---
Commit 4e1e5177fda73a8626df9c5ea914dc86647c3ef2 in jena's branch
refs/heads/master from Andy Seaborne
[ https://gitbox.apache.org/repos/asf?p=jena.git;h=4e1e517 ]
Merge pull request #531 from afs/fuseki-web-query
JENA-1671: Fix general query servlet.
> SPARQL_QueryGeneral does not work.
> --
>
> Key: JENA-1671
> URL: https://issues.apache.org/jira/browse/JENA-1671
> Project: Apache Jena
> Issue Type: Bug
> Components: Fuseki
>Affects Versions: Jena 3.10.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Adding a general purpose SPARQL processor (no dataset, reads data using
> protocol or FROM/FROM NAMED) does work work any more because:
> * The dispatch in {{ActionService}} remaps it to the registered SPARQL
> dataset processor.
> * When the dataset is built by {{SPARQL_QueryGeneral}}, it does not clear
> the query FROM so that get interpreted again during query processing as
> picking from the dataset.
> The general purpose SPARQL processor is {{--general}} in Fuseki Main.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] afs merged pull request #531: JENA-1671: Fix general query servlet.
afs merged pull request #531: JENA-1671: Fix general query servlet. URL: https://github.com/apache/jena/pull/531 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (JENA-1670) The Xerces-based XML datatype support uses string classnames to create factories
[ https://issues.apache.org/jira/browse/JENA-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769602#comment-16769602 ] ASF subversion and git services commented on JENA-1670: --- Commit 8fd4fa94886a150d679e2256585bb447ed2aa6ee in jena's branch refs/heads/master from Andy Seaborne [ https://gitbox.apache.org/repos/asf?p=jena.git;h=8fd4fa9 ] Merge pull request #530 from afs/xerces-refinement JENA-1670: Hardwire and isolate ext.Xerces setup > The Xerces-based XML datatype support uses string classnames to create > factories > > > Key: JENA-1670 > URL: https://issues.apache.org/jira/browse/JENA-1670 > Project: Apache Jena > Issue Type: Improvement > Components: Datatypes >Affects Versions: Jena 3.10.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Package: org.apache.jena.ext.xerces.impl.dv; > Classes affected: SchemaDVFactory, DTDDVFactory. > For this self-contained use of Xerces code, we can just create the right > class without class name, and newInstance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] afs merged pull request #530: JENA-1670: Hardwire and isolate ext.Xerces setup
afs merged pull request #530: JENA-1670: Hardwire and isolate ext.Xerces setup URL: https://github.com/apache/jena/pull/530 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] afs commented on issue #533: Feature/sdborder
afs commented on issue #533: Feature/sdborder URL: https://github.com/apache/jena/pull/533#issuecomment-464149627 Recorded as [JENA-1673](https://issues.apache.org/jira/browse/JENA-1673). (If the JIRA is opened before the PR and the PR has the JENA- in the title, the automation will update the JIRA ticket with activity on the PR.) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (JENA-1601) Make ClosableIterator extend AutoCloseable
[
https://issues.apache.org/jira/browse/JENA-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769553#comment-16769553
]
Andy Seaborne commented on JENA-1601:
-
A possibility is to add these two default methods to ExtendedIterator:
{code}
/**
* Execute an action on each element of this ExtendedIterator.
* The iterator is consumed and closed by this call.
*/
public default void loop( Consumer action ) {
try {
while(hasNext())
action.accept(next());
} finally { close(); }
}
/**
* Execute an action on this ExtendedIterator, wrapped in a
try-finally-close construct.
* The iterator processing code can throw exceptions or return early.
* The iterator is closed by this call.
*/
public default void process( Consumer> iteratorLoop ) {
try {
iteratorLoop.accept(this);
} finally { close(); }
}
{code}
This is a soft approach to having auto-closeable behaviour - it won't trigger
all application code getting IDE warnings.
> Make ClosableIterator extend AutoCloseable
> -
>
> Key: JENA-1601
> URL: https://issues.apache.org/jira/browse/JENA-1601
> Project: Apache Jena
> Issue Type: Improvement
> Components: Jena
>Affects Versions: Jena 3.8.0
>Reporter: David Schwingenschlögl
>Assignee: Andy Seaborne
>Priority: Minor
>
> The interface org.apache.jena.util.iterator.ClosableIterator defines a
> method public void close(), so the concept of closing is already baked into
> it. The only barrier to using a ClosableIterator (and thus, ExtendedIterator)
> in a try-with-resource block is the missing extension of
> java.lang.AutoCloseable.
> According to API documentation of ClosableIterator, an iterator should be
> closed when not completely exhausted, which may be the case when the block
> consuming the iterator throws an exception, effectively making constructs
> such as this necessary:
> {code:java}
> final ExtendedIterator iterator = someGraph.find();
> try {
> while (iterator.hasNext()) {
> // consume iterator, might throw in here
> }
> } finally {
> // Prevent resource leaks
> iterator.close();
> }
> {code}
> This would be better expressed in a try-with-resource-construct:
> {code:java}
> try (final ExtendedIterator itrator = someGraph.find()) {
> // consume iterator, might throw in here
> }
> {code}
> From what I can tell, making a ClosableIterator also extend AutoCloseable
> only adds to the usability of Jena's API while keeping source backwards
> compatibility intact.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: From PR #528 - policy around SDB.
+1. The advantage of a low-use part is that it is also low-risk to improve it. ajs6f > On Feb 15, 2019, at 12:26 PM, Andy Seaborne wrote: > > PMC level > > It is good to see contributions from Grapham Trigg to SDB. > > While there is activity around SDB, I don't think the general community is > paying much attention code-level to it. > > Nowadays, I barely have an MySQL setup running, and no PostGreSQL, and don't > use SDB for real so performance validation isn't possible. > > I think we should apply PRs quite freely providing the basics of checking > process and IP are done. > > Any comments? > >Andy > > Forwarded Message > Subject: [GitHub] afs commented on issue #528: Allow direct loading of tuples > without temporary tables > Date: Fri, 15 Feb 2019 14:05:43 - > > afs commented on issue #528 > URL: https://github.com/apache/jena/pull/528#issuecomment-464061578 > > The project position on SDB is currently that it is discouraged for new > applications and that problems with the module SDB would not block a release; > it would get dropped for the release. > > On that basis, I'm inclined to be quite permissive about changes to SDB. If > someone can make something better that works for them, then merge it. > > I'm not sure how many users there are and what databases they use. > Historicially MySQL has been the most commonly used backend. >
From PR #528 - policy around SDB.
PMC level It is good to see contributions from Grapham Trigg to SDB. While there is activity around SDB, I don't think the general community is paying much attention code-level to it. Nowadays, I barely have an MySQL setup running, and no PostGreSQL, and don't use SDB for real so performance validation isn't possible. I think we should apply PRs quite freely providing the basics of checking process and IP are done. Any comments? Andy Forwarded Message Subject: [GitHub] afs commented on issue #528: Allow direct loading of tuples without temporary tables Date: Fri, 15 Feb 2019 14:05:43 - afs commented on issue #528 URL: https://github.com/apache/jena/pull/528#issuecomment-464061578 The project position on SDB is currently that it is discouraged for new applications and that problems with the module SDB would not block a release; it would get dropped for the release. On that basis, I'm inclined to be quite permissive about changes to SDB. If someone can make something better that works for them, then merge it. I'm not sure how many users there are and what databases they use. Historicially MySQL has been the most commonly used backend.
[jira] [Updated] (JENA-1673) SDB improvements
[ https://issues.apache.org/jira/browse/JENA-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne updated JENA-1673: Description: Contribution from [~grahamtriggs] : [PR 553|https://github.com/apache/jena/pull/533]. was:Contribution from Graham Twiggs : [PR 553|https://github.com/apache/jena/pull/533]. > SDB improvements > > > Key: JENA-1673 > URL: https://issues.apache.org/jira/browse/JENA-1673 > Project: Apache Jena > Issue Type: Improvement >Affects Versions: Jena 3.10.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > > Contribution from [~grahamtriggs] : [PR > 553|https://github.com/apache/jena/pull/533]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (JENA-1673) SDB improvements
[ https://issues.apache.org/jira/browse/JENA-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne updated JENA-1673: Reporter: Graham Triggs (was: Andy Seaborne) > SDB improvements > > > Key: JENA-1673 > URL: https://issues.apache.org/jira/browse/JENA-1673 > Project: Apache Jena > Issue Type: Improvement >Affects Versions: Jena 3.10.0 >Reporter: Graham Triggs >Assignee: Andy Seaborne >Priority: Major > > Contribution from [~grahamtriggs] : [PR > 553|https://github.com/apache/jena/pull/533]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (JENA-1673) SDB improvements
Andy Seaborne created JENA-1673: --- Summary: SDB improvements Key: JENA-1673 URL: https://issues.apache.org/jira/browse/JENA-1673 Project: Apache Jena Issue Type: Improvement Affects Versions: Jena 3.10.0 Reporter: Andy Seaborne Assignee: Andy Seaborne Contribution from Graham Twiggs : [PR 553|https://github.com/apache/jena/pull/533]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] afs commented on issue #528: Allow direct loading of tuples without temporary tables
afs commented on issue #528: Allow direct loading of tuples without temporary tables URL: https://github.com/apache/jena/pull/528#issuecomment-464061578 The project position on SDB is currently that it is discouraged for new applications and that problems with the module SDB would not block a release; it would get dropped for the release. On that basis, I'm inclined to be quite permissive about changes to SDB. If someone can make something better that works for them, then merge it. I'm not sure how many users there are and what databases they use. Historicially MySQL has been the most commonly used backend. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] afs opened a new pull request #532: JENA-1672: Proper function implementation
afs opened a new pull request #532: JENA-1672: Proper function implementation URL: https://github.com/apache/jena/pull/532 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (JENA-1672) FunctionBase has a field, making it unsafe for threads or use twice in an eval tree
Andy Seaborne created JENA-1672: --- Summary: FunctionBase has a field, making it unsafe for threads or use twice in an eval tree Key: JENA-1672 URL: https://issues.apache.org/jira/browse/JENA-1672 Project: Apache Jena Issue Type: Improvement Components: ARQ Affects Versions: Jena 3.10.0 Reporter: Andy Seaborne Assignee: Andy Seaborne Fix For: Jena 3.11.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (JENA-1664) SDB Transform - improve performance of OPTIONAL, MINUS
[ https://issues.apache.org/jira/browse/JENA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne resolved JENA-1664. - Resolution: Fixed Fix Version/s: Jena 3.11.0 Thanks to [~grahamtriggs]. > SDB Transform - improve performance of OPTIONAL, MINUS > -- > > Key: JENA-1664 > URL: https://issues.apache.org/jira/browse/JENA-1664 > Project: Apache Jena > Issue Type: Improvement >Affects Versions: Jena 3.10.0 >Reporter: Graham Triggs >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.11.0 > > > [PR 527|https://github.com/apache/jena/pull/527]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1664) SDB Transform - improve performance of OPTIONAL, MINUS
[ https://issues.apache.org/jira/browse/JENA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769248#comment-16769248 ] ASF subversion and git services commented on JENA-1664: --- Commit b083f4032463645621d063d1b94ffb02a1a08466 in jena's branch refs/heads/master from Andy Seaborne [ https://gitbox.apache.org/repos/asf?p=jena.git;h=b083f40 ] Merge pull request #527 from grahamtriggs/feature/sdbtransform JENA-1664: SDB Transform - improve performance of OPTIONAL, MINUS > SDB Transform - improve performance of OPTIONAL, MINUS > -- > > Key: JENA-1664 > URL: https://issues.apache.org/jira/browse/JENA-1664 > Project: Apache Jena > Issue Type: Improvement >Affects Versions: Jena 3.10.0 >Reporter: Graham Triggs >Assignee: Andy Seaborne >Priority: Major > > [PR 527|https://github.com/apache/jena/pull/527]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] afs merged pull request #527: SDB Transform - improve performance of OPTIONAL, MINUS
afs merged pull request #527: SDB Transform - improve performance of OPTIONAL, MINUS URL: https://github.com/apache/jena/pull/527 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
