[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user afs commented on the issue: https://github.com/apache/jena/pull/474 I've picked out the .gitignore changes (not for `META-INF` - that's needed) and added them. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 Closing in favor of #476 ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user afs commented on the issue: https://github.com/apache/jena/pull/474 `10 < 11`. All these issues are in Java11 because Java 9 & 10 were the big changes and Java 11 the consolidation. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/474 @rvesse Yup, that's my site and every other one I know. That's not to say that this PR isn't worthwhile, just that I would certainly like to spend as much time as possible on 11, not 10. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/474 @afs Agreed, many folks are going to migrate Java 8 -> Java 11 because of the LTS release status are are skipping interim versions ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user afs commented on the issue: https://github.com/apache/jena/pull/474 "should be used with JDK 1.8" has several facets. There are different levels of Java11 usage: the project discussions back when it was Java9: [dev@ message](https://lists.apache.org/thread.html/880632ba6b6df6f2b26e4357462d94426ea4b14d83f08e9edac0b684@%3Cdev.jena.apache.org%3E) and sent as part of [users@ message](https://lists.apache.org/thread.html/5b31a3b6794781f6a02658608444043b5535957a6c94f3728efd8304@%3Cusers.jena.apache.org%3E). Ultimately, it is a community decision. My personal opinion is that Jena should be able to run on Java8 runtime. Research projects may upgrade quickly but enterprise deployments are another matter. To ensure no accidents, I prefer the release build used Java8 because it protects against runtime library changes (we have one currently about tools.jar). I'd like the build to work with Java11 - hence the commented line in the parent `pom.xml` and the Jenkins job, both of which came out of the project discussions from Feb. Currently, "-Pdev" works, the full release build does not. I have `~/.mavenrc` setup to make sure I gets builds right. I use JDK10 as the default java on my system (I am resisting installing Java11 manually and waiting for Ubuntu ... at least for now!), I make sure maven runs with Java8. # ~/.mavenrc JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 Java11 will change the ecosystem and we don't know how that plays out or what may come out of [adoptjava](https://adoptopenjdk.net/) and the Jan2019 deadline from Oracle. I think it will rapidly become clear. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/474 I think there is a simpler solution to this, I have Jena JDBC building locally under JDK10 and will push a new PR shortly ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 @afs > The problem is not html4/html5 (we can clean up the javadoc) but compatible with java8 javadoc tool. Java8 build causes: Got it. > I'd prefer that the build uses java8 for java8 libraries because cross-compiling does not catch changes in the runtime libraries. So do you want to abandon this PR and state that Jena should be used with JDK 1.8? If so I can close out this issue. Unless of course if you can propose an alternative. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/474 @afs https://github.com/rvesse/airline/blob/master/pom.xml#L495-L497 which I discovered via JIRA https://issues.apache.org/jira/browse/MJAVADOC-475 ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user afs commented on the issue: https://github.com/apache/jena/pull/474 @rvesse - The current plugin in the build is 3.0.0. `` didn't change the situation. Can you given an example or point to one? (the online plugin doc does not talk about `` Profiles: that would be great. Again, a sample to start from would help. While all the suggestions here are great, it's going to be slower if I have to carry out each one from scratch. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user afs commented on the issue: https://github.com/apache/jena/pull/474 @lewismc > @afs how about we propose the change to > > ``` > -html4 > ``` > This would produce JDK WARNING's under several environment's however would at least enable successful build under this environments. The problem is not html4/html5 (we can clean up the javadoc) but compatible with java8 javadoc tool. Java8 build causes: Exit code: 1 - javadoc: error - invalid flag: -html4 I'd prefer that the build uses java8 for java8 libraries because cross-compiling does not catch changes in the runtime libraries. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 I have not tried this build under JDK11 yet. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 @afs how about we propose the change to ``` -html4 ``` This would produce JDK WARNING's under several environment's however would at least enable successful build under this environments. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user rvesse commented on the issue: https://github.com/apache/jena/pull/474 @afs For some projects where I have added JDK 9/10 support I have had to create separate profiles activated by JDK version for the Javadoc plugin because there are breaking changes between the plugin versions and supported flags for the underlying `javadoc` tool Also if you have updated the Javadoc plugin version to a 3.x release then you need to add an `` sub-element within `` rather than just specifying the options directly ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user afs commented on the issue: https://github.com/apache/jena/pull/474 I'm trying to get a single build configuration for both java10 and java8. I can't get Jena to build with java8 if `-html5` is set. It is a problem in the full build because skipping javadoc isn't an option - the distributions include javadoc by dependency. With java 10.0.2 (Ubuntu latest with the placeholder java11 - still waiting for real java11): jena-elephas-common fails because: ``` [ERROR] Failed to execute goal on project jena-elephas-common: Could not resolve dependencies for project org.apache.jena:jena-elephas-common:jar:3.10.0-SNAPSHOT: Could not find artifact jdk.tools:jdk.tools:jar:1.6 at specified path /usr/lib/jvm/java-11-openjdk-amd64/../lib/tools.jar -> [Help 1] ``` (it also used MRUnit which is a retired project) A pure maven build will put the java11 runtime (no tools.jar) on the compile classpath. @lewismc - am I right in concluding it worked for you in the IDE because the java8 runtime was on the build path? ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 Thanks @afs I looked at the build and built locally using the following parameters ``` mvn clean verify -Pdev ``` ... it results in SUCCESSFUL build. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user afs commented on the issue: https://github.com/apache/jena/pull/474 See https://builds.apache.org/view/H-L/view/Jena/job/Jena_JDK11/ which builds with -Pdev and has been running for a while. It does not build jena-jdbc or jena-elephas both of which are need looking at. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 Thats good to know @acoburn thanks for chiming in. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user acoburn commented on the issue: https://github.com/apache/jena/pull/474 It is possibly worth noting here that these changes also make it possible to build Jena on JDK 11. ---
[GitHub] jena issue #474: JENA-1609 Jena master does not build under JDK10
Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 Thanks for comments @ajs6f ---
