Re: [jira] [Commented] (JENA-945) Add Seven methods to Query class
It's OK by me. I was going to get back to it but got caught up with other
work.
Claude
On Sun, May 24, 2015 at 11:21 AM, Andy Seaborne a...@apache.org wrote:
Do you mind if I clear up to remove the duplication of functionality in
Query?
Andy
On 21/05/15 07:18, Claude Warren wrote:
They are not both needed. It was a case of simultaneous development. You
added the the two methods while I added the one. I ran a complete build
and test on my (s...ll...o...w...) system and when it worked committed.
You and made your changes and committed at the same time.
On Wed, May 20, 2015 at 11:11 PM, Andy Seaborne (JIRA) j...@apache.org
wrote:
[
https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553230#comment-14553230
]
Andy Seaborne commented on JENA-945:
Replacing the call of {{Query.setGroupBy}} in
{{SolutionModifierHandler}},
that is.
Add Seven methods to Query class
Key: JENA-945
URL: https://issues.apache.org/jira/browse/JENA-945
Project: Apache Jena
Issue Type: Improvement
Components: Core
Affects Versions: Jena 3.0.0
Reporter: Claude Warren
Assignee: Claude Warren
Priority: Minor
Fix For: Jena 3.0.0
The QueryBuilder uses reflection to perform some of its data
manipulation. This reflection will fail in an environment with Java
Security Manager enabled.
This change is to add methods so that QueryBuilder no longer needs to
use reflection to get and set Query internal variables.
The variables are:
namedGraphURIs -- get and set required. parameter/return: ListString
graphURIs -- get and set required. parameter/return: ListString
projectVars -- get and set required. parameter/return: VarExprList
groupVars -- set required. parameter: VarExprList
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
--
I like: Like Like - The likeliest place on the web
http://like-like.xenei.com
LinkedIn: http://www.linkedin.com/in/claudewarren
Re: [jira] [Commented] (JENA-945) Add Seven methods to Query class
Do you mind if I clear up to remove the duplication of functionality in
Query?
Andy
On 21/05/15 07:18, Claude Warren wrote:
They are not both needed. It was a case of simultaneous development. You
added the the two methods while I added the one. I ran a complete build
and test on my (s...ll...o...w...) system and when it worked committed.
You and made your changes and committed at the same time.
On Wed, May 20, 2015 at 11:11 PM, Andy Seaborne (JIRA) j...@apache.org
wrote:
[
https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553230#comment-14553230
]
Andy Seaborne commented on JENA-945:
Replacing the call of {{Query.setGroupBy}} in {{SolutionModifierHandler}},
that is.
Add Seven methods to Query class
Key: JENA-945
URL: https://issues.apache.org/jira/browse/JENA-945
Project: Apache Jena
Issue Type: Improvement
Components: Core
Affects Versions: Jena 3.0.0
Reporter: Claude Warren
Assignee: Claude Warren
Priority: Minor
Fix For: Jena 3.0.0
The QueryBuilder uses reflection to perform some of its data
manipulation. This reflection will fail in an environment with Java
Security Manager enabled.
This change is to add methods so that QueryBuilder no longer needs to
use reflection to get and set Query internal variables.
The variables are:
namedGraphURIs -- get and set required. parameter/return: ListString
graphURIs -- get and set required. parameter/return: ListString
projectVars -- get and set required. parameter/return: VarExprList
groupVars -- set required. parameter: VarExprList
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Commented] (JENA-945) Add Seven methods to Query class
They are not both needed. It was a case of simultaneous development. You
added the the two methods while I added the one. I ran a complete build
and test on my (s...ll...o...w...) system and when it worked committed.
You and made your changes and committed at the same time.
On Wed, May 20, 2015 at 11:11 PM, Andy Seaborne (JIRA) j...@apache.org
wrote:
[
https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553230#comment-14553230
]
Andy Seaborne commented on JENA-945:
Replacing the call of {{Query.setGroupBy}} in {{SolutionModifierHandler}},
that is.
Add Seven methods to Query class
Key: JENA-945
URL: https://issues.apache.org/jira/browse/JENA-945
Project: Apache Jena
Issue Type: Improvement
Components: Core
Affects Versions: Jena 3.0.0
Reporter: Claude Warren
Assignee: Claude Warren
Priority: Minor
Fix For: Jena 3.0.0
The QueryBuilder uses reflection to perform some of its data
manipulation. This reflection will fail in an environment with Java
Security Manager enabled.
This change is to add methods so that QueryBuilder no longer needs to
use reflection to get and set Query internal variables.
The variables are:
namedGraphURIs -- get and set required. parameter/return: ListString
graphURIs -- get and set required. parameter/return: ListString
projectVars -- get and set required. parameter/return: VarExprList
groupVars -- set required. parameter: VarExprList
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
--
I like: Like Like - The likeliest place on the web
http://like-like.xenei.com
LinkedIn: http://www.linkedin.com/in/claudewarren
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[
https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553222#comment-14553222
]
Andy Seaborne commented on JENA-945:
Replacing the call of {{Query.setGroupBy}} by:
{noformat}
query.getGroupBy().clear()
query.getGroupBy().addAll(...)
{noformat}
works -- I don't undertand why {{setGroupBy}} is needed.
Add Seven methods to Query class
Key: JENA-945
URL: https://issues.apache.org/jira/browse/JENA-945
Project: Apache Jena
Issue Type: Improvement
Components: Core
Affects Versions: Jena 3.0.0
Reporter: Claude Warren
Assignee: Claude Warren
Priority: Minor
Fix For: Jena 3.0.0
The QueryBuilder uses reflection to perform some of its data manipulation.
This reflection will fail in an environment with Java Security Manager
enabled.
This change is to add methods so that QueryBuilder no longer needs to use
reflection to get and set Query internal variables.
The variables are:
namedGraphURIs -- get and set required. parameter/return: ListString
graphURIs -- get and set required. parameter/return: ListString
projectVars -- get and set required. parameter/return: VarExprList
groupVars -- set required. parameter: VarExprList
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[
https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553230#comment-14553230
]
Andy Seaborne commented on JENA-945:
Replacing the call of {{Query.setGroupBy}} in {{SolutionModifierHandler}}, that
is.
Add Seven methods to Query class
Key: JENA-945
URL: https://issues.apache.org/jira/browse/JENA-945
Project: Apache Jena
Issue Type: Improvement
Components: Core
Affects Versions: Jena 3.0.0
Reporter: Claude Warren
Assignee: Claude Warren
Priority: Minor
Fix For: Jena 3.0.0
The QueryBuilder uses reflection to perform some of its data manipulation.
This reflection will fail in an environment with Java Security Manager
enabled.
This change is to add methods so that QueryBuilder no longer needs to use
reflection to get and set Query internal variables.
The variables are:
namedGraphURIs -- get and set required. parameter/return: ListString
graphURIs -- get and set required. parameter/return: ListString
projectVars -- get and set required. parameter/return: VarExprList
groupVars -- set required. parameter: VarExprList
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550229#comment-14550229 ] Claude Warren commented on JENA-945: After further review and some head scratching I managed to reduce the change to adding a setGroupBy(VarExprList) method. If the method is passed a null it resets the groupBy to an empty list (initial condition upon construction of the Query). So it can not be set to null by this method. It was either add that or add methods to VarExprList that would allow manipulation of the items in that list. That seemed to be more work and more prone to error. Add Seven methods to Query class Key: JENA-945 URL: https://issues.apache.org/jira/browse/JENA-945 Project: Apache Jena Issue Type: Improvement Components: Core Affects Versions: Jena 3.0.0 Reporter: Claude Warren Assignee: Claude Warren Priority: Minor The QueryBuilder uses reflection to perform some of its data manipulation. This reflection will fail in an environment with Java Security Manager enabled. This change is to add methods so that QueryBuilder no longer needs to use reflection to get and set Query internal variables. The variables are: namedGraphURIs -- get and set required. parameter/return: ListString graphURIs -- get and set required. parameter/return: ListString projectVars -- get and set required. parameter/return: VarExprList groupVars -- set required. parameter: VarExprList -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[
https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550349#comment-14550349
]
Andy Seaborne commented on JENA-945:
Added {{VarExprList::clear()}} and {{VarExprList::remove(Var)}}.
Add Seven methods to Query class
Key: JENA-945
URL: https://issues.apache.org/jira/browse/JENA-945
Project: Apache Jena
Issue Type: Improvement
Components: Core
Affects Versions: Jena 3.0.0
Reporter: Claude Warren
Assignee: Claude Warren
Priority: Minor
The QueryBuilder uses reflection to perform some of its data manipulation.
This reflection will fail in an environment with Java Security Manager
enabled.
This change is to add methods so that QueryBuilder no longer needs to use
reflection to get and set Query internal variables.
The variables are:
namedGraphURIs -- get and set required. parameter/return: ListString
graphURIs -- get and set required. parameter/return: ListString
projectVars -- get and set required. parameter/return: VarExprList
groupVars -- set required. parameter: VarExprList
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550661#comment-14550661 ] ASF subversion and git services commented on JENA-945: -- Commit 716640bbe42bae9c014ce5fae99af37e2f9f6692 in jena's branch refs/heads/master from [~cla...@xenei.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=716640b ] Added Query.setGroupBy( VarExprList) in support of QueryBuilder and to close JENA-945 Add Seven methods to Query class Key: JENA-945 URL: https://issues.apache.org/jira/browse/JENA-945 Project: Apache Jena Issue Type: Improvement Components: Core Affects Versions: Jena 3.0.0 Reporter: Claude Warren Assignee: Claude Warren Priority: Minor The QueryBuilder uses reflection to perform some of its data manipulation. This reflection will fail in an environment with Java Security Manager enabled. This change is to add methods so that QueryBuilder no longer needs to use reflection to get and set Query internal variables. The variables are: namedGraphURIs -- get and set required. parameter/return: ListString graphURIs -- get and set required. parameter/return: ListString projectVars -- get and set required. parameter/return: VarExprList groupVars -- set required. parameter: VarExprList -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14551043#comment-14551043 ] ASF subversion and git services commented on JENA-945: -- Commit 716640bbe42bae9c014ce5fae99af37e2f9f6692 in jena's branch refs/heads/add-contract-tests from [~cla...@xenei.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=716640b ] Added Query.setGroupBy( VarExprList) in support of QueryBuilder and to close JENA-945 Add Seven methods to Query class Key: JENA-945 URL: https://issues.apache.org/jira/browse/JENA-945 Project: Apache Jena Issue Type: Improvement Components: Core Affects Versions: Jena 3.0.0 Reporter: Claude Warren Assignee: Claude Warren Priority: Minor The QueryBuilder uses reflection to perform some of its data manipulation. This reflection will fail in an environment with Java Security Manager enabled. This change is to add methods so that QueryBuilder no longer needs to use reflection to get and set Query internal variables. The variables are: namedGraphURIs -- get and set required. parameter/return: ListString graphURIs -- get and set required. parameter/return: ListString projectVars -- get and set required. parameter/return: VarExprList groupVars -- set required. parameter: VarExprList -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[
https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14547096#comment-14547096
]
Andy Seaborne commented on JENA-945:
The description does not say why the proposed operations are needed.
I was not clear whether the need is because something can't be done (parsing
and serializaling is managing to use the public interface to create queries),
or needs to be done differently or the presence of the operations was missed.
The only thing that direct access to those members gives is being about to set
them to null, and then every access has to check, or to use an alternative to
{{ArrayList}}.
If you wish to add javadoc, then go ahead but additional operations to provide
similar function don't seem like a good idea to me.
Add Seven methods to Query class
Key: JENA-945
URL: https://issues.apache.org/jira/browse/JENA-945
Project: Apache Jena
Issue Type: Improvement
Components: Core
Affects Versions: Jena 3.0.0
Reporter: Claude Warren
Assignee: Claude Warren
Priority: Minor
The QueryBuilder uses reflection to perform some of its data manipulation.
This reflection will fail in an environment with Java Security Manager
enabled.
This change is to add methods so that QueryBuilder no longer needs to use
reflection to get and set Query internal variables.
The variables are:
namedGraphURIs -- get and set required. parameter/return: ListString
graphURIs -- get and set required. parameter/return: ListString
projectVars -- get and set required. parameter/return: VarExprList
groupVars -- set required. parameter: VarExprList
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546911#comment-14546911 ] Claude Warren commented on JENA-945: Are you indicating that you think we should not allow direct access to the relevant lists or just that it should be noted in the documentation. I would prefer the latter. The QueryBuilder requires the ability to modify the list. That is, it may replace (positionally significant) a variable in the list. So either direct access to the list, or get, add and replace methods need to be provided. QueryBuilder is also in a different package. (o.a.j.arq.querybuilder). Add Seven methods to Query class Key: JENA-945 URL: https://issues.apache.org/jira/browse/JENA-945 Project: Apache Jena Issue Type: Improvement Components: Core Affects Versions: Jena 3.0.0 Reporter: Claude Warren Assignee: Claude Warren Priority: Minor The QueryBuilder uses reflection to perform some of its data manipulation. This reflection will fail in an environment with Java Security Manager enabled. This change is to add methods so that QueryBuilder no longer needs to use reflection to get and set Query internal variables. The variables are: namedGraphURIs -- get and set required. parameter/return: ListString graphURIs -- get and set required. parameter/return: ListString projectVars -- get and set required. parameter/return: VarExprList groupVars -- set required. parameter: VarExprList -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[
https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546874#comment-14546874
]
Andy Seaborne commented on JENA-945:
{noformat}
addGraphURI / getGraphURIs
addNamedGraphURI / getNamedGraphURIs
addResultVar / getProject
addGroupBy / getGroupBy
{noformat}
The {{get*}} return the relevant lists that can be manipulated directly.
Add Seven methods to Query class
Key: JENA-945
URL: https://issues.apache.org/jira/browse/JENA-945
Project: Apache Jena
Issue Type: Improvement
Components: Core
Affects Versions: Jena 3.0.0
Reporter: Claude Warren
Priority: Minor
The QueryBuilder uses reflection to perform some of its data manipulation.
This reflection will fail in an environment with Java Security Manager
enabled.
This change is to add methods so that QueryBuilder no longer needs to use
reflection to get and set Query internal variables.
The variables are:
namedGraphURIs -- get and set required. parameter/return: ListString
graphURIs -- get and set required. parameter/return: ListString
projectVars -- get and set required. parameter/return: VarExprList
groupVars -- set required. parameter: VarExprList
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
