Re: svn commit: r1233097 - in /jmeter/trunk: docs/images/screenshots/changes/ xdocs/ xdocs/images/screenshots/changes/
Le 20/01/2012 22:37, Philippe Mouawad a ecrit : Hello, My mail was incorrect, here is the right text: - I did screenshot for JMS and put it in images/screenshots/changes Thanks. Finally I did a new screenshot with same parameters to keep same look and feel (police) that others captures. - I let you do gedit screenshot for: - ignore failed for embedded resources as I don't have this software on my machine. Done. - Bug 43294 (which in fact is more an enhancement ) - Bug 52469 - = But I don't know if we should do this for every change or do One screenshot with arrows indicating which BUG is concerned ? It is not necessary to have screenshots for this bugs. If this bugs must have a light, you can add some special text at the end of New and Noteworthy section. Milamber Thank you On Fri, Jan 20, 2012 at 11:06 PM, Philippe Mouawad philippe.moua...@gmail.com wrote: Hello Milamber, you can find screenshots in: - jmssubscriber.png - Hello Milamber, - I did screenshot for JMS. - I let you do gedit screenshot for ignore failed for embedded resources as I don't have this software on my machine. Thank you Regards Philippe On Thu, Jan 19, 2012 at 2:13 PM, Milamber milam...@apache.org wrote: On Thu, Jan 19, 2012 at 12:20 PM, Philippe Mouawad philippe.moua...@gmail.com wrote: Hello, Regarding New and noteworthy, should'nt we also have: - JMS improvements (51419 and 52088) - And ignore failed for embedded resources (like Remote Batching support) Milamber, I can add them if you tell me which software you use for your highlights ? I use : Shutter for screen-shots and annotation ( http://shutter-project.org/) (Debian packages) And The GIMP for add a black border (2pix) I can make the resizing and integrating in changes.xml if you send me the full screenshots. Milamber Thanks. Regards Philippe On Thu, Jan 19, 2012 at 7:36 AM, Philippe Mouawad philippe.moua...@gmail.com wrote: Yes, very good indeed ! Thanks On Thu, Jan 19, 2012 at 2:47 AM, sebb seb...@gmail.com wrote: On 18 January 2012 22:29, milam...@apache.org wrote: Author: milamber Date: Wed Jan 18 22:29:54 2012 New Revision: 1233097 URL: http://svn.apache.org/viewvc?rev=1233097view=rev Log: Add New and Noteworthy for next version (2.6) Looks very good, thanks! -- Cordialement. Philippe Mouawad. -- Cordialement. Philippe Mouawad. -- Cordialement. Philippe Mouawad.
Re: Time for a release?
Le 20/01/2012 22:30, Philippe Mouawad a ecrit : Hello, There is this issue that seems fixed for me : - 50618 https://issues.apache.org/bugzilla/show_bug.cgi?id=50618 It impacts the following part in changes.xml: *pThe If Controller may cause an infinite loop if the condition is always false from the first iteration. A workaround is to add a sampler at the same level as (or superior to) the If Controller. For example a Test Action sampler with 0 wait time (which doesn't generate a sample), or a Debug Sampler with all fields set to False (to reduce the sample size). /p* Yes it's fixed by StackOverflow catch. Infinite loop don't appear. The only issue is the counts number don't increase in Listeners. with this use case: https://issues.apache.org/bugzilla/attachment.cgi?id=26539 Text in changes.xml can be modified to become a text like: Listeners don't show iteration counts when a If Controller have a condition which is always false from the first iteration. Bug 50618 can be closed, and perhaps add a new bug for the sentence above. Milamber Are we sure issue is still here ? Regards Philippe On Thu, Jan 19, 2012 at 1:12 PM, Philippe Mouawad philippe.moua...@gmail.com wrote: I have to finish 2 things (mirror server documentation and default to 2.5.1 behaviour) and commit another patch . I think I will do it this week end. Sebb, Milamber, when do you plan the release ? Regards Philippe On Thu, Jan 19, 2012 at 8:49 AM, Milamber milam...@apache.org wrote: Hello, I can act as a release manager for the 2.6 version. Milamber Le 15/01/2012 14:27, Milamber a ecrit : Le 15/01/2012 12:58, Rainer Jung a ecrit : Hello everyone, at the beginning of December 2011 we discussed, whether we should have a release soon. I think the overall opinion was yes but it seems the project is still busy with fixing things and adding enhancements. Nevertheless I have the impression there are now enough changes to warrant the next release and get all the nice new stuff out in users hands. I don't know whether it should be a 2.5.2 or 2.6 though. +1 to release a new version 2.6 Milamber Kudos to all the effort you put into JMeter! Regards, Rainer -- Cordialement. Philippe Mouawad.
Re: Time for a release?
On 21 January 2012 11:10, Milamber milam...@apache.org wrote: Le 19/01/2012 12:12, Philippe Mouawad a ecrit : I have to finish 2 things (mirror server documentation and default to 2.5.1 behaviour) and commit another patch . I think I will do it this week end. Sebb, Milamber, when do you plan the release ? I can targeting to a first JMeter 2.6 Release Candidate around next weekend (1/28/12) if everybody is ok. Should be OK timewise. I've still got some bits to finish so we can upload jars for eventual release to the Maven repo, but should have them done by then. The Ant script currently assumes that Maven CLI is available. Do you have Maven installed? If so which version? Milamber Regards Philippe On Thu, Jan 19, 2012 at 8:49 AM, Milamber milam...@apache.org wrote: Hello, I can act as a release manager for the 2.6 version. Milamber Le 15/01/2012 14:27, Milamber a ecrit : Le 15/01/2012 12:58, Rainer Jung a ecrit : Hello everyone, at the beginning of December 2011 we discussed, whether we should have a release soon. I think the overall opinion was yes but it seems the project is still busy with fixing things and adding enhancements. Nevertheless I have the impression there are now enough changes to warrant the next release and get all the nice new stuff out in users hands. I don't know whether it should be a 2.5.2 or 2.6 though. +1 to release a new version 2.6 Milamber Kudos to all the effort you put into JMeter! Regards, Rainer
Re: Time for a release?
On 21 January 2012 12:35, Milamber milam...@apache.org wrote: Le 21/01/2012 12:12, sebb a ecrit : On 21 January 2012 11:10, Milamber milam...@apache.org wrote: Le 19/01/2012 12:12, Philippe Mouawad a ecrit : I have to finish 2 things (mirror server documentation and default to 2.5.1 behaviour) and commit another patch . I think I will do it this week end. Sebb, Milamber, when do you plan the release ? I can targeting to a first JMeter 2.6 Release Candidate around next weekend (1/28/12) if everybody is ok. Should be OK timewise. I've still got some bits to finish so we can upload jars for eventual release to the Maven repo, but should have them done by then. The Ant script currently assumes that Maven CLI is available. Do you have Maven installed? Yes, 1.8.1 (I can upgrade if needed) That is extremely old, and is Maven 1, which is no longer supported AFAIK. The script will need Maven 2.2.1 or Maven 3.0.4 (just released). See http://maven.apache.org/download.html Now, ant distribution task works fine in my machine, but I don't see maven section in output... I'm still working on it and have not committed it yet. Milamber If so which version? Milamber Regards Philippe On Thu, Jan 19, 2012 at 8:49 AM, Milamber milam...@apache.org wrote: Hello, I can act as a release manager for the 2.6 version. Milamber Le 15/01/2012 14:27, Milamber a ecrit : Le 15/01/2012 12:58, Rainer Jung a ecrit : Hello everyone, at the beginning of December 2011 we discussed, whether we should have a release soon. I think the overall opinion was yes but it seems the project is still busy with fixing things and adding enhancements. Nevertheless I have the impression there are now enough changes to warrant the next release and get all the nice new stuff out in users hands. I don't know whether it should be a 2.5.2 or 2.6 though. +1 to release a new version 2.6 Milamber Kudos to all the effort you put into JMeter! Regards, Rainer
Re: svn commit: r1233097 - in /jmeter/trunk: docs/images/screenshots/changes/ xdocs/ xdocs/images/screenshots/changes/
Thanks Milamber. On Sat, Jan 21, 2012 at 11:02 AM, Milamber milam...@apache.org wrote: Le 20/01/2012 22:37, Philippe Mouawad a ecrit : Hello, My mail was incorrect, here is the right text: - I did screenshot for JMS and put it in images/screenshots/changes Thanks. Finally I did a new screenshot with same parameters to keep same look and feel (police) that others captures. - I let you do gedit screenshot for: - ignore failed for embedded resources as I don't have this software on my machine. Done. - Bug 43294 (which in fact is more an enhancement ) - Bug 52469 - = But I don't know if we should do this for every change or do One screenshot with arrows indicating which BUG is concerned ? It is not necessary to have screenshots for this bugs. If this bugs must have a light, you can add some special text at the end of New and Noteworthy section. Milamber Thank you On Fri, Jan 20, 2012 at 11:06 PM, Philippe Mouawad philippe.moua...@gmail.com wrote: Hello Milamber, you can find screenshots in: - jmssubscriber.png - Hello Milamber, - I did screenshot for JMS. - I let you do gedit screenshot for ignore failed for embedded resources as I don't have this software on my machine. Thank you Regards Philippe On Thu, Jan 19, 2012 at 2:13 PM, Milamber milam...@apache.org wrote: On Thu, Jan 19, 2012 at 12:20 PM, Philippe Mouawad philippe.moua...@gmail.com wrote: Hello, Regarding New and noteworthy, should'nt we also have: - JMS improvements (51419 and 52088) - And ignore failed for embedded resources (like Remote Batching support) Milamber, I can add them if you tell me which software you use for your highlights ? I use : Shutter for screen-shots and annotation ( http://shutter-project.org/) (Debian packages) And The GIMP for add a black border (2pix) I can make the resizing and integrating in changes.xml if you send me the full screenshots. Milamber Thanks. Regards Philippe On Thu, Jan 19, 2012 at 7:36 AM, Philippe Mouawad philippe.moua...@gmail.com wrote: Yes, very good indeed ! Thanks On Thu, Jan 19, 2012 at 2:47 AM, sebb seb...@gmail.com wrote: On 18 January 2012 22:29, milam...@apache.org wrote: Author: milamber Date: Wed Jan 18 22:29:54 2012 New Revision: 1233097 URL: http://svn.apache.org/viewvc?rev=1233097view=rev Log: Add New and Noteworthy for next version (2.6) Looks very good, thanks! -- Cordialement. Philippe Mouawad. -- Cordialement. Philippe Mouawad. -- Cordialement. Philippe Mouawad. -- Cordialement. Philippe Mouawad.
Re: svn commit: r1233620 - in /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control: HttpMirrorControl.java HttpMirrorServer.java
Hello sebb,
Commited.
Regards
Philippe
On Fri, Jan 20, 2012 at 1:19 AM, sebb seb...@gmail.com wrote:
On 19 January 2012 22:42, pmoua...@apache.org wrote:
Author: pmouawad
Date: Thu Jan 19 22:42:29 2012
New Revision: 1233620
URL: http://svn.apache.org/viewvc?rev=1233620view=rev
Log:
Bug 52471 - Improve Mirror Server performance by Using Pool of threads
instead of launching a Thread for each request
Implemented what was described on dev list
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorControl.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorServer.java
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorControl.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorControl.java?rev=1233620r1=1233619r2=1233620view=diff
==
---
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorControl.java
(original)
+++
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorControl.java
Thu Jan 19 22:42:29 2012
@@ -44,7 +44,7 @@ public class HttpMirrorControl extends A
public static final String MAX_POOL_SIZE =
HttpMirrorControlGui.maxPoolSize; // $NON-NLS-1$
-public static final int DEFAULT_MAX_POOL_SIZE = 10;
+public static final int DEFAULT_MAX_POOL_SIZE = 0;
public HttpMirrorControl() {
initPort(DEFAULT_PORT);
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorServer.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorServer.java?rev=1233620r1=1233619r2=1233620view=diff
==
---
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorServer.java
(original)
+++
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorServer.java
Thu Jan 19 22:42:29 2012
@@ -94,13 +94,15 @@ public class HttpMirrorServer extends Th
except = null;
running = true;
ServerSocket mainSocket = null;
-final ArrayBlockingQueueRunnable queue = new
ArrayBlockingQueueRunnable(
-25);
-ThreadPoolExecutor threadPoolExecutor = new ThreadPoolExecutor(
-maxThreadPoolSize/2,
-maxThreadPoolSize, KEEP_ALIVE_TIME, TimeUnit.SECONDS,
queue);
-threadPoolExecutor.setRejectedExecutionHandler(new
ThreadPoolExecutor.DiscardOldestPolicy());
-
+ThreadPoolExecutor threadPoolExecutor = null;
+if(maxThreadPoolSize0) {
+final ArrayBlockingQueueRunnable queue = new
ArrayBlockingQueueRunnable(
+25);
Why choose 25?
Should this not also be changeable?
+threadPoolExecutor = new ThreadPoolExecutor(
+maxThreadPoolSize/2,
+maxThreadPoolSize, KEEP_ALIVE_TIME,
TimeUnit.SECONDS, queue);
+threadPoolExecutor.setRejectedExecutionHandler(new
ThreadPoolExecutor.DiscardOldestPolicy());
+}
try {
log.info(Creating HttpMirror ... on port + daemonPort);
mainSocket = new ServerSocket(daemonPort);
@@ -112,10 +114,13 @@ public class HttpMirrorServer extends Th
Socket clientSocket = mainSocket.accept();
if (running) {
// Pass request to new thread
- threadPoolExecutor.execute(new
HttpMirrorThread(clientSocket));
- //HttpMirrorThread thd = new
HttpMirrorThread(clientSocket);
-log.debug(Starting new Mirror thread);
-//thd.start();
+if(threadPoolExecutor != null) {
+threadPoolExecutor.execute(new
HttpMirrorThread(clientSocket));
+} else {
+Thread thd = new Thread(new
HttpMirrorThread(clientSocket));
+log.debug(Starting new Mirror thread);
+thd.start();
+}
} else {
log.warn(Server not running);
JOrphanUtils.closeQuietly(clientSocket);
@@ -130,7 +135,9 @@ public class HttpMirrorServer extends Th
except = e;
log.warn(HttpMirror Server stopped, e);
} finally {
- threadPoolExecutor.shutdownNow();
+if(threadPoolExecutor != null) {
+threadPoolExecutor.shutdownNow();
+}
Re: Time for a release?
Le 21/01/2012 13:14, sebb a ecrit : On 21 January 2012 12:35, Milamber milam...@apache.org wrote: Le 21/01/2012 12:12, sebb a ecrit : On 21 January 2012 11:10, Milamber milam...@apache.org wrote: Le 19/01/2012 12:12, Philippe Mouawad a ecrit : I have to finish 2 things (mirror server documentation and default to 2.5.1 behaviour) and commit another patch . I think I will do it this week end. Sebb, Milamber, when do you plan the release ? I can targeting to a first JMeter 2.6 Release Candidate around next weekend (1/28/12) if everybody is ok. Should be OK timewise. I've still got some bits to finish so we can upload jars for eventual release to the Maven repo, but should have them done by then. The Ant script currently assumes that Maven CLI is available. Do you have Maven installed? Yes, 1.8.1 (I can upgrade if needed) That is extremely old, and is Maven 1, which is no longer supported AFAIK. Sorry, version 1.8.1 is my Ant version. My Maven version is 2.0.9. I just upgraded to 3.0.4. Milamber The script will need Maven 2.2.1 or Maven 3.0.4 (just released). See http://maven.apache.org/download.html Now, ant distribution task works fine in my machine, but I don't see maven section in output... I'm still working on it and have not committed it yet. Milamber If so which version? Milamber Regards Philippe On Thu, Jan 19, 2012 at 8:49 AM, Milamber milam...@apache.org wrote: Hello, I can act as a release manager for the 2.6 version. Milamber Le 15/01/2012 14:27, Milamber a ecrit : Le 15/01/2012 12:58, Rainer Jung a ecrit : Hello everyone, at the beginning of December 2011 we discussed, whether we should have a release soon. I think the overall opinion was yes but it seems the project is still busy with fixing things and adding enhancements. Nevertheless I have the impression there are now enough changes to warrant the next release and get all the nice new stuff out in users hands. I don't know whether it should be a 2.5.2 or 2.6 though. +1 to release a new version 2.6 Milamber Kudos to all the effort you put into JMeter! Regards, Rainer
Re: Time for a release?
On 21.01.2012 17:42, sebb wrote: I also want to add a signing target which can loop through all the dist artifacts (archives, poms, jars). That will need GPG installed, preferably GPG 2.x Note that Mark has added this feature to the Tomcat ant build just very recently. You can have a look. Regards, Rainer
New Maven targets (was: Re: Time for a release?)
Le 21/01/2012 16:42, sebb a ecrit : If you want to try out the Maven targets, update workspace and build (ant package) Then create the poms/jars: ant _maven_dist -Djmeter.version=2.6-SNAPSHOT [might add this to the distribution target later] Then ant maven_upload will create the a local repo under target/deploy. If that works OK, then it is picking up Maven. You can then try uploading to the snapshots repo: ant maven_upload -DrepoType=snapshots I'm still working on the Maven bits, so the instructions may need to change slightly. It's works. My feedback: If you want to try out the Maven targets, update workspace and build (ant package) Note: Environment variable M2_HOME must be set. (In Eclipse, External Tools Configurations box Ant Build maven task Environment tab) (In command-line, declare an environment variable with export M2_HOME=/path/to/maven_home) Then create the poms/jars: ant _dist_maven -Djmeter.version=2.6-SNAPSHOT [might add this to the distribution target later] Then ant maven_upload -Djmeter.version=2.6-SNAPSHOT will create the a local repo under target/deploy. If that works OK, then it is picking up Maven. You can then try uploading to the snapshots repo: If needed, add or modify your $HOME/.m2/settings.xml with this lines : settings [...] servers server idapache.snapshots.https/id !-- For Snapshots -- usernameASF_Login/username passwordYour_Password/password /server server idapache.releases.https/id !-- For Releases -- usernameASF_Login/username passwordYour_Password/password /server /servers [...] /settings ant maven_upload -Djmeter.version=2.6-SNAPSHOT -DrepoType=snapshots Works: Repository Path: /org/apache/jmeter/ApacheJMeter/2.6-SNAPSHOT/ApacheJMeter-2.6-20120121.185244-4.pom Uploaded by: milamber Size: 1.27 KB Uploaded Date: Sat Jan 21 2012 18:52:55 GMT+ (WET) Last Modified: Sat Jan 21 2012 18:52:55 GMT+ (WET) I also want to add a signing target which can loop through all the dist artifacts (archives, poms, jars). That will need GPG installed, preferably GPG 2.x gpg2 --version gpg (GnuPG) 2.0.14 Milamber Milamber The script will need Maven 2.2.1 or Maven 3.0.4 (just released). See http://maven.apache.org/download.html Now, ant distribution task works fine in my machine, but I don't see maven section in output... I'm still working on it and have not committed it yet. Milamber If so which version? Milamber Regards Philippe On Thu, Jan 19, 2012 at 8:49 AM, Milamber milam...@apache.org wrote: Hello, I can act as a release manager for the 2.6 version. Milamber Le 15/01/2012 14:27, Milamber a ecrit : Le 15/01/2012 12:58, Rainer Jung a ecrit : Hello everyone, at the beginning of December 2011 we discussed, whether we should have a release soon. I think the overall opinion was yes but it seems the project is still busy with fixing things and adding enhancements. Nevertheless I have the impression there are now enough changes to warrant the next release and get all the nice new stuff out in users hands. I don't know whether it should be a 2.5.2 or 2.6 though. +1 to release a new version 2.6 Milamber Kudos to all the effort you put into JMeter! Regards, Rainer
Properties files in mavenised artifacts
I've been hunting through the mavenised artifacts available at: https://repository.apache.org/content/repositories/snapshots/org/apache/jmet er/ However I cannot find the following in any package: saveservice.properties upgrade.properties system.properties jmeter.properties user.properties If I'm being blind please point me in the right direction, if I'm not being blind can we get these added to an artefact, or another artefact added that contains these. -- Mark Collin Managing Director Ardesco Solutions Ltd mailto:m...@ardescosolutions.com m...@ardescosolutions.com Registered Office: The Coachhouse Greys Green Business Centre Henley-on-Thames Oxon RG9 4QG REGISTERED IN ENGLAND NO. 4837759 -- This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. If you have received this email in error please notify postmas...@ardescosolutions.com
