SSL Manager description and feature

2015-02-28 Thread Philippe Mouawad
Hello,
Reading documentation of SSL Manager in component reference:

   -
   http://jmeter.apache.org/usermanual/component_reference.html#SSL_Manager


 I have few suggestions.

1/ Should this really be in component reference as it's more a menu item
2/ AFAIU it only works in GUI mode and only sets javax.net.ssl.keyStore.
3/ It is said that it can be used to simulate client certificate while in
fact :
- It is very limited (1 certificate)
- It works only in GUI
- It is superseeded by Keystore Config which really allows simulating
client side certificate for multiple clients and works in GUI and NON GUI
mode.

So I suggest we remove the menu item and remove it from documentation.

Regards
Philippe


Re: Module controller UI : automatic name replace

2015-02-28 Thread Philippe Mouawad
Hi,
Thanks for your contribution.
My answer below.

On Tue, Feb 24, 2015 at 8:26 PM, Maciej Franek maciej.fra...@gmail.com
wrote:

 Hello everyone,

 Can you share your opinion about issue:
 https://bz.apache.org/bugzilla/show_bug.cgi?id=57561

 Currently, combobox is replaced by a tree and it is in the trunk.

 Remaining point is an additional modification - automatically changing name
 of Module Controller to selected element`s name (after selection in module
 to run tree).

 Do you find it useful? Do you think it is good idea? Personally, I have
 positive experience with that, it increased readability of test plan (less
 elements in test plan that have default name - 'Module Controller'), less
 copy paste work (I usually used name of referenced element in a Module
 Controller`s name).
 Disadvantage of this modification is that some users may find it annoying
 that name is automatically changed when they don`t want to.

 Do you have any considerations how to implement it, currently there are
 some options taken into account:
 - automatic name change configured as global property
 - checkbox that would be component property in GUI
 - concatenation of two previous - checkbox that would be component property
 in GUI with global property defining if it is enabled or disabled by
 default

Would be the best I think.
Maybe add a field for prefix automatic naming ?


 Many thanks,
 Maciej Franek

Regards
Philippe


JMeter 2.12 Transitive Dependency Issues

2015-02-28 Thread Mark Collin
Just a quick heads up about this bug

https://bz.apache.org/bugzilla/show_bug.cgi?id=57649

It would be good to have a test that checks to see if there are any transitive 
dependency issues in maven after the POMs are built.

Re: Some Javadoc warning to fix before next release?

2015-02-28 Thread Felix Schumacher

Am 28.02.2015 um 21:18 schrieb Milamber:

Hello,

When I launch the distribution task to test the next release, I've these
Javadoc warning messages:

   [javadoc]
/home/milamber/temp/jmetertemp/src/core/org/apache/jmeter/save/SaveService.java:515:
warning - @param argument file is not a parameter name.
   [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/http/org/apache/jmeter/protocol/http/sampler/MeasuringConnectionManager.java:47:
warning - Tag @link: reference not found: MeasuringConnectionRequest
   [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_NONE (referenced by @value tag) is an
unknown reference.
   [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_READ_COMMITTED (referenced by @value
tag) is an unknown reference.
   [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_READ_UNCOMMITTED (referenced by @value
tag) is an unknown reference.
   [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_REPEATABLE_READ (referenced by @value
tag) is an unknown reference.
   [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_SERIALIZABLE (referenced by @value tag)
is an unknown reference.
   [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/http/org/apache/jmeter/protocol/http/sampler/MeasuringConnectionManager.java:47:
warning - Tag @link: reference not found: MeasuringConnectionRequest
   [javadoc] Building index for all the packages and classes...
   [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/http/org/apache/jmeter/protocol/http/sampler/MeasuringConnectionManager.java:47:
warning - Tag @link: reference not found: MeasuringConnectionRequest
   [javadoc] Building index for all classes...
   [javadoc] Generating
/home/milamber/temp/jmetertemp/docs/api/stylesheet.css...
   [javadoc] 9 warnings

I must ignore these messages or try to fix them?
You can ignore them now. I fixed them. Part of them came into the 
codebase, when I fixed the javadoc for java8... strange.


Regards
 Felix


Milamber




Re: Some Javadoc warning to fix before next release?

2015-02-28 Thread Milamber

Great
Thanks Felix.


On 28/02/2015 20:56, Felix Schumacher wrote:
 Am 28.02.2015 um 21:18 schrieb Milamber:
 Hello,

 When I launch the distribution task to test the next release, I've these
 Javadoc warning messages:

[javadoc]
 /home/milamber/temp/jmetertemp/src/core/org/apache/jmeter/save/SaveService.java:515:

 warning - @param argument file is not a parameter name.
[javadoc]
 /home/milamber/temp/jmetertemp/src/protocol/http/org/apache/jmeter/protocol/http/sampler/MeasuringConnectionManager.java:47:

 warning - Tag @link: reference not found: MeasuringConnectionRequest
[javadoc]
 /home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:

 warning - Connection#TRANSACTION_NONE (referenced by @value tag) is an
 unknown reference.
[javadoc]
 /home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:

 warning - Connection#TRANSACTION_READ_COMMITTED (referenced by @value
 tag) is an unknown reference.
[javadoc]
 /home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:

 warning - Connection#TRANSACTION_READ_UNCOMMITTED (referenced by @value
 tag) is an unknown reference.
[javadoc]
 /home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:

 warning - Connection#TRANSACTION_REPEATABLE_READ (referenced by @value
 tag) is an unknown reference.
[javadoc]
 /home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:

 warning - Connection#TRANSACTION_SERIALIZABLE (referenced by @value tag)
 is an unknown reference.
[javadoc]
 /home/milamber/temp/jmetertemp/src/protocol/http/org/apache/jmeter/protocol/http/sampler/MeasuringConnectionManager.java:47:

 warning - Tag @link: reference not found: MeasuringConnectionRequest
[javadoc] Building index for all the packages and classes...
[javadoc]
 /home/milamber/temp/jmetertemp/src/protocol/http/org/apache/jmeter/protocol/http/sampler/MeasuringConnectionManager.java:47:

 warning - Tag @link: reference not found: MeasuringConnectionRequest
[javadoc] Building index for all classes...
[javadoc] Generating
 /home/milamber/temp/jmetertemp/docs/api/stylesheet.css...
[javadoc] 9 warnings

 I must ignore these messages or try to fix them?
 You can ignore them now. I fixed them. Part of them came into the
 codebase, when I fixed the javadoc for java8... strange.

 Regards
  Felix

 Milamber





Some Javadoc warning to fix before next release?

2015-02-28 Thread Milamber
Hello,

When I launch the distribution task to test the next release, I've these
Javadoc warning messages:

  [javadoc]
/home/milamber/temp/jmetertemp/src/core/org/apache/jmeter/save/SaveService.java:515:
warning - @param argument file is not a parameter name.
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/http/org/apache/jmeter/protocol/http/sampler/MeasuringConnectionManager.java:47:
warning - Tag @link: reference not found: MeasuringConnectionRequest
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_NONE (referenced by @value tag) is an
unknown reference.
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_READ_COMMITTED (referenced by @value
tag) is an unknown reference.
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_READ_UNCOMMITTED (referenced by @value
tag) is an unknown reference.
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_REPEATABLE_READ (referenced by @value
tag) is an unknown reference.
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_SERIALIZABLE (referenced by @value tag)
is an unknown reference.
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/http/org/apache/jmeter/protocol/http/sampler/MeasuringConnectionManager.java:47:
warning - Tag @link: reference not found: MeasuringConnectionRequest
  [javadoc] Building index for all the packages and classes...
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/http/org/apache/jmeter/protocol/http/sampler/MeasuringConnectionManager.java:47:
warning - Tag @link: reference not found: MeasuringConnectionRequest
  [javadoc] Building index for all classes...
  [javadoc] Generating
/home/milamber/temp/jmetertemp/docs/api/stylesheet.css...
  [javadoc] 9 warnings

I must ignore these messages or try to fix them?

Milamber


Re: JMeter 2.12 Transitive Dependency Issues

2015-02-28 Thread Rainer Jung

Am 28.02.2015 um 16:08 schrieb Mark Collin:

Just a quick heads up about this bug

https://bz.apache.org/bugzilla/show_bug.cgi?id=57649


This should be a dublicate of BZ 57555 fixed in r1659390.


It would be good to have a test that checks to see if there are any transitive 
dependency issues in maven after the POMs are built.


True. Any implementation suggestion for that?

Regards,

Rainer



propsFile = File.createTempFile(jmeter-plugins, .properties);

2015-02-28 Thread Milamber
Hello,

jmeter-plugins will merge with JMeter? :)

in /Jmeter/test/src/org/apache/jmeter/engine/DistributedRunnerTest.java
line 41.

Milamber


Error or Warning message Index: 0, Size: 0 on the ant task test

2015-02-28 Thread Milamber
Hello,

When I run the ant task distribution, I've this message on the test task:

 [java] Created: 92 tests including 8 suites
 [java] Starting test run, test count = 2529
 [java] .
 [java] .
 [java] .
 [java] ...Index: 0, Size: 0
 [java] Index: 0, Size: 0
 [java] Index: 0, Size: 0
 [java] Index: 0, Size: 0
 [java] .Index: 0, Size: 0
 [java] Index: 0, Size: 0
 [java] .Index: 0, Size: 0
 [java] Index: 0, Size: 0
 [java] 
 [java] .
 [java] .


The index: 0, Size: 0 strings seems be not necessary (or obvious)... ?

In the jmeter-test.log file, I've found theses messages:

2015/02/28 20:01:13 INFO  - jmeter.engine.DistributedRunner: Configuring
remote engine: test1
2015/02/28 20:01:13 ERROR - jmeter.engine.DistributedRunner: Failed to
create engine at test1 java.lang.IndexOutOfBoundsException: Index: 0,
Size: 0
at java.util.LinkedList.entry(LinkedList.java:365)
at java.util.LinkedList.remove(LinkedList.java:357)
at
org.apache.jmeter.engine.DistributedRunnerTest$DistributedRunnerEmul.createEngine(DistributedRunnerTest.java:120)
at
org.apache.jmeter.engine.DistributedRunner.getClientEngine(DistributedRunner.java:213)
at
org.apache.jmeter.engine.DistributedRunner.init(DistributedRunner.java:91)
at
org.apache.jmeter.engine.DistributedRunnerTest.testFailure3(DistributedRunnerTest.java:105)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at junit.framework.TestCase.runTest(TestCase.java:176)
at junit.framework.TestCase.runBare(TestCase.java:141)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at junit.framework.TestSuite.runTest(TestSuite.java:252)
at junit.framework.TestSuite.run(TestSuite.java:247)
at junit.framework.TestSuite.runTest(TestSuite.java:252)
at junit.framework.TestSuite.run(TestSuite.java:247)
at junit.textui.TestRunner.doRun(TestRunner.java:116)
at junit.textui.TestRunner.doRun(TestRunner.java:109)
at junit.textui.TestRunner.run(TestRunner.java:77)
at org.apache.jorphan.test.AllTests.main(AllTests.java:236)

2015/02/28 20:01:13 INFO  - jmeter.engine.DistributedRunner: Failed to
configure test1
2015/02/28 20:01:13 INFO  - jmeter.engine.DistributedRunner: Configuring
remote engine: test2
2015/02/28 20:01:13 ERROR - jmeter.engine.DistributedRunner: Failed to
create engine at test2 java.lang.IndexOutOfBoundsException: Index: 0,
Size: 0
at java.util.LinkedList.entry(LinkedList.java:365)
at java.util.LinkedList.remove(LinkedList.java:357)
at
org.apache.jmeter.engine.DistributedRunnerTest$DistributedRunnerEmul.createEngine(DistributedRunnerTest.java:120)
at
org.apache.jmeter.engine.DistributedRunner.getClientEngine(DistributedRunner.java:213)
at
org.apache.jmeter.engine.DistributedRunner.init(DistributedRunner.java:91)
at
org.apache.jmeter.engine.DistributedRunnerTest.testFailure3(DistributedRunnerTest.java:105)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at junit.framework.TestCase.runTest(TestCase.java:176)
at junit.framework.TestCase.runBare(TestCase.java:141)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:129)
at junit.framework.TestSuite.runTest(TestSuite.java:252)
at junit.framework.TestSuite.run(TestSuite.java:247)
at junit.framework.TestSuite.runTest(TestSuite.java:252)
at junit.framework.TestSuite.run(TestSuite.java:247)
at junit.textui.TestRunner.doRun(TestRunner.java:116)
at junit.textui.TestRunner.doRun(TestRunner.java:109)
at junit.textui.TestRunner.run(TestRunner.java:77)
at org.apache.jorphan.test.AllTests.main(AllTests.java:236)

2015/02/28 20:01:13 INFO  - jmeter.engine.DistributedRunner: Failed to
configure test2
2015/02/28 20:01:13 INFO  - jmeter.engine.DistributedRunner: Stopping
remote engines
2015/02/28 20:01:13 INFO  - jmeter.engine.DistributedRunner: Remote
engines have been 

Re: propsFile = File.createTempFile(jmeter-plugins, .properties);

2015-02-28 Thread Andrey Pokhilko
Hey,

What made you think of it like this? :)

Did I do any mistake with class name or what?

Andrey Pokhilko

On 02/28/2015 11:13 PM, Milamber wrote:
 Hello,

 jmeter-plugins will merge with JMeter? :)

 in /Jmeter/test/src/org/apache/jmeter/engine/DistributedRunnerTest.java
 line 41.

 Milamber



Re: propsFile = File.createTempFile(jmeter-plugins, .properties);

2015-02-28 Thread Milamber

On 01/03/2015 06:07, Andrey Pokhilko wrote:
 Hey,

 What made you think of it like this? :)

Just the string jmeter-plugins in the class.


 Did I do any mistake with class name or what?

anything. all is good



 Andrey Pokhilko

 On 02/28/2015 11:13 PM, Milamber wrote:
 Hello,

 jmeter-plugins will merge with JMeter? :)

 in /Jmeter/test/src/org/apache/jmeter/engine/DistributedRunnerTest.java
 line 41.

 Milamber




Re: propsFile = File.createTempFile(jmeter-plugins, .properties);

2015-02-28 Thread Andrey Pokhilko
Ah, now I see.

Yes, I had to copy fixture helper from plugins, because I haven't found
existing way to do it in jmeter codebase.

I have removed the word.

Andrey Pokhilko

On 03/01/2015 10:12 AM, Milamber wrote:
 On 01/03/2015 06:07, Andrey Pokhilko wrote:
 Hey,

 What made you think of it like this? :)
 Just the string jmeter-plugins in the class.

 Did I do any mistake with class name or what?
 anything. all is good


 Andrey Pokhilko

 On 02/28/2015 11:13 PM, Milamber wrote:
 Hello,

 jmeter-plugins will merge with JMeter? :)

 in /Jmeter/test/src/org/apache/jmeter/engine/DistributedRunnerTest.java
 line 41.

 Milamber