[GitHub] jmeter pull request: Removing duplicate code.

[ham1]

GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/126

Removing duplicate code.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter remove_duplicate_code

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #126


commit 60f88f9ecac442c6189d2dcec8487e181e60ebf1
Author: Graham Russell 
Date:   2016-02-14T00:44:26Z

Removing duplicate code.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: svn commit: r1730604 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/sampler/ src/protocol/http/org/apache/jmeter/protocol/http/util/ xdocs/ xdocs/usermanual/

[Felix Schumacher]

Am 15.02.2016 um 23:00 schrieb sebb:

On 15 February 2016 at 20:58, Philippe Mouawad
 wrote:

there might be 1 side effect that we need to think about.

Take 1 plan using an additional method.
Plan is opened in a new instance not having this configuration.
What to put in select box ?
That might not be easy to diagnose.
It's the same issue as for java sampler when class is not in jar.

Maybe it would be better to have an editable selech box.

+1

But I think we should preset the known values.

Might also be useful to allow new methods to be added via a property.
This would make it easier when new ones are added, and hopefully would
not be a problem with porting to other versions, so long as they have
the editable select box.
I have attached a simple version of it. With the patch one can choose 
any method and it will be treated as a valid webdav method.


I haven't added the property, but that should be easy.
I think the webdav class can be removed, if it's used the way the patch 
makes it to be used.


Should I open a new bug, or use the one for the search entry?

Regards,
 Felix




Regards

On Monday, February 15, 2016, Philippe Mouawad 
wrote:


ok for me

On Monday, February 15, 2016, Felix Schumacher <
felix.schumac...@internetallee.de
>
wrote:


Am 15.02.2016 um 21:40 schrieb Philippe Mouawad:


On Monday, February 15, 2016, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

Am 15.02.2016 um 21:30 schrieb Philippe Mouawad:

Wouldn't a standard property (comma separated values) be better ?

Yes. That would be even better.

Merge them into the ones we already have, or replace them?


no firm opinion.
Merge might be safer ?


Merge is probably safer. So use the ones we have already as the base
stock?


Are you restricting it to webdav or to all methods ?


I think it should be free. Who knows what methods creep up in the future?


If all maybe we need to have a way to express if it can have a body or
not
?


If it is needed, we could add another comma separated list, that lists
those. But I think we can start without.

Felix




On Monday, February 15, 2016, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

Am 15.02.2016 um 21:19 schrieb Philippe Mouawad:


Hi Felix,


There are other webdav methods that we don't support, should we add
them
all ?

I thought about putting the list of supported methods into a file, so


anyone could edit it, if a new method is needed.

What do you think about that?



Felix


Regards


On Monday, February 15, 2016,  wrote:

Author: fschumacher

Date: Mon Feb 15 20:08:25 2016

New Revision: 1730604

URL: http://svn.apache.org/viewvc?rev=1730604=rev
Log:
HTTP Sampler : Added WebDAV verb (SEARCH).

Bugzilla Id: 59005

Modified:




jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java




jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/HTTPConstantsInterface.java
jmeter/trunk/xdocs/changes.xml
jmeter/trunk/xdocs/usermanual/component_reference.xml

Modified:



jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
URL:



http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1730604=1730603=1730604=diff




==
---



jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
(original)
+++



jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
Mon Feb 15 20:08:25 2016
@@ -96,7 +96,7 @@ import org.apache.oro.text.regex.Perl5Ma
 public abstract class HTTPSamplerBase extends AbstractSampler
 implements TestStateListener, TestIterationListener,
ThreadListener,
HTTPConstantsInterface {

-private static final long serialVersionUID = 240L;
+private static final long serialVersionUID = 241L;

 private static final Logger log =
LoggingManager.getLoggerForClass();

@@ -241,7 +241,8 @@ public abstract class HTTPSamplerBase ex
 HTTPConstants.LOCK,
 HTTPConstants.UNLOCK,
 HTTPConstants.REPORT,
-HTTPConstants.MKCALENDAR
+HTTPConstants.MKCALENDAR,
+HTTPConstants.SEARCH
 };

 private static final List METHODLIST =
Collections.unmodifiableList(Arrays.asList(METHODS));

Modified:



jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/HTTPConstantsInterface.java
URL:



http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/HTTPConstantsInterface.java?rev=1730604=1730603=1730604=diff




==
---