Re: svn commit: r1730971 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java

[sebb]

So that was the reason for the "no change" comment. Well spotted.

On 17 February 2016 at 23:05,   wrote:
> Author: pmouawad
> Date: Wed Feb 17 23:05:21 2016
> New Revision: 1730971
>
> URL: http://svn.apache.org/viewvc?rev=1730971&view=rev
> Log:
> Bug 59023 - HttpSampler UI : rework the embedded resources labels and change 
> default number of parallel downloads to 6
> Fix effectively the issue (thanks sebb for the note)
> Bugzilla Id: 59023
>
> Modified:
> 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>
> Modified: 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1730971&r1=1730970&r2=1730971&view=diff
> ==
> --- 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>  (original)
> +++ 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>  Wed Feb 17 23:05:21 2016
> @@ -180,7 +180,9 @@ public abstract class HTTPSamplerBase ex
>
>  public static final String CONCURRENT_POOL = 
> "HTTPSampler.concurrentPool"; // $NON-NLS-1$
>
> -private static final String CONCURRENT_POOL_DEFAULT = "6"; // default 
> for concurrent pool (do not change)
> +public static final int CONCURRENT_POOL_SIZE = 6; // Default concurrent 
> pool size for download embedded resources
> +
> +private static final String CONCURRENT_POOL_DEFAULT = 
> Integer.toString(CONCURRENT_POOL_SIZE); // default for concurrent pool
>
>  private static final String USER_AGENT = "User-Agent"; // $NON-NLS-1$
>
> @@ -196,8 +198,6 @@ public abstract class HTTPSamplerBase ex
>  private static final boolean IGNORE_FAILED_EMBEDDED_RESOURCES =
>  
> JMeterUtils.getPropDefault("httpsampler.ignore_failed_embedded_resources", 
> false); // $NON-NLS-1$ // default value: false
>
> -public static final int CONCURRENT_POOL_SIZE = 4; // Default concurrent 
> pool size for download embedded resources
> -
>  private static final boolean IGNORE_EMBEDDED_RESOURCES_DATA =
>  
> JMeterUtils.getPropDefault("httpsampler.embedded_resources_use_md5", false); 
> // $NON-NLS-1$ // default value: false
>
>
>

buildbot success in on jmeter-trunk

[buildbot]

The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/623

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1730971
Blamelist: pmouawad

Build succeeded!

Sincerely,
 -The Buildbot

Re: svn commit: r1730969 - in /jmeter/trunk: bin/jmeter.properties src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java xdocs/changes.xml

[sebb]

Thanks

On 17 February 2016 at 23:00,   wrote:
> Author: pmouawad
> Date: Wed Feb 17 23:00:34 2016
> New Revision: 1730969
>
> URL: http://svn.apache.org/viewvc?rev=1730969&view=rev
> Log:
> Bug 57577 - HttpSampler : Retrieve All Embedded Resources should only compute 
> size or hash by default
> Take into account sebb notes
> Bugzilla Id: 57577
>
> Modified:
> jmeter/trunk/bin/jmeter.properties
> 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> jmeter/trunk/xdocs/changes.xml
>
> Modified: jmeter/trunk/bin/jmeter.properties
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1730969&r1=1730968&r2=1730969&view=diff
> ==
> --- jmeter/trunk/bin/jmeter.properties (original)
> +++ jmeter/trunk/bin/jmeter.properties Wed Feb 17 23:00:34 2016
> @@ -996,9 +996,9 @@ beanshell.server.file=../extras/startup.
>  # Parent sample will not be marked as failed
>  #httpsampler.ignore_failed_embedded_resources=false
>
> -# ignore the embedded resources response data : just keep the size and the 
> md5
> +# Don't keep the embedded resources response data : just keep the size and 
> the md5
>  # default to false
> -#httpsampler.ignore_embedded_resources_data=true
> +#httpsampler.embedded_resources_use_md5=false
>
>  # The encoding to be used if none is provided (default ISO-8859-1)
>  #sampleresult.default.encoding=ISO-8859-1
>
> Modified: 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1730969&r1=1730968&r2=1730969&view=diff
> ==
> --- 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>  (original)
> +++ 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>  Wed Feb 17 23:00:34 2016
> @@ -199,7 +199,7 @@ public abstract class HTTPSamplerBase ex
>  public static final int CONCURRENT_POOL_SIZE = 4; // Default concurrent 
> pool size for download embedded resources
>
>  private static final boolean IGNORE_EMBEDDED_RESOURCES_DATA =
> -
> JMeterUtils.getPropDefault("httpsampler.ignore_embedded_resources_data", 
> false); // $NON-NLS-1$ // default value: false
> +
> JMeterUtils.getPropDefault("httpsampler.embedded_resources_use_md5", false); 
> // $NON-NLS-1$ // default value: false
>
>  public static enum SourceType {
>  HOSTNAME("web_testing_source_ip_hostname"), //$NON-NLS-1$
>
> Modified: jmeter/trunk/xdocs/changes.xml
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1730969&r1=1730968&r2=1730969&view=diff
> ==
> --- jmeter/trunk/xdocs/changes.xml (original)
> +++ jmeter/trunk/xdocs/changes.xml Wed Feb 17 23:00:34 2016
> @@ -110,7 +110,7 @@ Summary
>  59005HTTP Sampler : Added WebDAV verb (SEARCH).
>  59006Change Default proxy recording port to  to align 
> it with Recording Template. Contributed by Antonio Gomes Rodrigues (ra0077 at 
> gmail.com)
>  58099Performance : Lazily initialize HttpClient SSL 
> Context to avoid its initialization even for HTTP only scenarios
> -57577HttpSampler : Retrieve All Embedded Resources should 
> only compute size or hash by default. Contributed by Benoit Wiart (benoit dot 
> wiart at gmail.com)
> +57577HttpSampler : Retrieve All Embedded Resources, add 
> property "httpsampler.embedded_resources_use_md5" to only compute md5 and not 
> keep response data. Contributed by Benoit Wiart (benoit dot wiart at 
> gmail.com)
>  59023HttpSampler UI : rework the embedded resources 
> labels and change default number of parallel downloads to 6. Contributed by 
> Benoit Wiart (benoit dot wiart at gmail.com)
>  
>
>
>

Jenkins build is back to normal : JMeter-trunk #4962

[Apache Jenkins Server]

See 

[GitHub] jmeter pull request: Removing unnecessary (un)boxing

[ham1]

Github user ham1 commented on the pull request:

https://github.com/apache/jmeter/pull/123#issuecomment-185449811
  
Updated as per comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

buildbot failure in on jmeter-trunk

[buildbot]

The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/622

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1730969
Blamelist: pmouawad

BUILD FAILED: failed

Sincerely,
 -The Buildbot

Re: svn commit: r1730963 - in /jmeter/trunk: src/core/org/apache/jmeter/resources/messages.properties src/core/org/apache/jmeter/resources/messages_fr.properties src/protocol/http/org/apache/jmeter/pr

[sebb]

On 17 February 2016 at 22:46,   wrote:
> Author: pmouawad
> Date: Wed Feb 17 22:46:36 2016
> New Revision: 1730963
>
> URL: http://svn.apache.org/viewvc?rev=1730963&view=rev
> Log:
> Bug 59023 - HttpSampler UI : rework the embedded resources labels and change 
> default number of parallel downloads to 6
> Bugzilla Id: 59023
>
> Modified:
> jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
> jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
> 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> jmeter/trunk/xdocs/changes.xml
>
> Modified: 
> jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties?rev=1730963&r1=1730962&r2=1730963&view=diff
> ==
> --- jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties 
> (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties Wed 
> Feb 17 22:46:36 2016
> @@ -1289,7 +1289,7 @@ web_server_timeout_connect=Connect:
>  web_server_timeout_response=Response:
>  web_server_timeout_title=Timeouts (milliseconds)
>  web_testing2_title=HTTP Request HTTPClient
> -web_testing_concurrent_download=Use concurrent pool. Size:
> +web_testing_concurrent_download=Parallel downloads. Number:
>  web_testing_embedded_url_pattern=URLs must match\:
>  web_testing_retrieve_images=Retrieve All Embedded Resources
>  web_testing_retrieve_title=Embedded Resources from HTML Files
>
> Modified: 
> jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties?rev=1730963&r1=1730962&r2=1730963&view=diff
> ==
> --- jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties 
> (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties 
> Wed Feb 17 22:46:36 2016
> @@ -1274,7 +1274,7 @@ web_server_timeout_connect=Connexion \:
>  web_server_timeout_response=R\u00E9ponse \:
>  web_server_timeout_title=D\u00E9lai expiration (ms)
>  web_testing2_title=Requ\u00EAte HTTP HTTPClient
> -web_testing_concurrent_download=Utiliser pool unit\u00E9. Nbre \:
> +web_testing_concurrent_download=T\u00E9l\u00E9chargements en parall\u00e8le. 
> Nombre \:
>  web_testing_embedded_url_pattern=Les URL \u00E0 inclure doivent correspondre 
> \u00E0 \:
>  web_testing_retrieve_images=R\u00E9cup\u00E9rer les ressources incluses
>  web_testing_retrieve_title=Ressources incluses dans les pages HTML
>
> Modified: 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1730963&r1=1730962&r2=1730963&view=diff
> ==
> --- 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>  (original)
> +++ 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>  Wed Feb 17 22:46:36 2016
> @@ -180,7 +180,7 @@ public abstract class HTTPSamplerBase ex
>
>  public static final String CONCURRENT_POOL = 
> "HTTPSampler.concurrentPool"; // $NON-NLS-1$
>
> -private static final String CONCURRENT_POOL_DEFAULT = "4"; // default 
> for concurrent pool (do not change)
> +private static final String CONCURRENT_POOL_DEFAULT = "6"; // default 
> for concurrent pool (do not change)

There was obviously a reason for the "do not change" comment.
Why is it now OK to change the value?

>
>  private static final String USER_AGENT = "User-Agent"; // $NON-NLS-1$
>
>
> Modified: jmeter/trunk/xdocs/changes.xml
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1730963&r1=1730962&r2=1730963&view=diff
> ==
> --- jmeter/trunk/xdocs/changes.xml (original)
> +++ jmeter/trunk/xdocs/changes.xml Wed Feb 17 22:46:36 2016
> @@ -111,6 +111,7 @@ Summary
>  59006Change Default proxy recording port to  to align 
> it with Recording Template. Contributed by Antonio Gomes Rodrigues (ra0077 at 
> gmail.com)
>  58099Performance : Lazily initialize HttpClient SSL 
> Context to avoid its initialization even for HTTP only scenarios
>  57577HttpSampler : Retrieve All Embedded Resources should 
> only compute size or hash by default. Contributed by Benoit Wiart (benoit dot 
> wiart at gmail.com)
> +59023HttpSampler UI : rework the embedded resources 
> labels and change default number of parallel downloads to 6. Contributed by 
> Benoit Wiart (benoit dot wiart at

Re: svn commit: r1730962 - in /jmeter/trunk: bin/jmeter.properties src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java xdocs/changes.xml

[sebb]

On 17 February 2016 at 22:41,   wrote:
> Author: pmouawad
> Date: Wed Feb 17 22:41:37 2016
> New Revision: 1730962
>
> URL: http://svn.apache.org/viewvc?rev=1730962&view=rev
> Log:
> Bug 57577 - HttpSampler : Retrieve All Embedded Resources should only compute 
> size or hash by default
> #resolve #127
> Bugzilla Id: 57577
>
> Modified:
> jmeter/trunk/bin/jmeter.properties
> 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> jmeter/trunk/xdocs/changes.xml
>
> Modified: jmeter/trunk/bin/jmeter.properties
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1730962&r1=1730961&r2=1730962&view=diff
> ==
> --- jmeter/trunk/bin/jmeter.properties (original)
> +++ jmeter/trunk/bin/jmeter.properties Wed Feb 17 22:41:37 2016
> @@ -996,6 +996,10 @@ beanshell.server.file=../extras/startup.
>  # Parent sample will not be marked as failed
>  #httpsampler.ignore_failed_embedded_resources=false
>
> +# ignore the embedded resources response data : just keep the size and the 
> md5
> +# default to false
> +#httpsampler.ignore_embedded_resources_data=true

The comments should correspond with the default value.

I don't like the name "ignore_embedded_resources_data".
It's misleading to use "ignore" because the data is not ignored.

It should be something more like:

embedded_resources_use_md5

> +
>  # The encoding to be used if none is provided (default ISO-8859-1)
>  #sampleresult.default.encoding=ISO-8859-1
>
>
> Modified: 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1730962&r1=1730961&r2=1730962&view=diff
> ==
> --- 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>  (original)
> +++ 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>  Wed Feb 17 22:41:37 2016
> @@ -198,6 +198,9 @@ public abstract class HTTPSamplerBase ex
>
>  public static final int CONCURRENT_POOL_SIZE = 4; // Default concurrent 
> pool size for download embedded resources
>
> +private static final boolean IGNORE_EMBEDDED_RESOURCES_DATA =
> +
> JMeterUtils.getPropDefault("httpsampler.ignore_embedded_resources_data", 
> false); // $NON-NLS-1$ // default value: false
> +
>  public static enum SourceType {
>  HOSTNAME("web_testing_source_ip_hostname"), //$NON-NLS-1$
>  DEVICE("web_testing_source_ip_device"), //$NON-NLS-1$
> @@ -1954,6 +1957,7 @@ public abstract class HTTPSamplerBase ex
>  CookieManager clonedCookieManager = (CookieManager) 
> cookieManager.clone();
>  this.sampler.setCookieManagerProperty(clonedCookieManager);
>  }
> +this.sampler.setMD5(this.sampler.useMD5() || 
> IGNORE_EMBEDDED_RESOURCES_DATA);
>  this.jmeterContextOfParentThread = 
> JMeterContextService.getContext();
>  }
>
> @@ -1972,7 +1976,7 @@ public abstract class HTTPSamplerBase ex
>  }
>
>  /**
> - * Custom thread implementation that
> + * Custom thread implementation that allows notification of threadEnd
>   *
>   */
>  private static class CleanerThread extends Thread {
>
> Modified: jmeter/trunk/xdocs/changes.xml
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1730962&r1=1730961&r2=1730962&view=diff
> ==
> --- jmeter/trunk/xdocs/changes.xml (original)
> +++ jmeter/trunk/xdocs/changes.xml Wed Feb 17 22:41:37 2016
> @@ -110,6 +110,7 @@ Summary
>  59005HTTP Sampler : Added WebDAV verb (SEARCH).
>  59006Change Default proxy recording port to  to align 
> it with Recording Template. Contributed by Antonio Gomes Rodrigues (ra0077 at 
> gmail.com)
>  58099Performance : Lazily initialize HttpClient SSL 
> Context to avoid its initialization even for HTTP only scenarios
> +57577HttpSampler : Retrieve All Embedded Resources should 
> only compute size or hash by default. Contributed by Benoit Wiart (benoit dot 
> wiart at gmail.com)

This implies the default has changed - it has not.

>  
>
>  Other samplers
>
>

buildbot success in on jmeter-trunk

[buildbot]

The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/621

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1730963
Blamelist: pmouawad

Build succeeded!

Sincerely,
 -The Buildbot

buildbot failure in on jmeter-trunk

[buildbot]

The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/620

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1730962
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

[GitHub] jmeter pull request: Bug 57577 HttpSampler : Retrieve All Embedded...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/127


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Bug 57577 HttpSampler : Retrieve All Embedded...

[benbenw]

GitHub user benbenw opened a pull request:

https://github.com/apache/jmeter/pull/127

Bug 57577 HttpSampler : Retrieve All Embedded Resources should only compute 
size or hash

can be activated with a new parameter
httpsampler.ignore_embedded_resources_data (default to false)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/benbenw/jmeter 57577

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #127


commit 3d5e84780c7fb00319b4f74673db0dc6297c0584
Author: benoit 
Date:   2016-02-17T22:12:39Z

Bug 57577 HttpSampler : Retrieve All Embedded Resources should only
compute size or hash
can be activated with a new parameter
httpsampler.ignore_embedded_resources_data (default to false)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: JMeter-trunk #4961

[Apache Jenkins Server]

See 

Changes:

[pmouawad] Bug 58099 - Performance : Lazily initialize HttpClient SSL Context 
to avoid its initialization even for HTTP only scenarios
Bugzilla Id: 58099

--
[...truncated 934 lines...]

compile-monitor-model:
[javac] Compiling 21 source files to 


compile-monitor-components:
[javac] Compiling 13 source files to 


compile-monitor:

compile-junit:
[javac] Compiling 14 source files to 


compile-jms:
[javac] Compiling 20 source files to 


compile-native:
[javac] Compiling 3 source files to 


compile-mongodb:
[javac] Compiling 9 source files to 


compile:

prepare-resources:
 [copy] Copying 2 files to 


package-only:
  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 

  [jar] Building jar: 


package:

check-anakia:

report-old-velocity:

report-anakia-missing:

init-docs:
 [echo] eclipse.anakia = .

docs-printable:
   [anakia] Transforming into: 

   [anakia] Input:  building.xml
   [anakia] Output: 

   [anakia] Input:  changes.xml
   [anakia] Output: 

   [anakia] Input:  changes_history.xml
   [anakia] Output: 

   [anakia] Input:  devguide-dashboard.xml
   [anakia] Output: 

   [anakia] Input:  download_jmeter.xml
   [anakia] Output: 

   [anakia] Input:  index.xml
   [anakia] Output: 

   [anakia] Input:  issues.xml
   [anakia] Output: 

   [anakia] Input:  jmeter_irc.xml
   [anakia] Output: 

   [anakia] Input:  localising/index.xml
   [anakia] Output: 

   [anakia] Input:  mail.xml
   [anakia] Output: 

Re: SNI issue with HTTPClient 4 https://bz.apache.org/bugzilla/show_bug.cgi?id=57935

[Philippe Mouawad]

Hi sebb,
I had feedback from one user facing the SNI issue and he confirmed issue is
now fixed in nightly:
- http://stackoverflow.com/questions/35430575/jmeter-aws-https-sni-issue

As it was agreed on in a previous mailing list discussion, HC3.1 is to be
deprecated in 3.0 and removed in 3.1, so I think we have some time to fix
it.
Note there is also this one to be iso with HC3.1:
- https://bz.apache.org/bugzilla/show_bug.cgi?id=57242

HC3 is deprecated for  so many years now, I think removing it will
encourage us to fix or report to HttpClient all remaining issues.
We have I think fixed some remaining issues in next 3.0 and there is always
the option to switch to java implementation.

Regards

On Wed, Feb 17, 2016 at 9:57 PM, sebb  wrote:

> On 17 February 2016 at 12:50, Philippe Mouawad
>  wrote:
> > Hello,
> > I think I have fixed the SNI issue with HTTPClient 4. Note it was strange
> > that is worked with 3.1 and not 4.X.
> > It would be great if you could test it and review fix.
> >
> > For me, this is a temporary fix until we upgrade the SSL Socket factory
> in
> > JMeter to use up to date classes from HttpClient 4.5.X
> >
> > This socket factory has at least 3 aims in my understanding:
> > - Slow socket simulation
> > - SSL Context reuse or not
> > - Client SSL certificate management
> >
> >
> > I think in 3.1 version we should at least drop all code related to 3.X
> and
>
> Note that there was a recent email which suggested that HC3.1 worked
> better than HC4.x for the recording function:
>
>
> http://mail-archives.apache.org/mod_mbox/jmeter-user/201602.mbox/%3CCAOpZ4bk_U-0dx3JODwqbo3tiWgCWJwdx%2BWuH1v5NVHfOouvRxw%40mail.gmail.com%3E
>
> We should try and understand/fix that before dropping 3.1.
>
> > rework completely these part of the code as it is not easy to
> > read/understand.
> >
> > --
> > Regards.
> > Philippe
>



-- 
Cordialement.
Philippe Mouawad.

Re: SNI issue with HTTPClient 4 https://bz.apache.org/bugzilla/show_bug.cgi?id=57935

[sebb]

On 17 February 2016 at 12:50, Philippe Mouawad
 wrote:
> Hello,
> I think I have fixed the SNI issue with HTTPClient 4. Note it was strange
> that is worked with 3.1 and not 4.X.
> It would be great if you could test it and review fix.
>
> For me, this is a temporary fix until we upgrade the SSL Socket factory in
> JMeter to use up to date classes from HttpClient 4.5.X
>
> This socket factory has at least 3 aims in my understanding:
> - Slow socket simulation
> - SSL Context reuse or not
> - Client SSL certificate management
>
>
> I think in 3.1 version we should at least drop all code related to 3.X and

Note that there was a recent email which suggested that HC3.1 worked
better than HC4.x for the recording function:

http://mail-archives.apache.org/mod_mbox/jmeter-user/201602.mbox/%3CCAOpZ4bk_U-0dx3JODwqbo3tiWgCWJwdx%2BWuH1v5NVHfOouvRxw%40mail.gmail.com%3E

We should try and understand/fix that before dropping 3.1.

> rework completely these part of the code as it is not easy to
> read/understand.
>
> --
> Regards.
> Philippe

Re: [GitHub] jmeter pull request: Removing unnecessary (un)boxing

[sebb]

On 17 February 2016 at 17:53, Graham Russell  wrote:
> Hi Sebb
>
> Thanks for having a look through the PR. I appreciate all the work you
> do with JMeter!
>
> I do not fully understand your argument. Do you have an example of
> issues to help me understand where explicit (un)boxing would help
> prevent a problem?

I already mentioned several reasons.

> My main reason for the PR was to reduce the amount of code to improve
> readability. In my opinion most explicit (un)boxing is just noise -
> happy to be persuaded otherwise.
>
> For example:
> What potential problems does the booleanValue() here avoid? I
> understand the need for the null check as you are right auto unboxing
> could hide a NPE.
>
> if (success != null) {
> if (success.booleanValue()) { ...
>
> vs.:
>
> if (success != null) {
> if (success) { ...

That looks very odd to me.

> If the reasoning was to make it even more obvious that it was an
> object and needed the null check, then, just as one example, this
> hasn't worked in the HtmlTemplateExporter class, the method
> EmptyGraphChecker.checkResult has
> supportsControllerDiscrimination.booleanValue() but no null check even
> though the method which created it could return null.

In which case the null check needs to be added.

> As another example, in a method which returns a long, I do not
> understand why the .longValue() is helpful, e.g.:
>
> public long getTimestamp() {
> return getData(long.class, CSVSaveService.TIME_STAMP).longValue();
> }

The point is that the boxing/unboxing warnings are useful for the
reasons I quoted originally.

If you suppress all the warnings, you don't get to find out about the problems.
Once you have decided that the correct datatype has been used, then
you can fix the warning by using explicit (un)boxing, thereby also
documenting that the use of the object is deliberate.

> Or why:
> Double.valueOf(((double) data.longValue() * 100 / errorCount))
>
> is preferred over:
>
> ((double) data * 100 / errorCount)
>
> I acknowledge you need to be mindful of NPE and auto (un)boxing in
> loops etc. 
> (http://brian.pontarelli.com/2004/07/15/jdk-5-auto-boxing-best-practices/)
> but I currently do not see how being explicit about (ub)boxing helps?

Because the warnings help with exposing design issues and coding
errors, as per my original mail.

> I would very much appreciate any time you (or anyone else on the list)
> could spare to improve my understanding of this issue, via email or
> perhaps comment in github on specific changes and I would be happy to
> update the PR.
>
> Many thanks
>
> Graham
>
> On Mon, 15 Feb 2016 at 09:32 sebb  wrote:
>>
>> -1
>>
>> Auto boxing is generally a bad idea as it can hide poor design (wrong
>> choice of long/Long).
>>
>> It can also hide wrong choice of method (Long.parseLong/Long.decode)
>>
>> Implicit unboxing can hide potential NPE.
>>
>> About the only place where autoboxing is useful is in String.format,
>> but that should not be used as an excuse to allow it elsewhere.
>>

Re: svn commit: r1730604 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/sampler/ src/protocol/http/org/apache/jmeter/protocol/http/util/ xdocs/ xdocs/usermanual/

[Philippe Mouawad]

Hi Felix,
I think opening a bug as enhancement is better .

Search and possible other webdav methods addition should still be in this
bug.
We could maybe add all those that are missing:
https://msdn.microsoft.com/en-us/library/aa142917%28v=exchg.65%29.aspx

Regards

On Tue, Feb 16, 2016 at 10:09 PM, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

> Am 15.02.2016 um 23:00 schrieb sebb:
>
>> On 15 February 2016 at 20:58, Philippe Mouawad
>>  wrote:
>>
>>> there might be 1 side effect that we need to think about.
>>>
>>> Take 1 plan using an additional method.
>>> Plan is opened in a new instance not having this configuration.
>>> What to put in select box ?
>>> That might not be easy to diagnose.
>>> It's the same issue as for java sampler when class is not in jar.
>>>
>>> Maybe it would be better to have an editable selech box.
>>>
>> +1
>>
>> But I think we should preset the known values.
>>
>> Might also be useful to allow new methods to be added via a property.
>> This would make it easier when new ones are added, and hopefully would
>> not be a problem with porting to other versions, so long as they have
>> the editable select box.
>>
> I have attached a simple version of it. With the patch one can choose any
> method and it will be treated as a valid webdav method.
>
> I haven't added the property, but that should be easy.
> I think the webdav class can be removed, if it's used the way the patch
> makes it to be used.
>
> Should I open a new bug, or use the one for the search entry?
>
> Regards,
>
>  Felix
>
>
>> Regards
>>>
>>> On Monday, February 15, 2016, Philippe Mouawad <
>>> philippe.moua...@gmail.com>
>>> wrote:
>>>
>>> ok for me

 On Monday, February 15, 2016, Felix Schumacher <
 felix.schumac...@internetallee.de
 >
 wrote:

 Am 15.02.2016 um 21:40 schrieb Philippe Mouawad:
>
> On Monday, February 15, 2016, Felix Schumacher <
>> felix.schumac...@internetallee.de> wrote:
>>
>> Am 15.02.2016 um 21:30 schrieb Philippe Mouawad:
>>
>>> Wouldn't a standard property (comma separated values) be better ?
>>>
 Yes. That would be even better.

>>> Merge them into the ones we already have, or replace them?
>>>
>>> no firm opinion.
>> Merge might be safer ?
>>
>> Merge is probably safer. So use the ones we have already as the base
> stock?
>
> Are you restricting it to webdav or to all methods ?
>>
>> I think it should be free. Who knows what methods creep up in the
> future?
>
> If all maybe we need to have a way to express if it can have a body or
>> not
>> ?
>>
>> If it is needed, we could add another comma separated list, that lists
> those. But I think we can start without.
>
> Felix
>
>
>> On Monday, February 15, 2016, Felix Schumacher <
 felix.schumac...@internetallee.de> wrote:

 Am 15.02.2016 um 21:19 schrieb Philippe Mouawad:

 Hi Felix,
>
> There are other webdav methods that we don't support, should we add
>> them
>> all ?
>>
>> I thought about putting the list of supported methods into a
>> file, so
>>
>> anyone could edit it, if a new method is needed.
>
> What do you think about that?
>
>
> Felix

 Regards
>
> On Monday, February 15, 2016,  wrote:
>>
>> Author: fschumacher
>>
>> Date: Mon Feb 15 20:08:25 2016
>>
>>> New Revision: 1730604
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1730604&view=rev
>>> Log:
>>> HTTP Sampler : Added WebDAV verb (SEARCH).
>>>
>>> Bugzilla Id: 59005
>>>
>>> Modified:
>>>
>>>
>>>
>>>
>>>
>>> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>>>
>>>
>>>
>>>
>>>
>>> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/HTTPConstantsInterface.java
>>> jmeter/trunk/xdocs/changes.xml
>>> jmeter/trunk/xdocs/usermanual/component_reference.xml
>>>
>>> Modified:
>>>
>>>
>>>
>>>
>>> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>>> URL:
>>>
>>>
>>>
>>>
>>> http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1730604&r1=1730603&r2=1730604&view=diff
>>>
>>>
>>>
>>>
>>>
>>> ==
>>> ---
>>>
>>>
>>>
>>>
>>> jmeter/trunk/src/protocol/http/

Re: httpClient.getConnectionManager() performance with HTTP only

[Philippe Mouawad]

Hello,
I think I have fixed the issue in JMeter, I attached patch to:
- https://bz.apache.org/bugzilla/show_bug.cgi?id=58099

Reviews and feedback very welcome.
Regards

On Tue, Jan 5, 2016 at 3:05 PM, sebb  wrote:

> On 22 December 2015 at 08:36, Oleg Kalnichevski  wrote:
> > On Sun, 2015-12-20 at 22:44 +0100, Philippe Mouawad wrote:
> >> Hi Oleg,
> >> Back to this old subject and knowing that we must stick to 1 HttpClient
> per
> >> thread (as per all the discussion that followed this).
> >> Is there a plan to implement this lazy init of SSLContext in HttpClient
> as
> >> it used to be the case in HC3 ?
> >>
> >> For our project, it's a killer in terms of performance, and for other
> use
> >> cases, it appears kind of weird that an SSLContext is initialized even
> for
> >> a pure HTTP traffic.
> >>
> >
> > Given that HttpClient instance should be initialized only once, eager
> > initialization of the SSLContext looks reasonable to me.
>
> AFAICT there are lots of ways to configure the HttpClient instance by
> using HttpClientBuilder or HttpClients.
> So I don't understand why you say that the HttpClient instance should
> only be initialised once.
>
> > One, of course, can make SSL initialization lazy by using a custom
> > connection socket factory with SSLContext initialized on demand.
> >
> > Hope this helps
> >
> > Oleg
> >
> >> Thanks
> >> Regards
> >>
> >>
> >>
> >> On Thu, May 15, 2014 at 10:39 AM, Oleg Kalnichevski 
> >> wrote:
> >>
> >> > On Wed, 2014-05-14 at 19:46 +0100, sebb wrote:
> >> > > On 14 May 2014 12:28, Oleg Kalnichevski  wrote:
> >> >
> >> > ...
> >> >
> >> > > >> Issue is not present in HTTPCLient 3.1
> >> > > >
> >> > > > Philippe
> >> > > >
> >> > > > If HttpClient is used correctly, this code should only be
> executed only
> >> > > > once. Why does JMeter create more than one instance of HttpClient?
> >> > >
> >> > > We currently create an instance for each instance of different proxy
> >> > > settings and each protocol and each authority, because the client is
> >> > > created with these settings.
> >> > >
> >> > > This is also done for each thread.
> >> > >
> >> > > IIRC, this was necessary originally. We have not rewritten the code
> >> > > yet to use all the latest features.
> >> > >
> >> >
> >> > I see. For the time what you can do is to use a custom SSL socket
> >> > factory that lazily initializes SSL context when requested for the
> first
> >> > time. This is exactly what HC 3.1 does. It will be somewhat slower
> given
> >> > that one would need to mutex to synchronize access to the
> initialization
> >> > code.
> >> >
> >> > Oleg
> >> >
> >> > > > Oleg
> >> > > >
> >> > >
> >> > >
> -
> >> > > To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org
> >> > > For additional commands, e-mail:
> httpclient-users-h...@hc.apache.org
> >> > >
> >> >
> >> >
> >> >
> >>
> >>
> >
> >
>



-- 
Cordialement.
Philippe Mouawad.

SNI issue with HTTPClient 4 https://bz.apache.org/bugzilla/show_bug.cgi?id=57935

[Philippe Mouawad]

Hello,
I think I have fixed the SNI issue with HTTPClient 4. Note it was strange
that is worked with 3.1 and not 4.X.
It would be great if you could test it and review fix.

For me, this is a temporary fix until we upgrade the SSL Socket factory in
JMeter to use up to date classes from HttpClient 4.5.X

This socket factory has at least 3 aims in my understanding:
- Slow socket simulation
- SSL Context reuse or not
- Client SSL certificate management


I think in 3.1 version we should at least drop all code related to 3.X and
rework completely these part of the code as it is not easy to
read/understand.

-- 
Regards.
Philippe

Re: [GitHub] jmeter pull request: Removing unnecessary (un)boxing

[Graham Russell]

Hi Sebb

Thanks for having a look through the PR. I appreciate all the work you
do with JMeter!

I do not fully understand your argument. Do you have an example of
issues to help me understand where explicit (un)boxing would help
prevent a problem?

My main reason for the PR was to reduce the amount of code to improve
readability. In my opinion most explicit (un)boxing is just noise -
happy to be persuaded otherwise.

For example:
What potential problems does the booleanValue() here avoid? I
understand the need for the null check as you are right auto unboxing
could hide a NPE.

if (success != null) {
if (success.booleanValue()) { ...

vs.:

if (success != null) {
if (success) { ...

If the reasoning was to make it even more obvious that it was an
object and needed the null check, then, just as one example, this
hasn't worked in the HtmlTemplateExporter class, the method
EmptyGraphChecker.checkResult has
supportsControllerDiscrimination.booleanValue() but no null check even
though the method which created it could return null.

As another example, in a method which returns a long, I do not
understand why the .longValue() is helpful, e.g.:

public long getTimestamp() {
return getData(long.class, CSVSaveService.TIME_STAMP).longValue();
}

Or why:
Double.valueOf(((double) data.longValue() * 100 / errorCount))

is preferred over:

((double) data * 100 / errorCount)

I acknowledge you need to be mindful of NPE and auto (un)boxing in
loops etc. 
(http://brian.pontarelli.com/2004/07/15/jdk-5-auto-boxing-best-practices/)
but I currently do not see how being explicit about (ub)boxing helps?

I would very much appreciate any time you (or anyone else on the list)
could spare to improve my understanding of this issue, via email or
perhaps comment in github on specific changes and I would be happy to
update the PR.

Many thanks

Graham

On Mon, 15 Feb 2016 at 09:32 sebb  wrote:
>
> -1
>
> Auto boxing is generally a bad idea as it can hide poor design (wrong
> choice of long/Long).
>
> It can also hide wrong choice of method (Long.parseLong/Long.decode)
>
> Implicit unboxing can hide potential NPE.
>
> About the only place where autoboxing is useful is in String.format,
> but that should not be used as an excuse to allow it elsewhere.
>

[GitHub] jmeter pull request: Removing duplicate code.

[pmouawad]

Github user pmouawad commented on the pull request:

https://github.com/apache/jmeter/pull/126#issuecomment-185315393
  
Yes :-) fixed the comments
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Removing unnecessary (un)boxing

[pmouawad]

Github user pmouawad commented on the pull request:

https://github.com/apache/jmeter/pull/123#issuecomment-185315216
  
Note from sebb on dev mailing list:

> -1
> Auto boxing is generally a bad idea as it can hide poor design (wrong
>choice of long/Long).
>It can also hide wrong choice of method (Long.parseLong/Long.decode)
>Implicit unboxing can hide potential NPE.
>About the only place where autoboxing is useful is in String.format,
>but that should not be used as an excuse to allow it elsewhere.

Thanks for PR , if you can restrict it to String.format as per sebb notes.
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Removing duplicate code.

[ham1]

Github user ham1 commented on the pull request:

https://github.com/apache/jmeter/pull/126#issuecomment-185263205
  
Thanks @pmouawad, I think the comment was for PR #123 instead of this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Removing duplicate code.

[pmouawad]

Github user pmouawad commented on the pull request:

https://github.com/apache/jmeter/pull/126#issuecomment-185104857
  
Thanks for PR , if you can restrict it to String.format as per sebb notes.
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Removing duplicate code.

[pmouawad]

Github user pmouawad commented on the pull request:

https://github.com/apache/jmeter/pull/126#issuecomment-185104753
  
Note from sebb on dev mailing list:

> -1
> Auto boxing is generally a bad idea as it can hide poor design (wrong
>choice of long/Long).
>It can also hide wrong choice of method (Long.parseLong/Long.decode)
>Implicit unboxing can hide potential NPE.
>About the only place where autoboxing is useful is in String.format,
>but that should not be used as an excuse to allow it elsewhere.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---