HTTP Request simplify UI

2016-03-05 Thread Philippe Mouawad 
Hello,
What do you think of using a JTabbedPane to simplify the UI.

There would be a Basic Pane for usual parameters and an advanced one for
those which are rarely used.


I created https://bz.apache.org/bugzilla/show_bug.cgi?id=59129 with
screenshots.

-- 
Regards.
Philippe

Re: svn commit: r1733650 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java xdocs/changes.xml

2016-03-05 Thread sebb 
On 5 March 2016 at 11:00, Felix Schumacher
 wrote:
>
>
> Am 4. März 2016 21:42:20 MEZ, schrieb pmoua...@apache.org:
>>Author: pmouawad
>>Date: Fri Mar  4 20:42:20 2016
>>New Revision: 1733650
>>
>>URL: http://svn.apache.org/viewvc?rev=1733650=rev
>>Log:
>>Bug 59118 - Add comment in recorded think time by proxy recorder
>>#resolve #157
>>Bugzilla Id: 59118
>>
>>Modified:
>>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
>>jmeter/trunk/xdocs/changes.xml
>>
>>Modified:
>>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
>>URL:
>>http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java?rev=1733650=1733649=1733650=diff
>>==
>>---
>>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
>>(original)
>>+++
>>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
>>Fri Mar  4 20:42:20 2016
>>@@ -932,6 +932,7 @@ public class ProxyControl extends Generi
>> if (template instanceof Timer) {
>>TestElement timer = (TestElement) template.clone();
>> try {
>>+
>>timer.setComment("Recorded:"+Long.toString(deltaT)+"ms");
>
> Is the Long#toString really necessary?

Possibly not, but I think it's better to be explicit about conversions
- so I would recommend keeping it.

> Regards,
> Felix
>
>> replacer.undoReverseReplace(timer);
>> model.addComponent(timer, node);
>> } catch (InvalidVariableException
>>
>>Modified: jmeter/trunk/xdocs/changes.xml
>>URL:
>>http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1733650=1733649=1733650=diff
>>==
>>--- jmeter/trunk/xdocs/changes.xml (original)
>>+++ jmeter/trunk/xdocs/changes.xml Fri Mar  4 20:42:20 2016
>>@@ -133,6 +133,7 @@ Summary
>>59060HTTP Request GUI : Move File Upload to a new Tab to
>>have more space for parameters and prevent incoherent configuration.
>>Contributed by Benoit Wiart (benoit dot wiart at gmail.com)
>>59103HTTP Request Java Implementation: Change default
>>"http.java.sampler.retries" to align it on HttpClient behaviour and
>>make it meaningful
>>59083HTTP Request : Make Method field editable so that
>>additional methods (Webdav) can be added easily
>>+59118Add comment in recorded think time by proxy
>>recorder. Contributed by Antonio Gomes Rodrigues (ra0077 at
>>gmail.com)
>> 
>>
>> Other samplers
>

Re: svn commit: r1733756 - in /jmeter/trunk/src: components/org/apache/jmeter/modifiers/gui/ components/org/apache/jmeter/visualizers/ core/org/apache/jmeter/config/gui/ core/org/apache/jmeter/gui/uti

2016-03-05 Thread Milamber 



On 05/03/2016 20:05, Philippe Mouawad wrote:

Hi,
Wouldn't it be better to put applyHiDPI in ComponentUtil ?



See my comment about Jorphan package
https://bz.apache.org/bugzilla/show_bug.cgi?id=58426#c28

To have a applyHiDPI method in ComponentUtil, probably we need to change 
the current method based on a JMeter property (scale factor) to an 
automatic method based on the screen resolution (or a calculate DPI 
value from JVM if exists).





Regards

On Sat, Mar 5, 2016 at 7:50 PM,  wrote:


Author: milamber
Date: Sat Mar  5 18:50:43 2016
New Revision: 1733756

URL: http://svn.apache.org/viewvc?rev=1733756=rev
Log:
Better code to apploy the HiDPI mode in JTable elements. Thanks Benoit and
Felix.
Bugzilla Id: 58426

Modified:

jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java

jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java

jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java

jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatGraphVisualizer.java

jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatVisualizer.java

jmeter/trunk/src/components/org/apache/jmeter/visualizers/SummaryReport.java

jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
 jmeter/trunk/src/core/org/apache/jmeter/config/gui/ArgumentsPanel.java
 jmeter/trunk/src/core/org/apache/jmeter/config/gui/SimpleConfigGui.java
 jmeter/trunk/src/core/org/apache/jmeter/gui/util/FileListPanel.java
 jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TableEditor.java
 jmeter/trunk/src/core/org/apache/jmeter/util/JMeterUtils.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/AuthPanel.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/DNSCachePanel.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/HTTPFileArgsPanel.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/HeaderPanel.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/gui/ProxyControlGui.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java

jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSPropertiesPanel.java

jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LDAPArgumentsPanel.java

Modified:
jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java?rev=1733756=1733755=1733756=diff

==
---
jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java
(original)
+++
jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java
Sat Mar  5 18:50:43 2016
@@ -206,10 +206,7 @@ public class UserParametersGui extends A
  // paramTable.setCellSelectionEnabled(true);
  // paramTable.setPreferredScrollableViewportSize(new
Dimension(100,
  // 70));
-// HiDPI mode management
-if (JMeterUtils.getHiDPIMode()) {
-paramTable.setRowHeight((int)
Math.round(paramTable.getRowHeight() * JMeterUtils.getHiDPIScaleFactor()));
-}
+JMeterUtils.applyHiDPI(paramTable);

  paramPanel = new JPanel(new BorderLayout());
  paramPanel.add(tableLabel, BorderLayout.NORTH);

Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java?rev=1733756=1733755=1733756=diff

==
---
jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
(original)
+++
jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
Sat Mar  5 18:50:43 2016
@@ -160,10 +160,7 @@ public class PropertyControlGui extends
  table = new JTable(tableModel);
  table.getTableHeader().setDefaultRenderer(new
HeaderAsPropertyRenderer());
  table.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
-// HiDPI mode management
-if (JMeterUtils.getHiDPIMode()) {
-table.setRowHeight((int) Math.round(table.getRowHeight() *
JMeterUtils.getHiDPIScaleFactor()));
-}
+JMeterUtils.applyHiDPI(table);
  return makeScrollPane(table);
  }


Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java?rev=1733756=1733755=1733756=diff

Re: svn commit: r1733756 - in /jmeter/trunk/src: components/org/apache/jmeter/modifiers/gui/ components/org/apache/jmeter/visualizers/ core/org/apache/jmeter/config/gui/ core/org/apache/jmeter/gui/uti

2016-03-05 Thread Felix Schumacher 

Am 05.03.2016 um 21:05 schrieb Philippe Mouawad:

Hi,
Wouldn't it be better to put applyHiDPI in ComponentUtil ?
I have just seen your comment about ComponentUtil#createTable and I like 
it even better than JMeterUtils#applyHiDPI.


An easy solution would be to add a return statement to applyHiDPI and 
return the given table and move it to ComponentUtil. That way one could 
write

  JTable table = ComponentUtil.applyHiDPI(new JTable());

The next step would be to create the table in the function and rename it 
to createTable.


I wonder if it would be even better to have a HiDPITable, which extends 
JTable and overwrites setRowHeight, but that might be overkill.


Felix



Regards

On Sat, Mar 5, 2016 at 7:50 PM,  wrote:


Author: milamber
Date: Sat Mar  5 18:50:43 2016
New Revision: 1733756

URL: http://svn.apache.org/viewvc?rev=1733756=rev
Log:
Better code to apploy the HiDPI mode in JTable elements. Thanks Benoit and
Felix.
Bugzilla Id: 58426

Modified:

jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java

jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java

jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java

jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatGraphVisualizer.java

jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatVisualizer.java

jmeter/trunk/src/components/org/apache/jmeter/visualizers/SummaryReport.java

jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
 jmeter/trunk/src/core/org/apache/jmeter/config/gui/ArgumentsPanel.java
 jmeter/trunk/src/core/org/apache/jmeter/config/gui/SimpleConfigGui.java
 jmeter/trunk/src/core/org/apache/jmeter/gui/util/FileListPanel.java
 jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TableEditor.java
 jmeter/trunk/src/core/org/apache/jmeter/util/JMeterUtils.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/AuthPanel.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/DNSCachePanel.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/HTTPFileArgsPanel.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/HeaderPanel.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/gui/ProxyControlGui.java

jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java

jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSPropertiesPanel.java

jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LDAPArgumentsPanel.java

Modified:
jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java?rev=1733756=1733755=1733756=diff

==
---
jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java
(original)
+++
jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java
Sat Mar  5 18:50:43 2016
@@ -206,10 +206,7 @@ public class UserParametersGui extends A
  // paramTable.setCellSelectionEnabled(true);
  // paramTable.setPreferredScrollableViewportSize(new
Dimension(100,
  // 70));
-// HiDPI mode management
-if (JMeterUtils.getHiDPIMode()) {
-paramTable.setRowHeight((int)
Math.round(paramTable.getRowHeight() * JMeterUtils.getHiDPIScaleFactor()));
-}
+JMeterUtils.applyHiDPI(paramTable);

  paramPanel = new JPanel(new BorderLayout());
  paramPanel.add(tableLabel, BorderLayout.NORTH);

Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java?rev=1733756=1733755=1733756=diff

==
---
jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
(original)
+++
jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
Sat Mar  5 18:50:43 2016
@@ -160,10 +160,7 @@ public class PropertyControlGui extends
  table = new JTable(tableModel);
  table.getTableHeader().setDefaultRenderer(new
HeaderAsPropertyRenderer());
  table.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
-// HiDPI mode management
-if (JMeterUtils.getHiDPIMode()) {
-table.setRowHeight((int) Math.round(table.getRowHeight() *
JMeterUtils.getHiDPIScaleFactor()));
-}
+JMeterUtils.applyHiDPI(table);
  return makeScrollPane(table);
  }


Modified:

Re: svn commit: r1733756 - in /jmeter/trunk/src: components/org/apache/jmeter/modifiers/gui/ components/org/apache/jmeter/visualizers/ core/org/apache/jmeter/config/gui/ core/org/apache/jmeter/gui/uti

2016-03-05 Thread Philippe Mouawad 
Hi,
Wouldn't it be better to put applyHiDPI in ComponentUtil ?

Regards

On Sat, Mar 5, 2016 at 7:50 PM,  wrote:

> Author: milamber
> Date: Sat Mar  5 18:50:43 2016
> New Revision: 1733756
>
> URL: http://svn.apache.org/viewvc?rev=1733756=rev
> Log:
> Better code to apploy the HiDPI mode in JTable elements. Thanks Benoit and
> Felix.
> Bugzilla Id: 58426
>
> Modified:
>
> jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java
>
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
>
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java
>
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatGraphVisualizer.java
>
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatVisualizer.java
>
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/SummaryReport.java
>
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
> jmeter/trunk/src/core/org/apache/jmeter/config/gui/ArgumentsPanel.java
> jmeter/trunk/src/core/org/apache/jmeter/config/gui/SimpleConfigGui.java
> jmeter/trunk/src/core/org/apache/jmeter/gui/util/FileListPanel.java
> jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TableEditor.java
> jmeter/trunk/src/core/org/apache/jmeter/util/JMeterUtils.java
>
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/AuthPanel.java
>
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java
>
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/DNSCachePanel.java
>
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/HTTPFileArgsPanel.java
>
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/HeaderPanel.java
>
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/gui/ProxyControlGui.java
>
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java
>
> jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSPropertiesPanel.java
>
> jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LDAPArgumentsPanel.java
>
> Modified:
> jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java
> URL:
> http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java?rev=1733756=1733755=1733756=diff
>
> ==
> ---
> jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java
> (original)
> +++
> jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java
> Sat Mar  5 18:50:43 2016
> @@ -206,10 +206,7 @@ public class UserParametersGui extends A
>  // paramTable.setCellSelectionEnabled(true);
>  // paramTable.setPreferredScrollableViewportSize(new
> Dimension(100,
>  // 70));
> -// HiDPI mode management
> -if (JMeterUtils.getHiDPIMode()) {
> -paramTable.setRowHeight((int)
> Math.round(paramTable.getRowHeight() * JMeterUtils.getHiDPIScaleFactor()));
> -}
> +JMeterUtils.applyHiDPI(paramTable);
>
>  paramPanel = new JPanel(new BorderLayout());
>  paramPanel.add(tableLabel, BorderLayout.NORTH);
>
> Modified:
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
> URL:
> http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java?rev=1733756=1733755=1733756=diff
>
> ==
> ---
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
> (original)
> +++
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/PropertyControlGui.java
> Sat Mar  5 18:50:43 2016
> @@ -160,10 +160,7 @@ public class PropertyControlGui extends
>  table = new JTable(tableModel);
>  table.getTableHeader().setDefaultRenderer(new
> HeaderAsPropertyRenderer());
>  table.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
> -// HiDPI mode management
> -if (JMeterUtils.getHiDPIMode()) {
> -table.setRowHeight((int) Math.round(table.getRowHeight() *
> JMeterUtils.getHiDPIScaleFactor()));
> -}
> +JMeterUtils.applyHiDPI(table);
>  return makeScrollPane(table);
>  }
>
>
> Modified:
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java
> URL:
> http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java?rev=1733756=1733755=1733756=diff
>
> ==
> ---
> jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java
> (original)
> +++
>

[GitHub] jmeter pull request: bug 58426 move the jtable hdpi ui improvement...

2016-03-05 Thread benbenw 
GitHub user benbenw opened a pull request:

https://github.com/apache/jmeter/pull/160

bug 58426 move the jtable hdpi ui improvements into a single method



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/benbenw/jmeter hdpifactor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #160


commit 39f6dcc4d6b05cae41e4c13ae58af11d0c06018f
Author: benoit 
Date:   2016-03-05T18:13:12Z

bug 58426 move the jtable hdpi ui improvements into a single method




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Change the running indicator

2016-03-05 Thread benbenw 
Github user benbenw closed the pull request at:

https://github.com/apache/jmeter/pull/152


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Change the running indicator

2016-03-05 Thread milamberspace 
Github user milamberspace commented on the pull request:

https://github.com/apache/jmeter/pull/152#issuecomment-192651347
  
@benbenw Thanks for your PR. I've just merge the #159 with include the 
change for the status icon. You can close your PR
@pmouawad thanks for the ping.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Changes the default tree's icons with new icons set ready to HiDPI

2016-03-05 Thread Milamber 

Hello,

I've just commit the pseudo-hidpi changes in the trunk. With this 
changes, a new icon set was bring inside.


First, for the nostalgic people, you can return to old tree's icons with 
the property:

jmeter.icons=org/apache/jmeter/images/icon_old.properties

Second, this new icons was selected on the Open Icon Library, if an new 
icon is not the good icon for a element, you can find/purpose a new icon 
from this library.


This new set changes the look of JMeter, and justify more the 2.x -> 3.x 
version name (IMHO)


The HiDPI changes are mainly for the Linux/Windows people with high 
resolution like 3200x1800.


You can enable the pseudo-hidpi display with theses values (in your 
user.properties)


jmeter.toolbar.icons.size=48x48
jmeter.tree.icons.size=32x32
jmeter.hidpi.mode=true
jmeter.hidpi.scale.factor=2.0
jsyntaxtextarea.font.size=28


Milamber

@me Note for later: Don't forget to mention this mode in the New and 
Noteworthy section in changes.xml



[1] http://openiconlibrary.sourceforge.net/


On 09/02/2016 19:51, Milamber wrote:

Hello,

I would like merge my HiDPI branch [1] into the trunk before the next 
release.


To have a (pseudo) HiDPI mode with JMeter on Linux and Windows (MacOS 
has already JDK with HiDPI mode), we needs to have tree's icons with 
several dimensions (19x19 pixels, 24x24, 32x32 and 48x48). 
Unfortunately, the current icons set have only the 19x19 size, the 
original format is png (bitmap and not scalable like svg).


In the HiDPI branch, I've changed all tree's icons with a new set from 
openiconlibrary [2] (the library used for the current JMeter toolbar). 
The new set provides some sizes for png type and svg icons set allow 
to create every missing size in png.


Are you agree to change the tree's icons (make the new set are default)?

Or you prefer keep the old set (from 2003!) and use a property to have 
the new set (which allow the hidpi mode)?


You can see some screenshots on the bugzilla:
https://bz.apache.org/bugzilla/show_bug.cgi?id=58426
Like this : https://bz.apache.org/bugzilla/attachment.cgi?id=33396

You can test JMeter with the new icon set with this (personal) nightly 
build [3]


Comments are welcome on the icons choices.


Milamber


[1]https://github.com/milamberspace/jmeter/tree/HiDPI_changes_1

[2] http://openiconlibrary.sourceforge.net/

[2] http://www.milamberspace.net/hidpi/apache-jmeter-2.14-SNAPSHOT.tgz

Re: Remaining Work before Release of 3.0

2016-03-05 Thread Philippe Mouawad 
Hi

On Sat, Mar 5, 2016 at 9:43 AM, Mark Collin 
wrote:

>
> > If Mark is ok with this, what about having a separate sister project of
> > jmeter for the maven plugin (maybe also the jenkins one if we have some
> > volunteers)
> > It could be (if incubated and agreed upon) under the Apache umbrella and
> we
> > could(those who want) participate to it.
> >
> > The release process would be partly dependant on jmeter but as sebb wrote
> > also on maven /jenkins.
> >
>
>
> Not sure I understand what you are proposing here?  A sister version of
> Jmeter using Maven as a build tool?

No

> That seems like an awful lot of work for very little gain.
>
Yes

>
> Or are you suggesting moving the maven-plugin under the Apache umbrella?
>
Yes that was my proposal.



-- 
Cordialement.
Philippe Mouawad.

Re: svn commit: r1733650 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java xdocs/changes.xml

2016-03-05 Thread Felix Schumacher 


Am 4. März 2016 21:42:20 MEZ, schrieb pmoua...@apache.org:
>Author: pmouawad
>Date: Fri Mar  4 20:42:20 2016
>New Revision: 1733650
>
>URL: http://svn.apache.org/viewvc?rev=1733650=rev
>Log:
>Bug 59118 - Add comment in recorded think time by proxy recorder
>#resolve #157
>Bugzilla Id: 59118
>
>Modified:
>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
>jmeter/trunk/xdocs/changes.xml
>
>Modified:
>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java?rev=1733650=1733649=1733650=diff
>==
>---
>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
>(original)
>+++
>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
>Fri Mar  4 20:42:20 2016
>@@ -932,6 +932,7 @@ public class ProxyControl extends Generi
> if (template instanceof Timer) {
>TestElement timer = (TestElement) template.clone();
> try {
>+   
>timer.setComment("Recorded:"+Long.toString(deltaT)+"ms");

Is the Long#toString really necessary? 

Regards, 
Felix 

> replacer.undoReverseReplace(timer);
> model.addComponent(timer, node);
> } catch (InvalidVariableException
>
>Modified: jmeter/trunk/xdocs/changes.xml
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1733650=1733649=1733650=diff
>==
>--- jmeter/trunk/xdocs/changes.xml (original)
>+++ jmeter/trunk/xdocs/changes.xml Fri Mar  4 20:42:20 2016
>@@ -133,6 +133,7 @@ Summary
>59060HTTP Request GUI : Move File Upload to a new Tab to
>have more space for parameters and prevent incoherent configuration.
>Contributed by Benoit Wiart (benoit dot wiart at gmail.com)
>59103HTTP Request Java Implementation: Change default
>"http.java.sampler.retries" to align it on HttpClient behaviour and
>make it meaningful
>59083HTTP Request : Make Method field editable so that
>additional methods (Webdav) can be added easily
>+59118Add comment in recorded think time by proxy
>recorder. Contributed by Antonio Gomes Rodrigues (ra0077 at
>gmail.com)
> 
> 
> Other samplers

Re: Remaining Work before Release of 3.0

2016-03-05 Thread Mark Collin 

> If Mark is ok with this, what about having a separate sister project of
> jmeter for the maven plugin (maybe also the jenkins one if we have some
> volunteers)
> It could be (if incubated and agreed upon) under the Apache umbrella and we
> could(those who want) participate to it.
> 
> The release process would be partly dependant on jmeter but as sebb wrote
> also on maven /jenkins.
> 


Not sure I understand what you are proposing here?  A sister version of Jmeter 
using Maven as a build tool?  That seems like an awful lot of work for very 
little gain.

Or are you suggesting moving the maven-plugin under the Apache umbrella?