date:20160419

Jenkins build is back to normal : JMeter-trunk #5213

2016-04-19 Thread Apache Jenkins Server

See

Re: [GitHub] jmeter pull request: Used multi-catch, enhanced for loops, contain...

2016-04-19 Thread sebb

On 19 April 2016 at 23:44, Vladimir Sitnikov
 wrote:
> sebb>Yes, but is a stack trace necessary here?
> sebb>So long as it's obvious what the problem is and how to fix it without
>
> You do not think "catch (Exception e)" is obvious, do you?

Depends.

> What if it fails with NPE in unknown line?

Then I agree the stack trace is needed.
However for most cases it probably is not; I think the problem here is
that the catch is too broad.
I would probably catch the more obvious exceptions and let anything
else ripple up.

Looking at it again, I wonder why the catch was changed from
ConversionException?
The log message does not say.

> Vladimir

buildbot success in on jmeter-trunk

2016-04-19 Thread buildbot

The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/1026

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1740030
Blamelist: vladimirsitnikov

Build succeeded!

Sincerely,
 -The Buildbot

Re: [GitHub] jmeter pull request: Used multi-catch, enhanced for loops, contain...

2016-04-19 Thread Vladimir Sitnikov

sebb>Yes, but is a stack trace necessary here?
sebb>So long as it's obvious what the problem is and how to fix it without

You do not think "catch (Exception e)" is obvious, do you?
What if it fails with NPE in unknown line?

Vladimir

Re: [GitHub] jmeter pull request: Used multi-catch, enhanced for loops, contain...

2016-04-19 Thread sebb

On 19 April 2016 at 22:40, vlsi  wrote:
> Github user vlsi commented on a diff in the pull request:
>
> https://github.com/apache/jmeter/pull/174#discussion_r60316883
>
> --- Diff: src/core/org/apache/jmeter/reporters/ResultCollector.java ---
> @@ -386,16 +384,14 @@ public void loadExistingFile() {
>  
> SaveService.loadTestResults(bufferedInputStream,
>  new ResultCollectorHelper(this, 
> visualizer));
>  parsedOK = true;
> -} catch (ConversionException e) {
> -log.warn("Failed to load "+filename+" using 
> XStream. Error was: "+e);
>  } catch (Exception e) {
> -log.warn("Failed to load "+filename+" using 
> XStream. Error was: "+e);
> +log.warn("Failed to load " + filename + " 
> using XStream. Error was: " + e);
> --- End diff --
>
> I think comma should be used to log exception stacktrace, shouldn't it?

Yes, but is a stack trace necessary here?
So long as it's obvious what the problem is and how to fix it without
the stack trace, that just adds noise.

>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

[GitHub] jmeter pull request: Bug59351_BetterErrorMessageInIncludeControlle...

2016-04-19 Thread ra0077

Github user ra0077 commented on the pull request:

https://github.com/apache/jmeter/pull/202#issuecomment-212154513
  
Hi Philippe,

Like you can see in 
https://docs.oracle.com/javase/7/docs/api/java/io/File.html#canRead%28%29

"Returns:
true if and only if the file specified by this abstract pathname exists 
and can be read by the application; false otherwise"

canRead() test if the file exists and can be read

With this modification we have a better error message if the file can't be 
read

Antonio



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html

2016-04-19 Thread ra0077

Github user ra0077 commented on the pull request:

https://github.com/apache/jmeter/pull/203#issuecomment-212153353
  
Hi Philippe,

My title of PR is not good

I have modified xdocs/changes.xml file and not the html file

Antonio



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: JMeter-trunk #5212

2016-04-19 Thread Apache Jenkins Server

See 

Changes:

[vladimirsitnikov] Refactor TestCacheManager: replace duplicated code with 
inheritance

Reduce timeouts from 5 to 1 seconds to speedup test execution

closes #178

[vladimirsitnikov] Compress PNGs

Working copy is reduced by 19MiB

Command line used:
find . -name '*.png' -print0 | xargs -0 -P8 -L1 pngquant --ext .png --force

closes #177

--
[...truncated 1992 lines...]
 [copy] Copying 1 file to 


docs-api:
 [echo] Updating overview to r1740017
  [javadoc] Generating Javadoc
  [javadoc] Javadoc execution
  [javadoc] Loading source files for package org.apache.jmeter...
  [javadoc] Loading source files for package org.apache.jmeter.assertions...
  [javadoc] Loading source files for package org.apache.jmeter.assertions.gui...
  [javadoc] Loading source files for package org.apache.jmeter.config...
  [javadoc] Loading source files for package org.apache.jmeter.config.gui...
  [javadoc] Loading source files for package org.apache.jmeter.control...
  [javadoc] Loading source files for package org.apache.jmeter.control.gui...
  [javadoc] Loading source files for package org.apache.jmeter.engine...
  [javadoc] Loading source files for package org.apache.jmeter.engine.event...
  [javadoc] Loading source files for package org.apache.jmeter.engine.util...
  [javadoc] Loading source files for package org.apache.jmeter.exceptions...
  [javadoc] Loading source files for package org.apache.jmeter.functions...
  [javadoc] Loading source files for package org.apache.jmeter.functions.gui...
  [javadoc] Loading source files for package org.apache.jmeter.functions.util...
  [javadoc] Loading source files for package org.apache.jmeter.gui...
  [javadoc] Loading source files for package org.apache.jmeter.gui.action...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.template...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.validation...
  [javadoc] Loading source files for package org.apache.jmeter.gui.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.gui.tree...
  [javadoc] Loading source files for package org.apache.jmeter.gui.util...
  [javadoc] Loading source files for package org.apache.jmeter.logging...
  [javadoc] Loading source files for package org.apache.jmeter.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.processor...
  [javadoc] Loading source files for package org.apache.jmeter.processor.gui...
  [javadoc] Loading source files for package org.apache.jmeter.report.config...
  [javadoc] Loading source files for package org.apache.jmeter.report.core...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.dashboard...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph.impl...
  [javadoc] Loading source files for package org.apache.jmeter.reporters...
  [javadoc] Loading source files for package org.apache.jmeter.reporters.gui...
  [javadoc] Loading source files for package org.apache.jmeter.samplers...
  [javadoc] Loading source files for package org.apache.jmeter.samplers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.save...
  [javadoc] Loading source files for package 
org.apache.jmeter.save.converters...
  [javadoc] Loading source files for package org.apache.jmeter.services...
  [javadoc] Loading source files for package org.apache.jmeter.swing...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans.gui...
  [javadoc] Loading source files for package org.apache.jmeter.testelement...
  [javadoc] Loading source files for package 
org.apache.jmeter.testelement.property...
  [javadoc] Loading source files for package org.apache.jmeter.threads...
  [javadoc] Loading source files for package org.apache.jmeter.threads.gui...
  [javadoc] Loading source files for package org.apache.jmeter.timers...
  [javadoc] Loading source files for package org.apache.jmeter.timers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.util...
  [javadoc] Loading source files for package org.apache.jmeter.util.keystore...
  [javadoc] Loading source files for package org.apache.jmeter.visualizers...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.extractor...
  [javadoc] Loading source files for package org.apache.jmeter.extractor.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.extractor.json.jsonpath...
  [javadoc] Loading source files for package

[GitHub] jmeter pull request: Refactor TestCacheManager: replace duplicated...

2016-04-19 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/178


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

buildbot failure in on jmeter-trunk

2016-04-19 Thread buildbot

The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/1023

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1740015
Blamelist: vladimirsitnikov

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

[GitHub] jmeter pull request: Compress PNGs

2016-04-19 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/177


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Bug59351_BetterErrorMessageInIncludeControlle...

2016-04-19 Thread pmouawad

Github user pmouawad commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/202#discussion_r60310491
  
--- Diff: src/components/org/apache/jmeter/control/IncludeController.java 
---
@@ -121,19 +121,20 @@ protected HashTree loadIncludedElements() {
 final String includePath = getIncludePath();
 HashTree tree = null;
 if (includePath != null && includePath.length() > 0) {
+String fileName=prefix+includePath;
 try {
-String fileName=prefix+includePath;
+
 File file = new File(fileName);
 final String absolutePath = file.getAbsolutePath();
 log.info("loadIncludedElements -- try to load included 
module: "+absolutePath);
 if(!file.exists() && !file.isAbsolute()){
 log.info("loadIncludedElements -failed for: 
"+absolutePath);
 file = new 
File(FileServer.getFileServer().getBaseDir(), includePath);
 log.info("loadIncludedElements -Attempting to read it 
from: " + file.getAbsolutePath());
-if(!file.exists()){
+if(!file.canRead() || !file.isFile()){
--- End diff --

Hi,
Why do you replace !file.exists() by !file.canRead() || !file.isFile() 
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Compress PNGs

2016-04-19 Thread pmouawad

Github user pmouawad commented on the pull request:

https://github.com/apache/jmeter/pull/177#issuecomment-212119570
  
Hi @vlsi ,
Will you commit this ?
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Bug 59258 : GUI Mode : OOM Protection for Vie...

2016-04-19 Thread pmouawad

Github user pmouawad closed the pull request at:

https://github.com/apache/jmeter/pull/179


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Refactor TestCacheManager: replace duplicated...

2016-04-19 Thread pmouawad

Github user pmouawad commented on the pull request:

https://github.com/apache/jmeter/pull/178#issuecomment-212119461
  
Hi @vlsi ,
Will you commit this ?
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html

2016-04-19 Thread pmouawad

Github user pmouawad commented on the pull request:

https://github.com/apache/jmeter/pull/203#issuecomment-212119330
  
Hi Antonio,
I think it's a good idea.

But if you want to create a PR for docs, you must update changes.xml .
All html files are generated from xml.

Regards
Philippe


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: New website: horizontal scrolling?

2016-04-19 Thread Milamber




On 19/04/2016 20:36, Felix Schumacher wrote:

Am 17.04.2016 um 13:04 schrieb Milamber:

Hello,

In the next website (3.0), all pages have a horizontal scrolling on 
my computer with Firefox or Chrome (and same issue on Windows with 
Edge, IE, FF)


On the current website, the horizontal scrolling don't exist. Do you 
know why ? (@Felix?)
I think I know why. I have committed a different solution for the 
problem with r1739987


Could you check, whether it is OK on your test browsers?



That's works fine with your change. Thanks.





Thanks,
 Felix



http://home.apache.org/~milamber/jmeter-3.0RC1/docs/index.html

Thanks

Milamber

Build failed in Jenkins: JMeter-trunk #5211

2016-04-19 Thread Apache Jenkins Server

See 

Changes:

[pmouawad] Groovy is now embedded in JMeter

[pmouawad] Use correct Cookie policy
Http Request Defaults : Use up to date pool size
Set View Results Tree file name to recording.xml  to save the recording

[pmouawad] Use correct Cookie policy
Http Request Defaults : Use up to date pool size
Set View Results Tree file name to recording.xml  to save the recording

[pmouawad] Use correct Cookie policy
Remove disabled component
Remove jmeter website urls
Add Http Request Defaults

[fschumacher] Make header span the complete width again, but remove the 
padding, that
let the horizontal scrollbar appear. Set the text alignment inside the header
to center, so that the padding is not necessary anymore.

[pmouawad] Revert wrong license info for sbadmin v2 1.0.7

--
[...truncated 1318 lines...]
   [anakia] Input:  usermanual/index.xml
   [anakia] Output: 

   [anakia] Input:  usermanual/intro.xml
   [anakia] Output: 

   [anakia] Input:  usermanual/ldapanswer_xml.xml
   [anakia] Output: 

   [anakia] Input:  usermanual/ldapops_tutor.xml
   [anakia] Output: 

   [anakia] Input:  usermanual/listeners.xml
   [anakia] Output: 

   [anakia] Input:  usermanual/properties_reference.xml
   [anakia] Output: 

   [anakia] Input:  usermanual/realtime-results.xml
   [anakia] Output: 

   [anakia] Input:  usermanual/regular_expressions.xml
   [anakia] Output: 

   [anakia] Input:  usermanual/remote-test.xml
   [anakia] Output: 

   [anakia] Input:  usermanual/test_plan.xml
   [anakia] Output: 

 [echo] Fixing EOL
 [echo] Removing unnecessary  tags
 [echo] Copying files
 [copy] Copying 2 files to 

 [copy] Copying 405 files to 

 [copy] Copying 16 files to 

 [copy] Copying 5 files to 

 [copy] Copying 1 file to 


docs-api:
 [echo] Updating overview to r1739992
  [javadoc] Generating Javadoc
  [javadoc] Javadoc execution
  [javadoc] Loading source files for package org.apache.jmeter...
  [javadoc] Loading source files for package org.apache.jmeter.assertions...
  [javadoc] Loading source files for package org.apache.jmeter.assertions.gui...
  [javadoc] Loading source files for package org.apache.jmeter.config...
  [javadoc] Loading source files for package org.apache.jmeter.config.gui...
  [javadoc] Loading source files for package org.apache.jmeter.control...
  [javadoc] Loading source files for package org.apache.jmeter.control.gui...
  [javadoc] Loading source files for package org.apache.jmeter.engine...
  [javadoc] Loading source files for package org.apache.jmeter.engine.event...
  [javadoc] Loading source files for package org.apache.jmeter.engine.util...
  [javadoc] Loading source files for package org.apache.jmeter.exceptions...
  [javadoc] Loading source files for package org.apache.jmeter.functions...
  [javadoc] Loading source files for package org.apache.jmeter.functions.gui...
  [javadoc] Loading source files for package org.apache.jmeter.functions.util...
  [javadoc] Loading source files for package org.apache.jmeter.gui...
  [javadoc] Loading source files for package org.apache.jmeter.gui.action...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.template...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.validation...
  [javadoc] Loading source files for package org.apache.jmeter.gui.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.gui.tree...
  [javadoc] Loading source files for package org.apache.jmeter.gui.util...
  [javadoc] Loading source files for package

Re: New website: horizontal scrolling?

2016-04-19 Thread Felix Schumacher


Am 17.04.2016 um 13:04 schrieb Milamber:

Hello,

In the next website (3.0), all pages have a horizontal scrolling on my 
computer with Firefox or Chrome (and same issue on Windows with Edge, 
IE, FF)


On the current website, the horizontal scrolling don't exist. Do you 
know why ? (@Felix?)
I think I know why. I have committed a different solution for the 
problem with r1739987


Could you check, whether it is OK on your test browsers?

Thanks,
 Felix



http://home.apache.org/~milamber/jmeter-3.0RC1/docs/index.html

Thanks

Milamber

Re: New website: horizontal scrolling?

2016-04-19 Thread Philippe Mouawad

On Tue, Apr 19, 2016 at 9:25 PM, Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:

> Felix> I have done a simple setup for how it might look like on
> Felix> http://internetallee.de/~felix/jmeter/index.html
>
> As for me, star/fork/maven central buttons draw attention a little bit
> too much: their colors are not in line with the page.
>
> What if we have just "fork me on github" ribbon
> (https://github.com/blog/273-github-ribbons) on the main page.
> maven, CI badges should probably be moved to readme.MD (that is the
> page that is displayed at github).
>
I prefer to see badges on HomePage of JMeter.
ok for the ribbon


> Any objections on converting readme -> readme.md?
>
+1 for me

>
> Philippe>The badges are not big so I don't think it hurts
>
> You are right, the badges are not big. However, their style is
> different from all the other items on the page.
>
It's a matter of taste. It does not hurt me and it provides interesting
info for developers (maven dependencies links)

>
> Vladimir
>

Provided we don't delay release for this, let's proceed with whatever suits
the majority
Regards

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread Philippe Mouawad

Hi sebb, all,
I don't know what to do.

We depend on sbadmin which embeds a lot of dependencies but we don't use
them all.
My initial idea was not to touch it to ease upgrade.
But now, we are moving license.txt files into jmeter license folder so
changing it


Regarding your remarks sebb:
sebb: What about the files under bin/report-template/content?
> There is a license header for the ones that have not been developed by
JMeter

sebb: Are all the files under bin/report-template/sbadmin2-1.0.7 really
part of sb admin or bootstrap/mocha/metisMenu ?
> Yes. You could have checked this by downloading it.

sebb: What about less?
> http://startbootstrap.com/template-overviews/sb-admin-2/
> "LESS files included for deeper customization"

sebb: There seem to be copies of jquery
> Could you give more detail ?

sebb: What about the files under bin/report-template/content?
> Some are developments donated to Apache JMeter. The others are well known
dependencies under Apache Compatibles licenses mentioned in headers.


Regards



On Tue, Apr 19, 2016 at 2:14 PM, sebb  wrote:

> Also
>
> bin/report-template/sbadmin2-1.0.7/bower_components/datatables/license.txt
> bin/report-template/sbadmin2-1.0.7/bower_components/raphael/license.txt
>
>
>
> On 19 April 2016 at 12:54, sebb  wrote:
> > On 19 April 2016 at 12:40, Philippe Mouawad 
> wrote:
> >> On Tue, Apr 19, 2016 at 12:35 PM, sebb  wrote:
> >>
> >>> On 19 April 2016 at 11:30, Philippe Mouawad <
> philippe.moua...@gmail.com>
> >>> wrote:
> >>> > On Tue, Apr 19, 2016 at 12:20 PM, sebb  wrote:
> >>> >
> >>> >> Also the actual file names covered by the licenses need to be
> mentioned.
> >>> >>
> >>> >
> >>> > Can you be more explicit or do it ?
> >>> > I don't understand.
> >>> > Is the folder enough ?
> >>>
> >>> The user must be able to identify all the external files and their
> >>> licenses.
> >>> In the case of a jar, the jar name is sufficient.
> >>>
> >>
> >> Frankly I think we're one of the project that documents this the most.
> >
> > That does not mean we should not do it.
> >
> >> Isn't it too much ? This is really cumbersome as we now have to update
> for
> >> a library upgrade :
> >>
> >>- LICENSE
> >>- licenses/src
> > OR
> >>- licenses/bin
> >>- paths
> > paths would have to be done anyway.
> >
> >
> > The point is that downstream consumers must be told what the licenses
> are.
> >
> > The alternative would be to put it all in the LICENSE file.
> > That makes it very hard to read, and even harder to update especially
> > when dropping a dependency.
> >
> >>
> >>
> >>
> >>>
> >>> For source files it depends on how the files are grouped.
> >>> I don't know which files are under which license.
> >>>
> >> I tried to do it  but if it does not suit you feel free to modify
> >
> > What about the files under
> >
> > bin/report-template/content?
> >
> > Are all the files under
> > bin/report-template/sbadmin2-1.0.7
> >
> > really part of sb admin or bootstrap/mocha/metisMenu ?
> >
> > There seem to be copies of jquery
> > What about less?
> >
> >>>
> >>> BTW, it looks as though Start BootStrap is now MIT and the author has
> >>> moved to a new company so the README is out of date.
> >>>
> >>> Fixed.
> >>
> >>
> >>> >>
> >>> >> Note that the binary LICENSE section includes the full jar name,
> >>> >> including the .jar.
> >>> >> The source section needs to do likewise.
> >>> >>
> >>> >> There may need to be some updates to the unit test to deal with the
> >>> >> source licenses.
> >>> >>
> >>> >> On 19 April 2016 at 11:02, sebb  wrote:
> >>> >> > These are *source* files so the licenses belong under license/src.
> >>> >> >
> >>> >> > Also the final section of the main LICENSE file is intended for
> >>> >> > binary-only code.
> >>> >> > (It's not all that obvious at present)
> >>> >> >
> >>> >> > On 19 April 2016 at 07:33, Philippe Mouawad <
> >>> philippe.moua...@gmail.com>
> >>> >> wrote:
> >>> >> >> Hi sebb,
> >>> >> >> I filled in in root LICENSE file the license information for the
> 4
> >>> >> >> components.
> >>> >> >> Do we need to also add the MIT license in license/bin folder ?
> >>> >> >> Thanks
> >>> >> >>
> >>> >> >> On Tue, Apr 19, 2016 at 3:24 AM, sebb  wrote:
> >>> >> >>
> >>> >> >>> On 19 April 2016 at 01:32, sebb  wrote:
> >>> >> >>> > On 17 April 2016 at 18:03, Milamber 
> wrote:
> >>> >> >>> >> Hello,
> >>> >> >>> >>
> >>> >> >>> >> The second release candidate for JMeter 3.0 (r1739623) has
> been
> >>> >> >>> prepared,
> >>> >> >>> >> and your votes are solicited.
> >>> >> >>> >>
> >>> >> >>> >> This release brings a lot of new features (over 100) and
> fixes
> >>> many
> >>> >> bugs
> >>> >> >>> >> (60).
> >>> >> >>> >>
> >>> >> >>> >> If you can, some tests of this release candidate (load tests
> >>> and/or
> >>> >> >>> >> functional tests) with Java 7/8 on

Re: New website: horizontal scrolling?

2016-04-19 Thread Vladimir Sitnikov

Felix> I have done a simple setup for how it might look like on
Felix> http://internetallee.de/~felix/jmeter/index.html

As for me, star/fork/maven central buttons draw attention a little bit
too much: their colors are not in line with the page.

What if we have just "fork me on github" ribbon
(https://github.com/blog/273-github-ribbons) on the main page.
maven, CI badges should probably be moved to readme.MD (that is the
page that is displayed at github).

Any objections on converting readme -> readme.md?

Philippe>The badges are not big so I don't think it hurts

You are right, the badges are not big. However, their style is
different from all the other items on the page.

Vladimir

Re: sbadmin2 is now at 1.0.8

2016-04-19 Thread Philippe Mouawad

It was changed by me after your remark on license.
i will revert this.
Our version is 1.0.7 which is an Apache license and the readme was ok in
fact

On Tuesday, April 19, 2016, sebb  wrote:

> We seem to have the source from 1.0.7, but the README is now from 1.0.8
>
> It looks as though the license changed from AL2.0 in 1.0.7 to MIT in 1.0.8
>
> So at the moment we have a mixture of the two releases.
> Source is mainly 1.0.7 (I assume) and README/LICENSE from 1.0.8.
>
> This needs to be fixed.
> Either downdate back to 1.0.7 throughout or update to 1.0.8 throughout.
> If the latter, make sure there aren't any other dependency items that
> have changed (license or otherwise)
>


-- 
Cordialement.
Philippe Mouawad.

Re: New website: horizontal scrolling?

2016-04-19 Thread Philippe Mouawad

On Tuesday, April 19, 2016, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

> Am 19.04.2016 um 19:40 schrieb Vladimir Sitnikov:
>
>> Felix>I thought of a social bar at the right side of the content div,
>> where only small buttons are shown for the various social media sides
>> (like twitter, g+ or facebook). A sample of such an implementation
>> could be seen on heise.de.
>>
>> +1
>>
> I have done a simple setup for how it might look like on
> http://internetallee.de/~felix/jmeter/index.html
>
> The links at the bottom are not valid, they will probably have to be
> constructed using javascript.


It looks clean .
Thanks

>
> Felix>The badges for github
>>
>> I think just one github icon is enough, and "number of forks, number
>> of stars" might be just dropped.
>>
>
> The question remains, where that badge should be placed.


I would personally keep:
- fork on github
- the badge showing maven artifacts
The badges are not big so I don't think it hurts

>
> Regards,
>  Felix
>
>>
>> Vladimir
>>
>
>

-- 
Cordialement.
Philippe Mouawad.

Re: New website: horizontal scrolling?

2016-04-19 Thread Vladimir Sitnikov

Felix>I thought of a social bar at the right side of the content div,
where only small buttons are shown for the various social media sides
(like twitter, g+ or facebook). A sample of such an implementation
could be seen on heise.de.

+1

Felix>The badges for github

I think just one github icon is enough, and "number of forks, number
of stars" might be just dropped.

Vladimir

Re: New website: horizontal scrolling?

2016-04-19 Thread Felix Schumacher


Am 17.04.2016 um 15:16 schrieb Milamber:


I will commit my changes to reduce the size of the block.

We can continue to discuss to the better place for the Twitter button 
and/or the github/mc buttons, that isn't a blocker for the 3.0 release.


Perhaps, Felix can purpose later some variants of the home page with 
the buttons at several places to allow to decide the best place.
I thought of a social bar at the right side of the content div, where 
only small buttons are shown for the various social media sides (like 
twitter, g+ or facebook). A sample of such an implementation could be 
seen on heise.de.


The buttons on the top right side are links to the various social media 
sites. If you want to share the page, you will find links to do so at 
the bottom of each content site.


Those positions seem to be decent enough, not to disturb the visitor, 
while prominent enough, to be noticable. (Heise has even started a 
project (https://github.com/heiseonline/shariff) to include these 
buttons in a way that maximises the privacy of the visitor - not 
everyone wants facebook or twitter to know, which pages they have visited.)


The badges for github and co, are another story and I honestly don't 
have a clue, where to put them best.


Regards,
 Felix


(or better: have some web designer works to make a full re-lifting of 
the home page)



On 17/04/2016 13:39, Philippe Mouawad wrote:

+1 for me

On Sun, Apr 17, 2016 at 2:36 PM, Milamber  wrote:


Like this?

http://i.imgur.com/lleLPE6.png




On 17/04/2016 13:12, Philippe Mouawad wrote:


On Sun, Apr 17, 2016 at 1:59 PM, Milamber  wrote:

Perhaps, we can remove the Tweet about the page button (not very 
useful I

thinks), and use the small follow button.

Why not

Remove the Fork number on github (useful?)
I don't share this. For me we need to encourage forking which will 
result

in more contribution.

And move github star and maven central version on the same line.

We did it on purpose to encourage social coding.

The results is:

http://i.imgur.com/L4eXNqp.png

Better? I commit the changes?


-1 except for little tweet button.




On 17/04/2016 12:15, sebb wrote:

Also, I've just noticed the new placement of the Twitter etc links.

Seems to me that these are too prominent.

On 17 April 2016 at 12:04, Milamber  wrote:

Hello,
In the next website (3.0), all pages have a horizontal scrolling 
on my
computer with Firefox or Chrome (and same issue on Windows with 
Edge,

IE,
FF)

On the current website, the horizontal scrolling don't exist. Do 
you

know
why ? (@Felix?)

http://home.apache.org/~milamber/jmeter-3.0RC1/docs/index.html

Thanks

Milamber

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread sebb

On 19 April 2016 at 14:10, Milamber  wrote:
>
>
> On 19/04/2016 01:32, sebb wrote:
>>
>> On 17 April 2016 at 18:03, Milamber  wrote:
>>>
>>> Hello,
>>>
>>> The second release candidate for JMeter 3.0 (r1739623) has been prepared,
>>> and your votes are solicited.
>>>
>>> This release brings a lot of new features (over 100) and fixes many bugs
>>> (60).
>>>
>>> If you can, some tests of this release candidate (load tests and/or
>>> functional tests) with Java 7/8 on Linux/Windows/Mac OS on changes are
>>> welcome.
>>>
>>> You can read the New and Noteworthy section with some screenshots to
>>> illustrate improvements and full list of changes at:
>>> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>>>
>>> JMeter is a Java desktop application designed to load test functional
>>> behavior and measure performance. The current version is targeted at Java
>>> 7+.
>>>
>>> Archives/hashes/sigs:
>>>
>>> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/
>>
>> FTR, the revision is: r13285
>>
>>> RAT report:
>>>
>>>
>>> http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt
>>>
>>> MD5 hashes of archives for this vote:
>>>
>>> 8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz
>>> 0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip
>>> 792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip
>>> 823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz
>>>
>>> Site Docs are here:
>>> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/
>>>
>>> Maven staging repository is accessible here:
>>>
>>> https://repository.apache.org/content/repositories/orgapachejmeter-1007/org/apache/jmeter/
>>>
>>> Tag:
>>> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC2/
>>>
>>> Keys are here:
>>> https://www.apache.org/dist/jmeter/KEYS
>>>
>>> N.B.
>>> To download the dependencies: "ant download_jars"
>>>
>>> To create the jars and test JMeter: "ant package test".
>>>
>>> JMeter 3.0 requires Java 7 or later to run.
>>>
>>> Some known issues and incompatible changes are listed on changes page.
>>> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>>>
>>>
>>> All feedback and vote are welcome.
>>>
>>> [  ] +1  I support this release
>>> [  ] +0  I am OK with this release
>>> [  ] -0   OK, but
>>> [X] -1   I do not support this release (please indicate why)
>>>
>> (binding)
>>
>> Sorry but there are some files missing from the source archive:
>>
>> Only in v3_0_RC2: .gitignore
>> Only in v3_0_RC2: .svn
>> Only in v3_0_RC2: .travis.yml
>> Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7: LICENSE
>> Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap:
>> LICENSE
>> Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap-social:
>> .gitignore
>> Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/datatables-responsive:
>> .gitignore
>> Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
>> .gitignore
>> Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
>> Makefile
>> Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/font-awesome:
>> .gitignore
>> Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
>> .gitattributes
>> Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
>> .gitignore
>> Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs/test:
>> .gitignore
>> Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/metisMenu:
>> LICENSE
>> Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/mocha:
>> LICENSE
>> Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/morrisjs:
>> .gitignore
>> Only in v3_0_RC2: checkstyle-suppressions.xml
>> Only in v3_0_RC2: doap_JMeter.rdf
>> Only in v3_0_RC2/lib: api
>> Only in v3_0_RC2/lib: doc
>> Only in v3_0_RC2/lib: ext
>> Only in v3_0_RC2/lib: junit
>> Only in v3_0_RC2: rat-excludes.txt
>> Only in v3_0_RC2/test: resources
>>
>> The .* files are OK, as is the doap (we ought to move that)
>> Also the lib subdirectories.
>>
>> But the rest ought to be in the source archives, or some should
>> perhaps be dropped from SVN
>
>
> To resume, these files must be in the source archive or dropped from SVN:
>
> Only in
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:Makefile
> Only in v3_0_RC2: checkstyle-suppressions.xml
> Only in v3_0_RC2: rat-excludes.txt
> Only in v3_0_RC2/test: resources
>
>
> I don't know why the Makefile aren't in the source archive? Should be added?
> Please confirm.
>
> I suppose we need to add checkstyle-suppressions.xml, rat-excludes.txt and
> ressources dir into the source archive (I will do this)

Yes.
The source archive should contain everything in SVN.

I've just noticed that we include .gitignore at the top level.

The lower level ones need to be tidied

Re: svn commit: r1739924 - /jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java

2016-04-19 Thread UBIK LOAD PACK Support

But wasn't it non final in previous commit ?

On Tue, Apr 19, 2016 at 4:13 PM, sebb  wrote:

> On 19 April 2016 at 13:54, Felix Schumacher
>  wrote:
> >
> >
> > Am 19. April 2016 14:40:57 MESZ, schrieb s...@apache.org:
> >>Author: sebb
> >>Date: Tue Apr 19 12:40:57 2016
> >>New Revision: 1739924
> >>
> >>URL: http://svn.apache.org/viewvc?rev=1739924=rev
> >>Log:
> >>Field can still be final
> >>
> >>Modified:
> >>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
> >>
> >>Modified:
> >>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
> >>URL:
> >>
> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java?rev=1739924=1739923=1739924=diff
>
> >>==
> >>---
> >>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
> >>(original)
> >>+++
> >>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
> >>Tue Apr 19 12:40:57 2016
> >>@@ -32,10 +32,8 @@ import org.slf4j.helpers.MessageFormatte
> >>  */
> >>public class LogkitLoggerAdapter extends MarkerIgnoringBase implements
> >>Serializable {
> >>
> >>-transient Logger logger;
> >>-/**
> >>- *
> >>- */
> >>+final transient Logger logger;
> >
> > Is this really valid? When an object of This class gets deserialized,
> its transient fields will not be initialized. But they are marked as non
> changing and thus stay in that state.
> >
> > Looks strange to me.
>
> That's one reason why I asked if it needed to be Serializable.
>
> > Felix
> >
> >>+
> >> private static final long serialVersionUID = -122848886791823355L;
> >>
> >> /**
> >>@@ -44,6 +42,7 @@ public class LogkitLoggerAdapter extends
> >> @Deprecated // only for Unit test usage
> >> public LogkitLoggerAdapter() {
> >> super();
> >>+this.logger = null;
> >> }
> >>
> >> LogkitLoggerAdapter(org.apache.log.Logger logkitLogger) {
> >
>



-- 

Regards
Ubik Load Pack  Team
Follow us on Twitter 


Cordialement
L'équipe Ubik Load Pack 
Suivez-nous sur Twitter

Re: svn commit: r1739924 - /jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java

2016-04-19 Thread sebb

On 19 April 2016 at 13:54, Felix Schumacher
 wrote:
>
>
> Am 19. April 2016 14:40:57 MESZ, schrieb s...@apache.org:
>>Author: sebb
>>Date: Tue Apr 19 12:40:57 2016
>>New Revision: 1739924
>>
>>URL: http://svn.apache.org/viewvc?rev=1739924=rev
>>Log:
>>Field can still be final
>>
>>Modified:
>>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
>>
>>Modified:
>>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
>>URL:
>>http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java?rev=1739924=1739923=1739924=diff
>>==
>>---
>>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
>>(original)
>>+++
>>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
>>Tue Apr 19 12:40:57 2016
>>@@ -32,10 +32,8 @@ import org.slf4j.helpers.MessageFormatte
>>  */
>>public class LogkitLoggerAdapter extends MarkerIgnoringBase implements
>>Serializable {
>>
>>-transient Logger logger;
>>-/**
>>- *
>>- */
>>+final transient Logger logger;
>
> Is this really valid? When an object of This class gets deserialized, its 
> transient fields will not be initialized. But they are marked as non changing 
> and thus stay in that state.
>
> Looks strange to me.

That's one reason why I asked if it needed to be Serializable.

> Felix
>
>>+
>> private static final long serialVersionUID = -122848886791823355L;
>>
>> /**
>>@@ -44,6 +42,7 @@ public class LogkitLoggerAdapter extends
>> @Deprecated // only for Unit test usage
>> public LogkitLoggerAdapter() {
>> super();
>>+this.logger = null;
>> }
>>
>> LogkitLoggerAdapter(org.apache.log.Logger logkitLogger) {
>

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread Milamber




On 19/04/2016 01:32, sebb wrote:

On 17 April 2016 at 18:03, Milamber  wrote:

Hello,

The second release candidate for JMeter 3.0 (r1739623) has been prepared,
and your votes are solicited.

This release brings a lot of new features (over 100) and fixes many bugs
(60).

If you can, some tests of this release candidate (load tests and/or
functional tests) with Java 7/8 on Linux/Windows/Mac OS on changes are
welcome.

You can read the New and Noteworthy section with some screenshots to
illustrate improvements and full list of changes at:
http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html

JMeter is a Java desktop application designed to load test functional
behavior and measure performance. The current version is targeted at Java
7+.

Archives/hashes/sigs:

https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/

FTR, the revision is: r13285


RAT report:

http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt

MD5 hashes of archives for this vote:

8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz
0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip
792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip
823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz

Site Docs are here:
http://home.apache.org/~milamber/jmeter-3.0RC2/docs/

Maven staging repository is accessible here:
https://repository.apache.org/content/repositories/orgapachejmeter-1007/org/apache/jmeter/

Tag:
https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC2/

Keys are here:
https://www.apache.org/dist/jmeter/KEYS

N.B.
To download the dependencies: "ant download_jars"

To create the jars and test JMeter: "ant package test".

JMeter 3.0 requires Java 7 or later to run.

Some known issues and incompatible changes are listed on changes page.
http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html


All feedback and vote are welcome.

[  ] +1  I support this release
[  ] +0  I am OK with this release
[  ] -0   OK, but
[X] -1   I do not support this release (please indicate why)


(binding)

Sorry but there are some files missing from the source archive:

Only in v3_0_RC2: .gitignore
Only in v3_0_RC2: .svn
Only in v3_0_RC2: .travis.yml
Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7: LICENSE
Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap:
LICENSE
Only in 
v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap-social:
.gitignore
Only in 
v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/datatables-responsive:
.gitignore
Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
.gitignore
Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
Makefile
Only in 
v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/font-awesome:
.gitignore
Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
.gitattributes
Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
.gitignore
Only in 
v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs/test:
.gitignore
Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/metisMenu:
LICENSE
Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/mocha:
LICENSE
Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/morrisjs:
.gitignore
Only in v3_0_RC2: checkstyle-suppressions.xml
Only in v3_0_RC2: doap_JMeter.rdf
Only in v3_0_RC2/lib: api
Only in v3_0_RC2/lib: doc
Only in v3_0_RC2/lib: ext
Only in v3_0_RC2/lib: junit
Only in v3_0_RC2: rat-excludes.txt
Only in v3_0_RC2/test: resources

The .* files are OK, as is the doap (we ought to move that)
Also the lib subdirectories.

But the rest ought to be in the source archives, or some should
perhaps be dropped from SVN


To resume, these files must be in the source archive or dropped from SVN:

Only in 
v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:Makefile

Only in v3_0_RC2: checkstyle-suppressions.xml
Only in v3_0_RC2: rat-excludes.txt
Only in v3_0_RC2/test: resources


I don't know why the Makefile aren't in the source archive? Should be 
added? Please confirm.


I suppose we need to add checkstyle-suppressions.xml, rat-excludes.txt 
and ressources dir into the source archive (I will do this)



Milamber



Also the source archives don't agree: docs is missing from the zip file

Maybe we don't actually need to store the docs tree in SVN but if we
do it should be in both the source archives.


The vote will remain open for at least 72 hours.

The PMC members please indicate the mention "(binding)" with your vote.


Note: If the vote passes, the intention is to release the archive files
and rename the RC tag as the release tag.

Thanks in advance!

Milamber

Re: svn commit: r1739924 - /jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java

2016-04-19 Thread Felix Schumacher



Am 19. April 2016 14:40:57 MESZ, schrieb s...@apache.org:
>Author: sebb
>Date: Tue Apr 19 12:40:57 2016
>New Revision: 1739924
>
>URL: http://svn.apache.org/viewvc?rev=1739924=rev
>Log:
>Field can still be final
>
>Modified:
>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
>
>Modified:
>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java?rev=1739924=1739923=1739924=diff
>==
>---
>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
>(original)
>+++
>jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
>Tue Apr 19 12:40:57 2016
>@@ -32,10 +32,8 @@ import org.slf4j.helpers.MessageFormatte
>  */
>public class LogkitLoggerAdapter extends MarkerIgnoringBase implements
>Serializable {
> 
>-transient Logger logger;
>-/**
>- * 
>- */
>+final transient Logger logger;

Is this really valid? When an object of This class gets deserialized, its 
transient fields will not be initialized. But they are marked as non changing 
and thus stay in that state. 

Looks strange to me. 

Felix

>+
> private static final long serialVersionUID = -122848886791823355L;
> 
> /**
>@@ -44,6 +42,7 @@ public class LogkitLoggerAdapter extends
> @Deprecated // only for Unit test usage
> public LogkitLoggerAdapter() {
> super();
>+this.logger = null;
> }
> 
> LogkitLoggerAdapter(org.apache.log.Logger logkitLogger) {

sbadmin2 is now at 1.0.8

2016-04-19 Thread sebb

We seem to have the source from 1.0.7, but the README is now from 1.0.8

It looks as though the license changed from AL2.0 in 1.0.7 to MIT in 1.0.8

So at the moment we have a mixture of the two releases.
Source is mainly 1.0.7 (I assume) and README/LICENSE from 1.0.8.

This needs to be fixed.
Either downdate back to 1.0.7 throughout or update to 1.0.8 throughout.
If the latter, make sure there aren't any other dependency items that
have changed (license or otherwise)

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread sebb

Also

bin/report-template/sbadmin2-1.0.7/bower_components/datatables/license.txt
bin/report-template/sbadmin2-1.0.7/bower_components/raphael/license.txt



On 19 April 2016 at 12:54, sebb  wrote:
> On 19 April 2016 at 12:40, Philippe Mouawad  
> wrote:
>> On Tue, Apr 19, 2016 at 12:35 PM, sebb  wrote:
>>
>>> On 19 April 2016 at 11:30, Philippe Mouawad 
>>> wrote:
>>> > On Tue, Apr 19, 2016 at 12:20 PM, sebb  wrote:
>>> >
>>> >> Also the actual file names covered by the licenses need to be mentioned.
>>> >>
>>> >
>>> > Can you be more explicit or do it ?
>>> > I don't understand.
>>> > Is the folder enough ?
>>>
>>> The user must be able to identify all the external files and their
>>> licenses.
>>> In the case of a jar, the jar name is sufficient.
>>>
>>
>> Frankly I think we're one of the project that documents this the most.
>
> That does not mean we should not do it.
>
>> Isn't it too much ? This is really cumbersome as we now have to update for
>> a library upgrade :
>>
>>- LICENSE
>>- licenses/src
> OR
>>- licenses/bin
>>- paths
> paths would have to be done anyway.
>
>
> The point is that downstream consumers must be told what the licenses are.
>
> The alternative would be to put it all in the LICENSE file.
> That makes it very hard to read, and even harder to update especially
> when dropping a dependency.
>
>>
>>
>>
>>>
>>> For source files it depends on how the files are grouped.
>>> I don't know which files are under which license.
>>>
>> I tried to do it  but if it does not suit you feel free to modify
>
> What about the files under
>
> bin/report-template/content?
>
> Are all the files under
> bin/report-template/sbadmin2-1.0.7
>
> really part of sb admin or bootstrap/mocha/metisMenu ?
>
> There seem to be copies of jquery
> What about less?
>
>>>
>>> BTW, it looks as though Start BootStrap is now MIT and the author has
>>> moved to a new company so the README is out of date.
>>>
>>> Fixed.
>>
>>
>>> >>
>>> >> Note that the binary LICENSE section includes the full jar name,
>>> >> including the .jar.
>>> >> The source section needs to do likewise.
>>> >>
>>> >> There may need to be some updates to the unit test to deal with the
>>> >> source licenses.
>>> >>
>>> >> On 19 April 2016 at 11:02, sebb  wrote:
>>> >> > These are *source* files so the licenses belong under license/src.
>>> >> >
>>> >> > Also the final section of the main LICENSE file is intended for
>>> >> > binary-only code.
>>> >> > (It's not all that obvious at present)
>>> >> >
>>> >> > On 19 April 2016 at 07:33, Philippe Mouawad <
>>> philippe.moua...@gmail.com>
>>> >> wrote:
>>> >> >> Hi sebb,
>>> >> >> I filled in in root LICENSE file the license information for the 4
>>> >> >> components.
>>> >> >> Do we need to also add the MIT license in license/bin folder ?
>>> >> >> Thanks
>>> >> >>
>>> >> >> On Tue, Apr 19, 2016 at 3:24 AM, sebb  wrote:
>>> >> >>
>>> >> >>> On 19 April 2016 at 01:32, sebb  wrote:
>>> >> >>> > On 17 April 2016 at 18:03, Milamber  wrote:
>>> >> >>> >> Hello,
>>> >> >>> >>
>>> >> >>> >> The second release candidate for JMeter 3.0 (r1739623) has been
>>> >> >>> prepared,
>>> >> >>> >> and your votes are solicited.
>>> >> >>> >>
>>> >> >>> >> This release brings a lot of new features (over 100) and fixes
>>> many
>>> >> bugs
>>> >> >>> >> (60).
>>> >> >>> >>
>>> >> >>> >> If you can, some tests of this release candidate (load tests
>>> and/or
>>> >> >>> >> functional tests) with Java 7/8 on Linux/Windows/Mac OS on
>>> changes
>>> >> are
>>> >> >>> >> welcome.
>>> >> >>> >>
>>> >> >>> >> You can read the New and Noteworthy section with some
>>> screenshots to
>>> >> >>> >> illustrate improvements and full list of changes at:
>>> >> >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>>> >> >>> >>
>>> >> >>> >> JMeter is a Java desktop application designed to load test
>>> >> functional
>>> >> >>> >> behavior and measure performance. The current version is
>>> targeted at
>>> >> >>> Java
>>> >> >>> >> 7+.
>>> >> >>> >>
>>> >> >>> >> Archives/hashes/sigs:
>>> >> >>> >>
>>> >> >>> >> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/
>>> >> >>> >
>>> >> >>> > FTR, the revision is: r13285
>>> >> >>> >
>>> >> >>> >> RAT report:
>>> >> >>> >>
>>> >> >>> >>
>>> >> >>>
>>> >>
>>> http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt
>>> >> >>> >>
>>> >> >>> >> MD5 hashes of archives for this vote:
>>> >> >>> >>
>>> >> >>> >> 8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz
>>> >> >>> >> 0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip
>>> >> >>> >> 792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip
>>> >> >>> >> 823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz
>>> >> >>> >>
>>> >> >>> >> Site Docs are here:
>>> >> >>> >>

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread sebb

On 19 April 2016 at 12:40, Philippe Mouawad  wrote:
> On Tue, Apr 19, 2016 at 12:35 PM, sebb  wrote:
>
>> On 19 April 2016 at 11:30, Philippe Mouawad 
>> wrote:
>> > On Tue, Apr 19, 2016 at 12:20 PM, sebb  wrote:
>> >
>> >> Also the actual file names covered by the licenses need to be mentioned.
>> >>
>> >
>> > Can you be more explicit or do it ?
>> > I don't understand.
>> > Is the folder enough ?
>>
>> The user must be able to identify all the external files and their
>> licenses.
>> In the case of a jar, the jar name is sufficient.
>>
>
> Frankly I think we're one of the project that documents this the most.

That does not mean we should not do it.

> Isn't it too much ? This is really cumbersome as we now have to update for
> a library upgrade :
>
>- LICENSE
>- licenses/src
OR
>- licenses/bin
>- paths
paths would have to be done anyway.


The point is that downstream consumers must be told what the licenses are.

The alternative would be to put it all in the LICENSE file.
That makes it very hard to read, and even harder to update especially
when dropping a dependency.

>
>
>
>>
>> For source files it depends on how the files are grouped.
>> I don't know which files are under which license.
>>
> I tried to do it  but if it does not suit you feel free to modify

What about the files under

bin/report-template/content?

Are all the files under
bin/report-template/sbadmin2-1.0.7

really part of sb admin or bootstrap/mocha/metisMenu ?

There seem to be copies of jquery
What about less?

>>
>> BTW, it looks as though Start BootStrap is now MIT and the author has
>> moved to a new company so the README is out of date.
>>
>> Fixed.
>
>
>> >>
>> >> Note that the binary LICENSE section includes the full jar name,
>> >> including the .jar.
>> >> The source section needs to do likewise.
>> >>
>> >> There may need to be some updates to the unit test to deal with the
>> >> source licenses.
>> >>
>> >> On 19 April 2016 at 11:02, sebb  wrote:
>> >> > These are *source* files so the licenses belong under license/src.
>> >> >
>> >> > Also the final section of the main LICENSE file is intended for
>> >> > binary-only code.
>> >> > (It's not all that obvious at present)
>> >> >
>> >> > On 19 April 2016 at 07:33, Philippe Mouawad <
>> philippe.moua...@gmail.com>
>> >> wrote:
>> >> >> Hi sebb,
>> >> >> I filled in in root LICENSE file the license information for the 4
>> >> >> components.
>> >> >> Do we need to also add the MIT license in license/bin folder ?
>> >> >> Thanks
>> >> >>
>> >> >> On Tue, Apr 19, 2016 at 3:24 AM, sebb  wrote:
>> >> >>
>> >> >>> On 19 April 2016 at 01:32, sebb  wrote:
>> >> >>> > On 17 April 2016 at 18:03, Milamber  wrote:
>> >> >>> >> Hello,
>> >> >>> >>
>> >> >>> >> The second release candidate for JMeter 3.0 (r1739623) has been
>> >> >>> prepared,
>> >> >>> >> and your votes are solicited.
>> >> >>> >>
>> >> >>> >> This release brings a lot of new features (over 100) and fixes
>> many
>> >> bugs
>> >> >>> >> (60).
>> >> >>> >>
>> >> >>> >> If you can, some tests of this release candidate (load tests
>> and/or
>> >> >>> >> functional tests) with Java 7/8 on Linux/Windows/Mac OS on
>> changes
>> >> are
>> >> >>> >> welcome.
>> >> >>> >>
>> >> >>> >> You can read the New and Noteworthy section with some
>> screenshots to
>> >> >>> >> illustrate improvements and full list of changes at:
>> >> >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>> >> >>> >>
>> >> >>> >> JMeter is a Java desktop application designed to load test
>> >> functional
>> >> >>> >> behavior and measure performance. The current version is
>> targeted at
>> >> >>> Java
>> >> >>> >> 7+.
>> >> >>> >>
>> >> >>> >> Archives/hashes/sigs:
>> >> >>> >>
>> >> >>> >> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/
>> >> >>> >
>> >> >>> > FTR, the revision is: r13285
>> >> >>> >
>> >> >>> >> RAT report:
>> >> >>> >>
>> >> >>> >>
>> >> >>>
>> >>
>> http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt
>> >> >>> >>
>> >> >>> >> MD5 hashes of archives for this vote:
>> >> >>> >>
>> >> >>> >> 8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz
>> >> >>> >> 0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip
>> >> >>> >> 792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip
>> >> >>> >> 823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz
>> >> >>> >>
>> >> >>> >> Site Docs are here:
>> >> >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/
>> >> >>> >>
>> >> >>> >> Maven staging repository is accessible here:
>> >> >>> >>
>> >> >>>
>> >>
>> https://repository.apache.org/content/repositories/orgapachejmeter-1007/org/apache/jmeter/
>> >> >>> >>
>> >> >>> >> Tag:
>> >> >>> >> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC2/
>> >> >>> >>
>> >> >>> >> Keys are here:
>> >>

buildbot success in on jmeter-trunk

2016-04-19 Thread buildbot

The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/1015

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1739906
Blamelist: pmouawad,sebb

Build succeeded!

Sincerely,
 -The Buildbot

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread Philippe Mouawad

On Tue, Apr 19, 2016 at 12:35 PM, sebb  wrote:

> On 19 April 2016 at 11:30, Philippe Mouawad 
> wrote:
> > On Tue, Apr 19, 2016 at 12:20 PM, sebb  wrote:
> >
> >> Also the actual file names covered by the licenses need to be mentioned.
> >>
> >
> > Can you be more explicit or do it ?
> > I don't understand.
> > Is the folder enough ?
>
> The user must be able to identify all the external files and their
> licenses.
> In the case of a jar, the jar name is sufficient.
>

Frankly I think we're one of the project that documents this the most.
Isn't it too much ? This is really cumbersome as we now have to update for
a library upgrade :

   - LICENSE
   - licenses/src
   - licenses/bin
   - paths




>
> For source files it depends on how the files are grouped.
> I don't know which files are under which license.
>
I tried to do it  but if it does not suit you feel free to modify

>
> BTW, it looks as though Start BootStrap is now MIT and the author has
> moved to a new company so the README is out of date.
>
> Fixed.


> >>
> >> Note that the binary LICENSE section includes the full jar name,
> >> including the .jar.
> >> The source section needs to do likewise.
> >>
> >> There may need to be some updates to the unit test to deal with the
> >> source licenses.
> >>
> >> On 19 April 2016 at 11:02, sebb  wrote:
> >> > These are *source* files so the licenses belong under license/src.
> >> >
> >> > Also the final section of the main LICENSE file is intended for
> >> > binary-only code.
> >> > (It's not all that obvious at present)
> >> >
> >> > On 19 April 2016 at 07:33, Philippe Mouawad <
> philippe.moua...@gmail.com>
> >> wrote:
> >> >> Hi sebb,
> >> >> I filled in in root LICENSE file the license information for the 4
> >> >> components.
> >> >> Do we need to also add the MIT license in license/bin folder ?
> >> >> Thanks
> >> >>
> >> >> On Tue, Apr 19, 2016 at 3:24 AM, sebb  wrote:
> >> >>
> >> >>> On 19 April 2016 at 01:32, sebb  wrote:
> >> >>> > On 17 April 2016 at 18:03, Milamber  wrote:
> >> >>> >> Hello,
> >> >>> >>
> >> >>> >> The second release candidate for JMeter 3.0 (r1739623) has been
> >> >>> prepared,
> >> >>> >> and your votes are solicited.
> >> >>> >>
> >> >>> >> This release brings a lot of new features (over 100) and fixes
> many
> >> bugs
> >> >>> >> (60).
> >> >>> >>
> >> >>> >> If you can, some tests of this release candidate (load tests
> and/or
> >> >>> >> functional tests) with Java 7/8 on Linux/Windows/Mac OS on
> changes
> >> are
> >> >>> >> welcome.
> >> >>> >>
> >> >>> >> You can read the New and Noteworthy section with some
> screenshots to
> >> >>> >> illustrate improvements and full list of changes at:
> >> >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
> >> >>> >>
> >> >>> >> JMeter is a Java desktop application designed to load test
> >> functional
> >> >>> >> behavior and measure performance. The current version is
> targeted at
> >> >>> Java
> >> >>> >> 7+.
> >> >>> >>
> >> >>> >> Archives/hashes/sigs:
> >> >>> >>
> >> >>> >> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/
> >> >>> >
> >> >>> > FTR, the revision is: r13285
> >> >>> >
> >> >>> >> RAT report:
> >> >>> >>
> >> >>> >>
> >> >>>
> >>
> http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt
> >> >>> >>
> >> >>> >> MD5 hashes of archives for this vote:
> >> >>> >>
> >> >>> >> 8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz
> >> >>> >> 0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip
> >> >>> >> 792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip
> >> >>> >> 823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz
> >> >>> >>
> >> >>> >> Site Docs are here:
> >> >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/
> >> >>> >>
> >> >>> >> Maven staging repository is accessible here:
> >> >>> >>
> >> >>>
> >>
> https://repository.apache.org/content/repositories/orgapachejmeter-1007/org/apache/jmeter/
> >> >>> >>
> >> >>> >> Tag:
> >> >>> >> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC2/
> >> >>> >>
> >> >>> >> Keys are here:
> >> >>> >> https://www.apache.org/dist/jmeter/KEYS
> >> >>> >>
> >> >>> >> N.B.
> >> >>> >> To download the dependencies: "ant download_jars"
> >> >>> >>
> >> >>> >> To create the jars and test JMeter: "ant package test".
> >> >>> >>
> >> >>> >> JMeter 3.0 requires Java 7 or later to run.
> >> >>> >>
> >> >>> >> Some known issues and incompatible changes are listed on changes
> >> page.
> >> >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
> >> >>> >>
> >> >>> >>
> >> >>> >> All feedback and vote are welcome.
> >> >>> >>
> >> >>> >> [  ] +1  I support this release
> >> >>> >> [  ] +0  I am OK with this release
> >> >>> >> [  ] -0   OK, but
> >> >>> >> [X] -1   I do not support this release (please indicate why)
> >> >>> >>
> >> >>> >

Re: Why does LogkitLoggerAdapter implement Serializable?

2016-04-19 Thread Philippe Mouawad

Fixed by:
http://svn.apache.org/viewvc?rev=1739903=rev

On Tue, Apr 19, 2016 at 12:16 PM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Hi Sebb,
> The ancestor is Serializable.
> Existing implementations for other log frameworks are Serializable so I
> would say yes.
>
>
>
> Regards
>
> On Tue, Apr 19, 2016 at 11:58 AM, sebb  wrote:
>
>> PING - I think we need to resolve this before the re-release
>>
>> On 2 April 2016 at 13:59, sebb  wrote:
>> > Anyone?
>> >
>> > Code was added by Philippe as part of Bugzilla Id: 59240
>> >
>> >
>> > On 1 April 2016 at 00:29, sebb  wrote:
>> >> Is there any need to serialise this class?
>> >>
>> >> If not, it should not implement the interface.
>> >> If so, it needs a dummy ctor to allow unit tests to work
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>


-- 
Cordialement.
Philippe Mouawad.

Jenkins build is back to normal : JMeter-trunk #5207

2016-04-19 Thread Apache Jenkins Server

See

LICENSE ought to contain locations of the icons

2016-04-19 Thread sebb

The LICENSE file ought to contain the location(s) of the Open Icon library icons

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread sebb

On 19 April 2016 at 11:30, Philippe Mouawad  wrote:
> On Tue, Apr 19, 2016 at 12:20 PM, sebb  wrote:
>
>> Also the actual file names covered by the licenses need to be mentioned.
>>
>
> Can you be more explicit or do it ?
> I don't understand.
> Is the folder enough ?

The user must be able to identify all the external files and their licenses.
In the case of a jar, the jar name is sufficient.

For source files it depends on how the files are grouped.
I don't know which files are under which license.

BTW, it looks as though Start BootStrap is now MIT and the author has
moved to a new company so the README is out of date.

>>
>> Note that the binary LICENSE section includes the full jar name,
>> including the .jar.
>> The source section needs to do likewise.
>>
>> There may need to be some updates to the unit test to deal with the
>> source licenses.
>>
>> On 19 April 2016 at 11:02, sebb  wrote:
>> > These are *source* files so the licenses belong under license/src.
>> >
>> > Also the final section of the main LICENSE file is intended for
>> > binary-only code.
>> > (It's not all that obvious at present)
>> >
>> > On 19 April 2016 at 07:33, Philippe Mouawad 
>> wrote:
>> >> Hi sebb,
>> >> I filled in in root LICENSE file the license information for the 4
>> >> components.
>> >> Do we need to also add the MIT license in license/bin folder ?
>> >> Thanks
>> >>
>> >> On Tue, Apr 19, 2016 at 3:24 AM, sebb  wrote:
>> >>
>> >>> On 19 April 2016 at 01:32, sebb  wrote:
>> >>> > On 17 April 2016 at 18:03, Milamber  wrote:
>> >>> >> Hello,
>> >>> >>
>> >>> >> The second release candidate for JMeter 3.0 (r1739623) has been
>> >>> prepared,
>> >>> >> and your votes are solicited.
>> >>> >>
>> >>> >> This release brings a lot of new features (over 100) and fixes many
>> bugs
>> >>> >> (60).
>> >>> >>
>> >>> >> If you can, some tests of this release candidate (load tests and/or
>> >>> >> functional tests) with Java 7/8 on Linux/Windows/Mac OS on changes
>> are
>> >>> >> welcome.
>> >>> >>
>> >>> >> You can read the New and Noteworthy section with some screenshots to
>> >>> >> illustrate improvements and full list of changes at:
>> >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>> >>> >>
>> >>> >> JMeter is a Java desktop application designed to load test
>> functional
>> >>> >> behavior and measure performance. The current version is targeted at
>> >>> Java
>> >>> >> 7+.
>> >>> >>
>> >>> >> Archives/hashes/sigs:
>> >>> >>
>> >>> >> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/
>> >>> >
>> >>> > FTR, the revision is: r13285
>> >>> >
>> >>> >> RAT report:
>> >>> >>
>> >>> >>
>> >>>
>> http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt
>> >>> >>
>> >>> >> MD5 hashes of archives for this vote:
>> >>> >>
>> >>> >> 8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz
>> >>> >> 0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip
>> >>> >> 792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip
>> >>> >> 823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz
>> >>> >>
>> >>> >> Site Docs are here:
>> >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/
>> >>> >>
>> >>> >> Maven staging repository is accessible here:
>> >>> >>
>> >>>
>> https://repository.apache.org/content/repositories/orgapachejmeter-1007/org/apache/jmeter/
>> >>> >>
>> >>> >> Tag:
>> >>> >> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC2/
>> >>> >>
>> >>> >> Keys are here:
>> >>> >> https://www.apache.org/dist/jmeter/KEYS
>> >>> >>
>> >>> >> N.B.
>> >>> >> To download the dependencies: "ant download_jars"
>> >>> >>
>> >>> >> To create the jars and test JMeter: "ant package test".
>> >>> >>
>> >>> >> JMeter 3.0 requires Java 7 or later to run.
>> >>> >>
>> >>> >> Some known issues and incompatible changes are listed on changes
>> page.
>> >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>> >>> >>
>> >>> >>
>> >>> >> All feedback and vote are welcome.
>> >>> >>
>> >>> >> [  ] +1  I support this release
>> >>> >> [  ] +0  I am OK with this release
>> >>> >> [  ] -0   OK, but
>> >>> >> [X] -1   I do not support this release (please indicate why)
>> >>> >>
>> >>> >
>> >>> > (binding)
>> >>> >
>> >>> > Sorry but there are some files missing from the source archive:
>> >>> >
>> >>> > Only in v3_0_RC2: .gitignore
>> >>> > Only in v3_0_RC2: .svn
>> >>> > Only in v3_0_RC2: .travis.yml
>> >>> > Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7: LICENSE
>> >>> > Only in
>> >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap:
>> >>> > LICENSE
>> >>> > Only in
>> >>>
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap-social:
>> >>> > .gitignore
>> >>> > Only in
>> >>>
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/datatables-responsive:
>> >>>

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread Philippe Mouawad

On Tue, Apr 19, 2016 at 12:20 PM, sebb  wrote:

> Also the actual file names covered by the licenses need to be mentioned.
>

Can you be more explicit or do it ?
I don't understand.
Is the folder enough ?

>
> Note that the binary LICENSE section includes the full jar name,
> including the .jar.
> The source section needs to do likewise.
>
> There may need to be some updates to the unit test to deal with the
> source licenses.
>
> On 19 April 2016 at 11:02, sebb  wrote:
> > These are *source* files so the licenses belong under license/src.
> >
> > Also the final section of the main LICENSE file is intended for
> > binary-only code.
> > (It's not all that obvious at present)
> >
> > On 19 April 2016 at 07:33, Philippe Mouawad 
> wrote:
> >> Hi sebb,
> >> I filled in in root LICENSE file the license information for the 4
> >> components.
> >> Do we need to also add the MIT license in license/bin folder ?
> >> Thanks
> >>
> >> On Tue, Apr 19, 2016 at 3:24 AM, sebb  wrote:
> >>
> >>> On 19 April 2016 at 01:32, sebb  wrote:
> >>> > On 17 April 2016 at 18:03, Milamber  wrote:
> >>> >> Hello,
> >>> >>
> >>> >> The second release candidate for JMeter 3.0 (r1739623) has been
> >>> prepared,
> >>> >> and your votes are solicited.
> >>> >>
> >>> >> This release brings a lot of new features (over 100) and fixes many
> bugs
> >>> >> (60).
> >>> >>
> >>> >> If you can, some tests of this release candidate (load tests and/or
> >>> >> functional tests) with Java 7/8 on Linux/Windows/Mac OS on changes
> are
> >>> >> welcome.
> >>> >>
> >>> >> You can read the New and Noteworthy section with some screenshots to
> >>> >> illustrate improvements and full list of changes at:
> >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
> >>> >>
> >>> >> JMeter is a Java desktop application designed to load test
> functional
> >>> >> behavior and measure performance. The current version is targeted at
> >>> Java
> >>> >> 7+.
> >>> >>
> >>> >> Archives/hashes/sigs:
> >>> >>
> >>> >> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/
> >>> >
> >>> > FTR, the revision is: r13285
> >>> >
> >>> >> RAT report:
> >>> >>
> >>> >>
> >>>
> http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt
> >>> >>
> >>> >> MD5 hashes of archives for this vote:
> >>> >>
> >>> >> 8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz
> >>> >> 0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip
> >>> >> 792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip
> >>> >> 823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz
> >>> >>
> >>> >> Site Docs are here:
> >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/
> >>> >>
> >>> >> Maven staging repository is accessible here:
> >>> >>
> >>>
> https://repository.apache.org/content/repositories/orgapachejmeter-1007/org/apache/jmeter/
> >>> >>
> >>> >> Tag:
> >>> >> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC2/
> >>> >>
> >>> >> Keys are here:
> >>> >> https://www.apache.org/dist/jmeter/KEYS
> >>> >>
> >>> >> N.B.
> >>> >> To download the dependencies: "ant download_jars"
> >>> >>
> >>> >> To create the jars and test JMeter: "ant package test".
> >>> >>
> >>> >> JMeter 3.0 requires Java 7 or later to run.
> >>> >>
> >>> >> Some known issues and incompatible changes are listed on changes
> page.
> >>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
> >>> >>
> >>> >>
> >>> >> All feedback and vote are welcome.
> >>> >>
> >>> >> [  ] +1  I support this release
> >>> >> [  ] +0  I am OK with this release
> >>> >> [  ] -0   OK, but
> >>> >> [X] -1   I do not support this release (please indicate why)
> >>> >>
> >>> >
> >>> > (binding)
> >>> >
> >>> > Sorry but there are some files missing from the source archive:
> >>> >
> >>> > Only in v3_0_RC2: .gitignore
> >>> > Only in v3_0_RC2: .svn
> >>> > Only in v3_0_RC2: .travis.yml
> >>> > Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7: LICENSE
> >>> > Only in
> >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap:
> >>> > LICENSE
> >>> > Only in
> >>>
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap-social:
> >>> > .gitignore
> >>> > Only in
> >>>
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/datatables-responsive:
> >>> > .gitignore
> >>> > Only in
> >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
> >>> > .gitignore
> >>> > Only in
> >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
> >>> > Makefile
> >>> > Only in
> >>>
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/font-awesome:
> >>> > .gitignore
> >>> > Only in
> >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
> >>> > .gitattributes
> >>> > Only in
> >>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
> >>> > .gitignore
>

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread sebb

Also the actual file names covered by the licenses need to be mentioned.

Note that the binary LICENSE section includes the full jar name,
including the .jar.
The source section needs to do likewise.

There may need to be some updates to the unit test to deal with the
source licenses.

On 19 April 2016 at 11:02, sebb  wrote:
> These are *source* files so the licenses belong under license/src.
>
> Also the final section of the main LICENSE file is intended for
> binary-only code.
> (It's not all that obvious at present)
>
> On 19 April 2016 at 07:33, Philippe Mouawad  
> wrote:
>> Hi sebb,
>> I filled in in root LICENSE file the license information for the 4
>> components.
>> Do we need to also add the MIT license in license/bin folder ?
>> Thanks
>>
>> On Tue, Apr 19, 2016 at 3:24 AM, sebb  wrote:
>>
>>> On 19 April 2016 at 01:32, sebb  wrote:
>>> > On 17 April 2016 at 18:03, Milamber  wrote:
>>> >> Hello,
>>> >>
>>> >> The second release candidate for JMeter 3.0 (r1739623) has been
>>> prepared,
>>> >> and your votes are solicited.
>>> >>
>>> >> This release brings a lot of new features (over 100) and fixes many bugs
>>> >> (60).
>>> >>
>>> >> If you can, some tests of this release candidate (load tests and/or
>>> >> functional tests) with Java 7/8 on Linux/Windows/Mac OS on changes are
>>> >> welcome.
>>> >>
>>> >> You can read the New and Noteworthy section with some screenshots to
>>> >> illustrate improvements and full list of changes at:
>>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>>> >>
>>> >> JMeter is a Java desktop application designed to load test functional
>>> >> behavior and measure performance. The current version is targeted at
>>> Java
>>> >> 7+.
>>> >>
>>> >> Archives/hashes/sigs:
>>> >>
>>> >> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/
>>> >
>>> > FTR, the revision is: r13285
>>> >
>>> >> RAT report:
>>> >>
>>> >>
>>> http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt
>>> >>
>>> >> MD5 hashes of archives for this vote:
>>> >>
>>> >> 8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz
>>> >> 0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip
>>> >> 792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip
>>> >> 823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz
>>> >>
>>> >> Site Docs are here:
>>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/
>>> >>
>>> >> Maven staging repository is accessible here:
>>> >>
>>> https://repository.apache.org/content/repositories/orgapachejmeter-1007/org/apache/jmeter/
>>> >>
>>> >> Tag:
>>> >> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC2/
>>> >>
>>> >> Keys are here:
>>> >> https://www.apache.org/dist/jmeter/KEYS
>>> >>
>>> >> N.B.
>>> >> To download the dependencies: "ant download_jars"
>>> >>
>>> >> To create the jars and test JMeter: "ant package test".
>>> >>
>>> >> JMeter 3.0 requires Java 7 or later to run.
>>> >>
>>> >> Some known issues and incompatible changes are listed on changes page.
>>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>>> >>
>>> >>
>>> >> All feedback and vote are welcome.
>>> >>
>>> >> [  ] +1  I support this release
>>> >> [  ] +0  I am OK with this release
>>> >> [  ] -0   OK, but
>>> >> [X] -1   I do not support this release (please indicate why)
>>> >>
>>> >
>>> > (binding)
>>> >
>>> > Sorry but there are some files missing from the source archive:
>>> >
>>> > Only in v3_0_RC2: .gitignore
>>> > Only in v3_0_RC2: .svn
>>> > Only in v3_0_RC2: .travis.yml
>>> > Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7: LICENSE
>>> > Only in
>>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap:
>>> > LICENSE
>>> > Only in
>>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap-social:
>>> > .gitignore
>>> > Only in
>>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/datatables-responsive:
>>> > .gitignore
>>> > Only in
>>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
>>> > .gitignore
>>> > Only in
>>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
>>> > Makefile
>>> > Only in
>>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/font-awesome:
>>> > .gitignore
>>> > Only in
>>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
>>> > .gitattributes
>>> > Only in
>>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
>>> > .gitignore
>>> > Only in
>>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs/test:
>>> > .gitignore
>>> > Only in
>>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/metisMenu:
>>> > LICENSE
>>> > Only in
>>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/mocha:
>>> > LICENSE
>>> > Only in
>>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/morrisjs:
>>> > .gitignore
>>> >

Re: Why does LogkitLoggerAdapter implement Serializable?

2016-04-19 Thread Philippe Mouawad

Hi Sebb,
The ancestor is Serializable.
Existing implementations for other log frameworks are Serializable so I
would say yes.



Regards

On Tue, Apr 19, 2016 at 11:58 AM, sebb  wrote:

> PING - I think we need to resolve this before the re-release
>
> On 2 April 2016 at 13:59, sebb  wrote:
> > Anyone?
> >
> > Code was added by Philippe as part of Bugzilla Id: 59240
> >
> >
> > On 1 April 2016 at 00:29, sebb  wrote:
> >> Is there any need to serialise this class?
> >>
> >> If not, it should not implement the interface.
> >> If so, it needs a dummy ctor to allow unit tests to work
>



-- 
Cordialement.
Philippe Mouawad.

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread sebb

These are *source* files so the licenses belong under license/src.

Also the final section of the main LICENSE file is intended for
binary-only code.
(It's not all that obvious at present)

On 19 April 2016 at 07:33, Philippe Mouawad  wrote:
> Hi sebb,
> I filled in in root LICENSE file the license information for the 4
> components.
> Do we need to also add the MIT license in license/bin folder ?
> Thanks
>
> On Tue, Apr 19, 2016 at 3:24 AM, sebb  wrote:
>
>> On 19 April 2016 at 01:32, sebb  wrote:
>> > On 17 April 2016 at 18:03, Milamber  wrote:
>> >> Hello,
>> >>
>> >> The second release candidate for JMeter 3.0 (r1739623) has been
>> prepared,
>> >> and your votes are solicited.
>> >>
>> >> This release brings a lot of new features (over 100) and fixes many bugs
>> >> (60).
>> >>
>> >> If you can, some tests of this release candidate (load tests and/or
>> >> functional tests) with Java 7/8 on Linux/Windows/Mac OS on changes are
>> >> welcome.
>> >>
>> >> You can read the New and Noteworthy section with some screenshots to
>> >> illustrate improvements and full list of changes at:
>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>> >>
>> >> JMeter is a Java desktop application designed to load test functional
>> >> behavior and measure performance. The current version is targeted at
>> Java
>> >> 7+.
>> >>
>> >> Archives/hashes/sigs:
>> >>
>> >> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/
>> >
>> > FTR, the revision is: r13285
>> >
>> >> RAT report:
>> >>
>> >>
>> http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt
>> >>
>> >> MD5 hashes of archives for this vote:
>> >>
>> >> 8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz
>> >> 0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip
>> >> 792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip
>> >> 823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz
>> >>
>> >> Site Docs are here:
>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/
>> >>
>> >> Maven staging repository is accessible here:
>> >>
>> https://repository.apache.org/content/repositories/orgapachejmeter-1007/org/apache/jmeter/
>> >>
>> >> Tag:
>> >> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC2/
>> >>
>> >> Keys are here:
>> >> https://www.apache.org/dist/jmeter/KEYS
>> >>
>> >> N.B.
>> >> To download the dependencies: "ant download_jars"
>> >>
>> >> To create the jars and test JMeter: "ant package test".
>> >>
>> >> JMeter 3.0 requires Java 7 or later to run.
>> >>
>> >> Some known issues and incompatible changes are listed on changes page.
>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>> >>
>> >>
>> >> All feedback and vote are welcome.
>> >>
>> >> [  ] +1  I support this release
>> >> [  ] +0  I am OK with this release
>> >> [  ] -0   OK, but
>> >> [X] -1   I do not support this release (please indicate why)
>> >>
>> >
>> > (binding)
>> >
>> > Sorry but there are some files missing from the source archive:
>> >
>> > Only in v3_0_RC2: .gitignore
>> > Only in v3_0_RC2: .svn
>> > Only in v3_0_RC2: .travis.yml
>> > Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7: LICENSE
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap:
>> > LICENSE
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap-social:
>> > .gitignore
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/datatables-responsive:
>> > .gitignore
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
>> > .gitignore
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
>> > Makefile
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/font-awesome:
>> > .gitignore
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
>> > .gitattributes
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
>> > .gitignore
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs/test:
>> > .gitignore
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/metisMenu:
>> > LICENSE
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/mocha:
>> > LICENSE
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/morrisjs:
>> > .gitignore
>> > Only in v3_0_RC2: checkstyle-suppressions.xml
>> > Only in v3_0_RC2: doap_JMeter.rdf
>> > Only in v3_0_RC2/lib: api
>> > Only in v3_0_RC2/lib: doc
>> > Only in v3_0_RC2/lib: ext
>> > Only in v3_0_RC2/lib: junit
>> > Only in v3_0_RC2: rat-excludes.txt
>> > Only in v3_0_RC2/test: resources
>> >
>> > The .* files are OK, as is the doap (we ought to move that)
>> > Also the lib subdirectories.
>> >
>> > But the rest ought to be in the source archives, or some should
>> > perhaps be

Build failed in Jenkins: JMeter-trunk #5206

2016-04-19 Thread Apache Jenkins Server

See 

Changes:

[sebb] Fix MacOSX doc icon

--
[...truncated 1311 lines...]
  [javadoc] Loading source files for package org.apache.jmeter.gui.action...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.template...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.validation...
  [javadoc] Loading source files for package org.apache.jmeter.gui.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.gui.tree...
  [javadoc] Loading source files for package org.apache.jmeter.gui.util...
  [javadoc] Loading source files for package org.apache.jmeter.logging...
  [javadoc] Loading source files for package org.apache.jmeter.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.processor...
  [javadoc] Loading source files for package org.apache.jmeter.processor.gui...
  [javadoc] Loading source files for package org.apache.jmeter.report.config...
  [javadoc] Loading source files for package org.apache.jmeter.report.core...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.dashboard...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph.impl...
  [javadoc] Loading source files for package org.apache.jmeter.reporters...
  [javadoc] Loading source files for package org.apache.jmeter.reporters.gui...
  [javadoc] Loading source files for package org.apache.jmeter.samplers...
  [javadoc] Loading source files for package org.apache.jmeter.samplers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.save...
  [javadoc] Loading source files for package 
org.apache.jmeter.save.converters...
  [javadoc] Loading source files for package org.apache.jmeter.services...
  [javadoc] Loading source files for package org.apache.jmeter.swing...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans.gui...
  [javadoc] Loading source files for package org.apache.jmeter.testelement...
  [javadoc] Loading source files for package 
org.apache.jmeter.testelement.property...
  [javadoc] Loading source files for package org.apache.jmeter.threads...
  [javadoc] Loading source files for package org.apache.jmeter.threads.gui...
  [javadoc] Loading source files for package org.apache.jmeter.timers...
  [javadoc] Loading source files for package org.apache.jmeter.timers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.util...
  [javadoc] Loading source files for package org.apache.jmeter.util.keystore...
  [javadoc] Loading source files for package org.apache.jmeter.visualizers...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.extractor...
  [javadoc] Loading source files for package org.apache.jmeter.extractor.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.extractor.json.jsonpath...
  [javadoc] Loading source files for package 
org.apache.jmeter.extractor.json.jsonpath.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.extractor.json.render...
  [javadoc] Loading source files for package org.apache.jmeter.modifiers...
  [javadoc] Loading source files for package org.apache.jmeter.modifiers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.sampler...
  [javadoc] Loading source files for package org.apache.jmeter.sampler.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend.graphite...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.utils...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.control...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.modifier...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.modifier.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.parser...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.proxy...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.proxy.gui...
  [javadoc] Loading source files for package

Re: Why does LogkitLoggerAdapter implement Serializable?

2016-04-19 Thread sebb

PING - I think we need to resolve this before the re-release

On 2 April 2016 at 13:59, sebb  wrote:
> Anyone?
>
> Code was added by Philippe as part of Bugzilla Id: 59240
>
>
> On 1 April 2016 at 00:29, sebb  wrote:
>> Is there any need to serialise this class?
>>
>> If not, it should not implement the interface.
>> If so, it needs a dummy ctor to allow unit tests to work

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread Antonio Gomes Rodrigues

Hi,

The build failed with "[java] java.lang.AssertionError: LICENSE does not
contain entry for bootstrap-3.3.4" error message.

My PR don't modify any licence.
Build is it broken?
Do I need to do something?

Thank
Antonio


2016-04-19 9:19 GMT+02:00 Antonio Gomes Rodrigues :

> Hi,
>
> I propose to modify a little changes.html to be more clear about
> deprecated elements.
> I have add Spline Visualizer listener and Distribution Graph listener
> which are not mentioned in changes.xml
>
> See https://bz.apache.org/bugzilla/show_bug.cgi?id=59353 with the
> associated PR
>
> Antonio
>
>
> 2016-04-19 8:39 GMT+02:00 Philippe Mouawad :
>
>> I moved and renamed the license files mentioned by sebb
>>
>> @milamber I let you manage the other problems.
>> Regards
>>
>>
>> On Tue, Apr 19, 2016 at 8:33 AM, Philippe Mouawad <
>> philippe.moua...@gmail.com> wrote:
>>
>> > Hi sebb,
>> > I filled in in root LICENSE file the license information for the 4
>> > components.
>> > Do we need to also add the MIT license in license/bin folder ?
>> > Thanks
>> >
>> > On Tue, Apr 19, 2016 at 3:24 AM, sebb  wrote:
>> >
>> >> On 19 April 2016 at 01:32, sebb  wrote:
>> >> > On 17 April 2016 at 18:03, Milamber  wrote:
>> >> >> Hello,
>> >> >>
>> >> >> The second release candidate for JMeter 3.0 (r1739623) has been
>> >> prepared,
>> >> >> and your votes are solicited.
>> >> >>
>> >> >> This release brings a lot of new features (over 100) and fixes many
>> >> bugs
>> >> >> (60).
>> >> >>
>> >> >> If you can, some tests of this release candidate (load tests and/or
>> >> >> functional tests) with Java 7/8 on Linux/Windows/Mac OS on changes
>> are
>> >> >> welcome.
>> >> >>
>> >> >> You can read the New and Noteworthy section with some screenshots to
>> >> >> illustrate improvements and full list of changes at:
>> >> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>> >> >>
>> >> >> JMeter is a Java desktop application designed to load test
>> functional
>> >> >> behavior and measure performance. The current version is targeted at
>> >> Java
>> >> >> 7+.
>> >> >>
>> >> >> Archives/hashes/sigs:
>> >> >>
>> >> >> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/
>> >> >
>> >> > FTR, the revision is: r13285
>> >> >
>> >> >> RAT report:
>> >> >>
>> >> >>
>> >>
>> http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt
>> >> >>
>> >> >> MD5 hashes of archives for this vote:
>> >> >>
>> >> >> 8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz
>> >> >> 0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip
>> >> >> 792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip
>> >> >> 823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz
>> >> >>
>> >> >> Site Docs are here:
>> >> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/
>> >> >>
>> >> >> Maven staging repository is accessible here:
>> >> >>
>> >>
>> https://repository.apache.org/content/repositories/orgapachejmeter-1007/org/apache/jmeter/
>> >> >>
>> >> >> Tag:
>> >> >> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC2/
>> >> >>
>> >> >> Keys are here:
>> >> >> https://www.apache.org/dist/jmeter/KEYS
>> >> >>
>> >> >> N.B.
>> >> >> To download the dependencies: "ant download_jars"
>> >> >>
>> >> >> To create the jars and test JMeter: "ant package test".
>> >> >>
>> >> >> JMeter 3.0 requires Java 7 or later to run.
>> >> >>
>> >> >> Some known issues and incompatible changes are listed on changes
>> page.
>> >> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>> >> >>
>> >> >>
>> >> >> All feedback and vote are welcome.
>> >> >>
>> >> >> [  ] +1  I support this release
>> >> >> [  ] +0  I am OK with this release
>> >> >> [  ] -0   OK, but
>> >> >> [X] -1   I do not support this release (please indicate why)
>> >> >>
>> >> >
>> >> > (binding)
>> >> >
>> >> > Sorry but there are some files missing from the source archive:
>> >> >
>> >> > Only in v3_0_RC2: .gitignore
>> >> > Only in v3_0_RC2: .svn
>> >> > Only in v3_0_RC2: .travis.yml
>> >> > Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7: LICENSE
>> >> > Only in
>> >> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap:
>> >> > LICENSE
>> >> > Only in
>> >>
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap-social:
>> >> > .gitignore
>> >> > Only in
>> >>
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/datatables-responsive:
>> >> > .gitignore
>> >> > Only in
>> >> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
>> >> > .gitignore
>> >> > Only in
>> >> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
>> >> > Makefile
>> >> > Only in
>> >>
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/font-awesome:
>> >> > .gitignore
>> >> > Only in
>> >> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
>> >> > .gitattributes

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread Antonio Gomes Rodrigues

Hi,

I propose to modify a little changes.html to be more clear about deprecated
elements.
I have add Spline Visualizer listener and Distribution Graph listener which
are not mentioned in changes.xml

See https://bz.apache.org/bugzilla/show_bug.cgi?id=59353 with the
associated PR

Antonio


2016-04-19 8:39 GMT+02:00 Philippe Mouawad :

> I moved and renamed the license files mentioned by sebb
>
> @milamber I let you manage the other problems.
> Regards
>
>
> On Tue, Apr 19, 2016 at 8:33 AM, Philippe Mouawad <
> philippe.moua...@gmail.com> wrote:
>
> > Hi sebb,
> > I filled in in root LICENSE file the license information for the 4
> > components.
> > Do we need to also add the MIT license in license/bin folder ?
> > Thanks
> >
> > On Tue, Apr 19, 2016 at 3:24 AM, sebb  wrote:
> >
> >> On 19 April 2016 at 01:32, sebb  wrote:
> >> > On 17 April 2016 at 18:03, Milamber  wrote:
> >> >> Hello,
> >> >>
> >> >> The second release candidate for JMeter 3.0 (r1739623) has been
> >> prepared,
> >> >> and your votes are solicited.
> >> >>
> >> >> This release brings a lot of new features (over 100) and fixes many
> >> bugs
> >> >> (60).
> >> >>
> >> >> If you can, some tests of this release candidate (load tests and/or
> >> >> functional tests) with Java 7/8 on Linux/Windows/Mac OS on changes
> are
> >> >> welcome.
> >> >>
> >> >> You can read the New and Noteworthy section with some screenshots to
> >> >> illustrate improvements and full list of changes at:
> >> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
> >> >>
> >> >> JMeter is a Java desktop application designed to load test functional
> >> >> behavior and measure performance. The current version is targeted at
> >> Java
> >> >> 7+.
> >> >>
> >> >> Archives/hashes/sigs:
> >> >>
> >> >> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/
> >> >
> >> > FTR, the revision is: r13285
> >> >
> >> >> RAT report:
> >> >>
> >> >>
> >>
> http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt
> >> >>
> >> >> MD5 hashes of archives for this vote:
> >> >>
> >> >> 8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz
> >> >> 0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip
> >> >> 792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip
> >> >> 823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz
> >> >>
> >> >> Site Docs are here:
> >> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/
> >> >>
> >> >> Maven staging repository is accessible here:
> >> >>
> >>
> https://repository.apache.org/content/repositories/orgapachejmeter-1007/org/apache/jmeter/
> >> >>
> >> >> Tag:
> >> >> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC2/
> >> >>
> >> >> Keys are here:
> >> >> https://www.apache.org/dist/jmeter/KEYS
> >> >>
> >> >> N.B.
> >> >> To download the dependencies: "ant download_jars"
> >> >>
> >> >> To create the jars and test JMeter: "ant package test".
> >> >>
> >> >> JMeter 3.0 requires Java 7 or later to run.
> >> >>
> >> >> Some known issues and incompatible changes are listed on changes
> page.
> >> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
> >> >>
> >> >>
> >> >> All feedback and vote are welcome.
> >> >>
> >> >> [  ] +1  I support this release
> >> >> [  ] +0  I am OK with this release
> >> >> [  ] -0   OK, but
> >> >> [X] -1   I do not support this release (please indicate why)
> >> >>
> >> >
> >> > (binding)
> >> >
> >> > Sorry but there are some files missing from the source archive:
> >> >
> >> > Only in v3_0_RC2: .gitignore
> >> > Only in v3_0_RC2: .svn
> >> > Only in v3_0_RC2: .travis.yml
> >> > Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7: LICENSE
> >> > Only in
> >> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap:
> >> > LICENSE
> >> > Only in
> >>
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap-social:
> >> > .gitignore
> >> > Only in
> >>
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/datatables-responsive:
> >> > .gitignore
> >> > Only in
> >> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
> >> > .gitignore
> >> > Only in
> >> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
> >> > Makefile
> >> > Only in
> >>
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/font-awesome:
> >> > .gitignore
> >> > Only in
> >> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
> >> > .gitattributes
> >> > Only in
> >> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
> >> > .gitignore
> >> > Only in
> >>
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs/test:
> >> > .gitignore
> >> > Only in
> >> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/metisMenu:
> >> > LICENSE
> >> > Only in
> >> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/mocha:
> >> > LICENSE
> >> > Only in
>

[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html

2016-04-19 Thread ra0077

GitHub user ra0077 opened a pull request:

https://github.com/apache/jmeter/pull/203

Bug59353_NewPartInChanges.html

Hi,

I propose to have a dedicated part called "Deprecated and removed
elements" in "Incompatible changes" part in changes.xml

Like that it will be more visible for user

I have add Spline Visualizer listener and Distribution Graph listener
which are not mentioned in changes.xml

Antonio

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ra0077/jmeter Bug59353_NewPartInChanges.html

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #203


commit c212b3eb1d507374de24a2715315c8cf381a8fca
Author: ra0077 
Date:   2016-04-19T07:16:09Z

Bug59353_NewPartInChanges.html

Hi,

I propose to have a dedicated part called "Deprecated and removed
elements" in "Incompatible changes" part in changes.xml

Like that it will be more visible for user

I have add Spline Visualizer listener and Distribution Graph listener
which are not mentioned in changes.xml

Antonio




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: JMeter-trunk #5205

2016-04-19 Thread Apache Jenkins Server

See 

Changes:

[pmouawad] Bug 59350 - Add a space after "Writing log file to:" log message
Contributed by Antonio Gomes Rodrigues
#resolve #201
Bugzilla Id: 59350

[pmouawad] Bug 59345 - SMTPSampler connection leak 
#resolve #198
Bugzilla Id: 59345

[pmouawad] Remove start-bootstrap-admin2 license as it is Apache

[pmouawad] Move Mocha license

[pmouawad] move MetisMenu license

[pmouawad] Move bootstrap license

[pmouawad] Provide informations on licenses

--
[...truncated 992 lines...]
  [javadoc] Loading source files for package org.apache.jmeter.gui.action...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.template...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.validation...
  [javadoc] Loading source files for package org.apache.jmeter.gui.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.gui.tree...
  [javadoc] Loading source files for package org.apache.jmeter.gui.util...
  [javadoc] Loading source files for package org.apache.jmeter.logging...
  [javadoc] Loading source files for package org.apache.jmeter.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.processor...
  [javadoc] Loading source files for package org.apache.jmeter.processor.gui...
  [javadoc] Loading source files for package org.apache.jmeter.report.config...
  [javadoc] Loading source files for package org.apache.jmeter.report.core...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.dashboard...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph.impl...
  [javadoc] Loading source files for package org.apache.jmeter.reporters...
  [javadoc] Loading source files for package org.apache.jmeter.reporters.gui...
  [javadoc] Loading source files for package org.apache.jmeter.samplers...
  [javadoc] Loading source files for package org.apache.jmeter.samplers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.save...
  [javadoc] Loading source files for package 
org.apache.jmeter.save.converters...
  [javadoc] Loading source files for package org.apache.jmeter.services...
  [javadoc] Loading source files for package org.apache.jmeter.swing...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans.gui...
  [javadoc] Loading source files for package org.apache.jmeter.testelement...
  [javadoc] Loading source files for package 
org.apache.jmeter.testelement.property...
  [javadoc] Loading source files for package org.apache.jmeter.threads...
  [javadoc] Loading source files for package org.apache.jmeter.threads.gui...
  [javadoc] Loading source files for package org.apache.jmeter.timers...
  [javadoc] Loading source files for package org.apache.jmeter.timers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.util...
  [javadoc] Loading source files for package org.apache.jmeter.util.keystore...
  [javadoc] Loading source files for package org.apache.jmeter.visualizers...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.extractor...
  [javadoc] Loading source files for package org.apache.jmeter.extractor.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.extractor.json.jsonpath...
  [javadoc] Loading source files for package 
org.apache.jmeter.extractor.json.jsonpath.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.extractor.json.render...
  [javadoc] Loading source files for package org.apache.jmeter.modifiers...
  [javadoc] Loading source files for package org.apache.jmeter.modifiers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.sampler...
  [javadoc] Loading source files for package org.apache.jmeter.sampler.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend.graphite...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.utils...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.control...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.modifier...
  [javadoc] Loading

[GitHub] jmeter pull request: Bug59350_WritingLogFileTo

2016-04-19 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/201


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Bug 59345 - SMTPSampler connection leak

2016-04-19 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/198


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread Philippe Mouawad

I moved and renamed the license files mentioned by sebb

@milamber I let you manage the other problems.
Regards


On Tue, Apr 19, 2016 at 8:33 AM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Hi sebb,
> I filled in in root LICENSE file the license information for the 4
> components.
> Do we need to also add the MIT license in license/bin folder ?
> Thanks
>
> On Tue, Apr 19, 2016 at 3:24 AM, sebb  wrote:
>
>> On 19 April 2016 at 01:32, sebb  wrote:
>> > On 17 April 2016 at 18:03, Milamber  wrote:
>> >> Hello,
>> >>
>> >> The second release candidate for JMeter 3.0 (r1739623) has been
>> prepared,
>> >> and your votes are solicited.
>> >>
>> >> This release brings a lot of new features (over 100) and fixes many
>> bugs
>> >> (60).
>> >>
>> >> If you can, some tests of this release candidate (load tests and/or
>> >> functional tests) with Java 7/8 on Linux/Windows/Mac OS on changes are
>> >> welcome.
>> >>
>> >> You can read the New and Noteworthy section with some screenshots to
>> >> illustrate improvements and full list of changes at:
>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>> >>
>> >> JMeter is a Java desktop application designed to load test functional
>> >> behavior and measure performance. The current version is targeted at
>> Java
>> >> 7+.
>> >>
>> >> Archives/hashes/sigs:
>> >>
>> >> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/
>> >
>> > FTR, the revision is: r13285
>> >
>> >> RAT report:
>> >>
>> >>
>> http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt
>> >>
>> >> MD5 hashes of archives for this vote:
>> >>
>> >> 8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz
>> >> 0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip
>> >> 792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip
>> >> 823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz
>> >>
>> >> Site Docs are here:
>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/
>> >>
>> >> Maven staging repository is accessible here:
>> >>
>> https://repository.apache.org/content/repositories/orgapachejmeter-1007/org/apache/jmeter/
>> >>
>> >> Tag:
>> >> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC2/
>> >>
>> >> Keys are here:
>> >> https://www.apache.org/dist/jmeter/KEYS
>> >>
>> >> N.B.
>> >> To download the dependencies: "ant download_jars"
>> >>
>> >> To create the jars and test JMeter: "ant package test".
>> >>
>> >> JMeter 3.0 requires Java 7 or later to run.
>> >>
>> >> Some known issues and incompatible changes are listed on changes page.
>> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
>> >>
>> >>
>> >> All feedback and vote are welcome.
>> >>
>> >> [  ] +1  I support this release
>> >> [  ] +0  I am OK with this release
>> >> [  ] -0   OK, but
>> >> [X] -1   I do not support this release (please indicate why)
>> >>
>> >
>> > (binding)
>> >
>> > Sorry but there are some files missing from the source archive:
>> >
>> > Only in v3_0_RC2: .gitignore
>> > Only in v3_0_RC2: .svn
>> > Only in v3_0_RC2: .travis.yml
>> > Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7: LICENSE
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap:
>> > LICENSE
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap-social:
>> > .gitignore
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/datatables-responsive:
>> > .gitignore
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
>> > .gitignore
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
>> > Makefile
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/font-awesome:
>> > .gitignore
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
>> > .gitattributes
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
>> > .gitignore
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs/test:
>> > .gitignore
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/metisMenu:
>> > LICENSE
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/mocha:
>> > LICENSE
>> > Only in
>> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/morrisjs:
>> > .gitignore
>> > Only in v3_0_RC2: checkstyle-suppressions.xml
>> > Only in v3_0_RC2: doap_JMeter.rdf
>> > Only in v3_0_RC2/lib: api
>> > Only in v3_0_RC2/lib: doc
>> > Only in v3_0_RC2/lib: ext
>> > Only in v3_0_RC2/lib: junit
>> > Only in v3_0_RC2: rat-excludes.txt
>> > Only in v3_0_RC2/test: resources
>> >
>> > The .* files are OK, as is the doap (we ought to move that)
>> > Also the lib subdirectories.
>> >
>> > But the rest ought to be in the source archives, or some should
>> > perhaps be dropped from SVN
>>
>> The LICENSE files are misplaced.
>>
>> The

buildbot failure in on jmeter-trunk

2016-04-19 Thread buildbot

The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/1009

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1739849
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

Re: [VOTE] Release JMeter 3.0 RC2

2016-04-19 Thread Philippe Mouawad

Hi sebb,
I filled in in root LICENSE file the license information for the 4
components.
Do we need to also add the MIT license in license/bin folder ?
Thanks

On Tue, Apr 19, 2016 at 3:24 AM, sebb  wrote:

> On 19 April 2016 at 01:32, sebb  wrote:
> > On 17 April 2016 at 18:03, Milamber  wrote:
> >> Hello,
> >>
> >> The second release candidate for JMeter 3.0 (r1739623) has been
> prepared,
> >> and your votes are solicited.
> >>
> >> This release brings a lot of new features (over 100) and fixes many bugs
> >> (60).
> >>
> >> If you can, some tests of this release candidate (load tests and/or
> >> functional tests) with Java 7/8 on Linux/Windows/Mac OS on changes are
> >> welcome.
> >>
> >> You can read the New and Noteworthy section with some screenshots to
> >> illustrate improvements and full list of changes at:
> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
> >>
> >> JMeter is a Java desktop application designed to load test functional
> >> behavior and measure performance. The current version is targeted at
> Java
> >> 7+.
> >>
> >> Archives/hashes/sigs:
> >>
> >> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC2/
> >
> > FTR, the revision is: r13285
> >
> >> RAT report:
> >>
> >>
> http://home.apache.org/~milamber/jmeter-3.0RC2/dist/rat-report-jmeter-3.0RC2.txt
> >>
> >> MD5 hashes of archives for this vote:
> >>
> >> 8eab13c7c97cae7ad981adce73feaf7c *apache-jmeter-3.0.tgz
> >> 0375b7ad7fb51698f647ab2d8649b242 *apache-jmeter-3.0.zip
> >> 792fb612c2a8de5b4352579fcf4d09be *apache-jmeter-3.0_src.zip
> >> 823b8257824644837ec451e025d293d4 *apache-jmeter-3.0_src.tgz
> >>
> >> Site Docs are here:
> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/
> >>
> >> Maven staging repository is accessible here:
> >>
> https://repository.apache.org/content/repositories/orgapachejmeter-1007/org/apache/jmeter/
> >>
> >> Tag:
> >> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC2/
> >>
> >> Keys are here:
> >> https://www.apache.org/dist/jmeter/KEYS
> >>
> >> N.B.
> >> To download the dependencies: "ant download_jars"
> >>
> >> To create the jars and test JMeter: "ant package test".
> >>
> >> JMeter 3.0 requires Java 7 or later to run.
> >>
> >> Some known issues and incompatible changes are listed on changes page.
> >> http://home.apache.org/~milamber/jmeter-3.0RC2/docs/changes.html
> >>
> >>
> >> All feedback and vote are welcome.
> >>
> >> [  ] +1  I support this release
> >> [  ] +0  I am OK with this release
> >> [  ] -0   OK, but
> >> [X] -1   I do not support this release (please indicate why)
> >>
> >
> > (binding)
> >
> > Sorry but there are some files missing from the source archive:
> >
> > Only in v3_0_RC2: .gitignore
> > Only in v3_0_RC2: .svn
> > Only in v3_0_RC2: .travis.yml
> > Only in v3_0_RC2/bin/report-template/sbadmin2-1.0.7: LICENSE
> > Only in
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap:
> > LICENSE
> > Only in
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/bootstrap-social:
> > .gitignore
> > Only in
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/datatables-responsive:
> > .gitignore
> > Only in
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
> > .gitignore
> > Only in
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/flot:
> > Makefile
> > Only in
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/font-awesome:
> > .gitignore
> > Only in
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
> > .gitattributes
> > Only in
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs:
> > .gitignore
> > Only in
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/holderjs/test:
> > .gitignore
> > Only in
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/metisMenu:
> > LICENSE
> > Only in
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/mocha:
> > LICENSE
> > Only in
> v3_0_RC2/bin/report-template/sbadmin2-1.0.7/bower_components/morrisjs:
> > .gitignore
> > Only in v3_0_RC2: checkstyle-suppressions.xml
> > Only in v3_0_RC2: doap_JMeter.rdf
> > Only in v3_0_RC2/lib: api
> > Only in v3_0_RC2/lib: doc
> > Only in v3_0_RC2/lib: ext
> > Only in v3_0_RC2/lib: junit
> > Only in v3_0_RC2: rat-excludes.txt
> > Only in v3_0_RC2/test: resources
> >
> > The .* files are OK, as is the doap (we ought to move that)
> > Also the lib subdirectories.
> >
> > But the rest ought to be in the source archives, or some should
> > perhaps be dropped from SVN
>
> The LICENSE files are misplaced.
>
> The software items need to be mentioned in the main LICENSE file, and
> stored under the licenses/ folder if necessary.
>
> It's important that the user does not have to go looking for LICENSE
> files; they need to be all included or referenced from the top level
> file.
>
>
> > Also the source archives don't agree: docs is missing from the zip file
> >
> >

55 matches

Mail list logo