date:20160507

Hello,
I reviewed the code today and made some fixes and further tests.
On my side it is ok  to proceed with RM.

Thank to RM for his hard work on this 3.0

Regards

On Sat, May 7, 2016 at 11:29 AM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> I retire the veto but please ensure report generation works fine:
> - locally
> - in distributed testing
> - with properties modified
>
> It would be sad to discover an issue in rc4 due to it.
> I 've been testing this feature thorougjly on rc3.
> I don't have time to renew tests on rc4
> Thanks
>
>
> On Saturday, May 7, 2016, sebb  wrote:
>
>> OK for me assuming that the veto against the changes to the location
>> of the RG properties is withdrawn.
>>
>> On 7 May 2016 at 09:31, Philippe Mouawad 
>> wrote:
>> > ok for me
>> >
>> > On Saturday, May 7, 2016, Milamber  wrote:
>> >
>> >> Hello,
>> >>
>> >> Are you ready for the RC4 ? I can start the release process tonight or
>> >> tomorrow ?
>> >>
>> >> Milamber
>> >>
>> >> On 01/05/2016 14:48, Philippe Mouawad wrote:
>> >>
>> >>> Hi Milamber,
>> >>> It appears we have a last minute regression report:
>> >>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=59401
>> >>>
>> >>> I confirm the issue.
>> >>> Issue is due to HttpClient 4.5.X behaviour:
>> >>>
>> >>> -
>> >>>
>> https://github.com/apache/httpclient/blob/4.5.x/httpclient/src/main/java/org/apache/http/client/protocol/ResponseContentEncoding.java#L142
>> >>>
>> >>>
>> >>> When uncompressing HttpClient removes 3 headers:
>> >>> - Content-Length
>> >>> - Content-Encoding
>> >>> - Content-MD5
>> >>>
>> >>>
>> >>>
>> >>> Regards
>> >>> Philippe
>> >>>
>> >>> On Sat, Apr 30, 2016 at 5:59 PM, Milamber 
>> wrote:
>> >>>
>> >>> Hello,
>> 
>>  I will wait some hours to complete the 72h delay, and put the
>> results of
>>  the RC3 vote. It would seem that we will go to a RC4.
>> 
>>  I would like start the RC4 tomorrow afternoon, so please commit the
>> fixes
>>  of the minor issues found in the RC3 before (< 04:00 PM GMT+1)
>> 
>>  Thanks
>> 
>>  Milamber
>> 
>> 
>> 
>> 
>>  On 30/04/2016 13:23, Philippe Mouawad wrote:
>> 
>>  Hello,
>> > [-1] for all the reasons mentioned by Felix in the previous mail.
>> >
>> > Regards
>> > Philippe
>> >
>> > On Sat, Apr 30, 2016 at 1:15 PM, Felix Schumacher <
>> > felix.schumac...@internetallee.de> wrote:
>> >
>> > Am 28.04.2016 um 00:05 schrieb Milamber:
>> >
>> >> Hello,
>> >>
>> >>> The third release candidate for JMeter 3.0 (r1741338) has been
>> >>> prepared,
>> >>> and your votes are solicited.
>> >>>
>> >>> This release brings a lot of new features (over 100) and fixes
>> many
>> >>> bugs
>> >>> (60). The JMeter's logo and the JMeter's website have been
>> refreshed.
>> >>>
>> >>> Please, test this release candidate (with load tests and/or
>> functional
>> >>> tests) using Java 7/8 on Linux/Windows/Mac OS, especially on the
>> >>> changes.
>> >>> The feedback are welcome.
>> >>>
>> >>> You can read the New and Noteworthy section with some screenshots
>> to
>> >>> illustrate improvements and full list of changes at:
>> >>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/changes.html
>> >>>
>> >>> JMeter is a Java desktop application designed to load test
>> functional
>> >>> behavior and measure performance. The current version is targeted
>> at
>> >>> Java
>> >>> 7+.
>> >>>
>> >>> Download - Archives/hashes/sigs:
>> >>>
>> >>> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC3/
>> >>> (dist revision r13443)
>> >>>
>> >>> RAT report:
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> http://home.apache.org/~milamber/jmeter-3.0RC3/dist/rat-report-jmeter-3.0RC3.txt
>> >>>
>> >>> MD5 hashes of archives for this vote:
>> >>>
>> >>> 35c5e7798f602336c5bbcd8981804443 *apache-jmeter-3.0.tgz
>> >>> 9b8e01f005cfd56b92ae0c828bac54d4 *apache-jmeter-3.0.zip
>> >>> 88f03da71a9c90d21441e9139813afa6 *apache-jmeter-3.0_src.zip
>> >>> e6d7d1ed92830537cd06eb1748a07287 *apache-jmeter-3.0_src.tgz
>> >>>
>> >>> Site Docs are here:
>> >>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/
>> >>>
>> >>> Maven staging repository is accessible here:
>> >>>
>> >>>
>> >>>
>> >>>
>> https://repository.apache.org/content/repositories/orgapachejmeter-1008/org/apache/jmeter/
>> >>>
>> >>> Tag:
>> >>> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC3/
>> >>>
>> >>> Keys are here:
>> >>> https://www.apache.org/dist/jmeter/KEYS
>> >>>
>> >>> N.B.
>> >>> To download the dependencies: "ant download_jars"
>> >>>
>> >>> To create the jars and test JMeter: "ant package test".
>> >>>
>> >>> JMeter 3.0 requires

Jenkins build is back to normal : JMeter-trunk #5282

See

Re: svn commit: r1742642 - in /jmeter/trunk: bin/jmeter.properties bin/reportgenerator.properties src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java

Another comment, AFAIU, reportgenerator.properties must be added to bundles
?
I commited the fix, but please review as I am not sure.

On Sat, May 7, 2016 at 12:06 AM, sebb  wrote:

> On 6 May 2016 at 22:44, Philippe Mouawad 
> wrote:
> > -1
> >
> > I thought no important modification was to be done before 3.0 release ?
>
> Is that your only objection?
>
> >
> >
> > On Fri, May 6, 2016 at 11:38 PM,  wrote:
> >
> >> Author: sebb
> >> Date: Fri May  6 21:38:36 2016
> >> New Revision: 1742642
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1742642=rev
> >> Log:
> >> Move ReportGenerator defaults to a separate properties file
> >>
> >> Added:
> >> jmeter/trunk/bin/reportgenerator.properties   (with props)
> >> Modified:
> >> jmeter/trunk/bin/jmeter.properties
> >>
> >>
> jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java
> >>
> >> Modified: jmeter/trunk/bin/jmeter.properties
> >> URL:
> >>
> http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1742642=1742641=1742642=diff
> >>
> >>
> ==
> >> --- jmeter/trunk/bin/jmeter.properties (original)
> >> +++ jmeter/trunk/bin/jmeter.properties Fri May  6 21:38:36 2016
> >> @@ -1184,116 +1184,6 @@ view.results.tree.renderers_order=.Rende
> >>  classfinder.functions.contain=.functions.
> >>  classfinder.functions.notContain=.gui.
> >>
> >>
> >>
> -#---
> >> -# Reporting configuration
> >>
> >>
> -#---
> >> -
> >> -# Sets the satisfaction threshold for the APDEX calculation (in
> >> milliseconds).
> >> -#jmeter.reportgenerator.apdex_satisfied_threshold=500
> >> -
> >> -# Sets the tolerance threshold for the APDEX calculation (in
> >> milliseconds).
> >> -#jmeter.reportgenerator.apdex_tolerated_threshold=1500
> >> -
> >> -# Regular Expression which Indicates which samples to keep for graphs
> and
> >> statistics generation.
> >> -# Empty value means no filtering
> >> -#jmeter.reportgenerator.sample_filter=
> >> -
> >> -# Sets the temporary directory used by the generation process if it
> needs
> >> file I/O operations.
> >> -#jmeter.reportgenerator.temp_dir=temp
> >> -
> >> -# Sets the size of the sliding window used by percentile evaluation.
> >> -# Caution : higher value provides a better accuracy but needs more
> memory.
> >> -#jmeter.reportgenerator.statistic_window = 20
> >> -
> >> -# Configure this property to change the report title
> >> -#jmeter.reportgenerator.report_title=Apache JMeter Dashboard
> >> -
> >> -# Defines the overall granularity for over time graphs
> >> -jmeter.reportgenerator.overall_granularity=6
> >> -
> >> -# Response Time Percentiles graph definition
> >>
> >>
> -jmeter.reportgenerator.graph.responseTimePercentiles.classname=org.apache.jmeter.report.processor.graph.impl.ResponseTimePercentilesGraphConsumer
> >> -jmeter.reportgenerator.graph.responseTimePercentiles.title=Response
> Time
> >> Percentiles
> >> -
> >> -# Response Time Distribution graph definition
> >>
> >>
> -jmeter.reportgenerator.graph.responseTimeDistribution.classname=org.apache.jmeter.report.processor.graph.impl.ResponseTimeDistributionGraphConsumer
> >> -jmeter.reportgenerator.graph.responseTimeDistribution.title=Response
> Time
> >> Distribution
> >>
> >>
> -jmeter.reportgenerator.graph.responseTimeDistribution.property.set_granularity=500
> >> -
> >> -# Active Threads Over Time graph definition
> >>
> >>
> -jmeter.reportgenerator.graph.activeThreadsOverTime.classname=org.apache.jmeter.report.processor.graph.impl.ActiveThreadsGraphConsumer
> >> -jmeter.reportgenerator.graph.activeThreadsOverTime.title=Active Threads
> >> Over Time
> >>
> >>
> -jmeter.reportgenerator.graph.activeThreadsOverTime.property.set_granularity=${jmeter.reportgenerator.overall_granularity}
> >> -
> >> -# Time VS Threads graph definition
> >>
> >>
> -jmeter.reportgenerator.graph.timeVsThreads.classname=org.apache.jmeter.report.processor.graph.impl.TimeVSThreadGraphConsumer
> >> -jmeter.reportgenerator.graph.timeVsThreads.title=Time VS Threads
> >> -
> >> -# Bytes Throughput Over Time graph definition
> >>
> >>
> -jmeter.reportgenerator.graph.bytesThroughputOverTime.classname=org.apache.jmeter.report.processor.graph.impl.BytesThroughputGraphConsumer
> >> -jmeter.reportgenerator.graph.bytesThroughputOverTime.title=Bytes
> >> Throughput Over Time
> >>
> >>
> -jmeter.reportgenerator.graph.bytesThroughputOverTime.property.set_granularity=${jmeter.reportgenerator.overall_granularity}
> >> -
> >> -# Response Time Over Time graph definition
> >>
> >>
> -jmeter.reportgenerator.graph.responseTimesOverTime.classname=org.apache.jmeter.report.processor.graph.impl.ResponseTimeOverTimeGraphConsumer
> >> -jmeter.reportgenerator.graph.responseTimesOverTime.title=Response Time
> >>

Re: svn commit: r1742642 - in /jmeter/trunk: bin/jmeter.properties bin/reportgenerator.properties src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java

On Sat, May 7, 2016 at 12:14 PM, sebb  wrote:

> On 7 May 2016 at 10:33, Philippe Mouawad 
> wrote:
> > On Saturday, May 7, 2016, sebb  wrote:
> >
> >> On 7 May 2016 at 07:10, Philippe Mouawad  >> > wrote:
> >> > Hello,
> >> > I don't see docs update neither.
> >>
> >> The only relevant place I can find is properties_reference which I have
> >> updated.
> >> If there are any other places let me know.
> >
> >
> > i see no mention of this in dashboard docs.
> > I think some note on this would be nice
>
> AFAICT the dashboard docs don't mention jmeter.properties
> So why should  they mention the new property file?
>

They do, read
16.2 Configuring Dashboard Generation

>
> >
> >> > But for me it should have been discussed before and commited only
> after
> >> 3.0
> >> > as per milamber request.
> >>
> >> I could say the same about the fix you made:
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1742104=rev
> >> Log:
> >> Bug 59424 - Visualizer : Add "Clear" in popup menu
> >>
> >> That was not even discussed as I recall.
> >
> >
> > I can retire it if you want.
>
> No. I don't think it needs to be removed.
>
ok thanks

>
> > The regressions risks are very low,
>
> Since the patch affected code in MenuFactory, the _potential_ for
> regression is high.
>
> However the change was simple; it looks OK and I have not noticed any
> problems.
>
> > it's not the case for report generation which is a much more critical
> feature.
>
> The feature may be more critical, but there's no possibility of a
> regression since it's a new feature.
>

Yes but I don't like to release a broken feature.
See my comment on the commit.


>
> >
> >>
> >> ==
> >>
> >> The issue was discussed, but the solution was not.
> >>
> >> I am not happy releasing the code as it was before.
> >> I should have vetoed the original change.
> >
> >
> > which one ?
>
> The one which added the properties to jmeter.properties:
>
> http://svn.apache.org/viewvc?view=revision=1718425
>

As far as I remember, I never read a single good thing from you on this
feature since it was proposed, I don't remember you even voted.
I must confess I don't understand.
I am sad that the only conclusion of this feature for you is just "40 new
properties".

If your aim is to discourage further contributions, it's a very good way to
proceed.

Re: svn commit: r1742100 - in /jmeter/trunk: bin/jmeter.properties bin/user.properties src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java xdocs/usermanual/generating-dashboard.

Fixed

On Sat, May 7, 2016 at 7:17 PM, Philippe Mouawad  wrote:

>
>
> On Saturday, May 7, 2016, sebb  wrote:
>
>> On 3 May 2016 at 12:33,   wrote:
>> > Author: pmouawad
>> > Date: Tue May  3 11:33:46 2016
>> > New Revision: 1742100
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1742100=rev
>> > Log:
>> > Report generation : Better defaults
>> > filters_only_sample_series must be true to avoid empty graphs
>> >
>> > Modified:
>> > jmeter/trunk/bin/jmeter.properties
>> > jmeter/trunk/bin/user.properties
>> >
>>  
>> jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java
>> > jmeter/trunk/xdocs/usermanual/generating-dashboard.xml
>> > jmeter/trunk/xdocs/usermanual/properties_reference.xml
>> >
>> > Modified: jmeter/trunk/bin/jmeter.properties
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1742100=1742099=1742100=diff
>> >
>> ==
>> > --- jmeter/trunk/bin/jmeter.properties (original)
>> > +++ jmeter/trunk/bin/jmeter.properties Tue May  3 11:33:46 2016
>> > @@ -1286,8 +1286,10 @@ jmeter.reportgenerator.exporter.html.cla
>> >  # Empty value means no filtering
>> >  #jmeter.reportgenerator.exporter.html.series_filter=
>> >
>> > -# Indicates whether series filter apply only on sample series
>> > -#jmeter.reportgenerator.exporter.html.filters_only_sample_series=false
>> > +# Indicates whether series filter apply only on sample series or to
>> all series
>> > +# setting this to false can lead to empty graphs if series_filter does
>> not
>> > +# contain required series
>> > +#jmeter.reportgenerator.exporter.html.filters_only_sample_series=true
>> >
>> >  # Indicates whether only controller samples are displayed on graphs
>> that support it.
>> >  #jmeter.reportgenerator.exporter.html.show_controllers_only=false
>> >
>> > Modified: jmeter/trunk/bin/user.properties
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/bin/user.properties?rev=1742100=1742099=1742100=diff
>> >
>> ==
>> > --- jmeter/trunk/bin/user.properties (original)
>> > +++ jmeter/trunk/bin/user.properties Tue May  3 11:33:46 2016
>> > @@ -101,9 +101,7 @@
>> >  # on the result
>> >
>> #jmeter.reportgenerator.exporter.html.series_filter=((^Sample1)|(^Sample2))(-success|-failure)?
>> >
>> > -
>> > -# Indicates whether series filter apply only on sample series
>> > -#jmeter.reportgenerator.exporter.html.filters_only_sample_series=false
>> > -
>> >  # Indicates whether only controller samples are displayed on graphs
>> that support it.
>> >  #jmeter.reportgenerator.exporter.html.show_controllers_only=false
>> > +
>> > +jmeter.save.saveservice.timestamp_format=dd/MM HH:mm:ss
>>
>> -1
>>
>>
> Good catch, it's a mistake in the commit
>
>> This is the wrong place to change the default for a property.
>> And it is a breaking change that has not been discussed.
>>
>> Perhaps it was not intentional, as the change is not documented in the
>> log message nor in changes.xml
>>
>> In any case, this part of the commit needs to be reverted.
>>
>> > \ No newline at end of file
>> >
>> > Modified:
>> jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java?rev=1742100=1742099=1742100=diff
>> >
>> ==
>> > ---
>> jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java
>> (original)
>> > +++
>> jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java
>> Tue May  3 11:33:46 2016
>> > @@ -87,7 +87,7 @@ public class ReportGeneratorConfiguratio
>> >  // Required exporter properties
>> >  // Filters only sample series ?
>> >  public static final String EXPORTER_KEY_FILTERS_ONLY_SAMPLE_SERIES
>> = "filters_only_sample_series";
>> > -public static final Boolean
>> EXPORTER_KEY_FILTERS_ONLY_SAMPLE_SERIES_DEFAULT = Boolean.FALSE;
>> > +public static final Boolean
>> EXPORTER_KEY_FILTERS_ONLY_SAMPLE_SERIES_DEFAULT = Boolean.TRUE;
>> >
>> >  // Series filter
>> >  public static final String EXPORTER_KEY_SERIES_FILTER =
>> "series_filter";
>> >
>> > Modified: jmeter/trunk/xdocs/usermanual/generating-dashboard.xml
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/generating-dashboard.xml?rev=1742100=1742099=1742100=diff
>> >
>> ==
>> > --- jmeter/trunk/xdocs/usermanual/generating-dashboard.xml (original)
>> > +++ jmeter/trunk/xdocs/usermanual/generating-dashboard.xml Tue May  3
>> 11:33:46 2016
>> > @@ -225,7 +225,7 @@ jmeter.save.saveservice.timestamp_format
>> >

[GitHub] jmeter pull request: Used multi-catch, enhanced for loops, contain...

2016-05-07 Thread ham1

Github user ham1 commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/174#discussion_r62420814
  
--- Diff: src/core/org/apache/jmeter/reporters/ResultCollector.java ---
@@ -386,16 +384,14 @@ public void loadExistingFile() {
 
SaveService.loadTestResults(bufferedInputStream,
 new ResultCollectorHelper(this, 
visualizer));
 parsedOK = true;
-} catch (ConversionException e) {
-log.warn("Failed to load "+filename+" using 
XStream. Error was: "+e);
 } catch (Exception e) {
-log.warn("Failed to load "+filename+" using 
XStream. Error was: "+e);
+log.warn("Failed to load " + filename + " 
using XStream. Error was: " + e);
--- End diff --

Probably, however that would mean changing the rest in this file for 
consistency. I left it as it was as my intention for this PR was for Java 7 
related changes i.e. multi-catch (in this case removing duplicate code and 
'fixing' whitespace while there).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Refactoring of HTTPSamplerBase

2016-05-07 Thread ham1

Github user ham1 closed the pull request at:

https://github.com/apache/jmeter/pull/131


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: svn commit: r1742100 - in /jmeter/trunk: bin/jmeter.properties bin/user.properties src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java xdocs/usermanual/generating-dashboard.

On Saturday, May 7, 2016, sebb  wrote:

> On 3 May 2016 at 12:33,  > wrote:
> > Author: pmouawad
> > Date: Tue May  3 11:33:46 2016
> > New Revision: 1742100
> >
> > URL: http://svn.apache.org/viewvc?rev=1742100=rev
> > Log:
> > Report generation : Better defaults
> > filters_only_sample_series must be true to avoid empty graphs
> >
> > Modified:
> > jmeter/trunk/bin/jmeter.properties
> > jmeter/trunk/bin/user.properties
> >
>  
> jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java
> > jmeter/trunk/xdocs/usermanual/generating-dashboard.xml
> > jmeter/trunk/xdocs/usermanual/properties_reference.xml
> >
> > Modified: jmeter/trunk/bin/jmeter.properties
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1742100=1742099=1742100=diff
> >
> ==
> > --- jmeter/trunk/bin/jmeter.properties (original)
> > +++ jmeter/trunk/bin/jmeter.properties Tue May  3 11:33:46 2016
> > @@ -1286,8 +1286,10 @@ jmeter.reportgenerator.exporter.html.cla
> >  # Empty value means no filtering
> >  #jmeter.reportgenerator.exporter.html.series_filter=
> >
> > -# Indicates whether series filter apply only on sample series
> > -#jmeter.reportgenerator.exporter.html.filters_only_sample_series=false
> > +# Indicates whether series filter apply only on sample series or to all
> series
> > +# setting this to false can lead to empty graphs if series_filter does
> not
> > +# contain required series
> > +#jmeter.reportgenerator.exporter.html.filters_only_sample_series=true
> >
> >  # Indicates whether only controller samples are displayed on graphs
> that support it.
> >  #jmeter.reportgenerator.exporter.html.show_controllers_only=false
> >
> > Modified: jmeter/trunk/bin/user.properties
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/bin/user.properties?rev=1742100=1742099=1742100=diff
> >
> ==
> > --- jmeter/trunk/bin/user.properties (original)
> > +++ jmeter/trunk/bin/user.properties Tue May  3 11:33:46 2016
> > @@ -101,9 +101,7 @@
> >  # on the result
> >
> #jmeter.reportgenerator.exporter.html.series_filter=((^Sample1)|(^Sample2))(-success|-failure)?
> >
> > -
> > -# Indicates whether series filter apply only on sample series
> > -#jmeter.reportgenerator.exporter.html.filters_only_sample_series=false
> > -
> >  # Indicates whether only controller samples are displayed on graphs
> that support it.
> >  #jmeter.reportgenerator.exporter.html.show_controllers_only=false
> > +
> > +jmeter.save.saveservice.timestamp_format=dd/MM HH:mm:ss
>
> -1
>
>
Good catch, it's a mistake in the commit

> This is the wrong place to change the default for a property.
> And it is a breaking change that has not been discussed.
>
> Perhaps it was not intentional, as the change is not documented in the
> log message nor in changes.xml
>
> In any case, this part of the commit needs to be reverted.
>
> > \ No newline at end of file
> >
> > Modified:
> jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java?rev=1742100=1742099=1742100=diff
> >
> ==
> > ---
> jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java
> (original)
> > +++
> jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java
> Tue May  3 11:33:46 2016
> > @@ -87,7 +87,7 @@ public class ReportGeneratorConfiguratio
> >  // Required exporter properties
> >  // Filters only sample series ?
> >  public static final String EXPORTER_KEY_FILTERS_ONLY_SAMPLE_SERIES
> = "filters_only_sample_series";
> > -public static final Boolean
> EXPORTER_KEY_FILTERS_ONLY_SAMPLE_SERIES_DEFAULT = Boolean.FALSE;
> > +public static final Boolean
> EXPORTER_KEY_FILTERS_ONLY_SAMPLE_SERIES_DEFAULT = Boolean.TRUE;
> >
> >  // Series filter
> >  public static final String EXPORTER_KEY_SERIES_FILTER =
> "series_filter";
> >
> > Modified: jmeter/trunk/xdocs/usermanual/generating-dashboard.xml
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/generating-dashboard.xml?rev=1742100=1742099=1742100=diff
> >
> ==
> > --- jmeter/trunk/xdocs/usermanual/generating-dashboard.xml (original)
> > +++ jmeter/trunk/xdocs/usermanual/generating-dashboard.xml Tue May  3
> 11:33:46 2016
> > @@ -225,7 +225,7 @@ jmeter.save.saveservice.timestamp_format
> >   required="No">
> >  Defines whether
> series_filter (see below)
> >  apply only on sample series.
> > -

Build failed in Jenkins: JMeter-trunk #5281

See 

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-6 (docker Ubuntu ubuntu yahoo-not-h2) in workspace 

java.io.IOException: remote file operation failed: 
 at 
hudson.remoting.Channel@129e892e:ubuntu-6: java.io.IOException: Remote call on 
ubuntu-6 failed
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:968)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:898)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:834)
at hudson.scm.SCM.checkout(SCM.java:485)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1276)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:607)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1738)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Caused by: java.io.IOException: Remote call on ubuntu-6 failed
at hudson.remoting.Channel.call(Channel.java:789)
at hudson.FilePath.act(FilePath.java:979)
... 12 more
Caused by: java.lang.OutOfMemoryError: unable to create new native thread
at java.lang.Thread.start0(Native Method)
at java.lang.Thread.start(Thread.java:714)
at 
java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:949)
at 
java.util.concurrent.ThreadPoolExecutor.ensurePrestart(ThreadPoolExecutor.java:1590)
at 
java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:333)
at 
java.util.concurrent.ScheduledThreadPoolExecutor.scheduleWithFixedDelay(ScheduledThreadPoolExecutor.java:594)
at 
java.util.concurrent.Executors$DelegatedScheduledExecutorService.scheduleWithFixedDelay(Executors.java:698)
at 
org.tmatesoft.svn.core.wc.DefaultSVNRepositoryPool.(DefaultSVNRepositoryPool.java:156)
at 
org.tmatesoft.svn.core.wc.DefaultSVNRepositoryPool.(DefaultSVNRepositoryPool.java:126)
at 
org.tmatesoft.svn.core.wc.SVNClientManager.(SVNClientManager.java:150)
at 
org.tmatesoft.svn.core.wc.SVNClientManager.newInstance(SVNClientManager.java:201)
at hudson.scm.SubversionSCM.createClientManager(SubversionSCM.java:1037)
at hudson.scm.SubversionSCM$CheckOutTask.invoke(SubversionSCM.java:969)
at hudson.scm.SubversionSCM$CheckOutTask.invoke(SubversionSCM.java:949)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2719)
at hudson.remoting.UserRequest.perform(UserRequest.java:120)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:326)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to ubuntu-6(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1416)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:220)
at hudson.remoting.Channel.call(Channel.java:781)
... 13 more
Retrying after 10 seconds
java.io.IOException: remote file operation failed: 
 at 
hudson.remoting.Channel@129e892e:ubuntu-6: java.io.IOException: Remote call on 
ubuntu-6 failed
at hudson.FilePath.act(FilePath.java:986)
at hudson.FilePath.act(FilePath.java:968)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:898)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:834)
at hudson.scm.SCM.checkout(SCM.java:485)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1276)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:607)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1738)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)
Caused by:

Build failed in Jenkins: JMeter-trunk #5280

See 

Changes:

[sebb] Note that the class now supports JUnit4
Synch log with JUnit3 version

--
[...truncated 952 lines...]
   [anakia] Output: 

   [anakia] Input:  usermanual/regular_expressions.xml
   [anakia] Output: 

   [anakia] Input:  usermanual/remote-test.xml
   [anakia] Output: 

   [anakia] Input:  usermanual/test_plan.xml
   [anakia] Output: 

 [echo] Fixing EOL
 [echo] Removing unnecessary  tags
 [echo] Copying files
 [copy] Copying 2 files to 

 [copy] Copying 408 files to 

 [copy] Copying 16 files to 

 [copy] Copying 5 files to 

 [copy] Copying 1 file to 


install:

docs-api:
 [echo] Updating overview to r1742709
  [javadoc] Generating Javadoc
  [javadoc] Javadoc execution
  [javadoc] Loading source files for package org.apache.jmeter...
  [javadoc] Loading source files for package org.apache.jmeter.assertions...
  [javadoc] Loading source files for package org.apache.jmeter.assertions.gui...
  [javadoc] Loading source files for package org.apache.jmeter.config...
  [javadoc] Loading source files for package org.apache.jmeter.config.gui...
  [javadoc] Loading source files for package org.apache.jmeter.control...
  [javadoc] Loading source files for package org.apache.jmeter.control.gui...
  [javadoc] Loading source files for package org.apache.jmeter.engine...
  [javadoc] Loading source files for package org.apache.jmeter.engine.event...
  [javadoc] Loading source files for package org.apache.jmeter.engine.util...
  [javadoc] Loading source files for package org.apache.jmeter.exceptions...
  [javadoc] Loading source files for package org.apache.jmeter.functions...
  [javadoc] Loading source files for package org.apache.jmeter.functions.gui...
  [javadoc] Loading source files for package org.apache.jmeter.functions.util...
  [javadoc] Loading source files for package org.apache.jmeter.gui...
  [javadoc] Loading source files for package org.apache.jmeter.gui.action...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.template...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.validation...
  [javadoc] Loading source files for package org.apache.jmeter.gui.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.gui.tree...
  [javadoc] Loading source files for package org.apache.jmeter.gui.util...
  [javadoc] Loading source files for package org.apache.jmeter.logging...
  [javadoc] Loading source files for package org.apache.jmeter.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.processor...
  [javadoc] Loading source files for package org.apache.jmeter.processor.gui...
  [javadoc] Loading source files for package org.apache.jmeter.report.config...
  [javadoc] Loading source files for package org.apache.jmeter.report.core...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.dashboard...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph.impl...
  [javadoc] Loading source files for package org.apache.jmeter.reporters...
  [javadoc] Loading source files for package org.apache.jmeter.reporters.gui...
  [javadoc] Loading source files for package org.apache.jmeter.samplers...
  [javadoc] Loading source files for package org.apache.jmeter.samplers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.save...
  [javadoc] Loading source files for package 
org.apache.jmeter.save.converters...
  [javadoc] Loading source files for package org.apache.jmeter.services...
  [javadoc] Loading source files for package org.apache.jmeter.swing...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans.gui...
  [javadoc] Loading source files for package org.apache.jmeter.testelement...
  [javadoc] Loading source files for package 
org.apache.jmeter.testelement.property...
  [javadoc] Loading source files for

Build failed in Jenkins: JMeter-trunk #5279

See 

Changes:

[sebb] Add tests for properties files

--
[...truncated 954 lines...]
   [anakia] Output: 

   [anakia] Input:  usermanual/regular_expressions.xml
   [anakia] Output: 

   [anakia] Input:  usermanual/remote-test.xml
   [anakia] Output: 

   [anakia] Input:  usermanual/test_plan.xml
   [anakia] Output: 

 [echo] Fixing EOL
 [echo] Removing unnecessary  tags
 [echo] Copying files
 [copy] Copying 2 files to 

 [copy] Copying 408 files to 

 [copy] Copying 16 files to 

 [copy] Copying 5 files to 

 [copy] Copying 1 file to 


install:

docs-api:
 [echo] Updating overview to r1742704
  [javadoc] Generating Javadoc
  [javadoc] Javadoc execution
  [javadoc] Loading source files for package org.apache.jmeter...
  [javadoc] Loading source files for package org.apache.jmeter.assertions...
  [javadoc] Loading source files for package org.apache.jmeter.assertions.gui...
  [javadoc] Loading source files for package org.apache.jmeter.config...
  [javadoc] Loading source files for package org.apache.jmeter.config.gui...
  [javadoc] Loading source files for package org.apache.jmeter.control...
  [javadoc] Loading source files for package org.apache.jmeter.control.gui...
  [javadoc] Loading source files for package org.apache.jmeter.engine...
  [javadoc] Loading source files for package org.apache.jmeter.engine.event...
  [javadoc] Loading source files for package org.apache.jmeter.engine.util...
  [javadoc] Loading source files for package org.apache.jmeter.exceptions...
  [javadoc] Loading source files for package org.apache.jmeter.functions...
  [javadoc] Loading source files for package org.apache.jmeter.functions.gui...
  [javadoc] Loading source files for package org.apache.jmeter.functions.util...
  [javadoc] Loading source files for package org.apache.jmeter.gui...
  [javadoc] Loading source files for package org.apache.jmeter.gui.action...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.template...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.validation...
  [javadoc] Loading source files for package org.apache.jmeter.gui.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.gui.tree...
  [javadoc] Loading source files for package org.apache.jmeter.gui.util...
  [javadoc] Loading source files for package org.apache.jmeter.logging...
  [javadoc] Loading source files for package org.apache.jmeter.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.processor...
  [javadoc] Loading source files for package org.apache.jmeter.processor.gui...
  [javadoc] Loading source files for package org.apache.jmeter.report.config...
  [javadoc] Loading source files for package org.apache.jmeter.report.core...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.dashboard...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph.impl...
  [javadoc] Loading source files for package org.apache.jmeter.reporters...
  [javadoc] Loading source files for package org.apache.jmeter.reporters.gui...
  [javadoc] Loading source files for package org.apache.jmeter.samplers...
  [javadoc] Loading source files for package org.apache.jmeter.samplers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.save...
  [javadoc] Loading source files for package 
org.apache.jmeter.save.converters...
  [javadoc] Loading source files for package org.apache.jmeter.services...
  [javadoc] Loading source files for package org.apache.jmeter.swing...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans.gui...
  [javadoc] Loading source files for package org.apache.jmeter.testelement...
  [javadoc] Loading source files for package 
org.apache.jmeter.testelement.property...
  [javadoc] Loading source files for package org.apache.jmeter.threads...

Build failed in Jenkins: JMeter-trunk #5278

See 

Changes:

[sebb] Drop some bug reports that relate to nightly builds only

--
[...truncated 950 lines...]
   [anakia] Output: 

   [anakia] Input:  usermanual/test_plan.xml
   [anakia] Output: 

 [echo] Fixing EOL
 [echo] Removing unnecessary  tags
 [echo] Copying files
 [copy] Copying 2 files to 

 [copy] Copying 408 files to 

 [copy] Copying 16 files to 

 [copy] Copying 5 files to 

 [copy] Copying 1 file to 


install:

docs-api:
 [echo] Updating overview to r1742700
  [javadoc] Generating Javadoc
  [javadoc] Javadoc execution
  [javadoc] Loading source files for package org.apache.jmeter...
  [javadoc] Loading source files for package org.apache.jmeter.assertions...
  [javadoc] Loading source files for package org.apache.jmeter.assertions.gui...
  [javadoc] Loading source files for package org.apache.jmeter.config...
  [javadoc] Loading source files for package org.apache.jmeter.config.gui...
  [javadoc] Loading source files for package org.apache.jmeter.control...
  [javadoc] Loading source files for package org.apache.jmeter.control.gui...
  [javadoc] Loading source files for package org.apache.jmeter.engine...
  [javadoc] Loading source files for package org.apache.jmeter.engine.event...
  [javadoc] Loading source files for package org.apache.jmeter.engine.util...
  [javadoc] Loading source files for package org.apache.jmeter.exceptions...
  [javadoc] Loading source files for package org.apache.jmeter.functions...
  [javadoc] Loading source files for package org.apache.jmeter.functions.gui...
  [javadoc] Loading source files for package org.apache.jmeter.functions.util...
  [javadoc] Loading source files for package org.apache.jmeter.gui...
  [javadoc] Loading source files for package org.apache.jmeter.gui.action...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.template...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.validation...
  [javadoc] Loading source files for package org.apache.jmeter.gui.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.gui.tree...
  [javadoc] Loading source files for package org.apache.jmeter.gui.util...
  [javadoc] Loading source files for package org.apache.jmeter.logging...
  [javadoc] Loading source files for package org.apache.jmeter.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.processor...
  [javadoc] Loading source files for package org.apache.jmeter.processor.gui...
  [javadoc] Loading source files for package org.apache.jmeter.report.config...
  [javadoc] Loading source files for package org.apache.jmeter.report.core...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.dashboard...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph.impl...
  [javadoc] Loading source files for package org.apache.jmeter.reporters...
  [javadoc] Loading source files for package org.apache.jmeter.reporters.gui...
  [javadoc] Loading source files for package org.apache.jmeter.samplers...
  [javadoc] Loading source files for package org.apache.jmeter.samplers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.save...
  [javadoc] Loading source files for package 
org.apache.jmeter.save.converters...
  [javadoc] Loading source files for package org.apache.jmeter.services...
  [javadoc] Loading source files for package org.apache.jmeter.swing...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans.gui...
  [javadoc] Loading source files for package org.apache.jmeter.testelement...
  [javadoc] Loading source files for package 
org.apache.jmeter.testelement.property...
  [javadoc] Loading source files for package org.apache.jmeter.threads...
  [javadoc] Loading source files for package org.apache.jmeter.threads.gui...
  [javadoc] Loading source files for package org.apache.jmeter.timers...
  [javadoc] Loading source files for package org.apache.jmeter.timers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.util...
  [javadoc] Loading source files

Re: svn commit: r1742100 - in /jmeter/trunk: bin/jmeter.properties bin/user.properties src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java xdocs/usermanual/generating-dashboard.

On 3 May 2016 at 12:33,   wrote:
> Author: pmouawad
> Date: Tue May  3 11:33:46 2016
> New Revision: 1742100
>
> URL: http://svn.apache.org/viewvc?rev=1742100=rev
> Log:
> Report generation : Better defaults
> filters_only_sample_series must be true to avoid empty graphs
>
> Modified:
> jmeter/trunk/bin/jmeter.properties
> jmeter/trunk/bin/user.properties
> 
> jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java
> jmeter/trunk/xdocs/usermanual/generating-dashboard.xml
> jmeter/trunk/xdocs/usermanual/properties_reference.xml
>
> Modified: jmeter/trunk/bin/jmeter.properties
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1742100=1742099=1742100=diff
> ==
> --- jmeter/trunk/bin/jmeter.properties (original)
> +++ jmeter/trunk/bin/jmeter.properties Tue May  3 11:33:46 2016
> @@ -1286,8 +1286,10 @@ jmeter.reportgenerator.exporter.html.cla
>  # Empty value means no filtering
>  #jmeter.reportgenerator.exporter.html.series_filter=
>
> -# Indicates whether series filter apply only on sample series
> -#jmeter.reportgenerator.exporter.html.filters_only_sample_series=false
> +# Indicates whether series filter apply only on sample series or to all 
> series
> +# setting this to false can lead to empty graphs if series_filter does not
> +# contain required series
> +#jmeter.reportgenerator.exporter.html.filters_only_sample_series=true
>
>  # Indicates whether only controller samples are displayed on graphs that 
> support it.
>  #jmeter.reportgenerator.exporter.html.show_controllers_only=false
>
> Modified: jmeter/trunk/bin/user.properties
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/bin/user.properties?rev=1742100=1742099=1742100=diff
> ==
> --- jmeter/trunk/bin/user.properties (original)
> +++ jmeter/trunk/bin/user.properties Tue May  3 11:33:46 2016
> @@ -101,9 +101,7 @@
>  # on the result
>  
> #jmeter.reportgenerator.exporter.html.series_filter=((^Sample1)|(^Sample2))(-success|-failure)?
>
> -
> -# Indicates whether series filter apply only on sample series
> -#jmeter.reportgenerator.exporter.html.filters_only_sample_series=false
> -
>  # Indicates whether only controller samples are displayed on graphs that 
> support it.
>  #jmeter.reportgenerator.exporter.html.show_controllers_only=false
> +
> +jmeter.save.saveservice.timestamp_format=dd/MM HH:mm:ss

-1

This is the wrong place to change the default for a property.
And it is a breaking change that has not been discussed.

Perhaps it was not intentional, as the change is not documented in the
log message nor in changes.xml

In any case, this part of the commit needs to be reverted.

> \ No newline at end of file
>
> Modified: 
> jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java?rev=1742100=1742099=1742100=diff
> ==
> --- 
> jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java
>  (original)
> +++ 
> jmeter/trunk/src/core/org/apache/jmeter/report/config/ReportGeneratorConfiguration.java
>  Tue May  3 11:33:46 2016
> @@ -87,7 +87,7 @@ public class ReportGeneratorConfiguratio
>  // Required exporter properties
>  // Filters only sample series ?
>  public static final String EXPORTER_KEY_FILTERS_ONLY_SAMPLE_SERIES = 
> "filters_only_sample_series";
> -public static final Boolean 
> EXPORTER_KEY_FILTERS_ONLY_SAMPLE_SERIES_DEFAULT = Boolean.FALSE;
> +public static final Boolean 
> EXPORTER_KEY_FILTERS_ONLY_SAMPLE_SERIES_DEFAULT = Boolean.TRUE;
>
>  // Series filter
>  public static final String EXPORTER_KEY_SERIES_FILTER = "series_filter";
>
> Modified: jmeter/trunk/xdocs/usermanual/generating-dashboard.xml
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/generating-dashboard.xml?rev=1742100=1742099=1742100=diff
> ==
> --- jmeter/trunk/xdocs/usermanual/generating-dashboard.xml (original)
> +++ jmeter/trunk/xdocs/usermanual/generating-dashboard.xml Tue May  3 
> 11:33:46 2016
> @@ -225,7 +225,7 @@ jmeter.save.saveservice.timestamp_format
>   required="No">
>  Defines whether series_filter 
> (see below)
>  apply only on sample series.
> -Default: false
> +Default: true
>   required="No">Sets the filter
>  of series. An empty value deactivates the 
> filtering.
>  Format:

Re: svn commit: r1742642 - in /jmeter/trunk: bin/jmeter.properties bin/reportgenerator.properties src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java

On 7 May 2016 at 10:33, Philippe Mouawad  wrote:
> On Saturday, May 7, 2016, sebb  wrote:
>
>> On 7 May 2016 at 07:10, Philippe Mouawad > > wrote:
>> > Hello,
>> > I don't see docs update neither.
>>
>> The only relevant place I can find is properties_reference which I have
>> updated.
>> If there are any other places let me know.
>
>
> i see no mention of this in dashboard docs.
> I think some note on this would be nice

AFAICT the dashboard docs don't mention jmeter.properties
So why should  they mention the new property file?

>
>> > But for me it should have been discussed before and commited only after
>> 3.0
>> > as per milamber request.
>>
>> I could say the same about the fix you made:
>>
>> URL: http://svn.apache.org/viewvc?rev=1742104=rev
>> Log:
>> Bug 59424 - Visualizer : Add "Clear" in popup menu
>>
>> That was not even discussed as I recall.
>
>
> I can retire it if you want.

No. I don't think it needs to be removed.

> The regressions risks are very low,

Since the patch affected code in MenuFactory, the _potential_ for
regression is high.

However the change was simple; it looks OK and I have not noticed any problems.

> it's not the case for report generation which is a much more critical feature.

The feature may be more critical, but there's no possibility of a
regression since it's a new feature.

>
>>
>> ==
>>
>> The issue was discussed, but the solution was not.
>>
>> I am not happy releasing the code as it was before.
>> I should have vetoed the original change.
>
>
> which one ?

The one which added the properties to jmeter.properties:

http://svn.apache.org/viewvc?view=revision=1718425

Build failed in Jenkins: JMeter-trunk #5277

See 

Changes:

[sebb] Mention reportgeenrator.properties

--
[...truncated 950 lines...]
   [anakia] Output: 

   [anakia] Input:  usermanual/test_plan.xml
   [anakia] Output: 

 [echo] Fixing EOL
 [echo] Removing unnecessary  tags
 [echo] Copying files
 [copy] Copying 2 files to 

 [copy] Copying 408 files to 

 [copy] Copying 16 files to 

 [copy] Copying 5 files to 

 [copy] Copying 1 file to 


install:

docs-api:
 [echo] Updating overview to r1742694
  [javadoc] Generating Javadoc
  [javadoc] Javadoc execution
  [javadoc] Loading source files for package org.apache.jmeter...
  [javadoc] Loading source files for package org.apache.jmeter.assertions...
  [javadoc] Loading source files for package org.apache.jmeter.assertions.gui...
  [javadoc] Loading source files for package org.apache.jmeter.config...
  [javadoc] Loading source files for package org.apache.jmeter.config.gui...
  [javadoc] Loading source files for package org.apache.jmeter.control...
  [javadoc] Loading source files for package org.apache.jmeter.control.gui...
  [javadoc] Loading source files for package org.apache.jmeter.engine...
  [javadoc] Loading source files for package org.apache.jmeter.engine.event...
  [javadoc] Loading source files for package org.apache.jmeter.engine.util...
  [javadoc] Loading source files for package org.apache.jmeter.exceptions...
  [javadoc] Loading source files for package org.apache.jmeter.functions...
  [javadoc] Loading source files for package org.apache.jmeter.functions.gui...
  [javadoc] Loading source files for package org.apache.jmeter.functions.util...
  [javadoc] Loading source files for package org.apache.jmeter.gui...
  [javadoc] Loading source files for package org.apache.jmeter.gui.action...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.template...
  [javadoc] Loading source files for package 
org.apache.jmeter.gui.action.validation...
  [javadoc] Loading source files for package org.apache.jmeter.gui.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.gui.tree...
  [javadoc] Loading source files for package org.apache.jmeter.gui.util...
  [javadoc] Loading source files for package org.apache.jmeter.logging...
  [javadoc] Loading source files for package org.apache.jmeter.plugin...
  [javadoc] Loading source files for package org.apache.jmeter.processor...
  [javadoc] Loading source files for package org.apache.jmeter.processor.gui...
  [javadoc] Loading source files for package org.apache.jmeter.report.config...
  [javadoc] Loading source files for package org.apache.jmeter.report.core...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.dashboard...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph...
  [javadoc] Loading source files for package 
org.apache.jmeter.report.processor.graph.impl...
  [javadoc] Loading source files for package org.apache.jmeter.reporters...
  [javadoc] Loading source files for package org.apache.jmeter.reporters.gui...
  [javadoc] Loading source files for package org.apache.jmeter.samplers...
  [javadoc] Loading source files for package org.apache.jmeter.samplers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.save...
  [javadoc] Loading source files for package 
org.apache.jmeter.save.converters...
  [javadoc] Loading source files for package org.apache.jmeter.services...
  [javadoc] Loading source files for package org.apache.jmeter.swing...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans...
  [javadoc] Loading source files for package org.apache.jmeter.testbeans.gui...
  [javadoc] Loading source files for package org.apache.jmeter.testelement...
  [javadoc] Loading source files for package 
org.apache.jmeter.testelement.property...
  [javadoc] Loading source files for package org.apache.jmeter.threads...
  [javadoc] Loading source files for package org.apache.jmeter.threads.gui...
  [javadoc] Loading source files for package org.apache.jmeter.timers...
  [javadoc] Loading source files for package org.apache.jmeter.timers.gui...
  [javadoc] Loading source files for package org.apache.jmeter.util...
  [javadoc] Loading source files for package

Re: svn commit: r1742642 - in /jmeter/trunk: bin/jmeter.properties bin/reportgenerator.properties src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java

On Saturday, May 7, 2016, sebb  wrote:

> On 7 May 2016 at 07:10, Philippe Mouawad  > wrote:
> > Hello,
> > I don't see docs update neither.
>
> The only relevant place I can find is properties_reference which I have
> updated.
> If there are any other places let me know.


i see no mention of this in dashboard docs.
I think some note on this would be nice


> > But for me it should have been discussed before and commited only after
> 3.0
> > as per milamber request.
>
> I could say the same about the fix you made:
>
> URL: http://svn.apache.org/viewvc?rev=1742104=rev
> Log:
> Bug 59424 - Visualizer : Add "Clear" in popup menu
>
> That was not even discussed as I recall.


I can retire it if you want.
The regressions risks are very low, it's not the case for report generation
which is a much more critical feature.


>
> ==
>
> The issue was discussed, but the solution was not.
>
> I am not happy releasing the code as it was before.
> I should have vetoed the original change.


which one ?


>
> > Regards
> >
> > On Saturday, May 7, 2016, sebb > wrote:
> >
> >> On 6 May 2016 at 22:44, Philippe Mouawad  
> >> > wrote:
> >> > -1
> >> >
> >> > I thought no important modification was to be done before 3.0 release
> ?
> >>
> >> Is that your only objection?
> >>
> >> >
> >> >
> >> > On Fri, May 6, 2016 at 11:38 PM, 
> > wrote:
> >> >
> >> >> Author: sebb
> >> >> Date: Fri May  6 21:38:36 2016
> >> >> New Revision: 1742642
> >> >>
> >> >> URL: http://svn.apache.org/viewvc?rev=1742642=rev
> >> >> Log:
> >> >> Move ReportGenerator defaults to a separate properties file
> >> >>
> >> >> Added:
> >> >> jmeter/trunk/bin/reportgenerator.properties   (with props)
> >> >> Modified:
> >> >> jmeter/trunk/bin/jmeter.properties
> >> >>
> >> >>
> >>
> jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java
> >> >>
> >> >> Modified: jmeter/trunk/bin/jmeter.properties
> >> >> URL:
> >> >>
> >>
> http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1742642=1742641=1742642=diff
> >> >>
> >> >>
> >>
> ==
> >> >> --- jmeter/trunk/bin/jmeter.properties (original)
> >> >> +++ jmeter/trunk/bin/jmeter.properties Fri May  6 21:38:36 2016
> >> >> @@ -1184,116 +1184,6 @@ view.results.tree.renderers_order=.Rende
> >> >>  classfinder.functions.contain=.functions.
> >> >>  classfinder.functions.notContain=.gui.
> >> >>
> >> >>
> >> >>
> >>
> -#---
> >> >> -# Reporting configuration
> >> >>
> >> >>
> >>
> -#---
> >> >> -
> >> >> -# Sets the satisfaction threshold for the APDEX calculation (in
> >> >> milliseconds).
> >> >> -#jmeter.reportgenerator.apdex_satisfied_threshold=500
> >> >> -
> >> >> -# Sets the tolerance threshold for the APDEX calculation (in
> >> >> milliseconds).
> >> >> -#jmeter.reportgenerator.apdex_tolerated_threshold=1500
> >> >> -
> >> >> -# Regular Expression which Indicates which samples to keep for
> graphs
> >> and
> >> >> statistics generation.
> >> >> -# Empty value means no filtering
> >> >> -#jmeter.reportgenerator.sample_filter=
> >> >> -
> >> >> -# Sets the temporary directory used by the generation process if it
> >> needs
> >> >> file I/O operations.
> >> >> -#jmeter.reportgenerator.temp_dir=temp
> >> >> -
> >> >> -# Sets the size of the sliding window used by percentile evaluation.
> >> >> -# Caution : higher value provides a better accuracy but needs more
> >> memory.
> >> >> -#jmeter.reportgenerator.statistic_window = 20
> >> >> -
> >> >> -# Configure this property to change the report title
> >> >> -#jmeter.reportgenerator.report_title=Apache JMeter Dashboard
> >> >> -
> >> >> -# Defines the overall granularity for over time graphs
> >> >> -jmeter.reportgenerator.overall_granularity=6
> >> >> -
> >> >> -# Response Time Percentiles graph definition
> >> >>
> >> >>
> >>
> -jmeter.reportgenerator.graph.responseTimePercentiles.classname=org.apache.jmeter.report.processor.graph.impl.ResponseTimePercentilesGraphConsumer
> >> >> -jmeter.reportgenerator.graph.responseTimePercentiles.title=Response
> >> Time
> >> >> Percentiles
> >> >> -
> >> >> -# Response Time Distribution graph definition
> >> >>
> >> >>
> >>
> -jmeter.reportgenerator.graph.responseTimeDistribution.classname=org.apache.jmeter.report.processor.graph.impl.ResponseTimeDistributionGraphConsumer
> >> >> -jmeter.reportgenerator.graph.responseTimeDistribution.title=Response
> >> Time
> >> >> Distribution
> >> >>
> >> >>
> >>
> -jmeter.reportgenerator.graph.responseTimeDistribution.property.set_granularity=500
> >> >> -
> >> >> -# Active Threads Over Time graph definition
> >> >>
> >> >>
> >>
>

Re: [VOTE] Release JMeter 3.0 RC3

2016-05-07 Thread Felix Schumacher

Ok for me

Thanks for rm
Felix

Am 7. Mai 2016 09:55:24 MESZ, schrieb Milamber :
>Hello,
>
>Are you ready for the RC4 ? I can start the release process tonight or 
>tomorrow ?
>
>Milamber
>
>On 01/05/2016 14:48, Philippe Mouawad wrote:
>> Hi Milamber,
>> It appears we have a last minute regression report:
>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=59401
>>
>> I confirm the issue.
>> Issue is due to HttpClient 4.5.X behaviour:
>>
>> -
>https://github.com/apache/httpclient/blob/4.5.x/httpclient/src/main/java/org/apache/http/client/protocol/ResponseContentEncoding.java#L142
>>
>>
>> When uncompressing HttpClient removes 3 headers:
>> - Content-Length
>> - Content-Encoding
>> - Content-MD5
>>
>>
>>
>> Regards
>> Philippe
>>
>> On Sat, Apr 30, 2016 at 5:59 PM, Milamber 
>wrote:
>>
>>> Hello,
>>>
>>> I will wait some hours to complete the 72h delay, and put the
>results of
>>> the RC3 vote. It would seem that we will go to a RC4.
>>>
>>> I would like start the RC4 tomorrow afternoon, so please commit the
>fixes
>>> of the minor issues found in the RC3 before (< 04:00 PM GMT+1)
>>>
>>> Thanks
>>>
>>> Milamber
>>>
>>>
>>>
>>>
>>> On 30/04/2016 13:23, Philippe Mouawad wrote:
>>>
 Hello,
 [-1] for all the reasons mentioned by Felix in the previous mail.

 Regards
 Philippe

 On Sat, Apr 30, 2016 at 1:15 PM, Felix Schumacher <
 felix.schumac...@internetallee.de> wrote:

 Am 28.04.2016 um 00:05 schrieb Milamber:
> Hello,
>> The third release candidate for JMeter 3.0 (r1741338) has been
>prepared,
>> and your votes are solicited.
>>
>> This release brings a lot of new features (over 100) and fixes
>many bugs
>> (60). The JMeter's logo and the JMeter's website have been
>refreshed.
>>
>> Please, test this release candidate (with load tests and/or
>functional
>> tests) using Java 7/8 on Linux/Windows/Mac OS, especially on the
>> changes.
>> The feedback are welcome.
>>
>> You can read the New and Noteworthy section with some screenshots
>to
>> illustrate improvements and full list of changes at:
>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/changes.html
>>
>> JMeter is a Java desktop application designed to load test
>functional
>> behavior and measure performance. The current version is targeted
>at
>> Java
>> 7+.
>>
>> Download - Archives/hashes/sigs:
>>
>> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC3/
>> (dist revision r13443)
>>
>> RAT report:
>>
>>
>>
>>
>http://home.apache.org/~milamber/jmeter-3.0RC3/dist/rat-report-jmeter-3.0RC3.txt
>>
>> MD5 hashes of archives for this vote:
>>
>> 35c5e7798f602336c5bbcd8981804443 *apache-jmeter-3.0.tgz
>> 9b8e01f005cfd56b92ae0c828bac54d4 *apache-jmeter-3.0.zip
>> 88f03da71a9c90d21441e9139813afa6 *apache-jmeter-3.0_src.zip
>> e6d7d1ed92830537cd06eb1748a07287 *apache-jmeter-3.0_src.tgz
>>
>> Site Docs are here:
>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/
>>
>> Maven staging repository is accessible here:
>>
>>
>>
>https://repository.apache.org/content/repositories/orgapachejmeter-1008/org/apache/jmeter/
>>
>> Tag:
>> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC3/
>>
>> Keys are here:
>> https://www.apache.org/dist/jmeter/KEYS
>>
>> N.B.
>> To download the dependencies: "ant download_jars"
>>
>> To create the jars and test JMeter: "ant package test".
>>
>> JMeter 3.0 requires Java 7 or later to run.
>>
>> Some known issues and incompatible changes are listed on changes
>page.
>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/changes.html
>>
>>
>> All feedback and vote are welcome.
>>
>> [  ] +1  I support this release
>> [  ] +0  I am OK with this release
>> [ x] -0   OK, but
>>
>> I think the small things, that have been observed in this
>candidate,
> should be cared for:
>* Missing files (reported by sebb)
>* Mac-Icon (reported by sebb) (We probably use just the
>feather, as it
> is
> nearly quadratic)
>* exec permissions (reported by sebb)
>* report generation in combination with distributed testing
>(reported
> by
> pmouawad)
>
> I have committed three fixes for really minor issues:
>* wrong image width, which would be observable when viewing doc
>inside
> jmeter
>* use (officially) invalid dns names for templates
>
> Other than that I found no further issues.
>
> Regards,
>Felix
>
> [  ] -1   I do not support this release (please indicate why)
>
>> The vote will remain open for at least 72 hours.
>>
>> The PMC members please indicate the mention "(binding)" with your
>vote.
>>
>>
>> Note: If the vote passes, the intention is

Re: [VOTE] Release JMeter 3.0 RC3

OK for me assuming that the veto against the changes to the location
of the RG properties is withdrawn.

On 7 May 2016 at 09:31, Philippe Mouawad  wrote:
> ok for me
>
> On Saturday, May 7, 2016, Milamber  wrote:
>
>> Hello,
>>
>> Are you ready for the RC4 ? I can start the release process tonight or
>> tomorrow ?
>>
>> Milamber
>>
>> On 01/05/2016 14:48, Philippe Mouawad wrote:
>>
>>> Hi Milamber,
>>> It appears we have a last minute regression report:
>>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=59401
>>>
>>> I confirm the issue.
>>> Issue is due to HttpClient 4.5.X behaviour:
>>>
>>> -
>>> https://github.com/apache/httpclient/blob/4.5.x/httpclient/src/main/java/org/apache/http/client/protocol/ResponseContentEncoding.java#L142
>>>
>>>
>>> When uncompressing HttpClient removes 3 headers:
>>> - Content-Length
>>> - Content-Encoding
>>> - Content-MD5
>>>
>>>
>>>
>>> Regards
>>> Philippe
>>>
>>> On Sat, Apr 30, 2016 at 5:59 PM, Milamber  wrote:
>>>
>>> Hello,

 I will wait some hours to complete the 72h delay, and put the results of
 the RC3 vote. It would seem that we will go to a RC4.

 I would like start the RC4 tomorrow afternoon, so please commit the fixes
 of the minor issues found in the RC3 before (< 04:00 PM GMT+1)

 Thanks

 Milamber




 On 30/04/2016 13:23, Philippe Mouawad wrote:

 Hello,
> [-1] for all the reasons mentioned by Felix in the previous mail.
>
> Regards
> Philippe
>
> On Sat, Apr 30, 2016 at 1:15 PM, Felix Schumacher <
> felix.schumac...@internetallee.de> wrote:
>
> Am 28.04.2016 um 00:05 schrieb Milamber:
>
>> Hello,
>>
>>> The third release candidate for JMeter 3.0 (r1741338) has been
>>> prepared,
>>> and your votes are solicited.
>>>
>>> This release brings a lot of new features (over 100) and fixes many
>>> bugs
>>> (60). The JMeter's logo and the JMeter's website have been refreshed.
>>>
>>> Please, test this release candidate (with load tests and/or functional
>>> tests) using Java 7/8 on Linux/Windows/Mac OS, especially on the
>>> changes.
>>> The feedback are welcome.
>>>
>>> You can read the New and Noteworthy section with some screenshots to
>>> illustrate improvements and full list of changes at:
>>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/changes.html
>>>
>>> JMeter is a Java desktop application designed to load test functional
>>> behavior and measure performance. The current version is targeted at
>>> Java
>>> 7+.
>>>
>>> Download - Archives/hashes/sigs:
>>>
>>> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC3/
>>> (dist revision r13443)
>>>
>>> RAT report:
>>>
>>>
>>>
>>>
>>> http://home.apache.org/~milamber/jmeter-3.0RC3/dist/rat-report-jmeter-3.0RC3.txt
>>>
>>> MD5 hashes of archives for this vote:
>>>
>>> 35c5e7798f602336c5bbcd8981804443 *apache-jmeter-3.0.tgz
>>> 9b8e01f005cfd56b92ae0c828bac54d4 *apache-jmeter-3.0.zip
>>> 88f03da71a9c90d21441e9139813afa6 *apache-jmeter-3.0_src.zip
>>> e6d7d1ed92830537cd06eb1748a07287 *apache-jmeter-3.0_src.tgz
>>>
>>> Site Docs are here:
>>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/
>>>
>>> Maven staging repository is accessible here:
>>>
>>>
>>>
>>> https://repository.apache.org/content/repositories/orgapachejmeter-1008/org/apache/jmeter/
>>>
>>> Tag:
>>> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC3/
>>>
>>> Keys are here:
>>> https://www.apache.org/dist/jmeter/KEYS
>>>
>>> N.B.
>>> To download the dependencies: "ant download_jars"
>>>
>>> To create the jars and test JMeter: "ant package test".
>>>
>>> JMeter 3.0 requires Java 7 or later to run.
>>>
>>> Some known issues and incompatible changes are listed on changes page.
>>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/changes.html
>>>
>>>
>>> All feedback and vote are welcome.
>>>
>>> [  ] +1  I support this release
>>> [  ] +0  I am OK with this release
>>> [ x] -0   OK, but
>>>
>>> I think the small things, that have been observed in this candidate,
>>>
>> should be cared for:
>>* Missing files (reported by sebb)
>>* Mac-Icon (reported by sebb) (We probably use just the feather, as
>> it
>> is
>> nearly quadratic)
>>* exec permissions (reported by sebb)
>>* report generation in combination with distributed testing
>> (reported
>> by
>> pmouawad)
>>
>> I have committed three fixes for really minor issues:
>>* wrong image width, which would be observable when viewing doc
>> inside
>> jmeter
>>* use (officially) invalid dns names for templates
>>

Re: svn commit: r1742642 - in /jmeter/trunk: bin/jmeter.properties bin/reportgenerator.properties src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java

On 7 May 2016 at 07:10, Philippe Mouawad  wrote:
> Hello,
> I don't see docs update neither.

The only relevant place I can find is properties_reference which I have updated.
If there are any other places let me know.

> But for me it should have been discussed before and commited only after 3.0
> as per milamber request.

I could say the same about the fix you made:

URL: http://svn.apache.org/viewvc?rev=1742104=rev
Log:
Bug 59424 - Visualizer : Add "Clear" in popup menu

That was not even discussed as I recall.

==

The issue was discussed, but the solution was not.

I am not happy releasing the code as it was before.
I should have vetoed the original change.

> Regards
>
> On Saturday, May 7, 2016, sebb  wrote:
>
>> On 6 May 2016 at 22:44, Philippe Mouawad > > wrote:
>> > -1
>> >
>> > I thought no important modification was to be done before 3.0 release ?
>>
>> Is that your only objection?
>>
>> >
>> >
>> > On Fri, May 6, 2016 at 11:38 PM, > wrote:
>> >
>> >> Author: sebb
>> >> Date: Fri May  6 21:38:36 2016
>> >> New Revision: 1742642
>> >>
>> >> URL: http://svn.apache.org/viewvc?rev=1742642=rev
>> >> Log:
>> >> Move ReportGenerator defaults to a separate properties file
>> >>
>> >> Added:
>> >> jmeter/trunk/bin/reportgenerator.properties   (with props)
>> >> Modified:
>> >> jmeter/trunk/bin/jmeter.properties
>> >>
>> >>
>> jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java
>> >>
>> >> Modified: jmeter/trunk/bin/jmeter.properties
>> >> URL:
>> >>
>> http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1742642=1742641=1742642=diff
>> >>
>> >>
>> ==
>> >> --- jmeter/trunk/bin/jmeter.properties (original)
>> >> +++ jmeter/trunk/bin/jmeter.properties Fri May  6 21:38:36 2016
>> >> @@ -1184,116 +1184,6 @@ view.results.tree.renderers_order=.Rende
>> >>  classfinder.functions.contain=.functions.
>> >>  classfinder.functions.notContain=.gui.
>> >>
>> >>
>> >>
>> -#---
>> >> -# Reporting configuration
>> >>
>> >>
>> -#---
>> >> -
>> >> -# Sets the satisfaction threshold for the APDEX calculation (in
>> >> milliseconds).
>> >> -#jmeter.reportgenerator.apdex_satisfied_threshold=500
>> >> -
>> >> -# Sets the tolerance threshold for the APDEX calculation (in
>> >> milliseconds).
>> >> -#jmeter.reportgenerator.apdex_tolerated_threshold=1500
>> >> -
>> >> -# Regular Expression which Indicates which samples to keep for graphs
>> and
>> >> statistics generation.
>> >> -# Empty value means no filtering
>> >> -#jmeter.reportgenerator.sample_filter=
>> >> -
>> >> -# Sets the temporary directory used by the generation process if it
>> needs
>> >> file I/O operations.
>> >> -#jmeter.reportgenerator.temp_dir=temp
>> >> -
>> >> -# Sets the size of the sliding window used by percentile evaluation.
>> >> -# Caution : higher value provides a better accuracy but needs more
>> memory.
>> >> -#jmeter.reportgenerator.statistic_window = 20
>> >> -
>> >> -# Configure this property to change the report title
>> >> -#jmeter.reportgenerator.report_title=Apache JMeter Dashboard
>> >> -
>> >> -# Defines the overall granularity for over time graphs
>> >> -jmeter.reportgenerator.overall_granularity=6
>> >> -
>> >> -# Response Time Percentiles graph definition
>> >>
>> >>
>> -jmeter.reportgenerator.graph.responseTimePercentiles.classname=org.apache.jmeter.report.processor.graph.impl.ResponseTimePercentilesGraphConsumer
>> >> -jmeter.reportgenerator.graph.responseTimePercentiles.title=Response
>> Time
>> >> Percentiles
>> >> -
>> >> -# Response Time Distribution graph definition
>> >>
>> >>
>> -jmeter.reportgenerator.graph.responseTimeDistribution.classname=org.apache.jmeter.report.processor.graph.impl.ResponseTimeDistributionGraphConsumer
>> >> -jmeter.reportgenerator.graph.responseTimeDistribution.title=Response
>> Time
>> >> Distribution
>> >>
>> >>
>> -jmeter.reportgenerator.graph.responseTimeDistribution.property.set_granularity=500
>> >> -
>> >> -# Active Threads Over Time graph definition
>> >>
>> >>
>> -jmeter.reportgenerator.graph.activeThreadsOverTime.classname=org.apache.jmeter.report.processor.graph.impl.ActiveThreadsGraphConsumer
>> >> -jmeter.reportgenerator.graph.activeThreadsOverTime.title=Active Threads
>> >> Over Time
>> >>
>> >>
>> -jmeter.reportgenerator.graph.activeThreadsOverTime.property.set_granularity=${jmeter.reportgenerator.overall_granularity}
>> >> -
>> >> -# Time VS Threads graph definition
>> >>
>> >>
>> -jmeter.reportgenerator.graph.timeVsThreads.classname=org.apache.jmeter.report.processor.graph.impl.TimeVSThreadGraphConsumer
>> >> -jmeter.reportgenerator.graph.timeVsThreads.title=Time VS Threads
>> >> -
>> >> -# Bytes

Re: [VOTE] Release JMeter 3.0 RC3

ok for me

On Saturday, May 7, 2016, Milamber  wrote:

> Hello,
>
> Are you ready for the RC4 ? I can start the release process tonight or
> tomorrow ?
>
> Milamber
>
> On 01/05/2016 14:48, Philippe Mouawad wrote:
>
>> Hi Milamber,
>> It appears we have a last minute regression report:
>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=59401
>>
>> I confirm the issue.
>> Issue is due to HttpClient 4.5.X behaviour:
>>
>> -
>> https://github.com/apache/httpclient/blob/4.5.x/httpclient/src/main/java/org/apache/http/client/protocol/ResponseContentEncoding.java#L142
>>
>>
>> When uncompressing HttpClient removes 3 headers:
>> - Content-Length
>> - Content-Encoding
>> - Content-MD5
>>
>>
>>
>> Regards
>> Philippe
>>
>> On Sat, Apr 30, 2016 at 5:59 PM, Milamber  wrote:
>>
>> Hello,
>>>
>>> I will wait some hours to complete the 72h delay, and put the results of
>>> the RC3 vote. It would seem that we will go to a RC4.
>>>
>>> I would like start the RC4 tomorrow afternoon, so please commit the fixes
>>> of the minor issues found in the RC3 before (< 04:00 PM GMT+1)
>>>
>>> Thanks
>>>
>>> Milamber
>>>
>>>
>>>
>>>
>>> On 30/04/2016 13:23, Philippe Mouawad wrote:
>>>
>>> Hello,
 [-1] for all the reasons mentioned by Felix in the previous mail.

 Regards
 Philippe

 On Sat, Apr 30, 2016 at 1:15 PM, Felix Schumacher <
 felix.schumac...@internetallee.de> wrote:

 Am 28.04.2016 um 00:05 schrieb Milamber:

> Hello,
>
>> The third release candidate for JMeter 3.0 (r1741338) has been
>> prepared,
>> and your votes are solicited.
>>
>> This release brings a lot of new features (over 100) and fixes many
>> bugs
>> (60). The JMeter's logo and the JMeter's website have been refreshed.
>>
>> Please, test this release candidate (with load tests and/or functional
>> tests) using Java 7/8 on Linux/Windows/Mac OS, especially on the
>> changes.
>> The feedback are welcome.
>>
>> You can read the New and Noteworthy section with some screenshots to
>> illustrate improvements and full list of changes at:
>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/changes.html
>>
>> JMeter is a Java desktop application designed to load test functional
>> behavior and measure performance. The current version is targeted at
>> Java
>> 7+.
>>
>> Download - Archives/hashes/sigs:
>>
>> https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC3/
>> (dist revision r13443)
>>
>> RAT report:
>>
>>
>>
>>
>> http://home.apache.org/~milamber/jmeter-3.0RC3/dist/rat-report-jmeter-3.0RC3.txt
>>
>> MD5 hashes of archives for this vote:
>>
>> 35c5e7798f602336c5bbcd8981804443 *apache-jmeter-3.0.tgz
>> 9b8e01f005cfd56b92ae0c828bac54d4 *apache-jmeter-3.0.zip
>> 88f03da71a9c90d21441e9139813afa6 *apache-jmeter-3.0_src.zip
>> e6d7d1ed92830537cd06eb1748a07287 *apache-jmeter-3.0_src.tgz
>>
>> Site Docs are here:
>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/
>>
>> Maven staging repository is accessible here:
>>
>>
>>
>> https://repository.apache.org/content/repositories/orgapachejmeter-1008/org/apache/jmeter/
>>
>> Tag:
>> https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC3/
>>
>> Keys are here:
>> https://www.apache.org/dist/jmeter/KEYS
>>
>> N.B.
>> To download the dependencies: "ant download_jars"
>>
>> To create the jars and test JMeter: "ant package test".
>>
>> JMeter 3.0 requires Java 7 or later to run.
>>
>> Some known issues and incompatible changes are listed on changes page.
>> http://home.apache.org/~milamber/jmeter-3.0RC3/docs/changes.html
>>
>>
>> All feedback and vote are welcome.
>>
>> [  ] +1  I support this release
>> [  ] +0  I am OK with this release
>> [ x] -0   OK, but
>>
>> I think the small things, that have been observed in this candidate,
>>
> should be cared for:
>* Missing files (reported by sebb)
>* Mac-Icon (reported by sebb) (We probably use just the feather, as
> it
> is
> nearly quadratic)
>* exec permissions (reported by sebb)
>* report generation in combination with distributed testing
> (reported
> by
> pmouawad)
>
> I have committed three fixes for really minor issues:
>* wrong image width, which would be observable when viewing doc
> inside
> jmeter
>* use (officially) invalid dns names for templates
>
> Other than that I found no further issues.
>
> Regards,
>Felix
>
> [  ] -1   I do not support this release (please indicate why)
>
> The vote will remain open for at least 72 hours.
>>
>> The PMC members please indicate the mention "(binding)" with your
>> vote.
>>
>>
>> Note: If

Re: [VOTE] Release JMeter 3.0 RC3

2016-05-07 Thread Milamber

Hello,

Are you ready for the RC4 ? I can start the release process tonight or
tomorrow ?

Milamber

On 01/05/2016 14:48, Philippe Mouawad wrote:

Hi Milamber,
It appears we have a last minute regression report:
- https://bz.apache.org/bugzilla/show_bug.cgi?id=59401

I confirm the issue.
Issue is due to HttpClient 4.5.X behaviour:

-
https://github.com/apache/httpclient/blob/4.5.x/httpclient/src/main/java/org/apache/http/client/protocol/ResponseContentEncoding.java#L142

When uncompressing HttpClient removes 3 headers:
- Content-Length
- Content-Encoding
- Content-MD5

Regards
Philippe

On Sat, Apr 30, 2016 at 5:59 PM, Milamber wrote:

Hello,

I will wait some hours to complete the 72h delay, and put the results of
the RC3 vote. It would seem that we will go to a RC4.

I would like start the RC4 tomorrow afternoon, so please commit the fixes
of the minor issues found in the RC3 before (< 04:00 PM GMT+1)

Thanks

Milamber

On 30/04/2016 13:23, Philippe Mouawad wrote:

Hello,
[-1] for all the reasons mentioned by Felix in the previous mail.

Regards
Philippe

On Sat, Apr 30, 2016 at 1:15 PM, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

Am 28.04.2016 um 00:05 schrieb Milamber:

Hello,

The third release candidate for JMeter 3.0 (r1741338) has been prepared,
and your votes are solicited.

This release brings a lot of new features (over 100) and fixes many bugs
(60). The JMeter's logo and the JMeter's website have been refreshed.

Please, test this release candidate (with load tests and/or functional
tests) using Java 7/8 on Linux/Windows/Mac OS, especially on the
changes.
The feedback are welcome.

You can read the New and Noteworthy section with some screenshots to
illustrate improvements and full list of changes at:
http://home.apache.org/~milamber/jmeter-3.0RC3/docs/changes.html

JMeter is a Java desktop application designed to load test functional
behavior and measure performance. The current version is targeted at
Java
7+.

Download - Archives/hashes/sigs:

https://dist.apache.org/repos/dist/dev/jmeter/v3.0_RC3/
(dist revision r13443)

RAT report:

http://home.apache.org/~milamber/jmeter-3.0RC3/dist/rat-report-jmeter-3.0RC3.txt

MD5 hashes of archives for this vote:

35c5e7798f602336c5bbcd8981804443 *apache-jmeter-3.0.tgz
9b8e01f005cfd56b92ae0c828bac54d4 *apache-jmeter-3.0.zip
88f03da71a9c90d21441e9139813afa6 *apache-jmeter-3.0_src.zip
e6d7d1ed92830537cd06eb1748a07287 *apache-jmeter-3.0_src.tgz

Site Docs are here:
http://home.apache.org/~milamber/jmeter-3.0RC3/docs/

Maven staging repository is accessible here:

https://repository.apache.org/content/repositories/orgapachejmeter-1008/org/apache/jmeter/

Tag:
https://svn.apache.org/repos/asf/jmeter/tags/v3_0_RC3/

Keys are here:
https://www.apache.org/dist/jmeter/KEYS

N.B.
To download the dependencies: "ant download_jars"

To create the jars and test JMeter: "ant package test".

JMeter 3.0 requires Java 7 or later to run.

Some known issues and incompatible changes are listed on changes page.
http://home.apache.org/~milamber/jmeter-3.0RC3/docs/changes.html

All feedback and vote are welcome.

[ ] +1 I support this release
[ ] +0 I am OK with this release
[ x] -0 OK, but

I think the small things, that have been observed in this candidate,

should be cared for:
* Missing files (reported by sebb)
* Mac-Icon (reported by sebb) (We probably use just the feather, as it
is
nearly quadratic)
* exec permissions (reported by sebb)
* report generation in combination with distributed testing (reported
by
pmouawad)

I have committed three fixes for really minor issues:
* wrong image width, which would be observable when viewing doc inside
jmeter
* use (officially) invalid dns names for templates

Other than that I found no further issues.

Regards,
Felix

[ ] -1 I do not support this release (please indicate why)

The vote will remain open for at least 72 hours.

The PMC members please indicate the mention "(binding)" with your vote.

Note: If the vote passes, the intention is to release the archive files
and rename the RC tag as the release tag.

Thanks in advance!

Milamber

Re: svn commit: r1742642 - in /jmeter/trunk: bin/jmeter.properties bin/reportgenerator.properties src/core/org/apache/jmeter/report/dashboard/ReportGenerator.java