[GitHub] jmeter issue #233: Bug 60274

[blindio]

Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
All build and test errors that I believe that I introduced  are resolved. 
Please tell me if this is incorrect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #233: Bug 60274

[blindio]

GitHub user blindio opened a pull request:

https://github.com/apache/jmeter/pull/233

Bug 60274



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Nordstrom/jmeter 60274

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/233.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #233


commit 732b0e23a7737962c71de23b9a76ac888191bd48
Author: Thorson Little 
Date:   2016-06-01T01:49:16Z

initial import with working gui

commit c1e5d984687313f4225ba35fefd2b45d57108466
Author: Thorson Little 
Date:   2016-06-02T19:10:02Z

Refactored for readability plus some bug fixes

commit 86f2dedc60325ddbd56071d990ffc4dbef7dd7ea
Author: Thorson Little 
Date:   2016-06-02T20:20:13Z

Removed randomizer object since I determined that new WeightedDistCtrl
object were created for each thread thus new Random objects

commit 0e26a2ca5f8958fe9a86fd83ae7207d865a2af99
Author: Thorson Little 
Date:   2016-06-02T21:45:27Z

Fixed issue when only zero-weight children exist

commit d56d436e75b1667ea4235517b7f823aceab4a245
Author: Thorson Little 
Date:   2016-06-02T23:58:08Z

added unit tests, fixed a null pointer  error bug revealed by unit
tests.  the unit test testDistributionWithAllDisabled fails by throwing
all of the results to a single test elment when none should be called.
will investigate

commit 553b5d9b4402d893951344826b8ae7d6313af6c0
Author: Thorson Little 
Date:   2016-06-03T23:19:10Z

Added unit tests for various sampler configurations.  fixed bug where
disabled samplers are eliminated in addTestElement.  added an
abstraction over the randomizer for unit-test-ability

commit 31214ba265ce3e0774ba4a7fd48e13e8a842a6e2
Author: Thorson Little 
Date:   2016-06-05T08:35:39Z

removed referenced to perThreadCheckbox

commit 7807159a5ab0e7ed69ad1390acc7f469f51afcad
Author: Thorson Little 
Date:   2016-06-07T21:50:01Z

Added functionality to use variables for weights and will render those
variables in a column

commit b544c10a9312e9711e8962a78dd0c62ac591f012
Author: Thorson Little 
Date:   2016-06-08T18:38:58Z

Added xdocs component reference

commit 03c9d630d2e27878d87f6d6ceaf94500d7372a83
Author: Thorson Little 
Date:   2016-06-08T23:32:04Z

Code cleanup complete,  more unit tests to add, otehrwise I think that
this is done

commit eec359b7c33466891275568c134800dcb47fe902
Author: Thorson Little 
Date:   2016-06-08T23:36:43Z

copy & paste error in saveservice.props created duplicate
InterleaveControl entry

commit 657419583651d2c6036b82ef5cb90bcb9b7ea6ba
Author: Thorson Little 
Date:   2016-06-17T22:20:03Z

Code cleanup and more unit tests

commit 6a306f8f814d64d06257690be1c42a2d2061ed1d
Author: Thorson Little 
Date:   2016-06-23T23:04:01Z

Better comments and more unit tests

commit 6fbb363c79654072511e6dcc4058c6db1e6da809
Author: Thorson Little 
Date:   2016-06-23T23:10:26Z

Added one more unit test

commit 5b5670e53ca858f9a5daab23fba9b1e53831f321
Author: Thorson Little 
Date:   2016-06-24T21:58:59Z

variable and method renaming

commit eebb29a6407cd1ea658dd64b11fe97e713d97e9d
Author: Thorson Little 
Date:   2016-06-28T17:10:53Z

renamed seed to generator seed

commit 0938aed61bc65d28dbd416a6348008cc16bec060
Author: Thorson Little 
Date:   2016-06-28T17:53:09Z

Merge branch 'trunk' of https://github.com/Nordstrom/jmeter into trunk

commit f55d0e2005d0bcebf39725b2db9be05b0902df6b
Author: Thorson Little 
Date:   2016-06-28T18:03:50Z

Revert "Merge branch 'trunk' of https://github.com/Nordstrom/jmeter into 
trunk"

This reverts commit 0938aed61bc65d28dbd416a6348008cc16bec060, reversing
changes made to eebb29a6407cd1ea658dd64b11fe97e713d97e9d.

commit 6e4179ac513aa97385eb7b8a8bdba71162a378b3
Author: Thorson Little 
Date:   2016-06-28T21:57:06Z

manually merged due to confusion with earlier automated merge

commit e3199a46a5bc5912f90ffe9d1394ae20c50c3434
Author: Thorson Little 
Date:   2016-06-28T22:31:58Z

fixing logging messages

commit b4fe985a5560dd1166a40e8395be1cb27d1fb4d9
Author: Thorson Little 
Date:   2016-10-05T23:33:10Z

Merge branch 'trunk' of https://github.com/apache/jmeter into trunk

commit 

[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...

[vlsi]

Github user vlsi commented on the issue:

https://github.com/apache/jmeter/pull/231
  
> And if "test duration" parameter is not equal to expected test duration?

Nothing breaks. The idea is as follows: each "test duration" the timer 
produces exact number of samples.

For instance, if configured with "100 samples per hour, test duration 30 
min", then
1) By 30min into the test there will be exactly 50 samples produced
2) By 60min since the beginning there will be exactly 100 samples produced
3) By 90min since the beginning there will be exactly 150 samples produced
4) ...

However, the patterns between 0m..30m, 30m...60m, and 60m...90m will all be 
different. In other words, the timer will create different schedules for each 
30m timeframe.

> I think it's a GUI too complex and I search how to simplify it

Yeah, the UI looks complicated, however I did try to remove non-required 
elements.


On top of that, we might need to introduce "variable rate" somehow. For 
instance, in expression format: like `ramp(10/hour..100/hour in 10 min) 
keep(30min) ramp(..10/hour in 10 min)`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...

[ra0077]

Github user ra0077 commented on the issue:

https://github.com/apache/jmeter/pull/231
  
Thank to the quick answer

"so "test duration" parameter allows the timer to account for the expected 
test duration."

And if "test duration" parameter is not equal to expected test duration?

E.G. if I define a Loop count and not a Duration in the thread group

I think it's a GUI too complex and I search how to simplify it

I will do more test asap

Antonio


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...

[vlsi]

Github user vlsi commented on the issue:

https://github.com/apache/jmeter/pull/231
  
>I don't understand how to use "Test duration" parameter

The timer is random. Suppose one wants to have "100 samples per hour".
Suppose the test duration is 30 minutes.

The "expected" number of samples is 50. Do you remember that the timer is 
random. That basically means the number of produced samples for 30 minutes 
might be 50, it might be 40, and it might easily be 60. At the end of the day, 
poisson arrivals are not guaranteed to produce exactly 50 samples when running 
for 30 minutes under 100 samples/hour load.

In practice, everybody wants "round" numbers in the load reports, so "test 
duartion" parameter allows the timer to account for the expected test duration.
So, the timer ensures that the number of samples would be exactly 50.

Does that make sense?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...

[ra0077]

Github user ra0077 commented on the issue:

https://github.com/apache/jmeter/pull/231
  
Hi,
Thanks for the patch too.
I don't understand how to use "Test duration" parameter

Thank
Antonio


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Simplify JMeter first and following experiences...

[Antonio Gomes Rodrigues]

Hi,

About solution 3 (palette on the right), it's the solution adopted by
Neoload (they have put it in the left)

About Andrey idea, we have already templates. But it could be an
interesting solution but, in my opinion, start with recording template is
better.

Antonio




2016-10-18 13:30 GMT+02:00 Philippe Mouawad :

> Hi Andrei,
> I don't know if we should go that far, as if we have an HTTP Plan then
> users might think they need to configure everything manually instead of
> Recording.
> Or should we go for a Recording template as a start ?
>
>
> Regards
>
> On Tue, Oct 18, 2016 at 1:16 PM, Andrey Pokhilko  wrote:
>
> > IMO JMeter should start with basic HTTP test plan in it, ready to give a
> > try for newbies. Clear/New button should empty it to allow starting
> > clean for those who want to customize things.
> >
> > Andrey Pokhilko
> >
> > On 10/18/2016 02:07 PM, Philippe Mouawad wrote:
> > > Hello,
> > > Thoughts on that ?
> > > Thx
> > >
> > > On Sat, Oct 15, 2016 at 4:44 PM, Philippe Mouawad <
> > > philippe.moua...@gmail.com> wrote:
> > >
> > >> Hello,
> > >> I noticed that newbies are often lost at start when using jmeter and
> > >> search how to add a sampler for example, or don't know where to find
> > some
> > >> particular component in tree menu.
> > >>
> > >> 1)
> > >> I suggest that we add a Thread group by default to a new test plan. As
> > >> long as a view results tree.
> > >> Afaik, I always end up having those 2 elements.
> > >>
> > >> 2)
> > >> In the future we should think about a way to simplify gui.
> > >>
> > >> I think we discussed this in the past but test profile seem to be
> > useful:
> > >> - expert : as today
> > >> - http : keep only http protocol related elements + usual pre/post
> > >> processors, listeners ...
> > >> -jms same but for http
> > >> -jdbc
> > >> - java
> > >> - ldap
> > >> ...
> > >>
> > >> There would be a visible component (toolbar) to switch between
> profiles.
> > >>
> > >> 3)
> > >> Third idea(needs to be improved) add a palette on the right with a
> > >> selectable number of components.
> > >> Users could drag them on tree, this would avoid the unfolding of tree
> > menu
> > >> at different levels.
> > >>
> > >> Other ideas ?
> > >>
> > >> Thoughts ?
> > >>
> > >> Regards
> > >>
> > >>
> > >>
> > >>
> > >>
> > >> --
> > >> Cordialement.
> > >> Philippe Mouawad.
> > >>
> > >>
> > >>
> > >>
> > >
> >
> >
>
>
> --
> Cordialement.
> Philippe Mouawad.
>

Re: Simplify JMeter first and following experiences...

[Philippe Mouawad]

Hi Andrei,
I don't know if we should go that far, as if we have an HTTP Plan then
users might think they need to configure everything manually instead of
Recording.
Or should we go for a Recording template as a start ?


Regards

On Tue, Oct 18, 2016 at 1:16 PM, Andrey Pokhilko  wrote:

> IMO JMeter should start with basic HTTP test plan in it, ready to give a
> try for newbies. Clear/New button should empty it to allow starting
> clean for those who want to customize things.
>
> Andrey Pokhilko
>
> On 10/18/2016 02:07 PM, Philippe Mouawad wrote:
> > Hello,
> > Thoughts on that ?
> > Thx
> >
> > On Sat, Oct 15, 2016 at 4:44 PM, Philippe Mouawad <
> > philippe.moua...@gmail.com> wrote:
> >
> >> Hello,
> >> I noticed that newbies are often lost at start when using jmeter and
> >> search how to add a sampler for example, or don't know where to find
> some
> >> particular component in tree menu.
> >>
> >> 1)
> >> I suggest that we add a Thread group by default to a new test plan. As
> >> long as a view results tree.
> >> Afaik, I always end up having those 2 elements.
> >>
> >> 2)
> >> In the future we should think about a way to simplify gui.
> >>
> >> I think we discussed this in the past but test profile seem to be
> useful:
> >> - expert : as today
> >> - http : keep only http protocol related elements + usual pre/post
> >> processors, listeners ...
> >> -jms same but for http
> >> -jdbc
> >> - java
> >> - ldap
> >> ...
> >>
> >> There would be a visible component (toolbar) to switch between profiles.
> >>
> >> 3)
> >> Third idea(needs to be improved) add a palette on the right with a
> >> selectable number of components.
> >> Users could drag them on tree, this would avoid the unfolding of tree
> menu
> >> at different levels.
> >>
> >> Other ideas ?
> >>
> >> Thoughts ?
> >>
> >> Regards
> >>
> >>
> >>
> >>
> >>
> >> --
> >> Cordialement.
> >> Philippe Mouawad.
> >>
> >>
> >>
> >>
> >
>
>


-- 
Cordialement.
Philippe Mouawad.

Re: Simplify JMeter first and following experiences...

[Andrey Pokhilko]

IMO JMeter should start with basic HTTP test plan in it, ready to give a
try for newbies. Clear/New button should empty it to allow starting
clean for those who want to customize things.

Andrey Pokhilko

On 10/18/2016 02:07 PM, Philippe Mouawad wrote:
> Hello,
> Thoughts on that ?
> Thx
>
> On Sat, Oct 15, 2016 at 4:44 PM, Philippe Mouawad <
> philippe.moua...@gmail.com> wrote:
>
>> Hello,
>> I noticed that newbies are often lost at start when using jmeter and
>> search how to add a sampler for example, or don't know where to find some
>> particular component in tree menu.
>>
>> 1)
>> I suggest that we add a Thread group by default to a new test plan. As
>> long as a view results tree.
>> Afaik, I always end up having those 2 elements.
>>
>> 2)
>> In the future we should think about a way to simplify gui.
>>
>> I think we discussed this in the past but test profile seem to be useful:
>> - expert : as today
>> - http : keep only http protocol related elements + usual pre/post
>> processors, listeners ...
>> -jms same but for http
>> -jdbc
>> - java
>> - ldap
>> ...
>>
>> There would be a visible component (toolbar) to switch between profiles.
>>
>> 3)
>> Third idea(needs to be improved) add a palette on the right with a
>> selectable number of components.
>> Users could drag them on tree, this would avoid the unfolding of tree menu
>> at different levels.
>>
>> Other ideas ?
>>
>> Thoughts ?
>>
>> Regards
>>
>>
>>
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
>>
>>
>>
>

Re: Sent metrics : Should we add it to Summary and Aggregate report ?

[Philippe Mouawad]

Hello,
https://bz.apache.org/bugzilla/show_bug.cgi?id=60252 fixed.
Regards

On Fri, Oct 14, 2016 at 4:42 PM, Antonio Gomes Rodrigues 
wrote:

> Hi,
>
> My opinion is that we need to update them or deprecated them.
> If we don't do that, the reports will not be homogenous
>
> Antonio
>
> 2016-10-13 21:55 GMT+02:00 Philippe Mouawad  >:
>
> > Hello,
> > Following user feedback on addition of sent bytes:
> >
> >- https://bz.apache.org/bugzilla/show_bug.cgi?id=60229
> >
> > The user requested addition of this metric to reports:
> >
> >- https://bz.apache.org/bugzilla/show_bug.cgi?id=60250
> >
> > I implemented it for HTML report and re titled the bug.
> >
> > I created another one for Aggregate and Summary report:
> >
> >- https://bz.apache.org/bugzilla/show_bug.cgi?id=60252
> >
> >
> > I wonder if we should add this metric to those 2 reports.
> >
> > It makes us maintain 3 reports. I think the HTML one is the most complete
> > and easy to use, that's why I updated it, but I didn't for Aggregate and
> > Summary.
> >
> >
> > Regards.
> > Philippe
> >
>



-- 
Cordialement.
Philippe Mouawad.

Re: Simplify JMeter first and following experiences...

[Philippe Mouawad]

Hello,
Thoughts on that ?
Thx

On Sat, Oct 15, 2016 at 4:44 PM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Hello,
> I noticed that newbies are often lost at start when using jmeter and
> search how to add a sampler for example, or don't know where to find some
> particular component in tree menu.
>
> 1)
> I suggest that we add a Thread group by default to a new test plan. As
> long as a view results tree.
> Afaik, I always end up having those 2 elements.
>
> 2)
> In the future we should think about a way to simplify gui.
>
> I think we discussed this in the past but test profile seem to be useful:
> - expert : as today
> - http : keep only http protocol related elements + usual pre/post
> processors, listeners ...
> -jms same but for http
> -jdbc
> - java
> - ldap
> ...
>
> There would be a visible component (toolbar) to switch between profiles.
>
> 3)
> Third idea(needs to be improved) add a palette on the right with a
> selectable number of components.
> Users could drag them on tree, this would avoid the unfolding of tree menu
> at different levels.
>
> Other ideas ?
>
> Thoughts ?
>
> Regards
>
>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
>


-- 
Cordialement.
Philippe Mouawad.