Re: [VOTE] Release JMeter 3.1 RC3

2016-11-13 Thread Andrey Pokhilko
+1 !

Andrey Pokhilko

On 11/13/2016 11:34 AM, Milamber wrote:
> Hello,
>
> The third release candidate for JMeter 3.1 (r1769531) has been
> prepared, and your votes are solicited.
>
> This release brings new features and fixes bugs.
>
> Please, test this release candidate (with load tests and/or functional
> tests) using Java 7/8 on Linux/Windows/Mac OS, especially on the
> changes. The feedback are welcome.
>
> You can read the New and Noteworthy section with some screenshots to
> illustrate improvements and full list of changes at:
> http://home.apache.org/~milamber/jmeter-3.1RC3/docs/changes.html
>
> JMeter is a Java desktop application designed to load test functional
> behavior and measure performance. The current version is targeted at
> Java 7+.
>
> Download - Archives/hashes/sigs:
>
> https://dist.apache.org/repos/dist/dev/jmeter/v3.1_RC3/
> (dist revision r16985)
>
> RAT report:
>
> http://home.apache.org/~milamber/jmeter-3.1RC3/dist/rat-report-jmeter-3.1RC3.txt
>
>
> MD5 hashes of archives for this vote:
>
> 37e3c75cf80d2c60444e429bb0c27ae6 *apache-jmeter-3.1.tgz
> f096f4991454a22850ec6174331cfeed *apache-jmeter-3.1.zip
> a3e308d541a6c077ec322bce0d699a77 *apache-jmeter-3.1_src.tgz
> 96b94f4e0189bd0aa6e578e80323e6b7 *apache-jmeter-3.1_src.zip
>
> Site Docs are here:
> http://home.apache.org/~milamber/jmeter-3.1RC3/docs/
>
> Maven staging repository is accessible here:
> https://repository.apache.org/content/repositories/orgapachejmeter-1013/org/apache/jmeter/
>
>
> Tag:
> https://svn.apache.org/repos/asf/jmeter/tags/v3_1_RC3/
>
> Keys are here:
> https://www.apache.org/dist/jmeter/KEYS
>
> N.B.
> To download the dependencies: "ant download_jars"
>
> To create the jars and test JMeter: "ant package test".
>
> JMeter 3.1 requires Java 7 or later to run.
>
> Some known issues and incompatible changes are listed on changes page.
> http://home.apache.org/~milamber/jmeter-3.1RC3/docs/changes.html#Known%20problems%20and%20workarounds
>
>
>
> All feedback and vote are welcome.
> 
> [  ] +1  I support this release
> [  ] +0  I am OK with this release
> [  ] -0   OK, but
> [  ] -1   I do not support this release (please indicate why)
>
> The vote will remain open for at least 72 hours.
>
> The PMC members please indicate the mention "(binding)" with your vote.
>
>
> Note: If the vote passes, the intention is to release the archive files
> and rename the RC tag as the release tag.
>
> Thanks in advance!
>
> Milamber
>
>
>
>
>
>



[VOTE] Release JMeter 3.1 RC3

2016-11-13 Thread Milamber

Hello,

The third release candidate for JMeter 3.1 (r1769531) has been prepared, 
and your votes are solicited.


This release brings new features and fixes bugs.

Please, test this release candidate (with load tests and/or functional 
tests) using Java 7/8 on Linux/Windows/Mac OS, especially on the 
changes. The feedback are welcome.


You can read the New and Noteworthy section with some screenshots to 
illustrate improvements and full list of changes at:

http://home.apache.org/~milamber/jmeter-3.1RC3/docs/changes.html

JMeter is a Java desktop application designed to load test functional 
behavior and measure performance. The current version is targeted at 
Java 7+.


Download - Archives/hashes/sigs:

https://dist.apache.org/repos/dist/dev/jmeter/v3.1_RC3/
(dist revision r16985)

RAT report:

http://home.apache.org/~milamber/jmeter-3.1RC3/dist/rat-report-jmeter-3.1RC3.txt

MD5 hashes of archives for this vote:

37e3c75cf80d2c60444e429bb0c27ae6 *apache-jmeter-3.1.tgz
f096f4991454a22850ec6174331cfeed *apache-jmeter-3.1.zip
a3e308d541a6c077ec322bce0d699a77 *apache-jmeter-3.1_src.tgz
96b94f4e0189bd0aa6e578e80323e6b7 *apache-jmeter-3.1_src.zip

Site Docs are here:
http://home.apache.org/~milamber/jmeter-3.1RC3/docs/

Maven staging repository is accessible here:
https://repository.apache.org/content/repositories/orgapachejmeter-1013/org/apache/jmeter/

Tag:
https://svn.apache.org/repos/asf/jmeter/tags/v3_1_RC3/

Keys are here:
https://www.apache.org/dist/jmeter/KEYS

N.B.
To download the dependencies: "ant download_jars"

To create the jars and test JMeter: "ant package test".

JMeter 3.1 requires Java 7 or later to run.

Some known issues and incompatible changes are listed on changes page.
http://home.apache.org/~milamber/jmeter-3.1RC3/docs/changes.html#Known%20problems%20and%20workarounds


All feedback and vote are welcome.

[  ] +1  I support this release
[  ] +0  I am OK with this release
[  ] -0   OK, but
[  ] -1   I do not support this release (please indicate why)

The vote will remain open for at least 72 hours.

The PMC members please indicate the mention "(binding)" with your vote.


Note: If the vote passes, the intention is to release the archive files
and rename the RC tag as the release tag.

Thanks in advance!

Milamber








Re: BEFORE RELEASE CHECK : SVN Properties

2016-11-13 Thread Felix Schumacher


Am 13. November 2016 18:20:52 MEZ, schrieb Philippe Mouawad 
:
>On Sun, Nov 13, 2016 at 5:19 PM, Felix Schumacher <
>felix.schumac...@internetallee.de> wrote:
>
>>
>>
>> Am 13. November 2016 18:13:41 MEZ, schrieb Philippe Mouawad <
>> philippe.moua...@gmail.com>:
>> >Hello,
>> >Currently Readme.md has no svn properties.
>> >Shouldn't it have svn:eol : native ?
>>
>> Yes. Native seems to be right.
>>
>> >
>> >
>> >Also I think README  is referenced when building instead of
>README.md.
>>
>> Don't know what you mean by this.
>>
>See my last commit

Great.

>
>By the way I moved eclipse.readme to eclipse.md, shall I commit it ?

I am OK with it.

Felix

>
>
>>
>> Felix
>> >
>> >Regards
>> >Philippe M
>>
>>



JMeter not mirrored to github since 6 days

2016-11-13 Thread Philippe Mouawad
Hi,
I've created this ticket for that:

https://issues.apache.org/jira/servicedesk/agent/INFRA/issue/INFRA-12906

Regards
Philippe


Re: BEFORE RELEASE CHECK : SVN Properties

2016-11-13 Thread Philippe Mouawad
On Sun, Nov 13, 2016 at 5:19 PM, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

>
>
> Am 13. November 2016 18:13:41 MEZ, schrieb Philippe Mouawad <
> philippe.moua...@gmail.com>:
> >Hello,
> >Currently Readme.md has no svn properties.
> >Shouldn't it have svn:eol : native ?
>
> Yes. Native seems to be right.
>
> >
> >
> >Also I think README  is referenced when building instead of README.md.
>
> Don't know what you mean by this.
>
See my last commit

By the way I moved eclipse.readme to eclipse.md, shall I commit it ?


>
> Felix
> >
> >Regards
> >Philippe M
>
>


-- 
Cordialement.
Philippe Mouawad.


Re: BEFORE RELEASE CHECK : SVN Properties

2016-11-13 Thread Felix Schumacher


Am 13. November 2016 18:13:41 MEZ, schrieb Philippe Mouawad 
:
>Hello,
>Currently Readme.md has no svn properties.
>Shouldn't it have svn:eol : native ?

Yes. Native seems to be right.

>
>
>Also I think README  is referenced when building instead of README.md.

Don't know what you mean by this. 

Felix
>
>Regards
>Philippe M



BEFORE RELEASE CHECK : SVN Properties

2016-11-13 Thread Philippe Mouawad
Hello,
Currently Readme.md has no svn properties.
Shouldn't it have svn:eol : native ?


Also I think README  is referenced when building instead of README.md.

Regards
Philippe M


Re: buildbot failure in on jmeter-trunk [Tag: Ant, Buildbot]

2016-11-13 Thread Felix Schumacher


Am 13. November 2016 17:37:00 MEZ, schrieb Milamber :
>
>
>On 13/11/2016 13:06, sebb wrote:
>> On 13 November 2016 at 12:40, Felix Schumacher
>>  wrote:
>>> Am 13.11.2016 13:34, schrieb Milamber:
 Hello,

 With commit 1769490, I force the usage of Ant > 1.9.1 for JMeter.

 I've open a Infra ticket [1] to have a more recent version of Ant
>for
 the CI buildbot task. (currently I thinks it's Ant 1.8.2)

 Already says, this issue isn't a blocker for the 3.1 RC3. I will
>start
 the release process in few hours.

 Milamber

 For the record (in this mailing list) :
 - original JMeter buildbot request [2]
 - current JMeter buildbot config file [3]
>>>
>>> Hemera as a build slave will be gone by the 30. November. I have
>changed the
>>> slaves to bb_slave1_ubuntu in [3] as suggested by infra. But it
>seems that
>>> changing [3] is not enough.
>> AFAIK, some config changes need to be manually applied.
>> You might need to ask Infra to do so.
>
>
>I've just update the Infra ticket to indicate this.

Great.

Felix

>
>
>
>>
>>> So hopefully your ticket will help.
>>>
>>> Regards,
>>>   Felix
>>>
>>>
 [1] https://issues.apache.org/jira/browse/INFRA-12903
 [2] https://issues.apache.org/jira/browse/INFRA-4025
 [3]


>https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/jmeter.conf



 On 13/11/2016 11:26, Milamber wrote:
>
>
> Root cause :
>
> "The if/unless namespaces are only available since Ant 1.9.1."
> the if/unless namespaces was introduced with Bugzilla 60364
>
>
>
>http://stackoverflow.com/questions/35393545/how-can-i-provide-a-conditional-jvmarg-for-the-ant-junit-command
> On 13/11/2016 10:23, Milamber wrote:
>>
>>
>> On 13/11/2016 10:04, Philippe Mouawad wrote:
>>> Hi,
>>> Can we upgrade ant on build bot ?
>>
>> I don't know.
>>
>>
>> The error come because the call of
>org.apache.jorphan.test.AllTests in
>> _test task don't have the jacocoagent property (with ant 1.8).
>Currently I
>> try to find a bypass like the test.headless property...
>>
>>> Do you plan the release today ?
>>
>> yes, i would like. But this buildbot error is annoying even if
>not a
>> blocker to build JMeter (if I use a Ant > 1.9)
>>
>> Milamber
>>
>>> Thanks
>>>
>>> On Sunday, November 13, 2016, Milamber 
>wrote:
>>>
 I can reproduce this error with Ant 1.8.4. (works fine with Ant
>1.9.7)



 On 12/11/2016 20:41, Philippe Mouawad wrote:

> Hello,
> I don't know how to fix this issue on buildbox.
> It's not happening on jenkins.
>
> Regards
>
> On Sat, Nov 12, 2016 at 4:23 PM,  wrote:
>
> The Buildbot has detected a new failure on builder
>jmeter-trunk while
>> building . Full details are available at:
>> https://ci.apache.org/builders/jmeter-trunk/builds/1621
>>
>> Buildbot URL: https://ci.apache.org/
>>
>> Buildslave for this Build: hemera_ubuntu
>>
>> Build Reason: The AnyBranchScheduler scheduler named
>> 'on-jmeter-commit'
>> triggered this build
>> Build Source Stamp: [branch jmeter/trunk] 1769389
>> Blamelist: pmouawad
>>
>> BUILD FAILED: failed shell_3
>>
>> Sincerely,
>> -The Buildbot
>>
>>
>>
>>
>>
>>
>



Re: svn commit: r1769411 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java

2016-11-13 Thread Philippe Mouawad
Hi,
Yes sync on a new object is better.
Note this wrong combination is present in code at many places.
Regards

On Sun, Nov 13, 2016 at 1:47 PM, sebb  wrote:

> Might be better to synch on a separate Object e.g.:
>
> private final Object LOCK = new Object();
>
> On 13 November 2016 at 12:45, Felix Schumacher
>  wrote:
> > Am 12.11.2016 21:29, schrieb pmoua...@apache.org:
> >>
> >> Author: pmouawad
> >> Date: Sat Nov 12 20:29:20 2016
> >> New Revision: 1769411
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1769411=rev
> >> Log:
> >> Sync on final field
> >>
> >> Modified:
> >>
> >>
> >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> TableVisualizer.java
> >>
> >> Modified:
> >>
> >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> TableVisualizer.java
> >> URL:
> >>
> >> http://svn.apache.org/viewvc/jmeter/trunk/src/components/
> org/apache/jmeter/visualizers/TableVisualizer.java?rev=
> 1769411=1769410=1769411=diff
> >>
> >> 
> ==
> >> ---
> >>
> >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> TableVisualizer.java
> >> (original)
> >> +++
> >>
> >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> TableVisualizer.java
> >> Sat Nov 12 20:29:20 2016
> >> @@ -106,7 +106,7 @@ public class TableVisualizer extends Abs
> >>
> >>  private JCheckBox childSamples = null;
> >>
> >> -private transient Calculator calc = new Calculator();
> >> +private final transient Calculator calc = new Calculator();
> >
> >
> > I don't think that "final transient" is a valid combination of modifiers.
> >
> >
> > Regards,
> >  Felix
> >
> >>
> >>  private Format format = new SimpleDateFormat("HH:mm:ss.SSS");
> >> //$NON-NLS-1$
>



-- 
Cordialement.
Philippe Mouawad.


Re: buildbot failure in on jmeter-trunk [Tag: Ant, Buildbot]

2016-11-13 Thread sebb
On 13 November 2016 at 12:40, Felix Schumacher
 wrote:
> Am 13.11.2016 13:34, schrieb Milamber:
>>
>> Hello,
>>
>> With commit 1769490, I force the usage of Ant > 1.9.1 for JMeter.
>>
>> I've open a Infra ticket [1] to have a more recent version of Ant for
>> the CI buildbot task. (currently I thinks it's Ant 1.8.2)
>>
>> Already says, this issue isn't a blocker for the 3.1 RC3. I will start
>> the release process in few hours.
>>
>> Milamber
>>
>> For the record (in this mailing list) :
>> - original JMeter buildbot request [2]
>> - current JMeter buildbot config file [3]
>
>
> Hemera as a build slave will be gone by the 30. November. I have changed the
> slaves to bb_slave1_ubuntu in [3] as suggested by infra. But it seems that
> changing [3] is not enough.

AFAIK, some config changes need to be manually applied.
You might need to ask Infra to do so.

> So hopefully your ticket will help.
>
> Regards,
>  Felix
>
>
>>
>> [1] https://issues.apache.org/jira/browse/INFRA-12903
>> [2] https://issues.apache.org/jira/browse/INFRA-4025
>> [3]
>>
>> https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/jmeter.conf
>>
>>
>>
>> On 13/11/2016 11:26, Milamber wrote:
>>>
>>>
>>>
>>> Root cause :
>>>
>>> "The if/unless namespaces are only available since Ant 1.9.1."
>>> the if/unless namespaces was introduced with Bugzilla 60364
>>>
>>>
>>> http://stackoverflow.com/questions/35393545/how-can-i-provide-a-conditional-jvmarg-for-the-ant-junit-command
>>> On 13/11/2016 10:23, Milamber wrote:



 On 13/11/2016 10:04, Philippe Mouawad wrote:
>
> Hi,
> Can we upgrade ant on build bot ?


 I don't know.


 The error come because the call of org.apache.jorphan.test.AllTests in
 _test task don't have the jacocoagent property (with ant 1.8). Currently I
 try to find a bypass like the test.headless property...

>
> Do you plan the release today ?


 yes, i would like. But this buildbot error is annoying even if not a
 blocker to build JMeter (if I use a Ant > 1.9)

 Milamber

>
> Thanks
>
> On Sunday, November 13, 2016, Milamber  wrote:
>
>> I can reproduce this error with Ant 1.8.4. (works fine with Ant 1.9.7)
>>
>>
>>
>> On 12/11/2016 20:41, Philippe Mouawad wrote:
>>
>>> Hello,
>>> I don't know how to fix this issue on buildbox.
>>> It's not happening on jenkins.
>>>
>>> Regards
>>>
>>> On Sat, Nov 12, 2016 at 4:23 PM,  wrote:
>>>
>>> The Buildbot has detected a new failure on builder jmeter-trunk while

 building . Full details are available at:
 https://ci.apache.org/builders/jmeter-trunk/builds/1621

 Buildbot URL: https://ci.apache.org/

 Buildslave for this Build: hemera_ubuntu

 Build Reason: The AnyBranchScheduler scheduler named
 'on-jmeter-commit'
 triggered this build
 Build Source Stamp: [branch jmeter/trunk] 1769389
 Blamelist: pmouawad

 BUILD FAILED: failed shell_3

 Sincerely,
-The Buildbot







>>>
>>>
>


Re: svn commit: r1769411 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java

2016-11-13 Thread sebb
Might be better to synch on a separate Object e.g.:

private final Object LOCK = new Object();

On 13 November 2016 at 12:45, Felix Schumacher
 wrote:
> Am 12.11.2016 21:29, schrieb pmoua...@apache.org:
>>
>> Author: pmouawad
>> Date: Sat Nov 12 20:29:20 2016
>> New Revision: 1769411
>>
>> URL: http://svn.apache.org/viewvc?rev=1769411=rev
>> Log:
>> Sync on final field
>>
>> Modified:
>>
>>
>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
>>
>> Modified:
>>
>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
>> URL:
>>
>> http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java?rev=1769411=1769410=1769411=diff
>>
>> ==
>> ---
>>
>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
>> (original)
>> +++
>>
>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
>> Sat Nov 12 20:29:20 2016
>> @@ -106,7 +106,7 @@ public class TableVisualizer extends Abs
>>
>>  private JCheckBox childSamples = null;
>>
>> -private transient Calculator calc = new Calculator();
>> +private final transient Calculator calc = new Calculator();
>
>
> I don't think that "final transient" is a valid combination of modifiers.
>
>
> Regards,
>  Felix
>
>>
>>  private Format format = new SimpleDateFormat("HH:mm:ss.SSS");
>> //$NON-NLS-1$


Re: svn commit: r1769411 - /jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java

2016-11-13 Thread Felix Schumacher

Am 12.11.2016 21:29, schrieb pmoua...@apache.org:

Author: pmouawad
Date: Sat Nov 12 20:29:20 2016
New Revision: 1769411

URL: http://svn.apache.org/viewvc?rev=1769411=rev
Log:
Sync on final field

Modified:

jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java

Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java?rev=1769411=1769410=1769411=diff
==
---
jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
(original)
+++
jmeter/trunk/src/components/org/apache/jmeter/visualizers/TableVisualizer.java
Sat Nov 12 20:29:20 2016
@@ -106,7 +106,7 @@ public class TableVisualizer extends Abs

 private JCheckBox childSamples = null;

-private transient Calculator calc = new Calculator();
+private final transient Calculator calc = new Calculator();


I don't think that "final transient" is a valid combination of 
modifiers.



Regards,
 Felix


 private Format format = new SimpleDateFormat("HH:mm:ss.SSS"); 
//$NON-NLS-1$


Re: buildbot failure in on jmeter-trunk [Tag: Ant, Buildbot]

2016-11-13 Thread Felix Schumacher

Am 13.11.2016 13:34, schrieb Milamber:

Hello,

With commit 1769490, I force the usage of Ant > 1.9.1 for JMeter.

I've open a Infra ticket [1] to have a more recent version of Ant for
the CI buildbot task. (currently I thinks it's Ant 1.8.2)

Already says, this issue isn't a blocker for the 3.1 RC3. I will start
the release process in few hours.

Milamber

For the record (in this mailing list) :
- original JMeter buildbot request [2]
- current JMeter buildbot config file [3]


Hemera as a build slave will be gone by the 30. November. I have changed 
the slaves to bb_slave1_ubuntu in [3] as suggested by infra. But it 
seems that changing [3] is not enough.


So hopefully your ticket will help.

Regards,
 Felix



[1] https://issues.apache.org/jira/browse/INFRA-12903
[2] https://issues.apache.org/jira/browse/INFRA-4025
[3]
https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/jmeter.conf



On 13/11/2016 11:26, Milamber wrote:



Root cause :

"The if/unless namespaces are only available since Ant 1.9.1."
the if/unless namespaces was introduced with Bugzilla 60364

http://stackoverflow.com/questions/35393545/how-can-i-provide-a-conditional-jvmarg-for-the-ant-junit-command 
On 13/11/2016 10:23, Milamber wrote:



On 13/11/2016 10:04, Philippe Mouawad wrote:

Hi,
Can we upgrade ant on build bot ?


I don't know.


The error come because the call of org.apache.jorphan.test.AllTests 
in _test task don't have the jacocoagent property (with ant 1.8). 
Currently I try to find a bypass like the test.headless property...




Do you plan the release today ?


yes, i would like. But this buildbot error is annoying even if not a 
blocker to build JMeter (if I use a Ant > 1.9)


Milamber



Thanks

On Sunday, November 13, 2016, Milamber  wrote:

I can reproduce this error with Ant 1.8.4. (works fine with Ant 
1.9.7)




On 12/11/2016 20:41, Philippe Mouawad wrote:


Hello,
I don't know how to fix this issue on buildbox.
It's not happening on jenkins.

Regards

On Sat, Nov 12, 2016 at 4:23 PM,  wrote:

The Buildbot has detected a new failure on builder jmeter-trunk 
while

building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/1621

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-jmeter-commit'

triggered this build
Build Source Stamp: [branch jmeter/trunk] 1769389
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
   -The Buildbot













Re: buildbot failure in on jmeter-trunk [Tag: Ant, Buildbot]

2016-11-13 Thread Milamber

Hello,

With commit 1769490, I force the usage of Ant > 1.9.1 for JMeter.

I've open a Infra ticket [1] to have a more recent version of Ant for 
the CI buildbot task. (currently I thinks it's Ant 1.8.2)


Already says, this issue isn't a blocker for the 3.1 RC3. I will start 
the release process in few hours.


Milamber

For the record (in this mailing list) :
- original JMeter buildbot request [2]
- current JMeter buildbot config file [3]

[1] https://issues.apache.org/jira/browse/INFRA-12903
[2] https://issues.apache.org/jira/browse/INFRA-4025
[3] 
https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/jmeter.conf




On 13/11/2016 11:26, Milamber wrote:



Root cause :

"The if/unless namespaces are only available since Ant 1.9.1."
the if/unless namespaces was introduced with Bugzilla 60364

http://stackoverflow.com/questions/35393545/how-can-i-provide-a-conditional-jvmarg-for-the-ant-junit-command 




On 13/11/2016 10:23, Milamber wrote:



On 13/11/2016 10:04, Philippe Mouawad wrote:

Hi,
Can we upgrade ant on build bot ?


I don't know.


The error come because the call of org.apache.jorphan.test.AllTests 
in _test task don't have the jacocoagent property (with ant 1.8). 
Currently I try to find a bypass like the test.headless property...




Do you plan the release today ?


yes, i would like. But this buildbot error is annoying even if not a 
blocker to build JMeter (if I use a Ant > 1.9)


Milamber



Thanks

On Sunday, November 13, 2016, Milamber  wrote:


I can reproduce this error with Ant 1.8.4. (works fine with Ant 1.9.7)



On 12/11/2016 20:41, Philippe Mouawad wrote:


Hello,
I don't know how to fix this issue on buildbox.
It's not happening on jenkins.

Regards

On Sat, Nov 12, 2016 at 4:23 PM,  wrote:

The Buildbot has detected a new failure on builder jmeter-trunk while

building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/1621

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-jmeter-commit'

triggered this build
Build Source Stamp: [branch jmeter/trunk] 1769389
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
   -The Buildbot















Re: buildbot failure in on jmeter-trunk

2016-11-13 Thread Milamber



Root cause :

"The if/unless namespaces are only available since Ant 1.9.1."
the if/unless namespaces was introduced with Bugzilla 60364

http://stackoverflow.com/questions/35393545/how-can-i-provide-a-conditional-jvmarg-for-the-ant-junit-command


On 13/11/2016 10:23, Milamber wrote:



On 13/11/2016 10:04, Philippe Mouawad wrote:

Hi,
Can we upgrade ant on build bot ?


I don't know.


The error come because the call of org.apache.jorphan.test.AllTests in 
_test task don't have the jacocoagent property (with ant 1.8). 
Currently I try to find a bypass like the test.headless property...




Do you plan the release today ?


yes, i would like. But this buildbot error is annoying even if not a 
blocker to build JMeter (if I use a Ant > 1.9)


Milamber



Thanks

On Sunday, November 13, 2016, Milamber  wrote:


I can reproduce this error with Ant 1.8.4. (works fine with Ant 1.9.7)



On 12/11/2016 20:41, Philippe Mouawad wrote:


Hello,
I don't know how to fix this issue on buildbox.
It's not happening on jenkins.

Regards

On Sat, Nov 12, 2016 at 4:23 PM,  wrote:

The Buildbot has detected a new failure on builder jmeter-trunk while

building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/1621

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-jmeter-commit'

triggered this build
Build Source Stamp: [branch jmeter/trunk] 1769389
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
   -The Buildbot












Re: buildbot failure in on jmeter-trunk

2016-11-13 Thread Milamber



On 13/11/2016 10:04, Philippe Mouawad wrote:

Hi,
Can we upgrade ant on build bot ?


I don't know.


The error come because the call of org.apache.jorphan.test.AllTests in 
_test task don't have the jacocoagent property (with ant 1.8). Currently 
I try to find a bypass like the test.headless property...




Do you plan the release today ?


yes, i would like. But this buildbot error is annoying even if not a 
blocker to build JMeter (if I use a Ant > 1.9)


Milamber



Thanks

On Sunday, November 13, 2016, Milamber  wrote:


I can reproduce this error with Ant 1.8.4. (works fine with Ant 1.9.7)



On 12/11/2016 20:41, Philippe Mouawad wrote:


Hello,
I don't know how to fix this issue on buildbox.
It's not happening on jenkins.

Regards

On Sat, Nov 12, 2016 at 4:23 PM,  wrote:

The Buildbot has detected a new failure on builder jmeter-trunk while

building . Full details are available at:
  https://ci.apache.org/builders/jmeter-trunk/builds/1621

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit'
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1769389
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
   -The Buildbot









Re: buildbot failure in on jmeter-trunk

2016-11-13 Thread Philippe Mouawad
Hi,
Can we upgrade ant on build bot ?

Do you plan the release today ?

Thanks

On Sunday, November 13, 2016, Milamber  wrote:

>
> I can reproduce this error with Ant 1.8.4. (works fine with Ant 1.9.7)
>
>
>
> On 12/11/2016 20:41, Philippe Mouawad wrote:
>
>> Hello,
>> I don't know how to fix this issue on buildbox.
>> It's not happening on jenkins.
>>
>> Regards
>>
>> On Sat, Nov 12, 2016 at 4:23 PM,  wrote:
>>
>> The Buildbot has detected a new failure on builder jmeter-trunk while
>>> building . Full details are available at:
>>>  https://ci.apache.org/builders/jmeter-trunk/builds/1621
>>>
>>> Buildbot URL: https://ci.apache.org/
>>>
>>> Buildslave for this Build: hemera_ubuntu
>>>
>>> Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit'
>>> triggered this build
>>> Build Source Stamp: [branch jmeter/trunk] 1769389
>>> Blamelist: pmouawad
>>>
>>> BUILD FAILED: failed shell_3
>>>
>>> Sincerely,
>>>   -The Buildbot
>>>
>>>
>>>
>>>
>>>
>>
>

-- 
Cordialement.
Philippe Mouawad.


Re: buildbot failure in on jmeter-trunk

2016-11-13 Thread Milamber


I can reproduce this error with Ant 1.8.4. (works fine with Ant 1.9.7)



On 12/11/2016 20:41, Philippe Mouawad wrote:

Hello,
I don't know how to fix this issue on buildbox.
It's not happening on jenkins.

Regards

On Sat, Nov 12, 2016 at 4:23 PM,  wrote:


The Buildbot has detected a new failure on builder jmeter-trunk while
building . Full details are available at:
 https://ci.apache.org/builders/jmeter-trunk/builds/1621

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit'
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1769389
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
  -The Buildbot










[GitHub] jmeter issue #233: Bug 60274

2016-11-13 Thread blindio
Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
Agreed, I need to find some time to consider this issue.  I may be that the
variable resolution is not feasible without major changes.

Again, thank you,

Thorson

On Nov 13, 2016 1:18 AM, "Vladimir Sitnikov" 
wrote:

> I will test and consider a solution
>
> The question is if that is feasible at all to support run-time variable
> changes and keep the performance sane
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] jmeter issue #233: Bug 60274

2016-11-13 Thread vlsi
Github user vlsi commented on the issue:

https://github.com/apache/jmeter/pull/233
  
> I will test and consider a solution

The question is if that is feasible at all to support run-time variable 
changes and keep the performance sane


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] jmeter issue #233: Bug 60274

2016-11-13 Thread blindio
Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
Regarding the run time variable changes, that is a really good point.  I
will test and consider a solution.

Thank you,

Thorson

On Nov 12, 2016 11:39 PM, "Vladimir Sitnikov" 
wrote:

> *@vlsi* commented on this pull request.
> --
>
> In src/components/org/apache/jmeter/control/WeightedDistributionController
> .java
> :
>
> > + *the index of the child node
> + * @return the child test element
> + */
> +public TestElement getChildTestElement(int idx) {
> +JMeterTreeNode childNode = getChildNode(idx);
> +return childNode == null ? null : childNode.getTestElement();
> +}
> +
> +/**
> + * Gets the cumulative probability.
> + *
> + * @return the cumulative probability
> + */
> +public int getCumulativeProbability() {
> +// recalculate if reset flag is set
> +if (resetCumulativeProbability) {
>
> Can you clarify when weight is recalculated?
> The documentation suggests that weight is recalculated at run-time,
> however the flag resetCumulativeProbability is reset at design time only.
> That is it looks like weight distribution would not account for the
> variable changes in the runtime. Is that the case? Can you make
> documentation/intention more clear?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] jmeter issue #233: Bug 60274

2016-11-13 Thread vlsi
Github user vlsi commented on the issue:

https://github.com/apache/jmeter/pull/233
  
Just in case, C and C1 has the following groovy post-processor: 
`vars.put("x", String.valueOf(1+Integer.parseInt(vars.get("x"`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] jmeter issue #233: Bug 60274

2016-11-13 Thread blindio
Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
That is strange about the nesting not working, given that I manually tested
nesting, and it is one of the unit tests as well. I will investigate.

On Nov 13, 2016 12:08 AM, "Vladimir Sitnikov" 
wrote:

> While being able to enable-disable and rename the children from WDC UI is
> nice, I wonder how many worms are hidden in that "keep WDC and children
> tree" consistent can.
>
> Nested "Weighted Distribution Controller" elements does not seem to work.
>
> [image: 2016-11-13 11 05 00]
> 

>
> [image: 2016-11-13 11 05 04]
> 

>
> [image: 2016-11-13 11 05 09]
> 

>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] jmeter issue #233: Bug 60274

2016-11-13 Thread blindio
Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
The reason that I do not rely on the seed is because, as I understand it,
you can count on seed to be consistent within am implementation of random,
but not across implementations.

Users of 3rd party JVMs may have consistent failures in the unit tests
because their implementation of Random provides a different distribution
than those using the Open/Oracle JVM.

Since the intention of the test is to determine if all potential random
numbers bin correctly, the systematic approach guarantees correct binning.

Furthermore, magic numbers in unit tests should be avoided if at all
possible.

-Thorson

On Nov 12, 2016 11:33 PM, "Vladimir Sitnikov" 
wrote:

> *@vlsi* commented on this pull request.
> --
>
> In src/components/org/apache/jmeter/control/WeightedDistributionController
> .java
> :
>
> > +} else if (currSubCtrl instanceof TestElement) {
> +nextSubController = (TestElement) currSubCtrl;
> +}
> +
> +if (!(nextSubController.isEnabled()) && (nextSubController 
instanceof Controller || nextSubController instanceof Sampler)) {
> +setNextSubController();
> +}
> +} else {
> +nextSubController = null;
> +}
> +}
> +}
> +
> +/**
> + * This abstraction is necessary for unit tests, in which case a 
deterministic
> + * generator replaces the random one
>
> Why can't seed be used in order to make test consistent?
> There are at least two ways:
> 1) Hard-code seed value right into the test
> 2) Use random seed, and enable configuring the seed from the command line.
> That way if a test with some specific seed value fails, we can reproduce 
it
> by supplying that particular value.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] jmeter issue #233: Bug 60274

2016-11-13 Thread vlsi
Github user vlsi commented on the issue:

https://github.com/apache/jmeter/pull/233
  
While being able to enable-disable and rename the children from WDC UI is 
nice, I wonder how many worms are hidden in that "keep WDC and children tree" 
consistent can.


Nested "Weighted Distribution Controller" elements does not seem to work.

https://cloud.githubusercontent.com/assets/213894/20244397/18f73646-a991-11e6-81bd-945e78f0823a.png;>

https://cloud.githubusercontent.com/assets/213894/20244398/21b7d0f6-a991-11e6-81cc-9f35087a9ce9.png;>

https://cloud.githubusercontent.com/assets/213894/20244400/25cf7d60-a991-11e6-9a44-b737539af738.png;>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---