Re: Anybody working on PR 247

2017-01-22 Thread Philippe Mouawad 
Hi,
I won't have time this afternoon.
If anybody is willing to merge it, let him do.

Otherwise, I'll do it this evening.
There is also 241 , it needs deep review as I'm afraid of side effects and
performance.

Regards
Philippe


On Sun, Jan 22, 2017 at 2:19 PM, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

> Am Sonntag, den 22.01.2017, 13:59 +0100 schrieb Philippe Mouawad:
> > Hi Felix, all,
> > I will start merging PR 247 unless someone is already working on it.
> >
> > If so could you ping me within 30 minutes so that I don't override
> > anybody's work ?
>
> Great, give it a go.
>
> Felix
>
> > Thanks
> > Regards
>



-- 
Cordialement.
Philippe Mouawad.

Re: PR for Bug 55258

2017-01-22 Thread Philippe Mouawad 
Thanks for feedback.
Integrated.
To be uniform, I added new to menu.


On Sun, Jan 22, 2017 at 2:27 PM, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

> Am Sonntag, den 22.01.2017, 14:00 +0100 schrieb Philippe Mouawad:
> > Hello,
> > Any thoughts on this one ?
>
> While I wouldn't mind keeping both icons, it looks like the majority
> wanted to have only one icon and that one should be the "new" icon.
>
> In that light, it looks like the PR is OK.
>
> (I haven't looked at the docs, whether it is mentioned there, though)
>
> Felix
>
> > Thanks
> >
> > On Sun, Jan 15, 2017 at 2:55 PM, Philippe Mouawad <
> > p.moua...@ubik-ingenierie.com> wrote:
> >
> > >
> > > Hello,
> > > Shall we merge :
> > > https://github.com/apache/jmeter/pull/227
> > >
> > > Regards
> > > Philippe
> > >
> > >
> >
>



-- 
Cordialement.
Philippe Mouawad.

[GitHub] jmeter pull request #227: Bug 55258

2017-01-22 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/227


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: PR for Bug 55258

2017-01-22 Thread Felix Schumacher 
Am Sonntag, den 22.01.2017, 14:00 +0100 schrieb Philippe Mouawad:
> Hello,
> Any thoughts on this one ?

While I wouldn't mind keeping both icons, it looks like the majority
wanted to have only one icon and that one should be the "new" icon.

In that light, it looks like the PR is OK.

(I haven't looked at the docs, whether it is mentioned there, though)

Felix

> Thanks
> 
> On Sun, Jan 15, 2017 at 2:55 PM, Philippe Mouawad <
> p.moua...@ubik-ingenierie.com> wrote:
> 
> > 
> > Hello,
> > Shall we merge :
> > https://github.com/apache/jmeter/pull/227
> > 
> > Regards
> > Philippe
> > 
> > 
>

[GitHub] jmeter pull request #255: Utilised Java 8 (and 7) features to tidy up code

2017-01-22 Thread ham1 
Github user ham1 closed the pull request at:

https://github.com/apache/jmeter/pull/255


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #255: Utilised Java 8 (and 7) features to tidy up code

2017-01-22 Thread ham1 
Github user ham1 commented on the issue:

https://github.com/apache/jmeter/pull/255
  
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Anybody working on PR 247

2017-01-22 Thread Felix Schumacher 
Am Sonntag, den 22.01.2017, 13:59 +0100 schrieb Philippe Mouawad:
> Hi Felix, all,
> I will start merging PR 247 unless someone is already working on it.
> 
> If so could you ping me within 30 minutes so that I don't override
> anybody's work ?

Great, give it a go.

Felix

> Thanks
> Regards

Re: PR for Bug 55258

2017-01-22 Thread Philippe Mouawad 
Hello,
Any thoughts on this one ?
Thanks

On Sun, Jan 15, 2017 at 2:55 PM, Philippe Mouawad <
p.moua...@ubik-ingenierie.com> wrote:

> Hello,
> Shall we merge :
> https://github.com/apache/jmeter/pull/227
>
> Regards
> Philippe
>
>


-- 
Cordialement.
Philippe Mouawad.
Ubik-Ingénierie

UBIK LOAD PACK Web Site 

UBIK LOAD PACK on TWITTER

Anybody working on PR 247

2017-01-22 Thread Philippe Mouawad 
Hi Felix, all,
I will start merging PR 247 unless someone is already working on it.

If so could you ping me within 30 minutes so that I don't override
anybody's work ?
Thanks
Regards

[GitHub] jmeter issue #255: Utilised Java 8 (and 7) features to tidy up code

2017-01-22 Thread ham1 
Github user ham1 commented on the issue:

https://github.com/apache/jmeter/pull/255
  
Sorry, updated now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #255: Utilised Java 8 (and 7) features to tidy up code

2017-01-22 Thread FSchumacher 
Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/255
  
Thanks for your contribution.

Looks good, but as usual, I would have liked to see the different cleanups 
in different commits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---