Re: XPath Extractor : Drop Tidy Option

2017-11-18 Thread sebb 
On 18 November 2017 at 22:27, Philippe Mouawad
 wrote:
> On Sat, Nov 18, 2017 at 11:19 PM, sebb  wrote:
>
>> On 16 November 2017 at 19:20, Philippe Mouawad
>>  wrote:
>> > Hello,
>> > Tidy option AFAIK used to allow using XPath Extractor for HTML.
>> > I don't think it's needed anymore since we have CSS/JQuery extractor
>> which
>> > is:
>> > - Up to date
>> > - Powerful
>> > - Performing much better than XPath
>> >
>> > I propose to drop tidy options from XPath.
>> > I even propose to think about dropping jtidy library which would mean :
>> >
>> >- Either Dropping AnchorModifier or finding a better alternative to
>> >jtidy to it if it's useful
>> >
>> > IMO, we should drop it, as it doesn't work  with Distributed testing as
>> it
>> > requires keeping the previous SampleResult response Data to be able to
>> work
>> > which Stripping mode clears.
>>
>> Are you sure about that?
>>
> Yes, it is even documented in a note.
> To be clear,
> PreProcessor of Sampler N+1 requires access to Sample Result of Sampler N
> which would be stripped in distributed mode.
> It affects  Link Parser and Re-writing Modifier:
> -
> http://jmeter.apache.org/usermanual/component_reference.html#HTML_Link_Parser
> -
> http://jmeter.apache.org/usermanual/component_reference.html#HTTP_URL_Re-writing_Modifier
>
> Surely that would break all PostProcessors that process response data?
>>
> No, because the problem is due to access to N-1 sampler's response data,
> not current N Sampler's response data

Unless I am missing something here, I think the way the sample data is
stripped is faulty.

AIUI the purpose of the stripping mode is to reduce the network
overheads, so only the returned data should be affected.

I would expect the server to keep the full data, and only strip the
data from the response.

>>
>> If it is the case, then that is a bug that needs to be fixed.
>>
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Re: BUG 61567

2017-11-18 Thread sebb 
The code is quite complicated, so I would be very wary of changing it.
And it's important not to include jars in the classpath that don't belong.

JMeter runs quite happily if the jars are named anything you like so
long as they are in the lib/ext directory or they are added to the
appropriate path.

So I'm not sure that the Bug is valid.

On 18 November 2017 at 22:42, Philippe Mouawad
 wrote:
> Hello,
> Any thoughts on this ?
> Thanks
>
> On Sat, Nov 11, 2017 at 10:41 PM, Philippe Mouawad <
> p.moua...@ubik-ingenierie.com> wrote:
>
>> Hello,
>> Analyzing bug 61567 , I end up thinking that what we're doing in the below
>> method is not correct:
>>
>>- ClassFinder#getClasspathMatches
>>
>> This method does the following:
>>
>>- It takes a list of jars in search_path
>>- It takes the classpath
>>- For each entry in classpath , it tests if it ends with one of the
>>jar of the first list
>>- If one match is found, the entry will be returned , otherwise it
>>will be ignored
>>
>> So what is triggering the bug is the following, as search_path is empty,
>> only content of lib/ext is used.
>>
>> So first list consist of :
>>
>>- ApacheJMeter_jms.jar
>>ApacheJMeter_junit.jar
>>ApacheJMeter_native.jar
>>ApacheJMeter_ftp.jar
>>ApacheJMeter_components.jar
>>/data/jmeter/jmeters/apache-jmeter-3.3/lib/ext
>>ApacheJMeter_ldap.jar
>>ApacheJMeter_mail.jar
>>ApacheJMeter_tcp.jar
>>ApacheJMeter_http.jar
>>ApacheJMeter_java.jar
>>ApacheJMeter_core.jar
>>ApacheJMeter_functions.jar
>>ApacheJMeter_jdbc.jar
>>ApacheJMeter_mongodb.jar
>>
>> Classpath consists of many entries and specifically , JMeter artifacts end
>> with -3.3.jar
>>
>> None of the entries are added due to endsWith test failing, example:
>>
>> Testing if /MAVEN .m2/repository/org/apache/jmeter/ApacheJMeter_functions/
>> 3.3/ApacheJMeter_functions-3.3.jar ends with ApacheJMeter_jms.jar *will
>> return false*
>>
>> As a consequence, no function is found
>>
>>
>> *One fix would be in JMeter to suffix artifacts in bin and lib/ext with
>> the version number.*
>>
>> *But is this behaviour correct ?*
>>
>> --
>> Regards.
>> Philippe M.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
> Ubik-Ingénierie
>
> UBIK LOAD PACK Web Site 
>
> UBIK LOAD PACK on TWITTER

buildbot failure in on jmeter-trunk

2017-11-18 Thread buildbot 
The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3205

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1815703
Blamelist: agomes

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

Re: BUG 61567

2017-11-18 Thread Philippe Mouawad 
Hello,
Any thoughts on this ?
Thanks

On Sat, Nov 11, 2017 at 10:41 PM, Philippe Mouawad <
p.moua...@ubik-ingenierie.com> wrote:

> Hello,
> Analyzing bug 61567 , I end up thinking that what we're doing in the below
> method is not correct:
>
>- ClassFinder#getClasspathMatches
>
> This method does the following:
>
>- It takes a list of jars in search_path
>- It takes the classpath
>- For each entry in classpath , it tests if it ends with one of the
>jar of the first list
>- If one match is found, the entry will be returned , otherwise it
>will be ignored
>
> So what is triggering the bug is the following, as search_path is empty,
> only content of lib/ext is used.
>
> So first list consist of :
>
>- ApacheJMeter_jms.jar
>ApacheJMeter_junit.jar
>ApacheJMeter_native.jar
>ApacheJMeter_ftp.jar
>ApacheJMeter_components.jar
>/data/jmeter/jmeters/apache-jmeter-3.3/lib/ext
>ApacheJMeter_ldap.jar
>ApacheJMeter_mail.jar
>ApacheJMeter_tcp.jar
>ApacheJMeter_http.jar
>ApacheJMeter_java.jar
>ApacheJMeter_core.jar
>ApacheJMeter_functions.jar
>ApacheJMeter_jdbc.jar
>ApacheJMeter_mongodb.jar
>
> Classpath consists of many entries and specifically , JMeter artifacts end
> with -3.3.jar
>
> None of the entries are added due to endsWith test failing, example:
>
> Testing if /MAVEN .m2/repository/org/apache/jmeter/ApacheJMeter_functions/
> 3.3/ApacheJMeter_functions-3.3.jar ends with ApacheJMeter_jms.jar *will
> return false*
>
> As a consequence, no function is found
>
>
> *One fix would be in JMeter to suffix artifacts in bin and lib/ext with
> the version number.*
>
> *But is this behaviour correct ?*
>
> --
> Regards.
> Philippe M.
>



-- 
Cordialement.
Philippe Mouawad.
Ubik-Ingénierie

UBIK LOAD PACK Web Site 

UBIK LOAD PACK on TWITTER

Re: XPath Extractor : Drop Tidy Option

2017-11-18 Thread Philippe Mouawad 
On Sat, Nov 18, 2017 at 11:19 PM, sebb  wrote:

> On 16 November 2017 at 19:20, Philippe Mouawad
>  wrote:
> > Hello,
> > Tidy option AFAIK used to allow using XPath Extractor for HTML.
> > I don't think it's needed anymore since we have CSS/JQuery extractor
> which
> > is:
> > - Up to date
> > - Powerful
> > - Performing much better than XPath
> >
> > I propose to drop tidy options from XPath.
> > I even propose to think about dropping jtidy library which would mean :
> >
> >- Either Dropping AnchorModifier or finding a better alternative to
> >jtidy to it if it's useful
> >
> > IMO, we should drop it, as it doesn't work  with Distributed testing as
> it
> > requires keeping the previous SampleResult response Data to be able to
> work
> > which Stripping mode clears.
>
> Are you sure about that?
>
Yes, it is even documented in a note.
To be clear,
PreProcessor of Sampler N+1 requires access to Sample Result of Sampler N
which would be stripped in distributed mode.
It affects  Link Parser and Re-writing Modifier:
-
http://jmeter.apache.org/usermanual/component_reference.html#HTML_Link_Parser
-
http://jmeter.apache.org/usermanual/component_reference.html#HTTP_URL_Re-writing_Modifier

Surely that would break all PostProcessors that process response data?
>
No, because the problem is due to access to N-1 sampler's response data,
not current N Sampler's response data

>
> If it is the case, then that is a bug that needs to be fixed.
>
> > --
> > Cordialement.
> > Philippe Mouawad.
>



-- 
Cordialement.
Philippe Mouawad.

Re: XPath Extractor : Drop Tidy Option

2017-11-18 Thread sebb 
On 16 November 2017 at 19:20, Philippe Mouawad
 wrote:
> Hello,
> Tidy option AFAIK used to allow using XPath Extractor for HTML.
> I don't think it's needed anymore since we have CSS/JQuery extractor which
> is:
> - Up to date
> - Powerful
> - Performing much better than XPath
>
> I propose to drop tidy options from XPath.
> I even propose to think about dropping jtidy library which would mean :
>
>- Either Dropping AnchorModifier or finding a better alternative to
>jtidy to it if it's useful
>
> IMO, we should drop it, as it doesn't work  with Distributed testing as it
> requires keeping the previous SampleResult response Data to be able to work
> which Stripping mode clears.

Are you sure about that?
Surely that would break all PostProcessors that process response data?

If it is the case, then that is a bug that needs to be fixed.

> --
> Cordialement.
> Philippe Mouawad.

buildbot success in on jmeter-trunk

2017-11-18 Thread buildbot 
The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3204

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1815698
Blamelist: pmouawad

Build succeeded!

Sincerely,
 -The Buildbot

Build failed in Jenkins: JMeter Windows #881

2017-11-18 Thread Apache Jenkins Server 
See 


Changes:

[pmouawad] Bug 61544 - JMS Point-to-Point Sampler: Enhance communication styles 
with read, browse, clear
This closes #325
Fix persistence and add tests
Bugzilla Id: 61544

[fschumacher] set svn:eol-style to native

[agomes] [Bug 61775] Add a link to help menu to download nighty builds (it open 
the browser with the correct link) - add missing new line

[pmouawad] Bug 61544 - JMS Point-to-Point Sampler: Enhance communication styles 
with read, browse, clear
Bugzilla Id: 61544

--
[...truncated 173.65 KB...]
   [concat] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_152]
   [concat] 2017-11-18 22:07:16,416 WARN o.a.j.p.j.p.AbstractJDBCProcessor: SQL 
Problem in JDBC PreProcessor: java.sql.SQLSyntaxErrorException: unexpected 
token: USERS
   [concat] 2017-11-18 22:07:16,428 WARN o.a.j.p.j.p.AbstractJDBCProcessor: SQL 
Problem in JDBC PostProcessor: java.sql.SQLSyntaxErrorException: unexpected 
token: USERS
 [echo] JDBC_TESTS output files compared OK

batchtest:
 [echo] Starting JMS_TESTS with file JMS_TESTS.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/log4j-slf4j-impl-2.8.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/opt/activemq-all-5.15.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/JMS_TESTS.jmx
   [jmeter] Starting the test @ Sat Nov 18 22:07:19 UTC 2017 (1511042839855)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary + 11 in 00:00:11 =1.0/s Avg:   498 Min: 2 Max:  
2874 Err: 0 (0.00%) Active: 1 Started: 1 Finished: 0
   [jmeter] summary + 15 in 00:00:25 =0.6/s Avg:   611 Min: 0 Max:  
3001 Err: 2 (13.33%) Active: 0 Started: 1 Finished: 1
   [jmeter] summary = 26 in 00:00:36 =0.7/s Avg:   563 Min: 0 Max:  
3001 Err: 2 (7.69%)
   [jmeter] Tidying up ...@ Sat Nov 18 22:07:57 UTC 2017 (1511042877214)
   [jmeter] ... end of run
Target 'batchtest' failed with message 'CSV Files are not identical.



label,responseCode,responseMessage,threadName,dataType,success,grpThreads,allThreads,SampleCount,ErrorCount
BSS_startActiveMQ,200,OK,setUp Thread Group 1-1,text,true,1,1,1,0
JMS-P2P-DefaultCorrelationId,200,OK,TG-JMS-P2P 1-1,text,true,1,1,1,0
JSS-ConsumeUpcomingMessage,200,OK,TG-JMS-P2P 1-1,text,true,1,1,1,0
JMS-P2P-DefaultCorrelationId-TempQueue,200,OK,TG-JMS-P2P 1-1,text,true,1,1,1,0
JMS-P2P-CustomCorrelationId,200,OK,TG-JMS-P2P 1-1,text,true,1,1,1,0
JMS-P2P-DifferentSelector,,No reply message received,TG-JMS-P2P 
1-1,text,true,1,1,1,0
JMS-P2P-SameSelector,200,OK,TG-JMS-P2P 1-1,text,true,1,1,1,0
JMS-P2P-RequestOnly,200,OK,TG-JMS-P2P 1-1,text,true,1,1,1,0
JSS-ConsumePreviousMessage,200,OK,TG-JMS-P2P 1-1,text,true,1,1,1,0
JMS-P2P-RequestOnly,200,OK,TG-JMS-P2P 1-1,text,true,1,1,1,0
JMS-P2P-Browse,200,1 messages available on the queue,TG-JMS-P2P 
1-1,text,true,1,1,1,0
JMS-P2P-Read,200,1 message(s) received successfully,TG-JMS-P2P 
1-1,text,true,1,1,1,0
JMS-P2P-RequestOnlyForClear,200,OK,TG-JMS-P2P 1-1,text,true,1,1,1,0
JMS-P2P-Clear,200,1 message(s) removed,TG-JMS-P2P 1-1,text,true,1,1,1,0
JMS-P2P-BrowseAfterClear,200,0 messages available on the queue,TG-JMS-P2P 
1-1,text,true,1,1,1,0
JMS Publisher-NonDurable,200,1 messages published,TG-JMS-PS 2-1,,true,1,1,1,0
JMS Subscriber-NonDurable,200,1 message(s) received successfully of 1 
expected,TG-JMS-PS 2-1,text,true,1,1,1,0
JMS Publisher-Persistent,200,1 messages published,TG-JMS-PS-Selector-receive 
3-1,,true,1,1,1,0
JMS Subscriber-NonMatchingSelector,404,0 message(s) received successfully of 1 
expected,TG-JMS-PS-Selector-receive 3-1,text,true,1,1,0,0
JMS Subscriber-at-startup-onMessage,200,1 message(s) received successfully of 1 
expected,TG-JMS-PS-Selector-receive 3-1,text,true,1,1,1,0
JMS Publisher-Persistent,200,1 messages published,TG-JMS-PS-Selector-onMessage 
4-1,,true,1,1,1,0
JMS Subscriber-NonMatchingSelector-receive,404,0 message(s) received 
successfully of 1 expected,TG-JMS-PS-Selector-onMessage 4-1,text,true,1,1,0,0
JMS Subscriber-MatchingSelector-receive,200,1 message(s) received successfully 
of 1 expected,TG-JMS-PS-Selector-onMessage 4-1,text,true,1,1,1,0
JMS Publisher-Persistent,200,1 messages published,TG-JMS-PS-Durable 
5-1,,true,1,1,1,0
JMS

[GitHub] jmeter pull request #325: 61544 - Added read, browse and clear as communicat...

2017-11-18 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/325


---

buildbot failure in on jmeter-trunk

2017-11-18 Thread buildbot 
The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3201

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1815692
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

Build failed in Jenkins: JMeter Windows #880

2017-11-18 Thread Apache Jenkins Server 
See 


Changes:

[agomes] [Bug 61775] Add a link to help menu to download nighty builds (it open 
the browser with the correct link) - add missing file

--
[...truncated 176.50 KB...]
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary +  2 in 00:00:03 =0.7/s Avg:   811 Min:   145 Max:  
1478 Err: 0 (0.00%) Active: 1 Started: 1 Finished: 0
   [jmeter] summary +  4 in 00:00:00 =   26.5/s Avg:31 Min:17 Max:  
  69 Err: 0 (0.00%) Active: 0 Started: 1 Finished: 1
   [jmeter] summary =  6 in 00:00:03 =2.0/s Avg:   291 Min:17 Max:  
1478 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Nov 18 20:20:00 UTC 2017 (1511036400919)
   [jmeter] ... end of run
 [echo] FTP_TESTS output files compared OK

batchtest:
 [echo] Starting Bug60607 with file Bug60607.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/log4j-slf4j-impl-2.8.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/opt/activemq-all-5.15.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/Bug60607.jmx
   [jmeter] Starting the test @ Sat Nov 18 20:20:04 UTC 2017 (1511036404352)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary +  1 in 00:00:01 =1.7/s Avg:   264 Min:   264 Max:  
 264 Err: 0 (0.00%) Active: 1 Started: 1 Finished: 0
   [jmeter] summary +  1 in 00:00:30 =0.0/s Avg: 30117 Min: 30117 Max: 
30117 Err: 0 (0.00%) Active: 0 Started: 2 Finished: 2
   [jmeter] summary =  2 in 00:00:31 =0.1/s Avg: 15190 Min:   264 Max: 
30117 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Nov 18 20:20:36 UTC 2017 (1511036436121)
   [jmeter] ... end of run
 [echo] Bug60607 output files compared OK

batchtest:
 [echo] Starting SlowCharsFeature_HttpClient4 with file 
SlowCharsFeature.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/log4j-slf4j-impl-2.8.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/opt/activemq-all-5.15.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/SlowCharsFeature.jmx
   [jmeter] Starting the test @ Sat Nov 18 20:20:40 UTC 2017 (1511036440402)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary =  3 in 00:00:18 =0.2/s Avg:  5835 Min:   696 Max: 
11018 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Nov 18 20:20:59 UTC 2017 (1511036459351)
   [jmeter] ... end of run
 [echo] SlowCharsFeature_HttpClient4 output files compared OK

batchtest:
 [echo] Starting SlowCharsFeature_Java with file SlowCharsFeature.jmx using 
-X -Jjmeter.httpsampler=Java
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/log4j-slf4j-impl-2.8.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/opt/activemq-all-5.15.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/SlowCharsFeature.jmx
   [jmeter] Starting the test @ Sat Nov 18 20:21:03 UTC 2017 (1511036463611)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary +  1 in 00:00:01 =1.3/s Avg:   697 Min:   697 Max:  
 697 Err: 0 (0.00%) Active: 1 Started: 1 Finished: 0
   [jmeter] summary +  1 in 00:00:12 =0.1/s Avg: 11598 Min: 11598 Max: 
11598 Err: 0 (0.00%) Active: 0 Started: 1 Finished: 1
   [jmeter] summary =

[GitHub] jmeter pull request #331: Removed (some more) commented out code

2017-11-18 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/331


---

[GitHub] jmeter pull request #328: Improve wording and formatting of jmeter.propertie...

2017-11-18 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/328


---

[GitHub] jmeter pull request #294: Add expand/collapse all menu in render XML view

2017-11-18 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/294


---

[GitHub] jmeter pull request #329: Expansion of "Add expand/collapse all menu in rend...

2017-11-18 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/329


---

Jenkins build is back to normal : JMeter Windows #878

2017-11-18 Thread Apache Jenkins Server 
See

Build failed in Jenkins: JMeter Windows #877

2017-11-18 Thread Apache Jenkins Server 
See 


Changes:

[pmouawad] Add new line at end of file

[pmouawad] Remove unused import

--
[...truncated 176.90 KB...]
   [jmeter] Starting the test @ Sat Nov 18 12:20:00 UTC 2017 (1511007600720)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary +  1 in 00:00:02 =0.6/s Avg:  1589 Min:  1589 Max:  
1589 Err: 0 (0.00%) Active: 1 Started: 1 Finished: 0
   [jmeter] summary +  5 in 00:00:02 =3.3/s Avg:57 Min:14 Max:  
 154 Err: 0 (0.00%) Active: 0 Started: 1 Finished: 1
   [jmeter] summary =  6 in 00:00:03 =1.9/s Avg:   312 Min:14 Max:  
1589 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Nov 18 12:20:05 UTC 2017 (1511007605451)
   [jmeter] ... end of run
 [echo] FTP_TESTS output files compared OK

batchtest:
 [echo] Starting Bug60607 with file Bug60607.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/log4j-slf4j-impl-2.8.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/opt/activemq-all-5.15.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/Bug60607.jmx
   [jmeter] Starting the test @ Sat Nov 18 12:20:08 UTC 2017 (1511007608764)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary =  2 in 00:00:31 =0.1/s Avg: 15315 Min:   509 Max: 
30121 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Nov 18 12:20:40 UTC 2017 (1511007640615)
   [jmeter] ... end of run
 [echo] Bug60607 output files compared OK

batchtest:
 [echo] Starting SlowCharsFeature_HttpClient4 with file 
SlowCharsFeature.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/log4j-slf4j-impl-2.8.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/opt/activemq-all-5.15.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/SlowCharsFeature.jmx
   [jmeter] Starting the test @ Sat Nov 18 12:20:44 UTC 2017 (1511007644766)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary +  3 in 00:00:19 =0.2/s Avg:  6042 Min:   679 Max: 
11529 Err: 0 (0.00%) Active: 1 Started: 1 Finished: 0
   [jmeter] summary =  3 in 00:00:19 =0.2/s Avg:  6042 Min:   679 Max: 
11529 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Nov 18 12:21:04 UTC 2017 (1511007664291)
   [jmeter] ... end of run
 [echo] SlowCharsFeature_HttpClient4 output files compared OK

batchtest:
 [echo] Starting SlowCharsFeature_Java with file SlowCharsFeature.jmx using 
-X -Jjmeter.httpsampler=Java
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/log4j-slf4j-impl-2.8.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/opt/activemq-all-5.15.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/SlowCharsFeature.jmx
   [jmeter] Starting the test @ Sat Nov 18 12:21:08 UTC 2017 (1511007668493)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary =  2 in 00:00:13 =0.2/s Avg:  6342 Min:   664 Max: 
12021 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Nov 18 12:21:22 UTC 2017 (1511007682471)
   [jmeter] ... end of run
 [echo] SlowCharsFeature_Java output files compared OK

batchtest:
 [echo] Starting Http4ImplPreemptiveBasicAuth with file 
Http4ImplPreemptiveBasicAuth.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class

[GitHub] jmeter issue #331: Removed (some more) commented out code

2017-11-18 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/331
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=h1) 
Report
> Merging 
[#331](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/50d617565ccd626aa3c24881971732b9077f8b35?src=pr=desc)
 will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/331/graphs/tree.svg?width=650=150=pr=6Q7CI1wFSh)](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #331  +/-   ##

- Coverage 57.84%   57.84%   -0.01% 
+ Complexity 9938 9937   -1 

  Files  1142 1142  
  Lines 7324373243  
  Branches   7281 7281  

- Hits  4237042368   -2 
- Misses2840428405   +1 
- Partials   2469 2470   +1
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...rg/apache/jmeter/util/keystore/JmeterKeyStore.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9rZXlzdG9yZS9KbWV0ZXJLZXlTdG9yZS5qYXZh)
 | `19.54% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| 
[...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==)
 | `85.38% <ø> (ø)` | `18 <0> (ø)` | :arrow_down: |
| 
[...pache/jmeter/samplers/StatisticalSampleSender.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvc2FtcGxlcnMvU3RhdGlzdGljYWxTYW1wbGVTZW5kZXIuamF2YQ==)
 | `32.05% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| 
[src/core/org/apache/jmeter/util/SSLManager.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9TU0xNYW5hZ2VyLmphdmE=)
 | `31.86% <ø> (ø)` | `10 <0> (ø)` | :arrow_down: |
| 
[src/core/org/apache/jmeter/util/JMeterUtils.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9KTWV0ZXJVdGlscy5qYXZh)
 | `46.71% <ø> (ø)` | `62 <0> (ø)` | :arrow_down: |
| 
[...he/jmeter/visualizers/backend/BackendListener.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvYmFja2VuZC9CYWNrZW5kTGlzdGVuZXIuamF2YQ==)
 | `10.34% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |
| 
[.../core/org/apache/jmeter/samplers/SampleResult.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvc2FtcGxlcnMvU2FtcGxlUmVzdWx0LmphdmE=)
 | `77.1% <ø> (ø)` | `127 <0> (ø)` | :arrow_down: |
| 
[...ions/org/apache/jmeter/functions/XPathWrapper.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=tree#diff-c3JjL2Z1bmN0aW9ucy9vcmcvYXBhY2hlL2ptZXRlci9mdW5jdGlvbnMvWFBhdGhXcmFwcGVyLmphdmE=)
 | `95.45% <ø> (ø)` | `9 <0> (ø)` | :arrow_down: |
| 
[...rc/core/org/apache/jmeter/services/FileServer.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvc2VydmljZXMvRmlsZVNlcnZlci5qYXZh)
 | `71.21% <ø> (ø)` | `56 <0> (ø)` | :arrow_down: |
| 
[...pache/jmeter/samplers/SampleSaveConfiguration.java](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvc2FtcGxlcnMvU2FtcGxlU2F2ZUNvbmZpZ3VyYXRpb24uamF2YQ==)
 | `68.38% <ø> (ø)` | `95 <0> (ø)` | :arrow_down: |
| ... and [6 
more](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=tree-more) | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=footer). Last 
update 
[50d6175...b60d1b7](https://codecov.io/gh/apache/jmeter/pull/331?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter pull request #331: Removed (some more) commented out code

2017-11-18 Thread ham1 
GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/331

Removed (some more) commented out code

## Description
Removing more commented out code

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter remove_commented_out_code

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #331


commit b60d1b77903d881465295d56199a93b835b305c4
Author: Graham Russell 
Date:   2017-11-18T09:47:23Z

Removed commented out code




---

Re: XPath Extractor : Drop Tidy Option

2017-11-18 Thread Philippe Mouawad 
Hi ,
@Graham, would you propose a PR to:
- deprecate the properties in GUI
- amend documentation to say it will be dropped  in N+2 and what is the
correct way

If you want to ask on user mailing list, feel free to do so.
Even if users use it, they should move out of it, but I am ok with the 2
steps process (Deprecate in N+1, Remove in N+2).

Thanks

On Sat, Nov 18, 2017 at 12:32 PM, Graham Russell  wrote:

> +0
>
> I agree that CSS should be preferred for HTML and, in general, I'm in
> favour of removing seldom used/broken bits of functionality which don't
> warrant the cost of keeping them around, but I don't know enough about it
> nor how often XPath is currently used by people to say +1 for this yet.
>
> Maybe worth deprecating it and emailing the user mailing list to see the
> reaction?
>
> Graham
>
> On 16 November 2017 at 19:20, Philippe Mouawad  >
> wrote:
> > Hello,
> > Tidy option AFAIK used to allow using XPath Extractor for HTML.
> > I don't think it's needed anymore since we have CSS/JQuery extractor
> which
> > is:
> > - Up to date
> > - Powerful
> > - Performing much better than XPath
> >
> > I propose to drop tidy options from XPath.
> > I even propose to think about dropping jtidy library which would mean :
> >
> >- Either Dropping AnchorModifier or finding a better alternative to
> >jtidy to it if it's useful
> >
> > IMO, we should drop it, as it doesn't work  with Distributed testing as
> it
> > requires keeping the previous SampleResult response Data to be able to
> work
> > which Stripping mode clears.
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>



-- 
Cordialement.
Philippe Mouawad.

Re: XPath Extractor : Drop Tidy Option

2017-11-18 Thread Graham Russell 
+0

I agree that CSS should be preferred for HTML and, in general, I'm in
favour of removing seldom used/broken bits of functionality which don't
warrant the cost of keeping them around, but I don't know enough about it
nor how often XPath is currently used by people to say +1 for this yet.

Maybe worth deprecating it and emailing the user mailing list to see the
reaction?

Graham

On 16 November 2017 at 19:20, Philippe Mouawad 
wrote:
> Hello,
> Tidy option AFAIK used to allow using XPath Extractor for HTML.
> I don't think it's needed anymore since we have CSS/JQuery extractor which
> is:
> - Up to date
> - Powerful
> - Performing much better than XPath
>
> I propose to drop tidy options from XPath.
> I even propose to think about dropping jtidy library which would mean :
>
>- Either Dropping AnchorModifier or finding a better alternative to
>jtidy to it if it's useful
>
> IMO, we should drop it, as it doesn't work  with Distributed testing as it
> requires keeping the previous SampleResult response Data to be able to
work
> which Stripping mode clears.
>
> --
> Cordialement.
> Philippe Mouawad.

Build failed in Jenkins: JMeter Windows #876

2017-11-18 Thread Apache Jenkins Server 
See 


Changes:

[agomes] [Bug 61775] New: Add a link to help menu to download nighty builds (it 
open the browser with the correct link)

--
[...truncated 177.12 KB...]
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary =  6 in 00:00:03 =2.0/s Avg:   299 Min:15 Max:  
1519 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Nov 18 11:22:43 UTC 2017 (1511004163543)
   [jmeter] ... end of run
 [echo] FTP_TESTS output files compared OK

batchtest:
 [echo] Starting Bug60607 with file Bug60607.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/log4j-slf4j-impl-2.8.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/opt/activemq-all-5.15.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/Bug60607.jmx
   [jmeter] Starting the test @ Sat Nov 18 11:22:47 UTC 2017 (1511004167077)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary =  2 in 00:00:31 =0.1/s Avg: 15313 Min:   509 Max: 
30118 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Nov 18 11:23:19 UTC 2017 (1511004199041)
   [jmeter] ... end of run
 [echo] Bug60607 output files compared OK

batchtest:
 [echo] Starting SlowCharsFeature_HttpClient4 with file 
SlowCharsFeature.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/log4j-slf4j-impl-2.8.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/opt/activemq-all-5.15.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/SlowCharsFeature.jmx
   [jmeter] Starting the test @ Sat Nov 18 11:23:23 UTC 2017 (1511004203381)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary +  2 in 00:00:07 =0.3/s Avg:  3311 Min:   685 Max:  
5937 Err: 0 (0.00%) Active: 1 Started: 1 Finished: 0
   [jmeter] summary +  1 in 00:00:12 =0.1/s Avg: 11544 Min: 11544 Max: 
11544 Err: 0 (0.00%) Active: 0 Started: 1 Finished: 1
   [jmeter] summary =  3 in 00:00:19 =0.2/s Avg:  6055 Min:   685 Max: 
11544 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Nov 18 11:23:43 UTC 2017 (1511004223021)
   [jmeter] ... end of run
 [echo] SlowCharsFeature_HttpClient4 output files compared OK

batchtest:
 [echo] Starting SlowCharsFeature_Java with file SlowCharsFeature.jmx using 
-X -Jjmeter.httpsampler=Java
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/log4j-slf4j-impl-2.8.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/opt/activemq-all-5.15.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/SlowCharsFeature.jmx
   [jmeter] Starting the test @ Sat Nov 18 11:23:47 UTC 2017 (1511004227411)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary +  2 in 00:00:13 =0.2/s Avg:  6358 Min:   684 Max: 
12032 Err: 0 (0.00%) Active: 1 Started: 1 Finished: 0
   [jmeter] summary =  2 in 00:00:13 =0.2/s Avg:  6358 Min:   684 Max: 
12032 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sat Nov 18 11:24:01 UTC 2017 (1511004241544)
   [jmeter] ... end of run
 [echo] SlowCharsFeature_Java output files compared OK

batchtest:
 [echo] Starting Http4ImplPreemptiveBasicAuth with file 
Http4ImplPreemptiveBasicAuth.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class path contains multiple SLF4J